From: Nizamudeen A Date: Wed, 23 Jul 2025 11:09:46 +0000 (+0530) Subject: mgr/dashboard: fix table loading while fetching data X-Git-Tag: v20.1.1~87^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F65110%2Fhead;p=ceph.git mgr/dashboard: fix table loading while fetching data don't stop loading until all the data is properly fetched Fixes: https://tracker.ceph.com/issues/64170 Signed-off-by: Nizamudeen A (cherry picked from commit fb713c9130a708450c08a17fa6494970e6f1922e) --- diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts index 787d0417331..8494f70a965 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts @@ -562,9 +562,9 @@ export class TableComponent implements AfterViewInit, OnInit, OnChanges, OnDestr // this method was triggered by ngOnChanges(). if (this.fetchData.observers.length > 0) { this.loadingIndicator = true; - const loadingSubscription = this.fetchData.subscribe(() => { - this.loadingIndicator = false; - this.cdRef.detectChanges(); + const loadingSubscription = this.fetchData.subscribe({ + next: () => this.cdRef.detectChanges(), + complete: () => (this.loadingIndicator = false) }); this._subscriptions.add(loadingSubscription); }