From: Edwin Rodriguez <edwin.rodriguez1@ibm.com>
Date: Wed, 8 Oct 2025 16:20:36 +0000 (-0400)
Subject: mds: Remove unnecessary std::move on const expression in MetricsHandler::handle_payload
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F65884%2Fhead;p=ceph.git

mds: Remove unnecessary std::move on const expression in MetricsHandler::handle_payload

Fixes: https://tracker.ceph.com/issues/73430
Signed-off-by: Edwin Rodriguez <edwin.rodriguez1@ibm.com>
---

diff --git a/src/mds/MetricsHandler.cc b/src/mds/MetricsHandler.cc
index a67e90134a9..23811a42a75 100644
--- a/src/mds/MetricsHandler.cc
+++ b/src/mds/MetricsHandler.cc
@@ -368,7 +368,9 @@ std::chrono::steady_clock::now().time_since_epoch()).count());
     auto& vec = subvolume_metrics_map[path];
 
     dout(20) << " accumulating subv_metric " << payload.subvolume_metrics[i] << dendl;
-    vec.emplace_back(std::move(payload.subvolume_metrics[i]));
+    // std::move of the const expression of the trivially-copyable type 'const value_type'
+    // (aka 'const AggregatedIOMetrics') has no effect; remove std::move()
+    vec.emplace_back(payload.subvolume_metrics[i]);
     vec.back().time_stamp = now_ms;
   }
 }