From: Ilya Dryomov <idryomov@gmail.com>
Date: Mon, 16 Feb 2026 21:24:47 +0000 (+0100)
Subject: librbd/cache/pwl: WriteLogOperationSet::cell can be garbage
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F67368%2Fhead;p=ceph.git

librbd/cache/pwl: WriteLogOperationSet::cell can be garbage

The pointer is never initialized but gets printed by operator<<.
Luckily outside of that it's unused.

Fixes: https://tracker.ceph.com/issues/74971
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---

diff --git a/src/librbd/cache/pwl/LogOperation.cc b/src/librbd/cache/pwl/LogOperation.cc
index 8e5f6673439..61ba1b3724a 100644
--- a/src/librbd/cache/pwl/LogOperation.cc
+++ b/src/librbd/cache/pwl/LogOperation.cc
@@ -268,8 +268,7 @@ WriteLogOperationSet::~WriteLogOperationSet() { }
 
 std::ostream &operator<<(std::ostream &os,
                          const WriteLogOperationSet &s) {
-  os << "cell=" << (void*)s.cell
-     << ", extent_ops_appending=" << s.extent_ops_appending
+  os << "extent_ops_appending=" << s.extent_ops_appending
      << ", extent_ops_persist=" << s.extent_ops_persist;
   return os;
 }
diff --git a/src/librbd/cache/pwl/LogOperation.h b/src/librbd/cache/pwl/LogOperation.h
index 8ecd53d198d..7cb98cbe17b 100644
--- a/src/librbd/cache/pwl/LogOperation.h
+++ b/src/librbd/cache/pwl/LogOperation.h
@@ -169,7 +169,6 @@ private:
   Context *m_on_finish;
 public:
   bool persist_on_flush;
-  BlockGuardCell *cell;
   C_Gather *extent_ops_appending;
   Context *on_ops_appending;
   C_Gather *extent_ops_persist;