From: Sage Weil <sage@inktank.com>
Date: Thu, 10 Oct 2013 14:10:16 +0000 (-0700)
Subject: osdc/Objecter: clean up completion handlers that set *prval=0
X-Git-Tag: v0.72-rc1~66^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F711%2Fhead;p=ceph.git

osdc/Objecter: clean up completion handlers that set *prval=0

If the OSD operations returns 0, these are unnecessary.  If it does not,
then these are misleading.  In both cases here, the OSD sets the result to
zero, so this has no client-visible change.r

Signed-off-by: Sage Weil <sage@inktank.com>
---

diff --git a/src/osdc/Objecter.h b/src/osdc/Objecter.h
index 8a6c243d339a..938c97a4f311 100644
--- a/src/osdc/Objecter.h
+++ b/src/osdc/Objecter.h
@@ -386,7 +386,6 @@ struct ObjectOperation {
               pwatchers->push_back(ow);
             }
           }
-          *prval = 0;
 	}
 	catch (buffer::error& e) {
 	  if (prval)
@@ -424,8 +423,6 @@ struct ObjectOperation {
             }
 	    psnaps->seq = resp.seq;
           }
-          if (prval)
-	    *prval = 0;
 	}
 	catch (buffer::error& e) {
 	  if (prval)