From: Kefu Chai Date: Thu, 21 Jan 2016 04:52:54 +0000 (+0800) Subject: SubmittingPatches: rebase to resolve conflicts X-Git-Tag: v10.0.4~189^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F7292%2Fhead;p=ceph.git SubmittingPatches: rebase to resolve conflicts pull request is not supposed to contain merge commits Signed-off-by: Kefu Chai --- diff --git a/SubmittingPatches.rst b/SubmittingPatches.rst index 3e2624bbcb3c..87855d5f813b 100644 --- a/SubmittingPatches.rst +++ b/SubmittingPatches.rst @@ -258,6 +258,19 @@ feature. to ping the reviewer again or comment on the pull request to ensure the updates are noticed. + Sometimes your change could be based on an outdated parent commit and has + conflicts with the latest target branch, then you need to fetch the updates + from the remote branch, rebase your change onto it, and resolve the conflicts + before doing the force-push + + .. code-block:: bash + + $ git pull --rebase origin target-branch + + So that the pull request does not contain any "merge" commit. Instead of "merging" + the target branch, we expect a linear history in a pull request where you + commit on top of the remote branch. + Q: Which branch should I target in my pull request? A: The target branch depends on the nature of your change: