From: Radoslaw Zarzynski Date: Wed, 17 Feb 2016 17:30:06 +0000 (+0100) Subject: rgw: remove unnecessary overloads in RGWHTTPArgs. X-Git-Tag: v10.1.0~364^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F7666%2Fhead;p=ceph.git rgw: remove unnecessary overloads in RGWHTTPArgs. Signed-off-by: Radoslaw Zarzynski --- diff --git a/src/rgw/rgw_common.cc b/src/rgw/rgw_common.cc index 11b16f168725..98b091edff20 100644 --- a/src/rgw/rgw_common.cc +++ b/src/rgw/rgw_common.cc @@ -659,13 +659,6 @@ string& RGWHTTPArgs::get(const string& name, bool *exists) return empty_str; } -string& RGWHTTPArgs::get(const char *name, bool *exists) -{ - string s(name); - return get(s, exists); -} - - int RGWHTTPArgs::get_bool(const string& name, bool *val, bool *exists) { map::iterator iter; @@ -716,11 +709,6 @@ string RGWHTTPArgs::sys_get(const string& name, bool * const exists) return e ? iter->second : string(); } -string RGWHTTPArgs::sys_get(const char * const name, bool * const exists) -{ - return sys_get(string(name), exists); -} - bool verify_requester_payer_permission(struct req_state *s) { if (!s->bucket_info.requester_pays) diff --git a/src/rgw/rgw_common.h b/src/rgw/rgw_common.h index e22ed281a076..628fd26b4ed8 100644 --- a/src/rgw/rgw_common.h +++ b/src/rgw/rgw_common.h @@ -292,14 +292,12 @@ class RGWHTTPArgs int parse(); /** Get the value for a specific argument parameter */ string& get(const string& name, bool *exists = NULL); - string& get(const char *name, bool *exists = NULL); int get_bool(const string& name, bool *val, bool *exists); int get_bool(const char *name, bool *val, bool *exists); void get_bool(const char *name, bool *val, bool def_val); /** Get the value for specific system argument parameter */ string sys_get(const string& name, bool *exists = nullptr); - string sys_get(const char *name, bool *exists = nullptr); /** see if a parameter is contained in this RGWHTTPArgs */ bool exists(const char *name) {