From: Sage Weil <sage@inktank.com>
Date: Sat, 2 Nov 2013 06:56:45 +0000 (-0700)
Subject: mon/PGMap: use const ref, not pass-by-value
X-Git-Tag: v0.72~15^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F809%2Fhead;p=ceph.git

mon/PGMap: use const ref, not pass-by-value

Signed-off-by: Sage Weil <sage@inktank.com>
---

diff --git a/src/mon/PGMap.cc b/src/mon/PGMap.cc
index ab4c885df4c0..2ba8402b34f6 100644
--- a/src/mon/PGMap.cc
+++ b/src/mon/PGMap.cc
@@ -787,7 +787,7 @@ void PGMap::print_osd_perf_stats(std::ostream *ss) const
 }
 
 void PGMap::recovery_summary(Formatter *f, ostream *out,
-                             pool_stat_t delta_sum) const
+                             const pool_stat_t& delta_sum) const
 {
   bool first = true;
   if (delta_sum.stats.sum.num_objects_degraded) {
@@ -825,7 +825,7 @@ void PGMap::recovery_summary(Formatter *f, ostream *out,
 }
 
 void PGMap::recovery_rate_summary(Formatter *f, ostream *out,
-                                  pool_stat_t delta_sum,
+                                  const pool_stat_t& delta_sum,
                                   utime_t delta_stamp) const
 {
   // make non-negative; we can get negative values if osds send
@@ -886,7 +886,7 @@ void PGMap::pool_recovery_summary(Formatter *f, ostream *out,
 }
 
 void PGMap::client_io_rate_summary(Formatter *f, ostream *out,
-                                   pool_stat_t delta_sum,
+                                   const pool_stat_t& delta_sum,
                                    utime_t delta_stamp) const
 {
   pool_stat_t pos_delta = delta_sum;
diff --git a/src/mon/PGMap.h b/src/mon/PGMap.h
index c8ce7fd973eb..8a931ecbcca6 100644
--- a/src/mon/PGMap.h
+++ b/src/mon/PGMap.h
@@ -244,12 +244,12 @@ public:
   void print_osd_perf_stats(std::ostream *ss) const;
 
   void recovery_summary(Formatter *f, ostream *out,
-                        pool_stat_t delta_sum) const;
+                        const pool_stat_t& delta_sum) const;
   void overall_recovery_summary(Formatter *f, ostream *out) const;
   void pool_recovery_summary(Formatter *f, ostream *out,
                              uint64_t poolid) const;
   void recovery_rate_summary(Formatter *f, ostream *out,
-                             pool_stat_t delta_sum,
+                             const pool_stat_t& delta_sum,
                              utime_t delta_stamp) const;
   void overall_recovery_rate_summary(Formatter *f, ostream *out) const;
   void pool_recovery_rate_summary(Formatter *f, ostream *out,
@@ -259,7 +259,7 @@ public:
    * given @p delta_sum pool over a given @p delta_stamp period of time.
    */
   void client_io_rate_summary(Formatter *f, ostream *out,
-                              pool_stat_t delta_sum,
+                              const pool_stat_t& delta_sum,
                               utime_t delta_stamp) const;
   /**
    * Obtain a formatted/plain output for the overall client I/O, which is