From: Dan van der Ster <daniel.vanderster@cern.ch>
Date: Fri, 22 Apr 2016 09:19:30 +0000 (+0200)
Subject: osd: fix backwards min/max osd utilization
X-Git-Tag: v11.0.0~879^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F8696%2Fhead;p=ceph.git

osd: fix backwards min/max osd utilization

Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
---

diff --git a/src/osd/OSDMap.cc b/src/osd/OSDMap.cc
index 3d06df65b32a..7961d2f96771 100644
--- a/src/osd/OSDMap.cc
+++ b/src/osd/OSDMap.cc
@@ -2953,12 +2953,12 @@ int OSDMap::summarize_mapping_stats(
       base_stddev += base_diff * base_diff;
       float new_diff = (float)new_by_osd[osd] - avg_pg;
       new_stddev += new_diff * new_diff;
-      if (min < 0 || min_base_pg < base_by_osd[osd]) {
+      if (min < 0 || base_by_osd[osd] < min_base_pg) {
 	min = osd;
 	min_base_pg = base_by_osd[osd];
 	min_new_pg = new_by_osd[osd];
       }
-      if (max < 0 || max_base_pg > base_by_osd[osd]) {
+      if (max < 0 || base_by_osd[osd] > max_base_pg) {
 	max = osd;
 	max_base_pg = base_by_osd[osd];
 	max_new_pg = new_by_osd[osd];