From: Mykola Golub <mgolub@mirantis.com>
Date: Mon, 27 Jun 2016 11:45:02 +0000 (+0300)
Subject: librbd: potential use after free on refresh error
X-Git-Tag: v11.0.0~37^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F9949%2Fhead;p=ceph.git

librbd: potential use after free on refresh error

Signed-off-by: Mykola Golub <mgolub@mirantis.com>
---

diff --git a/src/librbd/AioImageRequestWQ.cc b/src/librbd/AioImageRequestWQ.cc
index eb5d83096742..725e96a8770d 100644
--- a/src/librbd/AioImageRequestWQ.cc
+++ b/src/librbd/AioImageRequestWQ.cc
@@ -457,9 +457,8 @@ void AioImageRequestWQ::handle_refreshed(int r, AioImageRequest<> *req) {
                  << "req=" << req << dendl;
   if (r < 0) {
     req->fail(r);
-    delete req;
-
     finish_queued_op(req);
+    delete req;
     finish_in_flight_op();
   } else {
     // since IO was stalled for refresh -- original IO order is preserved