]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/log
rocksdb.git
12 years agoIgnore a zero-sized file while looking for a seq-no in GetUpdatesSince
Abhishek Kona [Mon, 18 Mar 2013 21:50:59 +0000 (14:50 -0700)]
Ignore a zero-sized file while looking for a seq-no in GetUpdatesSince

Summary:
Rocksdb can create 0 sized log files when it is opened and closed without any operations.
The GetUpdatesSince fails currently if there is a log file of size zero.

This diff fixes this. If there is a log file is 0, it is removed form the probable_file_list

Test Plan: unit test

Reviewers: dhruba, heyongqiang

Reviewed By: heyongqiang

CC: leveldb
Differential Revision: https://reviews.facebook.net/D9507

12 years agoDO not report level size as zero when there are no files in L0
Abhishek Kona [Mon, 18 Mar 2013 19:04:38 +0000 (12:04 -0700)]
DO not report level size as zero when there are no files in L0

Summary:
Instead of checking for number of files in L0. Check for number of files in the requested level.

Bug introduced in D4929 (diff trying to do too many things).

Test Plan: db_test.

Reviewers: dhruba, MarkCallaghan

Reviewed By: dhruba

Differential Revision: https://reviews.facebook.net/D9483

12 years agoFixing a careless mistake in ldb
Mayank Agarwal [Fri, 15 Mar 2013 17:57:08 +0000 (10:57 -0700)]
Fixing a careless mistake in ldb

Summary: negation of the condition checked currently had to be checkd actually

Test Plan: make ldb; python ldb_test.py

Reviewers: sheki, dhruba

Reviewed By: sheki

Differential Revision: https://reviews.facebook.net/D9459

12 years agoDoing away with boost in ldb_cmd.h
Mayank Agarwal [Fri, 15 Mar 2013 00:56:38 +0000 (17:56 -0700)]
Doing away with boost in ldb_cmd.h

Summary: boost functions cause complications while deploying to third-party

Test Plan: make

Reviewers: sheki, dhruba

Reviewed By: sheki

Differential Revision: https://reviews.facebook.net/D9441