]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/log
ceph-ci.git
2 years agosrc/mds: increment directory inode's change attr by one
Ramana Raja [Thu, 22 Sep 2022 15:41:50 +0000 (11:41 -0400)]
src/mds: increment directory inode's change attr by one

... whenever the mtime or ctime of the directory inode is modified.

In CephFS subvolume clones exported using NFS-Ganesha, newly created
files using `touch` were not being listed. It was identified that the
create request sent to the Ceph MDS via NFS-Ganesha's libcephfs client
modified the mtime and ctime of the parent directory, but did not modify
the change_attr of the parent directory. Since the NFS client
didn't see a modification of the change attribute in the reply, it
didn't invalidate its readdir cache. The subsequent directory `ls` was
satisfied from the NFS client's stale readdir cache.

Whenever parent directory inode's  mtime was modified in
MDCache::predirty_journal_parents(), the parent inode's change_attr
was set to its dirstat->change_attr. The parent inode's
dirstat->change_attr doesn't track changes to parent's *ctime only*
changes such as setattr, setvxattr, etc. on the parent
directory. See commit 0d441dcd6af553d11d6be6df56d577c5659904a0 for more
details. This caused the directory inode's change_attr to not be updated
when an operation to change only its ctime was followed by an operation
to change its mtime and ctime.

Fix this by making changes to MDCache::predirty_journal_parents() and
CInode::finish_scatter_gather_update() to increment the directory
inode's change_attr by one instead of setting it to its
dirstat->change_attr.

Fixes: https://tracker.ceph.com/issues/57210
Signed-off-by: Ramana Raja <rraja@redhat.com>
2 years agotest/libcephfs: enhance directory's change_attr testing
Ramana Raja [Thu, 22 Sep 2022 19:55:52 +0000 (15:55 -0400)]
test/libcephfs: enhance directory's change_attr testing

Alternate operations that only change directory's ctime
(setattr/setxattr/removexattr on directory) with those that change
directory's mtime and ctime (create/rename/remove a file within
directory). Check that directory's change_attr is updated everytime
ctime changes.

Signed-off-by: Ramana Raja <rraja@redhat.com>
2 years agoMerge pull request #48437 from rosinL/fix-vstart
Samuel Just [Wed, 12 Oct 2022 23:04:04 +0000 (16:04 -0700)]
Merge pull request #48437 from rosinL/fix-vstart

src/vstart.sh: correct top_cpu's value

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agoMerge pull request #48457 from cyx1231st/wip-fix-msgr-test
Samuel Just [Wed, 12 Oct 2022 23:02:28 +0000 (16:02 -0700)]
Merge pull request #48457 from cyx1231st/wip-fix-msgr-test

test/crimson/test_messenger: add pause before marking down a connection

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2 years agoMerge pull request #48463 from zdover23/wip-doc-2022-10-14-dev-dev-guide-basic-workfl...
zdover23 [Wed, 12 Oct 2022 17:42:54 +0000 (03:42 +1000)]
Merge pull request #48463 from zdover23/wip-doc-2022-10-14-dev-dev-guide-basic-workflow-submodule-update-2

doc/dev: add submodule-update link to dev guide

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/dev: add submodule-update link to dev guide
Zac Dover [Wed, 12 Oct 2022 12:39:36 +0000 (22:39 +1000)]
doc/dev: add submodule-update link to dev guide

This commit links to the procedure in install/clone-source.rst that
explains how to update submodules.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48460 from zdover23/wip-doc-2022-10-14-install-clone-source-submo...
zdover23 [Wed, 12 Oct 2022 17:01:33 +0000 (03:01 +1000)]
Merge pull request #48460 from zdover23/wip-doc-2022-10-14-install-clone-source-submodules

doc/install: improve updating submodules procedure

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #47853 from WOnder93/selinux-io_uring
Boris Ranto [Wed, 12 Oct 2022 12:58:54 +0000 (14:58 +0200)]
Merge pull request #47853 from WOnder93/selinux-io_uring

selinux: prepare for anon inode controls enablement

2 years agodoc/install: improve updating submodules procedure
Zac Dover [Wed, 12 Oct 2022 08:27:42 +0000 (18:27 +1000)]
doc/install: improve updating submodules procedure

This commit beefs up the "Updating Submodules" procedure,
which (prior to this commit) was quite brief.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agocrimson/net: print connection memory address as the identity
Yingxin Cheng [Wed, 12 Oct 2022 05:37:56 +0000 (13:37 +0800)]
crimson/net: print connection memory address as the identity

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agotest/crimson/test_messenger: add pause before marking down a connection
Yingxin Cheng [Wed, 12 Oct 2022 05:14:20 +0000 (13:14 +0800)]
test/crimson/test_messenger: add pause before marking down a connection

To make sure the ACK messages are consumed, otherwise there can be
unexpected connect attempts to break the test.

Fixes: https://tracker.ceph.com/issues/57693
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #48377 from ktdreyer/win-deps-clone
Justin Caratzas [Tue, 11 Oct 2022 18:45:34 +0000 (14:45 -0400)]
Merge pull request #48377 from ktdreyer/win-deps-clone

win32: speed up and simplify deps cloning

2 years agoMerge pull request #48406 from athanatos/sjust/wip-57798
Samuel Just [Tue, 11 Oct 2022 18:36:03 +0000 (11:36 -0700)]
Merge pull request #48406 from athanatos/sjust/wip-57798

qa/suites/crimson-rados: add CRIMSON_COMPAT to workunit env

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2 years agoMerge pull request #48446 from zdover23/wip-doc-2022-10-12-glossary-ceph-monitor
zdover23 [Tue, 11 Oct 2022 17:36:02 +0000 (03:36 +1000)]
Merge pull request #48446 from zdover23/wip-doc-2022-10-12-glossary-ceph-monitor

doc/glossary: add "ceph monitor" entry

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/glossary: add "ceph monitor" entry
Zac Dover [Tue, 11 Oct 2022 16:49:13 +0000 (02:49 +1000)]
doc/glossary: add "ceph monitor" entry

This commit adds information to the "ceph monitor" entry in
glossary.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48196 from neesingh-rh/wip-human-readable-volume-info
Venky Shankar [Tue, 11 Oct 2022 11:18:19 +0000 (16:48 +0530)]
Merge pull request #48196 from neesingh-rh/wip-human-readable-volume-info

mgr/volumes: Add human-readable flag to volume info command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2 years agosrc/vstart.sh: correct top_cpu's value
luo rixin [Tue, 11 Oct 2022 07:44:05 +0000 (15:44 +0800)]
src/vstart.sh: correct top_cpu's value

Signed-off-by: luo rixin <luorixin@huawei.com>
2 years agoMerge pull request #48415 from rhcs-dashboard/repaired-metric-name
Nizamudeen A [Tue, 11 Oct 2022 07:32:53 +0000 (13:02 +0530)]
Merge pull request #48415 from rhcs-dashboard/repaired-metric-name

mgr/prometheus: change pg_repaired_objects name to pool_repaired_objects

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #47495 from rhcs-dashboard/rgw-s3-encryption
Nizamudeen A [Tue, 11 Oct 2022 07:18:43 +0000 (12:48 +0530)]
Merge pull request #47495 from rhcs-dashboard/rgw-s3-encryption

mgr/dashboard: add server side encryption to rgw/s3

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #46331 from lxbsz/wip-55332
Rishabh Dave [Tue, 11 Oct 2022 07:17:33 +0000 (12:47 +0530)]
Merge pull request #46331 from lxbsz/wip-55332

mds: wait unlink to finish to avoid conflict when creating same dentries

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
2 years agomgr/dashboard: add server side encryption to rgw/s3
Aashish Sharma [Mon, 8 Aug 2022 12:35:02 +0000 (18:05 +0530)]
mgr/dashboard: add server side encryption to rgw/s3

Fixes:https://tracker.ceph.com/issues/57826
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #48350 from athanatos/sjust/wip-57739
Liu-Chunmei [Tue, 11 Oct 2022 00:30:19 +0000 (17:30 -0700)]
Merge pull request #48350 from athanatos/sjust/wip-57739

crimson/.../replicated_request,logmissing_request: retain reference to req

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Radoslaw Zarzynski <rzarzynski@redhat.com>
2 years agoMerge pull request #48308 from cyx1231st/wip-seastore-offset
Liu-Chunmei [Tue, 11 Oct 2022 00:26:54 +0000 (17:26 -0700)]
Merge pull request #48308 from cyx1231st/wip-seastore-offset

crimson/os/seastore: introduce (64-8)-bit signed device_off_t and 32-bit signed segment_off_t

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Liu-Chunmei <chunmei.liu@intel.com>
2 years agoqa/suites/crimson-rados: add CRIMSON_COMPAT to workunit env
Samuel Just [Sun, 2 Oct 2022 18:08:40 +0000 (11:08 -0700)]
qa/suites/crimson-rados: add CRIMSON_COMPAT to workunit env

Fixes: https://tracker.ceph.com/issues/57798
Signed-off-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #48349 from rzarzynski/wip-crimson-cltreq-errreply-debug
Liu-Chunmei [Mon, 10 Oct 2022 23:41:37 +0000 (16:41 -0700)]
Merge pull request #48349 from rzarzynski/wip-crimson-cltreq-errreply-debug

crimson/osd: introduce debug to ClientRequest::reply_op_error()

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Liu-Chunmei <chunmei.liu@intel.com>
2 years agoMerge pull request #47754 from batrick/i57248
Rishabh Dave [Mon, 10 Oct 2022 18:42:24 +0000 (00:12 +0530)]
Merge pull request #47754 from batrick/i57248

qa: cleanup volumes on unwind

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
2 years agowin32: speed up and simplify deps cloning
Ken Dreyer [Fri, 30 Sep 2022 20:56:35 +0000 (16:56 -0400)]
win32: speed up and simplify deps cloning

Use --depth 1 for all the dependencies we clone to speed up the process.

Use the --branch argument for cloning all dependencies. This simplifies
the process and makes it easier to use other copies in an offline
environment where github.com is inaccessible.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
2 years agoMerge pull request #48423 from zdover23/wip-doc-2022-10-11-releases-pacific-grammar
zdover23 [Mon, 10 Oct 2022 16:38:44 +0000 (02:38 +1000)]
Merge pull request #48423 from zdover23/wip-doc-2022-10-11-releases-pacific-grammar

doc/releases: improve grammar in pacific.rst

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #48396 from rhcs-dashboard/fix-57792-main
Ernesto Puerta [Mon, 10 Oct 2022 15:34:46 +0000 (17:34 +0200)]
Merge pull request #48396 from rhcs-dashboard/fix-57792-main

mgr/dashboard: fix broken login links

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #48337 from batrick/first-python
Venky Shankar [Mon, 10 Oct 2022 15:28:47 +0000 (20:58 +0530)]
Merge pull request #48337 from batrick/first-python

tools/cephfs: convert first-damage.sh to python

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
2 years agoMerge pull request #46772 from cbodley/wip-rgw-doc-bucket-index
Casey Bodley [Mon, 10 Oct 2022 15:22:46 +0000 (11:22 -0400)]
Merge pull request #46772 from cbodley/wip-rgw-doc-bucket-index

doc/dev/radosgw: start describing the bucket index

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/releases: improve grammar in pacific.rst
Zac Dover [Mon, 10 Oct 2022 14:15:11 +0000 (00:15 +1000)]
doc/releases: improve grammar in pacific.rst

This commit accepts the grammar suggestions that were made by Cole
Mitchell in https://github.com/ceph/ceph/pull/48404.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agomgr/prometheus: change pg_repaired_objects name to pool_repaired_objects
Pere Diaz Bou [Mon, 10 Oct 2022 10:08:34 +0000 (12:08 +0200)]
mgr/prometheus: change pg_repaired_objects name to pool_repaired_objects

Fixes: https://tracker.ceph.com/issues/57806
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #48331 from tchaikov/crimson-stop
Kefu Chai [Mon, 10 Oct 2022 04:51:33 +0000 (12:51 +0800)]
Merge pull request #48331 from tchaikov/crimson-stop

crimson/osd: shutdown on osdmaps' demand

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #48238 from sisco0/fix-rgw-amqp-switch-compiler-warning-2
Yuval Lifshitz [Sun, 9 Oct 2022 10:35:02 +0000 (13:35 +0300)]
Merge pull request #48238 from sisco0/fix-rgw-amqp-switch-compiler-warning-2

rgw: fix rabbitmq version checking for AMQP_STATUS_SSL_SET_ENGINE_FAILED

3 years agomgr/dashboard: fix broken login links
Ernesto Puerta [Fri, 7 Oct 2022 15:08:14 +0000 (17:08 +0200)]
mgr/dashboard: fix broken login links

Fixes: https://tracker.ceph.com/issues/57792
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoMerge pull request #48275 from liu-chunmei/rados-api-test
Samuel Just [Thu, 6 Oct 2022 23:39:53 +0000 (16:39 -0700)]
Merge pull request #48275 from liu-chunmei/rados-api-test

crimson/qa: add rados_api_tests.yaml for seastore

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoqa/workunits/fs/damage: update first-damage test for python
Patrick Donnelly [Mon, 3 Oct 2022 00:45:48 +0000 (20:45 -0400)]
qa/workunits/fs/damage: update first-damage test for python

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agotools/cephfs: convert first-damage.sh to python
Patrick Donnelly [Sat, 1 Oct 2022 19:04:22 +0000 (15:04 -0400)]
tools/cephfs: convert first-damage.sh to python

To have only one RADOS instance and improve performance/reliability.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #48218 from mchangir/qa-test_scrub_pause_and_resume_with_abort...
Venky Shankar [Tue, 4 Oct 2022 06:15:24 +0000 (11:45 +0530)]
Merge pull request #48218 from mchangir/qa-test_scrub_pause_and_resume_with_abort-wait-for-scrub-to-finish

qa: wait for scrub to finish

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
3 years agocrimson/osd: introduce debug to ClientRequest::reply_op_error()
Radoslaw Zarzynski [Mon, 3 Oct 2022 21:31:18 +0000 (21:31 +0000)]
crimson/osd: introduce debug to ClientRequest::reply_op_error()

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #48041 from cbodley/wip-rgw-notify-shutdown
Casey Bodley [Mon, 3 Oct 2022 21:06:10 +0000 (17:06 -0400)]
Merge pull request #48041 from cbodley/wip-rgw-notify-shutdown

rgw: rados service shuts down rados client on shutdown()

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
3 years agoMerge pull request #48152 from Vfrost98/GHC22OSD_Ceph
Yuri Weinstein [Mon, 3 Oct 2022 20:21:49 +0000 (13:21 -0700)]
Merge pull request #48152 from Vfrost98/GHC22OSD_Ceph

mgr/telemetry: fixed log exceptions as "exception" instead of "error"

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>
3 years agoRGWServices_Def::shutdown() shuts down the rest of the services too
Casey Bodley [Thu, 15 Sep 2022 17:37:51 +0000 (13:37 -0400)]
RGWServices_Def::shutdown() shuts down the rest of the services too

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agorgw: shut down RGWDataChangesLog before other services
Casey Bodley [Sun, 11 Sep 2022 22:25:38 +0000 (18:25 -0400)]
rgw: shut down RGWDataChangesLog before other services

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agorgw: rados service shuts down rados client on shutdown()
Casey Bodley [Sun, 11 Sep 2022 22:13:52 +0000 (18:13 -0400)]
rgw: rados service shuts down rados client on shutdown()

if we leave the rados client running, it will keep delivering
AioCompletions while we're shutting other things down

this resolves a valgrind use-after-free where rgw::notify::Manager
gets completions after its destruction

Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #48155 from liangmingyuanneo/wip-rgw-aync-refcount
Casey Bodley [Mon, 3 Oct 2022 17:14:25 +0000 (13:14 -0400)]
Merge pull request #48155 from liangmingyuanneo/wip-rgw-aync-refcount

rgw: async refcount operate in copy_obj

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #47186 from cfsnyder/wip-cfsnyder-56645
Casey Bodley [Mon, 3 Oct 2022 16:01:18 +0000 (12:01 -0400)]
Merge pull request #47186 from cfsnyder/wip-cfsnyder-56645

rgw: log deletion status of individual objects in multi object delete request

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agorgw: async refcount operate in copy_obj
= [Sat, 17 Sep 2022 10:55:53 +0000 (18:55 +0800)]
rgw: async refcount operate in copy_obj

Signed-off-by: Mingyuan Liang <liangmingyuan@baidu.com>
3 years agocrimson/osd/stop_signal: s/signaled/on_signal/
Kefu Chai [Sun, 2 Oct 2022 02:29:55 +0000 (10:29 +0800)]
crimson/osd/stop_signal: s/signaled/on_signal/

to better reflect that it is a callback gets called when receiving a
signal.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agocrimson/.../replicated_request,logmissing_request: retain reference to req
Samuel Just [Wed, 28 Sep 2022 23:36:46 +0000 (23:36 +0000)]
crimson/.../replicated_request,logmissing_request: retain reference to req

Otherwise, operator<< and dump_detail would need to accessing req after
the call to handle_rep_op.

Fixes: https://tracker.ceph.com/issues/57739
Signed-off-by: Samuel Just <sjust@redhat.com>