Merge pull request #48667 from zdover23/wip-doc-2022-10-30-ceph-volume-lvm-prepare-colemitchell-notes

doc/ceph-volume: refine Filestore docs

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/ceph-volume: refine Filestore docs

Add Cole Mitchell's improvements to the filestore section.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48665 from zdover23/wip-doc-2022-10-30-ceph-volume-lvm-prepare-datri-notes

doc/ceph-volume: improve prepare.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/ceph-volume: improve prepare.rst

Incorporate Anthony D'Atri's suggestions from
https://github.com/ceph/ceph/pull/48651.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48090 from joscollin/wip-F55197-cephfs-top-scroll

cephfs-top: make cephfs-top display scrollable

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>

Merge pull request #48662 from ceph/wip-update-stale-bot

.github/workflows: update `days-before-pr-close`

.github/workflows: update `days-before-pr-close`

Currently, the stale bot closes PRs 90 days after they are marked stale since it counts "marking a PR stale" as activity.

We really want the PRs to close after a total of 90 days, or 30 days after they are marked stale. Changing `days-before-prs-close` to 30 will fix this.

Signed-off-by: Laura Flores <lflores@redhat.com>

Merge pull request #48658 from zdover23/wip-doc-2022-10-28-radosgw-multisite-prompts

doc/radosgw: add prompts to multisite.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/radosgw: add prompts to multisite.rst

Add unselectable prompts to multisite.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #47582 from snosratiershad/docs/correct-add-system-user-to-the-master-zone-command

docs: correct add system user to the master zone command

Reviewed-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48649 from ybwang0211/REST-spell

doc: Change 'ReST' to 'REST' in doc/radosgw/layout.rst

Reviewed-by: Zac Dover <zac.dover@gmail.com>

doc: Change 'ReST' to 'REST' in doc/radosgw/layout.rst

In doc/radosgw/layout.rst, 'ReST' is not spelled properly, so we change it to 'REST'.

Signed-off-by: wangyingbin <wangyingbin@inspur.com>

Merge pull request #48644 from zdover23/wip-doc-2022-10-28-ceph-volume-lvm-prepare-datri-notes

doc/ceph-volume: add A. D'Atri's suggestions

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/ceph-volume: add A. D'Atri's suggestions

Add Anthony D'Atri's notes on doc/ceph-volume/lvm/prepare.rst as
expressed in https://github.com/ceph/ceph/pull/48634.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48629 from SUSE/wip-fix-neorados-fmt9

neorados: compile with fmt v9

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #48622 from vumrao/wip-vikhyat-governance

doc/governance: add CLT member Vikhyat Umrao

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #47874 from petrutlucian94/dokany_v2

dokan: switch to Dokany v2

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48624 from zdover23/wip-doc-2022-10-26-ceph-volume-lvm-prepare

doc/ceph-volume: refine "prepare" top matter

neorados: compile with fmt v9

neorados FTBFS on openSUSE Tumbleweed which includes fmt version 9.
On the assumption it's still desirable to support building with older
versions, I've put "#if FMT_VERSION" guards around the additions here.

Signed-off-by: Tim Serong <tserong@suse.com>

doc/ceph-volume: refine "prepare" top matter

This commit refines the top matter in the
doc/ceph-volume/lvm/prepare.rst file.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48633 from adamemerson/wip-scopeguard-nodiscard

include: Add [[nodiscard]] to make_scope_guard

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #48586 from ivancich/wip-document-sal-readop-read

rgw: document convention used in ReadOp::read and ReadOp::iterate

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

include: Add [[nodiscard]] to make_scope_guard

To prevent a bug where an unassigned scope guard runs right away.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #48619 from ceph/wip-tracker-57883

qa/standalone/erasure-code: give osdmap 5 seconds to refresh

Merge pull request #48557 from phlogistonjohn/jjm-fix-cephadm-test-py36

cephadm: fix running cephadm tox test suite on python 3.6

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #48620 from mgfritch/cephadm-gitignore

cephadm: add .gitignore for tox related files

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #48627 from zdover23/wip-doc-2022-10-26-ceph-volume-lvm-prepare-3

doc/ceph-volume: refine "filestore" section

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #48625 from zdover23/wip-doc-2022-10-26-ceph-volume-lvm-prepare-2

doc/ceph-volume: refine "bluestore" section

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge PR #43284 into main

* refs/pull/43284/head:
doc: describe bal_rank_mask configuration
qa/cephfs: add bal_rank_mask test cases
mds: add bal_rank_mask option for ceph fs set

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

doc/ceph-volume: refine "filestore" section

This commit refines the "filestore" section in the doc/ceph-volume/lvm/prepare.rst file.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

cephfs-top: Select Filesystem Screen fixes for no FS

* drop the blank FS Menu when there is no FS
* cleanup display_fs_menu() code

Signed-off-by: Jos Collin <jcollin@redhat.com>

doc: Update cephfs-top.png

Fixes: https://tracker.ceph.com/issues/55197
Signed-off-by: Jos Collin <jcollin@redhat.com>

cephfs-top: make cephfs-top display scrollable

Fixes: https://tracker.ceph.com/issues/55197
Signed-off-by: Jos Collin <jcollin@redhat.com>

doc/ceph-volume: refine "bluestore" section

This commit refines the "bluestore" section in the
doc/ceph-volume/lvm/prepare.rst file.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

doc/governance: add CLT member Vikhyat Umrao

Signed-off-by: Vikhyat Umrao <vikhyat@redhat.com>

cephadm: add .gitignore for tox related files

ignore files created by a run of `tox -e coverage`

Signed-off-by: Michael Fritch <mfritch@suse.com>

qa/standalone/erasure-code: give osdmap 5 seconds to refresh

Fixes: https://tracker.ceph.com/issues/57883
Signed-off-by: Laura Flores <lflores@redhat.com>

Merge pull request #40363 from orozery/rbd-clone-encryption

librbd: add encryption format support for clones (part 1/2)

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

cephadm: fix running test suite on python3.6

While a new version of pyfakefs is available, version 5 is not available
for python 3.6. In order to run the test suite on centos 8 we will
continue to work with pyfakefs version 4.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

cephadm: fix base class behavior on python3.6

This fixes the cephadm test files when running tox/pytest on python3.6
(centos/rhel 8).
Long story short, combining classmethod and property on py3.6 behaves
differently from py3.7 and up. Since the classmethod is actually
unnecessary for the base class to behave as it does, we drop that
decorator.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #48547 from SUSE/wip-fix-57893

make-dist: don't set Release tag in ceph.spec for SUSE distros

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #48610 from zdover23/wip-doc-2022-10-25-cephadm-ssh-capitalization

doc/cephadm: s/ssh/SSH/ in doc/cephadm (complete)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephadm: s/ssh/SSH/ in doc/cephadm (complete)

This PR alters "ssh" to "SSH" in the text (that is, not in
commands) every location in the doc/cephadm/ directory where
"ssh" should be "SSH".

Signed-off-by: Zac Dover <zac.dover@gmail.com>

make-dist: don't set Release tag in ceph.spec for SUSE distros

SUSE's Open Build Service overwrites the Release tag with checkin
and build counters, so we can't use it to record the number of
commits since the last tag, and the last commit hash.  This commit
appends that extra information to the Version tag instead for
SUSE builds.

Fixes: https://tracker.ceph.com/issues/57893
Signed-off-by: Tim Serong <tserong@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #46188 from Zhiwei-Dai/wip-rgw-crypto-stack-on-compress

rgw: support full object encryption stack on compression

Reviewed-by: Casey Bodley <cbodley@redhat.com>

rgw: document convention used in ReadOp::read and ReadOp::iterate

Both of these functions defined at the SAL layer take an offset and an
end offset. It's important to note that the end offset is inclusive
since a common, modern convention is for the end offset to be
exclusive.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #48478 from myoungwon/wip-rbm-move-mkfs-cleanup

crimson/os/seastore/rbm: move mkfs to RBMDevice and use device_config_t

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #48445 from rzarzynski/wip-crimson-fix-obcload-errs

crimson/osd: send proper reply on obc load failure

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48577 from zdover23/wip-doc-2022-10-21-radosgw-notifications-and-event

doc/radosgw: refine "notifications" and "events"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/radosgw: refine "notifications" and "events"

This commit refines the English in the "Notifications"
and "Events" sections of the notifications.rst page
(the "Bucket Notifications" page).

Signed-off-by: Zac Dover <zac.dover@gmail.com>

crimson/os/seastore/cbj: handle remaing space (from written_to to the end of the journal) is less than the requested size

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

crimson/os/seastore/rbm: move test interfaces to the end of the class

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

crimson/os/seastore/cbj: rename size-related interfaces with grouping

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

Merge pull request #48477 from rzarzynski/wip-crimson-rollback-delete-head

crimson/osd: add the delete-head special case of CEPH_OSD_OP_ROLLBACK

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48572 from zdover23/wip-doc-2022-10-21-cephadm-host-management-os-tuning-grammar

doc/cephadm: refine "os tuning" in h. management

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephadm: refine "os tuning" in h. management

This commit refines the English in the "OS Tuning Profiles" section of
the "Host Management" page of the cephadm documentation. This commit is
made separately from but in anticipation of a forthcoming commit that
corrects technical (non-grammatical) errors.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #46089 from myoungwon/wip-dedup-doc

doc/dev: add explanation of how to use deduplication

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

crimson/osd: add the delete-head special case of CEPH_OSD_OP_ROLLBACK

This allows to pass `TestLibRBD.TestIOToSnapshot`:

```
[rzarzynski@o06 build]$ CRIMSON_COMPAT=true RBD_FEATURES=1 bin/ceph_test_librbd --gtest_filter=TestLibRBD.TestIOToSnapshot
seed 3954016
Note: Google Test filter = TestLibRBD.TestIOToSnapshot
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestLibRBD
[ RUN      ] TestLibRBD.TestIOToSnapshot
using new format!
...
opening testimg@orig
read: 80
write to snapshot returned -30
Read-only file system
num snaps is: 2
expected: 2
snap: orig
snap: written
found orig with size 2097152
found written with size 2097152
num snaps is: 1
expected: 1
snap: orig
found orig with size 2097152
num snaps is: 0
expected: 0
[       OK ] TestLibRBD.TestIOToSnapshot (7510 ms)
[----------] 1 test from TestLibRBD (7510 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (8504 ms total)
[  PASSED  ] 1 test.
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #48246 from liangmingyuanneo/fix-throttle-test

test/rgw: improve integrity of rgw throttle test

Reviewed-by: Casey Bodley <cbodley@redhat.com>

crimson/osd: ClientRequest sends error to client when loading obc fails

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #48456 from rhcs-dashboard/cypress-video-enable

mgr/dashboard: enable cypress video on test fails

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #48546 from rhcs-dashboard/update-node

cmake: bump node version to 14

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #48505 from zhscn/fix-uaf

crimson/osd: fix use after free error in FuturizedStoreLogReader::read

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #48556 from zdover23/wip-doc-2022-10-20-radosgw-notifications-bucket-notifications-rest-api

doc/radosgw: refine "bucket notifications"

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

doc/radosgw: refine "bucket notifications"

This commit refines the English in the "Bucket Notifications REST API"
section of the notifications.rst page (the "Bucket Notifications" page).

Co-author: Cole Mitchell <cole.mitchell@gmail.com>

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #47848 from galsalomon66/s3select_next_version

moving to next version of s3select.

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #48532 from ceph/wip-yuriw-release-17.2.5-main

doc: 17.2.5 Release Notes

doc: 17.2.5 Release Notes

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
Signed-off-by: Laura Flores <lflores@redhat.com>

crimson/os/seastore/rbm: rename TestMemory to EphemeralRBMDevice and adjust default paramter location

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

crimson/os/seastore/cbj: add get_journal_start() and adjust it to default block size

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

crimson/os/seastore/cbj: merge mkfs() in cbj into open_for_mkfs()

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

cmake: bump node version to 14

to update the angular to 13, we need a node version of either 12.20.x or
14.15.x or 16.10.x. But inorder to not break the angular 12 run for now
   we  need to choose the node which works for both 12 and 13. which is
14.15.x. So I went with that node version here.

Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #48347 from ronen-fr/wip-rf-acting

osd/scrub: use the actual active set when requesting replicas to scrub

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #48510 from ceph/update-mailmap

mailmap: add Pedro Gonzalez Gomez

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #48528 from ceph/fix-gh_pr_triage_node_version-main

.github/pr-triage: update node.js to v16

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #48515 from athanatos/sjust/wip-crimson-suites

qa/suites/crimson-rados: move seastore to crimson-rados-experimental, remove cache/dedup workloads

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

moving to next version of s3select
s3select submodule

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>

Merge pull request #48533 from zdover23/wip-doc-2022-10-19-radosgw-notification-topic-management-and-notification-performance

doc/radosgw: refine top. man. and not. perf. stats

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/radosgw: refine top. man. and not. perf. stats

This commit refines the English in the "Topic Management via CLI" and
"Notification Performance Statistics" sections of the notifications.rst
file.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #48444 from yuvalif/wip-yuval-fix-57850

rgw/amqp: store CA location string in connection object

qa/suites/crimson-rados: remove cache and dedup related tests

It's an accident that some of these pass -- the tests provide some
coverage for inconsistencies that can arise, but don't really validate
that the objects actually get moved between tiers.

It's going to be some time before we implement cache or dedup in
crimson, and we'll probably want to disable the related commands for
pools that can map to crimson osds to prevent accidents.

Signed-off-by: Samuel Just <sjust@redhat.com>

qa/suites: move seastore to crimson-rados-experimental suite

Let's use crimson-rados-experimental for tests that don't yet
pass reliably.  We can move these to crimson-rados as they
become reliable.

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #48511 from zdover23/wip-doc-2022-10-18-radosgw-notification-reliability

doc/radosgw: refine "notification reliability"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/radosgw: refine "notification reliability"

This commit refines the English in the "Notification Reliability"
section of the notifications.rst page (the "Bucket Notifications"
page). I have also added signposting structure.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Yuval Lifshitz <ylifshit@redhat.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>

.github/pr-triage: update node.js to v16

[Warning](https://github.com/ceph/ceph/actions/runs/3273201887):
```
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16: actions/labeler, iyu/actions-milestone
```

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>

Merge pull request #48484 from cyx1231st/wip-crimson-msgr-cleanup

crimson/net: simplify msgr interfaces with AuthClient/Server

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #48514 from ceph/wip-dashboard_gh_project-main

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #48485 from vshankar/wip-upgrade-x-o-q

qa: fs:upgrade featureful_client test upgrades to quincy

Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #48398 from rhcs-dashboard/fix-get-rbd-stats

mgr/prometheus: avoid duplicates and deleted entries for rbd_stats_pools

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #48471 from SUSE/wip-fix-57860

ceph.spec.in: disable system_pmdk on s390x for SUSE distros

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

doc/dev: add explanation of how to use deduplication

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

crimson/os/seastore/cbj: remove duplicate configs in cbj_header_t

Also, this commits remove cbj::mkfs_config_t and use device's
information.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

crimson/os/seastore/rbm: add stat to get device info. at mkfs time

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

crimson/os/seastore/rbm: remove start and start_data_area

remove start and start_data_area in rbm header and
use RBM_START_ADDRESS and journal_size instead.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

crimson/os/seastore/rbm: remove block_size and size in RBMDevice

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

crimson/os/seastore/rbm: use device_config_t in rbm_metadata_header_t

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

crimson/os/seastore/rbm: move mkfs to RBMDevice

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

.github/pr-triage: switch from old to new project

The old (classic) Dashboard project (https://github.com/ceph/ceph/projects/6) has been migrated to a new-style one (https://github.com/orgs/ceph/projects/2/views/1).

This also requires updating the GH Action that automatically assigned `dashboard`-labeled PRs to the Dashboard project.

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>

Merge pull request #48512 from zdover23/wip-doc-2022-10-18-radosgw-notifications-prompts

doc/radowsgw: add prompts to notifications.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

mailmap: add Pedro Gonzalez Gomez

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>