]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agoMerge pull request #43442 from linuxbox2/wip-rgwadmin-logfix
Matt Benjamin [Thu, 7 Oct 2021 15:04:16 +0000 (11:04 -0400)]
Merge pull request #43442 from linuxbox2/wip-rgwadmin-logfix

qa/rgw: fix ops log tests to handle non-bucket ops (which are now valid)

3 years agoMerge pull request #43448 from rzarzynski/wip-crimson-monmap-moredbgs
Kefu Chai [Thu, 7 Oct 2021 14:14:03 +0000 (22:14 +0800)]
Merge pull request #43448 from rzarzynski/wip-crimson-monmap-moredbgs

crimson, monmap: inform about errors when interacting with DNS

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge PR #43231 into master
Patrick Donnelly [Thu, 7 Oct 2021 13:16:34 +0000 (09:16 -0400)]
Merge PR #43231 into master

* refs/pull/43231/head:
qa: fix promotion test

Reviewed-by: Ramana Raja <rraja@redhat.com>
3 years agocrimson, monmap: inform about errors in MonMap::init_with_dns_srv(). 43448/head
Radoslaw Zarzynski [Thu, 7 Oct 2021 11:12:48 +0000 (11:12 +0000)]
crimson, monmap: inform about errors in MonMap::init_with_dns_srv().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agocrimson, monmap: limit the scope of the seastar namespace inclusion.
Radoslaw Zarzynski [Thu, 7 Oct 2021 11:04:12 +0000 (11:04 +0000)]
crimson, monmap: limit the scope of the seastar namespace inclusion.

More consistency that way. This also enables us to define the usual
`logger()` function without having a clash with `seastar::logger`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #43384 from bosc0/master
Venky Shankar [Thu, 7 Oct 2021 08:40:12 +0000 (14:10 +0530)]
Merge pull request #43384 from bosc0/master

mgr: Add check to prevent mgr from crashing

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #41445 from guits/cephadm_quick_patch
Kefu Chai [Wed, 6 Oct 2021 22:48:05 +0000 (06:48 +0800)]
Merge pull request #41445 from guits/cephadm_quick_patch

cephadm: add daemon_name in daemon description

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43335 from liewegas/debug-51815
Kefu Chai [Wed, 6 Oct 2021 22:45:45 +0000 (06:45 +0800)]
Merge pull request #43335 from liewegas/debug-51815

mon,auth: fix proposal (and mon db rebuild) of rotating secrets

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43379 from myoungwon/wip-evict-range
Kefu Chai [Wed, 6 Oct 2021 22:44:33 +0000 (06:44 +0800)]
Merge pull request #43379 from myoungwon/wip-evict-range

osd: trim corresponding chunks on tier_evict

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43378 from ivancich/wip-build-without-mgr
Kefu Chai [Wed, 6 Oct 2021 22:43:25 +0000 (06:43 +0800)]
Merge pull request #43378 from ivancich/wip-build-without-mgr

rados: build minimally when "WITH_MGR" is off

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43360 from jianwei1216/fix-shard-threads-cannot-wakeup-bug
Kefu Chai [Wed, 6 Oct 2021 22:41:54 +0000 (06:41 +0800)]
Merge pull request #43360 from jianwei1216/fix-shard-threads-cannot-wakeup-bug

osd: fix shard-threads cannot wakeup bug

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43307 from taodd/recv_stamp_fix
Kefu Chai [Wed, 6 Oct 2021 22:33:21 +0000 (06:33 +0800)]
Merge pull request #43307 from taodd/recv_stamp_fix

msg/async/ProtocolV2: Set the recv_stamp at the beginning of receiving a message

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Dan Hill <daniel.hill@canonical.com>
3 years agoMerge pull request #43380 from myoungwon/wip-dont-promote-dirty
Kefu Chai [Wed, 6 Oct 2021 22:31:32 +0000 (06:31 +0800)]
Merge pull request #43380 from myoungwon/wip-dont-promote-dirty

osd: do not promote objects if op is is_dirty

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43435 from rzarzynski/wip-crimson-pickv2only
Kefu Chai [Wed, 6 Oct 2021 22:19:54 +0000 (06:19 +0800)]
Merge pull request #43435 from rzarzynski/wip-crimson-pickv2only

crimson/osd: pick only v2 addresses.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agoqa/rgw: fix ops log tests to handle non-bucket ops (which are now valid) 43442/head
Matt Benjamin [Tue, 5 Oct 2021 12:17:59 +0000 (08:17 -0400)]
qa/rgw: fix ops log tests to handle non-bucket ops (which are now valid)

After 3863eb89512f1698b8e56f1f1ffc78a6ca8d5826--rgw: permit logging of
list-bucket (and any other no-bucket op-- the radosgw ops-log
contains entries for ops with no associated buckets--e.g., list_buckets.
When examining such a log object in the radosgw_admin task, don't assert
that it has any bucket name.

Fixes: https://tracker.ceph.com/issues/52647
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agoMerge pull request #43256 from rhcs-dashboard/fix-48845-master
Ernesto Puerta [Wed, 6 Oct 2021 19:49:12 +0000 (21:49 +0200)]
Merge pull request #43256 from rhcs-dashboard/fix-48845-master

qa/mgr/dashboard/test_pool: don't check HEALTH_OK

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #42964 from trociny/wip-52448
Neha Ojha [Wed, 6 Oct 2021 16:26:16 +0000 (09:26 -0700)]
Merge pull request #42964 from trociny/wip-52448

osd: re-cache peer_bytes on every peering state activate

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agocrimson/osd: pick only v2 addresses. 43435/head
Radoslaw Zarzynski [Wed, 6 Oct 2021 11:16:31 +0000 (11:16 +0000)]
crimson/osd: pick only v2 addresses.

Otherwise we'll run into an assertion failure when binding:

```
INFO  2021-10-05 15:14:51,075 [shard 0] osd - picked address v2:0.0.0.0:0/0
INFO  2021-10-05 15:14:51,075 [shard 0] osd - picked address v1:0.0.0.0:0/0
ceph-osd: /home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-8025-geb9c0f59/rpm/el8/BUILD/ceph-17.0.0-8025-geb9c0f59/src/crimson/net/SocketMessenger.cc:89: crimson::errorator<crimson::unthrowable_wrapper<const std::error_code&, ((const std::error_code&)(& crimson::ec<std::errc::address_in_use>))>, crimson::unthrowable_wrapper<const std::error_code&, ((const std::error_code&)(& crimson::ec<std::errc::address_not_available>))> >::future<> crimson::net::SocketMessenger::try_bind(const entity_addrvec_t&, uint32_t, uint32_t): Assertion `addrs.size() == 1' failed.
Aborting on shard 0.
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge PR #43399 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:17:49 +0000 (20:17 -0400)]
Merge PR #43399 into master

* refs/pull/43399/head:
mgr/volumes/fs/operations: fix various flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43398 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:17:19 +0000 (20:17 -0400)]
Merge PR #43398 into master

* refs/pull/43398/head:
mgr/volumes/fs: fix flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43397 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:16:50 +0000 (20:16 -0400)]
Merge PR #43397 into master

* refs/pull/43397/head:
mgr/volumes/fs: fix flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43395 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:16:19 +0000 (20:16 -0400)]
Merge PR #43395 into master

* refs/pull/43395/head:
mgr/volumes/fs/operations/versions: fix various flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43392 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:15:47 +0000 (20:15 -0400)]
Merge PR #43392 into master

* refs/pull/43392/head:
mgr/volumes/fs/operations: fix various flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43391 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:15:18 +0000 (20:15 -0400)]
Merge PR #43391 into master

* refs/pull/43391/head:
mgr/volumes/fs/vol_spec.py: fix flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43390 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:14:49 +0000 (20:14 -0400)]
Merge PR #43390 into master

* refs/pull/43390/head:
mgr/volumes/fs/operations : Fix flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43387 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:14:06 +0000 (20:14 -0400)]
Merge PR #43387 into master

* refs/pull/43387/head:
mgr/volumes: fix various flake8 issues

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43375 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:13:34 +0000 (20:13 -0400)]
Merge PR #43375 into master

* refs/pull/43375/head:
mgr/volumes/fs: add extra blank line

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43357 into master
Patrick Donnelly [Wed, 6 Oct 2021 00:12:44 +0000 (20:12 -0400)]
Merge PR #43357 into master

* refs/pull/43357/head:
mgr/nfs: stick to lazy evaluation of logger messages
mgr/nfs: change _cmd_rgw_export_create_rgw() name
mgr/nfs: don't log fsal keys
mgr/nfs: Add more debug log messages

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
3 years agoqa: fix promotion test 43231/head
Patrick Donnelly [Tue, 21 Sep 2021 00:07:42 +0000 (20:07 -0400)]
qa: fix promotion test

The test is not needing to check that the new MDS becomes active, only
that a replacement occurs.

Fixes: https://tracker.ceph.com/issues/52677
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #42977 from amathuria/wip-amathuri-scrub-duration
Yuri Weinstein [Tue, 5 Oct 2021 14:49:03 +0000 (07:49 -0700)]
Merge pull request #42977 from amathuria/wip-amathuri-scrub-duration

osd/scrub: Add scrub duration to pg dump stats

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoosd: wake up more shard workers when new osdmap is consumed 43360/head
Jianwei Zhang [Thu, 30 Sep 2021 06:47:01 +0000 (14:47 +0800)]
osd: wake up more shard workers when new osdmap is consumed

Reproduce:
(1) ceph cluster not running any client IO
(2) only ceph osd in osd.14 operation

Reason:
(1) one shard-queue has three shard-threads
(2) one or some PeeringOp's epoch > osdmap's epoch held by current osd,
    and these PeeringOp _add_slot_waiter()
(3) shard-queue become empty and three shard-threads cond.wait()
(4) new osdmap consume and it _wake_pg_slot()
    Problem in here
1> OSDShard::consume() exec loop all pg's slot wait
     and requeue more than one PeeringOp to shard-queue
        2> but it only notify one shard-thread to wakeup,
           the other two shard-threads continue cond.wait()
3> OSD::ShardedOpWQ::_enqueue() found the shard-queue not empty
   and not notify all shard-thread to wakeup

     In a period of time, only one shard-thread of 3 shard-threads is running.

Fixes: https://tracker.ceph.com/issues/52781
Signed-off-by: Jianwei Zhang <jianwei1216@qq.com>
Change-Id: I4617db2fd95082007e6d9fa2b60f17f2a6296b5b

3 years agoMerge pull request #43175 from ideepika/wip-supress-jaeger-cmake-logs
Deepika Upadhyay [Tue, 5 Oct 2021 08:30:50 +0000 (14:00 +0530)]
Merge pull request #43175 from ideepika/wip-supress-jaeger-cmake-logs

cmake,rgw: use jaeger-base target, as a dependency for building dbstore

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #43410 from zdover23/wip-doc-2021-10-04-min-hardware-typo
Josh Durgin [Mon, 4 Oct 2021 18:02:06 +0000 (11:02 -0700)]
Merge pull request #43410 from zdover23/wip-doc-2021-10-04-min-hardware-typo

docs/start: fix min. hardware rec. typo

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agodocs/start: fix min. hardware rec. typo 43410/head
Zac Dover [Mon, 4 Oct 2021 16:33:49 +0000 (02:33 +1000)]
docs/start: fix min. hardware rec. typo

The minimum hardware recommendations said that we
recommended a minimum of "24GB+ per daemon".

I changed this to read "2-4GB+ per daemon".

Reddit actually caught this one:
https://www.reddit.com/r/ceph/comments/q14ey2/cephs_mon_minimum_requirements/

Signed-off-by: Zac Dover <zac.dover@gmail.com>
3 years agocmake,rgw: use jaeger-base target, as a dependency for building dbstore 43175/head
Deepika Upadhyay [Mon, 4 Oct 2021 08:10:48 +0000 (13:40 +0530)]
cmake,rgw: use jaeger-base target, as a dependency for building dbstore

* dbstore also has tracing dependencies and missing linking for libraries
* use `using` keyword in common/tracer.cc to silence unused method
  warnings
* log building of external project jaegertracing, opentracing into build
  file, (done to reduce external project build verbosity)

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoMerge pull request #43402 from liewegas/doc-general-rep
Sage Weil [Sun, 3 Oct 2021 18:42:45 +0000 (13:42 -0500)]
Merge pull request #43402 from liewegas/doc-general-rep

doc/foundation: Martin is new general member rep

3 years agoMerge PR #43383 into master
Patrick Donnelly [Sat, 2 Oct 2021 16:27:40 +0000 (12:27 -0400)]
Merge PR #43383 into master

* refs/pull/43383/head:
doc: fixed typo in terminology

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agodoc/foundation: Martin is new general member rep 43402/head
Sage Weil [Sat, 2 Oct 2021 15:49:46 +0000 (10:49 -0500)]
doc/foundation: Martin is new general member rep

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomgr/volumes/fs/operations: fix various flake8 issues 43399/head
crossbears [Fri, 1 Oct 2021 22:39:21 +0000 (18:39 -0400)]
mgr/volumes/fs/operations: fix various flake8 issues

Fixes: https://tracker.ceph.com/issues/51390
Signed-off-by: Zoey <jingyasu@my.yorku.ca>
3 years agomgr/volumes/fs/vol_spec.py: fix flake8 issues 43391/head
Eunice Lee [Fri, 1 Oct 2021 21:51:49 +0000 (14:51 -0700)]
mgr/volumes/fs/vol_spec.py: fix flake8 issues

Fixes: https://tracker.ceph.com/issues/51384
Signed-off-by: Eunice Lee <eunice337@gmail.com>
3 years agomgr/volumes/fs: fix flake8 issues 43398/head
Hargun Kaur [Fri, 1 Oct 2021 22:39:33 +0000 (22:39 +0000)]
mgr/volumes/fs: fix flake8 issues

Fixes: https://tracker.ceph.com/issues/51407
Signed-off-by: Hargun Kaur <hargunalone@gmail.com>
3 years agomgr/volumes/fs/operations/versions: fix various flake8 issues 43395/head
Gokcen Iskender [Fri, 1 Oct 2021 22:16:07 +0000 (15:16 -0700)]
mgr/volumes/fs/operations/versions: fix various flake8 issues

Fixes: https://tracker.ceph.com/issues/51403
Signed-off-by: Gokcen Iskender <gokceng@gmail.com>
3 years agomgr/volumes/fs: fix flake8 issues 43397/head
Eunice Lee [Fri, 1 Oct 2021 22:11:28 +0000 (15:11 -0700)]
mgr/volumes/fs: fix flake8 issues

Fixes: https://tracker.ceph.com/issues/51381
Signed-off-by: Eunice Lee <eunice337@gmail.com>
3 years agomgr/volumes/fs/operations: fix various flake8 issues 43392/head
Gokcen Iskender [Fri, 1 Oct 2021 21:59:06 +0000 (14:59 -0700)]
mgr/volumes/fs/operations: fix various flake8 issues

Fixes: https://tracker.ceph.com/issues/51398
Signed-off-by: Gokcen Iskender <gokceng@gmail.com>
3 years agomgr/volumes/fs/operations : Fix flake8 issues 43390/head
Anuradha Kulkarni [Fri, 1 Oct 2021 19:25:37 +0000 (15:25 -0400)]
mgr/volumes/fs/operations : Fix flake8 issues
Fixes : https://tracker.ceph.com/issues/51396

Signed-off-by: Anuradha Kulkarni <anuradhak1990@gmail.com>
3 years agomgr/volumes: fix various flake8 issues 43387/head
Almen Ng [Fri, 1 Oct 2021 18:00:20 +0000 (14:00 -0400)]
mgr/volumes: fix various flake8 issues

Fixes: https://tracker.ceph.com/issues/51380
Signed-off-by: Almen Ng <almen000509@gmail.com>
3 years agoceph-monstore-tool: include rotating keys in rebuilt mon 43335/head
Sage Weil [Wed, 29 Sep 2021 20:29:43 +0000 (16:29 -0400)]
ceph-monstore-tool: include rotating keys in rebuilt mon

This avoids an initial period after mon restart in which there are no
rotating keys and authentication can fail.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomon,auth: fix proposal of rotating keys
Sage Weil [Wed, 29 Sep 2021 20:28:07 +0000 (16:28 -0400)]
mon,auth: fix proposal of rotating keys

Instead of updating the live CephxKeyServer's rotating_keys and also
including them in a paxos proposal, propose new keys only in the proposal,
and only make them live once they are committed.  This keeps mons fully in
sync and avoids any inconsistency between the live behavior and committed
state (e.g., stale or divergent keys being applied and passed out to
daemons).

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/suites/rados/singleton/rebuild-mon-db: debug auth 30
Sage Weil [Tue, 28 Sep 2021 17:05:22 +0000 (13:05 -0400)]
qa/suites/rados/singleton/rebuild-mon-db: debug auth 30

Hunting https://tracker.ceph.com/issues/51815

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomon,auth: debug missing service secrets
Sage Weil [Tue, 28 Sep 2021 17:03:13 +0000 (13:03 -0400)]
mon,auth: debug missing service secrets

Hunting https://tracker.ceph.com/issues/51815

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #41255 from rhcs-dashboard/angular-11-upgrade
Ernesto Puerta [Fri, 1 Oct 2021 16:13:09 +0000 (18:13 +0200)]
Merge pull request #41255 from rhcs-dashboard/angular-11-upgrade

mgr/dashboard: Angular v11 Migration

Reviewed-by: aaryanporwal <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #42716 from sshambar/bug-52002
Ernesto Puerta [Fri, 1 Oct 2021 16:12:11 +0000 (18:12 +0200)]
Merge pull request #42716 from sshambar/bug-52002

mgr/dashboard,prometheus: fix handling of server_addr

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: sebastian-philipp <NOT@FOUND>
Reviewed-by: sshambar <NOT@FOUND>
3 years agoMerge pull request #43277 from anthonyeleven/anthonyeleven/fix-47839
zdover23 [Fri, 1 Oct 2021 14:22:22 +0000 (00:22 +1000)]
Merge pull request #43277 from anthonyeleven/anthonyeleven/fix-47839

ceph: add example BlueStore migration via the ceph-objectstore-tool dup op

Reviewed-by: Zac Dover <zac.dover@gmail.com>
3 years agoMetricCollector.h: Add check to prevent mgr from crashing 43384/head
Aswin Toni [Fri, 1 Oct 2021 14:12:22 +0000 (16:12 +0200)]
MetricCollector.h: Add check to prevent mgr from crashing

Fixes: https://tracker.ceph.com/issues/52801
Signed-off-by: Aswin Toni <aswin.toni@cern.ch>
3 years agodoc: fixed typo in terminology 43383/head
Jos Collin [Thu, 9 Sep 2021 12:49:30 +0000 (18:19 +0530)]
doc: fixed typo in terminology

Signed-off-by: Jos Collin <jcollin@redhat.com>
3 years agoosd/scrub: Add scrub duration to pg dump stats 42977/head
Aishwarya Mathuria [Tue, 24 Aug 2021 14:55:02 +0000 (20:25 +0530)]
osd/scrub: Add scrub duration to pg dump stats

Addition of a new column, SCRUB_DURATION, to the pg stats that stores the time taken for a PG scrub.

Fixes: https://tracker.ceph.com/issues/52605
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
3 years agomgr/dashboard: Remove i18n Warning about duplicate id 41255/head
Nizamudeen A [Thu, 30 Sep 2021 11:48:14 +0000 (17:18 +0530)]
mgr/dashboard: Remove i18n Warning about duplicate id

Fixes: https://tracker.ceph.com/issues/50268
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: Taking care of deprecation warnings and other errors
Nizamudeen A [Thu, 30 Sep 2021 07:47:15 +0000 (13:17 +0530)]
mgr/dashboard: Taking care of deprecation warnings and other errors

1. deprecation  group is deprecated: This API is not typesafe and can result in issues with Closure Compiler renaming. Use the `FormBuilder#group` overload with `AbstractControlOptions` instead.

2. cypress/integration/rgw/users.po.ts(113,23): error TS2345: Argument of type 'void' is not assignable to parameter of type 'string'.

3. Cannot find module 'isomorphic-form-data' from 'node_modules/swagger-ui/dist/swagger-ui.js'

Fixes: https://tracker.ceph.com/issues/50268
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agomgr/dashboard: Angular v11 Migration
Nizamudeen A [Tue, 29 Jun 2021 09:30:34 +0000 (15:00 +0530)]
mgr/dashboard: Angular v11 Migration

Fixes: https://tracker.ceph.com/issues/50268
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agoosd: do not promote objects if op is is_dirty 43380/head
myoungwon oh [Fri, 1 Oct 2021 01:29:32 +0000 (10:29 +0900)]
osd: do not promote objects if op is is_dirty

manifest object contains object_info_t even if the object
is flushed, so OSD can reply the result of is_dirty.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agoosd: trim corresponding chunks on tier_evict 43379/head
myoungwon oh [Fri, 1 Oct 2021 01:18:49 +0000 (10:18 +0900)]
osd: trim corresponding chunks on tier_evict

This commit trims chunks on the object even if the size of
the chunks is not equal to the object size.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agorados: build minimally when "WITH_MGR" is off 43378/head
J. Eric Ivancich [Thu, 30 Sep 2021 22:18:30 +0000 (18:18 -0400)]
rados: build minimally when "WITH_MGR" is off

Minimize footprint of the MGR when WITH_MGR is off. Include the
minimal in MON. Don't include any MGR tests.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agomgr/volumes/fs: add extra blank line 43375/head
Manasvi Goyal [Thu, 30 Sep 2021 20:08:31 +0000 (01:38 +0530)]
mgr/volumes/fs: add extra blank line

Fixes: https://tracker.ceph.com/issues/51392
Signed-off-by: Manasvi Goyal <mg.manasvi@gmail.com>
3 years agoMerge PR #43323 into master
Patrick Donnelly [Thu, 30 Sep 2021 16:50:54 +0000 (12:50 -0400)]
Merge PR #43323 into master

* refs/pull/43323/head:
mgr/volumes/fs: add extra blank line

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge PR #43322 into master
Patrick Donnelly [Thu, 30 Sep 2021 16:49:37 +0000 (12:49 -0400)]
Merge PR #43322 into master

* refs/pull/43322/head:
mgr/volumes/fs: add extra blank line

Reviewed-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoMerge pull request #36733 from majianpeng/rocksdb-remove-redundant-perfcount
Yuri Weinstein [Thu, 30 Sep 2021 14:52:30 +0000 (07:52 -0700)]
Merge pull request #36733 from majianpeng/rocksdb-remove-redundant-perfcount

kv/RocksdbStore: remove perfcounter l_rocksdb_gets.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agoMerge pull request #34624 from zhouyh-orcadt/fix_optracker_coredump
Yuri Weinstein [Thu, 30 Sep 2021 14:51:32 +0000 (07:51 -0700)]
Merge pull request #34624 from zhouyh-orcadt/fix_optracker_coredump

common/TrackedOp: fix osd reboot optracker coredump

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agoMerge pull request #43355 from rzarzynski/wip-crimson-write_meta
Kefu Chai [Thu, 30 Sep 2021 14:16:51 +0000 (22:16 +0800)]
Merge pull request #43355 from rzarzynski/wip-crimson-write_meta

crimson/osd: write the 'osd_key' meta on OSD::mkfs().

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43364 from rzarzynski/wip-crimson-canceliores-on-stop
Kefu Chai [Thu, 30 Sep 2021 14:14:11 +0000 (22:14 +0800)]
Merge pull request #43364 from rzarzynski/wip-crimson-canceliores-on-stop

crimson/osd: cancel IO reservations on PG::stop().

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoqa/mgr/dashboard/test_pool: don't check HEALTH_OK 43256/head
Ernesto Puerta [Wed, 22 Sep 2021 12:25:44 +0000 (14:25 +0200)]
qa/mgr/dashboard/test_pool: don't check HEALTH_OK

Fixes: https://tracker.ceph.com/issues/48845
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
3 years agocrimson/osd: cancel IO reservations on PG::stop(). 43364/head
Radoslaw Zarzynski [Thu, 30 Sep 2021 09:53:50 +0000 (09:53 +0000)]
crimson/osd: cancel IO reservations on PG::stop().

`PG::request_{local,remote}_recovery_reservation()` dynamically allocates
up to 2 instances of `LambdaContext<T>` and transfers their ownership to
the `AsyncReserver<T, F>`. This is expressed in raw pointers (`new` and
`delete`) notion. Further analysis shows the only place where `delete`
for these objects is called is the `AsyncReserver::cancel_reservation()`.
In contrast to the classical OSD, crimson doesn't invoke the method when
stopping a PG during the shutdown sequence. This would explain the
following ASan issue observed at Sepia:

```
Direct leak of 576 byte(s) in 24 object(s) allocated from:
    #0 0x7fa108fc57b0 in operator new(unsigned long) (/lib64/libasan.so.5+0xf17b0)
    #1 0x55723d8b0b56 in non-virtual thunk to crimson::osd::PG::request_local_background_io_reservation(unsigned int, std::unique_ptr<PGPeeringEvent, std::default_delete<PGPeeringEvent> >, std::unique_ptr<PGPeeringEvent, std::default_delete<PGPeeringEvent> >) (/usr/bin/ceph-osd+0x24d95b56)
    #2 0x55723f1f66ef in PeeringState::WaitDeleteReserved::WaitDeleteReserved(boost::statechart::state<PeeringState::WaitDeleteReserved, PeeringState::ToDelete, boost::mpl::list<mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, (boost::statechart::history_mode)0>::my_context) (/usr/bin/ceph-osd+0x266db6ef)
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #43202 from karmab/kcli_doc
Sebastian Wagner [Thu, 30 Sep 2021 10:01:54 +0000 (12:01 +0200)]
Merge pull request #43202 from karmab/kcli_doc

doc: update kcli information

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43356 from tchaikov/wip-doc-cephadm
Sebastian Wagner [Thu, 30 Sep 2021 08:29:00 +0000 (10:29 +0200)]
Merge pull request #43356 from tchaikov/wip-doc-cephadm

doc/cephadm/services: unindent note section

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/nfs: stick to lazy evaluation of logger messages 43357/head
Ramana Raja [Thu, 30 Sep 2021 01:13:09 +0000 (21:13 -0400)]
mgr/nfs: stick to lazy evaluation of logger messages

Signed-off-by: Ramana Raja <rraja@redhat.com>
3 years agomgr/nfs: change _cmd_rgw_export_create_rgw() name
Varsha Rao [Mon, 16 Aug 2021 05:46:45 +0000 (11:16 +0530)]
mgr/nfs: change _cmd_rgw_export_create_rgw() name

To maintain uniformity in naming, modify _cmd_rgw_export_create_rgw() name to
_cmd_nfs_export_create_rgw().

Signed-off-by: Varsha Rao <varao@redhat.com>
3 years agomgr/nfs: don't log fsal keys
Varsha Rao [Mon, 16 Aug 2021 05:39:18 +0000 (11:09 +0530)]
mgr/nfs: don't log fsal keys

FSAL keys are written to export objects. Don't log it, instead log the initial
export before generating keys and user config object mostly will not contain
export block. It's okay to log user config object content.

Signed-off-by: Varsha Rao <varao@redhat.com>
3 years agodoc/cephadm/services: unindent note section 43356/head
Kefu Chai [Wed, 29 Sep 2021 23:22:09 +0000 (07:22 +0800)]
doc/cephadm/services: unindent note section

before this change the note on "apply" command is embedded in the note
on "_no_schedule". and they are not related. so let's move the former
out. also, highlight the yaml file sample in YAML.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agocrimson/osd: write the 'ready' meta on OSD::mkfs(). 43355/head
Radoslaw Zarzynski [Wed, 29 Sep 2021 20:12:18 +0000 (20:12 +0000)]
crimson/osd: write the 'ready' meta on OSD::mkfs().

This is for the compliance with the classical OSD. No problem
with lack of this file has been identified yet.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agocrimson/osd: write the 'osd_key' meta on OSD::mkfs().
Radoslaw Zarzynski [Wed, 29 Sep 2021 20:00:20 +0000 (20:00 +0000)]
crimson/osd: write the 'osd_key' meta on OSD::mkfs().

This commit fixes an issue identified during the Rook-crimson effort.

Missing the `write_meta()` on `osd_key` made the CephX inoperational
because of imposibility to load the keyring. Disabling CephX in turn
caused the auth method negotation to fail when reaching out to a monitor.

```
ERROR 2021-09-28 21:19:46,598 [shard 0] none - auth: unable to find a keyring on /var/lib/ceph/osd/ceph-0/keyring: (2) No such file or directory
ERROR 2021-09-28 21:19:46,598 [shard 0] none - AuthRegistry(0x7fa38c322b68) no keyring found at /var/lib/ceph/osd/ceph-0/keyring, disabling cephx
...
INFO  2021-09-28 21:19:46,601 [shard 0] monc - get_auth_request(con=[client.?(temp_mon_client) 172.17.0.1:0/2910147961@63138 >> mon.? v2:10.108.187.31:3300/0], auth_method=0)
INFO  2021-09-28 21:19:46,601 [shard 0] monc - get_auth_request no methods is supported
...
WARN  2021-09-28 21:20:06,612 [shard 0] monc - cannot establish the active_con with any mon
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #43340 from athanatos/sjust/wip-seastore-throttle
Samuel Just [Wed, 29 Sep 2021 19:29:23 +0000 (12:29 -0700)]
Merge pull request #43340 from athanatos/sjust/wip-seastore-throttle

crimson/seastore: fix segment_cleaner blocked_io_wake crash

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agoMerge PR #43287 into master
Sage Weil [Wed, 29 Sep 2021 18:38:47 +0000 (14:38 -0400)]
Merge PR #43287 into master

* refs/pull/43287/head:
mgr/rook, qa/tasks/rook: change rgw daemon service name
mgr/rook: fix placement_spec_to_node_selector
mgr/rook: orch rm no longer uses rook api delete
qa/tasks/rook: fix cluster deletion hanging due to CephObjectStore CR
mgr/rook: use default replication size in orch apply rgw
mgr/rook: add placement specs to apply rgw

Reviewed-by: Sage Weil <sage@redhat.com>
3 years agoMerge pull request #43255 from rhcs-dashboard/fix-49344-master
Ernesto Puerta [Wed, 29 Sep 2021 18:23:23 +0000 (20:23 +0200)]
Merge pull request #43255 from rhcs-dashboard/fix-49344-master

qa/mgr/dashboard: add extra wait to test

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #43341 from pdvian/wip-doc-mon-bootstrap
Kefu Chai [Wed, 29 Sep 2021 15:22:24 +0000 (23:22 +0800)]
Merge pull request #43341 from pdvian/wip-doc-mon-bootstrap

doc/dev/mon-bootstrap: fix typo

Reviewed-by: Varsha Rao <varao@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agodoc: update kcli information 43202/head
karmab [Fri, 17 Sep 2021 06:18:16 +0000 (08:18 +0200)]
doc: update kcli information

3 years agoMerge pull request #42353 from ifed01/wip-ifed-fix-invalid-offset-repair
Kefu Chai [Wed, 29 Sep 2021 14:54:15 +0000 (22:54 +0800)]
Merge pull request #42353 from ifed01/wip-ifed-fix-invalid-offset-repair

os/bluestore: fix writing to invalid offset when repairing

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agoMerge pull request #39062 from fyzard1991/master
Kefu Chai [Wed, 29 Sep 2021 14:52:11 +0000 (22:52 +0800)]
Merge pull request #39062 from fyzard1991/master

mon/OSDMonitor:Make the pg_num check more accurate

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43289 from tchaikov/wip-52705
Kefu Chai [Wed, 29 Sep 2021 14:50:02 +0000 (22:50 +0800)]
Merge pull request #43289 from tchaikov/wip-52705

os/bluestore: list obj which equals to pend

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Xinze Chi <xinze@xsky.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
3 years agoMerge pull request #42821 from rhcs-dashboard/force-maintenance-workflow
Ernesto Puerta [Wed, 29 Sep 2021 11:36:45 +0000 (13:36 +0200)]
Merge pull request #42821 from rhcs-dashboard/force-maintenance-workflow

mgr/dashboard: Move force maintenance test to the workflow test suite

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #43246 from Daniel-Pivonka/cephadm-iscsi-trust-mgr-ips
Sebastian Wagner [Wed, 29 Sep 2021 10:37:44 +0000 (12:37 +0200)]
Merge pull request #43246 from Daniel-Pivonka/cephadm-iscsi-trust-mgr-ips

mgr/cephadm: populate trusted_ip_list in iscsi-gateway.cfg with mgr ips

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43309 from guits/iscsi_fixes
Sebastian Wagner [Wed, 29 Sep 2021 10:37:02 +0000 (12:37 +0200)]
Merge pull request #43309 from guits/iscsi_fixes

cephadm/iscsi: fix a typo

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43319 from guits/workaround_tcmurunner_log
Sebastian Wagner [Wed, 29 Sep 2021 10:36:42 +0000 (12:36 +0200)]
Merge pull request #43319 from guits/workaround_tcmurunner_log

cephadm: modify iscsi containers bindmount

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43321 from adk3798/remove-exporter
Sebastian Wagner [Wed, 29 Sep 2021 10:36:06 +0000 (12:36 +0200)]
Merge pull request #43321 from adk3798/remove-exporter

mgr/cephadm: remove cephadm exporter code

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43226 from TRYTOBE8TME/wip-rgw-amqp-minor-nit
Yuval Lifshitz [Wed, 29 Sep 2021 09:32:55 +0000 (12:32 +0300)]
Merge pull request #43226 from TRYTOBE8TME/wip-rgw-amqp-minor-nit

src/test: Minor nit from PR #43025

3 years agocrimson/os/seastore/transaction_manager: limit callers to reserve_projected_usage 43340/head
Samuel Just [Wed, 29 Sep 2021 01:46:25 +0000 (18:46 -0700)]
crimson/os/seastore/transaction_manager: limit callers to reserve_projected_usage

Adds an exclusive stage for obtaining projected usage as well as an
unordered one for submitting ool writes.  This should allow for a
straightforward wait-list when io is blocked while still allowing
concurrent submission of ool writes otherwise.

Fixes: https://tracker.ceph.com/issues/52698
Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/segment_cleaner: track projected usage for in progress operations
Samuel Just [Wed, 29 Sep 2021 01:43:02 +0000 (18:43 -0700)]
crimson/os/seastore/segment_cleaner: track projected usage for in progress operations

We're going to want to permit multiple transactions to be writing
concurrently.  Replace await_hard_limits() with a mechanism that
remembers bytes that will be used by in-progress operations.

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agodoc/dev/mon-bootstrap: fix typo 43341/head
Prashant D [Wed, 29 Sep 2021 06:13:56 +0000 (07:13 +0100)]
doc/dev/mon-bootstrap: fix typo

Signed-off-by: Prashant D <pdhange@redhat.com>
3 years agocrimson/os/seastore/segment_manager/block: add debugging to remaining invarg case
Samuel Just [Wed, 29 Sep 2021 03:26:21 +0000 (20:26 -0700)]
crimson/os/seastore/segment_manager/block: add debugging to remaining invarg case

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/segment_manager/block: add method name debug prefix
Samuel Just [Wed, 29 Sep 2021 03:25:55 +0000 (20:25 -0700)]
crimson/os/seastore/segment_manager/block: add method name debug prefix

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agomgr/nfs: Add more debug log messages
Varsha Rao [Mon, 16 Aug 2021 05:20:48 +0000 (10:50 +0530)]
mgr/nfs: Add more debug log messages

Fixes: https://tracker.ceph.com/issues/52274
Signed-off-by: Varsha Rao <varao@redhat.com>
3 years agoMerge pull request #43327 from cyx1231st/wip-seastore-ool-metrics
Samuel Just [Wed, 29 Sep 2021 00:38:13 +0000 (17:38 -0700)]
Merge pull request #43327 from cyx1231st/wip-seastore-ool-metrics

crimson/os/seastore: introduce ool related metrics with misc improvements

Reviewed-by: Samuel Just <sjust@redhat.com>