client: simplify some filepath constructions

And add notes where it could maybe be simplified further.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

client: print readable encrypted names

Replace non-printable characters with '.'.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

client: catch error opening snapdir inside snap

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

client: do not wrap ceph special names

This avoids encrypting .snap which prevents Client::_lookup from opening the
snapdir.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

client: remove remaining fscrypt conflicts

There also seems to be some missing calls to

    gen_inherited_fscrypt_auth

?

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

client: use path walk and on-the-fly enc/dec for fscrypt

The code before would encrypt/decrypt the dentry and store the result as the
dentry name. This would cause the client to have a different view of the dentry
names compared to the MDS. This created an unnecessary and complex divergence
that requires fixing the name in any code path involving the MDS.

Instead, maintain the same view as before with the MDS. The client uses the new
`Client::path_walk`, `Client::_wrap_name`, and `Client::_unwrap_name`
mechanisms to correctly change from the application's namespace (unencrypted /
case insensitve names) to the Client/MDS namespace.

The complication here is that the Client now needs to recompute the
encrypted/decrypted name for any path walk. This can and should be mitigated by
memoizing the results of the decryption/encryption. This is particularly
important as we can keep the decrypted names in a separate memory region that
is protected from core dump / trace inspection.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

client: Use correct sizes in write_success

Write success had some incorrect usage of sizes.
request_[size|offset] refers to logical size
toalwritten + offset refers to written to osd size

Fixes: https://tracker.ceph.com/issues/70193
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Use PATH_MAX for max size of fscrypt enabled symlinks

Fixes: https://tracker.ceph.com/issues/70194
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

cephfs/test_volumes: Create tests for enctag

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

doc: Add documentation for enctag in subvolume

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Add is_encrypted libcephfs api

Given a fd, will return if is encrypted or not.
Optionally, an enctag will be returned if set.

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

mgr/volumes: Add enctag to subvol

Add functionality to support enctag for subvols. This
will be useful for app or administrator to know which
master key to use.

Fixes: https://tracker.ceph.com/issues/69693
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Use new errno identifiers

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: use fscrypt headers provided by linux

Fixes: https://tracker.ceph.com/issues/68116
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Fix up a few things in read_sync path

Fix up a few things in read_sync path
1. File size may not be updated locally, do not check for trim read
2. Do not get_cap before RMW, each do_write takes care of having proper caps

Fixes: https://tracker.ceph.com/issues/69796
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Calculate len before prepare_data_read

Fixes: https://tracker.ceph.com/issues/69797
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: During fscrypt write, ensure we get Fr cap

During fscrypt write will require Fr cap. It's best to ensure
this requirement is handled at the cap level instead of at the mode
level. Otherwise, O_WRONLY flag won't be enforced.

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

test/libcephfs: Add skips to tests where mount root is a subdir

When dir_prefix is a subdir, skip tests that expect
behavior of "/" to be on root of filesystem.

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Use enc_name when linking a fscrypt enabled inode

Fixes: https://tracker.ceph.com/issues/64163
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Do not encrypt '.' or '..'

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Use symlink_plain for decrypted fscrypt name

Use symlink_plain for only the value of a decrypted fscrypt
dname.

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: fscrypt last block

Support two edge cases in fscrypt last block.

1. When fscrypt last block is not the first block
2. Make sure to clean up SaferCond, allowing for successive
   truncates utilizing lastblock.

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Do not decrypt bl on trim read

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: set symlink dest to proper value

Fixes: https://tracker.ceph.com/issues/69442
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

test: Add function policy populator for reuse in fscrypt tests.

Fixes: https://tracker.ceph.com/issues/69161
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: change conditional to check for is locked.

Fixes: https://tracker.ceph.com/issues/64137
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

fuse client, fscrypt, test: Implement and create tests for S_ENCRYPTED in inode i_flags

This PR adds test for S_ENCRYPTED bit in the i_flags field of Inode.
The test implements 2 quering methods: using FS_IOC_GETFLAGS and STATX_ATTR_ENCRYPTED

Fixes: https://tracker.ceph.com/issues/64129
Author: Igor Golikov <igolikov@ibm.com>
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Use correct sizes on write_success

Fixes: https://tracker.ceph.com/issues/69302
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: clear logical size on open(O_TRUNC)

Fixes: https://tracker.ceph.com/issues/65613
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

test, client: implement tests for not supported FALLOC ops, use policy to determine the padding size for encrypted filename

Adding test for not supported FALLOC ops on the encypted tree
Using policy to determine the padding length for encrypted file names and symlinks

Fixes: https://tracker.ceph.com/issues/64162
https://tracker.ceph.com/issues/64131
Author: Igor Golikov <igolikov@ibm.com>
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Add fscrypt last block

Add logic to support fscrypt last block. Includes sending
truncated last block data (decrypted->trunc->encrypted)
from client to mds. The server then writes the last block
on successful truncate.

Fixes: https://tracker.ceph.com/issues/69160
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Ensure file_cache cap is released.

Fixes: https://tracker.ceph.com/issues/68798
Fixes: https://tracker.ceph.com/issues/68831
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Various fixes to fix multi-fuse client

Provide various fixes in which size used in
multi-fuse client tests.

Fixes: https://tracker.ceph.com/issues/68431
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

qa: Convert and create tests for libcephfs fscrypt

Convert existing tests to use teuthology framework.
Create tests to test N>1 fscrypt clients

Fixes: https://tracker.ceph.com/issues/66577
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Update fscrypt_file when mds info is newer

Fixes: https://tracker.ceph.com/issues/68233
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

qa: Add tests of interopability of fscrypt between fuse/kernel

Fixes: https://tracker.ceph.com/issues/66577
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

ObjectCacher: handle nullptr hole case

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

ObjectCacher: On RetryRead, ensure "hole" value is used

On C_RetryRead, ensure "hole" value instead of pointer
to a pointer is used to allow populating vector of holes.

Fixes: https://tracker.ceph.com/issues/67659
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: When calling update_inode_file_size, provide correct size

Fixes: https://tracker.ceph.com/issues/67559
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Use effective_size in eof read

Fixes: https://tracker.ceph.com/issues/67347
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client/FSCrypt: securely erase crypto key

Fixes: https://tracker.ceph.com/issues/64136
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Implement status for fscrypt key status

Fixes: https://tracker.ceph.com/issues/64130
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Add busy case on key removal

Fixes: https://tracker.ceph.com/issues/64159
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

fuse: enable ioctl on dir for fscrypt

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

src/test/libcephfs: add test cases for fscrypt key removal busy case

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

qa: Added workunits for testing problem snippets on rmw workloads

Fixes: https://tracker.ceph.com/issues/66038
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

qa: Allow fscrypt testing on fuse

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: fix non-encrypted case in read_sync

Only append pbl to bl if encrypted case.

Fixes: https://tracker.ceph.com/issues/65964
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: fscrypt rmw fails when endoff end of block or file
Fscrypt rmw fails when end of a write lines up with end of
a block or end of the file.

Fixes: https://tracker.ceph.com/issues/65745
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: During lookup of fscrypt symlink, use target fscrypt info.

During a lookup of fscrypt enabled symlink, use target fscrypt
info. This must be used because enc key for each file is derived
from master_key+nonce.

Fixes: https://tracker.ceph.com/issues/65615
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Fix logic in need read start/end to account for fscrypt.

Fix the logic in need read start/end. We need to make sure that a
whole block is read when a rmw is issued, regardless if it starts
at offset 0 or not. Change size that may be read from where offset
starts to the whole fscrypt block.

Fixes: https://tracker.ceph.com/issues/64819
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: After a rebase, no lock is necessary.

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

Client: fix O_TRUNC issue

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Ensure symlink plaintext is set

When creating symlink, ensure symlink_plain is set in fscrypt and
non-fscrypt cases.

Fixes: https://tracker.ceph.com/issues/64691
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: rmw doesn't get_cap_ref like it should. After rmw,
it put_cap_ref and it didn't happen. Issue with bool need_read.

Fixes: https://tracker.ceph.com/issues/64307
Signed-off-by: Christopher Hoffman <choffman@redhat.com>

Populate add key return

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

test: Add test for semantics

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: On fscrypt enabled directories, only allow read/write to files
in dir when unlocked. Client should not be able to read/write the encrypted payload.

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

fscrypt: Add tests for add key, remove key, set policy.

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client: Allow setpolicy only on dir and when it is empty.

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

Add multi user support on a unlock claim.

Signed-off-by: Christopher Hoffman <choffman@redhat.com>

client,test,osdc: add beginnings of fscrypt support

Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>

Merge pull request #64981 from zdover23/wip-doc-2025-08-12-cephfs-troubleshooting

doc/cephfs: edit troubleshooting.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #64930 from zdover23/wip-doc-2025-08-10-cephfs-troubleshooting-3

doc/cephfs: edit troubleshooting.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #64923 from zdover23/wip-doc-2025-08-09-cephfs-troubleshooting-3

doc/cephfs: edit troubleshooting.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #64922 from zdover23/wip-doc-2025-08-09-cephfs-troubleshooting-2

doc/cephfs: edit troubleshooting.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #64811 from ceph/fix-dependabot_dashboard_upgrades-main

dependabot: stop dashboard npm upgrade PRs

doc/cephfs: edit troubleshooting.rst

Edit the "Mount 5 Error" and "Mount 12 Error" sections of
doc/cephfs/troubleshooting.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #64982 from zdover23/wip-doc-2025-08-12-cephfs-troubleshooting-2

doc/cephfs: edit troubleshooting.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #65008 from chanyoung/omap-fast-check-mappings

test/crimson/seastore/test_omap_manager: faster check mappings

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #65013 from Naveenaidu/wip-naveen-update-cephadm-docs

doc/man/cephadm: update `--orphan-initial-daemons` argument description

Merge pull request #63938 from tchaikov/wip-osd-recalc-decode

osd: recalculate coll_t::_str during decode() to fix stale values

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #61770 from rkachach/fix_issue_69484

Prometheus configuration generation improvements

Reviewed-by: nizamial09 <nia@redhat.com>

doc/man/cephadm: update --orphan-initial-daemons argument description

Signed-off-by: Naveen Naidu <naveen.naidu@ibm.com>

test/crimson/seastore/test_omap_manager: faster check mappings

Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>

Merge pull request #64998 from chanyoung/monotonic

test/crimson/seastore/test_omap_manager: add monotonic inc UT

Reviewed-by: Samuel Just <sjust@redhat.com>

doc/cephfs: edit troubleshooting.rst

Edit the "Dynamic Debugging" section of doc/cephfs/troubleshooting.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
doc/cephfs: improve dynamic debugging section

Signed-off-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #64976 from phlogistonjohn/jjm-container-pkgs

container: support building a container image with custom packages

Merge pull request #64942 from chanyoung/redesign_depth3_split

test/crimson/seastore/test_omap_manager: redesign depth3 split

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #64964 from edwinzrodriguez/ceph-wip-72454

test/librbd/fsx: initialize effective_size variable

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge PR #64821 into main

* refs/pull/64821/head:
.github: only run redmine-upkeep actions from ceph/ceph.git
script/redmine-upkeep: add transform to resolve merged issue
script/redmine-upkeep: set default filter name/priority
script/redmine-upkeep: raise exception for PUT failures
script/redmine-upkeep: finish transform after application
script/redmine-upkeep: indicate log location in comments
script/redmine-upkeep: check envvar to see if running as action
script/redmine-upkeep: bullet issue list
script/redmine-upkeep: add stronger note on upkeep-failed tag in failure message
script/redmine-upkeep: do not raise commennt if upkeep-failed already present
script/redmine-upkeep: correct filter out of upkeep-failed
.github/workflows: allow redmine-upkeep to write comments

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

.github: only run redmine-upkeep actions from ceph/ceph.git

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: add transform to resolve merged issue

Few things:

- Add priority to transforms. Largely this is to have the "merged"
  transformation run first to update the "Merge Commit" field of the ticket
  before any other transform intends to look at that field. This avoids
  duplicating logic to set the Merge Commit field.

- Fix a bug where the github API cannot be trusted to indicate the Merge Commit
  for a PR. When the branch is rename or changed, the github backend clearly
  gets confused and gives the "HEAD" commit instead.

- Add new transform to resolve tickets that are merged to either Resolved or
  Pending Backport status.

* Note: filters on TAGS cannot be combined. There is some restructuring to deal with that.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #64938 from chanyoung/omap-binary-search

crimson/.../string_kv_node_layout: switch linear to binary search

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

script/redmine-upkeep: set default filter name/priority

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: raise exception for PUT failures

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: finish transform after application

Doing this at the end makes confusing error messages.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: indicate log location in comments

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: check envvar to see if running as action

This obviates --github-action in the workflow.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: bullet issue list

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: add stronger note on upkeep-failed tag in failure message

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: do not raise commennt if upkeep-failed already present

If the script is run manually on an issue, don't leave a new comment if we
already have the issue tagged with upkeep-failed.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/redmine-upkeep: correct filter out of upkeep-failed

"!~" is the proper filter for "does not contain".

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

.github/workflows: allow redmine-upkeep to write comments

Fixes errors like:

    Posting a comment to GitHub PR #62992.
    GitHub API error posting comment to PR #62992: 401 Client Error: Unauthorized for url: https://api.github.com/repos/ceph/ceph/issues/62992/comments - Response: {"message":"Requires authentication","documentation_url":"https://docs.github.com/rest/issues/comments#create-an-issue-comment","status":"401"}

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

test/crimson/seastore/test_omap_manager: add monotonic inc UT

Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>

Merge pull request #64501 from aainscow/ec_fixpack2_pr

Optimized Erasure Coding - Fixpack 2

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #64926 from chanyoung/faster-seastore-eph-dev

crimson/.../ephemeral: faster seastore eph dev

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #64861 from ronen-fr/wip-rf-pgdict

test/standalone/scrub: improve build_pg_dicts() performance

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #64253 from arm7star/rgw-openssl

rgw, common: OpenSSL provider support

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #64675 from chanyoung/fix-omap-balance

crimson/.../omap_btree_node_impl: pass pivot_idx for balancing

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>