]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
19 months agodoc/radosgw: update link in rgw-cache.rst 54805/head
Zac Dover [Tue, 5 Dec 2023 19:46:26 +0000 (20:46 +0100)]
doc/radosgw: update link in rgw-cache.rst

Update link in doc/radosgw/rgw-cache.rst. The link updated here is a
link to all the Nginx configuration files. The old link was broken. This
update comes to us from an anonymous report on
https://pad.ceph.com/p/Report_Documentation_Bugs.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e80d560d97bd44f9a308916a099bf9391813d95b)

19 months agoMerge pull request #54753 from zdover23/wip-doc-2023-12-02-backport-54752-to-reef
zdover23 [Tue, 5 Dec 2023 19:35:25 +0000 (20:35 +0100)]
Merge pull request #54753 from zdover23/wip-doc-2023-12-02-backport-54752-to-reef

reef: doc/radosgw: fix formatting

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
19 months agoMerge pull request #54775 from zdover23/wip-doc-2023-12-04-backport-54774-to-reef
Anthony D'Atri [Mon, 4 Dec 2023 21:14:39 +0000 (16:14 -0500)]
Merge pull request #54775 from zdover23/wip-doc-2023-12-04-backport-54774-to-reef

reef: doc: Fixes two typos and grammatical errors. Signed-off-by: Sina Ahma…

19 months agodoc: Fixes two typos and grammatical errors. Signed-off-by: Sina Ahmadi <sinatak1373... 54775/head
sinashan [Mon, 4 Dec 2023 19:02:54 +0000 (14:02 -0500)]
doc: Fixes two typos and grammatical errors. Signed-off-by: Sina Ahmadi <sinatak1373@live.com>

(cherry picked from commit bc39adceba611b00c04a894039b4c3280434d3fa)

19 months agoMerge pull request #54316 from batrick/wip-63413-reef
Yuri Weinstein [Mon, 4 Dec 2023 16:08:20 +0000 (08:08 -0800)]
Merge pull request #54316 from batrick/wip-63413-reef

reef: mon: fix mds metadata lost in one case.

Reviewed-by: Rishabh Dave <ridave@redhat.com>
19 months agoMerge pull request #54313 from batrick/wip-63418-reef
Yuri Weinstein [Mon, 4 Dec 2023 16:07:48 +0000 (08:07 -0800)]
Merge pull request #54313 from batrick/wip-63418-reef

reef: mds: ensure next replay is queued on req drop

Reviewed-by: Rishabh Dave <ridave@redhat.com>
19 months agoMerge pull request #54207 from neesingh-rh/wip-63264-reef
Yuri Weinstein [Mon, 4 Dec 2023 16:07:20 +0000 (08:07 -0800)]
Merge pull request #54207 from neesingh-rh/wip-63264-reef

reef: mgr/volumes: fix `subvolume group rm` error message

Reviewed-by: Rishabh Dave <ridave@redhat.com>
19 months agoMerge pull request #54119 from joscollin/wip-62998-reef
Yuri Weinstein [Mon, 4 Dec 2023 16:06:46 +0000 (08:06 -0800)]
Merge pull request #54119 from joscollin/wip-62998-reef

reef: cephfs-shell: remove distutils Version classes because they're deprecated

Reviewed-by: Rishabh Dave <ridave@redhat.com>
19 months agoMerge pull request #53333 from dparmar18/wip-62738-reef
Yuri Weinstein [Mon, 4 Dec 2023 16:04:00 +0000 (08:04 -0800)]
Merge pull request #53333 from dparmar18/wip-62738-reef

reef: mds: accept human readable values for quotas

Reviewed-by: Rishabh Dave <ridave@redhat.com>
19 months agoMerge pull request #52268 from dparmar18/wip-61842-reef
Yuri Weinstein [Mon, 4 Dec 2023 16:02:58 +0000 (08:02 -0800)]
Merge pull request #52268 from dparmar18/wip-61842-reef

reef: mds: do not evict clients if OSDs are laggy

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
19 months agoMerge pull request #54762 from zdover23/wip-doc-2023-12-04-backport-54758-to-reef
Anthony D'Atri [Mon, 4 Dec 2023 14:03:54 +0000 (09:03 -0500)]
Merge pull request #54762 from zdover23/wip-doc-2023-12-04-backport-54758-to-reef

doc/rados: repair stretch-mode.rst

19 months agodoc/rados: repair stretch-mode.rst 54762/head
Zac Dover [Sun, 3 Dec 2023 12:17:46 +0000 (13:17 +0100)]
doc/rados: repair stretch-mode.rst

Remove a section of doc/rados/operations/stretch-mode.rst that I wrongly
re-included after its removal. The request for this (re)-removal is
here: https://github.com/ceph/ceph/pull/54689#discussion_r1413007655.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b73656787d618197c60372d1817eab35879fa478)

19 months agoMerge pull request #54756 from zdover23/wip-doc-2023-12-03-backport-54689-to-reef
Anthony D'Atri [Sun, 3 Dec 2023 14:50:41 +0000 (09:50 -0500)]
Merge pull request #54756 from zdover23/wip-doc-2023-12-03-backport-54689-to-reef

reef: doc/rados: update "stretch mode"

19 months agodoc/rados: update "stretch mode" 54756/head
PC-Admin [Tue, 28 Nov 2023 09:45:52 +0000 (17:45 +0800)]
doc/rados: update "stretch mode"

Update stretch mode docs, min_size and max_size are no longer defined in
the CRUSH map and the example rule given will fail to compile.

Specify that the tiebreaker data centre cannot be defined in CRUSH as
this produces an error.

Signed-off-by: Michael Collins <perthserverplus@gmail.com>
(cherry picked from commit 28551b41f878e7ad8f43e85bcbc8c9f64c07346c)

19 months agodoc/radosgw: fix formatting 54753/head
Zac Dover [Sat, 2 Dec 2023 05:38:28 +0000 (06:38 +0100)]
doc/radosgw: fix formatting

Repair the formatting of a string that had a string inside backticks
that itself was inside double asterisks. The presence of the asterisks
around the entire string caused the backticks to appear in the rendered
documentation.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 08ac3114e9fdb4fe7260002639058ded6e47a5ee)

19 months agoMerge pull request #54743 from zdover23/wip-doc-2023-12-01-backport-54730-to-reef
Anthony D'Atri [Fri, 1 Dec 2023 14:59:39 +0000 (09:59 -0500)]
Merge pull request #54743 from zdover23/wip-doc-2023-12-01-backport-54730-to-reef

reef: doc/glossary.rst: add "Monitor Store"

19 months agoMerge pull request #54746 from zdover23/wip-doc-2023-12-01-backport-54731-to-reef
Anthony D'Atri [Fri, 1 Dec 2023 14:58:24 +0000 (09:58 -0500)]
Merge pull request #54746 from zdover23/wip-doc-2023-12-01-backport-54731-to-reef

reef: doc/rados: improve formatting of log-and-debug.rst

19 months agodoc/rados: improve formatting of log-and-debug.rst 54746/head
Zac Dover [Thu, 30 Nov 2023 08:16:38 +0000 (09:16 +0100)]
doc/rados: improve formatting of log-and-debug.rst

Improve the arrangment of information in the section "Ceph Subsystems"
in doc/rados/troubleshooting/log-and-debug.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e63fa697b72b3c12d98169958b6dd74cc6eb5486)

19 months agodoc/glossary.rst: add "Monitor Store" 54743/head
Zac Dover [Thu, 30 Nov 2023 07:08:00 +0000 (08:08 +0100)]
doc/glossary.rst: add "Monitor Store"

Add the term "Monitor Store" to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 35d168826fd7b96cb73c6d799f7267a92f3453e9)

19 months agoMerge pull request #54407 from mihalicyn/wip-63476-reef
Yuri Weinstein [Thu, 30 Nov 2023 16:44:17 +0000 (08:44 -0800)]
Merge pull request #54407 from mihalicyn/wip-63476-reef

reef: MClientRequest: properly handle ceph_mds_request_head_legacy for ext_num_retry, ext_num_fwd, owner_uid, owner_gid

Reviewed-by: Dan Mick <dmick@redhat.com>
19 months agoMerge pull request #54677 from vshankar/wip-smoke-all-distro
Yuri Weinstein [Thu, 30 Nov 2023 16:43:04 +0000 (08:43 -0800)]
Merge pull request #54677 from vshankar/wip-smoke-all-distro

reef: qa: add centos_latest (9.stream) and ubuntu_20.04 yamls to supported-all-distro

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
19 months agoMerge pull request #54718 from rhcs-dashboard/reef-e2e-fedora-link-fix
Nizamudeen A [Thu, 30 Nov 2023 08:06:06 +0000 (13:36 +0530)]
Merge pull request #54718 from rhcs-dashboard/reef-e2e-fedora-link-fix

reef: mgr/dashboard: update fedora link for dashboard-cephadm-e2e test

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
19 months agoqa/cephfs: try usual umount if client blocklisting cannot be inferred 54677/head
Venky Shankar [Thu, 30 Nov 2023 05:31:05 +0000 (11:01 +0530)]
qa/cephfs: try usual umount if client blocklisting cannot be inferred

Signed-off-by: Venky Shankar <vshankar@redhat.com>
19 months agoqa: don't fail on gather_mount_info() failure
Venky Shankar [Tue, 28 Nov 2023 05:44:19 +0000 (11:14 +0530)]
qa: don't fail on gather_mount_info() failure

kernel 5.4 (Ubuntu 20.04) has the following missing commits:

5a9e2f5d5590 ceph: add ceph.{cluster_fsid/client_id} vxattrs
247b1f19dbeb ceph: add status debugfs file

fs suite relies on these debugfs entries to gather mount information
(client-id, addr/inst) which are required by some tests. In fs suite,
the disto kernel gets overridden by the testing kernel and therefore
even if Ubuntu 20.04 is chosen as the distro, the testing kernel is
installed. However, with smoke suite, the distro kernel is used and
the missing patches causes certain essential information gathering to
fail early on (client-id, etc..) causing the test to not even start
execution. PR #54515 fixes a bug in the client-id fetching path but
isn't complete due to the missing patches - details here:

        https://tracker.ceph.com/issues/63488#note-8

But its essential to have the smoke tests running since those tests
have lately uncovered bugs in the MDS (w/ distro kernels). In order
to benefit from those tests, this change ignores failures when
gathering mount information (which aren't used by the fs relevant
smoke tests). The test (in fs suite) that rely on this piece of
information would fail when run with 20.04 distro kernel (but the
fs suite overrides it with the testing kernel).

Signed-off-by: Venky Shankar <vshankar@redhat.com>
19 months agoqa: add centos_latest (9.stream) and ubuntu_20.04 yamls to supported-all-distro
Venky Shankar [Mon, 27 Nov 2023 05:12:02 +0000 (10:42 +0530)]
qa: add centos_latest (9.stream) and ubuntu_20.04 yamls to supported-all-distro

A bug in Ceph MDS (MDS crash!) is seen with distos using a not-so-recent kernel
(5.4ish). This crash was first seen in quincy smoke run and the problematic
backport change was reverted. The smoke suite chooses a random distro for each
job, so to hit this bug, the appropriate distro needs to be (randomly) get chosen.

This change point the smoke suite to run against all supported distros.

This effects suites that point to supported-all-distro (powercycle) since it
bloats up the number of jobs. E.g., currently, without --subset, powercycle:osd

          INFO:teuthology.suite.run:0/336 jobs were filtered out.

vs

(with this change)

          Unable to schedule 560 jobs, too many jobs, when maximum 500 jobs allowed.

For smoke suite

          INFO:teuthology.suite.run:Scheduled 24 jobs in total.

vs

(with this change)

           INFO:teuthology.suite.run:Scheduled 120 jobs in total.

Eventually, with PR #46882, then testing kernel will no longer override the
distro kernel in fs suite, so we should get good coverage then.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
19 months agoqa: point ubuntu_latest.yaml to latest (22.04)
Venky Shankar [Mon, 27 Nov 2023 05:10:43 +0000 (10:40 +0530)]
qa: point ubuntu_latest.yaml to latest (22.04)

Signed-off-by: Venky Shankar <vshankar@redhat.com>
19 months agoqa/smoke: run smoke suite with all supported distros
Venky Shankar [Mon, 27 Nov 2023 04:58:39 +0000 (10:28 +0530)]
qa/smoke: run smoke suite with all supported distros

Signed-off-by: Venky Shankar <vshankar@redhat.com>
19 months agomgr/dashboard: update fedora link for dashboard-cephadm-e2e test 54718/head
Adam King [Fri, 3 Nov 2023 17:42:51 +0000 (13:42 -0400)]
mgr/dashboard: update fedora link for dashboard-cephadm-e2e test

The old link points to a directory that now only contains a
README saying

---

ATTENTION
======================================
The contents of this directory have been moved to our archives available at:

http://archives.fedoraproject.org/pub/archive/fedora/

If you are having troubles finding something there please stop by #fedora-admin on irc.freenode.net

---

so I think we either need to start using a newer fedora or point
to the archive link. This commit is currently doing the latter.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit f317cef9e3f6255898a67528ab0e421899d5d3f5)

19 months agoMerge pull request #54700 from zdover23/wip-doc-2023-11-29-backport-54684-to-reef
Anthony D'Atri [Wed, 29 Nov 2023 04:53:56 +0000 (23:53 -0500)]
Merge pull request #54700 from zdover23/wip-doc-2023-11-29-backport-54684-to-reef

reef: doc/rados: ops/pgs: s/power of 2/power of two

19 months agoMerge pull request #54702 from zdover23/wip-doc-2023-11-29-backport-54685-to-reef
Anthony D'Atri [Wed, 29 Nov 2023 04:52:22 +0000 (23:52 -0500)]
Merge pull request #54702 from zdover23/wip-doc-2023-11-29-backport-54685-to-reef

reef: doc/rados: improve "Ceph Subsystems"

19 months agodoc/rados: improve "Ceph Subsystems" 54702/head
Zac Dover [Tue, 28 Nov 2023 05:08:48 +0000 (06:08 +0100)]
doc/rados: improve "Ceph Subsystems"

Improve the English in the subsection "Ceph Subsystems" in the section
"Subsystem, Log and Debug Settings" [sic] in
doc/rados/troubleshooting/log-and-debug.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 7bca5f57cc2c11bdd76dd0edb43c716a1d5ad355)

19 months agodoc/rados: ops/pgs: s/power of 2/power of two 54700/head
Zac Dover [Tue, 28 Nov 2023 04:29:50 +0000 (05:29 +0100)]
doc/rados: ops/pgs: s/power of 2/power of two

Change "power of 2" to "power of two" in
doc/rados/operations/placement-groups.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ca819633219b7978ece2201b1ab0d7dc9c0faee8)

19 months agoMerge pull request #54694 from k0ste/wip-63661-reef
Anthony D'Atri [Tue, 28 Nov 2023 21:07:29 +0000 (16:07 -0500)]
Merge pull request #54694 from k0ste/wip-63661-reef

reef: doc/rados/configuration/bluestore-config-ref: Fix lowcase typo

19 months agodoc/rados/configuration/bluestore-config-ref: Fix lowcase typo 54694/head
Adam Kupczyk [Fri, 3 Nov 2023 19:32:28 +0000 (20:32 +0100)]
doc/rados/configuration/bluestore-config-ref: Fix lowcase typo

Letter "O" got lowcased to "o".
Reverted that.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit f14ef59984e556fc0fefee7c5eac2964f9b64c8b)

19 months agoMerge pull request #54665 from zdover23/wip-doc-2023-11-27-backport-54664-to-reef
Anthony D'Atri [Mon, 27 Nov 2023 06:56:08 +0000 (01:56 -0500)]
Merge pull request #54665 from zdover23/wip-doc-2023-11-27-backport-54664-to-reef

reef: doc/rados: edit "Everything Failed! Now What?"

19 months agodoc/rados: edit "Everything Failed! Now What?" 54665/head
Zac Dover [Mon, 27 Nov 2023 00:17:17 +0000 (10:17 +1000)]
doc/rados: edit "Everything Failed! Now What?"

Edit the section "Everything Failed! Now what?" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthoy D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d8cd49259d797304adfbdb8eb46110e8b749256e)

19 months agoMerge pull request #54659 from zdover23/wip-doc-2023-11-26-backport-54656-to-reef
Anthony D'Atri [Sun, 26 Nov 2023 04:16:02 +0000 (23:16 -0500)]
Merge pull request #54659 from zdover23/wip-doc-2023-11-26-backport-54656-to-reef

reef: doc/rados: edit "monitor store failures"

19 months agodoc/rados: edit "monitor store failures" 54659/head
Zac Dover [Fri, 24 Nov 2023 21:33:24 +0000 (07:33 +1000)]
doc/rados: edit "monitor store failures"

Edit the section "Monitor Store Failures" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 0a1ce0016871dc2ce29d4e7eff564a199d54c6e3)

19 months agoMerge pull request #54654 from zdover23/wip-doc-2023-11-25-backport-54625-to-reef
Anthony D'Atri [Sat, 25 Nov 2023 00:40:40 +0000 (19:40 -0500)]
Merge pull request #54654 from zdover23/wip-doc-2023-11-25-backport-54625-to-reef

reef: doc/rados: edit "client can't connect..."

19 months agodoc/rados: edit "client can't connect..." 54654/head
Zac Dover [Thu, 23 Nov 2023 04:59:24 +0000 (14:59 +1000)]
doc/rados: edit "client can't connect..."

Edit the section "Client can't connect or mount" in the file
doc/rados/troubleshooting/troubleshooting-mon.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ec298091b5e754293e798c90fc8afc3e4504d632)

19 months agoMerge pull request #54642 from zdover23/wip-doc-2023-11-24-backport-54641-to-reef
Anthony D'Atri [Thu, 23 Nov 2023 22:54:23 +0000 (17:54 -0500)]
Merge pull request #54642 from zdover23/wip-doc-2023-11-24-backport-54641-to-reef

reef: doc/radosgw: Fix JSON typo in Principal Tag example code snippet

19 months agoMerge pull request #54638 from zdover23/wip-doc-2023-11-24-backport-54632-to-reef
Anthony D'Atri [Thu, 23 Nov 2023 22:45:36 +0000 (17:45 -0500)]
Merge pull request #54638 from zdover23/wip-doc-2023-11-24-backport-54632-to-reef

reef: doc/rados: format sections in tshooting-mon.rst

19 months agodoc/radosgw: Fix JSON typo in Principal Tag example code snippet 54642/head
Daniel Parkes [Thu, 23 Nov 2023 21:15:52 +0000 (22:15 +0100)]
doc/radosgw: Fix JSON typo in Principal Tag example code snippet

Signed-off-by: Daniel Parkes <dparkes@redhat.com>
(cherry picked from commit 68729c951dd3acdbdf86c3ce895a55bbab1aeb89)

19 months agodoc/rados: format sections in tshooting-mon.rst 54638/head
Zac Dover [Thu, 23 Nov 2023 11:54:54 +0000 (21:54 +1000)]
doc/rados: format sections in tshooting-mon.rst

Format definition lists in the section "Do I need to restart a monitor
to adjust debug levels?" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 910e5efea19eacd204025fa58f37c27c4c0b2963)

19 months agoMerge pull request #54237 from lxbsz/wip-63339
Yuri Weinstein [Wed, 22 Nov 2023 20:06:35 +0000 (12:06 -0800)]
Merge pull request #54237 from lxbsz/wip-63339

reef: qa: fix incorrectly using the wait_for_health() helper

Reviewed-by: Venky Shankar <vshankar@redhat.com>
19 months agoMerge pull request #54614 from petrutlucian94/wip-63611-reef
Venky Shankar [Wed, 22 Nov 2023 14:28:33 +0000 (19:58 +0530)]
Merge pull request #54614 from petrutlucian94/wip-63611-reef

reef: test/libcephfs: skip flaky timestamp assertion on Windows

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
19 months agoMerge pull request #54606 from lxbsz/wip-63586-r
Ilya Dryomov [Wed, 22 Nov 2023 11:24:50 +0000 (12:24 +0100)]
Merge pull request #54606 from lxbsz/wip-63586-r

reef: osd: log the number of extents for sparse read

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
19 months agotest/libcephfs: skip flaky timestamp assertion on Windows 54614/head
Lucian Petrut [Wed, 15 Mar 2023 09:04:40 +0000 (09:04 +0000)]
test/libcephfs: skip flaky timestamp assertion on Windows

There's a new libcephfs test that creates a snapshot and
compares ctime/mtime. The issue is that one of the assertion
fails on Windows, potentially due to reduced timestamp
precision.

For now, we'll skip those assertions on Windows.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
(cherry picked from commit 5b2166fbd314f9a9838bc173235b00446ce9f6f8)

19 months agoosd: add more debug logs for sparse read 54606/head
Xiubo Li [Mon, 20 Nov 2023 14:04:12 +0000 (22:04 +0800)]
osd: add more debug logs for sparse read

This will be very important to get to know what exactly has happened
when client get a very large number of extents.

URL: https://tracker.ceph.com/issues/63586
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 1cf5ecb93fb73a5ed4a82935f635f98efccf7de6)

19 months agoMerge pull request #54601 from zdover23/wip-doc-2023-11-22-backport-54598-to-reef
Anthony D'Atri [Tue, 21 Nov 2023 20:10:19 +0000 (15:10 -0500)]
Merge pull request #54601 from zdover23/wip-doc-2023-11-22-backport-54598-to-reef

reef: doc/rados: edit "recovering broken monmap"

19 months agodoc/rados: edit "recovering broken monmap" 54601/head
Zac Dover [Tue, 21 Nov 2023 17:54:19 +0000 (03:54 +1000)]
doc/rados: edit "recovering broken monmap"

Edit the section "Recovering a monitor's broken monmap" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6ccb9f3ca10e814c42effb49c8441c23da911adc)

19 months agoMerge pull request #54541 from aaSharma14/wip-63568-reef
Aashish Sharma [Tue, 21 Nov 2023 10:54:36 +0000 (16:24 +0530)]
Merge pull request #54541 from aaSharma14/wip-63568-reef

reef: mgr/dashboard: Consider null values as zero in grafana panels

Reviewed-by: Nizamudeen A <nia@redhat.com>
19 months agoMerge pull request #54579 from zdover23/wip-doc-2023-11-21-backport-54574-to-reef
Anthony D'Atri [Mon, 20 Nov 2023 20:15:15 +0000 (15:15 -0500)]
Merge pull request #54579 from zdover23/wip-doc-2023-11-21-backport-54574-to-reef

reef: doc/rados: edit "understanding mon_status"

19 months agodoc/rados: edit "understanding mon_status" 54579/head
Zac Dover [Mon, 20 Nov 2023 16:39:39 +0000 (02:39 +1000)]
doc/rados: edit "understanding mon_status"

Edit the section "Understanding mon_status" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 08c16aa113dc22dfec3387f575752a5049b7af42)

19 months agoMerge pull request #54576 from zdover23/wip-doc-2023-11-21-backport-54565-to-reef
Anthony D'Atri [Mon, 20 Nov 2023 18:47:39 +0000 (13:47 -0500)]
Merge pull request #54576 from zdover23/wip-doc-2023-11-21-backport-54565-to-reef

reef: doc/rados: edit "Using the Monitor's Admin Socket"

19 months agodoc/rados: edit "Using the Monitor's Admin Socket" 54576/head
Zac Dover [Sun, 19 Nov 2023 20:32:09 +0000 (06:32 +1000)]
doc/rados: edit "Using the Monitor's Admin Socket"

Edit the section "Using the Monitor's Admin Socket" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit f627445806dadcc956fe1256cfc3886cb5b8e1ef)

19 months agoMerge pull request #54572 from zdover23/wip-doc-2023-11-21-backport-54561-to-reef
Anthony D'Atri [Mon, 20 Nov 2023 16:49:06 +0000 (11:49 -0500)]
Merge pull request #54572 from zdover23/wip-doc-2023-11-21-backport-54561-to-reef

reef: doc/start: update release names

19 months agodoc/start: update release names 54572/head
Zac Dover [Sun, 19 Nov 2023 14:47:40 +0000 (00:47 +1000)]
doc/start: update release names

Update "Quincy" to "Reef" and "Pacific" to "Quincy" in the section
"Viewing Old Ceph Documentation" in /doc/start/documenting-ceph.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 83ff8f2b67f1a784ebb3ca7d0b7ca2c385f99343)

19 months agoMerge pull request #54559 from zdover23/wip-doc-2023-11-19-backport-54545-to-reef
Anthony D'Atri [Sun, 19 Nov 2023 14:32:39 +0000 (09:32 -0500)]
Merge pull request #54559 from zdover23/wip-doc-2023-11-19-backport-54545-to-reef

reef: doc/start: explain "OSD"

19 months agodoc/start: explain "OSD" 54559/head
Zac Dover [Fri, 17 Nov 2023 09:24:14 +0000 (19:24 +1000)]
doc/start: explain "OSD"

Explain the initialism "OSD" and link to its definition in the glossary.
This PR is raised in response to an anonymous documentation bug that reads

  "Paragraph 2 uses the acronym OSD without any explanation.
   This makes it very difficult to understand this part of
   the documentation as there is no indication of what this
   acronym is until much further into the documentation. Replace
   first occurence of OSD with Object Storage Daemon (OSD) or
   link it to the glossary."
     -- https://pad.ceph.com/p/Report_Documentation_Bugs

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit a78fe85470c2471574aceb723cd304498cde1afb)

20 months agoMerge pull request #54551 from zdover23/wip-doc-2023-11-19-backport-54523-to-reef
Anthony D'Atri [Sat, 18 Nov 2023 21:35:35 +0000 (16:35 -0500)]
Merge pull request #54551 from zdover23/wip-doc-2023-11-19-backport-54523-to-reef

reef: doc/man: edit ceph-osd description

20 months agodoc/man: edit ceph-osd description 54551/head
Zac Dover [Thu, 16 Nov 2023 11:14:13 +0000 (21:14 +1000)]
doc/man: edit ceph-osd description

Improve the English grammar and reduce the ambiguity and unclear writing
in the "Description" section of doc/man/8/ceph-osd.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2921dacf1e7b7ad2aa62f52d6e8914d8ec50a610)

20 months agomgr/dashboard: Consider null values as zero in grafana panels 54541/head
Aashish Sharma [Wed, 4 Oct 2023 06:54:13 +0000 (12:24 +0530)]
mgr/dashboard: Consider null values as zero in grafana panels

After upgrading from RHCS4 to RHCS5..some of the grafana charts broke.
This is because in RHCS5 we do not generate the metrics if its value is
zero as a result the null value from that metric breaks the grafana
charts or graphs. This PR is to fix the above mentioned issue.

Fixes: https://tracker.ceph.com/issues/63088
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 6f3f58cb8e4ce100cc7186858465b4d11d5c2c49)

20 months agoMerge pull request #54521 from guits/wip-63554-reef
Guillaume Abrioux [Thu, 16 Nov 2023 14:33:55 +0000 (15:33 +0100)]
Merge pull request #54521 from guits/wip-63554-reef

reef: ceph-volume: fix a regression in `raw list`

20 months agoceph-volume: fix a regression in `raw list` 54521/head
Guillaume Abrioux [Wed, 15 Nov 2023 15:03:10 +0000 (16:03 +0100)]
ceph-volume: fix a regression in `raw list`

'ceph-volume raw list' is broken for a specific use case (rook).

rook copies devices from /dev/ to /mnt for specific/internal needs.

when ceph-volume raw list is passed a device from /mnt then
ceph-volume ignores it and return an empty dict.
That prevent rook from creating OSDs properly.

https://tracker.ceph.com/issues/63545

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit e67dce7120954fff9b7b936348bed0b2ac6c1155)

20 months agoMerge pull request #54509 from zdover23/wip-doc-2023-11-15-backport-54497-to-reef
Anthony D'Atri [Wed, 15 Nov 2023 13:40:10 +0000 (08:40 -0500)]
Merge pull request #54509 from zdover23/wip-doc-2023-11-15-backport-54497-to-reef

reef: doc/glossary: add "Quorum" to glossary

20 months agodoc/glossary: add "Quorum" to glossary 54509/head
Zac Dover [Tue, 14 Nov 2023 13:40:42 +0000 (23:40 +1000)]
doc/glossary: add "Quorum" to glossary

Add the term "Quorum" to the glossary and link to the part of
architecture.rst concerning Monitors. The sticky header at the top of
the docs.ceph.com website gets in the way of the location linked to in
this commit, but fatigue and disgust prevent me from spending time today
trial-and-erroring my way through the hostile and ill-documented
wilderness of scroll-margin so that the link goes where it should.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c2f6a770bf0e12296c334d99ac86ff4732ec29b7)

20 months agoMerge pull request #54502 from zdover23/wip-doc-2023-11-15-backport-54496-to-reef
Anthony D'Atri [Tue, 14 Nov 2023 19:07:38 +0000 (14:07 -0500)]
Merge pull request #54502 from zdover23/wip-doc-2023-11-15-backport-54496-to-reef

reef: doc/rados: edit "troubleshooting-mon"

20 months agodoc/rados: edit "troubleshooting-mon" 54502/head
Zac Dover [Tue, 14 Nov 2023 13:03:28 +0000 (23:03 +1000)]
doc/rados: edit "troubleshooting-mon"

Edit the text in the "Initial Troubleshooting" section of
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit fa8129a7466b3b48b56124eaf1d9ca8e8fd51fbc)

20 months agoMerge pull request #54480 from zdover23/wip-doc-2023-11-14-backport-54479-to-reef
Anthony D'Atri [Mon, 13 Nov 2023 16:57:51 +0000 (11:57 -0500)]
Merge pull request #54480 from zdover23/wip-doc-2023-11-14-backport-54479-to-reef

reef: doc/start: fix typo in hardware-recommendations.rst

20 months agodoc/start: fix typo in hardware-recommendations.rst 54480/head
Anthony D'Atri [Mon, 13 Nov 2023 13:58:44 +0000 (08:58 -0500)]
doc/start: fix typo in hardware-recommendations.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 48fd7ff1e13ccfeca04b9283b13641ce59316723)

20 months agoMerge pull request #54477 from zdover23/wip-doc-2023-11-13-backport-54473-to-reef
Anthony D'Atri [Mon, 13 Nov 2023 16:38:44 +0000 (11:38 -0500)]
Merge pull request #54477 from zdover23/wip-doc-2023-11-13-backport-54473-to-reef

reef: doc/rados: format "initial troubleshooting"

20 months agodoc/rados: format "initial troubleshooting" 54477/head
Zac Dover [Mon, 13 Nov 2023 10:57:07 +0000 (20:57 +1000)]
doc/rados: format "initial troubleshooting"

Format the steps in the "Initial Troubleshooting" section of
doc/rados/troubleshooting/troubleshooting-mon.rst. A near-future PR (not
this one) will add context to this section and explain that the steps
described here are the first steps that you should undertake when you
determine that you have an unresponsive or down Monitor. This PR is
merely for formatting.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c581018caf626fa0dd50bd244766bfa9755c9a16)

20 months agoMerge pull request #54224 from rkachach/fix_issue_63266
Adam King [Mon, 13 Nov 2023 13:40:32 +0000 (08:40 -0500)]
Merge pull request #54224 from rkachach/fix_issue_63266

reef: backport of rook orchestrator fixes and e2e automated testing

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
20 months agomon: fix mds metadata lost in one case. 54316/head
shimin [Sun, 8 Oct 2023 11:15:09 +0000 (19:15 +0800)]
mon: fix mds metadata lost in one case.

In most cases, peon's pending_metadata is inconsistent with mon's db.
When a peon turns into leader, and at the same time a active mds stops,
the new leader may flush wrong mds metadata into db. So we meed to
update mds metadata from db at every fsmap change.

This phenomenon can be reproduce like this:
A Cluster with 3 mon and 3 mds (one active, other two standby), 6 osd.
step 1. stop two standby mds;
step 2. restart all mon; (make pending_medata consistent with db)
step 3. start other two mds
step 4. stop leader mon
step 5. run "ceph mds metadata" command to check mds metadata
step 6. stop active mds
step 7. run "ceph mds metadata" command to check mds metadata again

In step 7, we would find mds metadata lost.

Fixes: https://tracker.ceph.com/issues/63166
Signed-off-by: shimin <shimin@kuaishou.com>
(cherry picked from commit 56cbf3f0716b556c815487d719abe86021125925)

20 months agoMerge pull request #54463 from zdover23/wip-doc-2023-11-13-backport-54457-to-reef
Anthony D'Atri [Sun, 12 Nov 2023 16:58:24 +0000 (11:58 -0500)]
Merge pull request #54463 from zdover23/wip-doc-2023-11-13-backport-54457-to-reef

reef: doc/config: edit "ceph-conf.rst"

20 months agoMerge pull request #54461 from zdover23/wip-doc-2023-11-12-backport-54458-to-reef
Anthony D'Atri [Sun, 12 Nov 2023 16:56:56 +0000 (11:56 -0500)]
Merge pull request #54461 from zdover23/wip-doc-2023-11-12-backport-54458-to-reef

reef: doc/rados: parallelize t-mon headings

20 months agodoc/config: edit "ceph-conf.rst" 54463/head
Zac Dover [Sun, 12 Nov 2023 10:21:41 +0000 (20:21 +1000)]
doc/config: edit "ceph-conf.rst"

Edit the first section of doc/rados/configuration/ceph-conf.rst.
Initially I just wanted to change "series" to "set", but once I got my
hands dirty I ended up simplifying some sentences.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c886e05404ce9c50454d40e692ababdc55f346c6)

20 months agodoc/rados: parallelize t-mon headings 54461/head
Zac Dover [Sun, 12 Nov 2023 10:52:09 +0000 (20:52 +1000)]
doc/rados: parallelize t-mon headings

Give parallel structure to the questions in the Q&A section of the "The
Cluster Has Quorum But At Least One Monitor Is Down" subsection of the
"Most Common Monitor Issues" section of
doc/rados/troubleshooting/troubleshooting-mon.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 010e5a13b9e4e6a860c676f1b3090a495592d715)

20 months agoMerge pull request #54455 from zdover23/wip-doc-2023-11-11-backport-54452-to-reef
Anthony D'Atri [Sat, 11 Nov 2023 13:35:24 +0000 (08:35 -0500)]
Merge pull request #54455 from zdover23/wip-doc-2023-11-11-backport-54452-to-reef

reef: doc/rados: edit t-mon "common issues" (5 of x)

20 months agodoc/rados: edit t-mon "common issues" (5 of x) 54455/head
Zac Dover [Sat, 11 Nov 2023 03:45:42 +0000 (13:45 +1000)]
doc/rados: edit t-mon "common issues" (5 of x)

Edit the fifth part of the section "Most Common Monitor Issues" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Follows https://github.com/ceph/ceph/pull/54440.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d98222db9b4436841102d23c979f05a9d958bb1f)

20 months agoMerge pull request #54443 from zdover23/wip-doc-2023-11-10-backport-54440-to-reef
Anthony D'Atri [Thu, 9 Nov 2023 23:47:11 +0000 (18:47 -0500)]
Merge pull request #54443 from zdover23/wip-doc-2023-11-10-backport-54440-to-reef

reef: doc/rados: edit t-mon "common issues" (4 of x)

20 months agodoc/rados: edit t-mon "common issues" (4 of x) 54443/head
Zac Dover [Thu, 9 Nov 2023 19:50:21 +0000 (05:50 +1000)]
doc/rados: edit t-mon "common issues" (4 of x)

Edit the fourth part of the section "Most Common Monitor Issues" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Follows https://github.com/ceph/ceph/pull/54432.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit f6b686ac3118507baab719f1587c8c360499e929)

20 months agoMerge pull request #54438 from zdover23/wip-doc-2023-11-10-backport-54432-to-reef
Anthony D'Atri [Thu, 9 Nov 2023 21:02:03 +0000 (16:02 -0500)]
Merge pull request #54438 from zdover23/wip-doc-2023-11-10-backport-54432-to-reef

reef: doc/rados: edit t-mon "common issues" (3 of x)

20 months agodoc/rados: edit t-mon "common issues" (3 of x) 54438/head
Zac Dover [Thu, 9 Nov 2023 10:20:20 +0000 (20:20 +1000)]
doc/rados: edit t-mon "common issues" (3 of x)

Edit the second part of the section "Most Common Monitor Issues" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Follows https://github.com/ceph/ceph/pull/54417.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 91ed10bc734bd93605b60c87037393d2704a16bc)

20 months agoMerge pull request #54436 from ceph/wip-yuriw-quincy-x-reef
Yuri Weinstein [Thu, 9 Nov 2023 18:46:09 +0000 (10:46 -0800)]
Merge pull request #54436 from ceph/wip-yuriw-quincy-x-reef

qa/tests: added - \(POOL_APP_NOT_ENABLED\) to the ignore list

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Prashant D <pdhange@redhat.com>
20 months agoqa/tests: added - \(POOL_APP_NOT_ENABLED\) to the ignore list 54436/head
Yuri Weinstein [Thu, 9 Nov 2023 16:05:38 +0000 (08:05 -0800)]
qa/tests: added - \(POOL_APP_NOT_ENABLED\) to the ignore list

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
20 months agoMerge pull request #54429 from guits/wip-63491-reef
Guillaume Abrioux [Thu, 9 Nov 2023 13:59:47 +0000 (14:59 +0100)]
Merge pull request #54429 from guits/wip-63491-reef

reef: ceph-volume: Revert "ceph-volume: fix raw list for lvm devices"

20 months agoceph-volume: fix raw list for non-existent device 54429/head
Matthew Booth [Tue, 7 Nov 2023 19:58:16 +0000 (19:58 +0000)]
ceph-volume: fix raw list for non-existent device

ceph-volume should not crash when given a device which doesn't exist.

Fixes: https://tracker.ceph.com/issues/63391
Signed-off-by: Matthew Booth <mbooth@redhat.com>
(cherry picked from commit e009b1a319c834a504947423ae1dd55387809235)
(cherry picked from commit 0e17f8b5aebb51ee69ce0689dabe2a9111055716)

20 months agoceph-volume: Revert "ceph-volume: fix raw list for lvm devices"
Guillaume Abrioux [Tue, 7 Nov 2023 13:39:50 +0000 (14:39 +0100)]
ceph-volume: Revert "ceph-volume: fix raw list for lvm devices"

This reverts commit e5e429617c1c27dcd631171f65d30571e32f7266.
This commit introduced a regression, see linked tracker for details.

Fixes: https://tracker.ceph.com/issues/63391
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 916a22ef031953056771eceb1f49cab7eb746978)

20 months agoMerge pull request #54427 from zdover23/wip-doc-2023-11-09-backport-54412-to-reef
Anthony D'Atri [Thu, 9 Nov 2023 04:45:09 +0000 (23:45 -0500)]
Merge pull request #54427 from zdover23/wip-doc-2023-11-09-backport-54412-to-reef

reef: doc/rados: edit t-shooting-mon.rst

20 months agodoc/rados: edit t-shooting-mon.rst 54427/head
Zac Dover [Wed, 8 Nov 2023 07:56:29 +0000 (17:56 +1000)]
doc/rados: edit t-shooting-mon.rst

Improve the front matter of the section "Troubleshooting Monitors" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e6e3fda2efb8f4a4345ba5f939baade844c5d582)

20 months agoMerge pull request #54421 from zdover23/wip-doc-2023-11-09-backport-54417-to-reef
Anthony D'Atri [Wed, 8 Nov 2023 16:15:45 +0000 (11:15 -0500)]
Merge pull request #54421 from zdover23/wip-doc-2023-11-09-backport-54417-to-reef

reef: doc/rados: edit t-mon "common issues" (2 of x)

20 months agodoc/rados: edit t-mon "common issues" (2 of x) 54421/head
Zac Dover [Wed, 8 Nov 2023 13:24:06 +0000 (23:24 +1000)]
doc/rados: edit t-mon "common issues" (2 of x)

Edit the second part of the section "Most Common Monitor Issues" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 7dcfa9132ce6ca97d2c414014fc5de0a0c7e106e)

20 months agoMerge pull request #54418 from zdover23/wip-doc-2023-11-08-backport-54413-to-reef
zdover23 [Wed, 8 Nov 2023 15:07:49 +0000 (01:07 +1000)]
Merge pull request #54418 from zdover23/wip-doc-2023-11-08-backport-54413-to-reef

reef: doc/rados: edit t-mon "common issues" (1 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
20 months agodoc/rados: edit t-mon "common issues" (1 of x) 54418/head
Zac Dover [Wed, 8 Nov 2023 09:07:40 +0000 (19:07 +1000)]
doc/rados: edit t-mon "common issues" (1 of x)

Edit the first part of the section "Most Common Monitor Issues" in
doc/rados/troubleshooting/troublehsooting-mon.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 434d8967a37d49bdce3effae4e9b4c69a8586a56)

20 months agobackport: https://github.com/ceph/ceph/pull/54364 54224/head
Redouane Kachach [Wed, 8 Nov 2023 13:02:31 +0000 (14:02 +0100)]
backport: https://github.com/ceph/ceph/pull/54364

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
20 months agoMClientRequest: handle owner_uid and owner_gid from ceph_mds_request_head_legacy 54407/head
Alexander Mikhalitsyn [Mon, 23 Oct 2023 12:37:44 +0000 (14:37 +0200)]
MClientRequest: handle owner_uid and owner_gid from ceph_mds_request_head_legacy

When a client is too old and uses struct ceph_mds_request_head_legacy we must
fill new owner_uid and owner_gid fields from an old client_uid and client_gid.

Fixes: https://github.com/ceph/ceph/pull/52575
Fixes: https://tracker.ceph.com/issues/63288
Fixes: commit 46cb244b9c839 ("ceph_fs.h: add separate owner_{u,g}id fields")
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
(cherry picked from commit a70a70f589214d6e2a5b477a61005b13ba2fec46)

20 months agoMClientRequest: handle ext_num_retry and ext_num_fwd from ceph_mds_request_head_legacy
Alexander Mikhalitsyn [Mon, 23 Oct 2023 12:34:26 +0000 (14:34 +0200)]
MClientRequest: handle ext_num_retry and ext_num_fwd from ceph_mds_request_head_legacy

When a client is too old and uses struct ceph_mds_request_head_legacy we must
fill new ext_num_retry and ext_num_fwd fields from an old num_retry and num_fwd.

Fixes: https://github.com/ceph/ceph/pull/45669
Fixes: https://tracker.ceph.com/issues/63288
Fixes: commit cbd7e3040208 ("ceph_fs.h: add 32 bits extended num_retry and num_fwd support")
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
(cherry picked from commit 43f32a46aa9095b19525357ba7ca215e842b4f77)

20 months agoMerge pull request #54395 from aaSharma14/wip-63470-reef
Aashish Sharma [Wed, 8 Nov 2023 04:41:19 +0000 (10:11 +0530)]
Merge pull request #54395 from aaSharma14/wip-63470-reef

reef: mgr/dashboard: fix rgw multi-site import form helper

Reviewed-by: Nizamudeen A <nia@redhat.com>