]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
15 months agorgw/redis: Implement RedisDriver::get_async and RedisDriver::put_async
Samarah [Wed, 8 Nov 2023 15:16:07 +0000 (15:16 +0000)]
rgw/redis: Implement RedisDriver::get_async and RedisDriver::put_async

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agoqa/d4n: Add test for large object
Samarah [Wed, 21 Feb 2024 15:55:26 +0000 (15:55 +0000)]
qa/d4n: Add test for large object

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n/policy: Add test for redis_sync method
Samarah [Wed, 21 Feb 2024 18:07:17 +0000 (18:07 +0000)]
d4n/policy: Add test for redis_sync method

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agoqa/d4n: Update D4N workunit to test small object read workflow
Samarah [Wed, 20 Dec 2023 21:41:02 +0000 (21:41 +0000)]
qa/d4n: Update D4N workunit to test small object read workflow

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agod4n/directory: Fix oid for directory blocks
Samarah [Tue, 20 Feb 2024 15:39:28 +0000 (15:39 +0000)]
d4n/directory: Fix oid for directory blocks

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n/policy: Update local weight sum + age handling and d4n policy
Samarah [Fri, 12 Jan 2024 19:01:05 +0000 (19:01 +0000)]
d4n/policy: Update local weight sum + age handling and d4n policy
test

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/d4n: removing lock from code path that writes to the cache
Pritha Srivastava [Mon, 19 Feb 2024 07:17:35 +0000 (12:47 +0530)]
rgw/d4n: removing lock from code path that writes to the cache
backend, and ensuring that write to the cache is atomic.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: implementation of `put` using yield context
Pritha Srivastava [Thu, 8 Feb 2024 08:49:35 +0000 (14:19 +0530)]
rgw/cache: implementation of `put` using yield context
as completion token and adding throttling to `put_async`
in the cache driver api. Also added a test case to the
ssd driver unit test for `put_async`.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw: updating the boost_redis submodule version to point to
Pritha Srivastava [Wed, 7 Feb 2024 08:37:09 +0000 (14:07 +0530)]
rgw: updating the boost_redis submodule version to point to
`develop` branch.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/d4n: fixing the 'get' call hanging issues and
Casey Bodley [Mon, 5 Feb 2024 07:05:49 +0000 (12:35 +0530)]
rgw/d4n: fixing the 'get' call hanging issues and
Operation Canceled errors, by wrapping async_exec
call in boost::asio::dispatch() call.

Signed-off-by: Casey Bodley <cbodley@redhat.com>
15 months agorgw/d4n: modifications to the filter driver:
Pritha Srivastava [Tue, 30 Jan 2024 10:04:42 +0000 (15:34 +0530)]
rgw/d4n: modifications to the filter driver:
1. replaced put_async() with put() in handle_data()
2. moved calls to update() from iterate() to flush()

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/d4n: Perform minor cleanup; add error checking for `localWeights` and fix order...
Samarah [Fri, 12 Jan 2024 19:01:05 +0000 (19:01 +0000)]
rgw/d4n: Perform minor cleanup; add error checking for `localWeights` and fix order of entry deletion in policy

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n: Add a central Redis connection to the filter to be shared by the rest of the...
Samarah [Wed, 10 Jan 2024 18:00:23 +0000 (18:00 +0000)]
d4n: Add a central Redis connection to the filter to be shared by the rest of the D4N classes and update D4N unit tests appropriately

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n/policy: Change `size_t` argument type and add error checking to
Samarah [Fri, 5 Jan 2024 19:51:36 +0000 (19:51 +0000)]
d4n/policy: Change `size_t` argument type and add error checking to
`set_local_weight_sum` method

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agotest/redis: Remove temporary boost.redis test program
Samarah [Fri, 5 Jan 2024 14:47:29 +0000 (14:47 +0000)]
test/redis: Remove temporary boost.redis test program

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw: this commit squashes commits performing cleanup in various files
Samarah [Wed, 3 Jan 2024 15:52:25 +0000 (15:52 +0000)]
rgw: this commit squashes commits performing cleanup in various files
like d4n filter, policy, cache backend, aio and process_env.

d4n/filter: Remove unnecessary erasure of attrs in read op's `prepare`
method
d4n: Remove `dout` definitions from header files
rgw: Remove unnecessary includes in `rgw_process_env.h`
rgw: Remove `cache_read_op` from `rgw_aio.h`
rgw: Return POSIX error codes and perform minor cleanup for D4N and
Redis files

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agobuild: Remove build/boost_redis
Adam Emerson [Fri, 30 Jun 2023 18:59:19 +0000 (14:59 -0400)]
build: Remove build/boost_redis

Signed-off-by: Adam Emerson <aemerson@redhat.com>
15 months agod4n/filter: Correct `CacheObj` `hostsList` value so it's empty since the
Samarah [Wed, 20 Dec 2023 20:47:41 +0000 (20:47 +0000)]
d4n/filter: Correct `CacheObj` `hostsList` value so it's empty since the
object isn't being locally cached

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n/filter: Update `creationTime` calculation
Samarah [Wed, 20 Dec 2023 20:11:12 +0000 (20:11 +0000)]
d4n/filter: Update `creationTime` calculation

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n/policy: Add additional lock guards for other `entries_heap` accesses
Samarah [Wed, 20 Dec 2023 17:35:16 +0000 (17:35 +0000)]
d4n/policy: Add additional lock guards for other `entries_heap` accesses

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n/policy: Fix `find_victim` logic so victim is found in `eviction`
Samarah [Tue, 19 Dec 2023 21:54:47 +0000 (21:54 +0000)]
d4n/policy: Fix `find_victim` logic so victim is found in `eviction`
method

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n/filter: Fix cache `exist_key` check to ensure the return value is positive
samarah [Wed, 13 Dec 2023 19:31:50 +0000 (14:31 -0500)]
d4n/filter: Fix cache `exist_key` check to ensure the return value is positive

Signed-off-by: samarah <suriarte@redhat.com>
15 months agorgw/cache: Make `bl` and `attrs` params `const` for cache write ops
samarah [Mon, 11 Dec 2023 19:48:32 +0000 (14:48 -0500)]
rgw/cache: Make `bl` and `attrs` params `const` for cache write ops

Signed-off-by: samarah <suriarte@redhat.com>
15 months agod4n/policy: Make `shutdown` method specific to LFUDA
samarah [Thu, 7 Dec 2023 21:54:43 +0000 (16:54 -0500)]
d4n/policy: Make `shutdown` method specific to LFUDA

Signed-off-by: samarah <suriarte@redhat.com>
15 months agorgw: Take in `io_context` by reference
samarah [Thu, 7 Dec 2023 18:51:33 +0000 (13:51 -0500)]
rgw: Take in `io_context` by reference

Signed-off-by: samarah <suriarte@redhat.com>
15 months agorgw/cache: Make protected members private
samarah [Thu, 7 Dec 2023 18:02:56 +0000 (13:02 -0500)]
rgw/cache: Make protected members private

Signed-off-by: samarah <suriarte@redhat.com>
15 months agod4n/policy: Initialize `age` to 1
samarah [Thu, 7 Dec 2023 16:13:27 +0000 (11:13 -0500)]
d4n/policy: Initialize `age` to 1

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n/policy: Fix minor logical errors
Samarah [Tue, 21 Nov 2023 21:31:31 +0000 (21:31 +0000)]
d4n/policy: Fix minor logical errors

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/cache: this commit squashes commits for removing CephContext* from
Pritha Srivastava [Tue, 12 Dec 2023 11:53:37 +0000 (17:23 +0530)]
rgw/cache: this commit squashes commits for removing CephContext* from
ssd, redis driver and related test files.

rgw/cache: removing CephContext* from ssd driver and redis driver.
It can be accessed in every api using dpp->get_cct(), where dpp
is of type DoutPrefixProvider*.
rgw/test: Remove `cct` parameter from cache driver initialization call
redis driver test file.
rgw/qa: removing cct parameter from ssd driver test file.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/cache: changing `get_attr` api such that it returns
Pritha Srivastava [Tue, 12 Dec 2023 07:14:24 +0000 (12:44 +0530)]
rgw/cache: changing `get_attr` api such that it returns
int signifying success or error, and `attr_val` is added
as an out param.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: removing `experimental` fallback from ssd backed cache driver.
Pritha Srivastava [Tue, 12 Dec 2023 05:04:45 +0000 (10:34 +0530)]
rgw/cache: removing `experimental` fallback from ssd backed cache driver.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: removing interface related to Partition.
Pritha Srivastava [Tue, 12 Dec 2023 04:01:28 +0000 (09:31 +0530)]
rgw/cache: removing interface related to Partition.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/d4n: using 'id_tag' as 'version' of an object for non-versioned
Pritha Srivastava [Wed, 22 Nov 2023 07:50:34 +0000 (13:20 +0530)]
rgw/d4n: using 'id_tag' as 'version' of an object for non-versioned
objects. Using 'instance' of 'oid' as 'version' for
versioned objects.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/d4n: restructuring LRUPolicy::erase(), update() and eviction() method.
Pritha Srivastava [Tue, 14 Nov 2023 08:30:07 +0000 (14:00 +0530)]
rgw/d4n: restructuring LRUPolicy::erase(), update() and eviction() method.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: adding unittests for ssd backed cache backend, and
Pritha Srivastava [Wed, 8 Nov 2023 11:01:04 +0000 (16:31 +0530)]
rgw/cache: adding unittests for ssd backed cache backend, and
fixing bugs that the tests revealed.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: fixing the free space available in ssd backed cache
Pritha Srivastava [Fri, 3 Nov 2023 11:12:59 +0000 (16:42 +0530)]
rgw/cache: fixing the free space available in ssd backed cache
backend by taking into account the size of xattrs in addition to
the file size.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agod4n: Update block `mtime` in filter and change `creationTime` to string
Samarah [Thu, 9 Nov 2023 21:27:04 +0000 (21:27 +0000)]
d4n: Update block `mtime` in filter and change `creationTime` to string
in directory due to seg faults

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n/directory: Add `ObjectDirectory::update_field` method
Samarah [Thu, 9 Nov 2023 14:28:07 +0000 (14:28 +0000)]
d4n/directory: Add `ObjectDirectory::update_field` method

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/d4n: this commit squashes the following commits related to LFUDA Policy.
Samarah [Tue, 31 Oct 2023 14:21:06 +0000 (14:21 +0000)]
rgw/d4n: this commit squashes the following commits related to LFUDA Policy.

rgw/d4n: Make minor updates, improve `LFUDAPolicy::erase` method, and
fix `localWeight` policy sets
rgw/d4n: Update `LFUDA::find_victim` method, add locks in policy code,
and remove setting of attrs in filter's `put_async` calls
d4n/policy: Update logic for minimum average weight calculation
d4n/policy: Remove iteration in `eviction`

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n/filter: Change from copying block to object in `copy_obj`
Samarah [Thu, 26 Oct 2023 17:49:02 +0000 (17:49 +0000)]
d4n/filter: Change from copying block to object in `copy_obj`

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/d4n: this commit squashes the following two commits.
Samarah [Thu, 19 Oct 2023 15:34:20 +0000 (15:34 +0000)]
rgw/d4n: this commit squashes the following two commits.

rgw/d4n: Remove `get_block` from policy and add logic to D4N filter
d4n/policy: Create a min heap of the local weights

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n: Store `optional_yield` in client cb and update index used in
Samarah [Fri, 6 Oct 2023 20:20:43 +0000 (20:20 +0000)]
d4n: Store `optional_yield` in client cb and update index used in
D4N/cache classes

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n/policy: Update policy to use block name
Samarah [Fri, 29 Sep 2023 13:35:57 +0000 (13:35 +0000)]
d4n/policy: Update policy to use block name

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n: Add connection client names for policy and directory
Samarah [Fri, 29 Sep 2023 13:26:50 +0000 (13:26 +0000)]
d4n: Add connection client names for policy and directory

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw: Add `rgw_local_cache_address` yaml config
Samarah [Tue, 26 Sep 2023 20:36:31 +0000 (20:36 +0000)]
rgw: Add `rgw_local_cache_address` yaml config

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/d4n: Remove `cacheBlock` and commented out read workflow from D4N filter
Samarah [Fri, 22 Sep 2023 18:20:16 +0000 (18:20 +0000)]
rgw/d4n: Remove `cacheBlock` and commented out read workflow from D4N filter

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n/directory: Update directory `exist_key` method to take in
Samarah [Thu, 7 Sep 2023 21:36:28 +0000 (21:36 +0000)]
d4n/directory: Update directory `exist_key` method to take in
block/object; fix endpoint generation; add `remove_host` method

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agod4n/policy: this commit squashes the following changes to policy and filter driver...
Samarah [Tue, 5 Sep 2023 16:53:32 +0000 (16:53 +0000)]
d4n/policy: this commit squashes the following changes to policy and filter driver files.

d4n/policy: Update policy with correct directory usage; create LFUDAEntry struct + entries map; add `optional_yield` to `insert` method
d4n/policy: Add `version` to Entry struct/policy methods and calls in
the D4N filter; add error checking and fix logic in LFUDA code

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/cache: this commit squashes following commits related to changes in
Samarah [Mon, 31 Jul 2023 17:32:49 +0000 (13:32 -0400)]
rgw/cache: this commit squashes following commits related to changes in
redis driver and ssd driver.

rgw/redis: Add `del`, `put_async`, and `calculate_free_space` methods to RedisDriver
rgw/redis: Work on RedisDriver `put_async` and `get_async` methods
rgw/cache: Add error-checking to `SSDDriver::set_attr`
rgw/redis: Remove `calculate_free_space` method from RedisDriver, fix
`free_space` calculations, clean up async code

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agotest/d4n: this commit squashes the following commits related to tests for d4n.
Samarah [Fri, 28 Jul 2023 13:44:03 +0000 (09:44 -0400)]
test/d4n: this commit squashes the following commits related to tests for d4n.

test/redis: Add temporary `boost::redis` unit test program for experimentation
test/rgw: Add/update unit test programs for D4N classes + RedisDriver; switch to `boost::redis` usage
test/d4n: Begin `cpp_redis` removal from D4N filter test program; needs
to be fixed
test/d4n: Temporarily remove D4N filter test program until D4N workflows
are fully implemented

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/d4n: this commit squashes the following commits related to
Samarah [Mon, 25 Sep 2023 14:49:43 +0000 (14:49 +0000)]
rgw/d4n: this commit squashes the following commits related to
clean up and removal of cpp_redis.

d4n/filter: Add `optional_yield` to CacheDriver calls in D4N Filter and
make minor updates to several filter methods
rgw/d4n: fix compilation issue.
rgw/cache: Add `del` method to CacheDriver and SSDDriver
cmake/d4n: Remove unnecessary D4N lines
rgw: Add `io_context` to D4N Filter and RedisDriver, remove `cpp_redis`
library from RedisDriver, and perform minor cleanup
d4n: Remove `cpp_redis` library from D4N directory and policy; update calls in filter; move Entry struct to base CachePolicy class
build/cpp_redis: Remove `cpp_redis` library
rgw/d4n: including <boost/asio/detached.hpp> wheerever needed.
rgw/d4n : fixes to d4n filter, policy, directory and redis driver files
for compilation errors.

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Co-authored-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw: Change D4N and RedisDriver `ifndef` directives to `#pragma once`; make integer...
Samarah [Tue, 5 Sep 2023 13:50:43 +0000 (13:50 +0000)]
rgw: Change D4N and RedisDriver `ifndef` directives to `#pragma once`; make integer errors negative; fix filter includes

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/cache: this commit adds entries to redis driver and squashes the
Samarah [Thu, 9 Nov 2023 16:39:15 +0000 (16:39 +0000)]
rgw/cache: this commit adds entries to redis driver and squashes the
following two commits.

rgw: Update D4N policy and RedisDriver with entries
rgw/d4n: fixing compilation error in d4n policy code.

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
Co-authored-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: fixing update_attrs and get_attrs in ssd backed cache backend.
Pritha Srivastava [Tue, 31 Oct 2023 06:41:30 +0000 (12:11 +0530)]
rgw/cache: fixing update_attrs and get_attrs in ssd backed cache backend.

update_attrs did not check whether an xattr already existed before
modifying it - added check for that. corrected converting bufferlist
to string.

get_attrs did not check whether attribute size is zero or negative -
added check for that.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/d4n: copying over read op params of the filter driver to
Pritha Srivastava [Fri, 13 Oct 2023 06:34:52 +0000 (12:04 +0530)]
rgw/d4n: copying over read op params of the filter driver to
the read op params of 'next' in prepare() method, to be used
while storing objects to the backend store.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: adding d4n config options for ssd backed
Pritha Srivastava [Wed, 27 Sep 2023 10:34:47 +0000 (16:04 +0530)]
rgw/cache: adding d4n config options for ssd backed
cache driver.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: saving dpp in set_client_cb() instead
Pritha Srivastava [Wed, 27 Sep 2023 06:09:41 +0000 (11:39 +0530)]
rgw/cache: saving dpp in set_client_cb() instead
of flush_write_part() so that the correct value
is available everywhere in handle_data().

Saving dpp value in flush_last_part() caused a crash in
rgw in handle_data().

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: This commit fixes two things in ssd backed cache backend:
Pritha Srivastava [Mon, 28 Aug 2023 11:43:38 +0000 (17:13 +0530)]
rgw/cache: This commit fixes two things in ssd backed cache backend:
1. fixing free space calcuation when data is deleted.

2. implementation of append_data().

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: moving LRU related data structures and interfaces to the Policy Manager.
Pritha Srivastava [Mon, 28 Aug 2023 11:42:18 +0000 (17:12 +0530)]
rgw/cache: moving LRU related data structures and interfaces to the Policy Manager.
Replacing the related calls in d4n filter driver with that of the cachepolicy in the
Policy Manager and adding cache block to the block directory
once the block is written to the cache backend and the
policy manager data structure.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: this commit adds `optional_yield` to ssd and redis driver
Samarah [Thu, 3 Aug 2023 20:59:55 +0000 (16:59 -0400)]
rgw/cache: this commit adds `optional_yield` to ssd and redis driver
and squashes the following commits.

RGW: Add `optional_yield` parameter to Cache Driver methods
RGW: Add `optional_yield` parameter to SSD Driver methods
rgw/cache: fix compilation errors related to optional_yield.

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
Co-authored-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: this commit removes indexing from ssd and redis
Pritha Srivastava [Thu, 24 Aug 2023 04:27:07 +0000 (09:57 +0530)]
rgw/cache: this commit removes indexing from ssd and redis
driver and squashes the following commits.

rgw/cache: modifications to the ssd cache driver after removing
indexing from the cache backend.
rgw/cache: modifications to redis cache driver, after
removing indexing from cache backend.
rgw/cache: modifications to policy driver code, commenting out
some pieces which refer to cache apis. Those apis have been
removed as part of modification to remove indexing from the
cache backend. These need to appropriately re-instated, once
we finalize which module will contain the data structures
related to cache policy.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: Modified APIs after removing indexing from
Pritha Srivastava [Thu, 24 Aug 2023 04:24:27 +0000 (09:54 +0530)]
rgw/cache: Modified APIs after removing indexing from
cache driver implementation.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: prototype implementation of an LRU Cache which includes
Pritha Srivastava [Thu, 24 Aug 2023 04:16:44 +0000 (09:46 +0530)]
rgw/cache: prototype implementation of an LRU Cache which includes
indexing and a list.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: this commit squashes commits related to removing
Pritha Srivastava [Mon, 14 Aug 2023 06:39:50 +0000 (12:09 +0530)]
rgw/cache: this commit squashes commits related to removing
cache_aio_read()/cache_aio_write() from cache api, ssd driver
and redis driver.

rgw/cache: removing cache_aio_read()/cache_aio_write()
interfaces from the Cache API. And moving cache_read_op
from rgw_aio.cc to ssd cache driver.
rgw/cache: changes related to cache_aio_read()/cache_aio_write()
in redis cache driver.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/d4n: completing the read flow for a local read cache,
Pritha Srivastava [Tue, 11 Jul 2023 15:32:20 +0000 (21:02 +0530)]
rgw/d4n: completing the read flow for a local read cache,
with ssd cache driver as the backend.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: fixing the segmentation fault by passing in 'yield'
Pritha Srivastava [Wed, 9 Aug 2023 09:47:29 +0000 (15:17 +0530)]
rgw/cache: fixing the segmentation fault by passing in 'yield'
by value to async_completion.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: implementation of put_async method in ssd driver
Pritha Srivastava [Tue, 11 Jul 2023 06:01:04 +0000 (11:31 +0530)]
rgw/cache: implementation of put_async method in ssd driver
and redis driver and squashes the following commits.

rgw/cache: implementation of async put. the call
does not take into account throttling for now.
rgw/cache: dummy implementation of put_async in redis
driver to fix compilation error.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agoRGW: Update read workflow so attributes get written
Samarah Uriarte [Wed, 5 Jul 2023 19:43:12 +0000 (15:43 -0400)]
RGW: Update read workflow so attributes get written

Signed-off-by: Samarah Uriarte <samarah.uriarte@ibm.com>
15 months agoRGW: Work on oid in cache and CacheBlock block ID
Samarah Uriarte [Thu, 29 Jun 2023 15:09:23 +0000 (11:09 -0400)]
RGW: Work on oid in cache and CacheBlock block ID

Signed-off-by: Samarah Uriarte <samarah.uriarte@ibm.com>
15 months agorgw/cache: This commit adds implementation of Partition in
Samarah Uriarte [Thu, 29 Jun 2023 13:51:02 +0000 (09:51 -0400)]
rgw/cache: This commit adds implementation of Partition in
ssd driver and squashes the following related commits.

RGW: Minor RedisDriver cleanup
RGW: Add partitioning
RGW: Cleanup RedisDriver

Signed-off-by: Samarah Uriarte <samarah.uriarte@ibm.com>
15 months agorgw/cache: This commit squashes commits related to boost::redis library.
Samarah Uriarte [Mon, 26 Jun 2023 19:56:01 +0000 (15:56 -0400)]
rgw/cache: This commit squashes commits related to boost::redis library.

RGW: Add boost_redis library
RGW: Add boost_redis to CMake
RGW: Add aedis methods to RedisDriver
RGW: Minor RedisDriver cleanup
build: Remove build/boost_redis
build: remove src/redis
build: Set src/boost_redis submodule to release version
RGW: Remove broken boost_redis
RGW: Add boost_redis
rgw: Get rgw_redis_driver to build
rgw/redis: Update `boost::redis` library
rgw/cache: fixing compilation error, by removing aedis header
file and src file includes from redis driver

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
Co-authored-by: Adam Emerson <aemerson@redhat.com>
Co-authored-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: fixing free space calcuation when data is deleted
Pritha Srivastava [Mon, 28 Aug 2023 11:43:38 +0000 (17:13 +0530)]
rgw/cache: fixing free space calcuation when data is deleted
from the cache backend.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agorgw/cache: This commit squashes the following commits
Pritha Srivastava [Mon, 3 Jul 2023 05:45:03 +0000 (11:15 +0530)]
rgw/cache: This commit squashes the following commits
related to xattrs in ssd driver.

rgw/cache: code to handle xattrs, which are stored as
file xattrs.
rgw/cache: correcting ssd driver get_attrs.
rgw/cache: fixing set_attrs in ssd cache driver.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agoRGW: Add D4N chunking mechanism
Samarah Uriarte [Fri, 23 Jun 2023 18:41:43 +0000 (14:41 -0400)]
RGW: Add D4N chunking mechanism

Signed-off-by: Samarah Uriarte <samarah.uriarte@ibm.com>
15 months agoRGW: move CacheDriver instance to D4N Filter
Samarah [Mon, 19 Jun 2023 18:00:16 +0000 (14:00 -0400)]
RGW: move CacheDriver instance to D4N Filter

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agoRGW: Fix rgw crash issue
Samarah [Mon, 19 Jun 2023 15:58:36 +0000 (11:58 -0400)]
RGW: Fix rgw crash issue

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agoRGW: Fix find_client method; rgw crash issue
Samarah [Mon, 19 Jun 2023 13:44:01 +0000 (09:44 -0400)]
RGW: Fix find_client method; rgw crash issue

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/d4n: This commit squashes the following commits related to
Samarah [Thu, 25 May 2023 18:58:26 +0000 (14:58 -0400)]
rgw/d4n: This commit squashes the following commits related to
d4n policy and filter driver.

RGW: Add cache driver base class - add d4n filter driver.
RGW: Update cache and policy files; add RedisDriver into D4N filter
RGW: Add D4N classes and unit testing; update cpp_redis submodule
QA: Add D4N teuthology suite
RGW: Improve D4N readability and structure
RGW: Add base D4N policy and test
RGW: Add GWF policy to D4N
RGW: Add global weight property
RGW: Added D4N namespace
RGW: Update policy driver interface
RGW: Update unit tests
RGW: Add Address struct to all files
RGW: Update D4N names and structure
RGW: Update structure and fix errors
RGW: Add more features to policy driver
RGW: Access local weight in policy code
RGW: Work on D4N workflows
RGW: Add object directory class and remove copy_value method
RGW: Establish object directory in read workflow
RGW: Update cache and policy files; add RedisDriver into D4N filter
RGW: Switch out D4N cache methods with Redis driver methods
RGW: Update RedisDriver to match new CacheDriver structure; define set_attrs method
RGW: Fix D4N read workflow crashes
RGW: Update D4N files to match CacheDriver changes
RGW: fix key_exists method for RedisDriver and clean up rgw_sal_d4n.cc
RGW: Use correct get_block method
RGW: Make CachePolicy a virtual class
RGW: Initialize localWeight if not found and develop find_victim method
RGW: Debugging network failure
RGW: Rebase and debugging network failure
RGW: Update RedisDriver::list_entries and usage in D4N policy driver
RGW: Fix network failure issue; add entries and entry methods
RGW: Update D4N test files to match rebase
RGW: Update D4N policy and RedisDriver with entries
RGW: make localWeight an attribute
rgw/cache: commit to fix compilation issues.

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/cache: this commit squashes the following commits for ssd backed cache driver.
Pritha Srivastava [Mon, 5 Jun 2023 08:04:32 +0000 (13:34 +0530)]
rgw/cache: this commit squashes the following commits for ssd backed cache driver.

initial implementation of ssd backed cache driver.This contains implementations
for methods related to Entry and Partition.

adding methods for put, get and delete data.
They are all synchronous.

added CacheAioRequest to handle async read and write
requests and added a corresponding read op in aio.h and aio.cc.

added get_async method implementation and
initial implementation to handle async reads using asio.

changing the signature of list_entries to match that with
base class and making it public.

adding implementation for asynchronous get.

modifying namespace from rgw::cal to rgw::cache.
Modifying the SSDDriver constructor for Partition related
modifications.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agoRGW: add entries and entry methods
Samarah [Tue, 13 Jun 2023 16:33:18 +0000 (12:33 -0400)]
RGW: add entries and entry methods

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/cache: This commit squashes the following commits related to list_entries cache...
Samarah [Thu, 8 Jun 2023 17:10:58 +0000 (13:10 -0400)]
rgw/cache: This commit squashes the following commits related to list_entries cache api.

RGW: Add list_entries method to CacheDriver and to Redis driver.
RGW: Change CacheDriver::list_entries output type
RGW: Update RedisDriver::list_entries and usage in D4N policy driver

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/cache: This commit squashes the following commits for redis driver.
Samarah [Fri, 22 Dec 2023 11:10:13 +0000 (16:40 +0530)]
rgw/cache: This commit squashes the following commits for redis driver.

RGW: fix key_exists method for RedisDriver and clean up rgw_sal_d4n.cc
RGW: Implement RedisDriver::get_free_space
rgw/cache: modifying namespace from rgw::cal to rgw::cache.
RGW: Update D4N files to match CacheDriver changes
RGW: Fix D4N read workflow crashes
RGW: Update RedisDriver to match new CacheDriver structure; define set_attrs method
RGW: Switch out D4N cache methods with Redis driver methods
RGW: Update Cache Driver structure
RGW: Update cache files.
RGW: create redis cache driver files

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agorgw/cache: This commit squashes modifications to base class.
Pritha Srivastava [Fri, 2 Jun 2023 10:16:23 +0000 (15:46 +0530)]
rgw/cache: This commit squashes modifications to base class.

1. Rename namespace from rgw::cal to rgw::cache
2. Remove Partition from the CacheDriver constructor.
3. Removing rgw_cache_driver.cc since all methods
are pure virtual in rgw_cache_driver.h.
4. Moving structures Partition and Entry out of
class CacheDriver. And modifying the signatures of methods
get_current_partition_info() and get_free_space().
5. modifying the cache driver base class.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
15 months agoRGW: Add cache driver base class
Samarah [Thu, 25 May 2023 18:58:26 +0000 (14:58 -0400)]
RGW: Add cache driver base class

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
15 months agoMerge pull request #55976 from cbodley/wip-qa-quincy-upgrade-distro
Casey Bodley [Tue, 2 Apr 2024 13:14:32 +0000 (14:14 +0100)]
Merge pull request #55976 from cbodley/wip-qa-quincy-upgrade-distro

qa/upgrade/quincy: bump ubuntu from 20->22

Reviewed-by: Adam King <adking@redhat.com>
15 months agoMerge pull request #56279 from ceph/long_processing_timeout
Casey Bodley [Tue, 2 Apr 2024 12:38:33 +0000 (13:38 +0100)]
Merge pull request #56279 from ceph/long_processing_timeout

rgw/s3select: s3select response handler refactor

Reviewed-by: Casey Bodley <cbodley@redhat.com>
15 months agoMerge pull request #56614 from zdover23/wip-doc-2024-03-30-mgr-zabbix
Zac Dover [Tue, 2 Apr 2024 11:21:15 +0000 (21:21 +1000)]
Merge pull request #56614 from zdover23/wip-doc-2024-03-30-mgr-zabbix

doc/mgr: update zabbix information

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
15 months agoMerge pull request #53679 from rhcs-dashboard/alerts-v2-api
Aashish Sharma [Tue, 2 Apr 2024 04:22:01 +0000 (09:52 +0530)]
Merge pull request #53679 from rhcs-dashboard/alerts-v2-api

mgr/dashboard: start using alertmanager v2

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
15 months agoMerge pull request #56596 from tchaikov/wip-on-exit-fix-leaks
Kefu Chai [Tue, 2 Apr 2024 00:43:42 +0000 (08:43 +0800)]
Merge pull request #56596 from tchaikov/wip-on-exit-fix-leaks

test/on_exit: use static variables for on_exit hooks

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
15 months agoMerge pull request #55979 from athanatos/sjust/wip-64546-max-creating-pgs
Samuel Just [Mon, 1 Apr 2024 20:18:15 +0000 (13:18 -0700)]
Merge pull request #55979 from athanatos/sjust/wip-64546-max-creating-pgs

mon: always create pgs in the epoch in which the pool was created

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
15 months agoMerge pull request #56533 from phlogistonjohn/jjm-cpatch-before
Adam King [Mon, 1 Apr 2024 15:32:36 +0000 (11:32 -0400)]
Merge pull request #56533 from phlogistonjohn/jjm-cpatch-before

cpatch: add --run-before command line option

Reviewed-by: Adam King <adking@redhat.com>
15 months agoMerge pull request #56136 from NitzanMordhai/wip-nitzan-init-hash-in-chunk-ref-by...
Yuri Weinstein [Mon, 1 Apr 2024 15:32:12 +0000 (08:32 -0700)]
Merge pull request #56136 from NitzanMordhai/wip-nitzan-init-hash-in-chunk-ref-by-hash

cls/cas/cls_cas_internal: Initialize 'hash' value before decoding

Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
15 months agoMerge pull request #54991 from ifed01/wip-ifed-some-recover-stuff
Yuri Weinstein [Mon, 1 Apr 2024 15:29:57 +0000 (08:29 -0700)]
Merge pull request #54991 from ifed01/wip-ifed-some-recover-stuff

tools/ceph-objectstore-tool: tricks to tolerate disk errors for "pg export" command.

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
15 months agodoc/mgr: update zabbix information 56614/head
Zac Dover [Fri, 29 Mar 2024 11:06:28 +0000 (21:06 +1000)]
doc/mgr: update zabbix information

Include information from John Jasen about how to install Zabbix.

Signed-off-by: Zac Dover <zac.dover@proton.me>
15 months agoMerge pull request #56512 from rhcs-dashboard/remove-token-authentication-multi-cluster
Aashish Sharma [Mon, 1 Apr 2024 14:00:56 +0000 (19:30 +0530)]
Merge pull request #56512 from rhcs-dashboard/remove-token-authentication-multi-cluster

mgr/dashboard: Remove token authentication multi cluster

Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agomgr/dashboard: remove the option for authentication with token in 56512/head
Aashish Sharma [Wed, 27 Mar 2024 09:45:59 +0000 (15:15 +0530)]
mgr/dashboard: remove the option for authentication with token in
multi-cluster form

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
15 months agoMerge pull request #55860 from ceph/add-multi-cluster-token-ttl
Aashish Sharma [Mon, 1 Apr 2024 07:50:37 +0000 (13:20 +0530)]
Merge pull request #55860 from ceph/add-multi-cluster-token-ttl

mgr/dashboard: Add multi cluster token ttl

Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #56600 from zdover23/wip-doc-2024-04-01-dev-essentials-leads-list
Zac Dover [Mon, 1 Apr 2024 01:36:42 +0000 (11:36 +1000)]
Merge pull request #56600 from zdover23/wip-doc-2024-04-01-dev-essentials-leads-list

doc/dev: update leads list

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
15 months agodoc/dev: update leads list 56600/head
Zac Dover [Mon, 1 Apr 2024 01:17:39 +0000 (11:17 +1000)]
doc/dev: update leads list

Remove Joao Luis from the list of component leads.

Signed-off-by: Zac Dover <zac.dover@proton.me>
15 months agorefactor of s3select response handler, adding continuation-response to parquet flow... 56279/head
Gal Salomon [Tue, 19 Mar 2024 11:45:58 +0000 (13:45 +0200)]
refactor of s3select response handler, adding continuation-response to parquet flow, refacor of error response

bug fix (init_success_response).
s3select submodule

fix for json-error-flow

Signed-off-by: Gal Salomon <gal.salomon@gmail.com>