]>
git.apps.os.sepia.ceph.com Git - ceph-ci.git/log 
Josh Durgin  [Wed, 18 Jul 2018 18:10:00 +0000  (11:10 -0700)] 
Merge pull request #23098 from neha-ojha/wip-limit-pglogReviewed-by: Josh Durgin <jdurgin@redhat.com> 
Casey Bodley  [Wed, 18 Jul 2018 17:25:58 +0000  (13:25 -0400)] 
Merge pull request #22347 from cbodley/wip-24367Reviewed-by: Orit Wasserman <owasserm@redhat.com> 
Casey Bodley  [Wed, 18 Jul 2018 17:25:01 +0000  (13:25 -0400)] 
Merge pull request #23032 from cbodley/wip-24873Reviewed-by: Matt Benjamin <mbenjamin@redhat.com> Reviewed-by: Orit Wasserman <owasserm@redhat.com> 
Andrew Schoen  [Wed, 18 Jul 2018 17:11:20 +0000  (17:11 +0000)] 
Merge pull request #23116 from alfredodeza/wip-rm24961Reviewed-by: Andrew Schoen <aschoen@redhat.com> 
Alfredo Deza  [Wed, 18 Jul 2018 16:39:01 +0000  (12:39 -0400)] 
ceph-volume tests/functional run lvm list after OSD provisioningSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Wed, 18 Jul 2018 16:04:11 +0000  (12:04 -0400)] 
Merge pull request #23075 from alfredodeza/wip-24492Reviewed-by: Andrew Schoen <aschoen@redhat.com> 
David Zafman  [Wed, 18 Jul 2018 15:23:07 +0000  (11:23 -0400)] 
Merge pull request #23083 from dzafman/wip-disable-skip-ddReviewed-by: Josh Durgin <jdurgin@redhat.com> 
Boris Ranto  [Wed, 18 Jul 2018 14:20:57 +0000  (16:20 +0200)] 
Merge pull request #22732 from b-ranto/wip-metric-resetReviewed-by: Jan Fajerski <jfajerski@suse.com> 
Patrick Donnelly  [Wed, 18 Jul 2018 13:43:13 +0000  (06:43 -0700)] 
Merge PR #23040 into masterReviewed-by: Rishabh Dave <ridave@redhat.com> 
Jason Dillaman  [Wed, 18 Jul 2018 12:10:07 +0000  (08:10 -0400)] 
Merge pull request #23008 from tchaikov/wip-rbd-silence-gcc-warningReviewed-by: Jason Dillaman <dillaman@redhat.com> 
Lenz Grimmer  [Wed, 18 Jul 2018 10:33:19 +0000  (12:33 +0200)] 
Merge pull request #22902 from alfonsomthd/24778-dashboard-info-cards-refactorReviewed-by: Ernesto Puerta <epuertat@redhat.com> Reviewed-by: Kanika Murarka <kmurarka@redhat.com> Reviewed-by: Ricardo Marques <rimarques@suse.com> Reviewed-by: Tiago Melo <tmelo@suse.com> 
Kefu Chai  [Wed, 18 Jul 2018 03:53:07 +0000  (11:53 +0800)] 
Merge pull request #23108 from tchaikov/wip-install-deps-seastarReviewed-by: Brad Hubbard <bhubbard@redhat.com> 
Kefu Chai  [Wed, 18 Jul 2018 02:28:03 +0000  (10:28 +0800)] 
install-deps: set DEBIAN_FRONTEND for apt-getSigned-off-by: Kefu Chai <kchai@redhat.com> 
Kefu Chai  [Wed, 18 Jul 2018 02:25:19 +0000  (10:25 +0800)] 
run-make-check: set WITH_SEASTAR with a non-empty stringSigned-off-by: Kefu Chai <kchai@redhat.com> 
Patrick Donnelly  [Wed, 18 Jul 2018 01:47:35 +0000  (18:47 -0700)] 
Merge PR #22966 into masterReviewed-by: Zheng Yan <zyan@redhat.com> 
Neha Ojha  [Tue, 17 Jul 2018 01:11:27 +0000  (18:11 -0700)] 
osd/PGLog: allow pg log trim when complete_to is less than trim_toSigned-off-by: Neha Ojha <nojha@redhat.com> 
Boris Ranto  [Tue, 17 Jul 2018 14:39:38 +0000  (16:39 +0200)] 
prometheus: Set the response header for cached responseSigned-off-by: Boris Ranto <branto@redhat.com> 
Boris Ranto  [Tue, 17 Jul 2018 13:59:20 +0000  (15:59 +0200)] 
prometheus: Reset the time the data was capturedSigned-off-by: Boris Ranto <branto@redhat.com> 
Boris Ranto  [Thu, 12 Jul 2018 17:29:07 +0000  (19:29 +0200)] 
prometheus: Format metrics in the collect functionSigned-off-by: Boris Ranto <branto@redhat.com> 
Boris Ranto  [Thu, 12 Jul 2018 17:01:50 +0000  (19:01 +0200)] 
prometheus: Remove the Metrics classSigned-off-by: Boris Ranto <branto@redhat.com> 
Boris Ranto  [Thu, 12 Jul 2018 15:05:18 +0000  (17:05 +0200)] 
prometheus: Optimize metrics formattingSigned-off-by: Boris Ranto <branto@redhat.com> 
Boris Ranto  [Thu, 12 Jul 2018 11:57:59 +0000  (13:57 +0200)] 
prometheus: Use instance instead of inst variableSigned-off-by: Boris Ranto <branto@redhat.com> 
Boris Ranto  [Wed, 11 Jul 2018 22:55:18 +0000  (00:55  +0200)] 
prometheus: Make the cache timeout configurableSigned-off-by: Boris Ranto <branto@redhat.com> 
Boris Ranto  [Wed, 27 Jun 2018 07:50:04 +0000  (09:50 +0200)] 
prometheus: Fix metric resetsSigned-off-by: Boris Ranto <branto@redhat.com> 
Alfredo Deza  [Mon, 16 Jul 2018 13:23:14 +0000  (09:23 -0400)] 
ceph-volume tests validate the new utils for promptsSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Mon, 16 Jul 2018 13:22:50 +0000  (09:22 -0400)] 
ceph-volume util create prompt helpersSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Fri, 13 Jul 2018 12:57:13 +0000  (08:57 -0400)] 
ceph-volume tests.api update lvm sizing testsSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Fri, 13 Jul 2018 12:55:46 +0000  (08:55 -0400)] 
ceph-volume tests verify str_to_int utilitySigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Fri, 13 Jul 2018 12:55:28 +0000  (08:55 -0400)] 
ceph-volume api.lvm convert and use extents for sizing calculationsSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Fri, 13 Jul 2018 12:54:33 +0000  (08:54 -0400)] 
ceph-volume util move the str_to_int utility out of lvmSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Thu, 12 Jul 2018 20:11:29 +0000  (16:11 -0400)] 
ceph-volume lvm.batch update help docs from auto to batchSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Thu, 12 Jul 2018 20:10:47 +0000  (16:10 -0400)] 
ceph-volume lvm.main rename auto to batchSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Thu, 12 Jul 2018 20:10:28 +0000  (16:10 -0400)] 
ceph-volume lvm rename auto to batchSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Thu, 12 Jul 2018 19:46:05 +0000  (15:46 -0400)] 
ceph-volume lvm.strategies add stubs for filestoreSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Thu, 12 Jul 2018 19:45:20 +0000  (15:45 -0400)] 
ceph-volume lvm.strategies add bluestore with validatorsSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Tue, 17 Jul 2018 18:03:10 +0000  (14:03 -0400)] 
Merge pull request #23093 from ceph/wip-rm24044Reviewed-by: Alfredo Deza <adeza@redhat.com> 
Matt Benjamin  [Tue, 17 Jul 2018 17:12:10 +0000  (13:12 -0400)] 
Merge pull request #23038 from linuxbox2/wip-rgwfile-deepstat
Kefu Chai  [Tue, 17 Jul 2018 15:31:23 +0000  (23:31 +0800)] 
Merge pull request #23044 from tchaikov/wip-crimson-connectionReviewed-by: Casey Bodley <cbodley@redhat.com> 
Abhishek L  [Tue, 17 Jul 2018 14:45:34 +0000  (16:45 +0200)] 
Merge pull request #23057 from liewegas/wip-12.2.7-notesReviewed-by: Nathan Cutler <ncutler@suse.com> Reviewed-by: Greg Farnum <gfarnum@redhat.com> Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com> Reviewed-by: Kefu Chai <kchai@redhat.com> Reviewed-by: Josh Durgin <jdurgin@redhat.com> 
Jason Dillaman  [Tue, 17 Jul 2018 13:59:56 +0000  (09:59 -0400)] 
Merge pull request #23085 from Songweibin/wip-rbd-unused-varReviewed-by: Jason Dillaman <dillaman@redhat.com> 
Andrew Schoen  [Mon, 16 Jul 2018 21:06:03 +0000  (16:06 -0500)] 
ceph-volume: an osd ID must exist and be destroyed before reuseFixes: https://tracker.ceph.com/issues/24044 Signed-off-by: Andrew Schoen <aschoen@redhat.com> 
Sage Weil  [Tue, 17 Jul 2018 12:18:30 +0000  (07:18 -0500)] 
Merge PR #22681 into masterReviewed-by: Kefu Chai <kchai@redhat.com> 
Sage Weil  [Tue, 17 Jul 2018 12:18:25 +0000  (07:18 -0500)] 
Merge PR #23052 into masterReviewed-by: David Zafman <dzafman@redhat.com> Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn> Reviewed-by: Josh Durgin <jdurgin@redhat.com> 
Sage Weil  [Sat, 14 Jul 2018 19:39:09 +0000  (14:39 -0500)] 
doc/release/luminous: v12.2.7 release notesSigned-off-by: Sage Weil <sage@redhat.com> 
Nathan Cutler  [Tue, 17 Jul 2018 11:29:49 +0000  (13:29 +0200)] 
Merge pull request #22899 from smithfarm/wip-doc-argonautReviewed-by: Sage Weil <sage@redhat.com> Reviewed-by: Kefu Chai <kchai@redhat.com> Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com> 
Nathan Cutler  [Tue, 17 Jul 2018 10:13:58 +0000  (12:13 +0200)] 
doc/start/hardware-recommendations.rst: link to Ceph blogSigned-off-by: Nathan Cutler <ncutler@suse.com> 
Nathan Cutler  [Tue, 17 Jul 2018 10:01:59 +0000  (12:01 +0200)] 
doc: fix up install/upgrading-ceph.rstSigned-off-by: Nathan Cutler <ncutler@suse.com> 
Nathan Cutler  [Fri, 6 Jul 2018 08:12:09 +0000  (10:12 +0200)] 
doc: cleanup: prune Argonaut-specific verbiageSigned-off-by: Nathan Cutler <ncutler@suse.com> 
Nathan Cutler  [Tue, 17 Jul 2018 08:57:52 +0000  (10:57 +0200)] 
Merge pull request #23079 from smithfarm/wip-with-seastar-fixReviewed-by: Kefu Chai <kchai@redhat.com> 
songweibin  [Tue, 17 Jul 2018 01:35:00 +0000  (09:35 +0800)] 
test/librbd: drop unused variable ‘num_aios’Signed-off-by: songweibin <song.weibin@zte.com.cn> 
Neha Ojha  [Tue, 17 Jul 2018 01:01:26 +0000  (18:01 -0700)] 
osd: reset complete_to when trimming the log past itSigned-off-by: Neha Ojha <nojha@redhat.com> 
Neha Ojha  [Mon, 16 Jul 2018 23:48:58 +0000  (16:48 -0700)] 
osd: allow trim() to proceed when there are missing itemsSigned-off-by: Neha Ojha <nojha@redhat.com> 
Neha Ojha  [Mon, 16 Jul 2018 23:31:22 +0000  (16:31 -0700)] 
osd: handle trim() during backfill and async recoverySigned-off-by: Neha Ojha <nojha@redhat.com> 
Neha Ojha  [Mon, 16 Jul 2018 22:42:43 +0000  (15:42 -0700)] 
osd: add flag to remember async recoverySigned-off-by: Neha Ojha <nojha@redhat.com> 
Neha Ojha  [Mon, 16 Jul 2018 22:06:12 +0000  (15:06 -0700)] 
osd: print pg log length and trim_toSigned-off-by: Neha Ojha <nojha@redhat.com> 
Neha Ojha  [Mon, 16 Jul 2018 21:46:21 +0000  (14:46 -0700)] 
osd: make calc_trim_to() independent of min_last_complete_ondiskSigned-off-by: Neha Ojha <nojha@redhat.com> 
David Zafman  [Mon, 16 Jul 2018 21:32:54 +0000  (14:32 -0700)] 
common: Fix description for osd_skip_data_digestSigned-off-by: David Zafman <dzafman@redhat.com> 
Sage Weil  [Sat, 14 Jul 2018 20:03:43 +0000  (15:03 -0500)] 
common/options: disable osd_skip_data_digest
This is flawed in that it stops doing digests based on the primary's
backend store, not the replicas.
Signed-off-by: Sage Weil <sage@redhat.com> 
(cherry picked from commit 
c7d8add701f156eb8bd8c7dc8ae9903bd782e77f )
Sage Weil  [Sat, 14 Jul 2018 18:26:31 +0000  (13:26 -0500)] 
common/options: make osd_skip_data_digest a DEV option
And document/warn to never turn it off after it's been on.
Signed-off-by: Sage Weil <sage@redhat.com> 
(cherry picked from commit 
c854ed9b33a5a293c8ace15718e26f74237e3332 )
Nathan Cutler  [Mon, 16 Jul 2018 20:07:57 +0000  (22:07 +0200)] 
build/ops: install-deps.sh: set with_seastar
25d5122b5538062e8282251c3d7bae0f9792d596  introduced code into
install-deps.sh which was intended to set a variable "with_seastar" to the
string "true" or "false" depending on whether or not an environment
variable WITH_SEASTAR is defined.
As originally implemented, the conditional is always true, so with_seastar
is set to "true" unconditionally. Fix this by putting $WITH_SEASTAR in
double quotes.
Signed-off-by: Nathan Cutler <ncutler@suse.com> 
Ron Allred  [Wed, 23 May 2018 14:34:41 +0000  (08:34 -0600)] 
ceph-volume util/prepare.pySigned-off-by: Ron Allred <rallred@itrefined.com> 
Patrick Donnelly  [Mon, 16 Jul 2018 16:17:19 +0000  (09:17 -0700)] 
Merge PR #23068 into masterReviewed-by: Patrick Donnelly <pdonnell@redhat.com> 
Jason Dillaman  [Mon, 16 Jul 2018 15:43:11 +0000  (11:43 -0400)] 
Merge pull request #22737 from trociny/wip-24675Reviewed-by: Jason Dillaman <dillaman@redhat.com> 
Alfredo Deza  [Thu, 5 Jul 2018 17:46:46 +0000  (13:46 -0400)] 
ceph-volume lvm.auto create a strategies moduleSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Thu, 5 Jul 2018 15:40:28 +0000  (11:40 -0400)] 
ceph-volume lvm.prepare do not pass the name when creating a vgSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Thu, 5 Jul 2018 15:39:53 +0000  (11:39 -0400)] 
ceph-volume api.lvm create_vg should optionally name vgs on the flySigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Thu, 5 Jul 2018 12:29:13 +0000  (08:29 -0400)] 
ceph-volume lvm.main make auto a subcommandSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Alfredo Deza  [Thu, 5 Jul 2018 12:28:39 +0000  (08:28 -0400)] 
ceph-volume lvm.auto add --yes prompt to execute strategiesSigned-off-by: Alfredo Deza <adeza@redhat.com> 
Zhu Shangzhong  [Mon, 16 Jul 2018 07:16:29 +0000  (15:16 +0800)] 
doc: fix some errors in the cephfs-journal-toolSigned-off-by: Zhu Shangzhong <zhu.shangzhong@zte.com.cn> 
Patrick Donnelly  [Sun, 15 Jul 2018 22:10:08 +0000  (15:10 -0700)] 
Merge PR #23059 into masterReviewed-by: Patrick Donnelly <pdonnell@redhat.com> 
Patrick Donnelly  [Sun, 15 Jul 2018 22:03:13 +0000  (15:03 -0700)] 
Merge PR #22211 into masterReviewed-by: Patrick Donnelly <pdonnell@redhat.com> Reviewed-by: Zheng Yan <zyan@redhat.com> 
Patrick Donnelly  [Sun, 15 Jul 2018 22:03:08 +0000  (15:03 -0700)] 
Merge PR #22705 into masterReviewed-by: Patrick Donnelly <pdonnell@redhat.com> 
Patrick Donnelly  [Sun, 15 Jul 2018 22:03:03 +0000  (15:03 -0700)] 
Merge PR #22751 into masterReviewed-by: Patrick Donnelly <pdonnell@redhat.com> Reviewed-by: Zheng Yan <zyan@redhat.com> 
Patrick Donnelly  [Sun, 15 Jul 2018 22:02:58 +0000  (15:02 -0700)] 
Merge PR #22801 into masterReviewed-by: Venky Shankar <vshankar@redhat.com> 
Patrick Donnelly  [Sun, 15 Jul 2018 22:02:57 +0000  (15:02 -0700)] 
githubmap: update contributorsSigned-off-by: Patrick Donnelly <pdonnell@redhat.com> 
Patrick Donnelly  [Sun, 15 Jul 2018 22:01:59 +0000  (15:01 -0700)] 
Merge PR #22804 into masterReviewed-by: Patrick Donnelly <pdonnell@redhat.com> 
Mykola Golub  [Wed, 27 Jun 2018 14:18:24 +0000  (17:18 +0300)] 
librbd: validate data pool for self-managed snapshot supportFixes: https://tracker.ceph.com/issues/24675 Signed-off-by: Mykola Golub <mgolub@suse.com> 
Abhishek Lekshmanan  [Wed, 11 Jul 2018 12:43:16 +0000  (14:43 +0200)] 
doc: releases: release notes for v12.2.6 luminousSigned-off-by: Abhishek Lekshmanan <abhishek@suse.com> 
Jason Dillaman  [Sat, 14 Jul 2018 18:18:02 +0000  (14:18 -0400)] 
Merge pull request #22945 from cxytt/masterReviewed-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Sat, 14 Jul 2018 18:17:17 +0000  (14:17 -0400)] 
Merge pull request #22637 from zy751713126/resize_equal_sizeReviewed-by: Jason Dillaman <dillaman@redhat.com> 
Jason Dillaman  [Sat, 14 Jul 2018 18:16:57 +0000  (14:16 -0400)] 
Merge pull request #20112 from liyichao/aio_failReviewed-by: Jason Dillaman <dillaman@redhat.com> 
Sage Weil  [Sat, 14 Jul 2018 17:39:15 +0000  (12:39 -0500)] 
osd: fix deep scrub with osd_skip_data_digest=true (default) and bluestoreFixes: http://tracker.ceph.com/issues/24922 Signed-off-by: Sage Weil <sage@redhat.com> 
Kefu Chai  [Sat, 14 Jul 2018 13:33:08 +0000  (21:33 +0800)] 
Merge pull request #23046 from tchaikov/wip-ftbfs-rgw-kefu
rgw: fix FTBFS introduced by 
abca9805 
Kefu Chai  [Sat, 14 Jul 2018 10:26:17 +0000  (18:26 +0800)] 
rgw: fix FTBFS introduced by 
abca9805 
Signed-off-by: Kefu Chai <kchai@redhat.com> 
Kefu Chai  [Sat, 14 Jul 2018 09:36:20 +0000  (17:36 +0800)] 
Merge pull request #22809 from tchaikov/wip-with-seastarReviewed-by: Casey Bodley <cbodley@redhat.com> 
Kefu Chai  [Sat, 14 Jul 2018 07:47:00 +0000  (15:47 +0800)] 
Merge pull request #22964 from tchaikov/wip-import-pub-key-without-hkp-serverReviewed-by: Ken Dreyer <kdreyer@redhat.com> 
Kefu Chai  [Fri, 29 Jun 2018 11:49:59 +0000  (19:49 +0800)] 
crimson/net: use boost::thread_unsafe_counter for refcounting ConnectionSigned-off-by: Kefu Chai <kchai@redhat.com> 
Kefu Chai  [Fri, 29 Jun 2018 11:51:31 +0000  (19:51 +0800)] 
crimson/net: add Connection::get_peer_type()Signed-off-by: Kefu Chai <kchai@redhat.com> 
Patrick Donnelly  [Sat, 14 Jul 2018 01:16:51 +0000  (18:16 -0700)] 
Merge PR #22971 into master
Patrick Donnelly  [Sat, 14 Jul 2018 01:15:17 +0000  (18:15 -0700)] 
qa: optionally use old fs name during cephfs remountSigned-off-by: Patrick Donnelly <pdonnell@redhat.com> 
Patrick Donnelly  [Sat, 14 Jul 2018 01:15:03 +0000  (18:15 -0700)] 
qa: remove dead codeSigned-off-by: Patrick Donnelly <pdonnell@redhat.com> 
Patrick Donnelly  [Sat, 14 Jul 2018 00:01:51 +0000  (17:01 -0700)] 
ceph-debug-docker: install python3 cephfs/rados packagesFixes: http://tracker.ceph.com/issues/24870 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> 
Patrick Donnelly  [Tue, 10 Jul 2018 20:14:05 +0000  (13:14 -0700)] 
qa: run asok command on correct machineFixes: http://tracker.ceph.com/issues/24858 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> 
Matt Benjamin  [Fri, 13 Jul 2018 21:35:05 +0000  (17:35 -0400)] 
rgw_file: deep stat handlingFixes: http://tracker.ceph.com/issues/24915 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> 
Patrick Donnelly  [Fri, 13 Jul 2018 20:57:17 +0000  (13:57 -0700)] 
Merge PR #21885 into masterReviewed-by: Patrick Donnelly <pdonnell@redhat.com> 
Patrick Donnelly  [Fri, 13 Jul 2018 20:57:10 +0000  (13:57 -0700)] 
Merge PR #23018 into masterReviewed-by: Zheng Yan <zyan@redhat.com> 
Patrick Donnelly  [Fri, 13 Jul 2018 04:35:46 +0000  (21:35 -0700)] 
qa: use 4 mds cluster for multifs testsFixes: http://tracker.ceph.com/issues/24899 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> 
Patrick Donnelly  [Fri, 13 Jul 2018 17:57:24 +0000  (10:57 -0700)] 
qa: update cluster log health warning messageSigned-off-by: Patrick Donnelly <pdonnell@redhat.com> 
Matt Benjamin  [Fri, 13 Jul 2018 16:36:24 +0000  (12:36 -0400)] 
Merge pull request #23033 from linuxbox2/wip-rgw-409
Kefu Chai  [Fri, 13 Jul 2018 15:32:47 +0000  (23:32 +0800)] 
Merge pull request #23020 from tchaikov/wip-config-value-friendReviewed-by: Mykola Golub <mgolub@suse.com> Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>