mgr/cephadm: f-string is missing placeholders (F541)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Do not use variables named 'I', 'O', or 'l' (E741)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Do not assign a lambda expression, use a def (E731)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Do not use bare except, specify exception instead (E722)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Comparison to true should be 'if cond is true:' or 'if cond:' (E712)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Multiple statements on one line (def) (E704)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: statement ends with a semicolon (E703)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Expected 1 blank line before a nested definition (E306)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Expected 2 blank lines, found 0 (E302)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: at least two spaces before inline comment (E261)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: multiple spaces after ':' (E241)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Missing whitespace after ',', ';', or ':' (E231)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Missing whitespace around arithmetic operator (E226)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Missing whitespace around operator (E225)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Continuation line under-indented for visual indent (E128)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Continuation line over-indented for hanging indent (E126)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: closing bracket does not match visual indentation (E124)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Continuation line missing indentation or outdented (E122)

also resolves:
continuation line unaligned for hanging indent (E131)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Continuation line under-indented for hanging indent (E121)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: Indentation is not a multiple of four (comment) (E114)

Signed-off-by: Michael Fritch <mfritch@suse.com>

mgr/cephadm: introduce flake8

Signed-off-by: Michael Fritch <mfritch@suse.com>

Merge pull request #39261 from adk3798/applytest

mgr/orchestrator: useful message when no service type in "ceph orch apply"

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #39238 from liewegas/cephadm-conditional-osd-apply

mgr/cephadm: only apply osd specs if the devices have changed

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #39259 from sebastian-philipp/cephadm-execnet-chmod-600

mgr/cephadm: on ssh connection error, advice chmod 0600

Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #39318 from AlexWangD/patch-3

doc: fix the spelling mistake of “Rersult”

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

doc: fix the spelling mistake of “Rersult”

“Rersult” is a spelling mistake of "Result".

Signed-off-by: Alex Wang wangdashuai@inspur.com

Merge pull request #39258 from Rethan/doc-remove-ms-options

doc/rados: remove some invalid ms option

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38538 from chenerqi/qos-skip-discard

librbd: optionally exclude ops from qos

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #39176 from ivancich/wip-rgw-gap-list

rgw: tooling to locate rgw objects with missing rados components

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Michael Kidd <linuxkidd@gmail.com>

Merge PR #39213 into master

* refs/pull/39213/head:
qa/suites/upgrade/octopus-x/parallel: include cephfs in upgrade cluster

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #39135 from orozery/librbd-crypto-performance

librbd: crypto performance optimization

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #39298 from dillaman/wip-rbd-suite-readahead

qa/suites/rbd: drop require-osd-release command

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge PR #39147 into master

* refs/pull/39147/head:
qa/tasks/ceph_fuse: do not createfs
qa/tasks/cephfs/fuse_mount: pass admin_socket path
qa/suites/fs/cephadm/multivolume: add basic multivolume test
mgr/mds_autoscaler: some fixes and cleanup
mgr/volumes: deploy MDSs when creating fs

Reviewed-by: Milind Changire <mchangir@redhat.com>

Merge pull request #39262 from zdover23/wip-doc-removing-workbench-from-docs-2021-Feb-first

doc/dev: Remove workbench mentions

Reviewed-by: Neha Ojha <nojha@redhat.com>

qa/suites/rbd: drop require-osd-release command

Teuthology already defaults to quincy now and results in a failure
when trying to set to pacific. Additionally, drop the LUKS readbalance
test since it's unnecessary to duplicate that test.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #38715 from lxbsz/rest_api

qa: add REST API method support for ceph-iscsi

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #39265 from zdover23/wip-doc-rados-realy-typo-2020-feb

doc/rados: s/realy/really/

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #39263 from cbodley/wip-48963

cmake: partial revert of BOOST_USE_VALGRIND when ALLOCATOR=libc

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #39182 from cbodley/wip-49065

rgw multisite: fix RGWCoroutine error handling

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #39241 from dillaman/wip-49117

test/rbd-mirror: fix broken ceph_test_rbd_mirror_random_write

Reviewed-by: Mykola Golub <mgolub@suse.com>

qa/suites/upgrade/octopus-x/parallel: include cephfs in upgrade cluster

Signed-off-by: Sage Weil <sage@newdream.net>

Merge PR #39210 into master

* refs/pull/39210/head:
qa/suites/rados: move thrash-old-clients out of cephadm

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #39229 from rhcs-dashboard/label-badge

mgr/dashboard: Add badge to the Label column in Host List

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #39269 from tchaikov/wip-crimson-seastore-cleanup

crimson/os/seastore: do not capture unused variables

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #39162 from sebastian-philipp/cephadm-find-orch-ls-assert

mgr/cephadm: Add strings to assert statements

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #38927 from sebastian-philipp/cephadm-upgrade-retry-ceph-volume

mgr/cephadm: try again calling ceph-volume without --filter-for-batch

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>

Merge pull request #39242 from vshankar/wip-cephfs-mirroring-doc-cleanup

doc: cleanup cephfs-mirroring document

Merge pull request #39208 from sebastian-philipp/pyhton-common-more-typing

python-common: Add more type annotations

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38685 from tchaikov/wip-gil

mgr/ActivePyModules.cc: always acquire locks without holding GIL

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #39217 from myoungwon/wip-fix-seg-fault-manifest-ops

osd: fix to call nullptr when cancel_manifest_ops

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #39224 from petrutlucian94/rbd_fixes

Windows RBD fixes

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #39145 from ronen-fr/wip-ronenf-scrub-48793

osd: fix the scrubber behavior on multiple preemption attempts

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #39279 from cbodley/wip-cmake-spawn-options

cmake/rgw: forward spawn's compile options to rgw_common object library

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

rgw: add rgw-gap-list-comparator tool

The rgw-gap-list tool can produce a number of false positives when the
cluster is being used during its run. One technique to minimize the
number of false positives is to run the tool twice and look for the
objects that appear in both lists. The rgw-gap-list-comparator tool is
designed to do this comparison.

Signed-off-by: Michael Kidd <linuxkidd@gmail.com>

rgw: add rgw-gap-list tool

Due to a prior bug (pr: 38228) tail rados objects of some RGW objects
could have been incorrectly deleted. This tool is designed to look for
such cases. It essentially does the opposite of rgw-orphan-list,
looking for rados objects that RGW expects to be there, but which are
not to be found.

IMPORTANT: This is very experimental at this point in time, and any
"results" produced should be verified by other means.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
Signed-off-by: Michael Kidd <linuxkidd@gmail.com>

Merge pull request #39275 from neha-ojha/wip-49139

qa/suites/rados/perf: pin to 18.04

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

cmake/rgw: forward spawn's compile options to rgw_common object library

since rgw_common is an OBJECT library, we can't use
target_link_libraries() for its dependency on spawn. we add its
include directories manually already with
$<TARGET_PROPERTY:spawn,INTERFACE_INCLUDE_DIRECTORIES>, but this didn't
pull in the compile definitions. this ultimately prevented the
WITH_BOOST_VALGRIND option from passing the BOOST_USE_VALGRIND
definition attached to boost::context

Signed-off-by: Casey Bodley <cbodley@redhat.com>

cmake: remove unnecessary target_include_directories() for spawn

targets that depend on spawn via target_link_libraries() automatically
pull in their compile options and include directories

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #39274 from yuriw/wip-yuriw-crontab-master

qa/tests: removed ceph-ansible (master and pacific)

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

qa/suites/perf-basic: pin to 18.04

This will have same problems as https://tracker.ceph.com/issues/49139

Signed-off-by: Neha Ojha <nojha@redhat.com>

mgr/cephadm: 'drive group' -> 'service'

...and add 'osd.' prefix

Signed-off-by: Sage Weil <sage@newdream.net>

qa/tests: removed ceph-ansible (master and pacific)

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

qa/suites/rados/perf: pin to 18.04

Caused by a07ca4c5c0f04c43c71231a898c2a89e99a80606

Fixes: https://tracker.ceph.com/issues/49139
Signed-off-by: Neha Ojha <nojha@redhat.com>

Merge PR #38687 into master

* refs/pull/38687/head:
ceph-volume: mock VGs with string properties in tests
ceph-volume: add some flexibility to bytes_to_extents

Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>

Merge pull request #39186 from tchaikov/wip-mgr-telemetry-ann

pybind/mgr: add typing annotation

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Yaarit Hatuka <yaarit@redhat.com>

crimson/os/seastore: do not capture unused variables

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #39260 from idryomov/wip-expand-randomized-suite-doc

qa: expand the documentation on the '$' suite feature

Reviewed-by: Kefu Chai <kchai@redhat.com>

mgr/orchestrator: useful message when no service type in "ceph orch apply"

Right now it just gives a traceback. A message telling users they have
not provided a proper service type would be more useful

Signed-off-by: Adam King <adking@redhat.com>

Merge pull request #37954 from joscollin/wip-F46226-log-dq-throttle-limit-new

msg,mon,common: log when DispatchQueue throttle limit is reached

Merge PR #39069 into master

* refs/pull/39069/head:
mgr/cephadm/upgrade: tolerate pre-pacific upgrade state
mgr/cephadm/upgrade: scale down MDS cluster(s) for major version upgrades
mgr/cephadm: fix capitalization, level; drop elipses of log msgs
mgr/cephadm/upgrade: match against any repo_digest, not image_id
cephadm: return repo_digests (plural) in pull/inspect output
mgr/cephadm: include container_image_digests in inventory
cephadm: include image_digests list in 'ls' output
vstart.sh: only extract first container digest
mgr/cephadm: move release -> major translation to helper
mgr/cephadm/upgrade: tolerate old upgrade_state.target_versoin
mgr/cephadm/upgrade: set require-osd-release when done with OSDs
mgr: add lookup_release_name(int) to mgr interface
mgr/cephadm: verify container image version after we pull it
mgr/cephadm: only save version portion of version string
cephadm: fix 'inspect' and 'pull'
mgr/cephadm/upgrade: implement N-2 version checks on upgrade start

Reviewed-by: Sebastian Wagner <swagner@suse.com>

doc/rados: s/realy/really/

This corrects the spelling of "realy" to "really".
Hat-tip to IcePic, who noticed this on 03 Feb 2021.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #39234 from neha-ojha/wip-49064

qa/*/test_envlibrados_for_rocksdb: use osd_client_message_cap to prevent slow requests

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

cmake: partial revert of BOOST_USE_VALGRIND when ALLOCATOR=libc

the WITH_SYSTEM_BOOST binaries are not built with BOOST_USE_VALGRIND, so
it probably isn't safe to define for the headers only

this flag is needed for teuthology testing, and the shaman builds use
WITH_SYSTEM_BOOST=OFF. so the better fix is to enable WITH_BOOST_VALGRIND
so BuildBoost.cmake will build the libraries with valgrind support and add
-DBOOST_USE_VALGRIND to the necessary targets

this change was merged in https://github.com/ceph/ceph-build/pull/1736

Fixes: https://tracker.ceph.com/issues/48963
Signed-off-by: Casey Bodley <cbodley@redhat.com>

qa: expand the documentation on the '$' suite feature

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

doc/dev: Remove workbench mentions

This PR removes the "running-tests-in-cloud.rst"
file, which explains how to use ceph-workbench.
ceph-workbench is now deprecated, and the new
Teuthology documentation supplants the information
in the ceph-workbench-related documentation.

This PR also alters the "index.rst" file to remove
a link to "running-tests-in-cloud.rst".

Fixes: https://tracker.ceph.com/issues/49109 (partially)
Signed-off-by: Zac Dover <zac.dover@gmail.com>

doc: cleanup cephfs-mirroring document

Remove references to in-progress feature, remove internal interfaces
section and minor cleanups.

Signed-off-by: Venky Shankar <vshankar@redhat.com>

mgr/cephadm: on ssh connection error, advice chmod 0600

Fixes: https://tracker.ceph.com/issues/46551
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

doc/rados: remove some invalid ms option

Remove some outdated ms options.

Signed-off-by: haoyixing <haoyixing@kuaishou.com>

pybind/mgr/hello: use f-string when appropriate

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/crash: flake8 cleanups

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/crash: add type annotations

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/crash: define options using Option

more type safe this way

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/crash: define commands using CLICommand

more type safe this way

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38955 from varshar16/wip-doc-update-nfs-ganesha-dynamic

doc/cephfs/nfs: Add rook pod restart note, export and log block example

win32*.sh: move debug symbols to separate files

This patch simplifies releasing Windows binaries along with debug
symbols.

By default, we're going to provide minimum debug information (-g1).
The symbols are extracted from the binaries and placed in separate
files in the ".debug" folder, which is used by gdb implicitly.

This is more convenient than having separate versions of the binaries,
with or without debug symbols.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

pybind/mgr/alerts: define options using Option

more type safe this way

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/cephadm: PEP8 cleanups

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/alerts: use CLIReadCommand to define commands

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/status: PEP8 cleanups

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/iostat: PEP8 cleanups

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/devicehealth: PEP8 cleanups

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/insights: PEP8 cleanups

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/prometheus: PEP8 cleanups

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/telemetry: use CLICommand to define commands

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/telemetry: silence flake8 warnings

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr: define substitution for autopep8 params

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/telemetry: remove duplicated dict entry

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/telemetry: remove duplicated method

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/telemetry: add typing annotations

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/telemetry: use Option to define options

Signed-off-by: Kefu Chai <kchai@redhat.com>