]>
 
 
git.apps.os.sepia.ceph.com Git - ceph-ci.git/log 
 
 
 
 
 
 
Juan Miguel Olmo Martínez  [Wed, 14 Dec 2022 16:59:40 +0000  (17:59 +0100)] 
 
mgr/rook: Replace hardcoded namespace 
 
The namespace used by a rook cluster can be different form the default (rook-ceph) that was hardcoded in several places in the rook_cluster module. 
 
fixes: https://tracker.ceph.com/issues/58210 
 
Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>  
colemitchell  [Wed, 14 Dec 2022 07:08:00 +0000  (02:08  -0500)] 
 
Merge pull request #49421 from zdover23/wip-doc-2022-12-14-glossary-fqdn 
 
doc/glossary: add "FQDN" entry 
 
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>  
Zac Dover  [Wed, 14 Dec 2022 05:59:51 +0000  (15:59 +1000)] 
 
doc/glossary: add "FQDN" entry 
 
Add "FQDN" definition to doc/glossary.rst. 
 
Signed-off-by: Zac Dover <zac.dover@gmail.com>  
Yingxin  [Wed, 14 Dec 2022 02:05:57 +0000  (10:05 +0800)] 
 
Merge pull request #49242 from myoungwon/wip-enable-rbm-test-seastore 
 
test/crimson/seastore: enable RBM-based unittest-seastore 
 
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>  
Kefu Chai  [Wed, 14 Dec 2022 00:42:16 +0000  (08:42 +0800)] 
 
Merge pull request #49407 from tchaikov/cmake-find-boost 
 
cmake: add 1.79 and 1.80 to known versions 
 
Reviewed-by: Casey Bodley <cbodley@redhat.com>  
yaarith  [Tue, 13 Dec 2022 19:34:45 +0000  (14:34 -0500)] 
 
Merge pull request #48214 from ljflores/wip-telemetry-bluestore-compression-mode 
 
mgr/telemetry: add `basic_pool_options_bluestore` collection 
 
Reviewed-by: Yaarit Hatuka <yaarit@redhat.com>  
Kefu Chai  [Tue, 13 Dec 2022 16:40:48 +0000  (00:40  +0800)] 
 
Merge pull request #49190 from tchaikov/wip-fmt 
 
fmt: pickup v9.1.0 
 
Reviewed-by: Tim Serong <tserong@suse.com>  
Reviewed-by: Casey Bodley <cbodley@redhat.com>  
Ronen Friedman  [Tue, 13 Dec 2022 14:02:24 +0000  (16:02 +0200)] 
 
Merge pull request #49410 from ronen-fr/wip-rf-cinode-tm 
 
mds: remove unused declaration 
 
Reviewed-by: Matan Breizman <mbreizma@redhat.com>  
Ronen Friedman  [Tue, 13 Dec 2022 12:24:08 +0000  (14:24 +0200)] 
 
mds: remove unused declaraion 
 
as some Jenkins builds are set to treat warnings as errors, and 
complain. 
 
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>  
Kefu Chai  [Tue, 13 Dec 2022 10:08:08 +0000  (18:08 +0800)] 
 
cmake: adapt FindBoost.cmake to our needs 
 
the vanilla FindBoost.cmake pulled from cmake has couple assumptions 
which do not hold in our environment. so address them case by case. 
 
Signed-off-by: Kefu Chai <tchaikov@gmail.com>  
Kefu Chai  [Tue, 13 Dec 2022 10:05:57 +0000  (18:05 +0800)] 
 
cmake: add 1.79 and 1.80 to known versions
sync with
https://github.com/Kitware/CMake/blob/
468a995346271c02f2248adf3539fbb34edaef2e /Modules/FindBoost.cmake
for v1.79 and v1.80 support
Signed-off-by: Kefu Chai <tchaikov@gmail.com> 
 
Matan  [Tue, 13 Dec 2022 08:54:48 +0000  (10:54 +0200)] 
 
Merge pull request #49250 from Matan-B/wip-matanb-debug-subsys-doc 
 
doc/rados/troubleshooting/log-and-debug: Update according to subsys.h 
 
Reviewed-by: Laura Flores <lflores@redhat.com>  
Venky Shankar  [Tue, 13 Dec 2022 08:48:34 +0000  (14:18 +0530)] 
 
Merge pull request #48449 from batrick/i57851 
 
pybind/mgr: use memory temp_store 
 
Reviewed-by: Venky Shankar <vshankar@redhat.com>  
Reviewed-by: Milind Changire <mchangir@redhat.com>  
Avan  [Tue, 13 Dec 2022 07:11:59 +0000  (12:41 +0530)] 
 
Merge pull request #49329 from rhcs-dashboard/fix-cors 
 
mgr/dashboard: allow Origin url for CORS if present in config 
 
Reviewed-by: Aashish Sharma <aasharma@redhat.com>  
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>  
Reviewed-by: Kefu Chai <kchai@redhat.com>  
colemitchell  [Tue, 13 Dec 2022 04:47:41 +0000  (23:47 -0500)] 
 
Merge pull request #49396 from zdover23/wip-doc-2022-12-13-glossary-secrets 
 
doc/glossary - add "secrets" 
 
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>  
Zac Dover  [Tue, 13 Dec 2022 04:39:35 +0000  (14:39 +1000)] 
 
doc/glossary - add "secrets" 
 
Add "secrets" to doc/glossary.rst. 
 
Signed-off-by: Zac Dover <zac.dover@gmail.com>  
myoungwon oh  [Mon, 5 Dec 2022 02:33:10 +0000  (11:33 +0900)] 
 
test/crimson/seastore: enable RBM-based unittest-seastore 
 
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>  
Yuri Weinstein  [Mon, 12 Dec 2022 21:35:26 +0000  (13:35 -0800)] 
 
Merge pull request #49391 from ceph/wip-yuri-crontab-main 
 
qa/tests: added quincy-p2p tp the mix 
 
Reviewed-by: Laura Flores <lflores@redhat.com>  
Yuri Weinstein  [Mon, 12 Dec 2022 19:31:52 +0000  (11:31 -0800)] 
 
qa/tests: added quincy-p2p tp the mix 
 
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>  
Yuri Weinstein  [Mon, 12 Dec 2022 19:01:15 +0000  (11:01 -0800)] 
 
Merge pull request #49251 from shreyanshjain7174/cppool_space 
 
rados: fix extra tabs on warning for pool copy 
 
Reviewed-by: Laura Flores <lflores@redhat.com>  
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>  
Yuri Weinstein  [Mon, 12 Dec 2022 19:00:19 +0000  (11:00 -0800)] 
 
Merge pull request #47596 from YiteGu/dump-slow-ops-count 
 
osd: add dump slow ops count 
 
Reviewed-by: Samuel Just <sjust@redhat.com>  
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>  
Casey Bodley  [Mon, 12 Dec 2022 17:20:52 +0000  (12:20 -0500)] 
 
Merge pull request #48711 from cfsnyder/wip-cfsnyder-del-perf-iops 
 
rgw: add 'inline_data' zone placement info option 
 
Reviewed-by: Casey Bodley <cbodley@redhat.com>  
Laura Flores  [Mon, 12 Dec 2022 17:11:44 +0000  (11:11 -0600)] 
 
Merge pull request #49278 from Matan-B/wip-matanb-EIO-flag-fix 
 
test/librados/aio_cxx: Fix Pool EIO flag tests 
 
Laura Flores  [Mon, 12 Dec 2022 17:11:02 +0000  (11:11 -0600)] 
 
Merge pull request #49180 from anthonyeleven/anthonyeleven/rework-pool-create-pg-error-message 
 
src/mon: clarify message for pool creation failure due to max_pgs_per_osd 
 
Venky Shankar  [Mon, 12 Dec 2022 14:13:54 +0000  (19:43 +0530)] 
 
Merge PR #45192 into main 
 
* refs/pull/45192/head: 
	mds: use the whole string as the snapshot long name 
 
Reviewed-by: Jos Collin <jcollin@redhat.com>  
Reviewed-by: Ramana Raja <rraja@redhat.com>  
Reviewed-by: Venky Shankar <vshankar@redhat.com>  
Reviewed-by: Jeff Layton <jlayton@redhat.com>  
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>  
Venky Shankar  [Mon, 12 Dec 2022 14:12:55 +0000  (19:42 +0530)] 
 
Merge PR #45312 into main 
 
* refs/pull/45312/head: 
	qa: new snapshot test for snapshot naming limits 
	mds: limit the snapshot names to 240 characters 
 
Reviewed-by: Xiubo Li <xiubli@redhat.com>  
Reviewed-by: Jeff Layton <jlayton@redhat.com>  
Reviewed-by: Jos Collin <jcollin@redhat.com>  
Reviewed-by: Venky Shankar <vshankar@redhat.com>  
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>  
Venky Shankar  [Mon, 12 Dec 2022 14:12:22 +0000  (19:42 +0530)] 
 
Merge PR #48450 into main 
 
* refs/pull/48450/head: 
	qa: add test_mdsdir_scrub_backtrace 
	mds: avoid ~mdsdir's scrubbing and reporting damage health status 
 
Reviewed-by: Venky Shankar <vshankar@redhat.com>  
Reviewed-by: Milind Changire <mchangir@redhat.com>  
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>  
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>  
Venky Shankar  [Mon, 12 Dec 2022 14:11:47 +0000  (19:41 +0530)] 
 
Merge PR #48642 into main 
 
* refs/pull/48642/head: 
	qa: Fix test_subvolume_snapshot_info_if_orphan_clone 
 
Reviewed-by: Ramana Raja <rraja@redhat.com>  
Reviewed-by: Venky Shankar <vshankar@redhat.com>  
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>  
Venky Shankar  [Mon, 12 Dec 2022 14:08:10 +0000  (19:38 +0530)] 
 
Merge PR #48786 into main 
 
* refs/pull/48786/head: 
	mds/PurgeQueue: don't consider filer_max_purge_ops when _calculate_ops 
 
Reviewed-by: Ramana Raja <rraja@redhat.com>  
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>  
Reviewed-by: Venky Shankar <vshankar@redhat.com>  
Venky Shankar  [Mon, 12 Dec 2022 14:07:31 +0000  (19:37 +0530)] 
 
Merge PR #48873 into main 
 
* refs/pull/48873/head: 
	mount: fix mount failure with old kernels 
 
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>  
Reviewed-by: Venky Shankar <vshankar@redhat.com>  
Venky Shankar  [Mon, 12 Dec 2022 14:06:11 +0000  (19:36 +0530)] 
 
Merge PR #49117 into main 
 
* refs/pull/49117/head: 
	mds: remove redundant frag check in MDBalancer::maybe_fragment() 
 
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>  
Reviewed-by: Jos Collin <jcollin@redhat.com>  
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>  
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>  
Adam King  [Mon, 12 Dec 2022 13:44:34 +0000  (08:44 -0500)] 
 
Merge pull request #48258 from adk3798/upgrade-mgr-loop 
 
mgr/cephadm: fix handling of mgr upgrades with 3 or more mgrs 
 
Reviewed-by: Redouane Kachach <rkachach@redhat.com>  
Adam King  [Mon, 12 Dec 2022 13:43:25 +0000  (08:43 -0500)] 
 
Merge pull request #48550 from rkachach/fix_issue_57894 
 
mgr/cephadm: moving Prometheus spec check to service_spec module 
 
Reviewed-by: Adam King <adking@redhat.com>  
Lucian Petrut  [Mon, 12 Dec 2022 10:44:48 +0000  (12:44 +0200)] 
 
Merge pull request #49277 from petrutlucian94/fix_log_win32 
 
log: fix stderr handling on Windows 
 
Cory Snyder  [Wed, 2 Nov 2022 20:06:23 +0000  (20:06 +0000)] 
 
rgw: add 'inline_data' zone placement info option 
 
Adds a new RGW zone placement info option to control whether 
an object's first data chunk is placed in the head object. 
This allows admins to make a tradeoff between optimizing for 
PUT/GET performance vs. DELETE performance for some cluster 
configurations. 
 
Fixes: https://tracker.ceph.com/issues/57965  
Signed-off-by: Cory Snyder <csnyder@iland.com>  
Yingxin  [Mon, 12 Dec 2022 07:43:12 +0000  (15:43 +0800)] 
 
Merge pull request #49325 from liu-chunmei/crimson-reactor_utilization 
 
crimson/osd: dump each shard seastar metrics 
 
Reviewed-by: Samuel Just <sjust@redhat.com>  
Reviewed-by: Kefu Chai <tchaikov@gmail.com>  
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>  
colemitchell  [Mon, 12 Dec 2022 04:32:46 +0000  (23:32 -0500)] 
 
Merge pull request #49383 from zdover23/wip-doc-2022-12-12-rados-user-management-prompts 
 
doc/rados: add prompts to user-management.rst 
 
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>  
Zac Dover  [Mon, 12 Dec 2022 04:22:40 +0000  (14:22 +1000)] 
 
doc/rados: add prompts to user-management.rst 
 
Add unselectable prompts to doc/rados/operations/user-management.rst. 
 
https://tracker.ceph.com/issues/57108 
 
Signed-off-by: Zac Dover <zac.dover@gmail.com>  
Ronen Friedman  [Sun, 11 Dec 2022 17:05:34 +0000  (19:05 +0200)] 
 
Merge pull request #48545 from ronen-fr/wip-rf-slow-replica 
 
osd/scrub: report replicas slow to respond to scrub requests 
 
Reviewed-by: Matan Breizman <mbreizma@redhat.com>  
Reviewed-by: Laura Flores <lflores@redhat.com>  
Ronen Friedman  [Thu, 8 Dec 2022 17:58:19 +0000  (19:58 +0200)] 
 
osd/scrub: modifying some tests to ignore late replicas 
 
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>  
Ronen Friedman  [Mon, 24 Oct 2022 13:35:52 +0000  (16:35 +0300)] 
 
osd/scrub: earlier response to interval changes 
 
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>  
Ronen Friedman  [Mon, 24 Oct 2022 13:33:23 +0000  (16:33 +0300)] 
 
osd/scrub: minor logging changes 
 
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>  
Ronen Friedman  [Mon, 24 Jan 2022 13:19:01 +0000  (13:19 +0000)] 
 
osd/scrub: report replicas slow to repond to scrub requests 
 
Implemented timeouts: 
 
1: Slow-Secondary Warning: 
 
Once at least half of the replicas have accepted the reservation, we 
start reporting any secondary that takes too long (more than <conf> 
milliseconds after the previous response received) to respond to the reservation 
request. 
(Why? because we have encountered real-life situations where a specific 
OSD was systematically very slow to respond (e.g. 5 seconds in one case) to 
the reservation requests, slowing the scrub process to a crawl). 
 
2: Reservation Process Timeout: 
 
We now limit the total time the primary waits for the replicas to 
respond to the reservation request. If we do not get all the responses 
(either Grant or Reject) within <conf> milliseconds, we give up and release all the 
reservations we have acquired so far. 
(Why? because we have encountered instances where a reservation request 
was lost - either due to a bug or due to a network issue.) 
 
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>  
colemitchell  [Sat, 10 Dec 2022 21:31:53 +0000  (16:31 -0500)] 
 
Merge pull request #49376 from zdover23/wip-doc-2022-12-11-install-clone-source-fix-git-command 
 
doc/install: update clone-source.rst 
 
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>  
Zac Dover  [Sat, 10 Dec 2022 20:25:13 +0000  (06:25 +1000)] 
 
doc/install: update clone-source.rst 
 
Beef up clone-source.rst. Repair semantics. Add internal references. Fix 
a broken "git submodule foreach git clean -fdx" command. 
 
Signed-off-by: Zac Dover <zac.dover@gmail.com>  
Kefu Chai  [Sat, 10 Dec 2022 15:57:01 +0000  (23:57 +0800)] 
 
Merge pull request #49375 from adk3798/partial-revert-49359 
 
pybind/mgr: partial reversion of #49359 
 
Reviewed-by: Kefu Chai <tchaikov@gmail.com>  
colemitchell  [Sat, 10 Dec 2022 04:42:48 +0000  (23:42 -0500)] 
 
Merge pull request #49368 from zdover23/wip-doc-2022-12-10-rados-upmap-prompts 
 
doc/rados: add prompts to upmap.rst 
 
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>  
colemitchell  [Sat, 10 Dec 2022 04:42:12 +0000  (23:42 -0500)] 
 
Merge pull request #49367 from zdover23/wip-doc-2022-12-10-rados-stretch-mode-prompts 
 
doc/rados: add prompts to stretch-mode.rst 
 
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>  
Zac Dover  [Sat, 10 Dec 2022 04:34:46 +0000  (14:34 +1000)] 
 
doc/rados: add prompts to upmap.rst 
 
Add unselectable prompts to doc/rados/operations/upmap.rst. 
 
https://tracker.ceph.com/issues/57108 
 
Signed-off-by: Zac Dover <zac.dover@gmail.com>  
Zac Dover  [Sat, 10 Dec 2022 04:15:45 +0000  (14:15 +1000)] 
 
doc/rados: add prompts to stretch-mode.rst 
 
Add unselectable prompts to doc/rados/operations/stretch-mode.rst. 
 
https://tracker.ceph.com/issues/57108 
 
Signed-off-by: Zac Dover <zac.dover@gmail.com>  
Kefu Chai  [Sat, 10 Dec 2022 02:31:21 +0000  (10:31 +0800)] 
 
rgw: drop rgw_obj_key::to_str() 
 
rgw_obj_key::to_str() is mainly used by operator<<(ostream&, ..), so 
we can just implement it with the specialization of 
fmt::formatter<rgw_obj_key>. and let operator<<(ostream&, ..) to 
call into fmt::format(..): 
 
1. for better readability and 
2. for probably better performance -- we don't need to do deep copy 
   for constructing a `std::string` from a `char[]`. 
3. for better standard compliance -- we don't need to use variable-length 
   array in C++ code. it is a part of C99 standard. but not a C++ standard. 
 
Signed-off-by: Kefu Chai <tchaikov@gmail.com>  
Kefu Chai  [Sat, 10 Dec 2022 03:38:49 +0000  (11:38 +0800)] 
 
cmake: link rgw_common against fmt::fmt 
 
as it includes rgw_data_sync.h which in turn uses fmtlib. 
 
Signed-off-by: Kefu Chai <tchaikov@gmail.com>  
colemitchell  [Sat, 10 Dec 2022 03:31:57 +0000  (22:31 -0500)] 
 
Merge pull request #49364 from zdover23/wip-doc-2022-12-10-rbd-rados-rbd-retrieving-image-information-typo 
 
doc/rbd: remove typo and ill-formed command 
 
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>  
Zac Dover  [Sat, 10 Dec 2022 03:20:17 +0000  (13:20 +1000)] 
 
doc/rbd: remove typo and ill-formed command 
 
Ingest Ilya Dryomov's comments here https://github.com/ceph/ceph/pull/49340/files#r1044365857 
 
Signed-off-by: Zac Dover <zac.dover@gmail.com>  
Kefu Chai  [Thu, 8 Dec 2022 04:38:07 +0000  (12:38 +0800)] 
 
rgw: define FMT_HEADER_ONLY using CMakeLists.txt 
 
less repeatings this way. and the macro definition can be populated 
to the targets linking against `rgw_common`. this is more maintainable, 
as rgw executables and libraries always link against `rgw_common`. 
 
Signed-off-by: Kefu Chai <tchaikov@gmail.com>  
Kefu Chai  [Fri, 2 Dec 2022 06:10:02 +0000  (14:10 +0800)] 
 
fmt: pickup v9.1.0 
 
fmt 9.0.0 dropped automatic `std::ostream` insertion operator discovery 
when `fmt/ostream.h` to prevent ODR violations. instead of defining 
`FMT_DEPRECATED_OSTREAM`, we took efforts to specialize 
`fmt::formatter<..>` to be compatible with the new fmtlib. to avoid 
breaking the build with fmt v9 and up, let's bump up the fmt submodule. 
 
Signed-off-by: Kefu Chai <tchaikov@gmail.com>  
Kefu Chai  [Fri, 2 Dec 2022 09:25:24 +0000  (17:25 +0800)] 
 
rgw: pass fmt::format_string to pretty_print() 
 
otherwise we'd have following compiling failure: 
 
In file included from /var/ssd/ceph/src/rgw/store/rados/rgw_data_sync.cc:13: 
/var/ssd/ceph/src/rgw/store/rados/rgw_data_sync.h:345:28: error: call to consteval function 'fmt::basic_format_string<char, std::basic_string<char> &, rgw_obj_key &, unsigned long &, std::basic_string<char> &>::basic_format_string<char[59], 0>' is not a constant expressio 
n 
    fmt::print(*env->ostr, std::forward<T>(t)...); 
                           ^ 
/var/ssd/ceph/src/rgw/store/rados/rgw_data_sync.cc:4136:8: note: in instantiation of function template specialization 'pretty_print<const char (&)[59], std::basic_string<char> &, rgw_obj_key &, unsigned long &, std::basic_string<char> &>' requested here 
              pretty_print(sc->env, "Syncing object s3://{}/{} version {} in sync from zone {}\n", 
              ^ 
/var/ssd/ceph/src/rgw/store/rados/rgw_data_sync.cc:4070:3: note: in instantiation of member function 'RGWBucketSyncSingleEntryCR<rgw_obj_key, rgw_obj_key>::operate' requested here 
  RGWBucketSyncSingleEntryCR(RGWDataSyncCtx *_sc, 
  ^ 
/var/ssd/ceph/src/rgw/store/rados/rgw_data_sync.cc:4352:27: note: in instantiation of member function 'RGWBucketSyncSingleEntryCR<rgw_obj_key, rgw_obj_key>::RGWBucketSyncSingleEntryCR' requested here 
          yield spawn(new SyncCR(sc, sync_pipe, entry->key, 
                          ^ 
/var/ssd/ceph/src/rgw/store/rados/rgw_data_sync.h:345:44: note: function parameter 't' with unknown value cannot be used in a constant expression 
    fmt::print(*env->ostr, std::forward<T>(t)...); 
                                           ^ 
/var/ssd/ceph/src/rgw/store/rados/rgw_data_sync.h:343:53: note: declared here 
void pretty_print(const RGWDataSyncEnv* env, T&& ...t) { 
                                                    ^ 
 
Signed-off-by: Kefu Chai <tchaikov@gmail.com>  
Kefu Chai  [Fri, 2 Dec 2022 09:23:23 +0000  (17:23 +0800)] 
 
rgw: specialize fmt::formatter<> for rgw_obj_key 
 
since fmt v9, fmt::formatter<> is not specialized for the types with 
operator<<(ostream&, ...) anymore. so we need to specialize it manually. 
in this change, fmt::formatter<rgw_obj_key> is defined so the tree can 
compile with fmt v9. 
 
Signed-off-by: Kefu Chai <tchaikov@gmail.com>  
Kefu Chai  [Fri, 2 Dec 2022 11:05:25 +0000  (19:05 +0800)] 
 
rgw/rgw_common: define FMT_HEADER_ONLY 
 
to be consistent with other parts of rgw 
 
Signed-off-by: Kefu Chai <tchaikov@gmail.com>  
Adam King  [Fri, 9 Dec 2022 19:20:47 +0000  (14:20 -0500)] 
 
pybind/mgr: partial reversion of #49359 
 
When creating #49359 I was testing on an outdated 
branch and didn't realize part of what I was fixing 
had already been fixed in #49321. Basically ended up 
changing what a variable "mypy_args" is set to but that 
variable is no longer being used. It has no actual effect 
but we should remove the extraneous code. 
 
Signed-off-by: Adam King <adking@redhat.com>  
Adam King  [Fri, 9 Dec 2022 18:19:10 +0000  (13:19 -0500)] 
 
Merge pull request #49359 from adk3798/mypy-args 
 
 mgr/pybind: fix mypy and autopep8 arg parsing 
 
Reviewed-by: Laura Flores <lflores@redhat.com>  
Casey Bodley  [Fri, 9 Dec 2022 17:56:28 +0000  (12:56 -0500)] 
 
Merge pull request #48626 from qiuxinyidian/rgw-coroutine 
 
rgw: modify multisite coroutine stack block 
 
Reviewed-by: Casey Bodley <cbodley@redhat.com>  
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>  
Casey Bodley  [Fri, 9 Dec 2022 17:55:21 +0000  (12:55 -0500)] 
 
Merge pull request #48559 from baergj/fix-listbuckets-truncation-main 
 
rgw: Fix truncated ListBuckets response. 
 
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>  
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>  
Casey Bodley  [Fri, 9 Dec 2022 17:54:13 +0000  (12:54 -0500)] 
 
Merge pull request #48554 from giubacc/rgw_dns_name_multivalue 
 
rgw: add multivalue support to rgw_dns_name config option 
 
Reviewed-by: Casey Bodley <cbodley@redhat.com>  
Casey Bodley  [Fri, 9 Dec 2022 17:52:32 +0000  (12:52 -0500)] 
 
Merge pull request #48390 from cbodley/wip-57784 
 
rgw: beast frontend checks for local_endpoint() errors 
 
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>  
Casey Bodley  [Fri, 9 Dec 2022 17:52:07 +0000  (12:52 -0500)] 
 
Merge pull request #45818 from cbodley/wip-system-rapidjson 
 
cmake: use rapidjson headers from s3select's submodule 
 
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>  
Reviewed-by: Kefu Chai <tchaikov@gmail.com>  
Daniel Gryniewicz  [Fri, 9 Dec 2022 17:41:13 +0000  (12:41 -0500)] 
 
Merge pull request #49336 from dang/wip-dang-zipper-driver 
 
Store -> Driver rename + header cleanup 
 
Reviewed-by: Casey Bodley <cbodley@redhat.com>  
Adam King  [Fri, 9 Dec 2022 16:25:01 +0000  (11:25 -0500)] 
 
pybind/mgr: fix tox autopep8 args 
 
Similar to mypy, we now need a backslash to signal 
a newline doesn't mean to start a new command 
 
Signed-off-by: Adam King <adking@redhat.com>  
Adam King  [Fri, 9 Dec 2022 16:10:36 +0000  (11:10 -0500)] 
 
mgr/pybind: fix mypy arg parsing 
 
On the new tox version it is treating each line as a new command 
so it will do something like "mypy --config-file=../../mypy.ini" 
as one command and then "-m balancer" as a totally separate command. 
The first one immediately fails as it doesn't include any modules 
to test. Adding backslashes to the ends of the lines gets it to 
handle the lines as one long command 
 
Signed-off-by: Adam King <adking@redhat.com>  
Yingxin  [Fri, 9 Dec 2022 10:01:52 +0000  (18:01 +0800)] 
 
Merge pull request #48691 from zhscn/wip-reserve 
 
crimson/os/seastore: correct the behavior of reserving space 
 
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>  
Reviewed-by: Kefu Chai <tchaikov@gmail.com>  
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>  
Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>  
Pere Diaz Bou  [Fri, 9 Dec 2022 08:34:06 +0000  (09:34 +0100)] 
 
Merge pull request #47842 from trociny/wip-rbd-rest-api-metadata 
 
mgr/dashboard: allow to get/update RBD image metadata via REST API 
 
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>  
colemitchell  [Fri, 9 Dec 2022 06:45:28 +0000  (01:45  -0500)] 
 
Merge pull request #49342 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-removing-a-block-device-semantics 
 
doc/rbd: refine "Removing a Block Device Image" 
 
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>  
Zac Dover  [Fri, 9 Dec 2022 01:16:27 +0000  (11:16 +1000)] 
 
doc/rbd: refine "Removing a Block Device Image" 
 
Refine and add unselectable prompts to "Removing a Block Device Image" 
in doc/rbd/rados-rbd-cmds. 
 
https://tracker.ceph.com/issues/57001 
 
Signed-off-by: Zac Dover <zac.dover@gmail.com>  
colemitchell  [Fri, 9 Dec 2022 06:17:17 +0000  (01:17  -0500)] 
 
Merge pull request #49341 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-resizing-a-block-device-image-semantics 
 
doc/rbd: refine "Resizing a Block Device Image" 
 
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>  
colemitchell  [Fri, 9 Dec 2022 06:16:43 +0000  (01:16  -0500)] 
 
Merge pull request #49343 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-restoring-a-block-device-image-semantics 
 
doc/rbd: refine "Restoring a Block Device Image" 
 
Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>  
Zac Dover  [Fri, 9 Dec 2022 01:31:07 +0000  (11:31 +1000)] 
 
doc/rbd: refine "Restoring a Block Device Image" 
 
Refine and add unselectable prompts to "Restoring a Block Device Image" 
in doc/rbd/rados-rbd-cmds.rst. 
 
https://tracker.ceph.com/issues/57001 
 
Signed-off-by: Zac Dover <zac.dover@gmail.com>  
Zac Dover  [Fri, 9 Dec 2022 01:02:31 +0000  (11:02 +1000)] 
 
doc/rbd: refine "Resizing a Block Device Image" 
 
Refine and add unselectable prompts to "Resizing a Block Device Image" 
in doc/rbd/rados/rbd-cmds.rst. 
 
https://tracker.ceph.com/issues/57001 
 
Signed-off-by: Zac Dover <zac.dover@gmail.com>  
colemitchell  [Fri, 9 Dec 2022 04:50:23 +0000  (23:50 -0500)] 
 
Merge pull request #49338 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-creating-a-block-device-image-semantics 
 
doc/rbd: refine "Creating a Block Device Image" 
 
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>  
colemitchell  [Fri, 9 Dec 2022 04:50:07 +0000  (23:50 -0500)] 
 
Merge pull request #49340 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-retrieving-image-information-semantics 
 
doc/rbd: refine "Retrieving Image Information" 
 
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>  
colemitchell  [Fri, 9 Dec 2022 02:50:05 +0000  (21:50 -0500)] 
 
Merge pull request #49339 from zdover23/wip-doc-2022-12-09-rbd-rados-rbd-cmds-listing-block-device-images-semantics 
 
doc/rbd: refine "Listing Block Device Images" 
 
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>  
Zac Dover  [Fri, 9 Dec 2022 00:25:55 +0000  (10:25 +1000)] 
 
doc/rbd: refine "Retrieving Image Information" 
 
Refine the text and prompts in "Retrieving Image Information" in 
doc/rbd/rados-rbd-cmds.rst. 
 
https://tracker.ceph.com/issues/57001 
 
Signed-off-by: Zac Dover <zac.dover@gmail.com>  
Kefu Chai  [Fri, 9 Dec 2022 00:31:05 +0000  (08:31 +0800)] 
 
Merge pull request #49321 from tchaikov/wip-qa-install-with-utf-8 
 
qa: set locale to C.UTF-8 in tox.ini 
 
Reviewed-by: John Mulligan <jmulligan@redhat.com>  
Reviewed-by: Adam King <adking@redhat.com>  
chunmei-liu  [Thu, 8 Dec 2022 07:48:33 +0000  (23:48 -0800)] 
 
crimson/osd: dump each shard seastar metrics 
 
Signed-off-by: chunmei-liu <chunmei.liu@intel.com>  
Signed-off-by: Samuel Just <sjust@redhat.com>  
Zac Dover  [Fri, 9 Dec 2022 00:21:47 +0000  (10:21 +1000)] 
 
doc/rbd: refine "Listing Block Device Images" 
 
Refine the text and prompts in "Listing Block Device Images" in 
doc/rbd/rados-rbd-cmds.rst. 
 
https://tracker.ceph.com/issues/57001 
 
Signed-off-by: Zac Dover <zac.dover@gmail.com>  
Zac Dover  [Thu, 8 Dec 2022 23:53:14 +0000  (09:53 +1000)] 
 
doc/rbd: refine "Creating a Block Device Image" 
 
Refine the English and prompts in "Creating a Block Device Image" in 
doc/rbd/rados-rbd-cmds.rst. 
 
https://tracker.ceph.com/issues/57001 
 
Signed-off-by: Zac Dover <zac.dover@gmail.com>  
Matt Benjamin  [Sat, 19 Sep 2020 00:59:31 +0000  (20:59 -0400)] 
 
rgw: define a hierarchy of basic type headers 
 
Defines a hierarchy of "simple" data types ensured to be 
safe to include in any context above the zipper line, and 
also from CLS. 
 
The following headers are currently defined to contain basic 
types only: 
 
 rewrite src/rgw/rgw_basic_types.h (70%) // includes the whole hierarchy 
 create mode 100644 src/rgw/rgw_acl_types.h 
 create mode 100644 src/rgw/rgw_bucket_types.h 
 create mode 100644 src/rgw/rgw_obj_types.h 
 create mode 100644 src/rgw/rgw_placement_types.h 
 create mode 100644 src/rgw/rgw_pool_types.h 
 create mode 100644 src/rgw/rgw_quota_types.h 
 create mode 100644 src/rgw/rgw_user_types.h 
 create mode 100644 src/rgw/rgw_zone_types.h 
 
This commit consolidates the following original commits: 
 
* rgw: move RGWUploadPartInfo to rgw_basic_types.{h,cc} 
* rgw: move rgw_obj_key to rgw_basic_types.{h,cc} 
* rgw: move rgw_placement_rule to rgw_basic_types.{h,cc} 
* rgw: move rgw_obj to rgw_basic_types.{h,cc} 
* rgw: include rgw_compression_types.h in rgw_basic_types.{h,cc} 
* rgw: move rgw_raw_obj to rgw_basic_types.{h,cc} 
* rgw: rgw_multi.h: remove unused RGWMPObj forward decl 
 
and the following cleanups from review: 
 
* rgw: remove stray comments 
* rgw: move rgw_obj_manifest.h inclusion to top of rgw_basic_types.h 
* rgw: nit: indentation 
* rgw: remove this line 
* rgw: move rgw_bucket_shard to rgw_bucket_types.h, cleanup 
* rgw: fix rgw_quota.h 
 
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>  
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>  
Matt Benjamin  [Sat, 19 Sep 2020 00:17:46 +0000  (20:17 -0400)] 
 
rgw: setup for inclusion of rgw_basic_types in rgw cls 
 
In downstream 4.1 version this change moved rgw_pool, rgw_bucket, 
and some related types--but these have already moved on more 
recent branches. 
 
Include rgw_basic_types.h only from cls_rgw_types.h (review). 
 
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>  
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>  
Daniel Gryniewicz  [Fri, 2 Dec 2022 16:34:44 +0000  (11:34 -0500)] 
 
RGW - Zipper - move rgw/store to rgw/driver 
 
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>  
Daniel Gryniewicz  [Tue, 29 Nov 2022 17:31:01 +0000  (12:31 -0500)] 
 
RGW - Zipper - Rename rgw::sal::Store to rgw::sal::Driver 
 
All along, we've had an overload of the term "store".  It was the base 
class of the entrypoint, and it was the lowest layer in a stack.  This 
renames the base class to Driver.  So, the primary elements of zipper 
that to work are now Drivers, and they come in two different flavors: 
Filters live in the middle of the stack, and do not need to implement 
every API, but pass through instead.  And Stores live a the bottom of 
the stack, and must implement the entire API. 
 
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>  
Kefu Chai  [Thu, 8 Dec 2022 16:49:37 +0000  (00:49  +0800)] 
 
pybind/mgr: do not test with py37
as we always test with ubuntu jammy, which does not provide python3.7:
py37: skipped because could not find python interpreter with spec(s): py37
so there is no point testing with python3.7.
also, in tox v4, it is not able to handle "key = value" anymore, where
value has newlines in it. so we need to find a better way passing
command line options to the test command.
this change partially reverts 
2dd86c9e3eca6e14a04a821edf3a654f31da7a21 
Signed-off-by: Kefu Chai <tchaikov@gmail.com> 
 
Kefu Chai  [Thu, 8 Dec 2022 16:32:26 +0000  (00:32  +0800)] 
 
cmake: temporarily disable py3 test
py3 tries to import all python modules to ensure that they are
python3 compatible. but the installation fails on jenkins test node:
  Resolved https://github.com/ceph/teuthology.git to commit 
4da97cf64e542f347ec47b7bdbe5eca99759f9b7 
  Installing build dependencies: started
  error: subprocess-exited-with-error
Signed-off-by: Kefu Chai <tchaikov@gmail.com> 
 
Yuri Weinstein  [Thu, 8 Dec 2022 16:49:17 +0000  (08:49 -0800)] 
 
Merge pull request #48375 from lbausch/mgr/balancer-fix_end_weekday_being_exclusive 
 
mgr/balancer: Fix `end_weekday` being exclusive 
 
Reviewed-by: Laura Flores <lflores@redhat.com>  
Yuri Weinstein  [Thu, 8 Dec 2022 16:48:23 +0000  (08:48 -0800)] 
 
Merge pull request #48318 from gregsfortytwo/wip-17170 
 
osd: mds: suggest clock skew when failing to obtain rotating service keys 
 
Reviewed-by: Venky Shankar <vshankar@redhat.com>  
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>  
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>  
Reviewed-by: Ramana Raja <rraja@redhat.com>  
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>  
Kefu Chai  [Thu, 8 Dec 2022 14:34:38 +0000  (22:34 +0800)] 
 
qa: add pytest to deps of py3 env 
 
otherwise it is mising when running test, and we'd have following 
failure: 
 
py3: exit 2 (0.00 seconds) /home/jenkins-build/build/workspace/ceph-pull-requests/qa> pytest --assert=plain test_import.py 
 
Signed-off-by: Kefu Chai <tchaikov@gmail.com>  
Kefu Chai  [Thu, 8 Dec 2022 06:42:42 +0000  (14:42 +0800)] 
 
qa: set locale to C.UTF-8 in tox.ini 
 
as ansible is using UTF-8 encoded characters in the file names, so, 
to avoid failures like: 
 
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/qa/.tox/py3/lib/python3.10/site-packages/pip/_internal/utils/unpacking.py", line 217, in untar_file 
    with open(path, "wb") as destfp: 
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 137-140: ordinal not in range(256) 
 
we have to set a locale which is able to handle UTF-8. 
 
see also https://github.com/ceph/teuthology/pull/1671 
 
Signed-off-by: Kefu Chai <tchaikov@gmail.com>  
Casey Bodley  [Thu, 8 Dec 2022 14:24:22 +0000  (09:24 -0500)] 
 
Merge pull request #49236 from yuvalif/wip-yuval-missing-init 
 
rgw/notification: initialize member in reservation ctor 
 
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>  
Casey Bodley  [Thu, 8 Dec 2022 14:04:25 +0000  (09:04 -0500)] 
 
Merge pull request #49290 from inspur-wyq/wip-rgw-svc-doc 
 
src/rgw/services/svc_finisher.cc: fix typos 
 
Reviewed-by: Casey Bodley <cbodley@redhat.com>  
Kefu Chai  [Thu, 8 Dec 2022 13:33:38 +0000  (21:33 +0800)] 
 
Merge pull request #49322 from tchaikov/wip-allowlist_externals 
 
*: s/whitelist_externals/allowlist_externals/ 
 
Reviewed-by: Adam King <adking@redhat.com>  
Avan Thakkar  [Thu, 8 Dec 2022 11:16:21 +0000  (16:46 +0530)] 
 
mgr/dashboard: allow Origin for CORS if present in config `cross_origin_url` 
 
Signed-off-by: Avan Thakkar <athakkar@redhat.com>  
Kefu Chai  [Thu, 8 Dec 2022 10:25:20 +0000  (18:25 +0800)] 
 
pybind/mgr: drop cython from requires 
 
cython is not required for running tox commands. 
 
this should address the test failure like: 
 
ROOT: will run in automatically provisioned tox, host /home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-virtualenv/bin/python3.10 is missing [requires (has)]: cython 
 
Signed-off-by: Kefu Chai <tchaikov@gmail.com>