Cleanup of ThreadStatusUtil structures should use the DB's reference
Summary:
instead of thread_local
The cleanup path for the rocksdb database might not have the
thread_updater_local_cache_ pointer initialized because the thread
executing the cleanup is likely not a rocksdb thread. This results in a
memory leak detected by Valgrind. The cleanup code path should use the
thread_status_updater pointer obtained from the DB object instead of a
thread local one.
Closes https://github.com/facebook/rocksdb/pull/2059
Differential Revision:
D4801611
Pulled By: hermanlee
fbshipit-source-id:
407d7de
Support SstFileManager::SetDeleteRateBytesPerSecond()
Summary:
Update DeleteScheduler component to support changing delete rate in runtime by introducing
SstFileManager::SetDeleteRateBytesPerSecond()
Closes https://github.com/facebook/rocksdb/pull/1994
Differential Revision:
D4719906
Pulled By: IslamAbdelRahman
fbshipit-source-id:
e6b8d9e
Added SstFileWriter construtor without explicit comparator to JNI api
Summary:
Adding API missing after https://github.com/facebook/rocksdb/commit/
1ffbdfd9a7637b6517053842386d71df2cd00d9b#diff-
b94146418eed4a9c1bf324041b95b279.
adamretter IslamAbdelRahman
Tested locally.
Closes https://github.com/facebook/rocksdb/pull/2028
Differential Revision:
D4762817
Pulled By: IslamAbdelRahman
fbshipit-source-id:
833f478
update history.md for fixing the bug that skips keys
Summary: Closes https://github.com/facebook/rocksdb/pull/1986
Differential Revision:
D4699152
Pulled By: siying
fbshipit-source-id:
b18c32c
delete fallocate with punch_hole
Summary:
As discuss in this thread:
https://www.facebook.com/groups/rocksdb.dev/permalink/
1218043868294125/
We remove fallocate with FALLOC_FL_PUNCH_HOLE because the recent bug on xfs in kernel 4.x+ that align file size to page size even with FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE.
Closes https://github.com/facebook/rocksdb/pull/2038
Differential Revision:
D4779974
Pulled By: siying
fbshipit-source-id:
5f54625
Expose the stalling information through DB::GetProperty()
Summary:
Add two DB properties: rocksdb.actual_delayed_write_rate and rocksdb.is_write_stooped, for people to know whether current writes are being throttled.
Closes https://github.com/facebook/rocksdb/pull/2043
Differential Revision:
D4782975
Pulled By: siying
fbshipit-source-id:
6b2f5cf