]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/log
rocksdb.git
12 years ago1.5.8.1.fb release. 1.5.8.1.fb v1.5.8.1
Dhruba Borthakur [Wed, 20 Mar 2013 21:16:53 +0000 (14:16 -0700)]
1.5.8.1.fb release.

Summary:

Test Plan:

Reviewers:

CC:

Task ID: #

Blame Rev:

12 years agoRemoving boost from ldb_cmd.cc
Mayank Agarwal [Wed, 20 Mar 2013 00:28:30 +0000 (17:28 -0700)]
Removing boost from ldb_cmd.cc

Summary: Getting rid of boost in our github codebase which caused problems on third-party

Test Plan: make ldb; python tools/ldb_test.py

Reviewers: sheki, dhruba

Reviewed By: sheki

Differential Revision: https://reviews.facebook.net/D9543

12 years agoUsing return value of fwrite in posix_logger.h
Mayank Agarwal [Fri, 15 Mar 2013 01:12:22 +0000 (18:12 -0700)]
Using return value of fwrite in posix_logger.h

Summary: Was causing error(warning) in third-party saying unused result

Test Plan: make

Reviewers: sheki, dhruba

Reviewed By: dhruba

Differential Revision: https://reviews.facebook.net/D9447

12 years agoFix more signed-unsigned comparisons
Mayank Agarwal [Tue, 19 Mar 2013 21:53:22 +0000 (14:53 -0700)]
Fix more signed-unsigned comparisons

Summary: Some comparisons left in log_test.cc and db_test.cc complained by make

Test Plan: make

Reviewers: dhruba, sheki

Reviewed By: dhruba

Differential Revision: https://reviews.facebook.net/D9537

12 years agoFixed sign-comparison in rocksdb code-base and fixed Makefile
Mayank Agarwal [Fri, 15 Mar 2013 01:32:01 +0000 (18:32 -0700)]
Fixed sign-comparison in rocksdb code-base and fixed Makefile

Summary: Makefile had options to ignore sign-comparisons and unused-parameters, which should be there. Also fixed the specific errors in the code-base

Test Plan: make

Reviewers: chip, dhruba

Reviewed By: dhruba

CC: leveldb
Differential Revision: https://reviews.facebook.net/D9531

12 years agoadd --benchmarks=levelstats option to db_bench, prevent "nan" in stats output
Mark Callaghan [Tue, 19 Mar 2013 13:36:03 +0000 (06:36 -0700)]
add --benchmarks=levelstats option to db_bench, prevent "nan" in stats output

Summary:
Add --benchmarks=levelstats option to report per-level stats (#files, #bytes)
Change readwhilewriting test to report response time for writes but exclude
them from the stats merged by all threads.
Prevent "NaN" in stats output by preventing division by 0.
Remove "o" file I committed by mistake.

Task ID: #

Blame Rev:

Test Plan:
make check

Revert Plan:

Database Impact:

Memcache Impact:

Other Notes:

EImportant:

- begin *PUBLIC* platform impact section -
Bugzilla: #
- end platform impact -

Reviewers: dhruba

Reviewed By: dhruba

Differential Revision: https://reviews.facebook.net/D9513

12 years agoIgnore a zero-sized file while looking for a seq-no in GetUpdatesSince
Abhishek Kona [Mon, 18 Mar 2013 21:50:59 +0000 (14:50 -0700)]
Ignore a zero-sized file while looking for a seq-no in GetUpdatesSince

Summary:
Rocksdb can create 0 sized log files when it is opened and closed without any operations.
The GetUpdatesSince fails currently if there is a log file of size zero.

This diff fixes this. If there is a log file is 0, it is removed form the probable_file_list

Test Plan: unit test

Reviewers: dhruba, heyongqiang

Reviewed By: heyongqiang

CC: leveldb
Differential Revision: https://reviews.facebook.net/D9507

12 years agoDO not report level size as zero when there are no files in L0
Abhishek Kona [Mon, 18 Mar 2013 19:04:38 +0000 (12:04 -0700)]
DO not report level size as zero when there are no files in L0

Summary:
Instead of checking for number of files in L0. Check for number of files in the requested level.

Bug introduced in D4929 (diff trying to do too many things).

Test Plan: db_test.

Reviewers: dhruba, MarkCallaghan

Reviewed By: dhruba

Differential Revision: https://reviews.facebook.net/D9483

12 years agoFixing a careless mistake in ldb
Mayank Agarwal [Fri, 15 Mar 2013 17:57:08 +0000 (10:57 -0700)]
Fixing a careless mistake in ldb

Summary: negation of the condition checked currently had to be checkd actually

Test Plan: make ldb; python ldb_test.py

Reviewers: sheki, dhruba

Reviewed By: sheki

Differential Revision: https://reviews.facebook.net/D9459

12 years agoDoing away with boost in ldb_cmd.h
Mayank Agarwal [Fri, 15 Mar 2013 00:56:38 +0000 (17:56 -0700)]
Doing away with boost in ldb_cmd.h

Summary: boost functions cause complications while deploying to third-party

Test Plan: make

Reviewers: sheki, dhruba

Reviewed By: sheki

Differential Revision: https://reviews.facebook.net/D9441