Merge pull request #59482 from rhcs-dashboard/nvmeof-api-group-support

mgr/dashboard: add gw_groups support to nvmeof api

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: caroav <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #59576 from rhcs-dashboard/hosts-selection-show-only-10-entries-fix

mgr/dashboard: service form hosts selection only show up to 10 entries

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #59738 from gbregman/main

Make the discovery and gateway IPs configurable in NVMEof configuration

Merge pull request #59681 from adk3798/cephadm-enable-module-bootstrap-retry

cephadm: bootstrap: verify orch module is running before setting cephadm backend

Reviewed-by: John Mulligan <jmulligan@redhat.com>

mgr/cephadm: Make the discovery and gateway IPs configurable in NVMEof configuration
Fixes https://tracker.ceph.com/issues/68030

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>

python-common/ceph/deployment: Make the discovery and gateway IPs configurable in NVMEof configuration
Fixes https://tracker.ceph.com/issues/68030

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>

Merge pull request #59635 from zdover23/wip-doc-2024-09-06-rados-ops-health-checks

doc/rados: add "pgs not deep scrubbed in time" info

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

mgr/dashboard: expose gw_groups list api

also if the cephadm is available, make the api smart enough to
understand the running daemons and get its gateway_addr instead of
taking the first one in the list so that the HA will be there for the UI
and API as well

Fixes: https://tracker.ceph.com/issues/67774
Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: add gw_groups support to nvmeof api

Introduces a gw_group query-param to gateway and subsystem requests.

Modified the dashboard config to support adding more than one gateway to
the list.

Fixes: https://tracker.ceph.com/issues/67774
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #59066 from xxhdx1985126/wip-67380

crimson/osd: cancel ongoing pglog-based recoveries on recovery defering

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #59485 from mcv21/cephadm_image_warn

cephadm: emit warning if daemon's image is not to be used

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #59599 from rhcs-dashboard/fix-67893-main

mgr/dashboard: Rephrase dedicated pool helper in rbd create form

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge pull request #59447 from afreen23/wip-nvmeof-microcopy

mgr/dashboard: Update nvmeof microcopies

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge pull request #59569 from afreen23/wip-nvme-ns

mgr/dashboard: Increase maximum namespace count to 1024

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge pull request #56858 from rhcs-dashboard/fix-grafana-server-depreciation

mgr/dashboard: use grafana server instead of grafana-server in grafana 10.4.0

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@ibm.com>

Merge pull request #59610 from adk3798/cephadm-ssh-configurable-keepalive

mgr/cephadm: make ssh keepalive settings configurable

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #59643 from rkachach/fix_issue_67939

mgr/cephadm: changing the nginx upstream image used by mgmt-gateway

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #59658 from phlogistonjohn/jjm-remove-object-deleting-func

mgr/smb: stop trying to clean external store during cluster sync

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anoop C S <anoopcs@cryptolab.net>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #58994 from phlogistonjohn/jjm-smb-vfs-ceph-new

mgr/smb: add support for new ceph vfs module

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anoop C S <anoopcs@cryptolab.net>

Merge pull request #58880 from aclamk/wip-aclamk-bs-faster-objectstore-test

test/store_test: Make ceph_test_objectstore run faster

Merge pull request #59107 from nbalacha/wip-nbalacha-async-sorted-snaps

librbd: make "group snap list" async and optionally sorted by snap creation time

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #59675 from zdover23/wip-doc-2024-09-10-README-md-vstart

doc/README.md: improve formatting

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #58986 from NitzanMordhai/wip-nitzan-crimson-op_gate-alianstore-multi-core

crimson: use gate per shard for AlienStore and OSD

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #58868 from xxhdx1985126/wip-crimson-clean_region-based-clone-recovery

crimson/osd/pg: properly propagate snap mapper updates and do clean-region-based clone objects recovery

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

mgr/dashboard: service form hosts selection only show up to 10 entries

exposed new UIRouter API to get all hosts

Fixes: https://tracker.ceph.com/issues/67413
Signed-off-by: Naman Munet <nmunet@redhat.com>

Merge pull request #59677 from zdover23/wip-doc-2024-09-10-man-ceph-bluestore-tool

doc/man: edit ceph-bluestore-tool.rst

cephadm: bootstrap: verify orch module is running before setting cephadm backend

There have been occasional failures when bootstrapping with error
messages like

```
Module 'orchestrator' is not enabled/loaded (required by command 'orch set backend'): use `ceph mgr module enable orchestrator` to enable it
```

despite the orchestrator being meant to be an always on module.

Since trying to enable an already enabled module causes no issues,
trying to enable it ourselves seems like a sensible workaround.

Fixes: https://tracker.ceph.com/issues/67969
Signed-off-by: Adam King <adking@redhat.com>

doc/man: edit ceph-bluestore-tool.rst

Edit the section "bluefs-bdev-migrate" in
doc/man/8/ceph-bluestore-tool.rst to add the information that this
operation expands the target storage by updating its size label, making
"bluefs-bdev-expand" unnecessary.

Improve the subject-verb agreement in this section, and supply some
absent definite articles.

Co-authored-by: Peter Gervai <grin@drop.grin.hu>
Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #58603 from cbodley/wip-rgw-sal-concrete-lc

rgw/sal: LCHead and LCEntry don't need abstraction

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

doc/README.md: improve formatting

Improve the formatting of the section "Building Ceph" in the file
README.md.

Signed-off-by: Zac Dover <zac.dover@proton.me>

mgr/cephadm: changing the nginx upstream image used by mgmt-gateway

pointing mgmt-gateway nginx image to a different upstream repository

Fixes: https://tracker.ceph.com/issues/67939
Signed-off-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #59297 from ivoalmeida/carbon-datatable-performance

mgr/dashboard: datatable performance improvement

Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/smb: stop trying to clean external store during cluster sync

It was found during testing that a sequence of commands like:
```
ceph smb cluster create slow1 user --define-user-pass=user1%badf00d --clustering=always
--placement=3
sleep 0.5
ceph smb share create slow1 share1 cephfs --subvolume=g1/sv1 --path=/
sleep 0.5
ceph smb share create slow1 share2 cephfs --subvolume=g1/sv2 --path=/
```
would create a CTDB enabled cluster that would fail to start up
correctly. The issue was due to the call to `external.rm_other_in_ns`
during the cluster sync operation. In the CTDB enabled mode, objects are
written to the pool outside of the smb mgr module's direct control, in
particular `cluster.meta.json`, and this function, intended to keep the
pool & namespace tidy, was removing objects needed by CTDB-enabled mode.
The failure is somewhat timing sensitive due to the ctdb enablement
sidecars coming up before or after the object was deleted.

Remove this function call so that these objects stop getting deleted at
inopportune times. While we could have tried making this function
"smarter" and only deleting some unexpected objects, in this case I feel
that keeping it simple is better. If we find this pool getting cluttered
in the future we can add a smarter pool-tidying-up function later.

Fixes: https://tracker.ceph.com/issues/67946
Signed-off-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #58815 from synarete/samba-metrics-exporter

cephadm: samba metrics exporter

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #59534 from cbodley/wip-rgw-listing-max-entries

rgw: raise default rgw_max_listing_results=5000

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #57635 from clwluvw/trans-id

rgw: log x-amz-request-id along with the request

Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>

Merge pull request #58082 from jzhu116-bloomberg/wip-66516

rgw/multipart: use cls_version to avoid racing between part upload and multipart complete

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #59014 from liangmingyuanneo/wip-bugfix-beast-socket-accept

rgw/beast: optimize for accept when meeting error in listenning

Reviewed-by: Casey Bodley <cbodley@redhat.com>

crimson/osd/ops_executer: pass MutFunc by value

Since we now co_await mut_func, we should not pass it by rvalue ref.

```
DEBUG 2024-09-01 15:54:46,212 [shard 0:main] osd - do_osd_ops_execute: object 2:c4c92e5a:::rbd_trash:head submitting txn
=================================================================
==17416==ERROR: AddressSanitizer: stack-use-after-return on address 0x7f590008a430 at pc 0x0000040a367a bp 0x7ffc0b1d5ff0 sp 0x7ffc0b1d5fe0
Address 0x7f590008a430 is located in stack of thread T0 at offset 48 in frame
    #0 0x40b0a2b in crimson::osd::PG::do_osd_ops_execute ... lambda(std::error_code const&)#1}&&)::{lambda()#1}::operator()() const (/usr/bin/ceph-osd+0x40b0a2b)
```

Co-authored-by: Xuehan Xu <xuxuehan@qianxin.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/osd/ops_executer: avoid seastar::async comment

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/osd/osd_operations/snaptrim_event: make use of process_and_submit

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/osd/osd_operations/snaptrim_event: introduce process_and_submit

We should be carful with using capturing lambdas with coroutines.
Avoid capturing [this] by passing process_and_submit instead.

See: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rcoro-capture

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/osd/ops_executer: flush_changes_n_do_ops_effects to use
coroutines

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/osd/osd_operations/snaptrim_event: start to use coroutines

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/osd/pg: make use of SnapMapper::update_snap_map

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

mgr/dashboard: datatable performance improvement

Fixes: https://tracker.ceph.com/issues/67796:
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>

Merge pull request #59657 from eriksjolund/fix-sign-of-errno

tools/rbd_ggate: fix sign of errno

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #59000 from connorfawcett/rbd-random

rbd/bench: Add ability to write a random string of bytes or a specific byte with --pattern-byte option

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #59607 from yuvalif/wip-yuval-67658

rgw/notifications: free completion pointer using unique_ptr

Reviewed-By: Adam Emerson <aemerson@ibm.com>, Casey Bodley <cbodley@ibm.com>

Merge pull request #59642 from zdover23/wip-doc-2024-09-06-cephadm-upgrade

doc/cephadm: add malformed-JSON removal instructions

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #59553 from cyx1231st/wip-seastore-more-reports3

crimson/os/seastore/cache: report cache access stats

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

doc/cephadm: add malformed-JSON removal instructions

Add instructions for removing malformed JSON that causes the cephadm
module to fail to start, which in turn makes the orchestrator fail to
start.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #59590 from ronen-fr/wip-rf-delay-conf

osd/scrub: add configuration parameters to control delay duration

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

tools/rbd_ggate: fix sign of errno

Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>

Merge pull request #59628 from zdover23/wip-doc-2024-09-06-dev-release-checklist-rtd-activation

doc/dev: add "activate latest release" RTD step

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #59592 from leonidc/wip-leonidc0409-blocklist-fix

leonidc0409 blocklist fix

Merge pull request #44640 from effi-ofer/live-migration-nbd

librbd/migration: add NBD stream

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #57388 from mchangir/mgr-snap_schedule-correctly-fetch-mds_max_snaps_per_dir-from-mds

mgr/snap_schedule: correctly fetch mds_max_snaps_per_dir from mds

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #59579 from leonidc/wip-leonidc0309-gw-deleting-state

 gw deleting state

mgr/cephadm: stop running "true" before every command

It turns out this is completely unnecessary. With the keepalive
settings on the connection, we no longer need to run an
additional command with a timeout on it to quickly detect a
host is offline

Signed-off-by: Adam King <adking@redhat.com>

Merge pull request #44359 from mchangir/mds-uninline-file-during-scrub

mds: un-inline data on scrub

Reviewed-by: Xiubo Li <xiubli@redhat.com>

doc/rados: add "pgs not deep scrubbed in time" info

Add a procedure to doc/rados/operations/health-warnings.rst that
explains how to remedy the "X PGs not deep-scrubbed in time" health
warning.

This procedure was developed by Eugen Block, and is at the time of this
commit available on his blog at
https://heiterbiswolkig.blogs.nde.ag/2024/09/06/pgs-not-deep-scrubbed-in-time/

Co-authored-by: Eugen Block <eblock@nde.ag>
Signed-off-by: Zac Dover <zac.dover@proton.me>

librbd/migration/NBDStream: abstract out libnbd and add unit tests

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

qa/suites/rbd: add snippets for migration import from NBD

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd/migration/NBDStream: call nbd_shutdown() in close()

Avoid warnings like

  qemu-nbd: Disconnect client, due to: Failed to read request:
  Unexpected end-of-file before all bytes were read

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd/migration/NBDStream: switch to NBD URIs

This removes the constraint on the transport being TCP, allowing to
use a Unix domain socket or other options.  It also allows specifying
export names which a) are needed in case of serving different content
on different exports and b) some servers may require regardless.

Additionally, NBD URIs are future proof as all that NBDStream needs to
do is forward the string to libnbd.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd/migration/NBDStream: check for nbd_get_size() errors

nbd_get_size() can fail with EOVERFLOW and possibly other errors.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd/migration/NBDStream: introduce from_nbd_errno()

Errors returned by nbd_get_errno() can't be used to complete Contexts
directly because a) these errors are positive while complete() in most
cases expects a negative error and b) nbd_get_errno() can return 0 even
after libnbd call fails (i.e. returns -1).

Introduce a helper with EIO as a default/fallback error.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd/migration/NBDStream: be more thorough around nbd_block_status()

nbd_block_status() is specified to be really loose: it can return
more status (go beyond the requested range), less status (cover only
some part of the requested range) or nothing at all.  The former would
likely violate some assumptions in ObjectCopyRequest, while the latter
would lead to straight data corruption -- parent blocks that weren't
covered would never get copied up into the destination image.

On top of that, the current implementation is very suboptimal.
Because only "nr_entries == 2" responses are effectively processed,
any extent which has a small amount of data and is otherwise zeroed
(e.g. 8K of data in a 4M object) gets listed as DATA.  A copyup for
such an object would write 4M worth of data instead of 8K, consuming
space in the destination image unnecessarily.

Also, it's unclear whether zero-sized entries can be returned.
Currently, if it happens we would hit an assert in interval_map.

This fixes all of these issues.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd/migration: add nbd stream

Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Effi Ofer <effio@il.ibm.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #59630 from zdover23/wip-doc-2024-09-06-README-md-build-prerequisites

doc/README.md: edit "Build Prerequisites"

Merge pull request #59575 from juan-ferrer-toribio/tracker-67849

mgr/dashboard: Fix variable capitalization in embedded rbd-details panel

Reviewed-by: Nizamudeen A <nia@redhat.com>

rbd/bench: Add ability to write a random string of bytes or a specific byte with --pattern-bytes option

Fixes: https://tracker.ceph.com/issues/67319
Signed-off-by: Connor Fawcett <connorfa@uk.ibm.com>

doc/README.md: edit "Build Prerequisites"

Make the sentences in the "Build Prerequisites" section of README.md
more direct.

Signed-off-by: Zac Dover <zac.dover@proton.me>

 mon/NVMeofGw*:
 1. fix blocklist bug - blockist was not called
 2. originally monitor only bloklisted specific ana groups but since we allow
    the changing of ns ana grp on the fly for the sake of ns load balance,
    it is not good enough and we need to blocklist all the cluster contexts
    of the failing gateway
Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>

doc/dev: add "activate latest release" RTD step

Add a step to the section called "First Stable Release" that explains
how to activate the latest release in Read the Docs.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #56597 from liangmingyuanneo/optimize-reshard

rgw reshard: optimize reshard process to minimum blocking time

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #59170 from guits/remove-legacy-disk-sorting

ceph-volume: switch over to new disk sorting behavior

Merge pull request #59604 from guits/wip-osd-id-raw

ceph-volume: pass self.osd_id to create_id() call

rgw/notifications: free completion pointer using unique_ptr

also fix access to possible dpp dangling pointer

Fixes: https://tracker.ceph.com/issues/67658
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

Merge pull request #59386 from mkogan1/wip-qlen_qactive

rgw: decrement qlen/qactive perf counters on error

Merge pull request #59613 from zdover23/wip-doc-2024-09-05-rados-config-mon-lookup-dns

doc/rados: add link to messenger v2 info in mon-lookup-dns.rst

Merge PR #59414 into main

* refs/pull/59414/head:
mds: move fscrypt_last_block to vector in mds_co mempool
mds: move fscrypt_file inode_t metadata to mds_co mempool
mds: move fscrypt_auth inode_t metadata to mds_co mempool
include/buffer: add helpers for uint8_t vectors

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>

mgr/dashboard: Increase maximum namespace count to 1024

Fixes https://tracker.ceph.com/issues/67871

The maximum namespace count will be 1024 for subsystems now.

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>

crimson/common/gated: Comment out ceph_assert for shard ID check

After adding sid (shard ID) to Gated, each shard should have its own gate.
However, some users of Gated had a single instance, which either failed
these assertions or created the Gated object on the wrong shard.
A tracker issue #67773 was opened for this, and this commit comments out
the assertions until the issue is resolved.

Signed-off-by: NitzanMordhai <nmordech@redhat.com>

crimson/net/io_handler: ctor add gate ctor with shard id

IOHandler::to_new_sid provides a mechanism to switch to a new core from the current one used.
This behavior is tricky for making sure that we keep the IOHandler::shard_states_t::gate instance to be used on the same core that it was created.
In order to resolve this, we should be able to construct Gated out of specified core_id (and not from this_shard_id).

See: https://github.com/ceph/ceph/pull/58986#discussion_r1733782952

Signed-off-by: NitzanMordhai <nmordech@redhat.com>

doc/rados: add link to messenger v2 info in mon-lookup-dns.rst

Add a link to the page about Messenger v2 to the end of
doc/rados/configuration/mon-lookup-dns.rst.

Fixes: https://tracker.ceph.com/issues/58752
Signed-off-by: Zac Dover <zac.dover@proton.me>

qa: test fetching foreign config item

Signed-off-by: Milind Changire <mchangir@redhat.com>

mgr/snap_schedule: correctly fetch mds_max_snaps_per_dir from mds

Fixes: https://tracker.ceph.com/issues/65895
Signed-off-by: Milind Changire <mchangir@redhat.com>

 mon/NVMeofGw*: Fix issue when ana group of deleted GW was not serviced.
 Introduced GW Deleting state
Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>

Merge pull request #58438 from myoungwon/wip-batched-ool-writes

crimson/os/seastore/rbm: write merge-able ool extents at once

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #59570 from zhscn/fix-node-capacity

crimson/os/seastore: cleanup lba/backref node capacity

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #59474 from athanatos/sjust/for-review/wip-67755-fix-msr-feature

osd: fix require_min_compat_client handling for msr rules

mgr/cephadm: make ssh keepalive settings configurable

It was found on some larger clusters that these settings
were two low and hosts were getting temporarily marked
offline

Signed-off-by: Adam King <adking@redhat.com>

mgr/smb: add support for new ceph vfs module

Add support for using the new ceph vfs module in Samba (aka ceph_new) to
the mgr module, and even default to using it for the samba-vfs provider.
Add two new "sub-providers" one for forcing the old vfs module
"samba-vfs/classic" and one, "samba-vfs/new", for forcing the new module
regardless of what the default for "samba-vfs" is.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #59490 from Suyashd999/fix-mfr1

rgw/rgw_aio: forwarding reference passed to std::move()

Reviewed-By: Adam Emerson <aemerson@ibm.com>, Yuval Lifshitz <ylifshit@ibm.com>

Merge pull request #59530 from rhcs-dashboard/api_test_mgr_module_failure

qa/tests: fix test_list_enabled_modules timeout error

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

ceph-volume: pass self.osd_id to create_id() call

This fixes a regression
(most likely introduced with 04c93a1ed42)

Current (broken) behavior:
```
[root@devel1-1 /]# ceph osd tree
ID  CLASS  WEIGHT  TYPE NAME     STATUS     REWEIGHT  PRI-AFF
-1              0  root default
 0              0  osd.0         destroyed         0  1.00000
[root@devel1-1 /]# ceph-volume raw prepare --bluestore --data /dev/vdb --osd-id 0
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring -i - osd new 543e0268-ea66-451f-a2f6-95ae60ab6146
Running command: /usr/bin/mount -t tmpfs tmpfs /var/lib/ceph/osd/ceph-1
Running command: /usr/sbin/restorecon /var/lib/ceph/osd/ceph-1
Running command: /usr/bin/chown -R ceph:ceph /dev/vdb
Running command: /usr/bin/ln -s /dev/vdb /var/lib/ceph/osd/ceph-1/block
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring mon getmap -o /var/lib/ceph/osd/ceph-1/activate.monmap
 stderr: got monmap epoch 1
--> Creating keyring file for osd.1
Running command: /usr/bin/chown -R ceph:ceph /var/lib/ceph/osd/ceph-1/keyring
Running command: /usr/bin/chown -R ceph:ceph /var/lib/ceph/osd/ceph-1/
Running command: /usr/bin/ceph-osd --cluster ceph --osd-objectstore bluestore --mkfs -i 1 --monmap /var/lib/ceph/osd/ceph-1/activate.monmap --keyfile - --osd-data /var/lib/ceph/osd/ceph-1/ --osd-uuid 543e0268-ea66-451f-a2f6-95ae60ab6146 --setuser ceph --setgroup ceph
 stderr: 2024-09-04T11:46:54.283+0000 7f0027d2b640 -1 bluestore(/var/lib/ceph/osd/ceph-1//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-1//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
 stderr: 2024-09-04T11:46:54.283+0000 7f0027d2b640 -1 bluestore(/var/lib/ceph/osd/ceph-1//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-1//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
 stderr: 2024-09-04T11:46:54.283+0000 7f0027d2b640 -1 bluestore(/var/lib/ceph/osd/ceph-1//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-1//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
 stderr: 2024-09-04T11:46:54.283+0000 7f0027d2b640 -1 bluestore(/var/lib/ceph/osd/ceph-1/) _read_fsid unparsable uuid
--> ceph-volume raw dmcrypt prepare successful for: /dev/vdb
[root@devel1-1 /]# ceph osd tree
ID  CLASS  WEIGHT  TYPE NAME     STATUS     REWEIGHT  PRI-AFF
-1              0  root default
 0              0  osd.0         destroyed         0  1.00000
 1              0  osd.1              down   1.00000  1.00000
```

A new osd id has been generated while we want to reuse the existing one (0 in this case).

Expected (fixed) behavior:

```
[root@devel1-1 /]# ceph osd tree
ID  CLASS  WEIGHT  TYPE NAME     STATUS     REWEIGHT  PRI-AFF
-1              0  root default
 0              0  osd.0         destroyed         0  1.00000
[root@devel1-1 /]# ceph-volume raw prepare --bluestore --data /dev/vdb --osd-id 0
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring osd tree -f json
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring -i - osd new c87841fb-f56f-40a2-a653-62bb092e8e95 0
Running command: /usr/bin/mount -t tmpfs tmpfs /var/lib/ceph/osd/ceph-0
Running command: /usr/sbin/restorecon /var/lib/ceph/osd/ceph-0
Running command: /usr/bin/chown -R ceph:ceph /dev/vdb
Running command: /usr/bin/ln -s /dev/vdb /var/lib/ceph/osd/ceph-0/block
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring mon getmap -o /var/lib/ceph/osd/ceph-0/activate.monmap
 stderr: got monmap epoch 1
--> Creating keyring file for osd.0
Running command: /usr/bin/chown -R ceph:ceph /var/lib/ceph/osd/ceph-0/keyring
Running command: /usr/bin/chown -R ceph:ceph /var/lib/ceph/osd/ceph-0/
Running command: /usr/bin/ceph-osd --cluster ceph --osd-objectstore bluestore --mkfs -i 0 --monmap /var/lib/ceph/osd/ceph-0/activate.monmap --keyfile - --osd-data /var/lib/ceph/osd/ceph-0/ --osd-uuid c87841fb-f56f-40a2-a653-62bb092e8e95 --setuser ceph --setgroup ceph
 stderr: 2024-09-04T13:07:39.125+0000 7ff02baaa640 -1 bluestore(/var/lib/ceph/osd/ceph-0//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-0//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
 stderr: 2024-09-04T13:07:39.125+0000 7ff02baaa640 -1 bluestore(/var/lib/ceph/osd/ceph-0//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-0//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
 stderr: 2024-09-04T13:07:39.126+0000 7ff02baaa640 -1 bluestore(/var/lib/ceph/osd/ceph-0//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-0//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
 stderr: 2024-09-04T13:07:39.126+0000 7ff02baaa640 -1 bluestore(/var/lib/ceph/osd/ceph-0/) _read_fsid unparsable uuid
--> ceph-volume raw dmcrypt prepare successful for: /dev/vdb
[root@devel1-1 /]# ceph osd tree
ID  CLASS  WEIGHT  TYPE NAME     STATUS  REWEIGHT  PRI-AFF
-1              0  root default
 0              0  osd.0           down         0  1.00000
```

Fixes: https://tracker.ceph.com/issues/67898
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>

osd/scrub: implement existing 'interval' as a distinct delay reason

allowing setting specific delay times for scrubs that were aborted
due to the interval being changed. The specified delay should be
lower than the default delay used for the other types of
mid-scrub aborts.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

test/osd: fix 'recovery scrub' standalone test

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>