]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/log
ceph-ci.git
5 years agomgr/ServiceMap: move ServiceMap::Daemon implementation into .cc file
Kefu Chai [Thu, 16 Jul 2020 11:09:18 +0000 (19:09 +0800)]
mgr/ServiceMap: move ServiceMap::Daemon implementation into .cc file

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #36103 from dillaman/wip-44311
Kefu Chai [Thu, 16 Jul 2020 09:22:47 +0000 (17:22 +0800)]
Merge pull request #36103 from dillaman/wip-44311

crush/CrushWrapper: rebuild reverse maps after rebuilding crush map

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
5 years agoMerge pull request #35768 from rhcs-dashboard/fix-45185-master
Kefu Chai [Thu, 16 Jul 2020 09:21:59 +0000 (17:21 +0800)]
Merge pull request #35768 from rhcs-dashboard/fix-45185-master

mgr/dashboard: fix pool usage calculation

Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
5 years agoMerge pull request #36095 from orozery/striper_get_file_offset
Kefu Chai [Thu, 16 Jul 2020 09:19:29 +0000 (17:19 +0800)]
Merge pull request #36095 from orozery/striper_get_file_offset

osdc/Striper: add get_file_offset function

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agoMerge pull request #36091 from tchaikov/wip-46495
Kefu Chai [Thu, 16 Jul 2020 09:17:49 +0000 (17:17 +0800)]
Merge pull request #36091 from tchaikov/wip-46495

mgr/DaemonServer: keep daemon in service map when it has no tasks

Reviewed-by: Venky Shankar <vshankar@redhat.com>
5 years agoMerge pull request #36051 from Songweibin/wip-rados-setomapval
Kefu Chai [Thu, 16 Jul 2020 09:13:28 +0000 (17:13 +0800)]
Merge pull request #36051 from Songweibin/wip-rados-setomapval

tools/rados: add an option "--input-file file" to `setomapval` command

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #35130 from rzarzynski/wip-crimson-backfill
Kefu Chai [Thu, 16 Jul 2020 08:29:29 +0000 (16:29 +0800)]
Merge pull request #35130 from rzarzynski/wip-crimson-backfill

crimson: add support for backfill, part 0

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #33770 from majianpeng/osd-simple-logger
Kefu Chai [Thu, 16 Jul 2020 04:29:49 +0000 (12:29 +0800)]
Merge pull request #33770 from majianpeng/osd-simple-logger

osd/OSD: simple perfcounter usage in OSDService

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #35989 from bigwhite37/fix-dedup-tool-unused-var-warn
myoungwon oh [Thu, 16 Jul 2020 00:42:30 +0000 (09:42 +0900)]
Merge pull request #35989 from bigwhite37/fix-dedup-tool-unused-var-warn

tools/ceph_dedup_tool: fix unused variable warning

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #30780 from zhangsw/fix-rgw-multipart-abortdate
ofriedma [Wed, 15 Jul 2020 16:21:55 +0000 (19:21 +0300)]
Merge pull request #30780 from zhangsw/fix-rgw-multipart-abortdate

rgw: add abort multipart date and rule-id header to init multipart upload response

5 years agoMerge pull request #35950 from zdover23/wip-doc-dev-guide-add-zdover-to-lead-list
zdover23 [Wed, 15 Jul 2020 14:37:46 +0000 (00:37 +1000)]
Merge pull request #35950 from zdover23/wip-doc-dev-guide-add-zdover-to-lead-list

doc/devel: add zdover to leads list

5 years agoMerge pull request #34537 from ideepika/wip-bluestore-mem-tracking
Josh Durgin [Wed, 15 Jul 2020 13:50:58 +0000 (06:50 -0700)]
Merge pull request #34537 from ideepika/wip-bluestore-mem-tracking

os/bluestore: mempool split for finer granularity

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
5 years agoMerge pull request #35901 from sebastian-philipp/juanmi-firewall-refactor
Sebastian Wagner [Wed, 15 Jul 2020 12:44:20 +0000 (14:44 +0200)]
Merge pull request #35901 from sebastian-philipp/juanmi-firewall-refactor

cephadm: refactor update_firewalld

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
5 years agoMerge pull request #35862 from adk3798/cephadm_45724
Sebastian Wagner [Wed, 15 Jul 2020 12:42:54 +0000 (14:42 +0200)]
Merge pull request #35862 from adk3798/cephadm_45724

mgr/cephadm: check-host should not fail as hard using fqdn

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
5 years agoMerge pull request #35471 from sebastian-philipp/cephadm-daemon-spec
Sebastian Wagner [Wed, 15 Jul 2020 12:39:35 +0000 (14:39 +0200)]
Merge pull request #35471 from sebastian-philipp/cephadm-daemon-spec

mgr/cephadm: Add CephadmDaemonSpec class

5 years agoMerge pull request #35838 from mgfritch/cephadm-rgw-spec-validate
Sebastian Wagner [Wed, 15 Jul 2020 12:37:56 +0000 (14:37 +0200)]
Merge pull request #35838 from mgfritch/cephadm-rgw-spec-validate

python-common: RGW service_id might not contain a zone

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agodoc/devel: add zdover to leads list
Zac Dover [Wed, 15 Jul 2020 10:59:06 +0000 (20:59 +1000)]
doc/devel: add zdover to leads list

This commit adds "zdover" to the list of
leads as the Docs Lead.

Fixes: https://tracker.ceph.com/issues/46378
Signed-off-by: Zac Dover <zac.dover@gmail.com>
5 years agoMerge pull request #36096 from BenoitKnecht/doc-osd-scrub-during-recovery
Kefu Chai [Wed, 15 Jul 2020 10:58:43 +0000 (18:58 +0800)]
Merge pull request #36096 from BenoitKnecht/doc-osd-scrub-during-recovery

doc/rados: Fix osd_scrub_during_recovery default value

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
5 years agoMerge pull request #36052 from smithfarm/wip-focce
Kefu Chai [Wed, 15 Jul 2020 10:52:18 +0000 (18:52 +0800)]
Merge pull request #36052 from smithfarm/wip-focce

bluestore: fix typo in _flush function declaration

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #35991 from votdev/adapt_cephadm_vagrantbox_to_el8
Sebastian Wagner [Wed, 15 Jul 2020 10:46:58 +0000 (12:46 +0200)]
Merge pull request #35991 from votdev/adapt_cephadm_vagrantbox_to_el8

mgr/cephadm: Adapt Vagrantbox to el8

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
5 years agoMerge pull request #35315 from weixinwei/master
Kefu Chai [Wed, 15 Jul 2020 10:42:57 +0000 (18:42 +0800)]
Merge pull request #35315 from weixinwei/master

blk:BlockDevice.cc: use pending_aios instead of iovec size as ios num

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
5 years agoMerge pull request #35844 from wuhongsong/fuse-assert-Dprocess
Kefu Chai [Wed, 15 Jul 2020 10:39:19 +0000 (18:39 +0800)]
Merge pull request #35844 from wuhongsong/fuse-assert-Dprocess

common:  ignore SIGHUP prior to fork

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #36054 from tchaikov/wip-blk-no-unused-label
Kefu Chai [Wed, 15 Jul 2020 10:38:02 +0000 (18:38 +0800)]
Merge pull request #36054 from tchaikov/wip-blk-no-unused-label

blk/BlockDevice: use ceph_assertf() for assert

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
5 years agoMerge pull request #35744 from jmolmo/document_unmanaged_use
Sebastian Wagner [Wed, 15 Jul 2020 10:33:39 +0000 (12:33 +0200)]
Merge pull request #35744 from jmolmo/document_unmanaged_use

doc: Add information about unmanaged parameter

Reviewed-by: Alexandra Settle <asettle@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
5 years agomgr/cephadm: Add test for _check_daemons()
Sebastian Wagner [Thu, 18 Jun 2020 12:07:54 +0000 (14:07 +0200)]
mgr/cephadm: Add test for _check_daemons()

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agomgr/cephadm: refactor `_create_daemon()`
Sebastian Wagner [Mon, 8 Jun 2020 10:45:14 +0000 (12:45 +0200)]
mgr/cephadm: refactor `_create_daemon()`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agomgr/cephadm: Add CephadmDaemonSpec class
Sebastian Wagner [Mon, 8 Jun 2020 07:36:20 +0000 (09:36 +0200)]
mgr/cephadm: Add CephadmDaemonSpec class

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #35709 from zdover23/wip-doc-preferring-yaml-to-cli-in-cephadm
Sebastian Wagner [Wed, 15 Jul 2020 08:10:38 +0000 (10:10 +0200)]
Merge pull request #35709 from zdover23/wip-doc-preferring-yaml-to-cli-in-cephadm

doc/cephadm: add yaml info for orch apply mon

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agomgr/DaemonServer: keep daemon in service map when it has no tasks
Kefu Chai [Tue, 14 Jul 2020 09:48:59 +0000 (17:48 +0800)]
mgr/DaemonServer: keep daemon in service map when it has no tasks

we should not remove a daemon from service map even if it has no task
running, as it is not an evidence that the service is removed from the
cluster.

this change partially reverts 5a7d0632d989536e09b2d916b5ea9713dc8dbea5

Fixes: https://tracker.ceph.com/issues/46495
Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agomgr/DaemonServer: pass task_status instead of a message
Kefu Chai [Tue, 14 Jul 2020 09:34:02 +0000 (17:34 +0800)]
mgr/DaemonServer: pass task_status instead of a message

be explicit that the caller is only interested in the task_status

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #29283 from myoungwon/wip-refcount-snap
Samuel Just [Tue, 14 Jul 2020 22:52:42 +0000 (15:52 -0700)]
Merge pull request #29283 from myoungwon/wip-refcount-snap

osd: refcounting chunks for snapshotted manifest object

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com> (portions Sam wrote)
5 years agocrush/CrushWrapper: rebuild reverse maps after rebuilding crush map
Jason Dillaman [Tue, 14 Jul 2020 22:49:30 +0000 (18:49 -0400)]
crush/CrushWrapper: rebuild reverse maps after rebuilding crush map

The Objecter will crash when localized reads are enabled and two threads
attempt to rebuild the (invalidated) reverse maps concurrently. This
should address the issue for the Objecter use-case without the need to
add additional locking.

Fixes: https://tracker.ceph.com/issues/44311
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
5 years agoMerge pull request #35955 from jschmid1/deprecate_filstore
Sebastian Wagner [Tue, 14 Jul 2020 14:17:52 +0000 (16:17 +0200)]
Merge pull request #35955 from jschmid1/deprecate_filstore

mgr/cephadm: do not accept filestore osds in osdspecs

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Travis Nielsen <tnielsen@redhat.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
5 years agodoc/cephadm: add yaml infor for orch apply mon
Zac Dover [Tue, 14 Jul 2020 13:51:08 +0000 (23:51 +1000)]
doc/cephadm: add yaml infor for orch apply mon

This commit breaks one of the long sentences into
three shorter sentences, and adds a parenthetical
comment walking the reader through a series of commands,
explaining what each command does and why only the last
of the commands ends up having a lasting effect on the Ceph
environment.

Fixes: https://tracker.ceph.com/issues/46133
Signed-off-by: Zac Dover <zac.dover@gmail.com>
5 years agomgr/cephadm: check-host should not fail as hard using fqdn
Adam King [Tue, 30 Jun 2020 21:49:09 +0000 (17:49 -0400)]
mgr/cephadm: check-host should not fail as hard using fqdn

Print error message instead of traceback when check-host
fails in due to host address not being found

Fixes: https://tracker.ceph.com/issues/45724
Signed-off-by: Adam King <adking@redhat.com>
5 years agocephadm: refactor update_firewalld
Sebastian Wagner [Thu, 2 Jul 2020 14:28:14 +0000 (16:28 +0200)]
cephadm: refactor update_firewalld

* split into three different methods
* untangle service and port lists

This helps in making our firewall handling more dynamic.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Co-authored-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
5 years agodoc/rados: Fix osd_scrub_during_recovery default value
Benoît Knecht [Tue, 14 Jul 2020 11:50:28 +0000 (13:50 +0200)]
doc/rados: Fix osd_scrub_during_recovery default value

Since 8dca17c, `osd_scrub_during_recovery` defaults to `false`, but the
documentation was still stating that its default value is `true`.

Fixes: https://tracker.ceph.com/issues/46531
Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
5 years agoosdc/Striper: add get_file_offset function
Or Ozeri [Tue, 14 Jul 2020 11:28:12 +0000 (14:28 +0300)]
osdc/Striper: add get_file_offset function

This commit adds a get_file_offset translating (object_no, object_off) -> file_offset.
This is useful for encryption object dispatch layer in librbd
to comply with disk-encryption standards that require the file offset as input.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
5 years agoMerge pull request #36013 from Devp00l/wip-46376
Sebastian Wagner [Tue, 14 Jul 2020 08:38:09 +0000 (10:38 +0200)]
Merge pull request #36013 from Devp00l/wip-46376

cephadm: Make Vagrantfile more flexible

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #36072 from zdover23/wip-doc-dev-word-choice-guidance
zdover23 [Tue, 14 Jul 2020 07:46:40 +0000 (17:46 +1000)]
Merge pull request #36072 from zdover23/wip-doc-dev-word-choice-guidance

doc/dev: remove extraneous word "guidance".

5 years agoMerge pull request #35931 from tchaikov/wip-mds-denc
Kefu Chai [Tue, 14 Jul 2020 04:04:32 +0000 (12:04 +0800)]
Merge pull request #35931 from tchaikov/wip-mds-denc

mds,denc: prepare for the enabling of denc support of EMetaBlob::fullbit

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #35755 into master
Patrick Donnelly [Tue, 14 Jul 2020 02:53:29 +0000 (19:53 -0700)]
Merge PR #35755 into master

* refs/pull/35755/head:
mgr/volumes: Deprecate protect/unprotect CLI calls for subvolume snapshots

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Victoria Martinez de la Cruz <vkmc@redhat.com>
Reviewed-by: Goutham Pacha Ravi <gouthamr@redhat.com>
5 years agoMerge pull request #35970 from athanatos/sjust/wip-fix-lba-addrs
Kefu Chai [Tue, 14 Jul 2020 02:18:41 +0000 (10:18 +0800)]
Merge pull request #35970 from athanatos/sjust/wip-fix-lba-addrs

crimson/seastore: fix lba btree internal references

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #34246 into master
Patrick Donnelly [Mon, 13 Jul 2020 18:17:44 +0000 (11:17 -0700)]
Merge PR #34246 into master

* refs/pull/34246/head:
mds: add request to batch_op before taking auth pins and locks
mds: move MDRequestImpl::batch_reqs into Batch_Getattr_Lookup
mds: track which map batch_op is in-use in MDRequest

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #34785 into master
Patrick Donnelly [Mon, 13 Jul 2020 18:16:28 +0000 (11:16 -0700)]
Merge PR #34785 into master

* refs/pull/34785/head:
ceph-fuse: show fuse helper options for libfuse >= 3.0
ceph-fuse: add splice read/write support to reduce the memory copy
ceph-fuse: add connection args parsing support for libfuse > 3.0
ceph-fuse: switch to fuse_reply_iov to reduce the memory copy

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
5 years agoMerge PR #35327 into master
Patrick Donnelly [Mon, 13 Jul 2020 18:15:14 +0000 (11:15 -0700)]
Merge PR #35327 into master

* refs/pull/35327/head:
client: fix directory inode can not call release callback

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #35690 into master
Patrick Donnelly [Mon, 13 Jul 2020 18:14:16 +0000 (11:14 -0700)]
Merge PR #35690 into master

* refs/pull/35690/head:
mds: fix hang issue when accessing a file under a lost parent directory

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #35848 into master
Patrick Donnelly [Mon, 13 Jul 2020 18:13:43 +0000 (11:13 -0700)]
Merge PR #35848 into master

* refs/pull/35848/head:
mds: do not submit omap_rm_keys if the dir is the basedir of merge.

Reviewed-by: Zheng Yan <zyan@redhat.com>
5 years agoos/Bluefs: fix file reader/writer buffer mempool
Deepika Upadhyay [Wed, 17 Jun 2020 14:42:32 +0000 (10:42 -0400)]
os/Bluefs: fix file reader/writer buffer mempool

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
5 years agobluestore: _get_used_bytes should reflect new mempool fields
Deepika Upadhyay [Wed, 20 May 2020 20:32:02 +0000 (02:02 +0530)]
bluestore: _get_used_bytes should reflect new mempool fields

with bluestore_cache_other split further, the _get_used_bytes should
take into account the new mempool splits as well.

see also: 0ce8ee4b123eacfc2bfb14f554487e928512415a
  68ee931fd4b6bf748f95b14dae31d11738fbaf1e

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
5 years agocommon/mempool: More detailed bluestore stats
Adam Kupczyk [Thu, 14 May 2020 11:24:15 +0000 (07:24 -0400)]
common/mempool: More detailed bluestore stats

Splits bluestore bluestore_cache_other, exposes accounting of some internals.

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
5 years agoIntroduce separate mempool for FileReaderBuffer and FileWriter
Deepika Upadhyay [Wed, 15 Apr 2020 12:10:15 +0000 (17:40 +0530)]
Introduce separate mempool for FileReaderBuffer and FileWriter

FileReaderBuffer and FileWriter uses Bufferlists which needs to be
tracked by mempool to get the proper memory usage.

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
5 years agosplit mempool allocation for bluestore_cache_other
Deepika Upadhyay [Wed, 15 Apr 2020 12:01:46 +0000 (17:31 +0530)]
split mempool allocation for bluestore_cache_other

While doing root cause analysis it bluestore_cache_other gives a bit of
a crude estimate, something more helpful would be to have it split into
the following fields:

- bluestore_cache_onode
- bluestore_cache_meta
- bluestore_onode_attrs

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
5 years agoMerge PR #35951 into master
Patrick Donnelly [Mon, 13 Jul 2020 18:10:00 +0000 (11:10 -0700)]
Merge PR #35951 into master

* refs/pull/35951/head:
qa/cephfs: set omit_sudo to False for wait_until_mounted() in...

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agocrimson/os/seastore: fix internal relative btree addrs
Samuel Just [Tue, 7 Jul 2020 22:44:42 +0000 (15:44 -0700)]
crimson/os/seastore: fix internal relative btree addrs

Internal relative addrs must be block relative on disk and record
relative in deltas.  Use maybe_generate_relative as intended.

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agoseastore/test_transaction_manager: add a test which forces an lba split
Samuel Just [Tue, 7 Jul 2020 22:44:04 +0000 (15:44 -0700)]
seastore/test_transaction_manager: add a test which forces an lba split

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agoseastore/test_btree_lba_manager: ensure record and block addrs are different
Samuel Just [Tue, 7 Jul 2020 23:23:29 +0000 (16:23 -0700)]
seastore/test_btree_lba_manager: ensure record and block addrs are different

Adds an extra extent to each transaction in the test to ensure that
record and block relative addresses differ as they do in real usage.

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agoMerge pull request #34920 from ofriedma/ofriedma-civetweb-timeout
Casey Bodley [Mon, 13 Jul 2020 14:42:46 +0000 (10:42 -0400)]
Merge pull request #34920 from ofriedma/ofriedma-civetweb-timeout

rgw: increase civetweb request timeout to 65 seconds

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
5 years agocrimson/osd: automate state logging in the backfill FSM.
Radoslaw Zarzynski [Fri, 10 Jul 2020 20:24:05 +0000 (22:24 +0200)]
crimson/osd: automate state logging in the backfill FSM.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agoosd: refactor needs_recovery() and needs_backfill() of PeeringState.
Radoslaw Zarzynski [Thu, 9 Jul 2020 14:28:27 +0000 (16:28 +0200)]
osd: refactor needs_recovery() and needs_backfill() of PeeringState.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: synchronize BackfillRecovery with PeeringEvent.
Radoslaw Zarzynski [Thu, 21 May 2020 18:26:07 +0000 (20:26 +0200)]
crimson/osd: synchronize BackfillRecovery with PeeringEvent.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: recovery locking uses ceph_assert_always().
Radoslaw Zarzynski [Tue, 19 May 2020 09:33:38 +0000 (11:33 +0200)]
crimson/osd: recovery locking uses ceph_assert_always().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: implement MOSDPGBackfill.
Radoslaw Zarzynski [Mon, 18 May 2020 13:24:28 +0000 (15:24 +0200)]
crimson/osd: implement MOSDPGBackfill.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: implement BackfillRecoveryPipeline.
Radoslaw Zarzynski [Tue, 12 May 2020 20:57:26 +0000 (22:57 +0200)]
crimson/osd: implement BackfillRecoveryPipeline.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agoosd: improve debugs in PrimaryLogPG::do_scan().
Radoslaw Zarzynski [Tue, 12 May 2020 14:46:14 +0000 (16:46 +0200)]
osd: improve debugs in PrimaryLogPG::do_scan().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: implement BackfillListener::backfilled().
Radoslaw Zarzynski [Tue, 12 May 2020 14:46:14 +0000 (16:46 +0200)]
crimson/osd: implement BackfillListener::backfilled().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: implement BackfillListener::enqueue_push().
Radoslaw Zarzynski [Tue, 12 May 2020 14:46:14 +0000 (16:46 +0200)]
crimson/osd: implement BackfillListener::enqueue_push().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: short-circuit budget_available().
Radoslaw Zarzynski [Mon, 11 May 2020 20:15:38 +0000 (22:15 +0200)]
crimson/osd: short-circuit budget_available().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: wire-up pg scanning on replicas.
Radoslaw Zarzynski [Mon, 11 May 2020 20:03:54 +0000 (22:03 +0200)]
crimson/osd: wire-up pg scanning on replicas.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: wire-up BackfillState and pg scanning on primary.
Radoslaw Zarzynski [Tue, 5 May 2020 14:39:56 +0000 (16:39 +0200)]
crimson/osd: wire-up BackfillState and pg scanning on primary.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: introduce PGRecovery::start_backfill_recovery().
Radoslaw Zarzynski [Fri, 22 May 2020 22:14:14 +0000 (00:14 +0200)]
crimson/osd: introduce PGRecovery::start_backfill_recovery().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: settle BackfillState in PGRecovery.
Radoslaw Zarzynski [Tue, 5 May 2020 10:43:13 +0000 (12:43 +0200)]
crimson/osd: settle BackfillState in PGRecovery.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: PGRecovery provides dummy BackfillListener.
Radoslaw Zarzynski [Mon, 4 May 2020 21:01:57 +0000 (23:01 +0200)]
crimson/osd: PGRecovery provides dummy BackfillListener.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: make BackgroundRecovery abstract for the sake of backfill.
Radoslaw Zarzynski [Mon, 4 May 2020 17:47:18 +0000 (19:47 +0200)]
crimson/osd: make BackgroundRecovery abstract for the sake of backfill.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: decouple backfill from PG::start_recovery_ops().
Radoslaw Zarzynski [Mon, 4 May 2020 16:44:36 +0000 (18:44 +0200)]
crimson/osd: decouple backfill from PG::start_recovery_ops().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: bring the boost::statechart-based FSM for backfill.
Radoslaw Zarzynski [Tue, 28 Apr 2020 14:45:52 +0000 (16:45 +0200)]
crimson/osd: bring the boost::statechart-based FSM for backfill.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agoosd: refactor PrimaryLogPG::recover_backfill() a little bit.
Radoslaw Zarzynski [Tue, 28 Apr 2020 14:45:52 +0000 (16:45 +0200)]
osd: refactor PrimaryLogPG::recover_backfill() a little bit.

This is change is intended to only refactor the code.
The main theme is just declaring the `backfill_pos` closer
to its usage.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agoosd: refactor PeeringState::find_best_info() a little bit.
Radoslaw Zarzynski [Tue, 28 Apr 2020 14:45:52 +0000 (16:45 +0200)]
osd: refactor PeeringState::find_best_info() a little bit.

This is change is intended to only refactor the code. All
it does is just declaring the `min_last_update_acceptable`
closer to its usage.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: sketch the backfill machine and its interfaces.
Radoslaw Zarzynski [Tue, 21 Apr 2020 18:45:21 +0000 (20:45 +0200)]
crimson/osd: sketch the backfill machine and its interfaces.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: send MOSDPGTemp on peering and map advance.
Radoslaw Zarzynski [Tue, 21 Apr 2020 18:39:18 +0000 (20:39 +0200)]
crimson/osd: send MOSDPGTemp on peering and map advance.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: rework handling of MOSDAlive.
Radoslaw Zarzynski [Tue, 21 Apr 2020 18:38:31 +0000 (20:38 +0200)]
crimson/osd: rework handling of MOSDAlive.

1. Migrate `MOSDAlive` crafting from `OSD` to `ShardServices`.
2. `send_alive()` takes the `want` epoch from callers
   instead of assuming it matches current OSDMap.
   Callers pass `pg_history_t::same_interval_since`.
   The passed epoch is handled similarly to `queue_want_up_thru()`
   in the classical.
   The message is sent once and when the desired epoch is greater
   than the one returned by `OSDMap::get_up_thru()`.
3. Send the message also when completing the `PeeringEvent`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agoosd: link up the documentation for last_epoch_started.
Radoslaw Zarzynski [Tue, 19 May 2020 13:50:40 +0000 (15:50 +0200)]
osd: link up the documentation for last_epoch_started.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/osd: implement PG scanning.
Radoslaw Zarzynski [Tue, 10 Mar 2020 22:49:27 +0000 (23:49 +0100)]
crimson/osd: implement PG scanning.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agodoc/dev: remove extraneous word "guidance".
Zac Dover [Mon, 13 Jul 2020 14:19:19 +0000 (00:19 +1000)]
doc/dev: remove extraneous word "guidance".

This bug changes the sentence "If your patches emit
messages to the Ceph cluster log, please consult this
guidance:" to "If your patches emit messages to the
Ceph cluster log, please consult this:". This new sentence
is more natural and idiomatic.

Fixes: https://tracker.ceph.com/issues/46363
Signed-off-by: Zac Dover <zac.dover@gmail.com>
5 years agoMerge pull request #36055 from zli091/master
Casey Bodley [Mon, 13 Jul 2020 14:04:30 +0000 (10:04 -0400)]
Merge pull request #36055 from zli091/master

 rgw: lc: fix Segmentation Fault when the tag of the object was not f…

Reviewed-by: Or Friedmann <ofriedma@redhat.com>
Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
5 years agocephadm: Make Vagrantfile more flexible
Stephan Müller [Wed, 1 Jul 2020 14:27:50 +0000 (16:27 +0200)]
cephadm: Make Vagrantfile more flexible

Now you can use a JSON or pass multiple variable to vagrant in order to
configure the outcome of VMs you get. Similar to vstart.sh you can use
OSDS, MGRS and MONS as arguments to pass. As OSDS behave a bit different
in this scenario you can also specify the amount of extra disks and OSD
VM has.

Fixes: https://tracker.ceph.com/issues/46376
Signed-off-by: Stephan Müller <smueller@suse.com>
5 years agotools/rados: add a parameter "-i infile" to `setomapval` command
songweibin [Sat, 11 Jul 2020 07:48:34 +0000 (15:48 +0800)]
tools/rados: add a parameter "-i infile" to `setomapval` command

Signed-off-by: songweibin <song.weibin@zte.com.cn>
5 years agocommon: ignore SIGHUP prior to fork
hzwuhongsong [Tue, 30 Jun 2020 07:46:28 +0000 (15:46 +0800)]
common: ignore SIGHUP prior to fork

Otherwise, the ceph-fuse process is terminated by the logratote task and will produce one Uninterruptible Sleep process.

Fixes: http://tracker.ceph.com/issues/46269
Signed-off-by: hzwuhongsong <hzwuhongsong@corp.netease.com>
5 years agoblk/zoned: do not use g_ceph_context for reading conf
Kefu Chai [Mon, 13 Jul 2020 03:19:53 +0000 (11:19 +0800)]
blk/zoned: do not use g_ceph_context for reading conf

use local `cct` instead, more consistent this way

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoblk/BlockDevice: use ceph_assertf() for assert
Kefu Chai [Sat, 11 Jul 2020 17:04:19 +0000 (01:04 +0800)]
blk/BlockDevice: use ceph_assertf() for assert

also silences a warning like

src/blk/BlockDevice.cc:158:1: warning: label 'out_fail' defined but not used [-Wunused-label]
  158 | out_fail:
      | ^~~~~~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoosd/OSD: simple perfcounter usage in OSDService
Jianpeng Ma [Mon, 13 Jul 2020 00:57:51 +0000 (08:57 +0800)]
osd/OSD: simple perfcounter usage in OSDService

Move create_logger()/create_recoverystate_perf() into construct to
avoid check logger in OSDService. And avoid in destructor delete
nullptr.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
5 years agorgwlc: fix Segmentation Fault related to tags.
zhuo li [Sun, 12 Jul 2020 09:31:20 +0000 (17:31 +0800)]
rgwlc: fix Segmentation Fault related to tags.

It is found that rgw crashes when putting a tag beyond the rule to the object, which can be solved by adding the return value judgment.

Fixes: https://tracker.ceph.com/issues/46485
Signed-off-by: zhuo li <lizhuo@chinatelecom.cn>
Signed-off-by: yupeng chen <chenyupeng@chinatelecom.cn>
5 years agoMerge pull request #36008 from idryomov/wip-krbd-58-options
Ilya Dryomov [Sat, 11 Jul 2020 20:19:34 +0000 (22:19 +0200)]
Merge pull request #36008 from idryomov/wip-krbd-58-options

rbd: recognize crush_location, read_from_replica and compression_hint map options

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agomds: do not decode EMetaBlob::fullbit struct_v < 8
Kefu Chai [Fri, 3 Jul 2020 12:33:04 +0000 (20:33 +0800)]
mds: do not decode EMetaBlob::fullbit struct_v < 8

the struct_v of EMetaBlob::fullbit::encode was bumped from 7 to 8 in
d62c67ca2041797fc7aa212ae4a37ba91e5620e7, the oldest release containing
this change was hammer rc1.

`EMetaBlob::fullbit` is used to persist dentry + inode as part of
journal, after the journal is flushed to the metadata pool, and applied to
dirty metadata, the flushed segments are trimmed. also, it's not allowed
to upgrade a Ceph cluster across 2 releases. so, there is no need
to decode an on-disk struct which will be trimmmed as part of journal
recycling, and that struct was encoded in hammer.

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agodenc: add boost::container::small_vector support
Kefu Chai [Sat, 4 Jul 2020 10:10:55 +0000 (18:10 +0800)]
denc: add boost::container::small_vector support

i could use `_denc::container_base<>` and `_denc::pushback_details<>` to
implement the traits for boost::container::small_vector (bcs for short),
but the second template parameter of bcs is a value of type size_t, so
the value it not a type, forunately, C++17 allows us to declare non-type
template parameter using `auto`, but when instantiating
_denc::container_base<>, the compiler complains that it expects a
constatnt of `auto` but `T` is passed in. because i have to change the
signature of `container_base` to something like
```
template<template<auto...> class C, typename Details, auto ...Ts>
  struct container_base {
```

so, in this change, the traits for bsc is implemented from scratch.

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #36041 from tchaikov/wip-mds-EMetaBlob
Kefu Chai [Sat, 11 Jul 2020 17:14:49 +0000 (01:14 +0800)]
Merge pull request #36041 from tchaikov/wip-mds-EMetaBlob

ceph-object-corpus: pick up changes to drop backward compatibility of…

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoceph-object-corpus: pick up changes to drop backward compatibility
Kefu Chai [Sat, 11 Jul 2020 15:11:21 +0000 (23:11 +0800)]
ceph-object-corpus: pick up changes to drop backward compatibility

to drop backward compatibility of EMetaBlob

see also https://github.com/ceph/ceph-object-corpus/pull/12

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #35747 from adk3798/cephadm-44877
Kefu Chai [Sat, 11 Jul 2020 14:49:47 +0000 (22:49 +0800)]
Merge pull request #35747 from adk3798/cephadm-44877

mgr/cephadm: allow custom dashboard grafana url

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
5 years agoMerge pull request #32852 from ifed01/wip-ifed-simplify-pin
Kefu Chai [Sat, 11 Jul 2020 12:12:27 +0000 (20:12 +0800)]
Merge pull request #32852 from ifed01/wip-ifed-simplify-pin

os/bluestore: simplify Onode pin/unpin logic.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
5 years agoMerge pull request #35973 from mlausch/mgr-progress-perf
Kefu Chai [Sat, 11 Jul 2020 11:32:02 +0000 (19:32 +0800)]
Merge pull request #35973 from mlausch/mgr-progress-perf

mgr/progress: Skip pg_summary update if _events dict is empty.

Reviewed-by: Mykola Golub <mgolub@suse.com>