test: corrected control reaches end by adding a return

Signed-off-by: Patty8122 <divyapattisapu@uchicago.edu>

Merge pull request #52524 from dparmar18/wip-62072

tools/cephfs_mirror: only perform actions if init succeed

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #53407 into main

* refs/pull/53407/head:
Client: Fix nonblocking-io zero by read

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #53279 into main

* refs/pull/53279/head:
qa: descrease pgbench scale factor to 32 for postgresql database test

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #52747 into main

* refs/pull/52747/head:
cephfs-mirror: restart failed/blocklisted replayer instances
cephfs-mirror: do not run concurrent C_RestartMirroring context

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge PR #53418 into main

* refs/pull/53418/head:
qa: use exisitng ignorelist override list for fs:mirror[-ha]

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #48027 from lxbsz/wip-57154

mds/client: check the cephx mds auth access in client side

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #52576 from cfsnyder/wip-62075

rgw: add radosgw-admin bucket check olh/unlinked commands

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #52042 from rishabh-d-dave/better-errmsg-for-perm

MDSAuthCaps: print better error message for perm flag in MDS caps

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #47533 from rishabh-d-dave/ceph-fuse-cmd

qa/cephfs: cleanup code for ceph-fuse command

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #52259 from cbodley/wip-61859

qa/rgw: disable 'rgw lc debug interval' in most suites

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #53531 from ronen-fr/wip-rf-squeue2

osd/scrub: extract scrub initiation code out of the OSD

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #53311 from idryomov/wip-62711

qa/suites/{rbd,krbd}: disable POOL_APP_NOT_ENABLED health check

Reviewed-by: Ramana Raja <rraja@redhat.com>

rgw: radosgw-admin bucket check should only print index entries with --check-objects flag

Printing all index entries can be very time consuming for large
buckets and the inability to switch this behavior off makes it
cumbersome to use the command for fixing bucket stats. This was
also preventing the command from outputting recalculated bucket
stats when the --fix flag wasn't specified.

Signed-off-by: Cory Snyder <csnyder@1111systems.com>

Merge pull request #53528 from rishabh-d-dave/cephfs-qa-mdtest

qa/cephfs: fix build failure for mdtest project

Reviewed-by: Venky Shankar <vshankar@redhat.com>

qa/rgw: enable s3tests for 'storage classes'

other than the rgw/lifecycle subsuite, all of the other subsuites were just
adding storage classes to the rgw task, but not the s3tests task that
enables the storage class test cases

Signed-off-by: Casey Bodley <cbodley@redhat.com>

qa/rgw: disable 'rgw lc debug interval' in most suites

this has a performance cost, and the teuthology environment can
already be sluggish. if lifecycle expiration/transition testing
was limited to the rgw/lifecycle and rgw/cloud-transition suites,
the others would probably run significantly faster

Fixes: https://tracker.ceph.com/issues/61859
Signed-off-by: Casey Bodley <cbodley@redhat.com>

qa/s3tests: use cloudtier_tests and lifecycle_tests to control filters

when `extra_attrs` was made additive, these tests were adding both
'not lifecycle_expiration' and 'lifecycle_expiration' to the command
line. use a yaml flag instead to control whether or not the s3tests task
adds the 'not' filter

Signed-off-by: Casey Bodley <cbodley@redhat.com>

qa/rgw: remove duplicate overrides in rgw/lifecycle

Signed-off-by: Casey Bodley <cbodley@redhat.com>

qa/suites/krbd: disable POOL_APP_NOT_ENABLED health check

... same as for rbd suite.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

qa/suites/rbd: drop POOL_APP_NOT_ENABLED from ignorelists

With "mon warn on pool no app = false" in the config, it's obviously
redundant.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

qa/suites/rbd: disable POOL_APP_NOT_ENABLED health check

Commit 990806e635a1 ("mon, qa: issue pool application warning even
if pool is empty") made it impossible to create a pool without raising
a (bogus) health alert.  See [1] for details.

[1] https://lists.ceph.io/hyperkitty/list/dev@ceph.io/thread/ZTDYC5HN677RR26EB4P6PORN6L2IFH4R/

Fixes: https://tracker.ceph.com/issues/62711
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #53448 from cbodley/wip-62378

rgw/crypt: don't deref null manifest_bl

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #53045 from smanjara/wip-shilpa-revert-51772

rgw/multisite: fixes assertion failure during realm reload

Reviewed-by: Casey Bodley <cbodley@redhat.com>

rgw: prevent another leftover bucket index olh entry scenario

If a call to bucket_index_link_olh or bucket_index_unlink_instance
fails, its associated pending xattr may have prevented the olh object
from being removed by another thread. We should do a best effort
cleanup attempt for this case by calling update_olh before returning
an error to the caller.

Signed-off-by: Cory Snyder <csnyder@1111systems.com>

Merge pull request #53493 from zdover23/wip-doc-2023-09-18-architecture-7-of-x

doc/architecture: "Edit HA Auth" (one of several)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #53505 from cbodley/wip-62771

rgw/sal: get_placement_target_names() returns void

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #52392 from yuvalif/wip-yuval-trace-name

rgw: rename request traces and change for tags

reviewed-by: cbodley

Merge PR #50503 into main

* refs/pull/50503/head:
mon: do not change pending if strategy is unchanged
mon/MonmapMonitor: do not propose on error in prepare_update
mon/MonmapMonitor: wait for commit before reply
mon: use wait_for_commit to reply
mon: add context list for commit wait
mon: remove unused method
test/mon: add commit benchmark script
mon/MonClient: provide config to target specific rank

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>

doc/architecture: "Edit HA Auth" (one of several)

Edit "High Availability Authentication" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>

osd/scrub: modify schedule_result_t to report error class

(which directly translates to the required followup action)
instead of reporting the exact failure. The specific of the failure
were never used by the scrub scheduler.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: scheduler refactoring - cleanups

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

qa/cephfs: add "set -x" in mdtest.yaml

Set the flag for printing the commands that will be executed so that
it's easier to go through teuthology.log

Signed-off-by: Rishabh Dave <ridave@redhat.com>

qa/cephfs: fix build failure for mdtest project

To fix the mdtest job failure (which happens because building mdtest
project fails) do -

1. Use ior projects intead of mdtest project bcecause latter was merged
   into former. See:
   https://github.com/MDTEST-LANL/mdtest/blob/master/README.md

2. Purge mpich package and then install it again. This is a vital step
   that's needed to build ior project on Ubuntu 22.04.

Fixes: https://tracker.ceph.com/issues/61574
Signed-off-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #52863 from batrick/i62326

pybind/mgr/cephadm/upgrade: stop disabling FSMap sanity checks

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

osd/scrub: scheduler: removing unused code

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: correct placement for some scheduler-related methods

Moving some member functions to their corresponding files.
Including ScrubQueue::dump_scrubs()
as it was moved in a previous commit,
and some ScrubJob code.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #53501 from zhscn/wip-lba-backref-node-size

crimson/os/seastore: create page aligned bufferptr in copy ctor of CachedExtent

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #52150 from paulreece42/wip-grafana-quorum-fix

monitoring: grafana mons out of quorum should be count - sum

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge PR #53028 into main

* refs/pull/53028/head:
Update MDSDaemon.cc
Update MDSRank.cc - Logoutput: Fix personal pronoun "I" to uppercase

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #53176 into main

* refs/pull/53176/head:
doc: add note for removing (automatic) partitioning policy

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>

Merge pull request #53467 from phlogistonjohn/jjm-cephadm-move-get_data_dir

cephadm: move get data dir function to daemonidentity method

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #53415 from rkachach/fix_issue_62814

cephadm: fix cephadm binary mount when --shared_ceph_folder is used

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #53298 from phlogistonjohn/jjm-logging-2

cephadm: enhance logging behavior

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #52251 from rkachach/fix_issue_61856

mgr/cephadm: Adding sort-by support for ceph orch ps

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #52982 from batrick/backport-cp-simplify

script/ceph-backport: perform cherry-pick in single command

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge PR #53145 into main

* refs/pull/53145/head:
mds: log message when exiting due to asok command

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge PR #53149 into main

* refs/pull/53149/head:
qa: lengthen shutdown timeout for thrashed MDS

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

doc: add note for removing (automatic) partitioning policy

Signed-off-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #53309 from guits/bz2203397

ceph-volume: fix mpath device support

osd/scrub: handle configuration changes in OsdScrub

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: move initiate_a_scrub() to OsdScrub

Scrub initiation is now fully owned by OsdScrub.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: add ScrubQueue::ready_to_scrub()

At this phase of the refactoring:
this is the main interface from the scrub scheduler in OsdScrub
to the ScrubQueue. The ScrubQueue provides the ordered list of
all targets (for now - PGs) that are ready for scrubbing.

Scrub initiation code is modified to use the new interface.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: move scrub_sleep_time() to OsdScrub

also scrub_time_permit().

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: extract restrictions_on_scrubbing()

from ScrubQueue::select_pg_and_scrub().

Clearing the path to moving some ScrubQueue methods into
OscScrub. Starting here with the CPU load tracker.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: introduce OsdService::get_locked_pg()

which returns an RAII-wrapper around a locked PG.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: move OSD::sched_scrub() to OsdScrub

... (as OsdScrub::initiate_scrub()).

The random backoff dice roller (scrub_random_backoff())
is moved as well.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: declare OsdScrub, an OSD subobject

for all OSD scrub things.

For now: OsdScrub is mostly a forwarder to the ScrubQueue object
(which it now owns).
The resource counters moved into a separate object within OsdScrub.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: unify dout macros across scrub scheduling code

to facilitate easy migration of code fragments between
related classes.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: complete ScrubJob transition from within ScrubQueue

ScrubJob is now in the Scrub namespace.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: set_reserving_now() signature modified

set_reserving_now() can now return a failure status, indicating
a race between two PGs to start scrubbing on the same OSD.

The scrubber FSM is modified to handle the failure.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: select_pg_and_scrub() moved into osd_scrub.cc

No code changes.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: renaming & fmt support for restrictions structure

Renaming ScrubPreconds, the collection of "environmental"
restrictions on possible scrubs, to OSDRestrictions.
Also - providing fmtlib support for that structure.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: introducing random_bool_with_probability()

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: moving the resources counters code into a separate file

No code changes in this commit.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: moving code as-is into osd_scrub.cc

Code from OSD.cc & osd_scrub_sched.cc moved as-is,
to be modified in followup commits.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: moving ScrubJob declaration as-is

from osd_scrub_sched.h into scrub_job.h.

A purely mechanical step. No code is changed.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

crimson/os/seastore: create page aligned bufferptr in copy ctor of CachedExtent

Signed-off-by: Zhang Song <zhangsong02@qianxin.com>

doc/cephadm: document new cephadm logging destination settings

Add docs for setting the binary's log destination at cephadm bootstrap
or on a running cluster.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

doc/cephadm: clarify what cephadm component writes to the cluster log channel

Clarify that the cephadm orchestrator module, a part of the ceph mgr,
logs to the cluster log channel. This prepares for adding a specific
section to cover logging for the cephadm "binary".

Signed-off-by: John Mulligan <jmulligan@redhat.com>

cephadm: remember log destination used during bootstrap

Store the log destination(s) specified on the CLI for cephadm bootstrap
as the manager configuration, unless the configuration key is explicitly
set by the input config.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

mgr/cephadm: add a module option for controlling cephadm log dest

Now that cephadm has multiple possible persistent logging destinations
we need a way to choose which one to use when the command is started by
the mgr. Add the option 'cephadm_log_destination' which can take one
of 'file', 'syslog', or 'file,syslog'. If left unset (empty string)
then the behavior is equivalent to 'file' and that is the same as
previous cephadm versions.

Fixes: https://tracker.ceph.com/issues/62233
Signed-off-by: John Mulligan <jmulligan@redhat.com>

cephadm: add cli option to enable logging to syslog

Add the --log-dest option to cephadm. The --log-dest option can be
specified 0, 1 or more times. If unspecified, cephadm will log to
the default location, the log file. If specified one ore more times,
each instance will enable the named logging destination.
Example:

```
cephadm boostrap

cephadm --log-dest=syslog bootstrap

cephadm --log-dest=file bootstrap

cephadm --log-dest=syslog --log-dest=file bootstrap
```

Signed-off-by: John Mulligan <jmulligan@redhat.com>

cephadm: add support for logging to syslog/journal

Add support to logging.py for persistent logging to syslog and thus to
journald. This is accomplished by switching logging handlers depending
on the log_dest attribute of the context. Setting this value is left
for a future patch.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

cephadm: move colored output support into logging.py

Rewrite cephadm's colored output support such that it abstracts away
the colorization into extra logging metadata. The new code will not
unconditionally put control characters into the log files. It will
only print the control chars if the stderr is a tty.
In theory this is probably more future proof as well, but it's only
got two callers so it is hard to say how useful it'll be.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

rgw/crypt: don't deref null manifest_bl

with dbstore, the manifest_bl pointer was null; check for null before
dereferencing for read_manifest_parts()

Fixes: https://tracker.ceph.com/issues/62378
Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #51921 from kamoltat/wip-ksirivad-fix-54136

pybind/mgr/pg_autoscaler: Use bytes_used for actual_raw_used
Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>

Merge pull request #53532 from zdover23/wip-doc-2023-09-19-man-ceph-monstore-tool

doc/man: s/kvstore-tool/monstore-tool/

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

doc/man: s/kvstore-tool/monstore-tool/

s/kvstore-tool/monstore-tool/ in accordance with Ilya's remark here:
https://github.com/ceph/ceph/pull/53450#discussion_r1329804085

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #53411 from rhcs-dashboard/align-charts

mgr/dashboard: align charts of landing page

Reviewed-by: Nizamudeen A <nia@redhat.com>

ceph-volume: fix mpath device support

commit [1] broke mpath devices support in `disk.is_device()`

[1] https://github.com/ceph/ceph/commit/4fc6bc394dffaf3ad375ff29cbb0a3eb9e4dbefc

Fixes: https://tracker.ceph.com/issues/62722
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>

Merge pull request #53230 from myoungwon/fix-cbj-overflow-bug

crimson/os/seastore/cbj: fix a potential overflow bug on segment_seq

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

Merge PR #52631 into main

* refs/pull/52631/head:
mds: add debug logs to monitor ceph.dir.subvolume management
mds: dump subvolume flag for inode

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #52892 into main

* refs/pull/52892/head:
qa: add test to validate periodic checks by async threads
mgr/volumes: periodically check for async work

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>

Merge PR #52755 into main

* refs/pull/52755/head:
mds: adjust pre_segments_size for MDLog when trimming segments for standby-replay

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge PR #52692 into main

* refs/pull/52692/head:
qa/tasks/cephfs: reset the client_inject_fixed_oldest_tid after test

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #53518 from likid0/patch-2

doc/dev: Fix typos in cephfs-mirroring.rst and  deduplication.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/dev: Fix typos in files cephfs-mirroring.rst and deduplication.rst

Typo Error in Doc cephfs-mirroring.rst , replace RAODS with RADOS
Typo Error in Doc deduplication.rst , replace RAODS with RADOS

Signed-off-by: Daniel Parkes <dparkes@redhat.com>

Merge pull request #53502 from dang/wip-dang-cls-test

RGW - Fix cls test build on new gcc

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #53508 from dang/wip-dang-posix-cache

RGW - Add wait backoff to posix bucket cache test

Reviewed-by Matt Benjamin <mbenjamin@redhat.com>

RGW - Add wait backoff to posix bucket cache test

The CI appears to be really slow, and even a second of wait for inotify
sometimes fails.  Add an exponential backoff wait of up to ~25 seconds
to hopefully make the test pass reliably.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

rgw/sal: get_placement_target_names() returns void

the function returned an integer error code, but two callers were
incorrectly testing the return value as a boolean

the function just returns placement ids that are in-memory, so none of
the drivers have a failure case; change the return value to void

Fixes: https://tracker.ceph.com/issues/62771
Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #53478 from EdwardVitor/cuiming_chinamobile

auth:rectify a cmake compilation warning

Reviewed-by: Casey Bodley <cbodley@redhat.com>

RGW - Fix cls test build on new gcc

The new encoder types broke building the cls test on newer gcc (13+) due
to undefined encoder/decoder.  Add the file that defines those to the
test.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Merge PR #53175 into main

* refs/pull/53175/head:
qa: increase the http postBuffer size and disable sslVerify

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

auth:rectify a cmake compilation warning

rectify src/auth/cephx/CephxProtocol.cc 1 warning
with the variable 'ch' Used before initialized
auth/cephx/CephxProtocol.cc:595:57: warning: '*((void*)& ch +8)' may be used uninitialized in this function [-Wmaybe-uninitialized]
     msg.server_challenge_plus_one = ch.server_challenge + 1;
                                     ~~~~~~~~~~~~~~~~~~~~^~~

Signed-off-by: cuiming <cuiming_yewu@cmss.chinamobile.com>

Merge pull request #53490 from zdover23/wip-doc-2023-09-17-architecture-6-of-x

doc/architecture: "Edit HA Auth" (one of several)

doc/architecture: "Edit HA Auth" (one of several)

Edit "High Availability Authentication" in doc/architecture.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #53487 from zdover23/wip-doc-2023-09-16-architecture-5-of-x

doc/architecture: Edit "HA Auth"

doc/architecture: Edit "HA Auth"

Edit "High Availability Authentication" in doc/architecture.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>