Merge pull request #56732 from mchangir/mgr-snap_schedule-restore-yearly-spec-from-Y-to-y

mgr/snap_schedule: restore yearly spec to lowercase y

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #56065 from rishabh-d-dave/mds-counters

mds: don't add counters in warning for standby-replay MDS

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #56066 from rishabh-d-dave/mds-fail-confirm

mon,cephfs: require confirmation flag to bring down unhealthy MDS

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #56981 from lxbsz/wip-65563

mds: remove the incorrect std::move for fsname and path

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #57145 from ktdreyer/rm-dashboard-werkzeug

ceph.spec.in: ceph-mgr-dashboard does not require werkzeug

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #56579 from rhcs-dashboard/fix-alerts-verison-compatability-multi-cluster

mgr/dashboard: Filter alerts based on cluster fsid and do not allow to connect clusters with version less than hub cluster in multi-cluster

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #57004 from kchheda3/wip-fix-retry

rgw/multisite-notification: retry storing bucket notification attrs for ECANCELED(ConcurrentModification) errors.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>

Merge PR #57207 into main

* refs/pull/57207/head:
doc/rados: s/cepgsqlite/cephsqlite/

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>

Merge pull request #57143 from adk3798/nvmeof-osd-profile-rbd

mgr/cephadm: set OSD cap for NVMEoF daemon to "profile rbd"

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #56575 from cloudbehl/ceph-cluster-json-update

monitoring/ceph-mixin: Add cluster variable to ceph-cluster.json

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #55495 from frittentheke/issue_64321

monitoring/ceph-mixin: Cleanup of variables, queries and tests (to fix showMultiCluster=True)

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #57151 from rhcs-dashboard/fix-65698-main

mgr/dashboard: exclude cloned-deleted RBD snaps

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/rados: s/cepgsqlite/cephsqlite/

As stated in the commit-message line, this corrects the typo "cepg" to
the correct string "ceph".

This typo was discovered by https://github.com/test-erik and this was
brought to our attention way back in
https://github.com/ceph/ceph/pull/50420.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge PR #57183 into main

* refs/pull/57183/head:
script/ptl-tool: add switch to update existing qa ticket

Reviewed-by: Yuri Weinstein <yweins@redhat.com>

Merge PR #57059 into main

* refs/pull/57059/head:
mds: do not try fragmenting or exporting a quiesced directory
mds: set/test ALL_LOCKED on fragment_dir request
mds: pass bypassfreezing to parent auth pin req
qa: add quiesce tests during fragmentation
qa: translate empty output from rank_tell to empty dict
qa: move reqid_tostr helper

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>

Merge pull request #57102 from xxhdx1985126/wip-65672

crimson/osd/osdop_params:Unify OpsExecuter::user_modify and osd_op_params_t::user_modify

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #56995 from athanatos/sjust/wip-65185-scrub-attr-error

osd: only call stat/getattrs once per object during deep-scrub

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge PR #56997 into main

* refs/pull/56997/head:
pybind/mgr: disable sqlite3/python autocommit
qa/tasks/mgr: add tests for sqlite autocommit
qa/tasks/vstart_runner: run daemons in foreground
qa/tasks/vstart_runner: add missing poll method
qa/suites/rados/mgr: add cli/devicehealth tasks
qa: reorganize mgr unit tests
qa: use position-independent link
qa: add missing terminating newline
pybind/mgr: add killpoint for sqlite3 database setup
mgr: allow specifying module option level
mon/MgrMonitor: promote standby when unsetting down flag
mon/MgrMonitor: only drop active if exists

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #57144 from adk3798/stray-laundry

qa/cephadm: ignore stray daemon warning during rados_api_tests

Reviewed-by: Laura Flores <lflores@ibm.com>

Merge pull request #56961 from adk3798/agent-check-error-before-json

cephadm: have agent check for errors before json loading mgr response

Reviewed-by: <mfritch@suse.com>

Merge pull request #56933 from adk3798/service-size-cleanup

mgr/cephadm: cleanup service size logic block

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #56928 from adk3798/grafana-anon-access-dropped

python-common: handle "anonymous_access: false" in to_json of Grafana spec

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #56350 from phlogistonjohn/jjm-mgr-smb-module

mgr: add a new smb cluster & share module

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #56817 from guits/cephadm-check-apply-spec-file

cephadm: check if file exists when passing `--apply_spec`

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #56487 from adk3798/bootstrap-custom-alerts

cephadm: allow passing custom prometheus alerts to bootstrap

Reviewed-by: John Mulligan <jmulligan@redhat.com>

script/ptl-tool: add switch to update existing qa ticket

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

mgr/dashboard: exclude cloned-deleted RBD snaps

Fixes: https://tracker.ceph.com/issues/65698
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

Merge PR #57044 into main

* refs/pull/57044/head:
qa: increase debugging for snap_schedule

Reviewed-by: Milind Changire <mchangir@redhat.com>

Merge PR #57043 into main

* refs/pull/57043/head:
client: clear resend_mds only after sending request

Reviewed-by: Milind Changire <mchangir@redhat.com>

Merge PR #57020 into main

* refs/pull/57020/head:
mds/cache: don't assume non-auth xlocks to be remote locks

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>

Merge PR #56935 into main

* refs/pull/56935/head:
mds: encode flags for all inode types
qa: test file inode with F_QUIESCE_BLOCK is replicated

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>

Merge PR #56934 into main

* refs/pull/56934/head:
mds: move drop_locks to directly after rdonly check
qa: test quiesce.block is replicated
qa: test that ceph.dir.subvolume is replicated properly
mds: add debug "lock path" command
qa: move reqid_tostr helper
qa: return run_shell process for waiters

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>

Merge PR #56923 into main

* refs/pull/56923/head:
qa: extend rank 1 lockup for test_quiesce_authpin_wait

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>

Merge pull request #57148 from zdover23/wip-doc-2024-04-30-cephadm-services-monitoring

doc/cephadm: add default monitor images

ceph.spec.in: ceph-mgr-dashboard does not require werkzeug

Nothing in the dashboard codebase imports werkzeug. It appears this was
leftover from the time when the dashboard was packaged with the rest of
the mgr modules.

Fixes: https://tracker.ceph.com/issues/65693
Signed-off-by: Ken Dreyer <kdreyer@ibm.com>

Merge pull request #57153 from rkhudov/doc-man-8-radosgw-admin_add-get-lifecycle-config-command

doc/man/8/radosgw-admin: add get lifecycle command

Reviewed-by: Zac Dover <zac.dover@proton.me>

Merge pull request #57154 from cityofships/main

doc/rados/operations: rephrase OSDs peering

Reviewed-by: Zac Dover <zac.dover@proton.me>

Merge pull request #55978 from xxhdx1985126/wip-librbd-unittest-sparsify

test/librbd/test_internal: change to check for 4KB-aligned sparse read

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

doc/rados/operations: rephrase OSDs peering

Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>

Merge pull request #55823 from ceph/wip-lusov-quiescer

qa: cephfs quiesce thrasher

doc/man/8/radosgw-admin: add get lifecycle command

Signed-off-by: rkhudov <rhudov@gmail.com>

Merge pull request #56806 from xxhdx1985126/wip-65399

crimson/osd/pg_recovery: backoff if the recovery/backfill is deferred

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #56998 from xxhdx1985126/wip-65568

crimson/osd/pg: only kick off snap trimming when PGs are clean

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #57128 from cyx1231st/wip-fix-ut-seastore-timeout

crimson/os/seastore: misc cleanups and fixes

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>

doc/cephadm: add default monitor images

Add a list of default monitor images to the documentation. This commit
is made in response to a request from Eugen Block, and is made using the
information developed by Mr Block here:
https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/thread/QGC66QIFBKRTPZAQMQEYFXOGZJ7RLWBN/.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #56892 from xxhdx1985126/wip-crimson-urgent-recovery-version

crimson/osd/osd_operations/client_request: retrieve the correct version for objects to be recovered urgently

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #56610 from Matan-B/wip-matanb-crimson-replicated-head-obc

crimson/osd/replicated_recovery_backend: Fix recovery obc usage

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge pull request #57135 from xxhdx1985126/wip-seastore-checksum-assertion-fix

crimson/os/seastore/transaction_manager: remove incorrect assertions

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #57129 from xxhdx1985126/wip-65585

crimson/os/seastore/transaction_manager: fix write pipeline phase leak

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

mds: do not try fragmenting or exporting a quiesced directory

And handle inode becoming quiesced after op is created.

Fixes: https://tracker.ceph.com/issues/65603
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

mds: set/test ALL_LOCKED on fragment_dir request

This is an optimization to obviate repeated calls to acquire_locks.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

mds: pass bypassfreezing to parent auth pin req

Credit to Leonid for first noticing this.

Fixes: https://tracker.ceph.com/issues/65603
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa: add quiesce tests during fragmentation

Reproduces: https://tracker.ceph.com/issues/65603
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa/suites/fs: add quiescer to the fs suite

Signed-off-by: Leonid Usov <leonid.usov@ibm.com>

qa/tasks: the quiescer task and a waiter task to test it

Fixes: https://tracker.ceph.com/issues/63669
Signed-off-by: Leonid Usov <leonid.usov@ibm.com>

qa: translate empty output from rank_tell to empty dict

Not all commands return JSON, like `dirfrag split`.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa: move reqid_tostr helper

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

pybind/mgr: disable sqlite3/python autocommit

SQLite3 and python's binding were both committing transactions at unintended
points. Turn it off and stop using executescript.

Fixes: https://tracker.ceph.com/issues/65494
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa/tasks/mgr: add tests for sqlite autocommit

That autocommit is properly turned off and that commits via context managers
work as expected.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa/cephadm: ignore stray daemon warning during rados_api_tests

The "stray daemon" that is getting logged about in this test is
from "stray daemon laundry.pid70383 on host smithi027 not managed by cephadm".
It seems the rados_api_tests is creating some additional "laundry" entity
during these tests that gets reported as an actual daemon in the mgr,
but cephadm is unaware of it, resulting in the warning. Originally
we thought to maybe add "laundry" itself to the ignorelist, but
without an additional patch that added extra logging for debug
purposes (which can't be merged) the log statement found in
the logs due to this problem will not say what daemon it found
to be stray. There will just be a generic warning about a stray
daemon. In a real cluster, a user would then check "ceph health detail"
to find out what daemon is stray, but the log scraper can't do this
and just fails the test due to the presence of the warning.

Signed-off-by: Adam King <adking@redhat.com>

mgr/cephadm: set OSD cap for NVMEoF daemon to "profile rbd"

Otherwise it is impossible to make rbd snapshots

Fixes: https://tracker.ceph.com/issues/65691
Signed-off-by: Adam King <adking@redhat.com>

qa/tasks/vstart_runner: run daemons in foreground

This mirrors teuthology and makes it possible to check the exit status of a
daemon.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa/tasks/vstart_runner: add missing poll method

Otherwise you cannot use LocalDaemon.check_status.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa/suites/rados/mgr: add cli/devicehealth tasks

These should have been part of the commit adding the tests.

Fixes: 9ebcbdbed0fbaf37d60fbd8db321742ee5721d8c
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa: reorganize mgr unit tests

Refactor common tasks and allow loading mgrmodules before unittests start.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa: use position-independent link

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa: add missing terminating newline

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

pybind/mgr: add killpoint for sqlite3 database setup

To catch unintentional autocommit by sqlite3.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

mgr: allow specifying module option level

Some are for development purposes and should be filtered out by the dashboard.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

mon/MgrMonitor: promote standby when unsetting down flag

In the same epoch, to simplify testing.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

mon/MgrMonitor: only drop active if exists

This avoids an assertion in ::drop_active.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #57136 from zdover23/wip-doc-2024-04-29-radosgw-bucketpolicy

doc/radosgw: disambiguate version-added remarks

doc/radosgw: disambiguate version-added remarks

Rewrite two sentences so that they explain precisely what was added to
Ceph and when it was added to Ceph.

This commit is made in response to a request made by Dr Per Mildner on
https://pad.ceph.com/p/Report_Documentation_Bugs.

Signed-off-by: Zac Dover <zac.dover@proton.me>

crimson/osd/osd_operation: yield the cpu before another round the
"with_throttle"

This is to avoid infinite recursive calling to "with_throttle_while"

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>

crimson/osd/pg_recovery: backoff if the recovery/backfill is deferred

Fixes: https://tracker.ceph.com/issues/65399
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

crimson/os/seastore: drop the impossible error eagain

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/extent_placement_manager: make reserve and block atomic

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: improve seastore_t logs

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/transaction_manager: remove incorrect assertions

Indirect mappings always hold the checksums of the corresponding intermediate
mappings, which may have non-zero

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

crimson/os/seastore: add logs for background

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

test/crimson/gtest_seastar: add logs

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

test/crimson/gtest_seastar: cleanups

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #55449 from xxhdx1985126/wip-seastore-extent-chksum

crimson/os/seastore: support extent checksum verification

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

crimson/os/seastore/transaction_manager: fix write pipeline phase leak

At present, if a transaction gets interrupted right after it enters
WritePipeline::ReserveProjectedUsage and before any later continuations
get executed, WritePipeline::ReserveProjectedUsage will be locked
forever.

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge pull request #57088 from xxhdx1985126/wip-seastore-update-onode-size

crimson/os/seastore: only update onode sizes when necessary

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #57118 from xxhdx1985126/wip-65673

test/ceph_crypto: define __has_feature if the compiler doesn't have it

Reviewed-by: Kefu Chai <kefu.chai@scylladb.com>

Merge pull request #57119 from zdover23/wip-doc-2024-04-28-cephfs-client-auth

doc/cephfs: edit front matter in client-auth.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephfs: edit front matter in client-auth.rst

Clarify the front matter in doc/cephfs/client-auth.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #57112 from tchaikov/erasure-code-free

erasure-code/shec: use free() to release alloc()'ed memory chunk

Reviewed-by: Rongqi Sun <sunrongqi@huawei.com>

Merge pull request #57113 from tchaikov/erasure-code-free-crush-wrapper

test//erasure-code/TestErasureCodeLrc: free allocated CrushWrapper

Reviewed-by: Rongqi Sun <sunrongqi@huawei.com>

Merge pull request #57111 from tchaikov/erasure-code-nullptr

erasure-code/shec: replace 0 with nullptr when appropriate

Reviewed-by: Rongqi Sun <sunrongqi@huawei.com>

crimson/osd/osdop_params:Unify OpsExecuter::user_modify and osd_op_params_t::user_modify

Before this change OpsExecuter::user_modify was maintained in OpsExecuter::do_write_op.
However, osd_op_params->user_modify was not updated when used in OpsExecuter::prepare_transaction

Fixes: https://tracker.ceph.com/issues/65672
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>

crimson/osd/pg: SnapTrimEvent to support interrupts

SnapTrimEvent operations are scheduled from `PG::on_active_actmap()`
using a `seastar::do_until` loop. This commit replaces the loop type
into an `interruptor::repeat` and SnapTrimEvent are now scheduled by
`start_operation_may_interrupt`.

Previously, `SnapTrimEvent::start` handled interruptions by returning
a `crimson::ct_error::eagain::make();`. Now, the errorator is directly
returned via the `snap_trim_event_ret_t` and interrupts the loop
described above.

As a result, interruptions originated by interval changes are now
supported by SnapTrimEvent.

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

test/ceph_crypto: define __has_feature if the compiler doesn't have it

Refer to https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005ffeature.html
and https://clang.llvm.org/docs/LanguageExtensions.html#has-feature-and-has-extension
for further information

Fixes: https://tracker.ceph.com/issues/65673
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

test//erasure-code/TestErasureCodeLrc: free allocated CrushWrapper

in TestErasureCodeLrc.cc, we create a `CrushWrapper` without
destroying and freeing it. and ASan points this out:
```
Indirect leak of 72000 byte(s) in 1000 object(s) allocated from:
    #0 0x559e00acc2bd in operator new(unsigned long) (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_erasure_code_lrc+0x1ed2bd) (BuildId: 1cd93d0f231006242239eb0d81a8d677e36aeba2)
    #1 0x559e00b2bb76 in __gnu_cxx::new_allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >::allocate(unsigned long, void const*) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:127:27
    #2 0x559e00b2bb00 in std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >::allocate(unsigned long) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/allocator.h:185:32
    #3 0x559e00b2bb00 in std::allocator_traits<std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > > >::allocate(std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >&, unsigned long) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/alloc_traits.h:464:20
    #4 0x559e00b2b9d1 in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >::_M_get_node() /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_tree.h:561:16
    #5 0x559e00b2aae4 in std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> >* std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >::_M_create_node<std::piecewise_construct_t const&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&>, std::tuple<> >(std::piecewise_construct_t const&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&>&&, std::tuple<>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_tree.h:611:23
    #6 0x559e00b29520 in std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >::_M_emplace_hint_unique<std::piecewise_construct_t const&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&>, std::tuple<> >(std::_Rb_tree_const_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> >, std::piecewise_construct_t const&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&>&&, std::tuple<>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_tree.h:2431:19
    #7 0x559e00b255c2 in std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >::operator[](std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_map.h:501:15
    #8 0x559e00b188da in CrushWrapper::set_item_name(int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/jenkins-build/build/workspace/ceph-pull-requests/src/crush/CrushWrapper.h:466:7
    #9 0x7feb54a4dcc2 in CrushWrapper::insert_item(ceph::common::CephContext*, int, float, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&, bool) /home/jenkins-build/build/workspace/ceph-pull-requests/src/crush/CrushWrapper.cc:1119:5
    #10 0x559e00ada922 in ErasureCodeTest_create_rule_Test::TestBody() /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/erasure-code/TestErasureCodeLrc.cc:127:5
    #11 0x559e00c0e0a6 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2605:10
```

so, in this change, let's manage the lifecycle of the `CrushWrapper`
instance with a smart pointer, so that it is destroyed and free'd
properly, and this should silence the ASan warning.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

erasure-code/shec: use free() to release alloc()'ed memory chunk

ASan warns
```
==445793==ERROR: AddressSanitizer: alloc-dealloc-mismatch (malloc vs operator delete) on 0x602000039b10
    #0 0x5604a544112d in operator delete(void*) (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_erasure_code_shec_all+0x1e012d) (BuildId: 8cfc74d22471b6905f9b23304aed2af945265a13)
    #1 0x7fc14752f588 in ErasureCodeShecTableCache::~ErasureCodeShecTableCache() /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/shec/ErasureCodeShecTableCache.cc:61:19
    #2 0x5604a544ccbe in ParameterTest_parameter_all_Test::TestBody() /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/erasure-code/TestErasureCodeShec_all.cc:263:1
...
0x602000039b10 is located 0 bytes inside of 4-byte region [0x602000039b10,0x602000039b14)
allocated by thread T0 here:
    #0 0x5604a5405afe in malloc (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_erasure_code_shec_all+0x1a4afe) (BuildId: 8cfc74d22471b6905f9b23304aed2af945265a13)
    #1 0x7fc1474c9617 in reed_sol_vandermonde_coding_matrix /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/jerasure/jerasure/src/reed_sol.c:86:10
    #2 0x7fc147528634 in ErasureCodeShec::shec_reedsolomon_coding_matrix(int) /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/shec/ErasureCodeShec.cc:514:12
    #3 0x7fc147526cd8 in ErasureCodeShecReedSolomonVandermonde::prepare() /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/shec/ErasureCodeShec.cc:390:14
    #4 0x7fc1475187aa in ErasureCodeShec::init(std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&, std::ostream*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/shec/ErasureCodeShec.cc:57:3
```

where we use `delete` to free the encoder matrix allocated using
`malloc()`. as jerasure is a library implemented in C language,
unless we want to reimplment it in C++, we should use `free()` to
free the memory chunk allocated by
`reed_sol_vandermonde_coding_matrix()`. also, please note,
jerasure does not provide a function to free the memory allocated
by this function, we have to explore its implementation, and use
`malloc()` directly. this should silence the ASan warning.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

erasure-code/shec: replace 0 with nullptr when appropriate

0 fails to send the message to human readers that the variable is
a pointer, but nullptr does. for improving the readability, let's
use nullptr when the variable in question is a pointer.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #57105 from zdover23/wip-doc-2024-04-26-mgr-dashboard

doc/mgr: explain error message - dashboard.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/mgr: explain error message - dashboard.rst

Explain that an error message received in response to
"redirect_resolve_ip_addr True" might be caused by having an
insufficiently recent release of Ceph running in your cluster.

Fixes: https://tracker.ceph.com/issues/61312
Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #52024 from lxbsz/wip-61660

mds: fix the description for inotable testing only options

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>