]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
11 months agolibrbd/migration/NativeFormat: refactor source spec parsing
Ilya Dryomov [Wed, 17 Jul 2024 19:11:51 +0000 (21:11 +0200)]
librbd/migration/NativeFormat: refactor source spec parsing

In preparation for not instantiating NativeFormat and losing a copy of
the source spec JSON object in m_json_object, refactor the parsing code
to use only const methods (which std::map's operator[] isn't) and local
variables where possible.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
11 months agolibrbd/migration/NativeFormat: do pool lookup instead of creating io_ctx
Ilya Dryomov [Wed, 17 Jul 2024 18:05:08 +0000 (20:05 +0200)]
librbd/migration/NativeFormat: do pool lookup instead of creating io_ctx

A Rados instance is sufficient to map the pool name to the pool ID,
no need to involve an IoCtx instance as well.  While at it, report
distinctive errors for a non-existing pool and an invalid JSON value
for pool_name key cases.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
11 months agolibrbd/migration: make SourceSpecBuilder::parse_source_spec() static
Ilya Dryomov [Wed, 17 Jul 2024 13:06:33 +0000 (15:06 +0200)]
librbd/migration: make SourceSpecBuilder::parse_source_spec() static

In preparation for divorcing NativeFormat from FormatInterface and
changing when/how src_image_ctx is created, make parse_source_spec()
independent of src_image_ctx.  The "invalid source-spec JSON" error is
duplicated by the "failed to parse migration source-spec" error, so
just get rid of the former to spare having to pass CephContext to
parse_source_spec().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
11 months agolibrbd/migration/OpenSourceImageRequest: rename io_ctx -> dst_io_ctx
Ilya Dryomov [Tue, 30 Jul 2024 20:56:17 +0000 (22:56 +0200)]
librbd/migration/OpenSourceImageRequest: rename io_ctx -> dst_io_ctx

For now, this is just slightly clearer.  The distinction would become
important with planned support for migrating from external clusters.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
11 months agolibrbd/migration: massage some error messages
Ilya Dryomov [Sun, 14 Jul 2024 17:48:33 +0000 (19:48 +0200)]
librbd/migration: massage some error messages

Add missing spaces, don't use the word stream when reporting errors
on POSIX file operations (open() and lseek64()) and fix a cut-and-paste
typo in RawSnapshot.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
11 months agolibrbd/api: clean up leftovers in Migration::prepare_import()
Ilya Dryomov [Sun, 14 Jul 2024 17:21:47 +0000 (19:21 +0200)]
librbd/api: clean up leftovers in Migration::prepare_import()

Dead code after return and an unused variable.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
11 months agoMerge pull request #58800 from ljflores/wip-update-crontab
Laura Flores [Tue, 30 Jul 2024 03:06:38 +0000 (22:06 -0500)]
Merge pull request #58800 from ljflores/wip-update-crontab

qa/crontab: update frequency and priority for rados nightlies

11 months agoMerge pull request #58409 from baergj/upstream-fix-async-discard-on-start
Laura Flores [Mon, 29 Jul 2024 17:56:34 +0000 (12:56 -0500)]
Merge pull request #58409 from baergj/upstream-fix-async-discard-on-start

blk/KernelDevice: React to bdev_enable_discard changes in handle_conf_change(); Fix several issues with stopping discard threads

11 months agoMerge pull request #58404 from NitzanMordhai/wip-nitzan-fix-corpus-forward_incompat...
Radoslaw Zarzynski [Mon, 29 Jul 2024 17:51:42 +0000 (19:51 +0200)]
Merge pull request #58404 from NitzanMordhai/wip-nitzan-fix-corpus-forward_incompat-cls_rgw_reshard_entry

corpus: update submodule with mark cls_rgw_reshard_entry forward_inco…

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
11 months agoMerge pull request #58904 from zdover23/wip-doc-2024-07-28-cephfs-multimds
Zac Dover [Mon, 29 Jul 2024 16:01:37 +0000 (02:01 +1000)]
Merge pull request #58904 from zdover23/wip-doc-2024-07-28-cephfs-multimds

doc/cephfs: edit "Dynamic Subtree Partitioning"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
11 months agodoc/cephfs: edit "Dynamic Subtree Partitioning" 58904/head
Zac Dover [Mon, 29 Jul 2024 11:17:44 +0000 (21:17 +1000)]
doc/cephfs: edit "Dynamic Subtree Partitioning"

Edit the section "Dynamic Subtree Partitioning" in
doc/cephfs/multimds.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
11 months agoMerge pull request #58588 from pereman2/remove-zone_adjustments
Igor Fedotov [Sun, 28 Jul 2024 17:33:01 +0000 (20:33 +0300)]
Merge pull request #58588 from pereman2/remove-zone_adjustments

os/bluestore: remove not used zone_adjustments

Reviewed-by: Adam Kupczyk akupczyk@ibm.com
Reviewed-by: Igor Fedotov igor.fedotov@croit.io
11 months agoMerge pull request #58884 from zdover23/wip-doc-2024-07-28-cephfs-client-auth
Anthony D'Atri [Sun, 28 Jul 2024 11:29:28 +0000 (07:29 -0400)]
Merge pull request #58884 from zdover23/wip-doc-2024-07-28-cephfs-client-auth

doc/cephfs: fix "OSD capabilities" link

11 months agoMerge pull request #58694 from xxhdx1985126/wip-crimson-fix-temp_contents
Matan Breizman [Sun, 28 Jul 2024 08:11:35 +0000 (11:11 +0300)]
Merge pull request #58694 from xxhdx1985126/wip-crimson-fix-temp_contents

crimson/osd/recovery_backend: cleanup PGBackend::temp_contents when pg interval changes

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
11 months agoMerge pull request #58592 from NitzanMordhai/wip-nitzan-crimson-mgr-client-lost-conne...
Matan Breizman [Sun, 28 Jul 2024 08:10:33 +0000 (11:10 +0300)]
Merge pull request #58592 from NitzanMordhai/wip-nitzan-crimson-mgr-client-lost-connection

mgr/client: validate connection before sending

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
11 months agoMerge pull request #58510 from sajibreadd/wip-61761
Matan Breizman [Sun, 28 Jul 2024 08:09:53 +0000 (11:09 +0300)]
Merge pull request #58510 from sajibreadd/wip-61761

crimson: PG stats are not synced between osds after object update

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
11 months agoMerge pull request #58504 from xxhdx1985126/wip-66885
Matan Breizman [Sun, 28 Jul 2024 08:09:03 +0000 (11:09 +0300)]
Merge pull request #58504 from xxhdx1985126/wip-66885

crimson/osd/pg_recovery: push the iteration forward after finding unfound objects when starting primary recoveries

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
11 months agoMerge pull request #58471 from guojidan/nullptr
Matan Breizman [Sun, 28 Jul 2024 08:08:06 +0000 (11:08 +0300)]
Merge pull request #58471 from guojidan/nullptr

src/crimson/osd/scrub: fix the null pointer error

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
11 months agodoc/cephfs: fix "OSD capabilities" link 58884/head
Zac Dover [Sun, 28 Jul 2024 07:27:53 +0000 (17:27 +1000)]
doc/cephfs: fix "OSD capabilities" link

Fix a broken link from the "OSD capabilites" reference on
doc/cephfs/client-auth.rst.

Fixes: https://tracker.ceph.com/issues/67218
Signed-off-by: Zac Dover <zac.dover@proton.me>
11 months agoMerge pull request #58205 from NitzanMordhai/wip-nitzan-rados-dashboard-test-update...
Yuri Weinstein [Fri, 26 Jul 2024 17:24:44 +0000 (10:24 -0700)]
Merge pull request #58205 from NitzanMordhai/wip-nitzan-rados-dashboard-test-update-ignorelist

suites: test should ignore osd_down warnings

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
11 months agoMerge pull request #58653 from phlogistonjohn/jjm-86-the-6
Adam King [Fri, 26 Jul 2024 15:43:54 +0000 (11:43 -0400)]
Merge pull request #58653 from phlogistonjohn/jjm-86-the-6

cephadm: do not hard code samba debuglevel 6

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anoop C S <anoopcs@cryptolab.net>
11 months agoMerge pull request #58867 from zdover23/wip-doc-2024-07-25-cephfs-client-auth-file...
Zac Dover [Fri, 26 Jul 2024 14:12:07 +0000 (00:12 +1000)]
Merge pull request #58867 from zdover23/wip-doc-2024-07-25-cephfs-client-auth-file-layouts-link

doc/cephfs: fix "file layouts" link

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
11 months agoMerge pull request #58641 from hualongfeng/qat_doc
Zac Dover [Fri, 26 Jul 2024 14:06:30 +0000 (00:06 +1000)]
Merge pull request #58641 from hualongfeng/qat_doc

doc/radosgw/qat-accel: Update and Add QATlib information

Reviewed-by: Zac Dover <zac.dover@proton.me>
11 months agodoc/radosgw/qat-accel: Update and Add QATlib information 58641/head
Feng, Hualong [Wed, 17 Jul 2024 06:53:32 +0000 (06:53 +0000)]
doc/radosgw/qat-accel: Update and Add QATlib information

Signed-off-by: Feng, Hualong <hualong.feng@intel.com>
11 months agoMerge pull request #58798 from cbodley/wip-common-async-spawn-throttle-spawn
Casey Bodley [Fri, 26 Jul 2024 13:17:58 +0000 (14:17 +0100)]
Merge pull request #58798 from cbodley/wip-common-async-spawn-throttle-spawn

common/async: spawn_throttle wraps call to asio::spawn()

Reviewed-by: Adam Emerson <aemerson@redhat.com>
11 months agoMerge pull request #58449 from cbodley/wip-rgw-gc-list-async
Casey Bodley [Fri, 26 Jul 2024 13:17:40 +0000 (14:17 +0100)]
Merge pull request #58449 from cbodley/wip-rgw-gc-list-async

cls/rgw: gc_list uses ObjectOperation instead of IoCtx

Reviewed-by: Adam Emerson <aemerson@redhat.com>
11 months agoMerge pull request #58046 from hualongfeng/wip_qat_zlib_data_format
Casey Bodley [Fri, 26 Jul 2024 13:14:39 +0000 (14:14 +0100)]
Merge pull request #58046 from hualongfeng/wip_qat_zlib_data_format

Compressor: Add data format(QZ_DEFLATE_GZIP_EXT) for QAT Zlib

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>
11 months agoMerge pull request #57546 from clwluvw/vault-token
Casey Bodley [Fri, 26 Jul 2024 13:12:57 +0000 (14:12 +0100)]
Merge pull request #57546 from clwluvw/vault-token

rgw: eliminate vault token perm for group read

Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
11 months agoMerge pull request #58689 from clwluvw/sse-c-policy
Casey Bodley [Fri, 26 Jul 2024 13:09:55 +0000 (14:09 +0100)]
Merge pull request #58689 from clwluvw/sse-c-policy

rgw: add support sse-c to bucket policy conditions

Reviewed-by: Casey Bodley <cbodley@redhat.com>
11 months agoMerge pull request #58534 from afreen23/wip-nvmeof-initiators
Nizamudeen A [Fri, 26 Jul 2024 11:40:51 +0000 (17:10 +0530)]
Merge pull request #58534 from afreen23/wip-nvmeof-initiators

mgr/dashboard: Add initiators

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
11 months agoMerge pull request #58844 from ceph/login-text-ui
Nizamudeen A [Fri, 26 Jul 2024 11:05:59 +0000 (16:35 +0530)]
Merge pull request #58844 from ceph/login-text-ui

mgr/dashboard: Changes for Sign out text to Login out

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
11 months agomgr/dashboard: Add initiators add/update in dashboard 58534/head
Afreen Misbah [Wed, 10 Jul 2024 11:24:20 +0000 (16:54 +0530)]
mgr/dashboard: Add initiators add/update in dashboard

Fixes  https://tracker.ceph.com/issues/66907

- add one or more initiators
- remove one or more initiators
- introduces two new UI routers for the above two

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
11 months agomgr/dashboard: Changes for Sign out text 58844/head
Prachi Goel [Thu, 25 Jul 2024 09:18:23 +0000 (14:48 +0530)]
mgr/dashboard: Changes for Sign out text

Fixes: https://tracker.ceph.com/issues/67075
Signed-off-by: Prachi Goel <prachi@li-f0e8f2cc-27e0-11b2-a85c-b2772164128d.ibm.com>
11 months agodoc/cephfs: fix "file layouts" link 58867/head
Zac Dover [Fri, 26 Jul 2024 07:15:12 +0000 (17:15 +1000)]
doc/cephfs: fix "file layouts" link

Fix a broken link to the "File Layouts" page on
doc/cephfs/client-auth.rst.

Fixes: https://tracker.ceph.com/issues/67190
Signed-off-by: Zac Dover <zac.dover@proton.me>
11 months agoMerge pull request #58722 from cbodley/wip-common-async-shared-mutex-impl
Casey Bodley [Thu, 25 Jul 2024 22:11:12 +0000 (23:11 +0100)]
Merge pull request #58722 from cbodley/wip-common-async-shared-mutex-impl

common/async: fix duplicate definition errors from SharedMutexImpl

Reviewed-by: Adam Emerson <aemerson@redhat.com>
11 months agoMerge pull request #58838 from idryomov/wip-rbd-lock-incompat-note
Ilya Dryomov [Thu, 25 Jul 2024 21:43:11 +0000 (23:43 +0200)]
Merge pull request #58838 from idryomov/wip-rbd-lock-incompat-note

doc/rbd/rbd-exclusive-locks: mention incompatibility with advisory locks

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>
11 months agodoc/rbd/rbd-exclusive-locks: mention incompatibility with advisory locks 58838/head
Ilya Dryomov [Thu, 25 Jul 2024 07:48:10 +0000 (09:48 +0200)]
doc/rbd/rbd-exclusive-locks: mention incompatibility with advisory locks

This is due to both using the same name for the lock at the RADOS level
("rbd_lock").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
11 months agoMerge pull request #58348 from cbodley/wip-async-co-algorithms
Casey Bodley [Thu, 25 Jul 2024 14:39:25 +0000 (15:39 +0100)]
Merge pull request #58348 from cbodley/wip-async-co-algorithms

common/async: add primitives for structured concurrency with c++20 coroutines

Reviewed-by: Adam Emerson <aemerson@redhat.com>
11 months agoMerge pull request #58686 from clwluvw/rgw-noprinc-allow
Casey Bodley [Thu, 25 Jul 2024 14:31:28 +0000 (15:31 +0100)]
Merge pull request #58686 from clwluvw/rgw-noprinc-allow

rgw: donot allow NotPrincipal with Allow Effect

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
11 months agoMerge pull request #58406 from mohit84/issue_42884
Yuri Weinstein [Thu, 25 Jul 2024 14:02:29 +0000 (07:02 -0700)]
Merge pull request #58406 from mohit84/issue_42884

test: Create ParallelPGMapper object before start threadpool

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
11 months agoMerge pull request #57223 from myoungwon/wip-rename-global-values-ceph-dedup-daemon
Yuri Weinstein [Thu, 25 Jul 2024 13:58:37 +0000 (06:58 -0700)]
Merge pull request #57223 from myoungwon/wip-rename-global-values-ceph-dedup-daemon

tool: renaming and refactoring global variables in ceph-dedup-daemon

Reviewed-by: Samuel Just <sjust@redhat.com>
11 months agocephadm: do not hard code samba debuglevel 6 58653/head
John Mulligan [Wed, 17 Jul 2024 20:53:14 +0000 (16:53 -0400)]
cephadm: do not hard code samba debuglevel 6

Remove the line hard-coding the samba debuglevel to 6. It is a leftover
from testing the early versions of the containers on ceph.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #58781 from idryomov/wip-67097
Ilya Dryomov [Thu, 25 Jul 2024 12:45:18 +0000 (14:45 +0200)]
Merge pull request #58781 from idryomov/wip-67097

qa/suites/krbd: stress test for recovering from watch errors for -o exclusive

Reviewed-by: Ramana Raja <rraja@redhat.com>
11 months agoMerge pull request #58766 from athanatos/sjust/wip-66294-collection-race
Matan Breizman [Thu, 25 Jul 2024 06:59:07 +0000 (09:59 +0300)]
Merge pull request #58766 from athanatos/sjust/wip-66294-collection-race

crimson: access coll_map under alien tp with a lock

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
11 months agoMerge pull request #58464 from athanatos/sjust/wip-66316-async-reserver
Matan Breizman [Thu, 25 Jul 2024 06:58:05 +0000 (09:58 +0300)]
Merge pull request #58464 from athanatos/sjust/wip-66316-async-reserver

crimson: peering event processing fixes,  wait for async operations started during peering events

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
11 months agoMerge pull request #57776 from rzarzynski/wip-bug-61948
Laura Flores [Wed, 24 Jul 2024 21:32:01 +0000 (16:32 -0500)]
Merge pull request #57776 from rzarzynski/wip-bug-61948

mon, osd, *: expose upmap-primary in OSDMap::get_features()

11 months agoqa/crontab: update frequency and priority for rados nightlies 58800/head
Laura Flores [Wed, 24 Jul 2024 21:16:40 +0000 (16:16 -0500)]
qa/crontab: update frequency and priority for rados nightlies

Although main rados nightlies are scheduled to run weekly, they
are so low in the queue that they take weeks to run, and when
they finally do, most of the jobs die (likely due to waiting in the
queue so long).

This commit increases the priority of main rados runs since
these are most important for debugging new failures. To compliment this
increase in priority, this commit also decreases the frequency of squid
rados runs from twice a week to once a week, since once is more than
enough. It also decreases the prioirity of squid runs.

Signed-off-by: Laura Flores <lflores@ibm.com>
11 months agoMerge pull request #56932 from ceph/wip-yuriw-release-18.2.3-main
Yuri Weinstein [Wed, 24 Jul 2024 21:11:31 +0000 (14:11 -0700)]
Merge pull request #56932 from ceph/wip-yuriw-release-18.2.3-main

doc: reef 18.2.4 release note

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
11 months agocommon/async: spawn_throttle wraps call to asio::spawn() 58798/head
Casey Bodley [Mon, 22 Jul 2024 20:48:29 +0000 (16:48 -0400)]
common/async: spawn_throttle wraps call to asio::spawn()

cancellation of the parent must immediately cancel its children, which
only works if the children are on the same executor as the parent

prohibit child coroutines from being spawned on a different executor by
wrapping the call to asio::spawn() in a new spawn_throttle::spawn()
interface

expose an overload for asio::spawn()'s optional StackAllocator argument

Signed-off-by: Casey Bodley <cbodley@redhat.com>
11 months agodoc/releases: add release note about thread creation incompatibility 56932/head
Laura Flores [Thu, 18 Jul 2024 22:50:17 +0000 (17:50 -0500)]
doc/releases: add release note about thread creation incompatibility

Signed-off-by: Laura Flores <lflores@ibm.com>
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
11 months agocommon/async: add parallel_for_each() algorithm 58348/head
Casey Bodley [Sun, 5 Feb 2023 22:08:49 +0000 (17:08 -0500)]
common/async: add parallel_for_each() algorithm

Signed-off-by: Casey Bodley <cbodley@redhat.com>
11 months agocommon/async: add co_spawn_group template for fork-join parallelism
Casey Bodley [Sun, 5 Feb 2023 15:10:34 +0000 (10:10 -0500)]
common/async: add co_spawn_group template for fork-join parallelism

Signed-off-by: Casey Bodley <cbodley@redhat.com>
11 months agocommon/async: implement max_concurrent_for_each() for awaitable
Casey Bodley [Thu, 27 Jun 2024 20:53:01 +0000 (16:53 -0400)]
common/async: implement max_concurrent_for_each() for awaitable

Signed-off-by: Casey Bodley <cbodley@redhat.com>
11 months agocommon/async: add co_throttle for bounded concurrency with c++20 coroutines
Casey Bodley [Wed, 11 Jan 2023 15:45:49 +0000 (10:45 -0500)]
common/async: add co_throttle for bounded concurrency with c++20 coroutines

Signed-off-by: Casey Bodley <cbodley@redhat.com>
11 months agoMerge pull request #58535 from anoopcs9/mgr-nfs-fix-export-create-conf-obj
Adam King [Wed, 24 Jul 2024 15:15:59 +0000 (11:15 -0400)]
Merge pull request #58535 from anoopcs9/mgr-nfs-fix-export-create-conf-obj

mgr/nfs: Do not ignore clusters from rados pool conf objects

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
11 months agoMerge pull request #58533 from rhcs-dashboard/shared-folder-pythonV
Adam King [Wed, 24 Jul 2024 15:13:53 +0000 (11:13 -0400)]
Merge pull request #58533 from rhcs-dashboard/shared-folder-pythonV

cephadm: update shared folder python packages dir

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #58153 from anoopcs9/modify-smb-dot-conf
Adam King [Wed, 24 Jul 2024 15:13:00 +0000 (11:13 -0400)]
Merge pull request #58153 from anoopcs9/modify-smb-dot-conf

mgr/smb: Make appropriate changes to global and share specific options

Reviewed-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #58670 from ivancich/wip-bolster-reshard-testing
J. Eric Ivancich [Wed, 24 Jul 2024 15:03:38 +0000 (11:03 -0400)]
Merge pull request #58670 from ivancich/wip-bolster-reshard-testing

test/rgw: address potential race condition in reshard testing

Reviewed-by: Casey Bodley <cbodley@redhat.com>
11 months agoMerge PR #58056 into main
Patrick Donnelly [Wed, 24 Jul 2024 14:18:58 +0000 (10:18 -0400)]
Merge PR #58056 into main

* refs/pull/58056/head:
qa: suppress __trans_list_add valgrind warning
qa: generate valgrind suppressions

Reviewed-by: Venky Shankar <vshankar@redhat.com>
11 months agoMerge pull request #58041 from vmackie/class-param-bug
Yuri Weinstein [Wed, 24 Jul 2024 13:40:42 +0000 (06:40 -0700)]
Merge pull request #58041 from vmackie/class-param-bug

mon: fix inconsistencies in class param

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
11 months agoMerge PR #58768 into main
Patrick Donnelly [Wed, 24 Jul 2024 13:03:39 +0000 (09:03 -0400)]
Merge PR #58768 into main

* refs/pull/58768/head:
script/backport-create-issue: retry without if assignee is invalid

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
11 months agoMerge pull request #58152 from adam-lj/aiocompletion-perf-changes
Adam Lyon-Jones [Wed, 24 Jul 2024 12:09:21 +0000 (13:09 +0100)]
Merge pull request #58152 from adam-lj/aiocompletion-perf-changes

librbd: Modify locks and atomics in AioCompletion to improve performance

11 months agolibrbd: Modify locks and atomics in AioCompletion to improve performance 58152/head
Adam Lyon-Jones [Mon, 13 May 2024 12:02:00 +0000 (13:02 +0100)]
librbd: Modify locks and atomics in AioCompletion to improve performance

Signed-off-by: Adam Lyon-Jones <adamlyon@uk.ibm.com>
11 months agoMerge PR #58222 into main
Venky Shankar [Wed, 24 Jul 2024 07:31:58 +0000 (13:01 +0530)]
Merge PR #58222 into main

* refs/pull/58222/head:
qa: ignore container checkpoint/restore related selinux denials for centos9

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
11 months agoMerge pull request #58463 from athanatos/sjust/wip-66827-interrupt-epoch
Matan Breizman [Wed, 24 Jul 2024 07:27:53 +0000 (10:27 +0300)]
Merge pull request #58463 from athanatos/sjust/wip-66827-interrupt-epoch

crimson: audit and correct epoch captured by IOInterruptCondition

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
11 months agoqa/suites/krbd: override extra_system_packages directly on install task 58781/head
Ilya Dryomov [Wed, 24 Jul 2024 06:47:51 +0000 (08:47 +0200)]
qa/suites/krbd: override extra_system_packages directly on install task

Follow commit c61cb16223fa ("qa/suites/rbd: override
extra_system_packages directly on install task").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
11 months agoqa/suites/krbd: stress test for recovering from watch errors for -o exclusive
Ilya Dryomov [Wed, 24 Jul 2024 06:44:46 +0000 (08:44 +0200)]
qa/suites/krbd: stress test for recovering from watch errors for -o exclusive

This is based on a test added in commit 237aa221ebad ("qa/suites/krbd:
stress test for recovering from watch errors") for regular mappings.

Fixes: https://tracker.ceph.com/issues/67097
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
11 months agoMerge pull request #58710 from rhcs-dashboard/multisite-test-case-fix
Ankush Behl [Wed, 24 Jul 2024 06:12:29 +0000 (11:42 +0530)]
Merge pull request #58710 from rhcs-dashboard/multisite-test-case-fix

mgr/dashboard: multisite e2e fixes

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
11 months agoMerge pull request #58716 from rhcs-dashboard/expand-cluster-back-btn-fix
naman munet [Wed, 24 Jul 2024 05:54:48 +0000 (11:24 +0530)]
Merge pull request #58716 from rhcs-dashboard/expand-cluster-back-btn-fix

mgr/dashboard: expand-cluster back navigation fix

11 months agoMerge pull request #58677 from rhcs-dashboard/fix-cephfs-e2e-error
Nizamudeen A [Wed, 24 Jul 2024 04:10:06 +0000 (09:40 +0530)]
Merge pull request #58677 from rhcs-dashboard/fix-cephfs-e2e-error

mgr/test_orchestrator: add apply_mds command in the test_orch

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
11 months agoMerge pull request #58524 from zdover23/wip-doc-2024-07-11-cephfs-index
Zac Dover [Wed, 24 Jul 2024 03:04:57 +0000 (13:04 +1000)]
Merge pull request #58524 from zdover23/wip-doc-2024-07-11-cephfs-index

doc/cephfs: streamline a paragraph

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
11 months agoMerge pull request #58572 from VVoidV/lbr-fix-head-chunked-encoding
J. Eric Ivancich [Tue, 23 Jul 2024 22:30:02 +0000 (18:30 -0400)]
Merge pull request #58572 from VVoidV/lbr-fix-head-chunked-encoding

[RGW] Fix the handling of HEAD requests that do not comply with RFC standards

Reviewed-by: Casey Bodley <cbodley@redhat.com>
11 months agoMerge pull request #58665 from cbodley/wip-67012
J. Eric Ivancich [Tue, 23 Jul 2024 22:28:28 +0000 (18:28 -0400)]
Merge pull request #58665 from cbodley/wip-67012

rgw/iam: CreateRole ignores EEXIST after forwarded request

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
11 months agoscript/backport-create-issue: retry without if assignee is invalid 58768/head
Patrick Donnelly [Tue, 23 Jul 2024 20:07:16 +0000 (16:07 -0400)]
script/backport-create-issue: retry without if assignee is invalid

Resolves:

    WARNING:root:Missing issues will be created in Backport tracker of the relevant Redmine project
    INFO:root:Redmine key was read from '$REDMINE_API_KEY'; using it
    INFO:root:Processing 35 issues with status Pending Backport
    Traceback (most recent call last):
      File "/home/runner/work/ceph/ceph/src/script/backport-create-issue", line 411, in <module>
        iterate_over_backports(redmine, issues, dry_run=args.dry_run)
      File "/home/runner/work/ceph/ceph/src/script/backport-create-issue", line 354, in iterate_over_backports
        update_relations(r, issue, dry_run)
      File "/home/runner/work/ceph/ceph/src/script/backport-create-issue", line 242, in update_relations
        other = r.issue.create(project_id=issue['project']['id'],
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/redminelib/managers/base.py", line 187, in create
        response = self.redmine.engine.request(self.resource_class.http_method_create, url, data=request)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/redminelib/engines/base.py", line 83, in request
        return self.process_response(self.session.request(method, url, **kwargs))
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/redminelib/engines/base.py", line 178, in process_response
        raise exceptions.ValidationError(', '.join(': '.join(e) if isinstance(e, list) else e for e in errors))
    redminelib.exceptions.ValidationError: Assignee is invalid
    Examining issue#66797 (1/35)

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
11 months agoMerge PR #58214 into main
Patrick Donnelly [Tue, 23 Jul 2024 20:01:31 +0000 (16:01 -0400)]
Merge PR #58214 into main

* refs/pull/58214/head:
qa/cephfs: ignore variant of MDS_UP_LESS_THAN_MAX

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
11 months agoMerge PR #58327 into main
Patrick Donnelly [Tue, 23 Jul 2024 19:56:56 +0000 (15:56 -0400)]
Merge PR #58327 into main

* refs/pull/58327/head:
cephfs-shell: excute cmd 'rmdir_helper' reported error

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
11 months agoMerge PR #57857 into main
Patrick Donnelly [Tue, 23 Jul 2024 19:55:49 +0000 (15:55 -0400)]
Merge PR #57857 into main

* refs/pull/57857/head:
qa: set debug_ms=2 for cephfs tests
msg: decrease the level to print the sending msgs from the protocol

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
11 months agoMerge pull request #58703 from kshtsk/wip-fix-unused-in-erasure-code
kyr [Tue, 23 Jul 2024 18:33:04 +0000 (20:33 +0200)]
Merge pull request #58703 from kshtsk/wip-fix-unused-in-erasure-code

erasure-code/clay: cleanup unused but set variable

11 months agocrimson/osd: execute PGListener async operations in order 58464/head
Samuel Just [Tue, 2 Jul 2024 22:27:55 +0000 (15:27 -0700)]
crimson/osd: execute PGListener async operations in order

- Adds ShardServices::singleton_orderer_t mechanism to ensure that
  OSDSingleton calls are completed in order.
- Updates ShardServices accessors invoked from PeeringListener handlers
  to use orderer.
- Updates PGListener handlers and complete_rctx to use orderer.

Fixes: https://tracker.ceph.com/issues/66316
Signed-off-by: Samuel Just <sjust@redhat.com>
11 months agocrimson/.../alien_store: access coll_map under coll_map_lock 58766/head
Samuel Just [Wed, 10 Jul 2024 22:58:55 +0000 (22:58 +0000)]
crimson/.../alien_store: access coll_map under coll_map_lock

Fixes: https://tracker.ceph.com/issues/66294
Signed-off-by: Samuel Just <sjust@redhat.com>
11 months agocrimson/.../alien_store: clear coll_map on stop()
Samuel Just [Wed, 10 Jul 2024 22:53:40 +0000 (15:53 -0700)]
crimson/.../alien_store: clear coll_map on stop()

Signed-off-by: Samuel Just <sjust@redhat.com>
11 months agocrimson/.../alien_store: update coll_map from alien tp
Samuel Just [Wed, 10 Jul 2024 22:53:28 +0000 (15:53 -0700)]
crimson/.../alien_store: update coll_map from alien tp

Signed-off-by: Samuel Just <sjust@redhat.com>
11 months agocrimson/.../alien_store: factor out get_alien_coll_ref
Samuel Just [Wed, 10 Jul 2024 22:25:15 +0000 (15:25 -0700)]
crimson/.../alien_store: factor out get_alien_coll_ref

Signed-off-by: Samuel Just <sjust@redhat.com>
11 months agocrimson/.../alien_store: add comment explaining coll_map
Samuel Just [Wed, 10 Jul 2024 17:42:31 +0000 (10:42 -0700)]
crimson/.../alien_store: add comment explaining coll_map

Signed-off-by: Samuel Just <sjust@redhat.com>
11 months agoqa: suppress __trans_list_add valgrind warning 58056/head
Patrick Donnelly [Sat, 15 Jun 2024 03:00:02 +0000 (23:00 -0400)]
qa: suppress __trans_list_add valgrind warning

Fixes: https://tracker.ceph.com/issues/65779
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
11 months agoMerge pull request #58215 from badone/wip-tracker-59380-admin-socket-injectfull
Yuri Weinstein [Tue, 23 Jul 2024 17:57:08 +0000 (10:57 -0700)]
Merge pull request #58215 from badone/wip-tracker-59380-admin-socket-injectfull

qa/suites/rados: Cancel injectfull to allow cleanup

Reviewed-by: Neha Ojha <nojha@redhat.com>
11 months agoMerge pull request #57951 from mohit84/issue_66231
Yuri Weinstein [Tue, 23 Jul 2024 17:56:34 +0000 (10:56 -0700)]
Merge pull request #57951 from mohit84/issue_66231

AsyncMessenger: Don't decrease l_msgr_active_connections if it is negative

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
11 months agoMerge pull request #57797 from ajarr/wip-66011
Ilya Dryomov [Tue, 23 Jul 2024 17:52:40 +0000 (19:52 +0200)]
Merge pull request #57797 from ajarr/wip-66011

rbd: add `group snap info` command

Reviewed-by: N Balachandran <nibalach@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
11 months agoMerge pull request #57485 from sseshasa/wip-fix-validator-osd-down-grace-tmout
Yuri Weinstein [Tue, 23 Jul 2024 17:50:32 +0000 (10:50 -0700)]
Merge pull request #57485 from sseshasa/wip-fix-validator-osd-down-grace-tmout

qa/suites/rados/verify/validater: increase heartbeat grace timeout

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
11 months agocrimson/.../shard_services: add logging to local and remote reservers
Samuel Just [Fri, 12 Jul 2024 04:13:20 +0000 (04:13 +0000)]
crimson/.../shard_services: add logging to local and remote reservers

Signed-off-by: Samuel Just <sjust@redhat.com>
11 months agocrimson/.../pg: add logging to most PeeringState::Listener implementations
Samuel Just [Fri, 12 Jul 2024 00:00:00 +0000 (00:00 +0000)]
crimson/.../pg: add logging to most PeeringState::Listener implementations

Signed-off-by: Samuel Just <sjust@redhat.com>
11 months agoMerge PR #58276 into main
Venky Shankar [Tue, 23 Jul 2024 16:36:58 +0000 (22:06 +0530)]
Merge PR #58276 into main

* refs/pull/58276/head:
mds/QuiesceDbManager: get requested state of members before iterating through each quiesce set members

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
11 months agoqa: generate valgrind suppressions
Patrick Donnelly [Tue, 23 Jul 2024 15:18:35 +0000 (11:18 -0400)]
qa: generate valgrind suppressions

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
11 months agoMerge pull request #58709 from kshtsk/wip-assert-equal-please
kyr [Tue, 23 Jul 2024 14:26:53 +0000 (16:26 +0200)]
Merge pull request #58709 from kshtsk/wip-assert-equal-please

mgr/dashboard: use assertEqual in test_iscsi

11 months agocls/rgw: gc_list uses ObjectOperation instead of IoCtx 58449/head
Casey Bodley [Fri, 5 Jul 2024 22:01:11 +0000 (18:01 -0400)]
cls/rgw: gc_list uses ObjectOperation instead of IoCtx

clean up the only gc function that was hidden with CLS_CLIENT_HIDE_IOCTX

this allows rgw to use it asynchonously with rgw_rados_operate() and
optional_yield, and warn about blocking calls that should be async

Signed-off-by: Casey Bodley <cbodley@redhat.com>
11 months agoMerge pull request #58735 from yuvalif/wip-yuval-63786
Casey Bodley [Tue, 23 Jul 2024 11:47:21 +0000 (12:47 +0100)]
Merge pull request #58735 from yuvalif/wip-yuval-63786

test/cls_2pc_queue: fix multi-threaded access to non-atomic counter

Reviewed-by: Casey Bodley <cbodley@redhat.com>
11 months agoMerge pull request #58745 from cyx1231st/wip-fix-blk-aio-compile-issue
Igor Fedotov [Tue, 23 Jul 2024 09:07:01 +0000 (12:07 +0300)]
Merge pull request #58745 from cyx1231st/wip-fix-blk-aio-compile-issue

blk/aio: fix compile issue when HAVE_LIBURING isn't defined

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
11 months agotest/cls_2pc_queue: fix multi-threaded access to non-atomic variables 58735/head
Yuval Lifshitz [Mon, 22 Jul 2024 16:10:55 +0000 (16:10 +0000)]
test/cls_2pc_queue: fix multi-threaded access to non-atomic variables

Fixes: https://tracker.ceph.com/issues/63786
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
11 months agoMerge pull request #58367 from xxhdx1985126/wip-seastore-lba-mapping-iterator
Yingxin [Tue, 23 Jul 2024 05:50:02 +0000 (13:50 +0800)]
Merge pull request #58367 from xxhdx1985126/wip-seastore-lba-mapping-iterator

crimson/os/seastore/cached_extent: add the "refresh" ability to lba mappings

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
11 months agoblk/aio: fix compile issue when HAVE_LIBURING isn't defined 58745/head
Yingxin Cheng [Tue, 23 Jul 2024 03:22:59 +0000 (11:22 +0800)]
blk/aio: fix compile issue when HAVE_LIBURING isn't defined

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>