mailmap: Nathan Cutler name normalization

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Ian Colle affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Kyr Shatskyy affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: haodong tang affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: craigchi affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Enming Zhang affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Saumay Agrawal affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Tahia Khan affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Taeksang Kim affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: hechuang affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Tang Wenjun affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Jos Collin affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Guillaume Abrioux affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Nikita Gerasimov affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: DanielBar-On affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: wei xiao affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Ziye Yang affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Michael Eischer affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Edwin F Boza affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Shasha Lu affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Chu Hua-Rong affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

mailmap: Lihongjie affiliation

Signed-off-by: M Ranga Swami Reddy <swamireddy@gmail.com>

Merge pull request #14288 from Adirl/small_leaks

msg/async/rdma: Fix small memory leaks detected by valgrind

Reviewed-by: Haomai Wang <haomai@xsky.com>

msg/async/rdma: Fix small memory leaks detected by valgrind

Issue: 995322
Change-Id: Iccffbd0defd09aa51c4b51b78733921444ea1c5f
Signed-off-by: Amir Vadai <amir@vadai.me>

Merge pull request #14170 from liewegas/wip-fewer-warnings

common/ceph_context: fewer warnings about experimental features

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14271 from joscollin/wip-krbd-warning

rbd: warning, ‘devno’ may be used uninitialized in this function

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #13909 from kestrels/wip-19217

crc32c: Add crc32c function optimized for ppc architecture

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14124 from Fabian-Gruenbichler/ipv6_fix

common: fix segfault in public IPv6 addr picking

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14173 from badone/wip-do_request-abort

common: Fix heap buffer overflow in do_request

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14193 from liupan1111/wip-fix-delete-full

librados: set the flag CEPH_OSD_FLAG_FULL_TRY of Op in the right place.

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14248 from badone/wip-simple_spin_lock-delay

common: Make spinlock delay more conventional

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #13690 from jcsp/wip-17503

mgr: pass through cluster log to plugins

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14276 from atheism/rgw-rgwop-remove-unused-iter

rgw: rgw_op: remove unused variable iter
Reviewed-by: Orit Wasserman <owasserm@redhat.com>

rgw: rgw_op: remove unused variable iter

    The variable iter is not used in  RGWInitMultipart::execute().

Signed-off-by: Weibing Zhang <zhangweibing@unitedstack.com>

Merge pull request #13811 from rzarzynski/wip-bs-bitmap-mem-cleanup

os/bluestore: memory and dereference clean-up in the BitAllocator

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14121 from majianpeng/bluefs-get-allocated

os/bluestore/BlueFS: optimize get_allocated

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14162 from majianpeng/optimize-bluestore-force-flush

os/bluestore: clean up flush logic

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14225 from ivancich/wip_fix_throttle_config_change

os/bluestore: make live changes for BlueStore throttle config work like initial config

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14229 from ceph/wip-systemd

qa: Add reboot case for systemd test

Merge pull request #14254 from idryomov/wip-vstart-runner-ps

qa/vstart_runner: amend ps invocation

Reviewed-by: John Spray <john.spray@redhat.com>

Merge pull request #14226 from ceph/preset-mon

systemd: remove ceph-create-keys from presets

Merge pull request #14266 from tchaikov/wip-require-mgr-for-pg-dump

tests: add MGR=1 so 'pg dump' won't be blocked

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #14259 from johnwilkins/wip-doc-multisite

doc: wip-doc-multisite ports downstream multisite document upstream.

rbd: warning, ‘devno’ may be used uninitialized in this function

The following warning appears during make. Fixed in both unmap_image() functions in krbd.cc

--
krbd.cc: In function ‘int krbd_unmap_by_spec(krbd_ctx*, const char*, const char*, const char*, const char*)’:
krbd.cc:608:65: warning: ‘devno’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   return do_unmap(ctx->udev, devno, build_unmap_buf(id, options));
                                                                 ^
krbd.cc:591:9: note: ‘devno’ was declared here
   dev_t devno;
--

Signed-off-by: Jos Collin <jcollin@redhat.com>

osd/OSDMap: use _pg_to_up_acting_osds() to get_pg_acting_primary()

avoid unnecessary swap() call of vector<int> which will be dropped on
the floor after getting its first element, which can be retrieved using
another parameter using _pg_to_up_acting_osds() directly.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr: use OSDMap::get_pg_acting_primary() to get the primary

OSDMap::pg_to_acting_osds() assumes that the "acting" parameter is not
null.

Signed-off-by: Kefu Chai <kchai@redhat.com>

tests: add MGR=1 so 'pg dump' won't be blocked

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14260 from dmick/wip-workunit-clone-with-branch

workunit: request branch when cloning

Reviewed-by: Kefu Chai <kchai@redhat.com>

common: Make spinlock delay more conventional

The accepted method of implementing a spinlock delay is the "pause"
instruction.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

tasks/workunit.py: specify the branch name when cloning a branch

c1309fb failed to specify a branch when cloning using --depth=1, which
by default clones the HEAD. and we can not "git checkout" a specific
sha1 if it is not HEAD, after cloning using '--depth=1', so in this
change, we dispatch "tag", "branch", "HEAD" using three Refspec classes.

Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Dan Mick <dan.mick@redhat.com>

Merge pull request #14219 from ShiqiCooperation/master

os/bluestore: clean up Invalid return value judgment

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14228 from ifed01/wip-bluestore-fix-store-test

test/store_test: fix bluestore test cases disablement

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #13617 from liewegas/wip-mgr-commands

mon,mgr: tag some commands for ceph-mgr

Reviewed-by: Kefu Chai <kchai@redhat.com>

mon/ConfigKeyService: wait for quorum

Among other things, this prevents a mgr activation stall if it
happens to request config-keys from a mon that is out of
quorum.

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrMonitor: show delta

This is mostly because I couldn't debug a weird state where
it kept updating but it appeared the addr was not changing
(always '-').

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrMap: implement dump, add to ceph-dencoder

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrMonitor: print MgrMap to log on each change

The other services do this.

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrMonitor: health warn/err if no active mgr

Start warning once mons are luminous; start erroring once
require_luminous is set in osdmap.  Allow a grace period for
mgr to restart or standby to take over before we turn a warning
into an error.

Signed-off-by: Sage Weil <sage@redhat.com>

Ported the downstream (and tested) document upstream.

Signed-off-by: John Wilkins <jowilkin@redhat.com>

Clarified index.

Signed-off-by: John Wilkins <jowilkin@redhat.com>

doc: Added a new version of the multi-site graphic.

Signed-off-by: John Wilkins <jowilkin@redhat.com>

Merge pull request #14183 from joscollin/wip-rgw-cleanup-removeunwantedheaders

rgw: Removed Unwanted headers
Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14194 from joscollin/wip-rgw_rados-warning

rgw: warning, output may be truncated before the last format character

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

qa/vstart_runner: amend ps invocation

"ps -xwwu<id>" is parsed as BSD, because -x is not a UNIX option.
"u" is a BSD option for user-oriented format, so the <id> ends up being
parsed as an old-style "select by pid".  The only reason this command
doesn't dump other user's processes is that the BSD "only yourself"
restriction is in effect.

I'm not sure what's wrong with a simple "ps xww", but if we want to
select by euid, let's do it right.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #14253 from liupan1111/wip-remove-debug-message

rbd-nbd: remove debug messages from do_unmap

Reviewed-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #13999 from tchaikov/wip-extract-creating-pgs

mon,osd: decouple creating pgs from pgmap

Reviewed-by: Sage Weil <sage@redhat.com>

rbd-nbd: remove debug message from do_unmap

Global context is not initialized when do_unmap is called.

Signed-off-by: Pan Liu <liupan1111@gmail.com>

tools/ceph-objectstore-tool: always set first_committed

otherwise the workaround of 7fb3804fb is triggered. we need to remove
that workaround later on.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon: switch to osdmon when handling osd_pg_creates subs

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/OSDMonitor: avoid search and lookup anti-pattern

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/OSDMonitor: pass by reference not pointer of const param

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/OSDMonitor: switch to the new creating_pgs

* prime_pg_temp(): switch to the new creating_pgs
* get_trim_to(): switch to the new creating_pgs

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon: handle MOSDPGCreated messages

MOSDPGCreated messages are used to prune the creating_pgs_by_osd_epoch
and creating_pgs, by updating created_pools. as once a pool is created
we will not send MOSDPGCreate to its acting_primary OSD anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>

osd: send pg-created message if any pg is newly created

add an option named "osd_created_report_interval" to specify the
interval to check and send the "pg_created" mesages to mon

because pg could update its state when it is still in the pg_stat_queue,
for example, to change its state to PG_STATE_CLEAN, we cannot tell if we
have sent a "pg-created" message for it or not without introducing a new
member variable in PG.

Signed-off-by: Kefu Chai <kchai@redhat.com>

messages/MPGCreated: add MPGCreated

add a new message type MPGCreated. osd is supposed to send this message
to monitor to inform that any pg(s) is created and activated.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/OSDMonitor: add send_pg_create() to OSDMonitor

OSDMonitor will handle the pg-create subscriptions after luminous.
1. scan new pools to get the pgs to be created
2. send pg creates using the collected pgs
3. trim the creating_pgs using the "created!" messages from OSD.

please note that we need to wait for the OSDMonitor::mapping to be fully
populated, so we cannot scan the incrementa map for creating pgs until
it is applied and accepted by other monitors.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon: acquire lock when accessing mon->session_map

we will access the mon->session_map for sending the osd-pg-creates
messages when finishing osdmapping in OSDMonitor, this could happen in
another thread without the protection of Monitor::lock, or in the same
thread already guarded by Monitor::lock. so instead of changing
Monitor::lock to a recursive lock, a new lock is introduced to protect
session_map.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/OSDMonitor: run mapping on peons also

otherwise subcriptions on peons won't get the creating_pgs notification
mapping updated. we want to send the notification from peons also. and
the notifications should be updated with the updated pg mapping.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/OSDMonitor: mapping is not optional anymore

as pg_creatings needs mapping to get the acting_primary osd of the
creating pg, so we can send the pg-create message to it if it subscribes
to this information, mapping should always be available now.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon: dispatch osd_beacon message to OSDMonitor

Signed-off-by: Kefu Chai <kchai@redhat.com>

osd: send osd-beacon to mon periodically

add an option named "osd_beacon_report_interval" to specify the interval
to send osd-beacon.

Signed-off-by: Kefu Chai <kchai@redhat.com>

messages/MOSDBeacon: add beacon msg

osd will send beacon message to monitor periodically to inform it that
"i am still alive!", previously, monitor use the pg-stats to check the
status of OSD, but since osd will only send pg stat to mgr after
luminous, we use a dedicated msg for this purpose.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/OSDMonitor: s/check_sub/check_osdmap_sub/

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/OSDMonitor: update comment in update_from_paxos()

this change updates the comment for 7fb3804fb, 97462a3 and e807770,
to reflect the reason why we need to fix latest_full in current code.
as the fix is not a workaround for cuttlefish anymore, it resolves the
issue where

0. mon.c has a latest_full of 5
1. mon.c is shutdown and out of sync with the quorum
2. mon.c starts sync
3. mon.c now has osdmap[31..50], and the latest_full is still 5.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/PGMonitor: remove unused variable

last_pg_scan is not used in PGMonitor::update_from_paxos(), so remove
it.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/PGmonitor: remove unused last_sent_pg_create

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon: pass const variables by const ref not pointer

* PGMapUpdater::check_down_pgs(): pass a const reference to pgmap
  instead of a pointer
* PGMapUpdater::register_new_pgs(): pass a const reference to pgmap
  instead of a pointer

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14250 from Adirl/fix_last_poll_dev

msg/async/rdma: Device::last_poll_dev must be positive

Reviewed-by: Haomai Wang <haomai@xsky.com>

msg/async/rdma: Device::last_poll_dev must be positive

Make Device::last_poll_dev `unsigned` - it could overlap and should not
be negative.
Also, add missing initialization.

Change-Id: I558f02292ae4f5d1ce48d9bcda5047d382604237
Signed-off-by: Amir Vadai <amir@vadai.me>

Merge pull request #14249 from Adirl/rdma-cm-4_1

msg/async/rdma: Debug prints for ibv_*

Reviewed-by: Haomai Wang <haomai@xsky.com>

msg/async/rdma: Debug prints for ibv_*

Setting RDMA_DEBUG to 1, will enable debug prints for every ibv_*
function called.
This makes it easier to debug RDMA issues.

Issue: 995322
Change-Id: I49d327d5d4386b44264f5619d50f2dbc7d76dcae
Signed-off-by: Amir Vadai <amir@vadai.me>

systemd: remove all occurence of ceph-create-keys

ceph-create-keys unit file does not exist anymore so there is no need to
call it.

Signed-off-by: Sébastien Han <seb@redhat.com>

os/bluestore: clean up Invalid return value judgment

Signed-off-by: shiqi <1454927420@qq.com>

Merge pull request #14245 from tchaikov/wip-revert-14201

Revert "msg/async/rdma: Debug prints for ibv_*"

Revert "msg/async/rdma: Debug prints for ibv_*"

This reverts commit 7d1475f6274531988854cf62f6056f9cfd13ff29.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14201 from Adirl/rdma-cm-4

msg/async/rdma: Introduce RDMAConnMgr + Debug prints

Reviewed-by: Haomai Wang <haomai@xsky.com>

Merge pull request #14214 from dmick/wip-workunit-shallow-clone

tasks/workunit.py: when cloning, use --depth=1

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14202 from tchaikov/wip-cast-size_t-arm32

rbd: use min<uint64_t>() explicitly

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Fix distro's, point to latest version

Signed-off-by: Vasu Kulkarni <vasu@redhat.com>

Add reboot case for systemd test

test systemd units restart after reboot

Signed-off-by: Vasu Kulkarni <vasu@redhat.com>