Merge pull request #1034 from ceph/fix_collect_logs

ceph-ansible: fix teardown issue

ceph-ansible: fix teardown issue

At the moment, the teardown isn't fully executed because of `collect-logs.yml`
playbook.

it is expected the following task can fail according to the context of the main
failure:

```
TASK [find ceph logs] **********************************************************
task path: /home/jenkins-build/build/workspace/ceph-ansible-scenario/collect-logs.yml:4
fatal: [ceph-nfs0]: FAILED! => {
    "changed": true,
    "cmd": [
        "find",
        "/var/log/ceph",
        "-name",
        "test*.log"
    ],
    "delta": "0:00:00.003363",
    "end": "2018-05-23 16:45:22.845782",
    "rc": 1,
    "start": "2018-05-23 16:45:22.842419"
}

STDERR:

find: ‘/var/log/ceph’: No such file or directory

MSG:

non-zero return code
```

therefore, `teardown_vagrant_tests()` doesn't return `0` and causes the
teardown to stop because of `set -e`

```
PLAY RECAP *********************************************************************
ceph-client0               : ok=1    changed=0    unreachable=0    failed=1
ceph-client1               : ok=1    changed=0    unreachable=0    failed=1
ceph-iscsi-gw0             : ok=1    changed=0    unreachable=0    failed=1
ceph-mds0                  : ok=1    changed=0    unreachable=0    failed=1
ceph-mgr0                  : ok=1    changed=0    unreachable=0    failed=1
ceph-mon0                  : ok=3    changed=2    unreachable=0    failed=0
ceph-mon1                  : ok=3    changed=2    unreachable=0    failed=0
ceph-mon2                  : ok=3    changed=2    unreachable=0    failed=0
ceph-nfs0                  : ok=1    changed=0    unreachable=0    failed=1
ceph-osd0                  : ok=1    changed=0    unreachable=0    failed=1
ceph-rbd-mirror0           : ok=1    changed=0    unreachable=0    failed=1
ceph-rgw0                  : ok=1    changed=0    unreachable=0    failed=1

Build step 'Execute Scripts' marked build as failure
Archiving artifacts
Finished: FAILURE
```

adding a `failed_when: false` on this task should avoid this bug.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #1033 from ceph/remove_fetch_dir_teardown

ceph-ansible: some teardown fixes

ceph-ansible: vagrant clean old cache

Somehow, it's possible sometimes there is some old cache left after a
failure. `vagrant global-status --prune` ensures old caches that were left are
removed.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

ceph-ansible: remove fetch directory in teardown

Remove the fetch directory in teardown for ceph-ansible to avoid
keeping leftover from previous jobs.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #1032 from ceph/cv-disable-bionic

ceph-volume-ansible-prs: remove bionic

ceph-volume-ansible-prs: remove bionic

ceph-volume doesn't have a 'bionic' factor in tox, so there aren't any
functional scenarios to support this. At the moment, there aren't any
ceph packages to test against either. Disabling this for now.

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #1031 from ceph/wip-pip-nobinary

build_utils.sh: Don't update pip after installing it

build_utils.sh: Don't update pip after installing

Attempting to update pip was resulting in job failures because the wheel
wasn't present in the local pip cache.

Since we pinned pip to 10.0.0 in
https://github.com/ceph/ceph-build/pull/1007, we don't need to update
pip immediately after.

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1030 from joscollin/wip-fix-signedoff-guide

ceph-pr-commits/build: Fix Sign your work url

ceph-pr-commits/build: Fix Sign your work url

Signed-off-by: Jos Collin <jcollin@redhat.com>

Merge pull request #1029 from ceph/wip-rtslib-fb-pyudev

rtslib-fb: reduce pyudev version requirements

rtslib-fb: reduce pyudev version requirements

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #1027 from ceph/cv-disable-bionic

ceph-volume-nightly: remove bionic

ceph-volume-nightly: remove bionic

ceph-volume doesn't have a 'bionic' factor in tox, so there aren't any
functional scenarios to support this. At the moment, there aren't any
ceph packages to test against either. Disabling this for now.

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #1028 from tchaikov/bionic-gcc-7

build_utils.sh: help bionic to point its gcc back to 7

build_utils.sh: help bionic to point its gcc back to 7

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1026 from tchaikov/bionic-gcc-7

build_utils.sh: help bionic to point its gcc back to 7.3

build_utils.sh: help bionic to point its gcc back to 7.3

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1025 from ceph/wip-bionic-builddebs

setup_deb: Forgot bionic

setup_deb: Forgot bionic

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1024 from ceph/wip-bionic-build

build_utils.sh: Add Bionic

build_utils.sh: Add Bionic

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1023 from ceph/branch-regex-fix

ceph-build: use BRANCH instead of non-existing GIT_BRANCH

ceph-build: use BRANCH instead of non-existing GIT_BRANCH

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #1022 from ceph/wip-bionic

Add support for Ubuntu Bionic globally

Add support for Ubuntu Bionic globally

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1019 from tchaikov/wip-do-not-build-mimi-on-trusty

ceph-build: do not build mimic on old distros

ceph-build: do not build mimic on old distros

mimic and nautilus require C++17 to build, but following distro do
not ship new enough GCC compiler:

- ubuntu trusty
- debian jessie
- debian stretch

so we won't build mimic or newer ceph on these distros.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1021 from ceph/disable_purge

ceph-ansible-prs: disable purge_bluestore_osds_container

ceph-ansible-prs: disable purge_bluestore_osds_container

This scenario is failing for every PRs because of a race condition.
A PR has been opened https://github.com/ceph/ceph/pull/21415 but until
it doesn't get merged we better to disable this scenario.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #1020 from ceph/wip-bionic

sepia-fog-images: Add support for Ubuntu 18.04

sepia-fog-images: Add support for Ubuntu 18.04

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1018 from ceph/wip-timeout-arm

ceph-pull-requests-arm64: Timeout after 3h

ceph-pull-requests-arm64: Timeout after 3h

Builds were hanging indefinitely during unit tests

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1017 from ceph/centos-container

ceph-ansible-nightly: always test on centos

ceph-ansible-nightly: always test on centos

The job was still configured to test on Ubuntu and we want CentOS.

Signed-off-by: Sébastien Han <seb@redhat.com>

Merge pull request #1016 from ceph/script-prune

cleanup: remove all top-level scripts

readme: update the deprecation with script locations

Signed-off-by: Alfredo Deza <adeza@redhat.com>

scripts: remove all top-level scripts

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #1015 from ceph/evelu-ceph-container-arm64

ceph-container-build-push-imgs-arm64: Fixing scripts

ceph-container-build-push-imgs-arm64: Fixing scripts

As ceph-container needs a particular build script for arm64, let's fix
the script name.

Merge pull request #1014 from ceph/arm

ceph-container-build-push-imgs-arm64: fix node label

ceph-container-build-push-imgs-arm64: fix node label

Signed-off-by: Sébastien Han <seb@redhat.com>

Merge pull request #1013 from ceph/arm64-follwup

ceph-container-build-push-imgs-arm64: update node label

ceph-container-build-push-imgs-arm64: update node label

The arm64 nodes have a 'arm64 xenial' label.

Signed-off-by: Sébastien Han <seb@redhat.com>

Merge pull request #1012 from ceph/ceph-container-prs

ceph-container-prs: only auto start a subsection of tests

ceph-container-prs: only auto start a subsection of tests

All tests can be triggered manually by github comments, but we only
want certain ones to start automatically when the PR is created.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #1011 from ceph/pip-easy-install

scripts: upgrade pip with easy_install before actual pinning

scripts: upgrade pip with easy_install before actual pinning

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #1010 from ceph/cv-prs-teardown-fix

ceph-volume-ansible-prs: ensure correct path is used for teardown

ceph-volume-ansible-prs: ensure correct path is used for teardown

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #1009 from ceph/cv-functional-repo

ceph-volume-test: configurable ceph repo url

ceph-volume-test: configurable ceph repo url

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #1008 from ceph/pip-download-fix2

scripts: pin pip to 10.0.0 on missing BASH func

scripts: pin pip to 10.0.0 on missing BASH func

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #1007 from ceph/pip-download-fix

scripts: pin pip to 10.0.0

scripts: pin pip to 10.0.0

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #1006 from ceph/cv-scenario-url

ceph-volume-scenario: configurable ceph repo url

ceph-volume-scenario: configurable ceph repo url

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #1005 from ceph/fix-build

build: fix unkown option

build: fix unkown option

Newer version of pip does not support --download anymore, the option has
been replaced by --cache-dir.
This fixes errors like:

+ /tmp/venv.ufvIkiZl8v/bin/pip download
--dest=/home/jenkins-build/.cache/pip pip
ERROR: unknown command "download"

Signed-off-by: Sébastien Han <seb@redhat.com>

Merge pull request #1004 from ceph/arm64-container-img

add ceph-container-build-push-imgs-arm64

add ceph-container-build-push-imgs-arm64

We need to build container images on arm64.

Signed-off-by: Sébastien Han <seb@redhat.com>

Merge pull request #1003 from ceph/wip-rhel75

sepia-fog-images: Add CentOS/RHEL 7.5 support

sepia-fog-images: Add CentOS/RHEL 7.5 support

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1001 from ceph/container-credentials-binding

container: add docker hub credential binding

container: add docker hub credential binding

docker-hub-leseb is defined as a credential on 2.jenkins.ceph.com

Merge pull request #1000 from ceph/evelu-ceph-container-flake8

ceph-container-flake8: Fixing tox.ini path

ceph-container-flake8: Fixing tox.ini path

tox.ini is located at the root of the project, so in $workspace/ceph-container

Merge pull request #999 from ceph/evelu-ceph-container-flake8

ceph-container-flake8: Using project's tox.ini

ceph-container-flake8: Using project's tox.ini

The current code is running flake8 from a container to check every
python file changed by a PR.

The actual code doesn't import the tox.ini of ceph-container which
specify a particular configuration like "max-line-length = 99"

This lead to a situation where a dev which runs flake on his dev env
have a flake reporting now failures while flake from the CI fails.

So this patch is about adding project's tox.ini inside the container to
insure flake is using it.

Merge pull request #997 from tchaikov/wip-pip-download

scripts/build_utils.sh: use "download" instead of "--download"

scripts/build_utils.sh: use "download" instead of "--download"

"pip install --download" was deprecated since v8.0.0, and was replaced
with "pip download". pip v10.0.0 removed support the "--download"
option. so we need to replace "install --dowload" with "download".

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #996 from ceph/wip-tcmu-runner

tcmu-runner: additional build tweaks

tcmu-runner: only upload binary RPM to chacra

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

tcmu-runner: cleanup no longer required

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #995 from ceph/wip-tcmu-runner

tcmu-runner: added missing PROJECT environment variable

tcmu-runner: added missing PROJECT environment variable

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #994 from ceph/wip-tcmu-runner

tcmu-runner: build using in-tree spec file under mock

tcmu-runner: build using in-tree spec file under mock

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #993 from ceph/vagrant-teardown

scripts: create util function for tearing down vagrant tests

use teardown_vagrant_tests on jobs that use vagrant

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

scripts: adds a teardown_vagrant_tests method

This will collect logs and do any vagrant/libvirt cleanup needed after
any jobs fail that were using vagrant vms for testing.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #992 from ceph/cv-logs-fix

ceph-volume-nightly: look for the ssh config file to avoid using the root dir

ceph-volume-nightly: look for the ssh config file to avoid using the root dir

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #991 from ceph/wip-skip-ci

ceph-{ansible,container}-prs: Fix skip-build-phrase regex

ceph-{ansible,container}-prs: Fix skip-build-phrase regex

JJB converts the string to lowercase so the \W was getting converted to
\w so the actual phrase wasn't being detected.  We can just use a space
instead of trying to match any character.

https://git.openstack.org/cgit/openstack-infra/jenkins-job-builder/tree/jenkins_jobs/modules/triggers.py#n1027

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #990 from ceph/wip-skip-ci

ceph-{ansible,container}-prs: Fix skip-build-phrase

ceph-{ansible,container}-prs: Fix skip-build-phrase

I think JJB was previously not sending 'jenkins do not test' as the skip
build phrase so the plugin default '[skip ci]' was being used and
working.  Since we recently updated JJB, I'm guessing 'jenkins do not
test' *is* being configured so '[skip ci]' is no longer working.  This
commit should allow either phrase to be used.

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #988 from ceph/wip-fog-pause

sepia-fog-images: Add retry function and pause the queue

sepia-fog-images: Add function to kill job if a loop hangs

Signed-off-by: David Galloway <dgallowa@redhat.com>

sepia-fog-images: Pause the queue if there are active Deploy tasks

I've observed deployment failures while teuthology jobs are running if
the OS image is replaced/removed while it's in use.  Pausing the queue
will allow Deploy tasks to finish so we can capture a new OS image
without interrupting running jobs.

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #989 from ceph/postbuildscript-fixes

all remove deprecated "script-only-if" in favor of "build-on"

all remove deprecated "script-only-if" in favor of "build-on"

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #987 from ceph/wip-unpin-jjb

jenkins-job-builder: Unpin JJB version

jenkins-job-builder: Use latest JJB version

It was pinned to a beta release in
https://github.com/ceph/ceph-build/commit/4f10012571b120e01854fae49be4d43f382787f1
so we could take advantage of an option that wasn't available in the
stable version.

It's now in the stable version and I've tested it against a job config
locally and confirmed compatibility

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #980 from ceph/wip-fog-doc

sepia-fog-images: Update setup doc

sepia-fog-images: Update setup doc

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #972 from ceph/wip-nfs-ganesha

nfs-ganesha: change CMAKE_BUILD_TYPE, add checks