Merge pull request #484 from yuvalif/fix-sts-error-handling

better error handling in the STS tests

Merge pull request #487 from robbat2/rgw_post_content_length

test_post_object_upload_size_below_minimum_rgw_max_chunk_size: new testcase for size validation bug

Reviewed-by: Casey Bodley <cbodley@redhat.com>

test_post_object_upload_size_rgw_chunk_size_bug: new testcase

`ERR_TOO_SMALL` is wrongly returned if all of the following are true,
- the get_data returns multiple items (chunks)
- the length of the last item is smaller than the POST Policy's min
  value for content-length-range.

The check should be `(ofs < min_len)` instead of `(len < min_len)`

This is further confirmed by the next line of `s->obj_size = ofs`

Move the `int len` scope inside loop to try and prevent the bug in
future.

The bug was refactored in 2016, but was introduced in Oct 2012, when
this functionality was first added to RGW in commit 7bb3504d3f0974e9863f536e9af0ce8889d6888f.

Reference: https://github.com/ceph/ceph/blob/933a42f9af349b3b222270e7f19f1fe151d89e8e/src/rgw/rgw_op.cc#L4474-L4513
Reference: https://github.com/ceph/ceph/commit/7bb3504d3f0974e9863f536e9af0ce8889d6888f
Signed-off-by: Robin H. Johnson <rjohnson@digitalocean.com>

better error handling in the STS tests

also, give more accurate instruction on how to run the tests

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #486 from cbodley/wip-58365

test_s3: remove test_user_policy()

Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>

test_s3: remove test_user_policy()

this has been failing consistently in local testing. test_sts.py has
lots of user policy test coverage, so this test case in test_s3.py is
superfluous

Fixes: https://tracker.ceph.com/issues/58365
Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #482 from cbodley/wip-tox-pytest

replace deprecated nose with pytest

test_headers: add custom marks for auth_common/aws2/aws4

Signed-off-by: Casey Bodley <cbodley@redhat.com>

remove boostrap

Signed-off-by: Casey Bodley <cbodley@redhat.com>

cleanup duplicate lines

Signed-off-by: Casey Bodley <cbodley@redhat.com>

remove nose dependency from requirements.txt

Signed-off-by: Casey Bodley <cbodley@redhat.com>

nose: remove nose attrs and imports

Signed-off-by: Casey Bodley <cbodley@redhat.com>

pytest: replace nose eq() with assert ==

Signed-off-by: Casey Bodley <cbodley@redhat.com>

pytest: replace nose SkipTest with pytest.skip()

Signed-off-by: Casey Bodley <cbodley@redhat.com>

pytest: replace @nose.with_setup with fixtures

Signed-off-by: Casey Bodley <cbodley@redhat.com>

pytest: add custom marks for each nose @attr

and register them in pytest.ini

Signed-off-by: Casey Bodley <cbodley@redhat.com>

remove tests tagged fails_strict_rfc2616

Signed-off-by: Casey Bodley <cbodley@redhat.com>

pytest: add global configfile and autouse teardown fixtures

Signed-off-by: Casey Bodley <cbodley@redhat.com>

pytest: add tox.ini to run pytest, update README

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #476 from cbodley/wip-botocore-sigv2

pin botocore to resolve v2 signature failures

pin botocore to resolve v2 signature failures

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #472 from galsalomon66/fixes_related_to_new_csv_parser_2

new CSV parser has some impact on engine results

remove comment

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>

Merge pull request #473 from cbodley/wip-copyobj-tails

add test_object_copy_16m to test refcounting of tail objects