]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
22 months agocommon/async: move service out of detail
Casey Bodley [Fri, 27 Jan 2023 17:22:06 +0000 (12:22 -0500)]
common/async: move service out of detail

Signed-off-by: Casey Bodley <cbodley@redhat.com>
22 months agoneorados/cls: Client for log objclass
Adam C. Emerson [Sat, 21 Jan 2023 06:03:48 +0000 (01:03 -0500)]
neorados/cls: Client for log objclass

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agoneorados/cls/version: Don't swallow exceptions
Adam C. Emerson [Thu, 2 Feb 2023 07:21:55 +0000 (02:21 -0500)]
neorados/cls/version: Don't swallow exceptions

Since they can be reported now, report them

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agoneorados/cls: cls::exec handles tuples properly
Adam C. Emerson [Wed, 25 Jan 2023 20:00:24 +0000 (15:00 -0500)]
neorados/cls: cls::exec handles tuples properly

If our decoder function returns a tuple of multiple values, flatten it
so our signature is `void(error_code, T, U, V)` not
`void(error_code, std::tuple<T, U, V>)`.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agocls/log: C++ namespaces exist
Adam C. Emerson [Tue, 24 Jan 2023 21:35:23 +0000 (16:35 -0500)]
cls/log: C++ namespaces exist

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agocls/log: Switch from utime_t to ceph::real_time
Adam C. Emerson [Tue, 24 Jan 2023 08:12:21 +0000 (03:12 -0500)]
cls/log: Switch from utime_t to ceph::real_time

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agocls/log: Add non-default constructors to cls_log_entry
Adam C. Emerson [Tue, 24 Jan 2023 06:53:20 +0000 (01:53 -0500)]
cls/log: Add non-default constructors to cls_log_entry

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agocls/log: Switch from std::list to std::vector
Adam C. Emerson [Sat, 21 Jan 2023 04:24:28 +0000 (23:24 -0500)]
cls/log: Switch from std::list to std::vector

We should not be using std::list everywhere, and this is an excellent
time to switch.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agocommon/async: add co_throttle for bounded concurrency with c++20 coroutines
Casey Bodley [Wed, 11 Jan 2023 15:45:49 +0000 (10:45 -0500)]
common/async: add co_throttle for bounded concurrency with c++20 coroutines

Signed-off-by: Casey Bodley <cbodley@redhat.com>
22 months agocommon/async: add service template for execution_context shutdown
Casey Bodley [Wed, 11 Jan 2023 18:41:50 +0000 (13:41 -0500)]
common/async: add service template for execution_context shutdown

Signed-off-by: Casey Bodley <cbodley@redhat.com>
22 months agocommon/async: handler wrappers forward associated cancellation_slot
Casey Bodley [Thu, 12 Jan 2023 02:02:57 +0000 (21:02 -0500)]
common/async: handler wrappers forward associated cancellation_slot

Signed-off-by: Casey Bodley <cbodley@redhat.com>
22 months agoneorados/cls: Client for version objclass
Adam C. Emerson [Sat, 21 Jan 2023 02:50:50 +0000 (21:50 -0500)]
neorados/cls: Client for version objclass

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agoneorados/cls: Helper function for reading CLS values
Adam C. Emerson [Sat, 21 Jan 2023 01:58:00 +0000 (20:58 -0500)]
neorados/cls: Helper function for reading CLS values

Since reading CLS values in a friendly way requires calling out to RADOS
then decoding the returned structure, make a function to help with that.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agocls/version: Add non-default constructor
Adam C. Emerson [Mon, 23 Jan 2023 22:51:02 +0000 (17:51 -0500)]
cls/version: Add non-default constructor

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agocls/version: Move obj_version printer to cls_version_types.h
Adam C. Emerson [Mon, 23 Jan 2023 22:28:10 +0000 (17:28 -0500)]
cls/version: Move obj_version printer to cls_version_types.h

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agobuild: Make `tests` depend on `neorados`
Adam Emerson [Fri, 8 Sep 2023 02:47:04 +0000 (22:47 -0400)]
build: Make `tests` depend on `neorados`

To make sure it's built by `make check`.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agotest/neorados: Rounding out test coverage, part 3
Adam Emerson [Tue, 29 Aug 2023 22:14:26 +0000 (18:14 -0400)]
test/neorados: Rounding out test coverage, part 3

This includes snapshots and watch_notify

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoneorados: Notify fixes
Adam Emerson [Fri, 8 Sep 2023 20:50:46 +0000 (16:50 -0400)]
neorados: Notify fixes

1. Objecter expects a count of seconds, not milliseconds
2. Actually return result

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoneorados: Validate pointers from watch cookies
Adam Emerson [Thu, 7 Sep 2023 21:35:40 +0000 (17:35 -0400)]
neorados: Validate pointers from watch cookies

Since Objecter has a set used to validate pointers converted from
watch cookies before dereferencing them, expose a function to do so.

Also make the set a `std::unordered_set` since we use it for only this
purpose.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoneorados: More snapshot support
Adam Emerson [Tue, 29 Aug 2023 22:13:55 +0000 (18:13 -0400)]
neorados: More snapshot support

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoosdc: with_osdmap should be const
Adam Emerson [Tue, 29 Aug 2023 22:13:35 +0000 (18:13 -0400)]
osdc: with_osdmap should be const

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoneorados: `execute` returns success on empty operations
Adam Emerson [Fri, 8 Sep 2023 16:48:39 +0000 (12:48 -0400)]
neorados: `execute` returns success on empty operations

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agotest/neorados: Rounding out test coverage, part 2
Adam Emerson [Mon, 14 Aug 2023 20:01:02 +0000 (16:01 -0400)]
test/neorados: Rounding out test coverage, part 2

This includes write_operations, io, misc, and pool.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoneorados: Moved-from operations are equivalent to new
Adam Emerson [Mon, 21 Aug 2023 21:28:05 +0000 (17:28 -0400)]
neorados: Moved-from operations are equivalent to new

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoneorados: Make neorados::Entry aggregate initializable
Adam Emerson [Fri, 18 Aug 2023 22:07:22 +0000 (18:07 -0400)]
neorados: Make neorados::Entry aggregate initializable

Now that C++20 has designated initializers, this is the least
confusing way to handle objects like this.

Also switch to using the spaceship operator, while we're at it.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoneorados/test: Support erasure coded pools
Adam Emerson [Thu, 17 Aug 2023 18:39:15 +0000 (14:39 -0400)]
neorados/test: Support erasure coded pools

The test framework in common test can now support erasure-coded pools
and be more easily extended generally.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoneorados: Take `claim_append`ed `buffer::list`s by value
Adam Emerson [Mon, 14 Aug 2023 23:11:27 +0000 (19:11 -0400)]
neorados: Take `claim_append`ed `buffer::list`s by value

Since both const lvalue and rvalue make sense, instead of duplicating
everything, just take a value and move from it.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agotest/neorados: Rounding out test coverage, part 1
Adam Emerson [Mon, 7 Aug 2023 17:21:10 +0000 (13:21 -0400)]
test/neorados: Rounding out test coverage, part 1

This includes cls, cmd, and read_operations.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoneorados: Implement `ReadOp::checksum`
Adam Emerson [Thu, 10 Aug 2023 02:00:24 +0000 (22:00 -0400)]
neorados: Implement `ReadOp::checksum`

Rather than using `buffer::list`s for initial values and hash results,
serialize to/from the expected types.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agotest/neorados: common_tests gets functions for bufferlists
Adam Emerson [Thu, 10 Aug 2023 01:57:41 +0000 (21:57 -0400)]
test/neorados: common_tests gets functions for bufferlists

Mostly for getting things into and out of them conveniently.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoneorados: Improve `cmp_omap` argument structure
Adam Emerson [Thu, 10 Aug 2023 03:59:34 +0000 (23:59 -0400)]
neorados: Improve `cmp_omap` argument structure

A map from strings to value/op pairs is a bit much and a bit annoying
for what's essentially a list of assertions. Just use a vector.

Also put op in the middle so it matches `cmpxattr`.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoneorados: Change `cmpxattr_op` to `cmp_op` and use in `Op::cmp_omap`
Adam Emerson [Wed, 9 Aug 2023 03:19:24 +0000 (23:19 -0400)]
neorados: Change `cmpxattr_op` to `cmp_op` and use in `Op::cmp_omap`

Omap and Xattr comparison use the same values, but in the Xattr case
it's eight bits wide.

Rename the enum to `cmp_op` to reflect this, and open-code encoding
the assertions so we don't have to allocate an intermediate structure.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoneorados: Fix `Op::cmpext` error and unfound behavior
Adam Emerson [Wed, 9 Aug 2023 00:38:24 +0000 (20:38 -0400)]
neorados: Fix `Op::cmpext` error and unfound behavior

A failure will produce the output `osd_errc::cmpext_failed`. On
failure, the `unfound` out parameter, if provided, will be set to the
index of the first nonmatching character; On success, it will be set
to `-1`.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agocommon/ceph_json: `encode_json()` for `std::array`
Adam Emerson [Mon, 7 Aug 2023 19:36:27 +0000 (15:36 -0400)]
common/ceph_json: `encode_json()` for `std::array`

No decode, though, since JSON arrays can vary in length and
`std::array` cannot.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
22 months agoneorados: Op builder functions should chain
Adam C. Emerson [Mon, 20 Mar 2023 16:20:38 +0000 (12:20 -0400)]
neorados: Op builder functions should chain

Make every operation function return the (Read/Write)Op, for chaining.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agoneorados: Use `asio::any_completion_handler`
Adam C. Emerson [Wed, 29 Mar 2023 05:35:22 +0000 (01:35 -0400)]
neorados: Use `asio::any_completion_handler`

As we'd like to reduce (and eliminate) internal Ceph dependencies to
the extent possible, now that Boost.Asio has a type-erased handler
type, let's use it.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agocmake: drop BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT
Casey Bodley [Thu, 9 Feb 2023 23:43:10 +0000 (18:43 -0500)]
cmake: drop BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT

this define was added for backward compatibility before boost 1.74

https://www.boost.org/doc/libs/1_74_0/doc/html/boost_asio/std_executors.html

Signed-off-by: Casey Bodley <cbodley@redhat.com>
22 months agosubmodule: update spawn submodule for any_io_executor
Casey Bodley [Tue, 14 Feb 2023 15:28:51 +0000 (10:28 -0500)]
submodule: update spawn submodule for any_io_executor

Signed-off-by: Casey Bodley <cbodley@redhat.com>
22 months agotest/common: test_blocked_completion uses boost::asio::post()
Casey Bodley [Fri, 10 Feb 2023 19:54:51 +0000 (14:54 -0500)]
test/common: test_blocked_completion uses boost::asio::post()

Signed-off-by: Casey Bodley <cbodley@redhat.com>
22 months agolibrbd: use strand template and make_strand()
Casey Bodley [Fri, 10 Feb 2023 15:36:57 +0000 (10:36 -0500)]
librbd: use strand template and make_strand()

Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agoneorados: use strand template and make_strand()
Casey Bodley [Fri, 10 Feb 2023 15:36:22 +0000 (10:36 -0500)]
neorados: use strand template and make_strand()

Signed-off-by: Casey Bodley <cbodley@redhat.com>
22 months agocommon/async: SharedMutex uses free function post
Casey Bodley [Thu, 9 Feb 2023 23:58:21 +0000 (18:58 -0500)]
common/async: SharedMutex uses free function post

Signed-off-by: Casey Bodley <cbodley@redhat.com>
22 months agocommon/async: completion uses free functions for defer/dispatch/post
Casey Bodley [Thu, 9 Feb 2023 21:41:53 +0000 (16:41 -0500)]
common/async: completion uses free functions for defer/dispatch/post

Signed-off-by: Casey Bodley <cbodley@redhat.com>
22 months agoosdc: replace asio::io_context::strand with asio::strand<>
Casey Bodley [Thu, 9 Feb 2023 19:46:27 +0000 (14:46 -0500)]
osdc: replace asio::io_context::strand with asio::strand<>

Signed-off-by: Casey Bodley <cbodley@redhat.com>
22 months agoosdc: Catch exceptions thrown in CLS client decoders
Adam C. Emerson [Thu, 2 Feb 2023 06:14:35 +0000 (01:14 -0500)]
osdc: Catch exceptions thrown in CLS client decoders

And return them to the client by setting the error code and result in
the vector and returning an error from the operation as a whole.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agotest/neorados: Harness and convenience for Neorados tests
Adam C. Emerson [Sat, 21 Jan 2023 02:35:41 +0000 (21:35 -0500)]
test/neorados: Harness and convenience for Neorados tests

Google Test does not support C++ coroutines, so kludge together a test
harness that supports coroutines reasonably well.

Also add a couple utility functions.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agocommon/async: Don't get allocator from moved-from handler
Adam C. Emerson [Tue, 24 Jan 2023 03:50:58 +0000 (22:50 -0500)]
common/async: Don't get allocator from moved-from handler

In the `destroy_` functions of `CompletionImpl` we were getting the
associated allocator after moving out of the handler into the call to
`bind_and_forward`. This was triggering a crash on null-pointer access
in operations made with `co_composed`.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agoneorados: Use C++20 Coroutines in exerciser/demo
Adam C. Emerson [Thu, 15 Sep 2022 20:42:51 +0000 (16:42 -0400)]
neorados: Use C++20 Coroutines in exerciser/demo

Just as a demonstration to see how well they work and how to put
things together with them.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agoneorados: Fix logic error in exerciser
Adam C. Emerson [Thu, 15 Sep 2022 18:46:47 +0000 (14:46 -0400)]
neorados: Fix logic error in exerciser

Use `min` rather than `max` when deciding how much we need to read in
`read()`.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agoneorados: Ensure we don't have dangling references
Adam C. Emerson [Thu, 17 Mar 2022 19:50:45 +0000 (15:50 -0400)]
neorados: Ensure we don't have dangling references

Apparently in some cases we were using references to objects on the
caller stack that happen to no longer exist if the caller's stack goes
away.

C++20 Coroutines tickled this bug.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agoneorados: Don't call dispatch inside with_osdmap
Adam C. Emerson [Thu, 17 Mar 2022 16:30:19 +0000 (12:30 -0400)]
neorados: Don't call dispatch inside with_osdmap

The lock will continue to be held over the 'dispatch' with C++20
coroutines.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agoneorados: Switch to async_initiate
Adam C. Emerson [Wed, 9 Mar 2022 00:14:59 +0000 (19:14 -0500)]
neorados: Switch to async_initiate

This form of completion handling is compatible with C++20 Completions
and generally more flexible stuff.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agoneorados: Remove 'broken out' versions of calls
Adam C. Emerson [Wed, 9 Mar 2022 23:58:11 +0000 (18:58 -0500)]
neorados: Remove 'broken out' versions of calls

Previously we had versions of all the calls that took an int64_t and
optional key and namespace.

This didn't really offer much benefit and doubled the maintenance
burden for changing anything.

As such just make the IOContext constructor non-explicit, and make all
its mutators return the same IOContext so people can supply them
builder-style if they want to.

Only wrap some things in optional, when it actually makes it easier.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
22 months agoMerge pull request #53296 from phlogistonjohn/jjm-fix-git-ls-files 52810/head
Adam King [Thu, 14 Sep 2023 17:10:16 +0000 (13:10 -0400)]
Merge pull request #53296 from phlogistonjohn/jjm-fix-git-ls-files

cephadm: remove duplicates when listing files in scan

Reviewed-by: Adam King <adking@redhat.com>
22 months agoMerge pull request #52690 from phlogistonjohn/jjm-cephadm-daemon-ident
Adam King [Thu, 14 Sep 2023 15:23:38 +0000 (11:23 -0400)]
Merge pull request #52690 from phlogistonjohn/jjm-cephadm-daemon-ident

cephadm: refactor code to make use of DaemonIdentity type

Reviewed-by: Adam King <adking@redhat.com>
22 months agoMerge pull request #53450 from zdover23/wip-doc-2023-09-14-man-ceph-monstore-tool
zdover23 [Thu, 14 Sep 2023 11:44:15 +0000 (21:44 +1000)]
Merge pull request #53450 from zdover23/wip-doc-2023-09-14-man-ceph-monstore-tool

doc/man: edit ceph-monstore-tool.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
22 months agoMerge pull request #53426 from ronen-fr/wip-rf-fshut
Ronen Friedman [Thu, 14 Sep 2023 10:33:46 +0000 (13:33 +0300)]
Merge pull request #53426 from ronen-fr/wip-rf-fshut

osd: cleaning stop_for_fast_shutdown()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
22 months agoMerge PR #53070 into main
Venky Shankar [Thu, 14 Sep 2023 10:09:07 +0000 (15:39 +0530)]
Merge PR #53070 into main

* refs/pull/53070/head:
PendingReleaseNotes: add note about 'm' and 'M' periods
doc/cephfs: add note about monthly scheduling and retention period
qa: update minute period multiplier to m
qa: change minute duration specifier from M to m
mgr/snap_schedule: change minute duration specifier from M to m

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
22 months agoMerge pull request #53433 from myoungwon/fix-53232
Yingxin [Thu, 14 Sep 2023 07:15:24 +0000 (15:15 +0800)]
Merge pull request #53433 from myoungwon/fix-53232

crimson/tools/perf_staged_fltree: fix compile error

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Aravind Ramesh <aravind.ramesh@wdc.com>
22 months agoMerge PR #51891 into main
Venky Shankar [Thu, 14 Sep 2023 03:59:07 +0000 (09:29 +0530)]
Merge PR #51891 into main

* refs/pull/51891/head:
qa: fix cephfs-top tests for the new fields
cephfs-top: include the missing fields in --dump output

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
22 months agoMerge pull request #53444 from zdover23/wip-doc-2023-09-14-architecture-4-of-x
zdover23 [Thu, 14 Sep 2023 03:27:52 +0000 (13:27 +1000)]
Merge pull request #53444 from zdover23/wip-doc-2023-09-14-architecture-4-of-x

doc/architecture: edit "High Avail. Monitors"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
22 months agodoc/man: edit ceph-monstore-tool.rst 53450/head
Zac Dover [Thu, 14 Sep 2023 03:24:11 +0000 (13:24 +1000)]
doc/man: edit ceph-monstore-tool.rst

Clean up the English in doc/man/8/ceph-monstore-tool.rst. Put all
commands in the imperative mood; make sentences more direct.

Follows https://github.com/ceph/ceph/pull/52860.

Signed-off-by: Zac Dover <zac.dover@proton.me>
22 months agodoc/architecture: edit "High Avail. Monitors" 53444/head
Zac Dover [Wed, 13 Sep 2023 14:09:45 +0000 (00:09 +1000)]
doc/architecture: edit "High Avail. Monitors"

Improve the sentence structure in the "High Availability Monitors"
section of doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
22 months agoMerge pull request #53178 from aclamk/wip-aclamk-bs-esb-5-enabled
Radoslaw Zarzynski [Wed, 13 Sep 2023 19:45:47 +0000 (21:45 +0200)]
Merge pull request #53178 from aclamk/wip-aclamk-bs-esb-5-enabled

bluestore: Elastic Shared Blobs 5 - enabled, final

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com
22 months agocephadm: fix an error running iscsi services 52690/head
John Mulligan [Wed, 13 Sep 2023 19:44:40 +0000 (15:44 -0400)]
cephadm: fix an error running iscsi services

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agoMerge pull request #52793 from linuxbox2/wip-fix-test-librgw-xattr
Matt Benjamin [Wed, 13 Sep 2023 16:57:52 +0000 (12:57 -0400)]
Merge pull request #52793 from linuxbox2/wip-fix-test-librgw-xattr

rgw/file:  fix build of librgw_file_xattr.cc unit test

22 months agoMerge pull request #51368 from dang/wip-dang-zipper-motr
Daniel Gryniewicz [Wed, 13 Sep 2023 13:35:39 +0000 (09:35 -0400)]
Merge pull request #51368 from dang/wip-dang-zipper-motr

Fix MOTR build, and move MOTR and DAOS to proper location

22 months agoMerge pull request #53391 from shreyanshjain7174/bucket_quota
Ali Maredia [Wed, 13 Sep 2023 11:46:19 +0000 (07:46 -0400)]
Merge pull request #53391 from shreyanshjain7174/bucket_quota

RadosGW API: incorrect bucket quota in response to HEAD /{bucket}/?usage

Reviewed-by: Ali Maredia <amaredia@redhat.com>
22 months agocrimson/tools/perf_staged_fltree: fix compile error 53433/head
Myoungwon Oh [Wed, 13 Sep 2023 05:16:16 +0000 (14:16 +0900)]
crimson/tools/perf_staged_fltree: fix compile error

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
22 months agoMerge pull request #53423 from zdover23/wip-doc-2023-09-12-architecture-3-of-x
zdover23 [Wed, 13 Sep 2023 07:07:26 +0000 (17:07 +1000)]
Merge pull request #53423 from zdover23/wip-doc-2023-09-12-architecture-3-of-x

doc/architecture: edit "Cluster Map"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
22 months agoMerge PR #53153 into main
Venky Shankar [Wed, 13 Sep 2023 05:40:59 +0000 (11:10 +0530)]
Merge PR #53153 into main

* refs/pull/53153/head:
Revert "mds: align quota.max_bytes to 4MB or 4KB"

Reviewed-by: Xiubo Li <xiubli@redhat.com>
22 months agoMerge pull request #53370 from wowly/rgw-cache-nginx-if-match-header
Casey Bodley [Tue, 12 Sep 2023 18:27:00 +0000 (19:27 +0100)]
Merge pull request #53370 from wowly/rgw-cache-nginx-if-match-header

examples: fixed errors with the if-match header in the examples of rgw-cache nginx configs

Reviewed-by: Casey Bodley <cbodley@redhat.com>
22 months agodoc/architecture: edit "Cluster Map" 53423/head
Zac Dover [Tue, 12 Sep 2023 11:17:40 +0000 (21:17 +1000)]
doc/architecture: edit "Cluster Map"

Edit the section "Cluster Map" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
22 months agoMerge pull request #53422 from zdover23/wip-doc-2023-09-12-glossary-primary-affinity
Anthony D'Atri [Tue, 12 Sep 2023 16:00:08 +0000 (12:00 -0400)]
Merge pull request #53422 from zdover23/wip-doc-2023-09-12-glossary-primary-affinity

doc/glossary: add "primary affinity" to glossary

22 months agoosd: cleaning stop_for_fast_shutdown() 53426/head
Ronen Friedman [Tue, 12 Sep 2023 13:15:40 +0000 (08:15 -0500)]
osd: cleaning stop_for_fast_shutdown()

Removed unsued variables to prevent compiler warnings.
Protected the shard lock.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
22 months agoMerge pull request #52407 from rhcs-dashboard/osd-op-scraper
Adam Kupczyk [Tue, 12 Sep 2023 15:47:52 +0000 (17:47 +0200)]
Merge pull request #52407 from rhcs-dashboard/osd-op-scraper

os/bluestore: osd scrape read/write operations

22 months agoos/bluestore: osd scrape read/write operations 52407/head
Pere Diaz Bou [Wed, 12 Jul 2023 11:05:17 +0000 (13:05 +0200)]
os/bluestore: osd scrape read/write operations

To run:
```bash
../src/test/objectstore/allocsim/ops_scraper.py --ceph_bin_path bin/ceph
```

Example:
```bash
$ ../src/test/objectstore/allocsim/ops_scraper.py --ceph_bin_path bin/ceph                                                                           [13:06:39]
collecting from osd. 0
op_type | offset/extent | name | pgid | initiated_at | who
-------------------------------------------------------
write 0~4194304 4:c4b97d2c:::be151868021c187609fb97e4c22ae1f9:head 4.3 2023-07-12T13:06:34.959082+0200 client.4831.0:351
write 0~4194304 4:d392075e:::b068dce954dca8ca56d72e02e87f39c8:head 4.b 2023-07-12T13:06:35.093439+0200 client.4831.0:358
write 0~4194304 4:bc1ac643:::7b815bd25a40695c891dc06bdf2b65be:head 4.1d 2023-07-12T13:06:35.128097+0200 client.4831.0:360
write 0~4194304 4:d0d21bd5:::cc531199dd2707370bb461cce82bdef6:head 4.b 2023-07-12T13:06:36.023082+0200 client.4831.0:367
write 0~4194304 4:a9abc92c:::0703d6f43d14bc33d69f94ecb96c522c:head 4.15 2023-07-12T13:06:36.367886+0200 client.4831.0:369
write 0~4194304 4:9b4684ea:::d5856dc0ecad96f811012e0937d5e0ac:head 4.19 2023-07-12T13:06:36.654584+0200 client.4831.0:370
write 0~4194304 4:d15b8c87:::c3344e5de8c8936876965d9fb056ad89:head 4.b 2023-07-12T13:06:36.835690+0200 client.4831.0:371
write 0~4194304 4:ad41de2a:::8a1e2743b577a67d6bc8a1d514391b53:head 4.15 2023-07-12T13:06:37.102741+0200 client.4831.0:373
write 0~4194304 4:fc35d54f:::39cd961e7e33680f4bfd1ca0fe43dda4:head 4.1f 2023-07-12T13:06:38.047612+0200 client.4831.0:377

collecting from osd. 1
op_type | offset/extent | name | pgid | initiated_at | who
-------------------------------------------------------
write 0~4194304 4:4c9ed2e8:::86206ccc35d8aceaf78670a751a6b550:head 4.12 2023-07-12T13:06:34.771423+0200 client.4831.0:340
write 0~4194304 4:106d9524:::fe7534cc604b0eb50498cb23aaca9161:head 4.8 2023-07-12T13:06:35.128105+0200 client.4831.0:359
write 0~4194304 4:a6e3fdb1:::2692491bfc4c584ca5b1efcb896936c2:head 4.5 2023-07-12T13:06:35.567070+0200 client.4831.0:363
write 0~4194304 4:2d9a471a:::ba51255646d00c496c2638bad03e0869:head 4.14 2023-07-12T13:06:35.568290+0200 client.4831.0:364
write 0~4194304 4:2b1381b1:::c58fa31e5d3a4f5550ee143bcb07a49f:head 4.14 2023-07-12T13:06:35.764699+0200 client.4831.0:365
write 0~4194304 4:a22e158f:::b2116e08700da18595b96d58120fe81c:head 4.5 2023-07-12T13:06:36.023101+0200 client.4831.0:366
```

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
22 months agoMerge pull request #53419 from AliMasarweh/wip-alimasa-persistent-q-test
Ali Masarwa [Tue, 12 Sep 2023 13:51:25 +0000 (16:51 +0300)]
Merge pull request #53419 from AliMasarweh/wip-alimasa-persistent-q-test

RGW | bucket notification: adding more sleeping time to prevent test from failing

Reviewed-by: yuvalif <ylifshit@redhat.com>
22 months agoqa: fix cephfs-top tests for the new fields 51891/head
Jos Collin [Fri, 2 Jun 2023 11:09:49 +0000 (16:39 +0530)]
qa: fix cephfs-top tests for the new fields

Fixes: https://tracker.ceph.com/issues/61397
Signed-off-by: Jos Collin <jcollin@redhat.com>
22 months agocephfs-top: include the missing fields in --dump output
Jos Collin [Fri, 2 Jun 2023 11:08:29 +0000 (16:38 +0530)]
cephfs-top: include the missing fields in --dump output

Fixes: https://tracker.ceph.com/issues/61397
Signed-off-by: Jos Collin <jcollin@redhat.com>
22 months agodoc/glossary: add "primary affinity" to glossary 53422/head
Zac Dover [Tue, 12 Sep 2023 10:56:03 +0000 (20:56 +1000)]
doc/glossary: add "primary affinity" to glossary

Add "Primary Affinity" to the glossary and link to the information in
the RADOS documentation that (more or less) explains it.

Signed-off-by: Zac Dover <zac.dover@proton.me>
22 months agoRGW | bucket notification: adding more sleeping time to prevent test from failing 53419/head
Ali Masarwa [Tue, 12 Sep 2023 10:31:31 +0000 (13:31 +0300)]
RGW | bucket notification: adding more sleeping time to prevent test from failing

Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
22 months agoPendingReleaseNotes: add note about 'm' and 'M' periods 53070/head
Milind Changire [Tue, 12 Sep 2023 08:39:39 +0000 (14:09 +0530)]
PendingReleaseNotes: add note about 'm' and 'M' periods

Signed-off-by: Milind Changire <mchangir@redhat.com>
22 months agodoc/cephfs: add note about monthly scheduling and retention period
Milind Changire [Thu, 24 Aug 2023 02:19:43 +0000 (07:49 +0530)]
doc/cephfs: add note about monthly scheduling and retention period

Fixes: https://tracker.ceph.com/issues/62494
Signed-off-by: Milind Changire <mchangir@redhat.com>
22 months agoqa: update minute period multiplier to m
Milind Changire [Tue, 12 Sep 2023 08:30:33 +0000 (14:00 +0530)]
qa: update minute period multiplier to m

Signed-off-by: Milind Changire <mchangir@redhat.com>
22 months agoqa: change minute duration specifier from M to m
Milind Changire [Thu, 24 Aug 2023 02:18:17 +0000 (07:48 +0530)]
qa: change minute duration specifier from M to m

Fixes: https://tracker.ceph.com/issues/62494
Signed-off-by: Milind Changire <mchangir@redhat.com>
22 months agomgr/snap_schedule: change minute duration specifier from M to m
Milind Changire [Thu, 24 Aug 2023 02:17:46 +0000 (07:47 +0530)]
mgr/snap_schedule: change minute duration specifier from M to m

Problem:
As per the issue tracker, the period spec specifier 'M' is not
consistent with what is used elsewhere, like the period specifiers
displayed in the 'ceph status' command output.
The 'M' period specifier is used as a 'minute' level period specifier by
the cephfs team.
The issue reporter suggests to use 'M' as a 'month' period specifier.

Solution:
Since the 'minute' level period specifer, 'M', is used internally by
the development team, it is failrly easy to swap the 'minute' ('M')
level and 'month' ('m') level period specifers to finally mean that 'm'
implies 'minute' level period and 'M' implies 'month' level period.
Also, since this is the first time that somebody has ever reported that
neither the 'M' nor the 'm' level specifiers work in production, it is a
good idea to fix them once and for all.

Fixes: https://tracker.ceph.com/issues/62494
Signed-off-by: Milind Changire <mchangir@redhat.com>
22 months agoMerge pull request #53408 from roysahar/nvmeof_fix_omap_state_object_contains_None
Roy Sahar [Tue, 12 Sep 2023 07:43:24 +0000 (10:43 +0300)]
Merge pull request #53408 from roysahar/nvmeof_fix_omap_state_object_contains_None

nvmeof-gw: omap object name contains None as string due to generated template to ceph-nvmeof.conf

22 months agoMerge pull request #53232 from myoungwon/wip-enable-rbm-tests
Liu-Chunmei [Tue, 12 Sep 2023 06:25:24 +0000 (23:25 -0700)]
Merge pull request #53232 from myoungwon/wip-enable-rbm-tests

test/crimson/seastore/rbm: add sub-tests regarding RBM to the existing tests

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Liu-Chunmei <chunmei.liu@intel.com>
22 months agocrimson/os/seastore/object_data_handler: consider a RBM case when checking if write... 53232/head
Myoungwon Oh [Fri, 25 Aug 2023 08:55:36 +0000 (17:55 +0900)]
crimson/os/seastore/object_data_handler: consider a RBM case when checking if write can be merged

RBM's paddr always indicates physical address, which means it doesn't have the dealayed.
So, this commit adds a condition that checks if given paddr is used for ongoing write.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
22 months agoMerge pull request #53305 from xxhdx1985126/wip-seastore-onode-erase-replay
Yingxin [Tue, 12 Sep 2023 01:21:29 +0000 (09:21 +0800)]
Merge pull request #53305 from xxhdx1985126/wip-seastore-onode-erase-replay

crimson/os/seastore/onode_manager: populate value recorders of onodes to be erased

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
22 months agonvmeof-gw: omap object name contains None due to generated template contains string... 53408/head
Roy Sahar [Mon, 11 Sep 2023 22:52:53 +0000 (01:52 +0300)]
nvmeof-gw: omap object name contains None due to generated template contains string None

Signed-off-by: Roy Sahar <royswi@gmail.com>
22 months agoMerge pull request #53344 from ljflores/wip-tracker-62761
Laura Flores [Mon, 11 Sep 2023 22:22:03 +0000 (18:22 -0400)]
Merge pull request #53344 from ljflores/wip-tracker-62761

common: add CephContext parameter to tracing::Tracer::init() in !HAVE_JAEGER branch

22 months agocephadm: convert _write_iscsi_unit_poststop_commands to to use a DaemonIdentity argument
John Mulligan [Thu, 27 Jul 2023 00:08:23 +0000 (20:08 -0400)]
cephadm: convert _write_iscsi_unit_poststop_commands to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert _write_osd_unit_poststop_commands to to use a DaemonIdentity argument
John Mulligan [Thu, 27 Jul 2023 00:05:03 +0000 (20:05 -0400)]
cephadm: convert _write_osd_unit_poststop_commands to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert _write_iscsi_unit_run_commands to to use a DaemonIdentity argument
John Mulligan [Thu, 27 Jul 2023 00:01:26 +0000 (20:01 -0400)]
cephadm: convert _write_iscsi_unit_run_commands to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert _write_osd_unit_run_commands to to use a DaemonIdentity argument
John Mulligan [Thu, 27 Jul 2023 00:00:01 +0000 (20:00 -0400)]
cephadm: convert _write_osd_unit_run_commands to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert _dispatch_deploy to to use a DaemonIdentity argument
John Mulligan [Wed, 26 Jul 2023 23:53:58 +0000 (19:53 -0400)]
cephadm: convert _dispatch_deploy to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert get_deployment_type to to use a DaemonIdentity argument
John Mulligan [Wed, 26 Jul 2023 23:50:16 +0000 (19:50 -0400)]
cephadm: convert get_deployment_type to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>
22 months agocephadm: convert get_deployment_container to to use a DaemonIdentity argument
John Mulligan [Wed, 26 Jul 2023 23:40:30 +0000 (19:40 -0400)]
cephadm: convert get_deployment_container to to use a DaemonIdentity argument

Signed-off-by: John Mulligan <jmulligan@redhat.com>