]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/log
ceph-ci.git
2 months agoMerge pull request #64536 from bluikko/doc-cloud-transition-link-plus-radosgw
Anthony D'Atri [Wed, 16 Jul 2025 17:31:13 +0000 (13:31 -0400)]
Merge pull request #64536 from bluikko/doc-cloud-transition-link-plus-radosgw

doc/radosgw: Internal link and single-keystroke improvements

2 months agoMerge PR #64229 into main
Venky Shankar [Wed, 16 Jul 2025 17:05:49 +0000 (22:35 +0530)]
Merge PR #64229 into main

* refs/pull/64229/head:
doc/cephfs: add mds_allow_batched_ops to conf ref
mds: nudge log for unstable locks after early_reply
mds: allow disabling batch ops
common/options: chomp whitespace

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 months agoMerge pull request #64517 from Hezko/nvmeof-cli-help
afreen23 [Wed, 16 Jul 2025 15:28:07 +0000 (20:58 +0530)]
Merge pull request #64517 from Hezko/nvmeof-cli-help

mgr/dashboard: add help for nvmeof cli

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 months agoMerge pull request #64251 from nbalacha/wip-nbalacha-71730
Yuval Lifshitz [Wed, 16 Jul 2025 15:14:18 +0000 (18:14 +0300)]
Merge pull request #64251 from nbalacha/wip-nbalacha-71730

rgw: fix aclRequired for bucket-logging

2 months agoMerge pull request #64441 from aainscow/monstore_linker
Alex Ainscow [Wed, 16 Jul 2025 15:04:33 +0000 (16:04 +0100)]
Merge pull request #64441 from aainscow/monstore_linker

Fix ceph_monstore_tool linker error

2 months agodoc/radosgw: Internal link and single-keystroke improvements
Ville Ojamo [Wed, 16 Jul 2025 14:59:08 +0000 (21:59 +0700)]
doc/radosgw: Internal link and single-keystroke improvements

Use ref for hyperlink instead of abusing "external links" feature for
intra-docs link in cloud-transition.rst, add a label in
cloud-restore.rst for it.

Use auto-generated link text instead of manually adding that same
section title as link text in cloud-transition.rst.

One list item was missing a colon in s3_objects_dedup.rst.

Add space between number and units in s3_objects_dedup.rst.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 months agoMerge pull request #64526 from bluikko/doc-objects-dedup-improvements-radosgw
Anthony D'Atri [Wed, 16 Jul 2025 14:15:29 +0000 (10:15 -0400)]
Merge pull request #64526 from bluikko/doc-objects-dedup-improvements-radosgw

doc/radosgw: Small improvements in s3_objects_dedup.rst

2 months agoMerge pull request #64513 from gbregman/main
Gil Bregman [Wed, 16 Jul 2025 12:04:19 +0000 (15:04 +0300)]
Merge pull request #64513 from gbregman/main

mgr/cephadm/nvmeof: Add Prometheus fields to NVMeOF spec file

2 months agoMerge pull request #64433 from NitzanMordhai/wip-nitzan-mgr-notify_types-docs-update
Zac Dover [Wed, 16 Jul 2025 11:55:10 +0000 (21:55 +1000)]
Merge pull request #64433 from NitzanMordhai/wip-nitzan-mgr-notify_types-docs-update

doc: update mgr modules notify_types

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 months agoMerge pull request #64391 from ljflores/wip-tracker-70917
Ilya Dryomov [Wed, 16 Jul 2025 10:42:24 +0000 (12:42 +0200)]
Merge pull request #64391 from ljflores/wip-tracker-70917

test/rbd: remove unit tests about cache tiering

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 months agocmake: link memstore against os
Alex Ainscow [Thu, 10 Jul 2025 11:44:54 +0000 (12:44 +0100)]
cmake: link memstore against os

This fixes the following linker error:

FAILED: bin/ceph-monstore-tool
: && /usr/lib64/ccache/clang++ -g -g -Wl,--export-dynamic    -Xlinker --dependency-file=src/tools/CMakeFiles/ceph-monstore-tool.dir/link.d src/tools/CMakeFiles/ceph-monstore-tool.dir/ceph_monstore_tool.cc.o src/tools/CMakeFiles/ceph-monstore-tool.dir/__/auth/cephx/CephxKeyServer.cc.o src/tools/CMakeFiles/ceph-monstore-tool.dir/__/mgr/mgr_commands.cc.o -o bin/ceph-monstore-tool  -Wl,-rpath,/work/ceph/build/lib:  lib/libos.a  lib/libglobal.a  boost/lib/libboost_program_options.a  lib/libmemstore.a  lib/libkstore.a  lib/libkv.a  src/rocksdb/librocksdb.a  /usr/lib64/libsnappy.so  /usr/lib64/liblz4.so  /usr/lib64/libz.so  lib/libblk.a  /lib64/libaio.so  src/liburing/src/liburing.a  lib/libheap_profiler.a  /lib64/libtcmalloc.so  lib/libfusestore.a  /usr/lib64/libfuse.so  lib/libceph-common.so.2  boost/lib/libboost_program_options.a  lib/libfmtd.a  src/opentelemetry-cpp/sdk/src/trace/libopentelemetry_trace.a  src/opentelemetry-cpp/sdk/src/resource/libopentelemetry_resources.a  src/opentelemetry-cpp/sdk/src/common/libopentelemetry_common.a  src/opentelemetry-cpp/exporters/jaeger/libopentelemetry_exporter_jaeger_trace.a  src/opentelemetry-cpp/ext/src/http/client/curl/libopentelemetry_http_client_curl.a  /usr/lib64/libcurl.so  /usr/lib64/libthrift.so  lib/libjson_spirit.a  lib/libcommon_utf8.a  lib/liberasure_code.a  lib/libextblkdev.a  -lcap  boost/lib/libboost_thread.a  boost/lib/libboost_chrono.a  boost/lib/libboost_atomic.a  boost/lib/libboost_system.a  boost/lib/libboost_random.a  boost/lib/libboost_date_time.a  boost/lib/libboost_iostreams.a  boost/lib/libboost_regex.a  /usr/lib64/libblkid.so  /usr/lib64/libcrypto.so  /usr/lib64/libudev.so  /usr/lib64/libibverbs.so  /usr/lib64/librdmacm.so  /usr/lib64/libz.so  src/breakpad_project-prefix/lib/libbreakpad_client.a  -ldl  /usr/lib64/librt.a  -lresolv   -Wl,--as-needed -latomic && :
/opt/rh/gcc-toolset-14/root//usr/lib/gcc/x86_64-redhat-linux/14/../../../../bin/ld: lib/libmemstore.a(MemStore.cc.o): in function `MemStore::_do_transaction(ceph::os::Transaction&)':
/work/ceph/src/os/memstore/MemStore.cc:992:(.text+0xa074): undefined reference to `ceph::os::Transaction::dump(ceph::Formatter*)'
/opt/rh/gcc-toolset-14/root//usr/lib/gcc/x86_64-redhat-linux/14/../../../../bin/ld: lib/libmemstore.a(MemStore.cc.o): in function `ceph::os::Transaction::iterator::decode_attrset_bl(ceph::buffer::v15_2_0::list*)':
/work/ceph/src/os/Transaction.h:753:(.text._ZN4ceph2os11Transaction8iterator17decode_attrset_blEPNS_6buffer7v15_2_04listE[_ZN4ceph2os11Transaction8iterator17decode_attrset_blEPNS_6buffer7v15_2_04listE]+0x1d): undefined reference to `decode_str_str_map_to_bl(ceph::buffer::v15_2_0::list::iterator_impl<true>&, ceph::buffer::v15_2_0::list*)'
/opt/rh/gcc-toolset-14/root//usr/lib/gcc/x86_64-redhat-linux/14/../../../../bin/ld: lib/libmemstore.a(MemStore.cc.o): in function `ceph::os::Transaction::iterator::decode_keyset_bl(ceph::buffer::v15_2_0::list*)':
/work/ceph/src/os/Transaction.h:760:(.text._ZN4ceph2os11Transaction8iterator16decode_keyset_blEPNS_6buffer7v15_2_04listE[_ZN4ceph2os11Transaction8iterator16decode_keyset_blEPNS_6buffer7v15_2_04listE]+0x1d): undefined reference to `decode_str_set_to_bl(ceph::buffer::v15_2_0::list::iterator_impl<true>&, ceph::buffer::v15_2_0::list*)'
/opt/rh/gcc-toolset-14/root//usr/lib/gcc/x86_64-redhat-linux/14/../../../../bin/ld: lib/libmemstore.a(MemStore.cc.o): in function `ObjectStore::~ObjectStore()':
/work/ceph/src/os/ObjectStore.h:248:(.text._ZN11ObjectStoreD2Ev[_ZN11ObjectStoreD2Ev]+0x13): undefined reference to `vtable for ObjectStore'
/opt/rh/gcc-toolset-14/root//usr/lib/gcc/x86_64-redhat-linux/14/../../../../bin/ld: lib/libmemstore.a(MemStore.cc.o):(.data.rel.ro+0x1b0): undefined reference to `ObjectStore::write_meta(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/opt/rh/gcc-toolset-14/root//usr/lib/gcc/x86_64-redhat-linux/14/../../../../bin/ld: lib/libmemstore.a(MemStore.cc.o):(.data.rel.ro+0x1b8): undefined reference to `ObjectStore::read_meta(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*)'
/opt/rh/gcc-toolset-14/root//usr/lib/gcc/x86_64-redhat-linux/14/../../../../bin/ld: lib/libmemstore.a(MemStore.cc.o):(.data.rel.ro+0x2e8): undefined reference to `typeinfo for ObjectStore'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
[352/548] Linking CXX executable bin/crimson-osd
ninja: build stopped: subcommand failed.

The above shows that MemStore is not being correctly linked against os.

I don't understand why this is not affecting most builds, but I can say it has been introduced
after the T release was split.

This change addresses a regression introduced by 5ab2e9fb.

Fixes: https://tracker.ceph.com/issues/72078
Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
2 months agoMerge pull request #64520 from tchaikov/wip-librados-c-iwyu
Kefu Chai [Wed, 16 Jul 2025 10:18:11 +0000 (18:18 +0800)]
Merge pull request #64520 from tchaikov/wip-librados-c-iwyu

librados: remove unused includes in librados_c.cc

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
2 months agodoc/radosgw: Small improvements in s3_objects_dedup.rst
Ville Ojamo [Wed, 16 Jul 2025 08:21:20 +0000 (15:21 +0700)]
doc/radosgw: Small improvements in s3_objects_dedup.rst

Fix sentence that had "different same" to just "different" (verified the
right one from the original author).

Remove colon at the end of section titles.

Remove rendered horizontal lines between sections.

Use double backticks for command name.

Use regular apostrophe in one sentence to be consistent with the rest.

Add missing full stop at the end of several sentences.

Very small language improvements in a few sentences.

Use consistent indent in one line.

Remove hyphens from many word pairs and don't capitalize few terms.
For consistency with rest of the docs.

Fix typos "spliting" to "splitting", "underlined" to "underlying".

Spell out "thousands" instead of using an apostrophe after the number.

Reformat table to use row separators like rest of the docs instead of
empty columns.
Separate number and unit with a space. Remove rendered underscores that
seemed to be an attempt to imprecisely align cell contents to right.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2 months agoMerge pull request #63414 from tchaikov/osd-variant
Kefu Chai [Wed, 16 Jul 2025 08:55:40 +0000 (16:55 +0800)]
Merge pull request #63414 from tchaikov/osd-variant

osd: migrate from boost::variant to std::variant

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoMerge pull request #64121 from JonBailey1993/ceph_test_rados_io_sequence_chunksize_se...
Jon Bailey [Wed, 16 Jul 2025 08:42:36 +0000 (09:42 +0100)]
Merge pull request #64121 from JonBailey1993/ceph_test_rados_io_sequence_chunksize_selection_bug_fix

test/osd: Fix issue where ceph_test_rados_io_sequence could select a chunksize of zero

2 months agoMerge branch 'ceph:main' into main
Gil Bregman [Wed, 16 Jul 2025 08:21:46 +0000 (11:21 +0300)]
Merge branch 'ceph:main' into main

2 months agoMerge pull request #62701 from rhcs-dashboard/notification-create-api
Pedro Gonzalez Gomez [Wed, 16 Jul 2025 07:05:03 +0000 (09:05 +0200)]
Merge pull request #62701 from rhcs-dashboard/notification-create-api

mgr/dashboard: Notification endpoints for create ,list and delete

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pedro Gonzalez <pegonzal@redhat.com>
2 months agomgr/dashboard: add help for nvmeof cli
Tomer Haskalovitch [Tue, 15 Jul 2025 07:40:07 +0000 (10:40 +0300)]
mgr/dashboard: add help for nvmeof cli

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
2 months agoMerge PR #64325 into main
Venky Shankar [Wed, 16 Jul 2025 05:08:34 +0000 (10:38 +0530)]
Merge PR #64325 into main

* refs/pull/64325/head:
mdstypes: Dump export_ephemeral_random_pin as double

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2 months agoMerge pull request #64518 from adk3798/fix-smb-sd-config-unit-test-cephadm
Redouane Kachach [Wed, 16 Jul 2025 04:59:14 +0000 (06:59 +0200)]
Merge pull request #64518 from adk3798/fix-smb-sd-config-unit-test-cephadm

mgr/cephadm: fixing SMB service discovery UT

https://tracker.ceph.com/issues/72152

Reviewed-by: Redouane Kachach <rkachach@ibm.com>
2 months agoMerge pull request #64349 from nbalacha/wip-nbalacha-71731
anrao19 [Wed, 16 Jul 2025 04:58:10 +0000 (10:28 +0530)]
Merge pull request #64349 from nbalacha/wip-nbalacha-71731

rgw: fix bucket logging AuthType field

2 months agoosd: migrate from boost::variant to std::variant
Kefu Chai [Wed, 21 May 2025 03:38:47 +0000 (11:38 +0800)]
osd: migrate from boost::variant to std::variant

Replace boost::variant with std::variant throughout the OSD-related
codebase. This change reduces third-party dependencies by leveraging
the C++ standard library alternative.

Changes:
- common/inline_variant.h: Replace the existing match() helper with a
  wrapper around std::visit. The previous implementation constructed a
  visitor class from given functions; the new implementation provides
  equivalent functionality using standard library primitives.

- osd/osd_types.h: Add templated operator<< overload for std::variant.
  Since boost::variant provided a built-in operator<< that we relied on,
  and std::variant does not include this functionality, we implement our
  own formatter. To avoid ambiguous overload resolution (where types
  implicitly convertible to variant alternatives could match both the
  variant formatter and their native formatters), the template requires
  at least one alternative type parameter.

This migration maintains existing functionality while eliminating the
boost::variant dependency.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 months agoMerge pull request #63184 from JonBailey1993/ec_optimisation_deep_scrubbing_implement...
SrinivasaBharathKanta [Wed, 16 Jul 2025 04:35:47 +0000 (10:05 +0530)]
Merge pull request #63184 from JonBailey1993/ec_optimisation_deep_scrubbing_implementation

OSD: Optimised EC Deep Scrubbing Implementation

2 months agoMerge pull request #64355 from xxhdx1985126/wip-71976
Yingxin Cheng [Wed, 16 Jul 2025 02:31:43 +0000 (10:31 +0800)]
Merge pull request #64355 from xxhdx1985126/wip-71976

crimson/os/seastrore/omap_manager: initialize rewritten omap nodes when

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 months agoMerge pull request #64401 from cyx1231st/wip-yingxin-fix-extent-lifecycle-upon-load
Yingxin Cheng [Wed, 16 Jul 2025 02:28:11 +0000 (10:28 +0800)]
Merge pull request #64401 from cyx1231st/wip-yingxin-fix-extent-lifecycle-upon-load

crimson/os/seastore/cache: extend extent lifecycle after wait-io

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
2 months agoMerge pull request #64489 from chanyoung/cleanup-test-omap-replay
Yingxin Cheng [Wed, 16 Jul 2025 02:22:30 +0000 (10:22 +0800)]
Merge pull request #64489 from chanyoung/cleanup-test-omap-replay

test/crimson/seastore/test_omap_manager: redesign test replay

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 months agoMerge pull request #64499 from chanyoung/fix-leafnode-test
Yingxin Cheng [Wed, 16 Jul 2025 02:20:41 +0000 (10:20 +0800)]
Merge pull request #64499 from chanyoung/fix-leafnode-test

test/crimson/seastore/test_omap_manager: redesign test leafnodes

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 months agolibrados: remove unused includes in librados_c.cc
Kefu Chai [Wed, 16 Jul 2025 00:56:45 +0000 (08:56 +0800)]
librados: remove unused includes in librados_c.cc

Remove unused header includes from librados_c.cc to reduce unnecessary
dependencies. This cleanup was initially motivated by removing unused
linkage of cls_lock_client, but expanded to address all unused includes
in the file.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 months agoMerge pull request #62982 from samarahu/wip-rgw-d4n-next-test
J. Eric Ivancich [Wed, 16 Jul 2025 00:11:16 +0000 (20:11 -0400)]
Merge pull request #62982 from samarahu/wip-rgw-d4n-next-test

rgw: D4N Test Updates

Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
2 months agoMerge pull request #64158 from tchaikov/wip-doc-ext-cleanup
David Galloway [Tue, 15 Jul 2025 20:44:35 +0000 (16:44 -0400)]
Merge pull request #64158 from tchaikov/wip-doc-ext-cleanup

doc/_ext: cleanups

2 months agoMerge pull request #61020 from MaxKellermann/kvstore_tool__ifdef_WITH_BLUESTORE
Neha Ojha [Tue, 15 Jul 2025 19:28:59 +0000 (12:28 -0700)]
Merge pull request #61020 from MaxKellermann/kvstore_tool__ifdef_WITH_BLUESTORE

tools/kvstore_tool: add missing `#ifdef WITH_BLUESTORE`

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2 months agotest: remove unit tests about cache tiering
Laura Flores [Tue, 8 Jul 2025 18:49:03 +0000 (14:49 -0400)]
test: remove unit tests about cache tiering

Cache tiering was deprecated in the Reef release,
so we are no longer supporting any issues related
to it.

Ref: https://docs.ceph.com/en/latest/rados/operations/cache-tiering/

Fixes: https://tracker.ceph.com/issues/70917
Signed-off-by: Laura Flores <lflores@ibm.com>
2 months agomgr/cephadm: fixing SMB service discovery UT
Redouane Kachach [Tue, 15 Jul 2025 14:38:26 +0000 (16:38 +0200)]
mgr/cephadm: fixing SMB service discovery UT

Signed-off-by: Redouane Kachach <rkachach@ibm.com>
2 months agoMerge pull request #64261 from tchaikov/wip-cmake-cls_rbd_client-with-neorados
Ilya Dryomov [Tue, 15 Jul 2025 17:04:58 +0000 (19:04 +0200)]
Merge pull request #64261 from tchaikov/wip-cmake-cls_rbd_client-with-neorados

cmake: Remove unused cls_lock_client linkage

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 months agoMerge pull request #62530 from liu-chunmei/omap_iterate
Matan Breizman [Tue, 15 Jul 2025 14:54:21 +0000 (17:54 +0300)]
Merge pull request #62530 from liu-chunmei/omap_iterate

crimson: implement crimson Omap iterate interface

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 months agomgr/cephadm/nvmeof: Add Prometheus filds to NVMeOF spec file.
Gil Bregman [Tue, 15 Jul 2025 14:52:12 +0000 (17:52 +0300)]
mgr/cephadm/nvmeof: Add Prometheus filds to NVMeOF spec file.

Fixes: https://tracker.ceph.com/issues/72142
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
2 months agoMerge pull request #64184 from kshtsk/wip-allow-cephadm-container-image-tag
Adam King [Tue, 15 Jul 2025 14:07:59 +0000 (10:07 -0400)]
Merge pull request #64184 from kshtsk/wip-allow-cephadm-container-image-tag

qa/tasks/cephadm: override container image tags

Reviewed-by: Adam King <adking@redhat.com>
2 months agoMerge pull request #63162 from Kushal-deb/fix_issue-2323601-trust-both-sites-rgw...
Adam King [Tue, 15 Jul 2025 14:04:46 +0000 (10:04 -0400)]
Merge pull request #63162 from Kushal-deb/fix_issue-2323601-trust-both-sites-rgw-certs-from-a-node

mgr/cephadm: include cluster FSID in root CA Common Name (CN)

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
2 months agoMerge pull request #62808 from adk3798/mgr-rgw-fix-re-realm-bootstrap-after-deletions
Adam King [Tue, 15 Jul 2025 14:01:36 +0000 (10:01 -0400)]
Merge pull request #62808 from adk3798/mgr-rgw-fix-re-realm-bootstrap-after-deletions

mgr/rgw: don't fail realm bootstrap if system user exists already

Reviewed-by: Redouane Kachach <rkachach@ibm.com>
2 months agoMerge pull request #59889 from adk3798/alertmanager-custom-webhook
Adam King [Tue, 15 Jul 2025 13:57:32 +0000 (09:57 -0400)]
Merge pull request #59889 from adk3798/alertmanager-custom-webhook

mgr/cephadm: fix custom alertmanager webhooks

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 months agoMerge pull request #61017 from ShwetaBhosale1/fix_issue_69174_ceph_orch_apply_command...
Adam King [Tue, 15 Jul 2025 13:56:24 +0000 (09:56 -0400)]
Merge pull request #61017 from ShwetaBhosale1/fix_issue_69174_ceph_orch_apply_command_accepts_both_positional_and_keyword_argument

mgr/cephadm: Ceph orch apply command does not give error if 'placement' is passed as both positional and keyword argument

Reviewed-by: Adam King <adking@redhat.com>
2 months agoMerge pull request #62927 from ShwetaBhosale1/fix_issue_71031_add_Monitoring_Addr_par...
Adam King [Tue, 15 Jul 2025 13:53:16 +0000 (09:53 -0400)]
Merge pull request #62927 from ShwetaBhosale1/fix_issue_71031_add_Monitoring_Addr_param_to_ganesha.conf

mgr/nfs: Add Monitoring_Addr parameter to ganesha.conf and provide option for user to provide ips for bind_addr

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 months agoMerge pull request #62984 from JoshuaGabriel/jblanch_71087
Adam King [Tue, 15 Jul 2025 13:50:43 +0000 (09:50 -0400)]
Merge pull request #62984 from JoshuaGabriel/jblanch_71087

mgr/cephadm: disallow changing OSD service type to non-OSD types

Reviewed-by: Adam King <adking@redhat.com>
2 months agoMerge pull request #63563 from adk3798/cephadm-no-new-daemon-on-port-change-mid-upgrade
Adam King [Tue, 15 Jul 2025 13:45:51 +0000 (09:45 -0400)]
Merge pull request #63563 from adk3798/cephadm-no-new-daemon-on-port-change-mid-upgrade

mgr/cephadm: don't remove and deploy new daemon if ports change during upgrade

Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
2 months agoMerge pull request #63952 from jimfunk/get_ceph_cluster_count_missing_data_dir
Adam King [Tue, 15 Jul 2025 13:39:50 +0000 (09:39 -0400)]
Merge pull request #63952 from jimfunk/get_ceph_cluster_count_missing_data_dir

cephadm: Get ceph cluster count missing data dir

Reviewed-by: Adam King <adking@redhat.com>
2 months agoMerge pull request #64385 from rhcs-dashboard/prometheus-http-service-fix
Adam King [Tue, 15 Jul 2025 13:35:35 +0000 (09:35 -0400)]
Merge pull request #64385 from rhcs-dashboard/prometheus-http-service-fix

mgr/prometheus: fix metrics service not coming up

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
2 months agoMerge pull request #64477 from gbregman/main
Gil Bregman [Tue, 15 Jul 2025 13:16:24 +0000 (16:16 +0300)]
Merge pull request #64477 from gbregman/main

mgr/cephadm/nvmeof: Increase the default limit of max_namespaces

2 months agotest/osd: Unit test to verify optimised EC deep scrub functionality
Jon Bailey [Wed, 30 Apr 2025 08:49:06 +0000 (09:49 +0100)]
test/osd: Unit test to verify optimised EC deep scrub functionality

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
2 months agotest/osd: Add erasure coded pools support to test_scrubber_be.cc
Jon Bailey [Thu, 8 May 2025 12:25:58 +0000 (13:25 +0100)]
test/osd: Add erasure coded pools support to test_scrubber_be.cc

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
2 months agoosd: Deep scrubbing implementation for optimised erasure coding
Jon Bailey [Mon, 12 May 2025 20:29:40 +0000 (21:29 +0100)]
osd: Deep scrubbing implementation for optimised erasure coding

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
2 months agomgr/dashboard: Notification endpoints for create ,list and delete
pujashahu [Fri, 4 Jul 2025 07:54:50 +0000 (13:24 +0530)]
mgr/dashboard: Notification endpoints for create ,list and delete

Fixes: https://tracker.ceph.com/issues/70313
Signed-off-by: pujashahu <pshahu@redhat.com>
2 months agocmake: Remove unused cls_lock_client linkage
Kefu Chai [Mon, 30 Jun 2025 09:04:37 +0000 (17:04 +0800)]
cmake: Remove unused cls_lock_client linkage

Remove unused cls_lock_client linkage from cls_rbd_client and ceph_test_cls_rbd

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 months agotest/crimson/seastore/test_omap_manager: redesign test leafnodes
Chanyoung Park [Tue, 15 Jul 2025 05:33:43 +0000 (05:33 +0000)]
test/crimson/seastore/test_omap_manager: redesign test leafnodes

Fixes: https://tracker.ceph.com/issues/72127
Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>
2 months agomgr/cephadm/nvmeof: Increase the default limit of max_namespaces
Gil Bregman [Mon, 14 Jul 2025 12:28:48 +0000 (15:28 +0300)]
mgr/cephadm/nvmeof: Increase the default limit of max_namespaces
Fixes https://tracker.ceph.com/issues/72108

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
2 months agoMerge pull request #63232 from amathuria/wip-amat-update-seastar
Matan Breizman [Tue, 15 Jul 2025 07:21:42 +0000 (10:21 +0300)]
Merge pull request #63232 from amathuria/wip-amat-update-seastar

seastar: bump up seastar submodule

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 months agocrimson/os: drop off omap_get_values with start
chunmei liu [Mon, 31 Mar 2025 21:27:52 +0000 (14:27 -0700)]
crimson/os: drop off omap_get_values with start

Signed-off-by: chunmei liu <chunmei.liu@ibm.com>
2 months agoosd/SnapMapper: replace omap_get_values by omap_iterate in get_next
Chunmei Liu [Tue, 1 Jul 2025 23:12:54 +0000 (23:12 +0000)]
osd/SnapMapper: replace omap_get_values by omap_iterate in get_next

Signed-off-by: Chunmei Liu <chunmei.liu@ibm.com>
2 months agotest/crimson/seastore: check_omap replace omap_get_values by omap_iterate
chunmei liu [Sun, 30 Mar 2025 10:10:01 +0000 (03:10 -0700)]
test/crimson/seastore: check_omap replace omap_get_values by omap_iterate

Signed-off-by: chunmei liu <chunmei.liu@ibm.com>
2 months agoosd/PGLog.cc: replace omap_get_values by omap_iterate
chunmei liu [Sun, 30 Mar 2025 07:47:16 +0000 (00:47 -0700)]
osd/PGLog.cc: replace omap_get_values by omap_iterate

Signed-off-by: chunmei liu <chunmei.liu@ibm.com>
2 months agocrimson/osd/../scrub_events: replace omap_get_values() by omap_iterate()
chunmei liu [Mon, 24 Mar 2025 07:30:25 +0000 (00:30 -0700)]
crimson/osd/../scrub_events: replace omap_get_values() by omap_iterate()

Signed-off-by: chunmei liu <chunmei.liu@ibm.com>
2 months agocrimson/osd/replicated_recovery_backend: replace omap_get_values() by omap_iterate()
chunmei liu [Sat, 22 Mar 2025 08:11:28 +0000 (01:11 -0700)]
crimson/osd/replicated_recovery_backend: replace omap_get_values() by omap_iterate()

Signed-off-by: chunmei liu <chunmei.liu@ibm.com>
2 months agocrimson/osd/pg_backend: replace omap_get_keys/vals() by omap_iterate()
chunmei liu [Sat, 22 Mar 2025 04:58:20 +0000 (21:58 -0700)]
crimson/osd/pg_backend: replace omap_get_keys/vals() by omap_iterate()

needn't scan the entire omap tree.

Signed-off-by: chunmei liu <chunmei.liu@ibm.com>
2 months agotest/crimson/seastore/test_omap_manager: test omap_iterate()
chunmei liu [Thu, 20 Mar 2025 01:48:59 +0000 (18:48 -0700)]
test/crimson/seastore/test_omap_manager: test omap_iterate()

Signed-off-by: chunmei liu <chunmei.liu@ibm.com>
2 months agocrimson/os: add omap_iterate interface to futurized store
chunmei liu [Wed, 19 Mar 2025 20:50:45 +0000 (13:50 -0700)]
crimson/os: add omap_iterate interface to futurized store

Signed-off-by: chunmei liu <chunmei.liu@ibm.com>
2 months agoMerge PR #64487 into main
Patrick Donnelly [Tue, 15 Jul 2025 01:07:57 +0000 (21:07 -0400)]
Merge PR #64487 into main

* refs/pull/64487/head:
script/redmine-upkeep: add Filter class

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2 months agoscript/redmine-upkeep: add Filter class
Patrick Donnelly [Mon, 14 Jul 2025 15:06:11 +0000 (11:06 -0400)]
script/redmine-upkeep: add Filter class

To add priority and clarity of organization.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
2 months agotest/crimson/seastore/test_omap_manager: redesign test replay
Chanyoung Park [Mon, 14 Jul 2025 16:21:19 +0000 (16:21 +0000)]
test/crimson/seastore/test_omap_manager: redesign test replay

Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>
2 months agoMerge PR #64486 into main
Patrick Donnelly [Mon, 14 Jul 2025 16:20:07 +0000 (12:20 -0400)]
Merge PR #64486 into main

* refs/pull/64486/head:
script/redmine-upkeep: codify commit abbreviation

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2 months agoMerge PR #64446 into main
Patrick Donnelly [Mon, 14 Jul 2025 16:04:27 +0000 (12:04 -0400)]
Merge PR #64446 into main

* refs/pull/64446/head:
script/redmine-upkeep: handle invalid PRs

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2 months agoscript/redmine-upkeep: codify commit abbreviation
Patrick Donnelly [Mon, 14 Jul 2025 15:46:23 +0000 (11:46 -0400)]
script/redmine-upkeep: codify commit abbreviation

As it can vary depending on repository size. On my development machine, it
produces 8 character abbreviations but the github action is producing 7
character abbreviations. This triggers unnecessary updates.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
2 months agoMerge PR #64461 into main
Patrick Donnelly [Mon, 14 Jul 2025 15:59:23 +0000 (11:59 -0400)]
Merge PR #64461 into main

* refs/pull/64461/head:
.github/workflows/redmine-upkeep: use pull_request_target

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2 months agoMerge PR #64468 into main
Patrick Donnelly [Mon, 14 Jul 2025 15:58:10 +0000 (11:58 -0400)]
Merge PR #64468 into main

* refs/pull/64468/head:
mailmap, githubmap, organizationmap: Add Kautilya

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
2 months agoMerge pull request #64483 from zdover23/wip-doc-2025-07-15-pr-64374-followup
Ilya Dryomov [Mon, 14 Jul 2025 15:52:16 +0000 (17:52 +0200)]
Merge pull request #64483 from zdover23/wip-doc-2025-07-15-pr-64374-followup

doc: add note admonitions in two files

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 months agodoc: add note admonitions in two files
Zac Dover [Mon, 14 Jul 2025 14:40:21 +0000 (00:40 +1000)]
doc: add note admonitions in two files

Add note admonitions when discussing client package support in the
context of OS Recommendations in the following two files:

- doc/cephfs/ceph-dokan.rst
- doc/rbd/rbd-windows.rst

This addresses a change requested by Ilya Dryomov in
https://github.com/ceph/ceph/pull/64374#discussion_r2199756581.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agoMerge pull request #64470 from Matan-B/wip-matanb-crimson-rbd-py
Ilya Dryomov [Mon, 14 Jul 2025 14:36:28 +0000 (16:36 +0200)]
Merge pull request #64470 from Matan-B/wip-matanb-crimson-rbd-py

test/pybind/test_rbd.py: remove skip_if_crimson

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 months agoMerge pull request #64374 from anthonyeleven/update-msw-support
Anthony D'Atri [Mon, 14 Jul 2025 14:23:21 +0000 (10:23 -0400)]
Merge pull request #64374 from anthonyeleven/update-msw-support

doc: Clarify the status of MS Windows client support

2 months agocommon: Add iterator traits to mini_flat_map and bitset_set iterator
Jon Bailey [Mon, 12 May 2025 20:19:48 +0000 (21:19 +0100)]
common: Add iterator traits to mini_flat_map and bitset_set iterator

Add iterator traits to mini_flat_map and bitset_set iterator to allow std algorithms to be able to perform operations using the mini_flat_map iterator

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
2 months agoerasure-code: Add new flag for whether plugins support encoding/decoding or CRCs
Jon Bailey [Mon, 12 May 2025 20:15:06 +0000 (21:15 +0100)]
erasure-code: Add new flag for whether plugins support encoding/decoding or CRCs

Add new flag for whether plugins support encoding/decoding or CRCs to get the CRC of what the encoded/decoded data would be.

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
2 months agodoc: Clarify the status of MS Windows client support
Anthony D'Atri [Mon, 7 Jul 2025 15:47:02 +0000 (11:47 -0400)]
doc: Clarify the status of MS Windows client support

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 months agoqa/d4n: Update D4N suite
Samarah [Tue, 24 Jun 2025 15:39:33 +0000 (15:39 +0000)]
qa/d4n: Update D4N suite

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
2 months agorgw/d4n: Add shutdown calls to unit tests and save yield in filter
Samarah [Wed, 18 Jun 2025 19:06:51 +0000 (19:06 +0000)]
rgw/d4n: Add shutdown calls to unit tests and save yield in filter

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
2 months agotest/d4n: Add length to bufferlist vars
Samarah [Wed, 18 Jun 2025 18:58:35 +0000 (18:58 +0000)]
test/d4n: Add length to bufferlist vars

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
2 months agotest/d4n: Add dout initalization during env setup
Samarah [Wed, 18 Jun 2025 18:54:24 +0000 (18:54 +0000)]
test/d4n: Add dout initalization during env setup

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
2 months agotest/d4n: Set config_store_type to dbstore
Samarah [Wed, 18 Jun 2025 18:47:07 +0000 (18:47 +0000)]
test/d4n: Set config_store_type to dbstore

Signed-off-by: Samarah <samarah.uriarte@ibm.com>
2 months agoMerge pull request #64333 from mohit84/seastore_magic
Matan Breizman [Mon, 14 Jul 2025 12:46:46 +0000 (15:46 +0300)]
Merge pull request #64333 from mohit84/seastore_magic

crimson/os/seastore: write "seastore block device" signature in write_superblock

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 months agoMerge pull request #64432 from tchaikov/wip-cls-rbd-iwyu
Ilya Dryomov [Mon, 14 Jul 2025 11:38:31 +0000 (13:38 +0200)]
Merge pull request #64432 from tchaikov/wip-cls-rbd-iwyu

cls/rbd: remove unused includes

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 months agoMerge pull request #62813 from smanjara/wip-fix-delete-object-tagging
anrao19 [Mon, 14 Jul 2025 09:59:17 +0000 (15:29 +0530)]
Merge pull request #62813 from smanjara/wip-fix-delete-object-tagging

rgw/multisite: sync object tagging deletion

2 months agoMerge pull request #63080 from bluikko/doc-caching-improvements-radosgw
Zac Dover [Mon, 14 Jul 2025 09:50:42 +0000 (19:50 +1000)]
Merge pull request #63080 from bluikko/doc-caching-improvements-radosgw

doc/radosgw: Improve rgw-cache.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>
2 months agoMerge pull request #64462 from anthonyeleven/fusefix
Zac Dover [Mon, 14 Jul 2025 09:47:20 +0000 (19:47 +1000)]
Merge pull request #64462 from anthonyeleven/fusefix

doc/cephfs: Improve mount-using-fuse.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 months agocls/rbd: remove unused includes
Kefu Chai [Thu, 10 Jul 2025 08:36:24 +0000 (16:36 +0800)]
cls/rbd: remove unused includes

- Remove unused #include "cls/lock/cls_lock_client.h" from
  cls_rbd_client.cc.
- Remove unused includes in test_cls_rbd.cc

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 months agotest/pybind/test_rbd.py: remove skip_if_crimson
Matan Breizman [Wed, 9 Jul 2025 12:31:08 +0000 (12:31 +0000)]
test/pybind/test_rbd.py: remove skip_if_crimson

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 months agoinstall-deps.sh: use gcc-12 for ubuntu jammy
Aishwarya Mathuria [Tue, 8 Jul 2025 06:20:32 +0000 (06:20 +0000)]
install-deps.sh: use gcc-12 for ubuntu jammy

Clang relies on the system's libstdc++ headers for standard C++
features. On Ubuntu Jammy, gcc-11 is the default and it's libstdc++ is
missing some of the newer features supported by C++20.

This causes build failures as certain standard headers are incomplete.
To fix this, we install gcc-12 explicitly so that Clang can pick up the
newer libstdc++ headers.

Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
2 months agocrimson/tools: remove usage of deprecated function at_exit()
Aishwarya Mathuria [Fri, 4 Jul 2025 06:37:45 +0000 (06:37 +0000)]
crimson/tools: remove usage of deprecated function at_exit()

at_exit() is now deprecated, in place of that we will explicitly
call stop() for the sharded objects.

Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
2 months agocrimson/tools: Remove usage of at_exit()
Aishwarya Mathuria [Mon, 30 Jun 2025 13:53:54 +0000 (13:53 +0000)]
crimson/tools: Remove usage of at_exit()

at_exit() is deprecated in seastar. Make use of deferred_stop instead.

Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
2 months agocrimson/test_messenger: remove usage of deprecated function at_exit()
Aishwarya Mathuria [Fri, 20 Jun 2025 06:42:46 +0000 (12:12 +0530)]
crimson/test_messenger: remove usage of deprecated function at_exit()

at_exit() is now deprecated, in place of that we will explicitly
call stop() for the sharded objects.

Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
2 months agoseastar: bump up seastar submodule
Aishwarya Mathuria [Mon, 12 May 2025 10:40:01 +0000 (10:40 +0000)]
seastar: bump up seastar submodule

Update branch to wip-amat-seastar-may-25
https://github.com/ceph/seastar/tree/wip-amat-seastar-may-25

Fixes: https://tracker.ceph.com/issues/71184
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
2 months agoMerge pull request #64362 from rhcs-dashboard/edit-bucket-with-account
afreen23 [Mon, 14 Jul 2025 07:14:49 +0000 (12:44 +0530)]
Merge pull request #64362 from rhcs-dashboard/edit-bucket-with-account

mgr/dashboard: differentiate account users from rgw users in bucket form

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
2 months agomailmap, githubmap, organizationmap: Add Kautilya
Kautilya Tripathi [Mon, 14 Jul 2025 05:16:50 +0000 (10:46 +0530)]
mailmap, githubmap, organizationmap: Add Kautilya

Signed-off-by: Kautilya Tripathi <kautilya.tripathi@ibm.com>
2 months agoMerge pull request #64259 from tchaikov/wip-cmake-osdc-without-error_code
Kefu Chai [Mon, 14 Jul 2025 04:13:47 +0000 (12:13 +0800)]
Merge pull request #64259 from tchaikov/wip-cmake-osdc-without-error_code

cmake: remove error_code.cc from osdc to fix ODR violation

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 months agocmake: remove osdc/error_code.cc from osdc to fix ODR violation
Kefu Chai [Mon, 30 Jun 2025 07:54:14 +0000 (15:54 +0800)]
cmake: remove osdc/error_code.cc from osdc to fix ODR violation

Fix AddressSanitizer ODR (One Definition Rule) violation caused by
osdc/error_code.cc being compiled into both the osdc library and
ceph-common library.

The violation occurred because osdc_error_category was defined in
both the rbd binary (via osdc) and libceph-common.so, creating
duplicate symbols at runtime.

Since all targets that link against osdc also link against
ceph-common, removing osdc/error_code.cc from osdc doesn't break the
build while eliminating the duplicate definition.

ASan error sample:

```
  ==857433==ERROR: AddressSanitizer: odr-violation (0x5612ad665760):
    [1] size=22 'typeinfo name for osdc_error_category' /home/jenkins-build/build/workspace/ceph-pull-requests/src/osdc/error_code.cc in /home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/rbd
    [2] size=22 'typeinfo name for osdc_error_category' /home/jenkins-build/build/workspace/ceph-pull-requests/src/osdc/error_code.cc in /home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libceph-common.so.2
  These globals were registered at these points:
    [1]:
      #0 0x5612acd62c88 in __asan_register_globals (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/rbd+0x815c88) (BuildId: 62a02cbbf3426e5470e16372e3b53a18cb18ce0f)
      #1 0x5612acd63d59 in __asan_register_elf_globals (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/rbd+0x816d59) (BuildId: 62a02cbbf3426e5470e16372e3b53a18cb18ce0f)
      #2 0x7f28d3b02eba in call_init csu/../csu/libc-start.c:145:3
      #3 0x7f28d3b02eba in __libc_start_main csu/../csu/libc-start.c:379:5
```

Signed-off-by: Kefu Chai <tchaikov@gmail.com>