tools/cephfs_mirror: Synchronize taking snapshot

The crawler/entry creation thread needs to wait until
all the data is synced by datasync threads to take
the snapshot. This patch adds the necessary conditions
for the same.

It is important for the conditional flag to be part
of SyncMechanism and not part of PeerReplayer class.
The following bug would be hit if it were part of
PeerReplayer class.

When multiple directories are confiugred for mirroring as below
/d0                /d1              /d2
Crawler1         Crawler2          Crawler3
DoneEntryOps     DoneEntryOps      DoneEntryOps
WaitForSafeSnap  WaitForSafeSnap   WaitForSafeSnap

When all crawler threads are waiting at above, the data sync threads
which is done processing /d1, would notify, waking up all the crawlers
causing spurious/unwanted wake up and half baked snapshots.

Fixes: https://tracker.ceph.com/issues/73452
Signed-off-by: Kotresh HR <khiremat@redhat.com>

tools/cephfs_mirror: Add SnapDiff entries to dataq

Add SnapDiff entries to dataq and process the same
in datasync threads similar to RemoteSync entries.

Fixes: https://tracker.ceph.com/issues/73452
Signed-off-by: Kotresh HR <khiremat@redhat.com>

tools/cephfs_mirror: Process entries from dataq

Consume entries from syncm's data queue and sync
them to remote.

Fixes: https://tracker.ceph.com/issues/73452
Signed-off-by: Kotresh HR <khiremat@redhat.com>

tools/cephfs_mirror: Move dir_root to SyncMechanism

Store m_dir_root in parent (SyncMehansim) to make
it accessible in the data sync threads to sync
files

Fixes: https://tracker.ceph.com/issues/73452
Signed-off-by: Kotresh HR <khiremat@redhat.com>

tools/cephfs_mirror: Fix data sync threads completion logic

We need to exactly know when all data threads completes
the processing of a syncm. If a few threads finishes the
job, they all need to wait for the in processing threads
of that syncm to complete. Otherwise the finished threads
would be busy loop until in processing threads finishes.

And only after all threads finishes processing, the crawler
thread can be notified to take the snapshot.

Fixes: https://tracker.ceph.com/issues/73452
Signed-off-by: Kotresh HR <khiremat@redhat.com>

tools/cephfs_mirror: Populate dataq for RemoteSync

Fixes: https://tracker.ceph.com/issues/73452
Signed-off-by: Kotresh HR <khiremat@redhat.com>

tools/cephfs_mirror: Move remote_mkdir to SyncMechanism

This is required as SyncMechanism::get_entry would sync
directories during crawl.

Fixes: https://tracker.ceph.com/issues/73452
Signed-off-by: Kotresh HR <khiremat@redhat.com>

tools/cephfs_mirror: Mark crawl finished

After entry operations are synced and stack is empty,
mark the crawl as finished so the data sync threads'
wait logic works correctly and doesn't indefinitely wait.

Fixes: https://tracker.ceph.com/issues/73452
Signed-off-by: Kotresh HR <khiremat@redhat.com>

tools/cephfs_mirror: Add m_sync_data queue

Add data sync queue for each SyncMechanism.

Fixes: https://tracker.ceph.com/issues/73452
Signed-off-by: Kotresh HR <khiremat@redhat.com>

tools/cephfs_mirror: Add SyncMechanism Queue

Add a queue of shared_ptr of type SyncMechanism.
Since it's shared_ptr, the queue can hold both
shared_ptr to both RemoteSync and SnapDiffSync objects.
Each SyncMechanism holds the queue for the SyncEntry
items to be synced using the data sync threads.

The SyncMechanism queue needs to be shared_ptr because
all the data sync threads needs to access the object
of SyncMechanism to process the SyncEntry Queue.

This patch sets up the building blocks for the same.

Fixes: https://tracker.ceph.com/issues/73452
Signed-off-by: Kotresh HR <khiremat@redhat.com>

tools/cephfs_mirror: Join datasync threads on shutdown

Fixes: https://tracker.ceph.com/issues/73452
Signed-off-by: Kotresh HR <khiremat@redhat.com>

tools/cephfs_mirror: Use the existing m_lock and m_cond

The entire snapshot is synced outside the lock.
The m_lock and m_cond pair is used for data sync
threads along with crawler threads to work well
with all terminal conditions like shutdown and
existing data structures.

Fixes: https://tracker.ceph.com/issues/73452
Signed-off-by: Kotresh HR <khiremat@redhat.com>

tools/cephfs_mirror: Add a pool of datasync threads

Fixes: https://tracker.ceph.com/issues/73452
Signed-off-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #66484 from samarahu/d4n-remove-erase-from-update

Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>

Merge pull request #67348 from VallariAg/wip-nvmeof-udisks-disable

qa: Fix coredumps caused by udisks

Merge pull request #67370 from kotreshhr/qa-mirror-flake8-fix

qa/test_mirroring: Fix flake8 errors

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

qa/test_mirroring: Fix flake8 errors

Introduced-by: c1e827247bd20e8a1851bc2d7a9861c12d033ef0
Signed-off-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #67231 from guits/ceph-volume-inventory-ls-all

ceph-volume: include LVM mapper devices in get_devices()

Merge pull request #67110 from FredNass/patch-2

doc/radosgw: rgw_lua_max_memory_per_state defaults to 128K (not 500K)

Merge pull request #66967 from rhcs-dashboard/gateway-add-modal

mgr/dashboard: gateway-add-modal

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #67305 from kotreshhr/qa-mirror

qa: Add retry logic to remove most sleeps in mirroring tests

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #66912 from idryomov/wip-74394

osd/PrimaryLogPG: encode an empty data_bl for empty sparse reads

Merge pull request #66894 from tchaikov/wip-ec-isa-fix-cache-collision

erasure-code/isa: fix cache collision causing buffer overflow

Merge pull request #66376 from NitzanMordhai/wip-nitzan-self-test-influx-set-hostname

qa/tasks/mgr: test_module_selftest set influx hostname to avoid warnings

Merge pull request #62067 from ljflores/wip-tracker-67179

osd: add pg-upmap-primary to clean_pg_upmaps

Merge pull request #67353 from idryomov/wip-daemonwatchdog-unbound

qa/tasks/daemonwatchdog: fix unbound variable in bark_reason message

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #67351 from idryomov/wip-74712

qa: krbd_rxbounce.sh: do more reads to generate more errors

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #65318 from tchaikov/wip-mgr-progress-cleanup

pybind/mgr/progress: cleanups

Reviewed-by: Samuel Just <sjust@redhat.com>

qa/tasks/daemonwatchdog: fix unbound variable in bark_reason message

Introduced in commit 783f0e3a9903 ("qa: Adding a new class for the
daemonwatchdog to monitor").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

qa: krbd_rxbounce.sh: do more reads to generate more errors

On faster hardware having each thread do 1024 reads isn't always
sufficient for the "two orders of magnitude" threshold that is used in
the test.

Fixes: https://tracker.ceph.com/issues/74712
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #67218 from jamiepryde/jerasure-unit-test-big-endian-fix

test/erasure-code: Use memory comparisons that are safe on big endian arch

qa: Fix coredumps caused by udisks

Also redo commands to install nvme 2.13.
Fixes: https://tracker.ceph.com/issues/74922
Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>

Merge pull request #67240 from guits/cv-raw-list-perf

ceph-volume: single lvs call to speed up exclude_lvm_osd_devices

Merge pull request #66646 from ujjawal-ibm/ceph-volume-format-device

Add NVMe preformat support to skip redundant mkfs discard

Merge PR #66183 into main

* refs/pull/66183/head:

Reviewed-by: Anoop C S <anoopcs@cryptolab.net>
Reviewed-by: Shachar Sharon <ssharon@redhat.com>

Merge pull request #66606 from shraddhaag/add-logs

PeeringState::needs_recovery(): log first missing item

Merge pull request #66352 from tchaikov/debian-invoke-rc.d

debian: remove invoke-rc.d calls from postrm scripts

Merge pull request #66591 from NitzanMordhai/wip-nitzan-pickup-object-corpus-20.2.0-380-gdbcbbd3f281

ceph-object-corpus: pick up 20.2.0-380-gdbcbbd3f281

Merge pull request #66553 from smanjara/wip-fix-object-sync-enoent

rgw: retry ENOENT if bucket reshard races with index operation

Merge pull request #66721 from swjtu-zhanglei/main-wip

rgw: refact by encapsulating io_context_pool to enforce lazy initialization

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #66567 from mertsunacoglu/wip-prerequest-auth

RGW: Change prerequest hook to run after authorization process

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #66509 from morphes1995/rgw_qos_fix

rgw: ops large budget caused by rate limiter was enabled and max_ops …

Reviewed-by: Mark Kogan <mkogan@ibm.com>

qa: Fix test_cephfs_mirror_remote_snap_corrupt_fails_synced_snapshot

Fixes: https://tracker.ceph.com/issues/74896
Signed-off-by: Kotresh HR <khiremat@redhat.com>

qa: Add retry logic to remove most sleeps in mirroring tests

The mirroring tests contain lot of sleeps adding it up to ~1hr.
This patch adds a retry logic and removes most of them. This
is cleaner and saves considerable time in test time for mirroring.

Fixes: https://tracker.ceph.com/issues/74878
Signed-off-by: Kotresh HR <khiremat@redhat.com>

ceph-volume: skip redundant NVMe mkfs discards

- Avoid redundant discard during mkfs when discard is disabled
- Reduces mkfs time on large NVMe devices by skipping long running discard operations

Fixes: https://tracker.ceph.com/issues/74908
Signed-off-by: Ujjawal Anand <ujjawal.anand@ibm.com>

Merge pull request #67264 from guits/fix-74818

ceph-volume: pass osd_type value to ceph-volume

Merge pull request #66594 from cbodley/wip-qa-rgw-account-migration

qa/rgw: add test_account_migration workunit

Reviewed-by: Krunal Chheda <kchheda3@bloomberg.net>

Merge PR #66657 into main

* refs/pull/66657/head:
developer: Add name to maps

Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #67309 into main

* refs/pull/67309/head:
doc: correct spelling

Reviewed-by: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #67078 into main

* refs/pull/67078/head:
doc: Fixes a spelling error on the RATIO for PG scaling recommendation.

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #66526 from gardran/wip-gardran-show-sharding

os/bluestore: show RocksDB sharding information

Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>

Merge PR #67320 into main

* refs/pull/67320/head:
.github/workflows: use main branch for config diff

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Naveen Naidu <naveen.naidu@ibm.com>

Merge pull request #66821 from rhcs-dashboard/cephfs-mirroring-filesystem

mgr/dashboard: Cephfs mirroring Filesystem Selection

Reviewed-by: Naman Munet <nmunet@redhat.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>

Merge pull request #67044 from Hezko/nvme-submodule-to-1-6-5

mgr/dashboard: bump nvmeof submodule to 1.6.5

Merge pull request #66929 from mkogan1/wip-t74245

ceph-volume: fix build on RHEL 10/python 3.12

Reviewed-by: Kefu Chai <k.chai@proxmox.com>

mgr/dashboard: use gray10 theme colors

- sidenav, header , table - white
- background - gray

Signed-off-by: Afreen Misbah <afreen@ibm.com>

mgr/dashboard: add-gateway-nodes

Fixes: https://tracker.ceph.com/issues/74335
Signed-off-by: Sagar Gopale <sagar.gopale@ibm.com>
:wq

Merge pull request #66906 from rhcs-dashboard/gateway-resources

mgr/dashboard: NVme-gateway-resource

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Naman Munet <nmunet@redhat.com>

Merge PR #67316 into main

* refs/pull/67316/head:
doc/dev/release-checklist: add release to redmine-upkeep trigger
.github/workflows/redmine-upkeep: run for release branches

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

.github/workflows: use main branch for config diff

This script does not exist for the "head" reference of backport PRs.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

qa/rgw: add test_account_migration workunit

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #67307 from leonidc/fix-tests-after-beacon-diff

 qa: fixing the qa test in mon/misc.sh after adding beacon-diff feature

doc/dev/release-checklist: add release to redmine-upkeep trigger

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

.github/workflows/redmine-upkeep: run for release branches

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Merge PR #67011 into main

* refs/pull/67011/head:
qa/multisite: use boto3's ClientError in place of assert_raises from tools.py.
qa/multisite: test fixes
qa/multisite: boto3 in tests.py
qa/multisite: zone files use boto3 resource api
qa/multisite: switch to boto3 in multisite test libraries

Reviewed-by: Casey Bodley <cbodley@redhat.com>

doc: correct spelling

I saw a typo so I fixed it

Signed-off-by: Amnay <amnay.m@gmail.com>

libcephfs_proxy: log more information about the negotiation

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

libcephfs_proxy: implement client support for batched readdir

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

libcephfs_proxy: create internal ceph_dir_result structure

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

libcephfs_proxy: add the number of supported operations to negotiation

The v0 negotiation structure has been modified to hold the total number
of operations and callbacks supported by the peer. The changes are done in
a way that it's completely transparent and harmless for a peer expecting
the previous definition.

This will be useful to quickly check if the daemon supports some
operation, or the client supports some callback before sending them.

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

libcephfs_proxy: implement daemon support for batched readdir

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

libcephfs_proxy: define protocol for batched readdir

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

libcephfs_proxy: cleanup unneded variable

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

libcephfs_proxy: fix include dependency

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>

 qa: fixing the qa test in mon/misc.sh after adding beacon-diff feature

Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>

mgr/dashboard: NVme-gateway-resource

Fixes: https://tracker.ceph.com/issues/74334
Signed-off-by: Sagar Gopale <sagar.gopale@ibm.com>

Merge pull request #67290 from shraddhaag/wip-shraddhaag-cephadm-crimson-tests

cephadm, ceph-volume: add tests for crimson OSD support

Merge pull request #66255 from rkachach/fix_issue_73853

mgr/cephadm: don't remove TLS certs if svc still has daemons on host

Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>

mgr/dashboard: Cephfs Mirroring - Filesystem Selection

Fixes: https://tracker.ceph.com/issues/74280
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>

Merge PR #65538 into main

* refs/pull/65538/head:

Reviewed-by: Anoop C S <anoopcs@cryptolab.net>
Reviewed-by: Shachar Sharon <ssharon@redhat.com>

Merge pull request #67182 from Kh9705/add-s3select-limit-examples

doc/radosgw/s3select: added SQL LIMIT operator examples

Merge pull request #67104 from rhcs-dashboard/header-page-component

mgr/dashboard: add page header component

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>

Merge pull request #67059 from bluikko/wip-src-script-backport-fixes

ceph-backport.sh: clean function argument use and update GitHub help link

Merge pull request #67202 from tchaikov/wip-ec-isa-cleanup

erasure-code/isa: eliminate redundant map lookups

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>

Merge pull request #67128 from afreen23/subsystem-step-2

mgr/dashboard: Step two subsystem creation form

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: pujaoshahu <pshahu@redhat.com>

mgr/dashboard: bump nvmeof submodule to 1.6.5

update proto files and gateway submodule
Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
tomer

Merge pull request #67174 from bluikko/wip-fix-74721-trailing-space

mgr/dashboard: remove trailing space from directory name

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: pujaoshahu <pshahu@redhat.com>

d4n/policy: Remove erase call from update

Signed-off-by: Samarah <samarah.uriarte@ibm.com>

Merge pull request #66092 from kshtsk/wip-fix-lua-kernel-check

qa/cephfs: lua to respect missing kernel in yaml

cephadm, ceph-volume: add tests for crimson OSD support

This commit adds tests for the crimson OSD support in cephadm and ceph-volume.
The following tests are added for the same:

1. cephadm: DriveGroupSpec validation checks for osd_type.
2. cephadm: entrypoint verification in runfile.
3. cephadm to ceph-volume: command verification when osd_type is specified in spec.
4. ceph-volume: binary selection verification for mkfs cmd.

Fixes: https://tracker.ceph.com/issues/74851
Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>

Merge pull request #66815 from bluikko/wip-doc-man-fix-directives

doc/man: fix invalid directive missing a second colon

mgr/dashboard: Add step two of subsystem create form

- add steps to add initiators
- can add by input field
- added right influencer (right panel) in tearsheet component
- added unit tests
- includes api updates

Fixes https://tracker.ceph.com/issues/74096

Signed-off-by: Afreen Misbah <afreen@ibm.com>

mgr/dashboard: add page header component

Adds page header component and applies it to the CephFS Mirroring list

Fixes: https://tracker.ceph.com/issues/74626
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>

Merge PR #64743 into main

* refs/pull/64743/head:

Reviewed-by: Anoop C S <anoopcs@cryptolab.net>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #66979 from idryomov/wip-73824

librbd: introduce RBD_LOCK_MODE_EXCLUSIVE_TRANSIENT

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #64819 from aclamk/aclamk-rocksdb-binned-cache-perf-counters

kv/RocksDB: Add instrumentation to BinnedLRUCache

Reviewed-by: Jaya Prakash <jayaprakash@ibm.com>

Merge pull request #67170 from afreen23/subsystem-step-3

mgr/dashboard: Step three subsystem creation form

Reviewed-by: pujaoshahu <pshahu@redhat.com>

Merge pull request #67217 from aliakseimakarau/main-s390x-fixexecstack

Mark s390x CRC assembly code as not requiring ELF execstack

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #67261 from Matan-B/wip-matanb-crimson-66488-revert

Revert "crimson/os/seastore/cache: TRIM_DIRTY/CLEANER_* transactions won't invalidate other transactions anymore"

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge pull request #67266 from gbregman/main

mgr/cephadm: Change the default value of omap_file_lock_duration in  NVMEoF spec file