ceph-docker-lint: test code SC2015

Work around in https://github.com/ceph/ceph-docker/pull/622
Using if and unset -e and reset it.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1450480
Signed-off-by: Sébastien Han <seb@redhat.com>

ceph-docker-lint: remove -x arg

The current version from EPEL does not have the -x argument.

Signed-off-by: Sébastien Han <seb@redhat.com>

ceph-docker-lint: remove .build.swp file

Signed-off-by: Sébastien Han <seb@redhat.com>

Merge pull request #716 from ceph/wip-cannon-url

really fix the expected url to be canonicalized

really fix the expected url to be canonicalized

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #717 from ceph/docker-scenarios

ceph-docker: update scenario names

ceph-docker: update scenario names

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #715 from ceph/wip-fix-jenkins-invocation

fix the expected value of HUDSON_URL

fix the expected value of HUDSON_URL

and exit when deps aren't installed when running locally

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #713 from ceph/shellcheck-exclude

ceph-docker-lint: exclude codes

ceph-docker-lint: do not check variables_entrypoint.sh

Shellcheck will complain with SC2034: foo appears unused. Verify it or
export it.
The problem here is that this file contains a reference of all the
variables so indeed they appear unused.
We could potentially source some portion of the code from that file,
however I don't want to change the structure of the code because of
shellchecker. Also sourcing all the variables might results in expected
scenario if these variables are not expected to be declared.

There is no way to tell shellcheck to ignore this file so we should not
test it.

Signed-off-by: Sébastien Han <seb@redhat.com>

ceph-docker-lint: exclude codes

Excluding the following code:

* SC1091: since our entrypoint copies files in / during this shellcheck
the files can not be found. Basically we source ./file but presently the
file is under osd_directory/file so can not be found.
* SC2015: because we use 'set -e' we don't have other choice to use '||
true' here.
* SC2009: pgrep returns processes ID where we are looking for a specific
string in the process line.
* SC2001: our sed expressions are too complex we can not substitute them
with bash ${variable//search/replace}.

Signed-off-by: Sébastien Han <seb@redhat.com>

Merge pull request #712 from ceph/docker-ceph-ansible-version

ceph-docker-nightly: test on stable-2.2 of ceph-ansible

ceph-docker-nightly: test on stable-2.2 of ceph-ansible

We don't need to test on stable-2.1 of ceph-ansible anymore

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #711 from ceph/shellchecker-source

ceph-docker-lint: Shellchecker source

ceph-docker-lint: remove reverse grep for NOT_MAINTAINED_ANYMORE

As per PR: https://github.com/ceph/ceph-docker/pull/632 the directory
NOT_MAINTAINED_ANYMORE does not exist anymore.

Signed-off-by: Sébastien Han <seb@redhat.com>

ceph-docker-lint: shellcheck: allow 'source' outside of FILES.

ceph-docker sources a lot of files so to prevent warning from shellcheck
we add the option '-x' to source.
Follow 'source' statements even when the file is not specified as input.
By default, shellcheck will only follow files specified on the command
line (plus /dev/null).  This option allows following any file the
script may source.

Signed-off-by: Sébastien Han <seb@redhat.com>

Merge pull request #710 from ceph/wip-filter

filter files in PR to be only files ending in .sh$

filter files in PR to be only files ending in .sh$

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #709 from ceph/wip-docker-lint-config

check lint on all PRs automatically

Merge branch 'master' into wip-docker-lint-config

check lint on all PRs automatically

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #708 from ceph/wip-docker-lint-config

remove trigger whitelist

remove trigger whitelist

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #707 from ceph/wip-docker-lint

fix exit of build script

Merge branch 'master' into wip-docker-lint

fix exit of build script

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #706 from ceph/wip-docker-lint

limit shellcheck to files changed by the PR

limit shellcheck to files changed by the PR

also add some provisions for running locally

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #704 from ceph/wip-docker-lint2

correct lint executable; filter paths; set +e so we can lint all files

correct lint executable; filter paths; set +e so we can lint all files

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #703 from ceph/wip-docker-lint

install EPEL and correct package name

Merge branch 'master' into wip-docker-lint

install EPEL and correct package name

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #702 from ceph/wip-docker-lint

adds a linting of all shell files the project

adds a linting of all shell files in the project

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #701 from ceph/log-retention

Keep logs around longer for ceph-ansible/docker jobs

ceph-docker-prs: keep all logs in a 15 day period

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

ceph-ansible-prs: keep all logs in a 15 day period

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

ceph-docker-nightly: keep all logs forever

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #695 from ceph/libvirt-fixes

attempt to make libvirt slaves more stable

use libvirt util methods in all jobs that use libvirt

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

scripts: add libvirt util functions to build_utils.sh

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

ceph-installer-tests: restart libvirt services before running tests

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

ceph-docker-prs: restart libvirt services before running tests

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

ceph-docker-nightly: restart libvirt services before running tests

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

ceph-ansible-prs: restart libvirt services before running tests

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

ceph-installer-tests: remove old libvirt networks before running tests

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

ceph-docker-prs: remove old libvirt networks before running tests

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

ceph-docker-nightly: remove old libvirt networks before running tests

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #700 from ceph/wip-nfs-ganesha-version

nfs-ganesha: fix rpm version finder to work on dev and release candid…

nfs-ganesha: set VERSION correctly in rpm builds

$VERSION now set properly for "dev-X" & "rcX"
versions in rpm builds of nfs-ganesha.

Signed-off-by: Ali Maredia <amaredia@redhat.com>

Merge pull request #699 from ceph/ceph-ansible-scenario-fix

ceph-ansible-scenario: enable concurrent builds

ceph-ansible-scenario: enable concurrent builds

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #698 from ceph/ceph-ansible-scenario-fix

ceph-ansible-scenario: use include-raw instead of include-raw-escape

ceph-ansible-scenario: use include-raw instead of include-raw-escape

This job is not using a job-template and fails with the following error
when using include-raw-escape:

  syntax error near unexpected token `{{'

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #697 from ceph/ceph-ansible-scenario

ceph-ansible-scenario: create an individual scenario job

ceph-ansible-scenario: create an individual scenario job

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #696 from ceph/disable-ceph-prs-arm

ceph-prs-arm: disable for now, needs to get worked on

ceph-prs-arm: disable for now, needs to get worked on

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #693 from ceph/patched-jenkins

ansible: using forked version of python-jenkins until we can fix upstream

ansible: update examples with patched python-jenkins

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ansible: using forked version of python-jenkins until we can fix upstream

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #694 from ceph/rpm-install-mock

ceph-ansible/-installer: explicitly install mock

ceph-ansible/-installer: explicitly install mock

It appears that Yum is not installing "mock" when installing fedpkg
(with fedpkg-1.28-1.el7). Explicitly install it in our build steps.

Merge pull request #692 from ceph/slave-java-version

ansible: we now need java-1.8.0-openjdk on rpm nodes

ansible: we now need java-1.8.0-openjdk on rpm nodes

After the latest jenkins upgrade to 2.57 our centos slaves failed to
connect to jenkins, upgrading to a 1.8.0 version of java fixed the
issue.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #691 from ceph/ganesha-json-fix

nfs-ganesha: add missing comma in JSON blob

nfs-ganesha: add missing comma in JSON blob

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #689 from ceph/ceph-prs-arm

ceph-prs-arm: create a job to build arm on PRs

ceph-prs-arm: create a job to build arm on PRs

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #690 from ceph/libvirt-hammer

ceph-ansible-prs: remove old libvirt networks before running tests

ceph-ansible-prs: remove old libvirt networks before running tests

Occasionally we deal with libvirt network issues on jenkins slaves that
have been used for a couple test runs, this attempts to avoid those.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #688 from ceph/wip-bz-mill

re-organize the script

re-organize the script

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #687 from ceph/wip-bz-mill

add config to run the template generator

add config to run the template generator

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #686 from ceph/wip-bz-mill

see what is in the enviroment

use b-ranto's template trickto get the metrics map

Signed-off-by: Gregory Meno <gmeno@redhat.com>

see what is in the enviroment

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #685 from ceph/wip-bz-mill

del the project -- don't need it

Merge branch 'master' into wip-bz-mill

del the project -- don't need it

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #684 from ceph/luminous-trigger

ceph-dev-trigger: also build luminous

ceph-dev-trigger: also build luminous

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #683 from ceph/wip-bz-mill

adds a builder def.

adds a builder def.

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #682 from ceph/wip-bz-mill

adds a job definition

adds a job definition

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #681 from ceph/wip-bz-mill

adds a simple script that feeds bz counts into grafana

removing unnecessary teardown

Signed-off-by: Gregory Meno <gmeno@redhat.com>

adds a simple script that feeds bz counts into grafana

Signed-off-by: Gregory Meno <gmeno@redhat.com>

Merge pull request #679 from ceph/ceph-ansible-docs-prs

ceph-ansible-docs-prs: create a job for building docs on prs

ceph-ansible-docs-prs: create a job for building docs on prs

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #678 from ceph/libvirt-networks

ceph-ansible-prs: destroy and undefine libvirt networks on teardown

ceph-ansible-prs: destroy and undefine libvirt networks on teardown

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #677 from ceph/libvirt-kill-networks

ceph-ansible-prs: ensure libvirt networks are destroyed after a job is completed

ceph-ansible-prs: ensure libvirt networks are destroyed after a job is completed

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #676 from ceph/mkdir-typo

ceph-ansible-docs: fix a typo on mkdir

ceph-ansible-docs: fix a typo on mkdir

Signed-off-by: Alfredo Deza <adeza@redhat.com>