Merge pull request #16194 from cbodley/wip-20534

msg: QueueStrategy::wait() joins all threads

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>

Merge pull request #16196 from liewegas/wip-19518

ceph_test_rados_api_c_read_operations: do not assert per-op rval is correct

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16201 from tchaikov/wip-20432

common/Timer: do not add event if already shutdown

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16208 from ceph/wip-base-postun

rpm: Fix undefined FIRST_ARG

Reviewed-by: Nathan Cutler <ncutler@suse.com>

rpm: Fix undefined FIRST_ARG

If FIRST_ARG is undefined, the rpms will show an error on upgrade
because the condition in the postun script gets broken.

This was a regression introduced by commit for issue 20077 that moved
ceph-disk unit files to ceph-base.

Fixes: http://tracker.ceph.com/issues/20077
Signed-off-by: Boris Ranto <branto@redhat.com>

Merge pull request #16126 from ktdreyer/rpm-epoch-2

rpm: bump epoch ahead of RHEL base

Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Boris Ranto <branto@redhat.com>

Merge pull request #16199 from tchaikov/wip-release-note-escape-stars

tools: ceph-release-notes: escape asterisks not for inline emphasis

Reviewed-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #15895 from ganeshmaharaj/isal-v2.18

isa-l: update isa-l to v2.18

Reviewed-by: Kefu Chai <kchai@redhat.com>

common/Timer: do not add event if already shutdown

otherwise the callback is leaked.

Fixes: http://tracker.ceph.com/issues/20432
Signed-off-by: Kefu Chai <kchai@redhat.com>

tools: ceph-release-notes: escape asterisks not for inline emphasis

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge remote-tracking branch 'upstream/pull/15844/head' into master

* commit '47ab651a1f':
  qa: reset journal before cephfs_journal_tool_smoke.sh exits
  qa: remove 'apply' from journal_tool_smoke.sh

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge remote-tracking branch 'upstream/pull/15822/head' into master

* upstream/pull/15822/head:
  qa: add timeout/repeat to pool df

Reviewed-by: John Spray <jspray@redhat.com>

Merge remote-tracking branch 'upstream/pull/15950/head' into master

* upstream/pull/15950/head:
  qa: update thrash max mds testing

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge remote-tracking branch 'upstream/pull/15758/head' into master

* upstream/pull/15758/head:
  mds: repeat dir->is_frozen in rdlock_path_xlock_dentry

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge remote-tracking branch 'upstream/pull/15510/head' into master

* upstream/pull/15510/head:
  mds: improve freeze deadlock detection

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge remote-tracking branch 'upstream/pull/15937/head' into master

* upstream/pull/15937/head:
  qa: remove unused quota config option

Reviewed-by: John Spray <jspray@redhat.com>

Merge remote-tracking branch 'upstream/pull/15825/head' into master

* upstream/pull/15825/head:
  mds: remove unused MDBalancer member
  Update last_epoch_(over|under) in MDBalaner if mds0 has failed

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge remote-tracking branch 'upstream/pull/15818/head' into master

* upstream/pull/15818/head:
  mds: assert straydn to silence coverity error

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge remote-tracking branch 'upstream/pull/15817/head' into master

* upstream/pull/15817/head:
  qa: wait for healthy cluster before testing pins

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge remote-tracking branch 'upstream/pull/13770/head' into master

* upstream/pull/13770/head:
  tasks/cephfs: add TestStrays.test_replicated_delete_speed

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #15786 from markhpc/wip-bluestore-cache-behavior

os/bluestore: cap rocksdb cache size

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>

Merge pull request #16120 from yanghonggang/master

os/filestore/FileJournal: FileJournal::open() close journal file before return error

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16019 from wido/mgr-plugin-zabbix

mgr: Zabbix monitoring module

Reviewed-by: Kefu Chai <kchai@redhat.com>

ceph_test_rados_api_c_read_operations: do not assert per-op rval is correct

This is not included in the pg log and may be zeroed if there is an op
replayed.  Disable the assertion until the underlying bug is fixed.  See
http://tracker.ceph.com/issues/19518

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #15647 from gmayyyha/format-config-show

common,config: OPT_FLOAT and OPT_DOUBLE output format in config show

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #15743 from yuyuyu101/wip-20330

msg: make listen backlog an option, increase from 128 to 512

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #15781 from kchiu/wip-filejournal-fix

os/filestore: call committed_thru when no journal entries are replayed

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #15810 from liupan1111/wip-precise

msg/async: make recv_stamp more precise

Reviewed-by: Haomai Wang <haomai@xsky.com>

Merge pull request #16159 from tchaikov/wip-20432

Context: C_ContextsBase: delete enclosed contexts in dtor

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #15878 from renhwztetecs/renhw-wip-common-dns

common: Update the error string when res_nsearch() or res_search() fails

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Sage Weil <sweil@redhat.com>

Update isa-l to v2.18

This upgrade brings
-  Complete rewrite of DEFLATE optimizations resulting in 5X better
   throughput and compression ratios comapred to  zlib, lz4, lzo and 2X
   better decompression performance when compared to zlib.
-  AVX512 improvements to multi-buffer versions of MD5, SHA-1 and SHA-256
   cryptographic hashing functions resulting in 3X better in performance
   compared to the AVX2 generation.

This update improves bluestore compression and potential to improve
dedup performance.

Testing this patch with objectstore fio yeided a max of 37% increase in
compression performance.

Fio Params:
rw=randwrite,buffer_compress_percentage=50,nr_files=64,direct=1,buffered=0,size=4G,bs=64k

Test Avg BlueStore Compression Time
v2.16(us)  v2.18(us)
iodepth=1,jobs=1 241.658    175.476 27.39%
iodepth=2,jobs=2 184.174    145.861 20.80%
iodepth=4,jobs=4 143.617    104.392 27.31%
iodepth=8,jobs=8 146.984    116.505 20.74%
iodepth=16,jobs=8 180.167    112.769 37.41%

Signed-off-by: Ganesh Mahalingam <ganesh.mahalingam@intel.com>
Signed-off-by: Tushar Gohad <tushar.gohad@intel.com>

msg: QueueStrategy::wait() joins all threads

wait() was only looping over disp_threads, which is an intrusive list
that only contains threads that are waiting on a message from
ds_dispatch(). this means that some QSThreads could outlive the
QueueStrategy itself, causing a segfault in QueueStrategy::entry()

Fixes: http://tracker.ceph.com/issues/20534
Signed-off-by: Casey Bodley <cbodley@redhat.com>

common/config_opts: favor bluestore kv cache before meta until max.

Signed-off-by: Mark Nelson <mnelson@redhat.com>

Merge pull request #16171 from wjwithagen/wip-wjw-freebsd-nobtrfs

os/filestore: Exclude BTRFS on FreeBSD

Reviewed-by: Sage Weil <sage@redhat.com>

kv/RocksDBStore: explicitly disable block_cache when set to 0.

Signed-off-by: Mark Nelson <mnelson@redhat.com>

os/bluestore: limit kv cache size.

Signed-off-by: Mark Nelson <mnelson@redhat.com>

common/config_opts: Better rocksdb cache size description.

Signed-off-by: Mark Nelson <mnelson@redhat.com>

kv/RocksDBStore: default to disable row cache.

Signed-off-by: Mark Nelson <mnelson@redhat.com>

Merge pull request #15670 from rzarzynski/wip-rgw-postobj-get_params-error-handling

rgw: fix error handling in get_params() of RGWPostObj_ObjStore_S3.

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #15700 from mikulely/olh-cleanup

rgw: cleanup rgw-admin duplicated judge during OLH GET/READLOG

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #15777 from oritwas/wip-rgw-no-log-meta

rgw: log_meta only for more than one zone

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #15827 from joscollin/wip-CID1412979-uninitialized-members

rgw: Uninitialized member in LCRule

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #15938 from shashalu/fix-data-sync-run

rgw: fix radosgw-admin data sync run crash

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #15949 from joscollin/wip-cleanup-rgw-rest-warning

rgw: silence warning from -Wmaybe-uninitialized

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #15960 from aclamk/fix-rgw-cryptopp-compilation

radosgw: fix compilation with cryptopp

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #15965 from mdw-at-linuxbox/signature

rgw: fix s3 object uploads with chunked transfers and v4 signatures.

Reviewed-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>

Merge pull request #16156 from tchaikov/wip-20524

osd/filestore: Revert "os/filestore: move ondisk in front

Reviewed-by: Pan Liu <liupan1111@gmail.com>

filestore: Exclude BTRFS on FreeBSD

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #16155 from majianpeng/man-rados-add-offset

doc/rados.8: add offset option for put command

Reviewed-by: Kefu Chai <kchai@redhat.com>

doc/rados.8: add offset option for put command.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

Context: C_ContextsBase: delete enclosed contexts in dtor

there are chances that these contexts are never finished/completed

Fixes: http://tracker.ceph.com/issues/20432
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16032 from tanghaodong25/bluestore-aio-submit

os/bluestore/KernelDevice: batch aio submit

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16086 from liewegas/wip-btrfs-experimental

os/filestore: require experimental flag for btrfs

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Revert "os/filestore: move ondisk in front, so that return oncommit earlier, and improve write op performance."

This reverts commit 21f167cf39cc7c025004e9b455ce8ba1252863f0.

Fixes: http://tracker.ceph.com/issues/20524
Signed-off-by: Kefu Chai <kchai@redhat.com>

common: add query_str when res_search() failed

I don't know the abort information about DNS Resolver,
if not add "query_str".

Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>

Merge pull request #16026 from linuxbox2/wip-tag-timeout-secs

rgw: cls: ceph::timespan tag_timeout wrong units

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #15873 from ztczll/zl

osd: check queue_transaction return value

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #16048 from Yan-waller/wip-waller-0630mon

mon/mgr: add detail error infomation

Reviewed-by: John Spray <john.spray@redhat.com>

rpm: bump epoch ahead of RHEL base

RHEL's ceph-common package is "1". Move our upstream packages' epoch
ahead of that, so that upstream will always override whatever is in
RHEL, even if it happens to have a higher NVR one day.

Fixes: http://tracker.ceph.com/issues/20508
Signed-off-by: Ken Dreyer <kdreyer@redhat.com>

Merge pull request #16122 from tchaikov/wip-qa-warning-msg

qa/tasks/ceph: should be "Waiting for all PGs", not "all osds"

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #16117 from majianpeng/bluestore-move-object-exist-in-assign-nid

os/bluestore: move object exist in assign nid

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Sage Weil <sage@redhat.com>

os/bluestore/BlueStore: move "onode::exists=true" in _assign_nid.

If object  has nid, it always set exists =true in get_onode.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

Merge pull request #16110 from javacruft/wrap-and-sort

debian: wrap-and-sort all files

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #15642 from wjwithagen/wip-wjw-freebsd-ceph-disk-zap

ceph_disk/main.py: Allow FreeBSD zap a OSD disk

Reviewed-by: Loic Dachary <loic@dachary.org>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16084 from mikulely/fix-data-pool-cli

rgw,test: fix rgw placement rule pool config option

Reviewed By: Jos Collin <jcollin@redhat.com>

Merge pull request #16024 from dillaman/wip-19035

rbd: do not attempt to load key if auth is disabled

Reviewed-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #15860 from dillaman/wip-20168

librbd: fail IO request when exclusive lock cannot be obtained

Reviewed-by: Mykola Golub <mgolub@mirantis.com>

os/filestore/FileJournal: FileJournal::open() close journal file before return error

After successfully opened journal in FileJournal::open(), the following
error returns will cause journal->open() in JournalingObjectStore::journal_replay()
failed and delete journal. In ~FileJournal(), we assert fd == -1. As we not cleanup
journal fd in FileJournal::open(), fd is not -1. This will generate a core.

Fixes: http://tracker.ceph.com/issues/20504
Signed-off-by: Yang Honggang <joseph.yang@xtaotech.com>

Merge pull request #16118 from IlsooByun/fix-spdk-build-error

os/bluestore: fix build errors when spdk is on

Reviewed-by: Haomai Wang <haomai@xsky.com>

qa/tasks/ceph: should be "Waiting for all PGs", not "all osds"

amend the warning message

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #15265 from cooldavid/pr-osd-historic-op

osd: Preserve OSDOp information for historic ops

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #15964 from tchaikov/wip-5249

mon/MonClient: respect the priority in SRV RR

Reviewed-by: Gregory Farnum <gfarnum@redhat.com>

Merge pull request #15780 from wjwithagen/wip-wjw-freebsd-use-ceph_to_hostos_errno

core: make the conversion from wire error to host OS work

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

core: make the conversion from wire error to host OS work

 - The key change is the type of rval,
   that will call the conversion when en/decoded
 - Remainder is fixes for the type change and promotions

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

mgr: Zabbix monitoring module

This ceph-mgr module will pull various values from the Ceph cluster
and send them to a Zabbix Server using zabbix_sender.

This requires the zabbix_sender executable to be present on the system
running ceph-mgr as it will be invoked to send data to Zabbix.

A Zabbix template can be found in this directory which can be used
to easily get data from your Ceph cluster into Zabbix.

More information is available in the README file found in the module's
directory.

Signed-off-by: Wido den Hollander <wido@42on.com>

Merge pull request #15897 from yuyuyu101/wip-20390

msg/async: increase worker reference with local listen table enabled backend

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #15754 from tchaikov/wip-test-auth-caps

qa/suites: add test exercising workunits/mon/auth_caps.sh

Reviewed By: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Joao Eduardo Luis <joao@suse.de>

Merge pull request #16011 from hsepeng/cache-osd-bugfix

osd/PrimaryLogPG solve cache tier osd high memory consumption

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #13918 from liupan1111/wip-fix-performance-filestore

os/filestore: queue ondisk completion before apply work

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16051 from liewegas/wip-20381

os/bluestore: fix deferred_aio deadlock

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

os/bluestore: fix build errors when spdk is on

- remove pthread library link from dpdk cmake
- fix the bugs of NVMEDevice

Signed-off-by: Ilsoo Byun <ilsoo.byun@sk.com>

Merge pull request #15958 from liewegas/wip-mgr-modules

mgr,mon: enable/disable mgr modules via 'ceph mgr module ...' commands

Reviewed-by: John Spray <john.spray@redhat.com>

debian: wrap-and-sort all files

'wrap-and-sort -a -t' debian folder to apply consistent
ordering/formatting to all files.

This makes synchronization of debian package changes
between Ceph packages and Ubuntu packages easier to
manage.

Signed-off-by: James Page <james.page@ubuntu.com>

Merge pull request #15305 from wjwithagen/wip-wjw-HAVE_BABELTRACE

cmake: Rewrite HAVE_BABELTRACE  option to WITH_

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16094 from zphj1987/master

pybind/mgr/dashboard: fix get kernel_version error

Reviewed-by: Kefu Chai <kchai@redhat.com>

ceph-mgr:fix ceph-mgr web get kernel_version error

fix :
File "/usr/lib64/ceph/mgr/dashboard/module.py", line 523, in _clients
client['version'] = client['kernel_version']
----------

change client['kernel_version'] to
client['client_metadata']['kernel_version']

Signed-off-by: Peng Zhang zphj1987@gmail.com

Merge pull request #16093 from tchaikov/wip-20432

osd: clear_queued_recovery() in on_shutdown()

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #15823 from jdurgin/wip-omap-tp-heartbeat

osd/ReplicatedBackend: reset thread heartbeat after every omap entry …

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

osd: clear_queued_recovery() in on_shutdown()

otherwise when we are kicking the PG waiting in OSD's awaiting_throttle
queue, the queue is still holding a strong reference of it. then we will
have warnings like "pgid 0.7 has ref count of 2" when shutting down OSD,
because pgmap is also holding a reference of it.

we could clear the "awaiting_throttle" directly in OSD::shutdown(), but
clear_queued_recovery() is more consistent this way, because it is PG
which registered itself to the queue in OSD, it'd be better if PG can
remove itself from the OSD when it is shutting down itself.

Fixes: http://tracker.ceph.com/issues/20432
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16081 from tsg-/tsg-affiliation

mailmap, organizationmap: add affiliation for Tushar Gohad

Reviewed-by: Jos Collin <jcollin@redhat.com>

os/filestore: require experimental flag for btrfs

This isn't strictly accurate since we're really deprecating, but the
message is appropriately scary and reflects the risk of data loss.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge remote-tracking branch 'upstream/pull/16080/head' into HEAD

* upstream/pull/16080/head:
  doc/mon: clean up `mds fail`/`mds deactivate` descriptions

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

doc: fix rgw placment rule pool config option

actually we're checking '--data-pool' and '--data-extra-pool'
during the argument parsing.

Signed-off-by: Jiaying Ren <jiaying.ren@umcloud.com>

Merge pull request #15833 from Linbing/wip-osd-delete-MPing

osd: osd does not using MPing Messages,do not include unused include

Reviewed-by: Kefu Chai <kchai@redhat.com>

doc/mon: clean up `mds fail`/`mds deactivate` descriptions

Fixes: http://tracker.ceph.com/issues/20424
Signed-off-by: John Spray <john.spray@redhat.com>

Merge pull request #16072 from tchaikov/wip-20453

debian: workaround the bug in dpkg-maintscript-helper

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #15835 from SUSE/wip-flatten-systemd-target-hierarchy-master

systemd: Add explicit Before=ceph.target

Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Boris Ranto <branto@redhat.com>

mgr: Implement self_test() method in MgrModule

Other modules are encouraged to override this method and implement
a as good as possible self-test which returns True or False

It should be a simple way of running (automated) testing on a ceph-mgr
module

Signed-off-by: Wido den Hollander <wido@42on.com>

mgr: set/get_localized_config in MgrModule

get_localized_config was getting redundant as it was copied to various
modules.

This commit also introduces set_localized_config() which set a localized
configuration option for a module.

Signed-off-by: Wido den Hollander <wido@42on.com>

Merge pull request #16067 from YangFanlinux/affi

 .mailmap, .organizationmap: Update Fan Yang information and affiliation

Reviewed By: Jos Collin <jcollin@redhat.com>