]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/log
ceph-ci.git
4 years agoRevert "vstart_runner: rotate logs between testcases"
Ernesto Puerta [Wed, 19 Aug 2020 08:36:05 +0000 (10:36 +0200)]
Revert "vstart_runner: rotate logs between testcases"

Fixes: https://tracker.ceph.com/issues/47032
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
4 years agoMerge pull request #36706 from Daniel-Pivonka/cephadm-rootuserdocfix
Sebastian Wagner [Wed, 19 Aug 2020 07:45:36 +0000 (09:45 +0200)]
Merge pull request #36706 from Daniel-Pivonka/cephadm-rootuserdocfix

doc/cephadm: remove ssh user limitation troubleshooting

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #36531 from tchaikov/wip-alpine
Kefu Chai [Wed, 19 Aug 2020 03:05:59 +0000 (11:05 +0800)]
Merge pull request #36531 from tchaikov/wip-alpine

alpine: remove stale Alpine build recipe

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #36688 from coreycb/master
Jason Dillaman [Tue, 18 Aug 2020 21:23:25 +0000 (17:23 -0400)]
Merge pull request #36688 from coreycb/master

librbd: Align rbd_write_zeroes declarations

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agodoc/cephadm: remove ssh user limitation troubleshooting
Daniel-Pivonka [Tue, 18 Aug 2020 20:46:35 +0000 (16:46 -0400)]
doc/cephadm: remove ssh user limitation troubleshooting

Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
4 years agoMerge PR #35824 into master
Patrick Donnelly [Tue, 18 Aug 2020 16:27:49 +0000 (09:27 -0700)]
Merge PR #35824 into master

* refs/pull/35824/head:
vstart_runner.py: rotate logs between testcases
vstart.sh: write logrotate conf and rotate logs
vstart_runner: run one test method at a time...

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #36533 into master
Patrick Donnelly [Tue, 18 Aug 2020 16:00:44 +0000 (09:00 -0700)]
Merge PR #36533 into master

* refs/pull/36533/head:
mon: store mon updates in ceph context for future MonMap instantiation

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #36530 from tchaikov/wip-cmake-python2
Kefu Chai [Tue, 18 Aug 2020 15:18:05 +0000 (23:18 +0800)]
Merge pull request #36530 from tchaikov/wip-cmake-python2

cmake: drop WITH_PYTHON2 option

Reviewed-By: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge pull request #36543 from jschmid1/prevent_path_from_non_data_devices
Sebastian Wagner [Tue, 18 Aug 2020 13:45:49 +0000 (15:45 +0200)]
Merge pull request #36543 from jschmid1/prevent_path_from_non_data_devices

python-common: ban paths from non-data-devices

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #36568 from jschmid1/remove_osd_spec
Sebastian Wagner [Tue, 18 Aug 2020 13:38:36 +0000 (15:38 +0200)]
Merge pull request #36568 from jschmid1/remove_osd_spec

mgr/orchestrator: remove traces of ceph orch osd spec

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #36541 from jschmid1/save_osdspec_affinity_to_store
Sebastian Wagner [Tue, 18 Aug 2020 13:37:29 +0000 (15:37 +0200)]
Merge pull request #36541 from jschmid1/save_osdspec_affinity_to_store

mgr/cephadm: save osdspec_affinity to dd store

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #36584 from jschmid1/get_daemons_by_type
Sebastian Wagner [Tue, 18 Aug 2020 13:36:34 +0000 (15:36 +0200)]
Merge pull request #36584 from jschmid1/get_daemons_by_type

mgr/cephadm: add by_type daemon retrieval method

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #34918 from bk201/wip-45397
Lenz Grimmer [Tue, 18 Aug 2020 12:00:35 +0000 (14:00 +0200)]
Merge pull request #34918 from bk201/wip-45397

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #36674 from tchaikov/wip-doc-crimson
Kefu Chai [Tue, 18 Aug 2020 11:05:42 +0000 (19:05 +0800)]
Merge pull request #36674 from tchaikov/wip-doc-crimson

doc/dev/crimson: note about script/ceph-debug-docker.sh

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agovstart_runner.py: rotate logs between testcases
Rishabh Dave [Mon, 29 Jun 2020 06:30:12 +0000 (12:00 +0530)]
vstart_runner.py: rotate logs between testcases

Fixes: https://tracker.ceph.com/issues/46059
Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 years agovstart.sh: write logrotate conf and rotate logs
Rishabh Dave [Tue, 30 Jun 2020 10:19:29 +0000 (15:49 +0530)]
vstart.sh: write logrotate conf and rotate logs

Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 years agovstart_runner: run one test method at a time...
Rishabh Dave [Thu, 25 Jun 2020 17:35:58 +0000 (23:05 +0530)]
vstart_runner: run one test method at a time...

instead of running entire testsuite at once; this would allow us more
control on the test runner.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 years agoMerge pull request #36686 from sebastian-philipp/ceaphdm-upgrade-pytest
Sebastian Wagner [Tue, 18 Aug 2020 08:38:53 +0000 (10:38 +0200)]
Merge pull request #36686 from sebastian-philipp/ceaphdm-upgrade-pytest

mgr/cephadm: Add tests/test_upgrade.py

Reviewed-by: Joshua Schmid <jschmid@suse.de>
4 years agoMerge pull request #36629 from yison/fix-mem-leak-nvmedevice
Kefu Chai [Tue, 18 Aug 2020 06:57:41 +0000 (14:57 +0800)]
Merge pull request #36629 from yison/fix-mem-leak-nvmedevice

blk/spdk/NVMEDevice.cc: fix a memory leak issue

Reviewed-By: Kefu Chai <kchai@redhat.com>
4 years agoalpine: remove stale Alpine build recipe
Kefu Chai [Sat, 8 Aug 2020 08:57:37 +0000 (16:57 +0800)]
alpine: remove stale Alpine build recipe

alpine build recipe is stale and does not work with the latest Ceph,
also the APKBUILD for Ceph can be found at alphine's aports repo, see
https://gitlab.alpinelinux.org/alpine/aports/-/tree/master/community/ceph.

so instead keeping a stale version, let's drop it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge PR #36515 into master
Patrick Donnelly [Tue, 18 Aug 2020 03:40:42 +0000 (20:40 -0700)]
Merge PR #36515 into master

* refs/pull/36515/head:
libcephfs: ignore restoring the open files limit
msg: throw a system error when center.init fails

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #36525 into master
Patrick Donnelly [Tue, 18 Aug 2020 03:39:25 +0000 (20:39 -0700)]
Merge PR #36525 into master

* refs/pull/36525/head:
client: switch to use ceph_mutex_is_locked_by_me always

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #36552 into master
Patrick Donnelly [Tue, 18 Aug 2020 03:35:31 +0000 (20:35 -0700)]
Merge PR #36552 into master

* refs/pull/36552/head:
mds: fix kcephfs parse dirfrag's ndist is always 0

Reviewed-by: Zheng Yan <zyan@redhat.com>
4 years agoMerge PR #36617 into master
Patrick Donnelly [Tue, 18 Aug 2020 03:34:44 +0000 (20:34 -0700)]
Merge PR #36617 into master

* refs/pull/36617/head:
mds: revert the decode version

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agolibrbd: Align rbd_write_zeroes declarations
Corey Bryant [Mon, 17 Aug 2020 12:19:25 +0000 (08:19 -0400)]
librbd: Align rbd_write_zeroes declarations

Fixes: https://tracker.ceph.com/issues/46928
Signed-off-by: Corey Bryant <corey.bryant@canonical.com>
4 years agoMerge pull request #36605 from rhcs-dashboard/fix-46920-master
Lenz Grimmer [Mon, 17 Aug 2020 13:19:41 +0000 (15:19 +0200)]
Merge pull request #36605 from rhcs-dashboard/fix-46920-master

mgr/dashboard/api: reduce amount of daemon logs

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #36312 from ishanrai05/bug-1
Lenz Grimmer [Mon, 17 Aug 2020 13:12:31 +0000 (15:12 +0200)]
Merge pull request #36312 from ishanrai05/bug-1

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agomgr/cephadm: also mock `ceph vesions`
Sebastian Wagner [Mon, 17 Aug 2020 11:07:03 +0000 (13:07 +0200)]
mgr/cephadm: also mock `ceph vesions`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agomgr/cephadm: add test_upgrade.py
Sebastian Wagner [Mon, 17 Aug 2020 10:34:02 +0000 (12:34 +0200)]
mgr/cephadm: add test_upgrade.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agomgr/cephadm/tests: move with_service to fixtures.py
Sebastian Wagner [Mon, 17 Aug 2020 09:11:21 +0000 (11:11 +0200)]
mgr/cephadm/tests: move with_service to fixtures.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agopybind/mgr: Also mock the config store in pytest
Sebastian Wagner [Fri, 7 Aug 2020 14:21:18 +0000 (16:21 +0200)]
pybind/mgr: Also mock the config store in pytest

This will be used to dry-run mgr/cephadm/upgrade.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #36476 from ceph/42072-landing-page
Lenz Grimmer [Mon, 17 Aug 2020 08:43:39 +0000 (10:43 +0200)]
Merge pull request #36476 from ceph/42072-landing-page

mgr/dashboard: Landing Page improvements

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge pull request #36669 from smithfarm/wip-nautilus-11
Abhishek L [Mon, 17 Aug 2020 08:42:10 +0000 (10:42 +0200)]
Merge pull request #36669 from smithfarm/wip-nautilus-11

doc/releases: add Nautilus 14.2.11 to timeline

Reviewed-By: Kefu Chai <kchai@redhat.com>
Reviewed-By: Zac Dover <zac.dover@gmail.com>
Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>
4 years agoMerge pull request #36508 from mgfritch/cephadm-nfs-rados-pool
Sebastian Wagner [Mon, 17 Aug 2020 07:50:13 +0000 (09:50 +0200)]
Merge pull request #36508 from mgfritch/cephadm-nfs-rados-pool

mgr/cephadm: check existence of the RADOS pool

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
4 years agomgr/dashboard: clear Jest cache before testing
Kiefer Chang [Wed, 29 Jul 2020 13:05:04 +0000 (21:05 +0800)]
mgr/dashboard: clear Jest cache before testing

Jest seems to not detect removed files correctly. Let's clean the cache
before performing frontend unit tests in CI.

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
4 years agomgr/dashboard: leverage features set from orchestrator
Kiefer Chang [Wed, 6 May 2020 08:20:06 +0000 (16:20 +0800)]
mgr/dashboard: leverage features set from orchestrator

Orchestrator provides a list of supported functions. Using
this list to provide better UX and guard for unsupported
features.

- Backend: return 503 if required orchestrator features are
  missing, rather than calling non-implemented methods
  in orchestrator.
- Frontend:
  - Remove information modal when Orchestrator is not available.
  - Disable table action buttons if Orchestrator is not available
    or features are not supported.

Fixes: https://tracker.ceph.com/issues/45397
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
4 years agoMerge pull request #36228 from vosdev/doc-mgr-crash-typo
Kefu Chai [Mon, 17 Aug 2020 03:17:02 +0000 (11:17 +0800)]
Merge pull request #36228 from vosdev/doc-mgr-crash-typo

doc/mgr/crash: Add missing command in rm example

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36623 from cheese/master
Kefu Chai [Mon, 17 Aug 2020 02:41:49 +0000 (10:41 +0800)]
Merge pull request #36623 from cheese/master

common: document the current semantics of bl::append(std::istream)

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36418 from changchengx/osd_map
Kefu Chai [Mon, 17 Aug 2020 02:33:15 +0000 (10:33 +0800)]
Merge pull request #36418 from changchengx/osd_map

osd/OSDMap: corret osd_info_t last_clean comment

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agodoc/dev/crimson: note about script/ceph-debug-docker.sh
Kefu Chai [Sun, 16 Aug 2020 14:31:38 +0000 (22:31 +0800)]
doc/dev/crimson: note about script/ceph-debug-docker.sh

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36642 from tchaikov/wip-crimson-silence-warnings
Kefu Chai [Sun, 16 Aug 2020 14:48:56 +0000 (22:48 +0800)]
Merge pull request #36642 from tchaikov/wip-crimson-silence-warnings

crimson: silence warnings from clang++

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agocrimson/osd: do not capture unused variables
Kefu Chai [Sat, 15 Aug 2020 11:05:46 +0000 (19:05 +0800)]
crimson/osd: do not capture unused variables

this change silences warnings like

src/crimson/osd/pg_backend.cc:232:34: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
        [&os, &osd_op, &extents, this](auto&& bl) -> read_errorator::future<> {

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/os: do not return a value for non-reachable branch
Kefu Chai [Sat, 15 Aug 2020 11:04:19 +0000 (19:04 +0800)]
crimson/os: do not return a value for non-reachable branch

for silencing a warning like

btree/btree_lba_manager.cc:177:12: warning: binding dereferenced null pointer to reference has undefined behavior [-Wnull-dereference]
    return *static_cast<btree_range_pin_t*>(nullptr);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

ceph_abort_msg() is marked [[noreturn]], so we can just use it here
without worrying about complains from compiler.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc/releases: add Nautilus 14.2.11 to timeline
Nathan Cutler [Sat, 15 Aug 2020 20:55:44 +0000 (22:55 +0200)]
doc/releases: add Nautilus 14.2.11 to timeline

Signed-off-by: Nathan Cutler <ncutler@suse.com>
4 years agoMerge pull request #36479 from dillaman/wip-46669
Mykola Golub [Sat, 15 Aug 2020 15:31:10 +0000 (18:31 +0300)]
Merge pull request #36479 from dillaman/wip-46669

test/rbd-mirror: pool watcher registration error might result in race

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge pull request #36639 from tchaikov/wip-crimson-build-push-op
Kefu Chai [Sat, 15 Aug 2020 10:47:46 +0000 (18:47 +0800)]
Merge pull request #36639 from tchaikov/wip-crimson-build-push-op

crimson/osd: clear data_included if fiemap fails

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoMerge pull request #36505 from rzarzynski/wip-crimson-bump-up-seastar
Kefu Chai [Sat, 15 Aug 2020 10:41:42 +0000 (18:41 +0800)]
Merge pull request #36505 from rzarzynski/wip-crimson-bump-up-seastar

crimson: bump up seastar version to freshest master

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36529 from tchaikov/wip-crimson-dts-9
Kefu Chai [Sat, 15 Aug 2020 10:39:48 +0000 (18:39 +0800)]
Merge pull request #36529 from tchaikov/wip-crimson-dts-9

ceph.spec.in: use devtoolset-9 for building crimson

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
4 years agoinstall-deps.sh: add tchaikov's copr repo for crimson build on el8
Kefu Chai [Sat, 15 Aug 2020 03:22:53 +0000 (11:22 +0800)]
install-deps.sh: add tchaikov's copr repo for crimson build on el8

we need it before the updated version of gcc-toolset9 addressing
https://bugzilla.redhat.com/show_bug.cgi?id=1853900 is available in
RHEL8/CentOS8.

see https://copr.fedorainfracloud.org/coprs/tchaikov/gcc-toolset-9

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoceph.spec.in: use gcc-toolset-9 for building crimson
Kefu Chai [Sat, 8 Aug 2020 06:33:01 +0000 (14:33 +0800)]
ceph.spec.in: use gcc-toolset-9 for building crimson

since seastar dropped support from C++14, we have to move to a compiler
with a decent C++17 support.

in this change, gcc-toolset-9 is used for compiling ceph if seastar is
enabled. use version >= 9.2.1-2.2, because of
https://bugzilla.redhat.com/show_bug.cgi?id=1853900

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: clear data_included if read fails
Kefu Chai [Sat, 15 Aug 2020 02:51:04 +0000 (10:51 +0800)]
crimson/osd: clear data_included if read fails

* extract read_object_for_push_op() out of build_push_op().
  build_push_op() is composed of multiple steps. would be better
  if we can split and extract them into separated method for better
  readability
* clear push_op->data_included() if fiemap fails. before this change,
  a local copy of `copy_subset` is cleared if fiemap fails, but
  push_op->data_included is not updated in this case. we should
  clear the latter if no data is returned in push_op->data. so,
  in this change, push_op->data_included is cleared if fiemap
  fails. the same applies to other cases where no data is returned in
  push_op
* add comments to outline the steps in read_object_for_push_op().

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: print detailed info of object being recovered
Kefu Chai [Fri, 14 Aug 2020 14:53:15 +0000 (22:53 +0800)]
crimson/osd: print detailed info of object being recovered

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: remove stale comment
Kefu Chai [Fri, 14 Aug 2020 14:00:14 +0000 (22:00 +0800)]
crimson/osd: remove stale comment

CyanStore supports readv() now, so remove this comment.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: do not use __func__ in a lambda
Kefu Chai [Fri, 14 Aug 2020 13:26:21 +0000 (21:26 +0800)]
crimson/osd: do not use __func__ in a lambda

otherwise we would have logging messages like

operator(): returning obc ...

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoblk/spdk/NVMEDevice.cc: fix a memory leak issue
Yuan Lu [Fri, 14 Aug 2020 19:11:30 +0000 (19:11 +0000)]
blk/spdk/NVMEDevice.cc: fix a memory leak issue

Signed-off-by: Yuan Lu <yuan.y.lu@intel.com>
4 years agoMerge pull request #36618 from tspmelo/wip-backport-jq
Nathan Cutler [Fri, 14 Aug 2020 18:07:06 +0000 (20:07 +0200)]
Merge pull request #36618 from tspmelo/wip-backport-jq

script/ceph-backport.sh: Check if jq is installed

4 years agoMerge pull request #36609 from tspmelo/wip-doc-browsers
Lenz Grimmer [Fri, 14 Aug 2020 13:31:40 +0000 (15:31 +0200)]
Merge pull request #36609 from tspmelo/wip-doc-browsers

mgr/dashboard: Update list of supported browsers

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #36624 from lixiaoy1/fix_config
Jason Dillaman [Fri, 14 Aug 2020 12:29:35 +0000 (08:29 -0400)]
Merge pull request #36624 from lixiaoy1/fix_config

rbd/rwl: fix the config issue

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #36466 from lixiaoy1/rbd_image_info_br
Jason Dillaman [Fri, 14 Aug 2020 12:21:11 +0000 (08:21 -0400)]
Merge pull request #36466 from lixiaoy1/rbd_image_info_br

rbd/status: get image cache state

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #36422 from orozery/object_dispatch_assert_version_write
Jason Dillaman [Fri, 14 Aug 2020 12:20:49 +0000 (08:20 -0400)]
Merge pull request #36422 from orozery/object_dispatch_assert_version_write

librbd: support writing with version assertion on object dispatch

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #36366 from runsisi/wip-fix-free
Jason Dillaman [Fri, 14 Aug 2020 12:20:30 +0000 (08:20 -0400)]
Merge pull request #36366 from runsisi/wip-fix-free

librbd: fix possible use after free error while shuting down exclusive lock

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #36561 from lixiaoy1/fix_queue
Jason Dillaman [Fri, 14 Aug 2020 12:20:10 +0000 (08:20 -0400)]
Merge pull request #36561 from lixiaoy1/fix_queue

rbd/rwl: fix the construction of ContextWQ

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agomgr/dashboard: Update list of supported browsers
Tiago Melo [Thu, 13 Aug 2020 13:46:56 +0000 (13:46 +0000)]
mgr/dashboard: Update list of supported browsers

Fixes: https://tracker.ceph.com/issues/46923
Signed-off-by: Tiago Melo <tmelo@suse.com>
4 years agorbd/rwl: fix the config issue
lixiaoy1 [Fri, 14 Aug 2020 11:09:57 +0000 (07:09 -0400)]
rbd/rwl: fix the config issue

Include acconfig.h to the librbd/cache/Util.h.

Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
4 years agoscript/ceph-backport.sh: Check if jq is installed
Tiago Melo [Thu, 13 Aug 2020 15:38:37 +0000 (15:38 +0000)]
script/ceph-backport.sh: Check if jq is installed

If you tried to setup ceph-backport.sh without having 'jq' installed, you would
get a totally unrelated error message and it was hard to figure out the problem.

Signed-off-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge pull request #36604 from tspmelo/wip-favicon-circle
Lenz Grimmer [Fri, 14 Aug 2020 08:22:12 +0000 (10:22 +0200)]
Merge pull request #36604 from tspmelo/wip-favicon-circle

mgr/dashboard: Fix favicon white circle

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #36602 from tspmelo/wip-spell-check
Lenz Grimmer [Fri, 14 Aug 2020 08:19:46 +0000 (10:19 +0200)]
Merge pull request #36602 from tspmelo/wip-spell-check

mgr/dashboard: Fix spell errors

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
4 years agoMerge pull request #36585 from votdev/proper_format_portals
Lenz Grimmer [Fri, 14 Aug 2020 08:16:56 +0000 (10:16 +0200)]
Merge pull request #36585 from votdev/proper_format_portals

mgr/dashboard: Proper format iSCSI target portals

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge pull request #36566 from votdev/issue_46900_autocomplete
Lenz Grimmer [Fri, 14 Aug 2020 08:13:30 +0000 (10:13 +0200)]
Merge pull request #36566 from votdev/issue_46900_autocomplete

mgr/dashboard: Strange iSCSI discovery auth behavior

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge pull request #36567 from votdev/issue_46901_hide_limit_action_field
Lenz Grimmer [Fri, 14 Aug 2020 08:06:30 +0000 (10:06 +0200)]
Merge pull request #36567 from votdev/issue_46901_hide_limit_action_field

mgr/dashboard: Hide table action input field if limit=0

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agocommon: document the current semantics of bl::append(std::istream)
Robin Lee [Thu, 13 Aug 2020 06:42:52 +0000 (14:42 +0800)]
common: document the current semantics of bl::append(std::istream)

bl::append(std::istream) comes with a surprise implementation. People may think
it would just slurp the indentical binary data from the stream. Document the
trap to let people don't mis-use it.

Signed-off-by: Robin Lee <cheeselee@fedoraproject.org>
4 years agomon: store mon updates in ceph context for future MonMap instantiation
Shyamsundar Ranganathan [Mon, 10 Aug 2020 00:47:43 +0000 (20:47 -0400)]
mon: store mon updates in ceph context for future MonMap instantiation

MonMap builds initial mon list using provided sources, like
mon-host or monmap.

For future instantiations of MonClient, if mon addresses are
updated, stale information from the provided sources are used.

This commit retains mon updates that are processed by the
MonClient in CephContext, for use in MonMap instantiations
and hence uses updated information as required.

This is helpful in cases where librados or libcephfs
instantiate MonClient in the ceph-mgr deamon as required.

Fixes: https://tracker.ceph.com/issues/46645
Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
4 years agoMerge pull request #36510 from athanatos/sjust/wip-tm-decref
Kefu Chai [Thu, 13 Aug 2020 19:47:55 +0000 (03:47 +0800)]
Merge pull request #36510 from athanatos/sjust/wip-tm-decref

crimson: remove extent from cache in TransactionManager::dec_ref

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/os/seastore/transaction_manager: complete dec_ref
Samuel Just [Wed, 5 Aug 2020 02:50:45 +0000 (19:50 -0700)]
crimson/os/seastore/transaction_manager: complete dec_ref

Previously, dec_ref didn't handle actually retiring the
extent from the cache.  dec_ref will now reach into the
cache and mark the extent retired if it exists either
in the cache or in the current transaction.

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/lba_manager: clarify ref count operation return
Samuel Just [Thu, 6 Aug 2020 04:35:48 +0000 (21:35 -0700)]
crimson/os/seastore/lba_manager: clarify ref count operation return

Previously, we returned a refcount from inc_ref and dec_ref.  Now,
return the paddr as well for future code accounting for released
extents.

In addition, replumb btree_lba_manager to return an enoent error if
the mapping does not exist, and the resulting refcount, paddr
otherwise with a refcount of 0 indicating that the mapping has
been removed.

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/cache: don't mark invalid extents clean
Samuel Just [Thu, 6 Aug 2020 00:03:31 +0000 (17:03 -0700)]
crimson/os/seastore/cache: don't mark invalid extents clean

In the event that an extent is created and removed in the same
transaction (invalid extent in fresh_block_list), update
block specific metadata but don't add to cache and especially
do not mark clean.  LBAManager::complete_commit implementations
are meant to use skip based on state in the same way.

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/cached_extent: add print_detail for logical extents
Samuel Just [Thu, 6 Aug 2020 00:00:07 +0000 (17:00 -0700)]
crimson/os/seastore/cached_extent: add print_detail for logical extents

This way we can always see laddr in debug output.

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agomds: revert the decode version
Jos Collin [Thu, 13 Aug 2020 15:30:13 +0000 (21:00 +0530)]
mds: revert the decode version

Introduced in
https://github.com/ceph/ceph/commit/3fac3b1236c4918e9640e38fe7f5f59efc0a23b9,
the decode changes are reverted but the version number is not.

Fixes: https://tracker.ceph.com/issues/46926
Signed-off-by: Jos Collin <jcollin@redhat.com>
4 years agoMerge pull request #36591 from idryomov/wip-snap-create-progress
Ilya Dryomov [Thu, 13 Aug 2020 14:25:06 +0000 (16:25 +0200)]
Merge pull request #36591 from idryomov/wip-snap-create-progress

qa: update krbd tests for snap create

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #36434 from ricardoasmarques/fix-iscsi-logged-in-client-edit
Lenz Grimmer [Thu, 13 Aug 2020 13:58:46 +0000 (15:58 +0200)]
Merge pull request #36434 from ricardoasmarques/fix-iscsi-logged-in-client-edit

mgr/dashboard: Unable to edit iSCSI logged-in client

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #36564 from ceph/46899-log-info-from-unhandled-errors
Lenz Grimmer [Thu, 13 Aug 2020 13:31:38 +0000 (15:31 +0200)]
Merge pull request #36564 from ceph/46899-log-info-from-unhandled-errors

mgr/dashboard: log useful information from internal server errors

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Fabrizio D'Angelo <fdangelo@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
4 years agomgr/dashboard: Landing Page improvements
Alfonso Martínez [Thu, 13 Aug 2020 12:29:38 +0000 (14:29 +0200)]
mgr/dashboard: Landing Page improvements

Fixes: https://tracker.ceph.com/issues/42072
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
4 years agomgr/dashboard/api: reduce amount of daemon logs
Ernesto Puerta [Thu, 13 Aug 2020 11:45:17 +0000 (13:45 +0200)]
mgr/dashboard/api: reduce amount of daemon logs

Fixes: https://tracker.ceph.com/issues/46920
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
4 years agomgr/dashboard: Fix favicon white circle
Tiago Melo [Thu, 13 Aug 2020 11:38:15 +0000 (11:38 +0000)]
mgr/dashboard: Fix favicon white circle

A white circle was displayed when the user logged out.

Fixes: https://tracker.ceph.com/issues/46919
Signed-off-by: Tiago Melo <tmelo@suse.com>
4 years agomgr/dashboard: Fix spell errors
Tiago Melo [Mon, 22 Jun 2020 14:59:23 +0000 (14:59 +0000)]
mgr/dashboard: Fix spell errors

Fixes: https://tracker.ceph.com/issues/46917
Signed-off-by: Tiago Melo <tmelo@suse.com>
4 years agomgr/dashboard: fix error message for the confirmpassword
Ishan Rai [Wed, 5 Aug 2020 08:36:08 +0000 (14:06 +0530)]
mgr/dashboard: fix error message for the confirmpassword

fixes: https://tracker.ceph.com/issues/46494

Signed-off-by: Ishan Rai <ishanrai05@gmail.com>
4 years agomgr/dashboard: remove password fields, if the login is using SSO
Ishan Rai [Wed, 5 Aug 2020 08:34:30 +0000 (14:04 +0530)]
mgr/dashboard: remove password fields, if the login is using SSO

fixes: https://tracker.ceph.com/issues/46494

Signed-off-by: Ishan Rai <ishanrai05@gmail.com>
4 years agomgr/dashboard: Proper format iSCSI target portals
Volker Theile [Wed, 12 Aug 2020 10:54:07 +0000 (12:54 +0200)]
mgr/dashboard: Proper format iSCSI target portals

Proper format the 'Portals' and 'Images' columns.

Fixes: https://tracker.ceph.com/issues/46908
Signed-off-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #36532 from simon-rock/crash_on_restart
Yan, Zheng [Thu, 13 Aug 2020 01:55:16 +0000 (09:55 +0800)]
Merge pull request #36532 from simon-rock/crash_on_restart

mds : move start_files_to_recover() to recovery_done

4 years agomds : move start_files_to_recover() to recovery_done
Simon Gao [Sun, 9 Aug 2020 07:38:30 +0000 (15:38 +0800)]
mds : move start_files_to_recover()  to recovery_done

the requests in the queue, named waiting_for_replay, may modify the state of the filelock,
resulting in the wrong lock state when repairing file (start_files_to_recover)

Fixes : https://tracker.ceph.com/issues/46906
Signed-off-by: Simon Gao <simon29rock@gmail.com>
4 years agoMerge pull request #36119 from votdev/issue_44831_deploy_service
Lenz Grimmer [Wed, 12 Aug 2020 16:05:25 +0000 (18:05 +0200)]
Merge pull request #36119 from votdev/issue_44831_deploy_service

mgr/dashboard: Create Ceph services via Orchestrator by using ServiceSpec

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
4 years agoqa: update krbd tests for snap create
Ilya Dryomov [Tue, 11 Aug 2020 15:45:18 +0000 (17:45 +0200)]
qa: update krbd tests for snap create

"rbd snap create" now reports progress.  Pass --no-progress, as in
commit b5a5fea9e2b4 ("test/cli-integration/rbd: tweak after snap create
started to show progress").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
4 years agoMerge pull request #36569 from yuriw/wip-yuriw-crontab-master
Yuri Weinstein [Wed, 12 Aug 2020 14:43:20 +0000 (07:43 -0700)]
Merge pull request #36569 from yuriw/wip-yuriw-crontab-master

qa/tests: use "-k distro" for all suites (except krbd)

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #36570 from theanalyst/doc/releases/v14.2.11
Abhishek L [Wed, 12 Aug 2020 14:10:57 +0000 (16:10 +0200)]
Merge pull request #36570 from theanalyst/doc/releases/v14.2.11

doc: releases: notes for v14.2.11 nautilus

Reviewed-By: Neha Ojha <nojha@redhat.com>
Reviewed-By: Josh Durgin <jdurgin@redhat.com>
Reviewed-By: Patrick Donelly <pdonell@redhat.com>
4 years agorbd/rwl: fix the construction of ContextWQ
lixiaoy1 [Tue, 11 Aug 2020 16:26:01 +0000 (12:26 -0400)]
rbd/rwl: fix the construction of ContextWQ

Fix the build issue caused by the commit c11594a which changed the constructor
of ContextWQ.

Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
4 years agomgr/dashboard: log useful information from internal server errors
Alfonso Martínez [Wed, 12 Aug 2020 11:22:27 +0000 (13:22 +0200)]
mgr/dashboard: log useful information from internal server errors

Fixes: https://tracker.ceph.com/issues/46899
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
4 years agorbd/status: get image cache state
lixiaoy1 [Fri, 7 Aug 2020 09:11:20 +0000 (05:11 -0400)]
rbd/status: get image cache state

Signed-off-by: Peterson, Scott <scott.d.peterson@intel.com>
Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
Signed-off-by: Lu, Yuan <yuan.y.lu@intel.com>
Signed-off-by: Chamarthy, Mahati <mahati.chamarthy@intel.com>
4 years agomgr/cephadm: add by_type daemon retrieval method
Joshua Schmid [Wed, 12 Aug 2020 10:23:59 +0000 (12:23 +0200)]
mgr/cephadm: add by_type daemon retrieval method

Signed-off-by: Joshua Schmid <jschmid@suse.de>
4 years agomgr/dashboard: Strange iSCSI discovery auth behavior
Volker Theile [Tue, 11 Aug 2020 12:53:56 +0000 (14:53 +0200)]
mgr/dashboard: Strange iSCSI discovery auth behavior

Disable 'autocomplete' for the user and password form fields.

Fixes: https://tracker.ceph.com/issues/46900
Signed-off-by: Volker Theile <vtheile@suse.com>
4 years agodoc: releases: notes for v14.2.11 nautilus
Abhishek Lekshmanan [Tue, 11 Aug 2020 19:02:11 +0000 (21:02 +0200)]
doc: releases: notes for v14.2.11 nautilus

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>