]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ci.git/log
ceph-ci.git
2 weeks agoMerge branch 'ceph-volume-inventory-ls-all' of https://github.com/guits/ceph into...
Guillaume Abrioux [Mon, 9 Feb 2026 12:01:44 +0000 (12:01 +0000)]
Merge branch 'ceph-volume-inventory-ls-all' of https://github.com/guits/ceph into wip-guits-main-2026-02-09-1201

2 weeks agoMerge branch 'node-proxy-various-fixes' of https://github.com/guits/ceph into wip...
Guillaume Abrioux [Mon, 9 Feb 2026 12:01:43 +0000 (12:01 +0000)]
Merge branch 'node-proxy-various-fixes' of https://github.com/guits/ceph into wip-guits-main-2026-02-09-1201

2 weeks agoMerge branch 'ceph-volume-format-device' of https://github.com/ujjawal-ibm/ceph into...
Guillaume Abrioux [Mon, 9 Feb 2026 12:01:42 +0000 (12:01 +0000)]
Merge branch 'ceph-volume-format-device' of https://github.com/ujjawal-ibm/ceph into wip-guits-main-2026-02-09-1201

2 weeks agoMerge pull request #67024 from amathuria/wip-amat-fix-73791
Matan Breizman [Mon, 9 Feb 2026 10:39:04 +0000 (12:39 +0200)]
Merge pull request #67024 from amathuria/wip-amat-fix-73791

crimson/os/seastore: Add progress logging to transaction processing

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 weeks agoMerge pull request #65814 from amathuria/wip-amat-crimson-add-pg-num-testing
Matan Breizman [Mon, 9 Feb 2026 10:37:48 +0000 (12:37 +0200)]
Merge pull request #65814 from amathuria/wip-amat-crimson-add-pg-num-testing

qa/suites/crimson-rados: Add pg splitting tests to crimson thrash tes…

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 weeks agoMerge pull request #66644 from rhcs-dashboard/fix-doc-controller-reponses
Pedro Gonzalez Gomez [Mon, 9 Feb 2026 08:18:35 +0000 (09:18 +0100)]
Merge pull request #66644 from rhcs-dashboard/fix-doc-controller-reponses

mgr/dashboard: Add application/json content type to api doc respones

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 weeks agoMerge pull request #67254 from tchaikov/wip-doc-build-mgr-module-command
Kefu Chai [Mon, 9 Feb 2026 00:00:15 +0000 (08:00 +0800)]
Merge pull request #67254 from tchaikov/wip-doc-build-mgr-module-command

doc/_ext: fix ceph_commands.py for new decorator-based command system

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 weeks agoMerge pull request #67186 from perezjosibm/wip-perezjos-tracker74642
Jose Juan Palacios-Perez [Sun, 8 Feb 2026 20:16:36 +0000 (20:16 +0000)]
Merge pull request #67186 from perezjosibm/wip-perezjos-tracker74642

crimson: fix dump_metrics skipping metrics argument.

2 weeks agoMerge PR #67086 into main
Patrick Donnelly [Sun, 8 Feb 2026 18:28:42 +0000 (13:28 -0500)]
Merge PR #67086 into main

* refs/pull/67086/head:
qa/suites/upgrade: Exclude ceph-osd-classic/crimson when installing LTS releases
qa/suites/fs/upgrade: Exclude ceph-osd-classic/crimson when installing LTS releases

Reviewed-by: Kefu Chai <k.chai@proxmox.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
2 weeks agoMerge PR #67145 into main
Patrick Donnelly [Sun, 8 Feb 2026 18:26:23 +0000 (13:26 -0500)]
Merge PR #67145 into main

* refs/pull/67145/head:
src/script/build-with-container.py: fix a few spelling errors

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
2 weeks agomgr/dashboard: Add application/json content type to api doc respones
Pedro Gonzalez Gomez [Tue, 16 Dec 2025 08:37:27 +0000 (09:37 +0100)]
mgr/dashboard: Add application/json content type to api doc respones

This will fix the sphinx documentation generated and properly display endpoint documentation responses.
Also adds a doc link to the openapi swagger

Fixes: https://tracker.ceph.com/issues/73413
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>
2 weeks agodoc/_ext: fix ceph_commands.py for new decorator-based command system
Kefu Chai [Sun, 8 Feb 2026 12:34:15 +0000 (20:34 +0800)]
doc/_ext: fix ceph_commands.py for new decorator-based command system

After commit 4aa9e246f, mgr modules migrated from using a class-level
COMMANDS list to decorator-based command registration using per-module
CLICommand instances (e.g., @BalancerCLICommand.Read('balancer status')).

This broke the ceph_commands.py Sphinx extension which was hardcoded to
expect m.COMMANDS to be a list, causing documentation builds to fail.

But not all modules are using this per-module CLICommand. Some modules are
fully migrated (balancer, hello, etc.) and use decorators, while others
are partially migrated (volumes, progress, stats, influx, k8sevents,
osd_perf_query, osd_support) - they have CLICommand defined but still
use the old COMMANDS list.

This fix updates _collect_module_commands() to handle three scenarios:

1. Fully migrated modules: Check CLICommand.dump_cmd_list() and use it
   if it returns commands
2. Partially migrated modules: Fall back to the old COMMANDS list if
   dump_cmd_list() returns empty
3. Legacy modules: Use COMMANDS list if CLICommand doesn't exist

This ensures the Sphinx extension works with modules in any migration
state, maintaining backwards compatibility while supporting the new
decorator pattern.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
2 weeks agoMerge pull request #67247 from ivancich/wip-fix-versioning-test-fix
J. Eric Ivancich [Sat, 7 Feb 2026 03:45:25 +0000 (22:45 -0500)]
Merge pull request #67247 from ivancich/wip-fix-versioning-test-fix

rgw/test: fix rgw versioning test fix

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 weeks agoMerge pull request #67243 from anthonyeleven/updateslink
Anthony D'Atri [Sat, 7 Feb 2026 00:44:12 +0000 (19:44 -0500)]
Merge pull request #67243 from anthonyeleven/updateslink

doc/start: Update Slack invite link in doc/start/get-involved.rst

2 weeks agorgw/test: fix rgw versioning test fix
J. Eric Ivancich [Fri, 6 Feb 2026 21:19:27 +0000 (16:19 -0500)]
rgw/test: fix rgw versioning test fix

Removing parentheses that are problematic.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2 weeks agoMerge pull request #66467 from athanatos/wip-sjust-mgr-cli-command-74042
Dan Mick [Fri, 6 Feb 2026 21:23:51 +0000 (13:23 -0800)]
Merge pull request #66467 from athanatos/wip-sjust-mgr-cli-command-74042

pybind/mgr: update modules to use independent CLICommand subtypes with distinct COMMAND attributes

2 weeks agodoc/start: Update Slack invite link in doc/start/get-involved.rst
Anthony D'Atri [Fri, 6 Feb 2026 14:05:07 +0000 (09:05 -0500)]
doc/start: Update Slack invite link in doc/start/get-involved.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 weeks agoceph-volume: skip redundant NVMe mkfs discards
Ujjawal Anand [Fri, 6 Feb 2026 11:26:58 +0000 (16:56 +0530)]
ceph-volume: skip redundant NVMe mkfs discards

- Avoid redundant discard during mkfs when discard is disabled
- Reduces mkfs time on large NVMe devices by skipping long running discard operations

Signed-off-by: Ujjawal Anand <ujjawal.anand@ibm.com>
2 weeks agoMerge pull request #67220 from shraddhaag/wip-shraddhaag-74753
Shraddha Agrawal [Fri, 6 Feb 2026 11:05:36 +0000 (16:35 +0530)]
Merge pull request #67220 from shraddhaag/wip-shraddhaag-74753

doc: add instructions for deploying crimson with cephadm

2 weeks agoMerge pull request #67180 from afreen23/fix-notif-panel
Afreen Misbah [Fri, 6 Feb 2026 08:46:22 +0000 (14:16 +0530)]
Merge pull request #67180 from afreen23/fix-notif-panel

mgr/dashboard: Fix footer of notification panel

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 weeks agodoc: add instructions for deploying crimson with cephadm
Shraddha Agrawal [Wed, 4 Feb 2026 14:03:33 +0000 (19:33 +0530)]
doc: add instructions for deploying crimson with cephadm

This PR adds user facing instructions on how to deploy crimson
OSDs with cephadm. It also updates the build information as per
latest changes.

Fixes: https://tracker.ceph.com/issues/74753
Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
2 weeks agoMerge pull request #67222 from anthonymicmidd/wip-docs-page
Josh Durgin [Thu, 5 Feb 2026 23:40:12 +0000 (15:40 -0800)]
Merge pull request #67222 from anthonymicmidd/wip-docs-page

Update foundation.rst

Reviewed-by: Josh Durgin <jdurgin@ibm.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
2 weeks agoMerge pull request #65623 from JonBailey1993/data_digests_are_inconsistent_fix
SrinivasaBharathKanta [Thu, 5 Feb 2026 22:47:14 +0000 (04:17 +0530)]
Merge pull request #65623 from JonBailey1993/data_digests_are_inconsistent_fix

osd: fix for "data digests are inconsistent"

2 weeks agoMerge pull request #65074 from bill-scales/test_pool_min_size
SrinivasaBharathKanta [Thu, 5 Feb 2026 22:44:43 +0000 (04:14 +0530)]
Merge pull request #65074 from bill-scales/test_pool_min_size

qa: test_pool_min_size should kill osds first then mark them down

2 weeks agoMerge pull request #67190 from ivancich/wip-log-more-versioning-test
J. Eric Ivancich [Thu, 5 Feb 2026 19:36:02 +0000 (14:36 -0500)]
Merge pull request #67190 from ivancich/wip-log-more-versioning-test

rgw/test: add more output in boto3 versioning testing

Reviewed-by: Jane Zhu <jzhu116@bloomberg.net>
2 weeks agoMerge pull request #66616 from rhcs-dashboard/cephfs-mirroring-wizard
Pedro Gonzalez Gomez [Thu, 5 Feb 2026 17:02:45 +0000 (18:02 +0100)]
Merge pull request #66616 from rhcs-dashboard/cephfs-mirroring-wizard

mgr/dashboard: Cephfs Mirroring Wizard

Reviewed-by: Naman Munet <naman.munet@ibm.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>
Reviewed-by: Afreen Misbah <afreen@ibm.com>
2 weeks agodoc: update foundation.rst
Anthony M [Wed, 4 Feb 2026 15:28:26 +0000 (09:28 -0600)]
doc: update foundation.rst

Updating the Ceph Foundation members list and the community manager.

Signed-off-by: Anthony M <anthony@amicmid.com>
2 weeks agonode-proxy: encapsulate send logic in dedicated method
Guillaume Abrioux [Thu, 5 Feb 2026 09:01:06 +0000 (10:01 +0100)]
node-proxy: encapsulate send logic in dedicated method

Move the "send data to mgr when inventory changed" logic from main()
into a dedicated method _try_send_update().
This flattens the reporter loop and keeps main() to a single call under
the lock.

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: log actual data delta in reporter
Guillaume Abrioux [Wed, 4 Feb 2026 14:46:29 +0000 (15:46 +0100)]
node-proxy: log actual data delta in reporter

this adds a _dict_diff() function that computes recursive dict diff
and uses it in reporter to log the delta (truncated at 2048 chars)

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: add periodic heartbeats in main and reporter loops
Guillaume Abrioux [Wed, 4 Feb 2026 14:15:23 +0000 (15:15 +0100)]
node-proxy: add periodic heartbeats in main and reporter loops

This logs an info message every 5 minutes so that logs show the agent
and reporter are still running when nothing else is logged.

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: adjust log levels
Guillaume Abrioux [Wed, 4 Feb 2026 13:16:40 +0000 (14:16 +0100)]
node-proxy: adjust log levels

Let's adjust log levels across the project:

- use warning for bad request in the API,
  when thread is not alive and for retry failure,
- use error for OOB load failure,
- use info for backoff interval,
- use debug in send attempts and for member fetch

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: add unit tests
Guillaume Abrioux [Tue, 3 Feb 2026 15:26:16 +0000 (16:26 +0100)]
node-proxy: add unit tests

This adds some unit tests.

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: add tox config for mypy, flake8, isort, black
Guillaume Abrioux [Tue, 3 Feb 2026 13:47:54 +0000 (14:47 +0100)]
node-proxy: add tox config for mypy, flake8, isort, black

this adds tox.ini with environments to run mypy, flake8, isort, and
black on the ceph_node_proxy code.

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: black and isort formatting pass
Guillaume Abrioux [Tue, 3 Feb 2026 13:45:30 +0000 (14:45 +0100)]
node-proxy: black and isort formatting pass

Format the code with black and isort.

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: fix mypy errors
Guillaume Abrioux [Tue, 3 Feb 2026 13:41:13 +0000 (14:41 +0100)]
node-proxy: fix mypy errors

this commit fixes mypy errors by adding explicit types for get_path
and get_* getters methods, extending SystemBackend with
start/shutdown and declaring _ca_temp_file on NodeProxyManager

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: handle nested Redfish paths for components
Guillaume Abrioux [Tue, 3 Feb 2026 12:22:03 +0000 (13:22 +0100)]
node-proxy: handle nested Redfish paths for components

Add a _resolve_path() helper to support components whose data
lives under nested Redfish paths when assembling component data.

For instance, power is exposed at 'PowerSubsystem/PowerSupplies'

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: split out config, bootstrap and redfish logic
Guillaume Abrioux [Fri, 30 Jan 2026 15:02:28 +0000 (16:02 +0100)]
node-proxy: split out config, bootstrap and redfish logic

refactor config, bootstrap, redfish layer, and monitoring:

this:
- adds a config module (CephadmCofnig, load_cephadm_config and
get_node_proxy_config) and protocols for api/reporter.
- extracts redfish logic to redfish.py
- adds a vendor registry with entrypoints.
- simplifies main() and NodeProxyManager().

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: refactor config loading
Guillaume Abrioux [Fri, 30 Jan 2026 14:33:05 +0000 (15:33 +0100)]
node-proxy: refactor config loading

This commit renames CONFIG to DEFAULTS and add load_config() with
deep merge, refactor Config to use path + defaults and makes
node-proxy config path configurable via bootstrap JSON or env.

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: add 'vendor based' redfish system selection
Guillaume Abrioux [Fri, 30 Jan 2026 14:12:14 +0000 (15:12 +0100)]
node-proxy: add 'vendor based' redfish system selection

This commit adds REDFISH_SYSTEM_CLASSES registry (generic, dell, ...),
this way the user can choose a system class.

The default value is BaseRedfishSystem (generic) when vendor isn't specified.

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: introduce component spec registry and overrides for updates
Guillaume Abrioux [Thu, 29 Jan 2026 12:27:22 +0000 (13:27 +0100)]
node-proxy: introduce component spec registry and overrides for updates

This change introduces a single COMPONENT_SPECS dict and get_update_spec(component)
as the single source of truth for RedFish component update config (collection, path,
fields, attribute). To support hardware that uses different paths or attributes,
get_component_spec_overrides() allows overriding only those fields (via dataclasses.replace())
without duplicating the rest of the spec.
All _update_network, _update_power, etc. now call _run_update(component).

For instance, AtollonSystem uses this to set the power path to 'PowerSubsystem'.

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agomgr/cephadm: safe status/health access in node-proxy agent and inventory
Guillaume Abrioux [Thu, 29 Jan 2026 12:14:40 +0000 (13:14 +0100)]
mgr/cephadm: safe status/health access in node-proxy agent and inventory

This adds helpers in NodeProxyEndpoint and NodeProxyCache to safely
read status.health and status.state.

In NodeProxyEndpoint, methods _get_health_value() and _get_state_value()
are used in get_nok_members() to avoid KeyError on malformed data.

In NodeProxyCache, _get_health_value(), _has_health_value(),
_is_error_status(), and _is_unknown_status() are used in fullreport()
and when filtering 'non ok' members instead of accessing
status['status']['health'] inline.

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: narrow build_data exception handling and re-raise
Guillaume Abrioux [Thu, 29 Jan 2026 10:38:45 +0000 (11:38 +0100)]
node-proxy: narrow build_data exception handling and re-raise

With this commit, it catches only KeyError, TypeError, and
AttributeError in build_data() instead of Exception, and
re-raise after logging so callers get the actual error.

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: refactor Endpoint/EndpointMgr and fix chassis paths
Guillaume Abrioux [Thu, 29 Jan 2026 09:48:45 +0000 (10:48 +0100)]
node-proxy: refactor Endpoint/EndpointMgr and fix chassis paths

This commit refactors EndpointMgr and Endpoint to use explicit dicts
instead of dynamic attributes. It also fixes member path filtering
so chassis endpoints use Chassis paths.

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: use safe field access in storage update
Guillaume Abrioux [Wed, 28 Jan 2026 12:10:26 +0000 (13:10 +0100)]
node-proxy: use safe field access in storage update

Replace direct dictionary access with .get() method when processing
storage fields to handle missing optional fields gracefully.

(extra change: extract get_members_names() call for better readability.)

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agonode-proxy: reduce log verbosity for missing optional fields
Guillaume Abrioux [Wed, 28 Jan 2026 12:05:04 +0000 (13:05 +0100)]
node-proxy: reduce log verbosity for missing optional fields

Change missing field logging from warning to debug level in
RedfishDellSystem, as missing optional fields can be expected behavior
and and doesn't require warning level logging.

Fixes: https://tracker.ceph.com/issues/74749
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agoMerge pull request #66393 from ljflores/wip-update-cluster-log-warnings
Ilya Dryomov [Thu, 5 Feb 2026 16:17:06 +0000 (17:17 +0100)]
Merge pull request #66393 from ljflores/wip-update-cluster-log-warnings

qa: update ignorelists for expected cluster log warnings

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 weeks agoceph-volume: include LVM mapper devices in get_devices()
Guillaume Abrioux [Thu, 5 Feb 2026 15:34:26 +0000 (15:34 +0000)]
ceph-volume: include LVM mapper devices in get_devices()

`ceph-volume inventory --list-all` doesn't include LVs devices:

```
NAME          MAJ:MIN RM  SIZE RO TYPE MOUNTPOINTS
vda           253:0    0   61G  0 disk
└─vda1        253:1    0   61G  0 part /etc/ceph/ceph.keyring
                                       /etc/ceph/ceph.conf
                                       /run/podman-init
                                       /rootfs/var/lib/containers/storage/overlay
                                       /rootfs
vdb           253:16   0  200G  0 disk
vdc           253:32   0  200G  0 disk
vdd           253:48   0  200G  0 disk
vde           253:64   0  200G  0 disk
vdf           253:80   0  200G  0 disk
vdg           253:96   0  200G  0 disk
vdh           253:112  0  200G  0 disk
vdi           253:128  0  200G  0 disk
vdj           253:144  0  200G  0 disk
vdk           253:160  0  200G  0 disk
└─vg_test-lv1 252:0    0  200G  0 lvm

Device Path               Size         Device nodes    rotates available
Model name
/dev/vdb                  200.00 GB    vdb             True    True
/dev/vdc                  200.00 GB    vdc             True    True
/dev/vdd                  200.00 GB    vdd             True    True
/dev/vde                  200.00 GB    vde             True    True
/dev/vdf                  200.00 GB    vdf             True    True
/dev/vdg                  200.00 GB    vdg             True    True
/dev/vdh                  200.00 GB    vdh             True    True
/dev/vdi                  200.00 GB    vdi             True    True
/dev/vdj                  200.00 GB    vdj             True    True
/dev/vda                  61.00 GB     vda             True    False
/dev/vda1                 61.00 GB     vda             False   False
/dev/vdk                  200.00 GB    vdk             True    False
```

This commit removes the UdevData(diskname).is_lvm check so LVs devices
are no longer skipped when listing devices.

```

Device Path               Size         Device nodes    rotates available
Model name
/dev/vdb                  200.00 GB    vdb             True    True
/dev/vdc                  200.00 GB    vdc             True    True
/dev/vdd                  200.00 GB    vdd             True    True
/dev/vde                  200.00 GB    vde             True    True
/dev/vdf                  200.00 GB    vdf             True    True
/dev/vdg                  200.00 GB    vdg             True    True
/dev/vdh                  200.00 GB    vdh             True    True
/dev/vdi                  200.00 GB    vdi             True    True
/dev/vdj                  200.00 GB    vdj             True    True
/dev/vda                  61.00 GB     vda             True    False
/dev/vda1                 61.00 GB     vda             False   False
/dev/vdk                  200.00 GB    vdk             True    False
/dev/vg_test/lv1          200.00 GB    vdk             True    False
```

Fixes: https://tracker.ceph.com/issues/74775
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 weeks agoMerge pull request #66874 from tchaikov/wip-rgw-client-fix-leak
J. Eric Ivancich [Thu, 5 Feb 2026 15:39:16 +0000 (10:39 -0500)]
Merge pull request #66874 from tchaikov/wip-rgw-client-fix-leak

rgw: fix memory leak in RGWHTTPManager thread cleanup

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 weeks agoMerge pull request #67047 from guits/2430588
Guillaume Abrioux [Thu, 5 Feb 2026 14:04:41 +0000 (15:04 +0100)]
Merge pull request #67047 from guits/2430588

ceph-volume: avoid Device() instantiation in lvm OSD filtering

3 weeks agomgr/dashboard: Cephfs Mirroring Wizard
Pedro Gonzalez Gomez [Thu, 20 Nov 2025 14:09:03 +0000 (15:09 +0100)]
mgr/dashboard: Cephfs Mirroring Wizard
Fixes: https://tracker.ceph.com/issues/74200
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>
3 weeks agoMerge pull request #67206 from gbregman/main
Gil Bregman [Thu, 5 Feb 2026 08:44:24 +0000 (10:44 +0200)]
Merge pull request #67206 from gbregman/main

mgr/cephadm: Add IO statistics enable field to the cephadm NVMEoF spe…

3 weeks agoMerge branch 'ceph:main' into main
Gil Bregman [Thu, 5 Feb 2026 06:32:23 +0000 (08:32 +0200)]
Merge branch 'ceph:main' into main

3 weeks agosrc/script/build-with-container.py: fix a few spelling errors
Dan Mick [Sat, 31 Jan 2026 03:42:19 +0000 (19:42 -0800)]
src/script/build-with-container.py: fix a few spelling errors

I finally snapped.

Signed-off-by: Dan Mick <dan.mick@redhat.com>
3 weeks agorgw: fix memory leak in RGWHTTPManager thread cleanup
Kefu Chai [Fri, 9 Jan 2026 23:53:29 +0000 (07:53 +0800)]
rgw: fix memory leak in RGWHTTPManager thread cleanup

Fix memory leak detected by AddressSanitizer in unittest_http_manager.
The test was failing with ASan enabled due to rgw_http_req_data objects
not being properly cleaned up when the HTTP manager thread exits.

ASan reported the following leaks:

  Direct leak of 17152 byte(s) in 32 object(s) allocated from:
    #0 operator new(unsigned long)
    #1 RGWHTTPManager::add_request(RGWHTTPClient*)
       /ceph/src/rgw/rgw_http_client.cc:946:33
    #2 HTTPManager_SignalThread_Test::TestBody()
       /ceph/src/test/rgw/test_http_manager.cc:132:10

  Indirect leak of 768 byte(s) in 32 object(s) allocated from:
    #0 operator new(unsigned long)
    #1 rgw_http_req_data::rgw_http_req_data()
       /ceph/src/rgw/rgw_http_client.cc:52:22
    #2 RGWHTTPManager::add_request(RGWHTTPClient*)
       /ceph/src/rgw/rgw_http_client.cc:946:37

  SUMMARY: AddressSanitizer: 17920 byte(s) leaked in 64 allocation(s).

Root cause: The rgw_http_req_data class uses reference counting
(inherits from RefCountedObject). When a request is unregistered,
unregister_request() calls get() to increment the refcount, expecting
a corresponding put() to be called later.

In manage_pending_requests(), unregistered requests are properly
handled with both _unlink_request() and put(). However, in the thread
cleanup code (reqs_thread_entry exit path), only _unlink_request() was
called without the matching put(), causing a reference count leak.

The fix adds the missing put() call in the thread cleanup code to match
the reference counting pattern used in manage_pending_requests().

Test results:
- Before: 17,920 bytes leaked in 64 allocations
- After: 0 leaks, unittest_http_manager passes with ASan

Fixes: https://tracker.ceph.com/issues/74762
Signed-off-by: Kefu Chai <k.chai@proxmox.com>
3 weeks agoMerge pull request #67201 from rhcs-dashboard/import-error
Nizamudeen A [Thu, 5 Feb 2026 03:34:12 +0000 (09:04 +0530)]
Merge pull request #67201 from rhcs-dashboard/import-error

qa/tasks: fix import error

3 weeks agoqa/tasks: fix import error
Nizamudeen A [Wed, 4 Feb 2026 06:39:46 +0000 (12:09 +0530)]
qa/tasks: fix import error

```
2026-02-04 06:04:16,385.385 INFO:__main__:    from .helper import DashboardTestCase, MgrModuleTestCase
2026-02-04 06:04:16,385.385 INFO:__main__:ImportError: cannot import name 'MgrModuleTestCase' from 'tasks.mgr.dashboard.helper' (/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/helper.py)
```

Signed-off-by: Nizamudeen A <nia@redhat.com>
3 weeks agoMerge PR #67094 into main
Patrick Donnelly [Wed, 4 Feb 2026 21:33:52 +0000 (16:33 -0500)]
Merge PR #67094 into main

* refs/pull/67094/head:
script/ptl-tool: supprt --debug-build to add debug flavor
script/ptl-tool: remove debug suffix on branch name

Reviewed-by: John Mulligan <jmulligan@redhat.com>
3 weeks agorgw/test: add more output in boto3 versioning testing
J. Eric Ivancich [Mon, 2 Feb 2026 21:37:22 +0000 (16:37 -0500)]
rgw/test: add more output in boto3 versioning testing

Saw a spurious error in this test and figured it'd be helpful if more
information was logged in case another spurious error occcurs.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
3 weeks agoMerge pull request #66886 from ifed01/wip-ifed-revert-bitmap-in-vstart
Igor Fedotov [Wed, 4 Feb 2026 16:33:44 +0000 (19:33 +0300)]
Merge pull request #66886 from ifed01/wip-ifed-revert-bitmap-in-vstart

vstart.sh: revert unintended allocator type change

Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
3 weeks agoMerge pull request #67203 from VallariAg/fix-corrupted-issue
Vallari Agrawal [Wed, 4 Feb 2026 15:47:25 +0000 (21:17 +0530)]
Merge pull request #67203 from VallariAg/fix-corrupted-issue

qa/workunits/nvmeof/basic_tests: use nvme-cli 2.13

3 weeks agoMerge branch 'ceph:main' into main
Gil Bregman [Wed, 4 Feb 2026 14:23:04 +0000 (16:23 +0200)]
Merge branch 'ceph:main' into main

3 weeks agoMerge pull request #67181 from shraddhaag/wip-shraddhaag-74178
Shraddha Agrawal [Wed, 4 Feb 2026 14:22:35 +0000 (19:52 +0530)]
Merge pull request #67181 from shraddhaag/wip-shraddhaag-74178

qa/standalone/availability.sh: retry after feature is turned on

3 weeks agocrimson/os/seastore: Add progress logging to transaction processing
Aishwarya Mathuria [Wed, 21 Jan 2026 11:31:20 +0000 (11:31 +0000)]
crimson/os/seastore: Add progress logging to transaction processing

Log "op X of Y" during the transaction iteration in do_transaction_no_callbacks
to improve observability during transactions.

Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
3 weeks agosrc/crimson/osd/pg: Add DEBUG logging to do_delete_work
Aishwarya Mathuria [Wed, 21 Jan 2026 11:00:17 +0000 (11:00 +0000)]
src/crimson/osd/pg: Add DEBUG logging to do_delete_work

Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
3 weeks agoMerge pull request #66811 from shraddhaag/wip-shraddhaag-cephadm-add-osd-type
Shraddha Agrawal [Wed, 4 Feb 2026 11:21:46 +0000 (16:51 +0530)]
Merge pull request #66811 from shraddhaag/wip-shraddhaag-cephadm-add-osd-type

cephadm, ceph-volume: deploy crimson OSDs using cephadm

3 weeks agoMerge pull request #66162 from aainscow/no_obj_ver
Alex Ainscow [Wed, 4 Feb 2026 10:06:56 +0000 (10:06 +0000)]
Merge pull request #66162 from aainscow/no_obj_ver

rados: Add API to disable version querying with reads in librados

Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 weeks agomgr/cephadm: Add IO statistics enable field to the cephadm NVMEoF spec file.
Gil Bregman [Wed, 4 Feb 2026 09:14:58 +0000 (11:14 +0200)]
mgr/cephadm: Add IO statistics enable field to the cephadm NVMEoF spec file.

Fixes: https://tracker.ceph.com/issues/74750
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
3 weeks agoMerge pull request #67175 from bluikko/wip-doc-undo-66059-pip-pin
Kefu Chai [Wed, 4 Feb 2026 07:59:45 +0000 (15:59 +0800)]
Merge pull request #67175 from bluikko/wip-doc-undo-66059-pip-pin

doc: unpin pip in admin/doc-read-the-docs.txt

Reviewed-by: Kefu Chai <k.chai@proxmox.com>
3 weeks agoqa/workunits/nvmeof/basic_tests: use nvme-cli 2.13
Vallari Agrawal [Tue, 3 Feb 2026 15:02:17 +0000 (20:32 +0530)]
qa/workunits/nvmeof/basic_tests: use nvme-cli 2.13

Install nvme version 2.13 (instead of latest nvme
ver 2.16). This is because nvme-cli 2.16 has a bug
in 'nvme list-subsys' command on centos9.

Fixes: https://tracker.ceph.com/issues/74615
Co-authored-by: barakda <barak.davidov@gmail.com>
Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
3 weeks agoMerge pull request #66488 from xxhdx1985126/wip-seastore-background-trans-cc-opt2
Xuehan Xu [Wed, 4 Feb 2026 04:58:59 +0000 (12:58 +0800)]
Merge pull request #66488 from xxhdx1985126/wip-seastore-background-trans-cc-opt2

crimson/os/seastore/cache: TRIM_DIRTY/CLEANER_* transactions won't invalidate other transactions anymore

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
3 weeks agoMerge pull request #67177 from rhcs-dashboard/fix-feedback-module-failure
David Galloway [Tue, 3 Feb 2026 21:22:39 +0000 (16:22 -0500)]
Merge pull request #67177 from rhcs-dashboard/fix-feedback-module-failure

qa/tests: wait for module to be available for connection

3 weeks agoMerge pull request #66367 from mheler/lc-tag-scan-reduction
J. Eric Ivancich [Tue, 3 Feb 2026 17:34:03 +0000 (12:34 -0500)]
Merge pull request #66367 from mheler/lc-tag-scan-reduction

rgw/lc: optimize lifecycle processing for multiple rules

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
3 weeks agoMerge pull request #66514 from BBoozmen/wip-oozmen-62063
J. Eric Ivancich [Tue, 3 Feb 2026 17:30:28 +0000 (12:30 -0500)]
Merge pull request #66514 from BBoozmen/wip-oozmen-62063

RGW: remove custom copy ctor for RGWObjectCtx and enforce no copy/move

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 weeks agoMerge pull request #66369 from BBoozmen/wip-oozmen-66100
J. Eric Ivancich [Tue, 3 Feb 2026 17:29:27 +0000 (12:29 -0500)]
Merge pull request #66369 from BBoozmen/wip-oozmen-66100

RGW: prevent shutdown hang by reconciling race between async processor and multisite sync threads

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
3 weeks agomgr/dashboard: Fix footer of notification panel
Afreen Misbah [Tue, 3 Feb 2026 11:59:45 +0000 (17:29 +0530)]
mgr/dashboard: Fix footer of notification panel

Fixes https://tracker.ceph.com/issues/74735

Signed-off-by: Afreen Misbah <afreen@ibm.com>
3 weeks agoscript/ptl-tool: supprt --debug-build to add debug flavor
Patrick Donnelly [Tue, 3 Feb 2026 15:55:55 +0000 (10:55 -0500)]
script/ptl-tool: supprt --debug-build to add debug flavor

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 weeks agoscript/ptl-tool: remove debug suffix on branch name
Patrick Donnelly [Tue, 27 Jan 2026 16:09:53 +0000 (11:09 -0500)]
script/ptl-tool: remove debug suffix on branch name

A git trailer is now the preferred way to enable this.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
3 weeks agoMerge PR #66666 into main
Patrick Donnelly [Tue, 3 Feb 2026 15:45:20 +0000 (10:45 -0500)]
Merge PR #66666 into main

* refs/pull/66666/head:
ceph: fix a small error in the ceph command help

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
3 weeks agoMerge pull request #67106 from afreen23/subsystem-step-1
Afreen Misbah [Tue, 3 Feb 2026 15:03:53 +0000 (20:33 +0530)]
Merge pull request #67106 from afreen23/subsystem-step-1

mgr/dashboard: Add step 1 for subsystem form

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
3 weeks agoMerge pull request #66512 from aclamk/aclamk-fix-bs-wal-envelope-mode-size
Adam Kupczyk [Tue, 3 Feb 2026 14:46:21 +0000 (15:46 +0100)]
Merge pull request #66512 from aclamk/aclamk-fix-bs-wal-envelope-mode-size

os/bluestore/bluefs: Fix stat() for WAL envelope mode

3 weeks agocrimson: fix dump_metrics skipping metrics argument. Add minimal qa test for the...
Jose J Palacios-Perez [Tue, 3 Feb 2026 14:19:27 +0000 (14:19 +0000)]
crimson: fix dump_metrics skipping metrics argument. Add minimal qa test for the fix.

Signed-off-by: Jose J Palacios-Perez <perezjos@uk.ibm.com>
3 weeks agoqa/standalone/availability.sh: retry after feature is turned on
Shraddha Agrawal [Tue, 3 Feb 2026 12:26:18 +0000 (17:56 +0530)]
qa/standalone/availability.sh: retry after feature is turned on

This commit adds a retry to ensure we wait for availability score
to be reported after it is turned on and do not fail early.

Fixes: https://tracker.ceph.com/issues/74178
Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
3 weeks agoMerge pull request #66962 from rhcs-dashboard/74429-add-cert-mgmt-tabs
Pedro Gonzalez Gomez [Tue, 3 Feb 2026 09:40:25 +0000 (10:40 +0100)]
Merge pull request #66962 from rhcs-dashboard/74429-add-cert-mgmt-tabs

mgr/dashboard : Add Certificate tab under service details

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>
3 weeks agoqa/suites/crimson-rados: disable PG splitting in radosbench workloads
Aishwarya Mathuria [Fri, 30 Jan 2026 07:57:26 +0000 (07:57 +0000)]
qa/suites/crimson-rados: disable PG splitting in radosbench workloads

Disable 'crimson_allow_pg_split' in radosbench and high-concurrency
workloads to avoid hitting known bugs in Seastore.

Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
3 weeks agoMerge pull request #66798 from Matan-B/wip-matanb-seastore-docs
Matan Breizman [Tue, 3 Feb 2026 08:06:17 +0000 (10:06 +0200)]
Merge pull request #66798 from Matan-B/wip-matanb-seastore-docs

doc/dev/crimson: Update Seastore docs

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
3 weeks agoqa/tests: wait for module to be available for connection
Nizamudeen A [Tue, 3 Feb 2026 08:03:08 +0000 (13:33 +0530)]
qa/tests: wait for module to be available for connection

Signed-off-by: Nizamudeen A <nia@redhat.com>
3 weeks agodoc: unpin pip in admin/doc-read-the-docs.txt
Ville Ojamo [Tue, 3 Feb 2026 06:28:12 +0000 (13:28 +0700)]
doc: unpin pip in admin/doc-read-the-docs.txt

7dd00ca introduced a proper fix for pip 25.3/PEP517 compatibility by
adding pyproject.toml files and the workaround in a65c46c is no longer
necessary. RTD builds with pip 25.3 and later work with the proper fix.

Remove the pinned pip in admin/doc-read-the-docs.txt and let RTD use the
default PIP version.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
3 weeks agoMerge pull request #66511 from bill-scales/issue74048_deletepg
Radoslaw Zarzynski [Mon, 2 Feb 2026 19:29:28 +0000 (20:29 +0100)]
Merge pull request #66511 from bill-scales/issue74048_deletepg

osd: Deleting PG should discard pwlc

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 weeks agomgr/dashboard : Add Certificate tab under service details
Abhishek Desai [Mon, 19 Jan 2026 08:47:54 +0000 (14:17 +0530)]
mgr/dashboard : Add Certificate tab under service details
fixes : https://tracker.ceph.com/issues/74429
Signed-off-by: Abhishek Desai <abhishek.desai1@ibm.com>
3 weeks agoMerge pull request #66698 from aainscow/partial_write_with_clone_fix
Alex Ainscow [Mon, 2 Feb 2026 14:13:21 +0000 (14:13 +0000)]
Merge pull request #66698 from aainscow/partial_write_with_clone_fix

osd: Do not remove objects with divergent logs if only partial writes.

Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 weeks agoMerge pull request #67157 from xxhdx1985126/wip-seastore-fix-possible-chksum-error
Matan Breizman [Mon, 2 Feb 2026 13:32:41 +0000 (15:32 +0200)]
Merge pull request #67157 from xxhdx1985126/wip-seastore-fix-possible-chksum-error

crimson/os/seastore/cache: fix possible extent chksum error

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
3 weeks agoMerge pull request #65157 from liu-chunmei/omap_rm_key
Matan Breizman [Mon, 2 Feb 2026 12:38:49 +0000 (14:38 +0200)]
Merge pull request #65157 from liu-chunmei/omap_rm_key

crimson/os/seastore: optimize omap_rm_key_range

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
3 weeks agoMerge pull request #67138 from idryomov/wip-74672
Ilya Dryomov [Mon, 2 Feb 2026 12:34:27 +0000 (13:34 +0100)]
Merge pull request #67138 from idryomov/wip-74672

qa/valgrind.supp: make gcm_cipher_internal suppression more resilient

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
3 weeks agoceph-volume: support crimson osd binary wip-shraddhaag-cephadm-add-osd-type
Shraddha Agrawal [Thu, 29 Jan 2026 04:28:00 +0000 (09:58 +0530)]
ceph-volume: support crimson osd binary

Prior to this commit, ceph-volume was using hardcoded OSD binary
to issue commands (eg - to perform mkfs, etc). This commit enables
ceph-volume to start supporting crimson OSDs.

A new argument, --osd-type is introduced with the default value
classic. When this parameter is set to 'crimson', ceph-osd-crimson
binary will be used to execute OSD commands.

Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
3 weeks agocephadm: add osd_type to orchestrator
Shraddha Agrawal [Tue, 6 Jan 2026 12:51:01 +0000 (18:21 +0530)]
cephadm: add osd_type to orchestrator

This commit enables us to deploy both classic and crimson
type OSDs using cephadm. To enable the same, a new feature,
osd_type is added to DriverGroupSpec. The default value for
the same is classic, but can also be set to crimson.
When this value is read by cephadm, the entrypoint is
changed from /usr/bin/ceph-osd to /usr/bin/ceph-osd-crimson.

Fixes: https://tracker.ceph.com/issues/74081
Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
3 weeks agoMerge pull request #67133 from rsommer/rsommer-fix-missing-smb-module
Kefu Chai [Mon, 2 Feb 2026 11:12:58 +0000 (19:12 +0800)]
Merge pull request #67133 from rsommer/rsommer-fix-missing-smb-module

debian: package mgr/smb in ceph-mgr-modules-core

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Kefu Chai <k.chai@proxmox.com>
3 weeks agomgr/dashboard: Add step 1 for subsystem form
Afreen Misbah [Wed, 28 Jan 2026 13:18:52 +0000 (18:48 +0530)]
mgr/dashboard: Add step 1 for subsystem form

Fixes https://tracker.ceph.com/issues/74093
Fixes https://tracker.ceph.com/issues/74094

- updates tearsheet component css to match with carbon component
- adds laoding state to submit button
- adds support for step validation when angualr component are use for steps rather than plain html templates
- adds step one of nvmeof

Signed-off-by: Afreen Misbah <afreen@ibm.com>
3 weeks agoMerge pull request #66817 from aainscow/bad_erase_after_ro_offset_fix
Alex Ainscow [Mon, 2 Feb 2026 10:14:24 +0000 (10:14 +0000)]
Merge pull request #66817 from aainscow/bad_erase_after_ro_offset_fix

osd/ECUtil: Fix erase_after_ro_offset length calculation and add tests

Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 weeks agoMerge pull request #67090 from shraddhaag/wip-shraddhaag-add-more-osd-bootstrap-logs
Shraddha Agrawal [Mon, 2 Feb 2026 10:05:16 +0000 (15:35 +0530)]
Merge pull request #67090 from shraddhaag/wip-shraddhaag-add-more-osd-bootstrap-logs

crimson/osd: add verbose DEBUG logs for OSD startup

3 weeks agocrimson/os/seastore/cache: fix possible extent chksum error wip-seastore-fix-possible-chksum-error
Xuehan Xu [Mon, 2 Feb 2026 05:52:47 +0000 (13:52 +0800)]
crimson/os/seastore/cache: fix possible extent chksum error

See: https://github.com/ceph/ceph/pull/66506#issuecomment-3821417465

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>