rgw/cloud-transition: increase time out for test cases

Fixes: https://tracker.ceph.com/issues/69411
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>

Merge pull request #634 from yuvalif/wip-bucket-logging-policy

rgw/logging: bucket logging policy

Merge pull request #626 from linuxbox2/wip-crc64nvme

Wip crc64nvme

rgw/logging: test bucket logging with accounts

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

rgw/logging: fix tenant test

tests were failing in teuthology since the tenanted user name
already have the tenant in its name

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

enhance additional checksum tests

includes tests for CRC64NVME, tests for selecting
COMPOSITE and FULL_OBJECT checksums

a decomposed matrix of tests for all checksum types

also removes the mixed checksum upload case that no longer
works in recent boto3

cleanups, add sha1

checksum validation failure (mismatch) returns BadDigest

multipart checksum matrix helper now validates checksum and checksum type
for all operations which can return them (complete-multipart, head-object,
and get-object-attributes)

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

add minimal put-object for CRC64NVME

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #635 from cbodley/wip-69527

test put_bucket_acl with group uri

rgw/logging: add bucket logging permission tests

this is to cover new functionality added in:
https://github.com/ceph/ceph/pull/62284

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

rgw/logging: add more bucket logging error cases

this is to cover these checks:
* source bucket ownership
* "requester pays" on log bucket

that were added in: https://github.com/ceph/ceph/pull/62284

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

rgw/logging: add basic policy to target bucket

this commit needed to be able to run bucket logging regression
against: https://github.com/ceph/ceph/pull/62284
since target bucket requires policy for bucket logging to work
this only covers the positive cases from bucket logging policy
perspective

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

test put_bucket_acl with group uri

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw/logging: add missing marker to remove warnings

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

Merge pull request #614 from jzhu116-bloomberg/wip-63799

add test case for stacked delete-markers

Merge pull request #625 from cbodley/wip-70191

s3: test bucket policy evaluation for CreateMultipartUpload

Merge pull request #567 from clwluvw/policy-remove-self-access

BucketPolicy: add tests for ConfirmRemoveSelfBucketAccess header

BucketPolicy: add tests for ConfirmRemoveSelfBucketAccess header

Refrence: https://github.com/ceph/ceph/pull/57629
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

Merge pull request #627 from soumyakoduri/wip-skoduri-restore

cloud-restore:  Add testcase for restoring non-current versioned objects

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>

cloud-restore: testcase for non-current versioned object

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #599 from shreyanshjain7174/restore-s3tests

rgw/restore: s3tests to test restore object functionality

Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #622 from cbodley/wip-70013

s3: test that object lock can be enabled on an existing bucket

Merge pull request #621 from cbodley/wip-69936

s3: reenable tests with range requests and checksums

mark test_versioning_stack_delete_merkers fails_on_dbstore

Signed-off-by: Jane Zhu <jzhu116@bloomberg.net>

s3: test bucket policy evaluation for CreateMultipartUpload

test case for https://tracker.ceph.com/issues/70191

Signed-off-by: Casey Bodley <cbodley@redhat.com>

running cloud restore tests seperately

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>

s3: test that object lock can be enabled on an existing bucket

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw/restore: s3tests to test restore object functionality.

This tests are added to tests temporary restore, permanent restore and
read through resotre object functionality, this includes zonegroup
parameters and checks.

Signed-off-by: shreyanshjain7174 <ssanchet@redhat.com>
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>

s3: reenable tests with range requests and checksums

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #619 from cbodley/wip-unpin-botocore

unpin botocore, disable failing sigv2/checksum tests

Merge pull request #620 from ArbitCode/wip-rgw-raja-remove-clientid-oidc-provider

rgw/iam: add RemoveClientIDFromOpenIDConnectProvider

rgw/iam: add RemoveClientIDFromOpenIDConnectProvider

Signed-off-by: Raja Sharma <raja@ibm.com>

sns: clear region_name for s3 clients

work around sns failures due to default region_name='':

> ERROR s3tests_boto3/functional/test_sns.py::test_account_topic_publish - botocore.exceptions.EndpointResolutionError: Invalid region: region was not a valid DNS name.
> ERROR s3tests_boto3/functional/test_sns.py::test_cross_account_topic_publish - botocore.exceptions.EndpointResolutionError: Invalid region: region was not a valid DNS name.

Signed-off-by: Casey Bodley <cbodley@redhat.com>

s3: disable checksum calculation for test_object_create_bad_contentlength_negative

if tls is enabled, boto will switch to STREAMING-UNSIGNED-PAYLOAD-TRAILER
and omit the provided content-length header. this leads to test failure:

> ________________ test_object_create_bad_contentlength_negative _________________
>       e = assert_raises(ClientError, client.put_object, Bucket=bucket_name, Key=key_name, ContentLength=-1)
> AssertionError: ClientError not raised

Signed-off-by: Casey Bodley <cbodley@redhat.com>

iam: remove invalid Bucket param from list_buckets()

> botocore.exceptions.ParamValidationError: Parameter validation failed:
> Unknown parameter in input: "Bucket", must be one of: MaxBuckets, ContinuationToken, Prefix, BucketRegion

Signed-off-by: Casey Bodley <cbodley@redhat.com>

s3: disable multipart/ranged tests with checksum failures

boto update exposed some bugs in our checksum feature around multipart
copy and ranged requests. disabling them with fails_on_rgw until
https://tracker.ceph.com/issues/69936 is resolved

Signed-off-by: Casey Bodley <cbodley@redhat.com>

s3: disable request_checksum_calculation for test_multipart_checksum_upload_fallback

the test sends create_multipart_upload() with a requested checksum
algorithm, and upload_part() requests without. newer boto automatically
adds `x-amz-sdk-checksum-algorithm: CRC32` when nothing is specified,
so we have to explicitly disable that behavior via botocore config

Signed-off-by: Casey Bodley <cbodley@redhat.com>

s3: clean up use of tenanted bucket names

the botocore.handlers.validate_bucket_name validation is enabled by
default, but we can disable it with unregister(). this avoids having to
mess with the signature or url

Signed-off-by: Casey Bodley <cbodley@redhat.com>

s3: sse-kms policy tests use v4 client

Signed-off-by: Casey Bodley <cbodley@redhat.com>

s3: mark sigv2 tests with fails_on_rgw

Signed-off-by: Casey Bodley <cbodley@redhat.com>

requirements: unpin botocore version

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #616 from ceph/wip-alimasa-sns-cross-tenant

RGW | BucketNotification: fix test to expect authorization failure

Reviewed-by: yuvalif<ylifshit@redhat.com>

rgw|BN: fix test to expect authorization failure

Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>

Merge pull request #611 from ArbitCode/wip-raja-fix-multipart-upload-cant-get-obj-tag

RGW:test-case to fix obj by multipart upload cant get tag

Merge branch 'ceph:master' into wip-raja-fix-multipart-upload-cant-get-obj-tag

Merge pull request #610 from ArbitCode/wip-raja-rgw-test-support-64526

rgw test-case to support x-expected-bucket-owner

add test case for stacked delete-markers

Signed-off-by: Jane Zhu <jzhu116@bloomberg.net>

test-case to fix obj by multipart upload cant get tag

Signed-off-by: Raja Sharma <raja@ibm.com>

Merge pull request #607 from yuvalif/wip-yuval-bucket-logging-tenant

rgw/logging: increase test coverage

Reviewed-By: Ali Masarwe <ali.masarwa@ibm.com>

rgw test-case to support x-expected-bucket-owner
If the bucket is owned by a different account, the request fails with the HTTP status code 403 Forbidden (access denied).
PR: ceph/ceph#61215
Fixes: https://tracker.ceph.com/issues/64526
Signed-off-by: Raja Sharma <raja@ibm.com>

rgw/logging: fix typo in readme

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

rgw/logging: add cleanup tests

* use flushing api instead of sleep when possible
* test flushing concurrency

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

rgw/logging: test log bucket encryption error

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

rgw/logging: test source and log have different names

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

rgw/logging: test tenant support

when source and log buckets are on a specific tenant, or
on different tenants

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

Merge pull request #571 from linuxbox2/wip-get-objattrs

test get_object_attributes

Merge pull request #549 from jzhu116-bloomberg/wip-63995

add test case for delete-marker expiration with 'Days' tag

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

mark attribute tests as failing on dbstore (for now)

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

more tests for GetObjectAttributes

* multipart upload without checksums
* multipart upload with a single part
* pagination of multipart parts
* non-multipart upload with/without checksum
* versioned object, current and non-current
* sse-c encrypted object

Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

multipart fallback to create-multipart checksum algorithm

there seem to be workloads which assume checksum algorithm can be
omitted from upload-part

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

test get_object_attributes

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #606 from yuvalif/wip-yuval-bucket-logging-flush

rgw/logging: tests for flush API

Reviewed-By: Ali Masarwe <ali.masarwa@ibm.com>

Merge pull request #601 from pritha-srivastava/wip-rgw-merge-store-tests

rgw/s3-tests: adding missing tests for testing delete operations (related to bucket policy and bucket public access block)

Merge pull request #605 from clwluvw/read-stats

HeadBucket: add read-stats query string for usage test

HeadBucket: add read-stats query string for usage test

Refs: https://github.com/ceph/ceph/pull/56756

Signed-off-by: Seena Fallah <seenafallah@gmail.com>

rgw/logging: tests for flush API

as well as test for object key filters

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

Merge pull request #576 from yuvalif/wip-yuval-bucket-logging

rgw/logging: basic set of tests for bucket logging

rgw/logging: basic set of tests for bucket logging

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

Merge pull request #603 from ArbitCode/wip-raja-rgw-test-fix-68211

rgw:modify testcase rgw header when bucket  or user quota is disabled

Merge pull request #604 from cbodley/wip-69001

sts: remove test_get_session_token_permanent_creds_denied

Merge pull request #602 from pritha-srivastava/wip-rgw-change-err-code

rgw/s3tests: making the tests generic to check only

sts: remove test_get_session_token_permanent_creds_denied

Fixes: https://tracker.ceph.com/issues/69001
Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw:modify testcase rgw header when bucket quota or user is disabled
By default quota is disable at user/bucket level.
if quota is disable then these value will not return so need to modify test_head_bucket_usages

'X-RGW-Quota-User-Size'
'X-RGW-Quota-User-Objects'
'X-RGW-Quota-Bucket-Size'
'X-RGW-Quota-Bucket-Objects'
to Fix: https://tracker.ceph.com/issues/68211

Signed-off-by: Raja Sharma raja@ibm.com

rgw/s3tests: making the tests generic to check only
for 403 error code (and not specific errors) so that
the tests pass for any order of auth engines.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw/s3-tests: adding a test to check put, get, delete and
then get to ensure that public block access is deleted
successfully.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw/s3-test: adding test to set, get, delete and then get
a bucket policy to ensure that delete correctly removes
the bucket policy

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

Merge pull request #593 from soumyakoduri/wip-skoduri-lc-noncur

Updating lifecycle_noncur* tests to include objects with instance empty

Updating lifecycle_noncur* tests to include objects with instance empty

Signed-off-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #591 from cbodley/wip-68292

s3: test GetObject with PartNumber and SSE-C encryption

Merge pull request #589 from tobias-urdin/v2-presigned-get

Add v2 signature presigned get_object tests

s3: test GetObject with PartNumber and SSE-C encryption

Signed-off-by: Casey Bodley <cbodley@redhat.com>

s3: add v2 signature presigned put_object tests

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Add v2 signature presigned get_object tests

This adds tests for get_object presigned URLs
using signature v2.

Also code formatting.

Signed-off-by: Tobias Urdin <tobias.urdin@binero.com>

Merge pull request #579 from galsalomon66/tracker_65651

Merge pull request #528 from pritha-srivastava/wip-rgw-oidc-tests

rgw: adding tests for add_client_id_to_oidc_provider

fix comments

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>

Merge pull request #578 from clwluvw/upload-part-copy

UploadPartCopy: add test for source bucket with policy

fix the assert per empty results

Signed-off-by: Gal Salomon <gal.salomon@gmail.com>

rgw: adding tests for add_client_id_to_oidc_provider
and update_thumbprint_for oidc_provider.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

UploadPartCopy: add test for source bucket with policy

Ref: https://github.com/ceph/ceph/pull/59253

Signed-off-by: Seena Fallah <seenafallah@gmail.com>

Merge pull request #577 from cbodley/wip-cross-tenant

s3: reenable tenanted bucket policy test

s3: reenable tenanted bucket policy test

the before-call hook url-encodes the ':' part of tenanted bucket names
to resolve SignatureDoesNotMatch errors

removed the list-v2 version of the test since it isn't relevant to
bucket policy test coverage

add a new test case that creates the bucket under the tenanted user,
then uses the main client to access it

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #572 from clwluvw/s3select-error

s3select: align error codes with the new AWS format

Merge pull request #574 from clwluvw/sse-c-policy

BucketPolicy: add test for sse-c in conditions

Merge pull request #573 from clwluvw/public-policy

BucketPolicy: donot allow NotPrincipal with Allow Effect

BucketPolicy: decouple encryption tests from invalid algo and unencrypted

Signed-off-by: Seena Fallah <seenafallah@gmail.com>

BucketPolicy: add test for sse-c in conditions

Ref. https://github.com/ceph/ceph/pull/58689

Signed-off-by: Seena Fallah <seenafallah@gmail.com>

BlockPublicPolicy: add test when policy has principal

Ref. https://tracker.ceph.com/issues/67048

Signed-off-by: Seena Fallah <seenafallah@gmail.com>

PolicyStatus: add test for policy with Principal

Ref. https://github.com/ceph/ceph/pull/58686

Signed-off-by: Seena Fallah <seenafallah@gmail.com>

BucketPolicy: donot allow NotPrincipal with Allow Effect

Ref. https://github.com/ceph/ceph/pull/58686

Signed-off-by: Seena Fallah <seenafallah@gmail.com>

s3select: align error codes with the new AWS format

ref. https://github.com/ceph/ceph/pull/56864

Signed-off-by: Seena Fallah <seenafallah@gmail.com>