rgw: switch to std::array in RGWBulkUploadOp due to C++11 and FreeBSD.

Before this patch RGWBulkUploadOp::terminal_errors was declared as
std::initializer_list<int>. Unfortunately, a constexpr constructor
for it is available since C++14, not C++11. This was causing build
failures on FreeBSD.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

Merge pull request #14174 from shinobu-x/wp-sk-typo-osdmonitor-20170328

mon/OSDMonitor: Clean up: delete extra S signature for plural

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #12243 from rzarzynski/wip-rgw-bulkupload

rgw: add support for the BulkUpload of Swift API
Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14120 from wangzhengyong/uninitialized

rgw: fix uninitialized fields

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #14217 from Liuchang0812/wip-18584-pg-info-dump

osd: print pg_info_t::purged_snaps as array, not string

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14036 from batrick/mds-debug-reply

mds: bump client_reply debug to match client_req

Reviewed-by: Yan, Zheng <zyan@redhat.com>

Merge pull request #14296 from theanalyst/fix/script/credits

script: drop the -x arg for credits script

Reviewed-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #13401 from liewegas/wip-kill-subop

osd: kill all remaining MOSDSubOp users

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #14221 from jcsp/wip-19253-b

qa: whitelist another fullness log message

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #14279 from jimmyway/wip-fix-pg-comment

osd: fix comments about pg refs and lock

Reviewed-by: Pan Liu <liupan1111@gmail.com>

Merge pull request #14277 from atheism/fix-test-objectstore-chain_xattr

test: objectstore: chain_xattr: fix wrong memset usage to fill buf

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #13800 from xiexingguo/wip-clean-pgcreate-throttle

common/config_opts.h: kill mon_pg_create_interval

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #13621 from Jing-Scott/add-remov-x-delete-feature

rgw: add the remove-x-delete feature to cancel swift object expiration

Reviewed-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

Merge pull request #13862 from jcsp/wip-16523

qa, mds: add checks for fragmentation, and enable it by default

mon/OSDMonitor: Clean up: delete extra S signature for plural

Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>

Merge pull request #14156 from smithfarm/release-notes-add-rbd-mirror

tools: ceph-release-notes: prefixes and pep8 compliance

Reviewed-by: Loic Dachary <ldachary@redhat.com>
Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

script: drop the -x arg for credits script

while useful for debugging creates a whole lot of output which we don't
need normally

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #12084 from hansbogert/patch-4

rgw: Add --zonegroup-new-name  in usage
Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14269 from liewegas/wip-no-spinlock

mon/OSDMonitor: spinlock -> std::mutex

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14274 from liewegas/wip-osd-beacon-fix

osd: fix some osd beacon bugs

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14288 from Adirl/small_leaks

msg/async/rdma: Fix small memory leaks detected by valgrind

Reviewed-by: Haomai Wang <haomai@xsky.com>

rgw: add the check for Content-Length in BulkUpload.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

rgw: implement the full response generation in BulkUpload of Swift API.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

rgw: optimize metadata caching in BulkUpload of Swift API.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

rgw: implement the object creation in BulkUpload of Swift API.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

rgw: implement the container creation in BulkUpload of Swift API.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

msg/async/rdma: Fix small memory leaks detected by valgrind

Issue: 995322
Change-Id: Iccffbd0defd09aa51c4b51b78733921444ea1c5f
Signed-off-by: Amir Vadai <amir@vadai.me>

rgw: implement the AlignedStreamGetter.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

rgw: implement the basic security check for BulkUpload of Swift API.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

Merge pull request #14170 from liewegas/wip-fewer-warnings

common/ceph_context: fewer warnings about experimental features

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14271 from joscollin/wip-krbd-warning

rbd: warning, ‘devno’ may be used uninitialized in this function

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #13909 from kestrels/wip-19217

crc32c: Add crc32c function optimized for ppc architecture

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14124 from Fabian-Gruenbichler/ipv6_fix

common: fix segfault in public IPv6 addr picking

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14173 from badone/wip-do_request-abort

common: Fix heap buffer overflow in do_request

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #14193 from liupan1111/wip-fix-delete-full

librados: set the flag CEPH_OSD_FLAG_FULL_TRY of Op in the right place.

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14248 from badone/wip-simple_spin_lock-delay

common: Make spinlock delay more conventional

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #13690 from jcsp/wip-17503

mgr: pass through cluster log to plugins

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

rgw: implement the TAR extraction loop of Swift's BulkUpload.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

rgw: implement the TAR format interpreter.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

rgw: implement RGWBulkUploadOp::DecoratedStreamGetter.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

rgw: initial class structure for BulkUpload of Swift API.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

osd: fix comments about pg refs and lock

Signed-off-by: tang.jin <tang.jin@istuary.com>

Merge pull request #14276 from atheism/rgw-rgwop-remove-unused-iter

rgw: rgw_op: remove unused variable iter
Reviewed-by: Orit Wasserman <owasserm@redhat.com>

test: objectstore: chain_xattr: fix wrong memset usage to fill buf

    Current usage:
        memset(buf, sizeof(buf), 0x1F);
    should be:
        memset(buf, 0x1F, sizeof(buf));
    to fill the buffer with '0x1F'.

Signed-off-by: Weibing Zhang <zhangweibing@unitedstack.com>

rgw: rgw_op: remove unused variable iter

    The variable iter is not used in  RGWInitMultipart::execute().

Signed-off-by: Weibing Zhang <zhangweibing@unitedstack.com>

Merge pull request #13811 from rzarzynski/wip-bs-bitmap-mem-cleanup

os/bluestore: memory and dereference clean-up in the BitAllocator

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14121 from majianpeng/bluefs-get-allocated

os/bluestore/BlueFS: optimize get_allocated

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14162 from majianpeng/optimize-bluestore-force-flush

os/bluestore: clean up flush logic

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14225 from ivancich/wip_fix_throttle_config_change

os/bluestore: make live changes for BlueStore throttle config work like initial config

Reviewed-by: Sage Weil <sage@redhat.com>

osd: only send beacon on connect if active

Otherwise the mon will just ignore it and we'll wait another
cycle.

Signed-off-by: Sage Weil <sage@redhat.com>

osd: fix beacon condition

- && should have been ||
- change this to instead not send when monmap epoch==0,
  and only set last_sent_beacon if we actually send.  That
  way we'll send on the next tick after we get a real monmap.

Signed-off-by: Sage Weil <sage@redhat.com>

osd/ReplicatedBackend: remove MOSDSubOp cruft from repop_commit

Signed-off-by: Sage Weil <sage@redhat.com>

osd: drop unused MOSDSubOp includes

Signed-off-by: Sage Weil <sage@redhat.com>

osd/ReplicatedBackend: rename sub_op_modify* do_repop*

Signed-off-by: Sage Weil <sage@redhat.com>

osd/ReplicatedBackend: no empty MOSDSubOps anymore

Signed-off-by: Sage Weil <sage@redhat.com>

osd/ReplicatedBackend: use more __func__

Signed-off-by: Sage Weil <sage@redhat.com>

osd: drop unnecessary declarations in headers

Signed-off-by: Sage Weil <sage@redhat.com>

osd: use MOSDScrubReserve instead of MOSDSubOp for scrub reservations

This is the last MOSDSubOp user.

Note that while the next step is to move to AsyncReserver internally,
this isn't quite yet possible since AsyncReserve "blocks" indefinitely
so we wouldn't generate a REJECT.  Changing how we schdule scrubs
internally will take a bit more work.

Signed-off-by: Sage Weil <sage@redhat.com>

osd: use new MOSDRepScrubMap message for ScrubMap instead of MOSDSubOp

This is one of the last remaining users of MOSDSubOp!

Signed-off-by: Sage Weil <sage@redhat.com>

osd: use new MOSDPGBackfillRemove instead of MOSDSubOp

One of the last remaining MOSDSubOp users!

Signed-off-by: Sage Weil <sage@redhat.com>

osd/ReplicatedBackend: remove legacy push/pull op handling

These are never sent, and thus never recieved.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #14229 from ceph/wip-systemd

qa: Add reboot case for systemd test

Merge pull request #14254 from idryomov/wip-vstart-runner-ps

qa/vstart_runner: amend ps invocation

Reviewed-by: John Spray <john.spray@redhat.com>

Merge pull request #14226 from ceph/preset-mon

systemd: remove ceph-create-keys from presets

Merge pull request #14266 from tchaikov/wip-require-mgr-for-pg-dump

tests: add MGR=1 so 'pg dump' won't be blocked

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #14259 from johnwilkins/wip-doc-multisite

doc: wip-doc-multisite ports downstream multisite document upstream.

rbd: warning, ‘devno’ may be used uninitialized in this function

The following warning appears during make. Fixed in both unmap_image() functions in krbd.cc

--
krbd.cc: In function ‘int krbd_unmap_by_spec(krbd_ctx*, const char*, const char*, const char*, const char*)’:
krbd.cc:608:65: warning: ‘devno’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   return do_unmap(ctx->udev, devno, build_unmap_buf(id, options));
                                                                 ^
krbd.cc:591:9: note: ‘devno’ was declared here
   dev_t devno;
--

Signed-off-by: Jos Collin <jcollin@redhat.com>

mon/OSDMonitor: spinlock -> std::mutex

I think spinlock is dangerous here: we're doing semi-unbounded
work (decode).  Also seemingly innocuous code like dout macros
take mutexes.

Signed-off-by: Sage Weil <sage@redhat.com>

osd/OSDMap: use _pg_to_up_acting_osds() to get_pg_acting_primary()

avoid unnecessary swap() call of vector<int> which will be dropped on
the floor after getting its first element, which can be retrieved using
another parameter using _pg_to_up_acting_osds() directly.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr: use OSDMap::get_pg_acting_primary() to get the primary

OSDMap::pg_to_acting_osds() assumes that the "acting" parameter is not
null.

Signed-off-by: Kefu Chai <kchai@redhat.com>

tests: add MGR=1 so 'pg dump' won't be blocked

Signed-off-by: Kefu Chai <kchai@redhat.com>

common/config_opts: kill mon_pg_create_interval

This is not needed anymore.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #14260 from dmick/wip-workunit-clone-with-branch

workunit: request branch when cloning

Reviewed-by: Kefu Chai <kchai@redhat.com>

common: Make spinlock delay more conventional

The accepted method of implementing a spinlock delay is the "pause"
instruction.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

tasks/workunit.py: specify the branch name when cloning a branch

c1309fb failed to specify a branch when cloning using --depth=1, which
by default clones the HEAD. and we can not "git checkout" a specific
sha1 if it is not HEAD, after cloning using '--depth=1', so in this
change, we dispatch "tag", "branch", "HEAD" using three Refspec classes.

Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Dan Mick <dan.mick@redhat.com>

rgw: fix uninitialized fields

Signed-off-by: wangzhengyong@cmss.chinamobile.com

Merge pull request #14219 from ShiqiCooperation/master

os/bluestore: clean up Invalid return value judgment

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14228 from ifed01/wip-bluestore-fix-store-test

test/store_test: fix bluestore test cases disablement

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #13617 from liewegas/wip-mgr-commands

mon,mgr: tag some commands for ceph-mgr

Reviewed-by: Kefu Chai <kchai@redhat.com>

mon/ConfigKeyService: wait for quorum

Among other things, this prevents a mgr activation stall if it
happens to request config-keys from a mon that is out of
quorum.

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrMonitor: show delta

This is mostly because I couldn't debug a weird state where
it kept updating but it appeared the addr was not changing
(always '-').

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrMap: implement dump, add to ceph-dencoder

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrMonitor: print MgrMap to log on each change

The other services do this.

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrMonitor: health warn/err if no active mgr

Start warning once mons are luminous; start erroring once
require_luminous is set in osdmap.  Allow a grace period for
mgr to restart or standby to take over before we turn a warning
into an error.

Signed-off-by: Sage Weil <sage@redhat.com>

Ported the downstream (and tested) document upstream.

Signed-off-by: John Wilkins <jowilkin@redhat.com>

Clarified index.

Signed-off-by: John Wilkins <jowilkin@redhat.com>

doc: Added a new version of the multi-site graphic.

Signed-off-by: John Wilkins <jowilkin@redhat.com>

Merge pull request #14183 from joscollin/wip-rgw-cleanup-removeunwantedheaders

rgw: Removed Unwanted headers
Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #14194 from joscollin/wip-rgw_rados-warning

rgw: warning, output may be truncated before the last format character

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

qa/vstart_runner: amend ps invocation

"ps -xwwu<id>" is parsed as BSD, because -x is not a UNIX option.
"u" is a BSD option for user-oriented format, so the <id> ends up being
parsed as an old-style "select by pid".  The only reason this command
doesn't dump other user's processes is that the BSD "only yourself"
restriction is in effect.

I'm not sure what's wrong with a simple "ps xww", but if we want to
select by euid, let's do it right.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #14253 from liupan1111/wip-remove-debug-message

rbd-nbd: remove debug messages from do_unmap

Reviewed-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #13999 from tchaikov/wip-extract-creating-pgs

mon,osd: decouple creating pgs from pgmap

Reviewed-by: Sage Weil <sage@redhat.com>

rbd-nbd: remove debug message from do_unmap

Global context is not initialized when do_unmap is called.

Signed-off-by: Pan Liu <liupan1111@gmail.com>

tools/ceph-objectstore-tool: always set first_committed

otherwise the workaround of 7fb3804fb is triggered. we need to remove
that workaround later on.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon: switch to osdmon when handling osd_pg_creates subs

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/OSDMonitor: avoid search and lookup anti-pattern

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/OSDMonitor: pass by reference not pointer of const param

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/OSDMonitor: switch to the new creating_pgs

* prime_pg_temp(): switch to the new creating_pgs
* get_trim_to(): switch to the new creating_pgs

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon: handle MOSDPGCreated messages

MOSDPGCreated messages are used to prune the creating_pgs_by_osd_epoch
and creating_pgs, by updating created_pools. as once a pool is created
we will not send MOSDPGCreate to its acting_primary OSD anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>

osd: send pg-created message if any pg is newly created

add an option named "osd_created_report_interval" to specify the
interval to check and send the "pg_created" mesages to mon

because pg could update its state when it is still in the pg_stat_queue,
for example, to change its state to PG_STATE_CLEAN, we cannot tell if we
have sent a "pg-created" message for it or not without introducing a new
member variable in PG.

Signed-off-by: Kefu Chai <kchai@redhat.com>