Merge branch prs/66467

Merge branch prs/66396

Merge branch prs/66232

Merge branch prs/66223

Merge branch prs/66244

Merge branch prs/66171

pybind/mgr: add per-module CLICommand instances to remaining modules

Signed-off-by: Samuel Just <sjust@redhat.com>

pybind/mgr/dashboard: create DBCLICommand, use throughout

Also moves Command from mgr_module to DBCommand in dashboard/cli.py
since dashboard is the only user and this way it can directly use
DBCLICommand.

Signed-off-by: Samuel Just <sjust@redhat.com>

pybind/mgr/tests/test_object_format: update DecoDemo to use fresh CLICommand

Signed-off-by: Samuel Just <sjust@redhat.com>

pybind/mgr/smb: adapt SMBCommand to use CLICommandBase

Signed-off-by: Samuel Just <sjust@redhat.com>

pybind/orchestrator,cephadm: replace CLICommandMeta

orchestrator and cephadm relied on CLICommandMeta to bypass the global
behavior of CLICommand.  That is no longer a problem, so replace
CLICommandMeta with OrchestratorCLICommandBase to preserve the magic
error wrapping.

Signed-off-by: Samuel Just <sjust@redhat.com>

pybind/mgr: mechanically fix simple users to not import CLI*Command

The next commit will introduce module specific CLICommand classes.

Signed-off-by: Samuel Just <sjust@redhat.com>

pybind/mgr/mgr_module: support per-module CLICommand instances and globals

Otherwise, the class members on MgrModule and CLICommand are global to all
modules in the same interpreter.

Following commits will introduce a per-module CLICommand types for each
module.

Signed-off-by: Samuel Just <sjust@redhat.com>

pybind/.../dashboard: misc automatic linter fixes

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #66336 from Matan-B/wip-matanb-crimson-snapmapper-osddriver

osd/SnapMapper: fix Crimson logs

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>

neorados: specify alignments for aligned_storage

the default alignment of `Alignment = std::bit_ceil(S)` was a very
conservative estimate. reduce that to `alignof(std::max_align_t)` to
match the old behavior, then assert on construction that the given
alignment is large enough for the implementation's type

Fixes: https://tracker.ceph.com/issues/73750
Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #66332 from rhcs-dashboard/73854-CephFS-Authorize-modal-Update-issues

mgr/dashboard : fix - CephFS Authorize Modal Update issue

Reviewed-by: Dnyaneshwari Talwekar dtalweka@redhat.com

Merge pull request #66382 from bluikko/doc-mgmt-gateway-improvements-cephadm

doc/cephadm: Fix command plus improvements in services/mgmt-gateway.rst

Merge pull request #66006 from afreen23/carbonize-chnage-password

mgr/dashboard: Carbonize the Change Password Form

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Dnyaneshwari Talwekar dtalweka@redhat.com

Merge pull request #66326 from afreen23/fixes-mixins

monitoring: Fixes for development

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>

mgr/dashboard : fix - CephFS Authorize Modal Update issue
fixes : https://tracker.ceph.com/issues/73854
Signed-off-by: Devika Babrekar <devika.babrekar@ibm.com>

doc/cephadm: Fix command plus improvements in service/mgmt-gateway.rst

Remove double backticks from a CLI command.

Use bash prompt consistently for CLI command blocks.

Don't capitalize word in middle of sentence.

Talk about "admin" instead of "user", similarly to the last text
paragraph in the doc.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>

mgr/dashboard: Carbonize the Change Password Form

Fixes https://tracker.ceph.com/issues/73193

-  using carbon based stylings, typography and components
-  used grid layout for form arrangement
-  breadcrumb is slightly off, which needs to be fixed by applying grid layout to the app shell

Signed-off-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #66372 from tchaikov/wip-qa-encoder-exclude

qa/suites/rados/encoder: exclude ceph-osd-classic when installing LTS…

Reviewed-by: Matan Breizman <mbreizma@ibm.com>

qa/suites/rados/encoder: exclude ceph-osd-* when installing LTS releases

In a37b5b5, the ceph-osd-classic and ceph-osd-crimson packages were
added to qa/packages/packages.yaml. The "install" task uses this file as
the default package list for all branches, including LTS releases like
Reef.

However, a37b5b5 only exists in the main branch and won't be backported
to LTS branches. This causes installation failures in the rados/encoder
test suite, which verifies forward compatibility by installing LTS
releases and testing whether they can decode the latest corpus.

Exclude ceph-osd-classic and ceph-osd-crimson from LTS installations to
ensure the test suite can successfully install ceph-dencoder, which is
required for the interoperability tests.

Fixes: https://tracker.ceph.com/issues/73957
Signed-off-by: Kefu Chai <k.chai@proxmox.com>

Merge pull request #66293 from anthonyeleven/instore.dbnoonecanhearyouscream

doc: Improve start/hardware-recommendations.rst

Merge pull request #65995 from pcuzner/rocksdb_compaction_metric

rados/osd: enable compact_running perfcounter at PRIO=5

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Neha Ojha <nojha@ibm.com>

doc: Improve start/hardware-recommendations.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

osd/SnapMapper: fix Crimson logs

Switch to crimson's debugging macro and fix the faulty
subsystem defined of ceph_subsys_

Might help with https://tracker.ceph.com/issues/73790

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

monitoring: Fixes for development

- fixes tox.ini using and undefined env - `grafonnet-check`( instead of `jsonnet-check`)
- adds steps for local development of mixins and building jsonnet
- added help command in Makefile
- added comments and descriptions for Makefile and tox.ini

Signed-off-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #66268 from Matan-B/wip-matanb-old-clients-installs

qa/suites/thrash-old-clients/1-install: exclude ceph-osd-classic

Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #62765 from bobham-bloomberg/unittest-ceph-assert

test/ceph_assert.cc: Disable core files

Merge pull request #66307 from shraddhaag/wip-shraddhaag-fix-slow-ops

qa/clusters/crimson: increase reactors in fixed-1 cluster

Reviewed-by: Matan Breizman <mbreizma@ibm.com>

Merge pull request #65971 from ceph/wip-20.2.0-documentation

doc: add Tentacle v20.2.0 release notes

Merge pull request #65374 from dang/wip-dang-standalone

RGW - Standalone - Enable building without librados

doc/releases: add cephadm notes

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: change final release date

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases/tentacle: add missing rgw deprecation notice

Signed-off-by: Casey Bodley <cbodley@redhat.com>

doc/releases/tentacle: fix Crimson highlight

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

doc/releases/tentacle: add Crimson highlight

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

doc/releases: arrange sections in alphabetical order

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases/tentacle.rst: more RBD items

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

doc/releases/tentacle.rst: fix seastore typo

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

doc/releases: remove extra word

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases/tentacle.rst: Update Crimson section

Refer to Tentacle Crimson updates blog post

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

doc/releases: remove note that is not specific to tentacle

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: move smb support update into highlights

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: give smb update a better category title

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: add Crimson section and clean up references

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: edit formatting and other small changes

Formatting with double backticks, indentation etc.

Fix some typos and add missing hyphenation.

Add review comment suggestions by anthonyeleven after OOB discussion.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>

doc/releases: add one more item to RADOS

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: add to CephFS section

And a bit of RGW

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: add more to RBD section

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: clean up RGW formatting

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: take quincy out of timeline since it is EOL

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/releases: add more to mgr section and fix rados formatting

Signed-off-by: Laura Flores <lflores@ibm.com>

doc: improve rados section for tentacle release notes

Signed-off-by: Laura Flores <lflores@ibm.com>

doc/tentacle: add more RGW release notes

Signed-off-by: Casey Bodley <cbodley@redhat.com>

doc: add Tentacle v20.2.0 release notes

Signed-off-by: Laura Flores <lflores@ibm.com>

qa/clusters/crimson: increase reactors in fixed-1 cluster

Issue: Various different tests were failing randomly due to slow
ops. There was no common ground between them, it was happening
across differnet object stores (seastore and bluestore) and
across different tests.

Cause: Since this is happening quite randomly, this is likely
happening due to low reactor count.

Solution: We are opting the solution to increase reactors used
for testing. I've increased them to 3 from the initial 2 value.

Fixes: https://tracker.ceph.com/issues/72778
Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>

Merge pull request #66207 from steliaio/fix-rados-fsid-return-doc

include/rados/librados.h: fix documented rados_cluster_fsid return value

Reviewed-by: Casey Bodley <cbodley@redhat.com>

test/ceph_assert.cc: Disable core files

Without this, core files are produced which subsequently cause
failures in other tests, specifically smoke.sh and safe-to-destroy.sh.

Fixes: bfa83df6d33ee2238f1389ca4518592b5c4fb267
Signed-off-by: Bob Ham <bham12@bloomberg.net>
test/ceph_assert.cc: Update line numbers

Signed-off-by: Bob Ham <bham12@bloomberg.net>

Merge pull request #66105 from rhcs-dashboard/carbonize-sync-policy-form

mgr/dashboard: Carbonize multisite sync policy forms

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@ibm.com>

qa/suites: exclude ceph-osd-classic

a37b5b5bde8c2e8d6890f16b31046119ed55f25d added ceph-osd-classic
package.
old-clients and upgrade tests should not try to install the new package
as it is not available in older releases.

Fixes: https://tracker.ceph.com/issues/73848
Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #65999 from anoopcs9/smb-disable-posix-locking

mgr/smb: Disable posix locking in share definition

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #65931 from anoopcs9/update-smbd-ports-config

smb: Update the configuration logic for smbd ports

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #66179 from rhcs-dashboard/73766-remove-subalerts-detail

mgr/dashboard : Remove subalerts details for multiple subalerts

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

mgr/dashboard: Carbonize multisite sync policy forms

Fixes: https://tracker.ceph.com/issues/73164
Signed-off-by: Naman Munet <naman.munet@ibm.com>

Merge pull request #66149 from amathuria/wip-amat-update-seastar-nov25

seastar: bump up seastar submodule

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

mgr: add mgr_subinterpreter_modules config

This commit adds a mgr_subinterpreter_modules config to cause specified
modules (or all if * is specified) to be loaded in individual
subinterpreters.

This changes the default behavior of ceph-mgr from running each module
in a distinct subinterpreter to running them all in the same main
interpreter.  We can reintroduce subinterpreter support over time by
adding modules to the list as we test them.

Fixes: https://tracker.ceph.com/issues/73857
Fixes: https://tracker.ceph.com/issues/73859
Signed-off-by: Samuel Just <sjust@redhat.com>

python-common/.../service_spec: implement ServiceSpec.__getnewargs__ to allow unpickle to work correctly

Signed-off-by: Samuel Just <sjust@redhat.com>

mgr/smb: Disable posix locking in share definition

The prerequisites for supporting durable handles[1] in Samba include
disabling the mapping of POSIX locks, as well as setting the `kernel
oplocks` and `kernel sharemodes` parameters to disabled. Currently
this configuration is hard‑coded, but in the future it could be made
conditional and combined with other settings to enable persistent
handles on continuously available shares.

[1] https://www.samba.org/samba/docs/current/man-html/smb.conf.5.html#DURABLEHANDLES

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>

Merge pull request #65962 from NitzanMordhai/wip-nitzan-MOSDOpReply-pgid64-encode-decode-fix

messages: MOSDOpReply encode and decode errorcode32_t with PGID64 fea…

qa/workunits: add Rocky Linux support to librados tests

Add Rocky Linux to the list of supported RPM-based distributions in
test_librados_build.sh and version_number_sanity.sh. Rocky Linux uses
the same package names and commands as CentOS/RHEL, so it can use the
existing RPM codepath.

Without this change, the tests fail on Rocky Linux systems with
"unknown distro" errors.

Fixes: https://tracker.ceph.com/issues/73839
Signed-off-by: Nitzan Mordechai <nmordec@ibm.com>

Merge pull request #66116 from rhcs-dashboard/carbonized-multisite-zone

mgr/dashboard: Carbonized - Multisite Zone (Create and Edit)

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Naman Munet <naman.munet@ibm.com>

qa/suites/fs/shell: install cmd2

This must be installed via pip as a band-aid fix.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

ceph.spec.in: break python3-cmd2 dependency

This package is no longer available in EPEL 10. We will have to refactor
the library out of cephfs-shell.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>