]>
git.apps.os.sepia.ceph.com Git - ceph-ci.git/log
Kefu Chai [Sun, 13 Jun 2021 15:27:58 +0000 (23:27 +0800)]
Merge pull request #41809 from linuxbox2/wip-returnvec-64
rados: increase osd_max_write_op_reply_len default to 64 bytes
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Sun, 13 Jun 2021 15:26:46 +0000 (23:26 +0800)]
Merge pull request #41746 from strenuous-life/wip-cephadm-osd-create
mgr/cephadm: When create osd which include db, _create_daemon will be…
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Sage Weil [Sat, 12 Jun 2021 13:02:19 +0000 (09:02 -0400)]
Merge PR #41781 into master
* refs/pull/41781/head:
mgr/mgr_module:delete invalid judgment
Reviewed-by: Kefu Chai <kchai@redhat.com>
Sage Weil [Sat, 12 Jun 2021 13:01:38 +0000 (09:01 -0400)]
Merge PR #41699 into master
* refs/pull/41699/head:
mgr/telemetry: pass leaderboard flag even w/o ident
Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>
Kefu Chai [Sat, 12 Jun 2021 00:37:35 +0000 (08:37 +0800)]
Merge pull request #40480 from kamoltat/wip-ksirivad-fix-bug-49988
pybind/mgr/progress: Disregard unreported pgs
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Kefu Chai [Sat, 12 Jun 2021 00:11:45 +0000 (08:11 +0800)]
Merge pull request #41772 from cyx1231st/wip-seastore-onode-tree-node-size
crimson/onode-staged-tree: extend tree node sizes to fit insert upper-bounds
Reviewed-by: Kefu Chai <kchai@redhat.com>
Patrick Donnelly [Sat, 12 Jun 2021 00:10:41 +0000 (17:10 -0700)]
Merge PR #39505 into master
* refs/pull/39505/head:
qa: test nowsync option in kernel client workflows
qa: deep merge top level overrides for fuse/kclient
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Kefu Chai [Sat, 12 Jun 2021 00:08:47 +0000 (08:08 +0800)]
Merge pull request #40952 from tchaikov/wip-deb-build-profile
debian: use build-profile to manage build deps
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Sat, 12 Jun 2021 00:07:06 +0000 (17:07 -0700)]
Merge PR #41683 into master
* refs/pull/41683/head:
qa: update RHEL to 8.4
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Ernesto Puerta [Fri, 11 Jun 2021 17:46:15 +0000 (19:46 +0200)]
Merge pull request #41550 from aaryanporwal/navbar-fix
mgr/dashboard: fix for right sidebar nav icon not clickable
Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: aaryanporwal <NOT@FOUND>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Yingxin Cheng [Wed, 9 Jun 2021 03:06:28 +0000 (11:06 +0800)]
crimson/onode-staged-tree: convert ghobject_t to key_hobj_t to print
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 9 Jun 2021 02:48:43 +0000 (10:48 +0800)]
crimson/onode-staged-tree: merge with single-value tail internal node
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Tue, 8 Jun 2021 07:19:33 +0000 (15:19 +0800)]
crimson/onode-staged-tree: switch to and test larger node sizes
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Tue, 8 Jun 2021 06:11:52 +0000 (14:11 +0800)]
crimson/onode-staged-tree: support unaligned read to leaf_sub_items_t::num_keys
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Tue, 8 Jun 2021 06:03:07 +0000 (14:03 +0800)]
crimson/onode-staged-tree: add the missing retired validation
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Tue, 8 Jun 2021 01:59:32 +0000 (09:59 +0800)]
crimson/onode-staged-tree: encode/decode stage_size instead
end-offset may risk overflow the node_offset_t, but stage_size will not.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Tue, 8 Jun 2021 01:55:15 +0000 (09:55 +0800)]
crimson/onode-staged-tree: use extent_len_t and node_offset_t correctly
extent_len_t represents a value that may include the node size, but
node_offset_t cannot and may overflow. Also add validations when
try to cast a larger type to node_offset_t.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Tue, 8 Jun 2021 01:42:34 +0000 (09:42 +0800)]
crimson/onode-staged-tree: remove unused code
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Tue, 8 Jun 2021 01:41:44 +0000 (09:41 +0800)]
crimson/onode-staged-tree: validate node size where possible
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 7 Jun 2021 05:57:13 +0000 (13:57 +0800)]
crimson/onode-staged-tree: remove compile-time NODE_BLOCK_SIZE
Switch to run-time node_size.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 7 Jun 2021 05:15:58 +0000 (13:15 +0800)]
crimson/onode-staged-tree: pass node_size to lower node stages
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 7 Jun 2021 02:45:18 +0000 (10:45 +0800)]
crimson/onode-staged-tree: remove compile-time node SIZE
Switch to run-time node_extent_t::node_size instead.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 7 Jun 2021 02:43:31 +0000 (10:43 +0800)]
crimson/onode-staged-tree: cleanup internal_fields_3_t template
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 3 Jun 2021 02:28:50 +0000 (10:28 +0800)]
crimson/onode-staged-tree: pass node_size into node_extent_t
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 2 Jun 2021 15:44:07 +0000 (23:44 +0800)]
crimson/onode-staged-tree: extend num_keys_t to support larger nodes
Also adjust the accroding layout related unit tests.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 2 Jun 2021 08:25:05 +0000 (16:25 +0800)]
crimson/onode-staged-tree: remove hard-coded node_stage_t::EXTENT_SIZE
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 2 Jun 2021 06:07:33 +0000 (14:07 +0800)]
crimson/onode-staged-tree: check the maximum tree height
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 2 Jun 2021 05:36:11 +0000 (13:36 +0800)]
crimson/onode-staged-tree: validate safe-split from tree_conf_t
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 2 Jun 2021 05:33:50 +0000 (13:33 +0800)]
crimson/onode-staged-tree: add and use node sizes in tree_conf_t
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 2 Jun 2021 05:18:48 +0000 (13:18 +0800)]
crimson/onode-staged-tree: implement size upper-bounds to value
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 2 Jun 2021 04:47:55 +0000 (12:47 +0800)]
crimson/onode-staged-tree: implement size upper-bounds to ns/oid
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 2 Jun 2021 03:52:33 +0000 (11:52 +0800)]
crimson/onode-staged-tree: introduce compile-time tree_conf_t
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 31 May 2021 07:58:30 +0000 (15:58 +0800)]
crimson/onode-staged-tree: cleanup, decouple test_item_t from TestValue
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 31 May 2021 02:11:01 +0000 (10:11 +0800)]
crimson/seastore: introduce TransactionManager::read_extent(t, offset)
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 26 May 2021 06:26:59 +0000 (14:26 +0800)]
crimson/onode-staged-tree: correct the node size equation
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 26 May 2021 04:45:27 +0000 (12:45 +0800)]
crimson/onode-staged-tree: try merge peer if node has one value
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 26 May 2021 04:44:13 +0000 (12:44 +0800)]
crimson/onode-staged-tree: cleanup and introduce has_single_value()
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Fri, 11 Jun 2021 11:59:46 +0000 (19:59 +0800)]
Merge pull request #41814 from tchaikov/wip-crimson-fmt-seq
crimson/osd: specialize fmt::formatter<> for OpSequencer
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Ernesto Puerta [Fri, 11 Jun 2021 09:08:18 +0000 (11:08 +0200)]
Merge pull request #41759 from rhcs-dashboard/wip-api_label-master
.github/labeler: add api-change label
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Sebastian Wagner [Fri, 11 Jun 2021 08:45:47 +0000 (10:45 +0200)]
Merge pull request #41242 from zdover23/wip-doc-cephadm-monitoring-deploying-monitoring-second-half-2021-05-10
doc/cephadm: rewrite "deploy. mon. w/cephadm" 2/2
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Fri, 11 Jun 2021 08:45:04 +0000 (10:45 +0200)]
Merge pull request #41241 from zdover23/wip-doc-cephadm-monitoring-deploying-monitoring-first-half-2021-05-10
doc/cephadm: rewrite "deploy. mon. w/cephadm"
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Kefu Chai [Fri, 11 Jun 2021 06:18:22 +0000 (14:18 +0800)]
crimson/osd: specialize fmt::formatter<> for OpSequencer
so we can print it like fmt::format("{}", sequencer)
Signed-off-by: Kefu Chai <kchai@redhat.com>
jianglong01 [Fri, 11 Jun 2021 02:56:30 +0000 (10:56 +0800)]
mgr/cephadm: When test osd active, it need to add "mock call" to make sure execute correctly
Signed-off-by: jianglong01 <jianglong01@qianxin.com>
Kefu Chai [Fri, 11 Jun 2021 00:41:36 +0000 (08:41 +0800)]
Merge pull request #41812 from agayev/zoned-fix-block-size
os/bluestore: Fix the size of the block in the Allocator base class t…
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Kefu Chai [Fri, 11 Jun 2021 00:32:30 +0000 (08:32 +0800)]
Merge pull request #41744 from tchaikov/wip-cmake-no-python-bindings-on-wnin32
cmake: vstart do not depend on cython_rbd if WIN32
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Thu, 10 Jun 2021 21:53:21 +0000 (14:53 -0700)]
Merge PR #41442 into master
* refs/pull/41442/head:
doc/cephfs/nfs: add ganesha configuration hierarchy
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Patrick Donnelly [Thu, 10 Jun 2021 20:55:12 +0000 (13:55 -0700)]
Merge PR #41797 into master
* refs/pull/41797/head:
qa: update cephfs-shell distro to ubuntu 20.04
Reviewed-by: Kefu Chai <kchai@redhat.com>
Igor Fedotov [Thu, 10 Jun 2021 20:32:00 +0000 (23:32 +0300)]
Merge pull request #41575 from ifed01/wip-ifed-fix-no-osd-daemonperf
common/PriorityCache: low perf counters priorities for submodules.
Reviewed-by: Mark Nelson <mnelson@readhat.com>
Abutalib Aghayev [Thu, 10 Jun 2021 19:59:45 +0000 (15:59 -0400)]
os/bluestore: Fix the size of the block in the Allocator base class to avoid
the confusing log message about the block size.
Signed-off-by: Abutalib Aghayev <agayev@psu.edu>
Matt Benjamin [Thu, 10 Jun 2021 14:27:58 +0000 (10:27 -0400)]
rados: increase osd_max_write_op_reply_len default to 64 bytes
Agreed in #ceph-devel on 6/10. The current controlling
rationale is that the default value should be sufficient to
marshall a SHA-512 checksum.
Fixes: https://tracker.ceph.com/issues/51166
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Matt Benjamin [Thu, 10 Jun 2021 11:56:52 +0000 (07:56 -0400)]
Merge pull request #41585 from pritha-srivastava/wip-rgw-sts-session-policy-eval
rgw/sts: correcting the evaluation of session policies
Matt Benjamin [Thu, 10 Jun 2021 11:56:31 +0000 (07:56 -0400)]
Merge pull request #41735 from pritha-srivastava/wip-rgw-sts-ops-log-updates
rgw/sts: adding role name and role session to ops log.
Sebastian Wagner [Thu, 10 Jun 2021 10:52:17 +0000 (12:52 +0200)]
Merge pull request #41653 from zdover23/wip-doc-cephadm-serve-man-setting-a-limit-2021-06-02
doc/cephadm: enriching "setting a limit"
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Thu, 10 Jun 2021 10:13:40 +0000 (12:13 +0200)]
Merge pull request #41693 from sebastian-philipp/cephadm-devenv-bootstrap-mount
doc/dev/cephadm: cephadm bootstrap --shared_ceph_folder
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Liu-Chunmei [Thu, 10 Jun 2021 00:17:07 +0000 (17:17 -0700)]
Merge pull request #41741 from liu-chunmei/seastore-fixe-read-invalid
crimson/seastore: fix OTree read invalid extent
Patrick Donnelly [Wed, 9 Jun 2021 23:20:05 +0000 (16:20 -0700)]
qa: update cephfs-shell distro to ubuntu 20.04
18.04 is no longer built.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
chunmei-liu [Mon, 7 Jun 2021 23:48:20 +0000 (16:48 -0700)]
crimson/seastore: fix OTree read invalid extent
Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
Sage Weil [Wed, 9 Jun 2021 19:55:25 +0000 (15:55 -0400)]
Merge PR #41229 into master
* refs/pull/41229/head:
qa/suites/upgrade/pacific-x/stress-split: add
Reviewed-by: Yuri Weinstein <yweins@redhat.com>
Kefu Chai [Wed, 9 Jun 2021 15:41:47 +0000 (23:41 +0800)]
Merge pull request #41729 from tchaikov/wip-std-filesystem-gcc-8
*: stop using <experimental/filesystem> as an alternative
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Kefu Chai [Wed, 9 Jun 2021 15:40:21 +0000 (23:40 +0800)]
Merge pull request #41791 from rzarzynski/wip-crimson-monc-no_auth_req_when_inactive
crimson/monc: don't serve auth requests without active mon connection.
Reviewed-by: Kefu Chai <kchai@redhat.com>
Neha Ojha [Wed, 9 Jun 2021 15:28:05 +0000 (08:28 -0700)]
Merge pull request #41782 from sseshasa/wip-fix-standalone-test
qa/standalone: Use osd op queue = wpq in activate_osd() within ceph-helpers.sh.
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Mon, 7 Jun 2021 09:18:19 +0000 (17:18 +0800)]
common/strtol: do not check for existence of <charconv>
<charconv> is available since GCC-8, see https://gcc.gnu.org/onlinedocs/libstdc++/manual/status.html#status.iso.2017
> Elementary string conversions P0067R5 11.1 (integral types supported since 8.1) __has_include(<charconv>), __cpp_lib_to_chars >= 201611
since we always have the access to GCC-8.1 and up, there is no need to
detect the existence of <charconv> anymore.
also, because GCC-11 introduced the support of float types support,
update the comment to reflect the change.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 7 Jun 2021 08:31:11 +0000 (16:31 +0800)]
*: always include <filesystem>
since there is no need to be compatible with GCC older than GCC-8, so
there is no need to use <experimental/filesystem> as an alternative of
<filesystem> anymore.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 7 Jun 2021 08:21:22 +0000 (16:21 +0800)]
os/bluestore/bluestore_tool: do not use boost:filesystem as alternative
reverts
9dedabde520907f99727edf9f916ebb55ccdaa87
since there is no need to be compatible with GCC older than GCC-8, so
there is no need to use boost::filesystem as an alternative of
std::filesystem anymore.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 7 Jun 2021 08:39:22 +0000 (16:39 +0800)]
cmake: stop detecting <experimental/filesystem>
since we've dropped the support of GCC older than v8.0, there is no need
to detect <experimental/filesystem>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 7 Jun 2021 08:17:09 +0000 (16:17 +0800)]
cmake: require GCC-8.1 and up
for better C++17 support, for instance for a better std::filesystem
support.
the reason why 8.1 is required is that ubuntu focal provides GCC-8.1,
and RHEL/CentOS8 provides GCC-8.4.1. so we only test the build on
GCC-8.1 and up so far.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kamoltat [Thu, 13 May 2021 17:38:10 +0000 (17:38 +0000)]
pybind/mg/progress: Disregard unreported pgs
The global recovery event progress calculations only
takes into account pgs with `reported_epoch < start_epoch_of_event`
but sometimes the pgs doesn't get move before or after the creation
of the global recovery event, therefore this might result in a bug
where the global event gets stuck forever unless there is another
event that specifically makes the pgs that get stuck moves and updates
its `reported_epoch`.
Therefore, we decided to disregard pgs that are in active+clean state
but has `reported_epoch < start_epoch_of_event`.
Fixes: https://tracker.ceph.com/issues/49988
Signed-off-by: Kamoltat <ksirivad@redhat.com>
Sage Weil [Wed, 9 Jun 2021 14:51:34 +0000 (10:51 -0400)]
Merge PR #41740 into master
* refs/pull/41740/head:
mgr/nfs: do not depend on cephadm.utils
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Radoslaw Zarzynski [Wed, 9 Jun 2021 14:31:50 +0000 (14:31 +0000)]
crimson/monc: don't serve auth requests without active mon connection.
It's yet another racing issue which happens when auth request
handling is performed during the `active_con` reset sequence.
It caused the following `nullptr` dereference at Sepia:
```
DEBUG 2021-06-09 10:27:24,059 [shard 0] ms - [osd.6(client) v2:172.21.15.170:6809/33397 >> client.? -@39840] GOT AuthRequestFrame: method=2, p
referred_modes={2, 1}, payload_len=174
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/
17.0.0-4977-g65cb255e /rpm/el8/BUILD/
ceph-17.0.0-4977-g65cb255e /src/crimson/mon/MonClient.cc:595:26: runtime error: member call on null pointer of type 'struct Connection'
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/
17.0.0-4977-g65cb255e /rpm/el8/BUILD/
ceph-17.0.0-4977-g65cb255e /src/crimson/mon/MonClient.cc:178:11: runtime error: member access within null pointer of type 'struct Connection'
Segmentation fault on shard 0.
Backtrace:
0# 0x0000563F9C00395F in ceph-osd
1# FatalSignal::signaled(int, siginfo_t const*) in ceph-osd
2# FatalSignal::install_oneshot_signal_handler<11>()::{lambda(int, siginfo_t*, void*)#1}::_FUN(int, siginfo_t*, void*) in ceph-osd
3# 0x00007F4A064D0B20 in /lib64/libpthread.so.0
4# crimson::mon::Connection::get_keys() in ceph-osd
5# crimson::mon::Client::handle_auth_request(seastar::shared_ptr<crimson::net::Connection>, seastar::lw_shared_ptr<AuthConnectionMeta>, bool, unsigned int, ceph::buffer::v15_2_0::list const&, ceph::buffer::v15_2_0::list*) in ceph-osd
6# crimson::net::ProtocolV2::_handle_auth_request(ceph::buffer::v15_2_0::list&, bool) in ceph-osd
7# 0x0000563F9D007B39 in ceph-osd
8# 0x0000563F9D008C45 in ceph-osd
9# 0x0000563F95FF8D70 in ceph-osd
10# 0x0000563FA1A560BF in ceph-osd
11# 0x0000563FA1A5B600 in ceph-osd
12# 0x0000563FA1C0D66B in ceph-osd
13# 0x0000563FA176B0EA in ceph-osd
14# 0x0000563FA177520E in ceph-osd
15# main in ceph-osd
16# __libc_start_main in /lib64/libc.so.6
17# _start in ceph-osd
Fault at location: 0xb0
```
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Daniel Gryniewicz [Wed, 9 Jun 2021 13:46:58 +0000 (09:46 -0400)]
Merge pull request #41761 from dang/wip-dang-setattrs
RGW - Don't move attrs before setting them
Sridhar Seshasayee [Wed, 9 Jun 2021 06:14:11 +0000 (11:44 +0530)]
qa/standalone: Use osd op queue = wpq in activate_osd()
This change is a follow-up to commit
b6e9c0903d5ad9a699b675f9fa7739e9cce9a5f3 that set the scheduler to wpq in
run_osd() and run_osd_filestore(). In addition, activate_osd() too has to
set the scheduler type to 'wpq' in order to be consistent and avoid test
failures.
The above is a temporary measure until all the standalone tests are
modified to run well with the mclock_scheduler.
Fixes: https://tracker.ceph.com/issues/51074
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
Pritha Srivastava [Mon, 7 Jun 2021 15:25:11 +0000 (20:55 +0530)]
rgw/sts: adding role name and role session to ops log.
Also adding authentication type for all ops.
Fixes: https://tracker.ceph.com/issues/51152
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Kefu Chai [Wed, 9 Jun 2021 09:03:05 +0000 (17:03 +0800)]
Merge pull request #41727 from yanqiang-ux/handle_error_ret_FillInVerifyExtent
osd: set r only if succeed in FillInVerifyExtent
Reviewed-by: Kefu Chai <kchai@redhat.com>
dengchl01 [Wed, 9 Jun 2021 08:59:51 +0000 (16:59 +0800)]
mgr/mgr_module:delete invalid judgment
Signed-off-by: dengchl01 <dengchl01@inspur.com>
yanqiang-ux [Mon, 7 Jun 2021 07:54:44 +0000 (15:54 +0800)]
osd: set r only if succeed in FillInVerifyExtent
When read failed, ret can be taken as data len in FillInVerifyExtent, which should be avoided.
It may cause errors in crc repair or retry read because of the data len. In my case, we use FillInVerifyExtent for EC read,
when meet -EIO,we will try crc repair, which need read data from other shard accrding to data len.
And I meet assert in ECBackend.cc (loc: line 2288 ceph_assert(range.first != range.second) ), But it seems master branch not support EC crc repair.
In shot, when reuse the readop may cause unpredictable error.
Fixes: https://tracker.ceph.com/issues/51115
Signed-off-by: yanqiang-ux <yanqiang_ux@163.com>
Kefu Chai [Wed, 9 Jun 2021 08:36:01 +0000 (16:36 +0800)]
Merge pull request #41718 from tchaikov/wip-doc-ci-deps
doc/dev: add continuous-integration
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Kefu Chai [Sun, 6 Jun 2021 10:22:06 +0000 (18:22 +0800)]
doc/dev: add continuous-integration
for noting down the architecture of our CI. and how we prepare
some of the build dependencies.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Ernesto Puerta [Wed, 9 Jun 2021 08:23:34 +0000 (10:23 +0200)]
Merge pull request #41123 from rhcs-dashboard/host-addr-and-labels
mgr/dashboard: Include Network address and labels on Host Creation form
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Ernesto Puerta [Wed, 9 Jun 2021 08:08:16 +0000 (10:08 +0200)]
Merge pull request #41548 from rhcs-dashboard/revert-npm
Revert "mgr/dashboard: Generate NPM dependencies manifest"
Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
jianglong01 [Tue, 8 Jun 2021 06:00:48 +0000 (14:00 +0800)]
mgr/cephadm: When create osd which include db, _create_daemon will be executed twice. So we should filter the db type
Signed-off-by: jianglong01 <jianglong01@qianxin.com>
J. Eric Ivancich [Tue, 8 Jun 2021 17:20:05 +0000 (13:20 -0400)]
Merge pull request #38135 from joke-lee/fix-list-parts-show-id-and-displayname
rgw: RGWListMultipart show Owner ID and DisplayName
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
J. Eric Ivancich [Tue, 8 Jun 2021 17:19:33 +0000 (13:19 -0400)]
Merge pull request #40975 from trociny/wip-50415
cls/rgw: look for plain entries in non-ascii plain namespace too
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
J. Eric Ivancich [Tue, 8 Jun 2021 17:19:16 +0000 (13:19 -0400)]
Merge pull request #41065 from pponnuvel/tracker_50554
rgw: Improve error message on email id reuse
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
J. Eric Ivancich [Tue, 8 Jun 2021 17:18:25 +0000 (13:18 -0400)]
Merge pull request #41678 from ivancich/wip-multipart-delete-marker
rgw: completion of multipart upload leaves delete marker
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Matt Benjamin mbenjamin@redhat.com
Daniel Gryniewicz [Tue, 8 Jun 2021 16:59:56 +0000 (12:59 -0400)]
RGW - Don't move attrs before setting them
Moving the attrs into s->bucket_attrs before setting them results in
setting empty attrs into the bucket. This means that reading them back
later gets empty attrs, which can cause a segfault.
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
zdover23 [Tue, 8 Jun 2021 16:14:25 +0000 (02:14 +1000)]
Merge pull request #41760 from zdover23/wip-doc-2021-06-09-dev-guide-reposotory-spelling
doc/dev: s/reposotory/repository/ (really)
Reviewed-by: Kefu Chai <kchai@redhat.com>
Zac Dover [Tue, 8 Jun 2021 15:57:13 +0000 (01:57 +1000)]
doc/dev: s/reposotory/repository/ (really)
This corrects the heinous misspelling described in the
substitution expression in the title. This misspelling is
all the more egregious because it appears in a title, and
therefore would be used to create links if it had not been
caught.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Ernesto Puerta [Tue, 8 Jun 2021 15:48:25 +0000 (17:48 +0200)]
Merge pull request #41523 from rhcs-dashboard/fix-50955-master
mgr/dashboard: introduce separate front-end component for API docs
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Kefu Chai [Tue, 8 Jun 2021 15:33:38 +0000 (23:33 +0800)]
Merge pull request #41703 from tchaikov/wip-options-mgr-mon
common/options: extract mgr and mon options out
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Tue, 8 Jun 2021 15:32:24 +0000 (23:32 +0800)]
Merge pull request #41444 from Daniel-Pivonka/cephadm-monitoring-ip-bind
mgr/cephadm: allow monitoring stack ip binding and custom ports
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Reviewed-by: Adam King <adking@redhat.com>
Kefu Chai [Tue, 8 Jun 2021 15:30:47 +0000 (23:30 +0800)]
Merge pull request #41555 from mgfritch/cephadm-pytest-bootstrap
cephadm: add bootstrap unit tests
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Kefu Chai [Tue, 8 Jun 2021 15:30:13 +0000 (23:30 +0800)]
Merge pull request #41567 from ybwang0211/listxattr
doc: Added the explanation of the 'listxattr <obj-name>' and 'getxattr <obj-name> attr' commands
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 8 Jun 2021 15:29:27 +0000 (23:29 +0800)]
Merge pull request #41724 from tchaikov/wip-cmdparse-cleanup
common/cmdparse: do not create temp string unless necessary
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Ernesto Puerta [Tue, 8 Jun 2021 15:12:36 +0000 (17:12 +0200)]
.github/labeler: add api-change label
To flag PRs changing the Ceph REST API. It might also work for another
APIs.
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
Ernesto Puerta [Tue, 8 Jun 2021 14:53:10 +0000 (16:53 +0200)]
Merge pull request #41656 from rhcs-dashboard/49885-fix-bucket-object-lock-fields
mgr/dashboard: simplify object locking fields in 'Bucket Creation' form
Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Kefu Chai [Tue, 8 Jun 2021 13:33:50 +0000 (21:33 +0800)]
Merge pull request #41743 from tchaikov/wip-rgw-lua-exception
rgw/rgw_lua_utils: return error using luaL_error()
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Kefu Chai [Tue, 8 Jun 2021 12:23:40 +0000 (20:23 +0800)]
Merge pull request #41689 from tchaikov/wip-vstart-restful
vstart.sh: disable restful by default
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Kefu Chai [Tue, 8 Jun 2021 11:40:38 +0000 (19:40 +0800)]
Merge pull request #41756 from rzarzynski/wip-crimson-monc-fix-races-in-on_session_opened
crimson/monc: fix races between on_session_opened() and the reset sequence
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 8 Jun 2021 11:11:35 +0000 (19:11 +0800)]
Merge pull request #41747 from dengchl01/dengchl01-commit
mgr/mgr_module: update docstring of MgrModule.get()
Reviewed-by: Kefu Chai <kchai@redhat.com>
Radoslaw Zarzynski [Tue, 8 Jun 2021 10:33:31 +0000 (10:33 +0000)]
crimson/monc: fix races between on_session_opened() and the reset sequence.
The `active_con` can get invalidated every single time when there is
a preemption point. This includes even the middle connection open
sequence as it's spread across multiple continuations!
Unfortunately, we don't check for `active_con` in the lambdas inside
the `on_session_opened()` method. That was the reason of the following
crash at Sepia [1]:
```
INFO 2021-06-08 09:36:23,992 [shard 0] monc - do_auth_single: connection closed
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/
17.0.0-4967-g96cdf983 /rpm/el8/BUILD/
ceph-17.0.0-4967-g96cdf983 /src/crimson/mon/MonClient.cc:399:10: runtime error: member access within null pointer of type 'struct Connection'
Segmentation fault on shard 0.
Backtrace:
0# 0x000055C3C1CA860F in ceph-osd
1# FatalSignal::signaled(int, siginfo_t const*) in ceph-osd
2# FatalSignal::install_oneshot_signal_handler<11>()::{lambda(int, siginfo_t*, void*)#1}::_FUN(int, siginfo_t*, void*) in ceph-osd
3# 0x00007FAAE1713B20 in /lib64/libpthread.so.0
4# crimson::mon::Connection::get_conn() in ceph-osd
5# 0x000055C3C2532DA8 in ceph-osd
6# 0x000055C3C2535CB5 in ceph-osd
7# 0x000055C3BBC9FC70 in ceph-osd
8# 0x000055C3C76FAE5F in ceph-osd
9# 0x000055C3C77003A0 in ceph-osd
10# 0x000055C3C78B240B in ceph-osd
11# 0x000055C3C740FE8A in ceph-osd
12# 0x000055C3C7419FAE in ceph-osd
13# main in ceph-osd
14# __libc_start_main in /lib64/libc.so.6
15# _start in ceph-osd
Fault at location: 0x98
```
[1]: http://pulpito.front.sepia.ceph.com/rzarzynski-2021-06-08_09:11:05-rados-master-distro-basic-smithi/
6159602
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>