Merge PR #38669 into master

* refs/pull/38669/head:
mds: fix typo in debug logs

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Varsha Rao <varao@redhat.com>

Merge pull request #38674 from mkogan1/rgw-fix-t48688

rgw: fix 'this->ondisk_version' will always evaluate to 'true'

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #38653 from dillaman/wip-48647

librbd: clear implicitly enabled feature bits when creating images

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #38670 from Rethan/doc-fix-max_part-description

doc/rbd-nbd: fix description for command rbd-nbd's parameter --max_part

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

rgw: fix 'this->ondisk_version' will always evaluate to 'true'

fix:
```
src/rgw/CMakeFiles/radosgw.dir/rgw_rest_metadata.cc.o
../src/rgw/rgw_rest_metadata.cc:267:13: warning: address of
'this->ondisk_version' will always evaluate to 'true'
[-Wpointer-bool-conversion]
                                       &ondisk_version);
```
Fixes: https://tracker.ceph.com/issues/48688
Signed-off-by: Mark Kogan <mkogan@redhat.com>

Merge pull request #38259 from rhcs-dashboard/fix-jwt-token

mgr/dashboard: Use secure cookies to store JWT Token

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/rbd-nbd: fix description for command rbd-nbd's parameter --max_part

The parameter --max_part should actually override module param max_part,
not as nbds_max as it said.

Signed-off-by: haoyixing <haoyixing@kuaishou.com>

mds: fix typo in debug logs

Signed-off-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #38573 from batrick/i48600

osd: remove invalid put on message

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38646 from xxhdx1985126/wip-crimson-bug-fix

crimson/osd: don't get recovery read lock in PGRecvery::on_local_recover()

Reviewed-by: Kefu Chai <kchai@redhat.com>

crimson/osd: make sure the read lock is acquired when trying to get recovery read

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>

crimson/osd: don't get recovery read lock in PGRecvery::on_local_recover()

Now we've changed drop_recovery_read to only care about the recovery_read flag, so
we shouldn't get read lock when acquiring recovery read, otherwise there would be
a chance in which the read lock can't get released

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>

Merge pull request #38291 from aserdean/windows_common_proccess_name

common: Add get_process_name implementation for Windows

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38630 from tchaikov/wip-crimson-cleanups

crimson/osd: cleanups to drop some do_with() calls

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #38522 from tchaikov/wip-mon-health-cleanup

mon/HealthMonitor: split large method into smaller ones and cleanups

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge PR #38579 into master

* refs/pull/38579/head:
mds: ensure dirfrags are fetched once
mds: refactor variable names

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #38540 into master

* refs/pull/38540/head:
client: support client oc's options can update at runtime

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #38495 into master

* refs/pull/38495/head:
doc: add documentation for new multifs feature
qa: update tests concerning setting of multifs
mon,mds: mark multifs stable

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>

librbd: drop explicit masking of implicit feature bits

Now that the create image state machine is handling the masking
of implicit features, all callers to the state machine can skip
the need to perform the masking themselves.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd/image: mask out all implicit features when creating an image

This will ensure that all paths to the create image state machine
properly handle this condition. Previously, it was up to the callers
of the state machine to clear the implicit feature bits.

Fixes: https://tracker.ceph.com/issues/48647
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd/image: use internal feature flag mask when creating images

When validating the provided features for an image, utilize the
RBD_FEATURES_INTERNAL flag instead of just RBD_FEATURE_OPERATION.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd/api: do not explicitly add the MIGRATION feature bit

This feature bit is automatically added to the source and destination
images via the cls method on the OSD.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #38613 from dillaman/wip-48522

librbd/api: avoid retrieving more than max mirror image info records

Reviewed-by: Mykola Golub <mgolub@suse.com>

mgr/dashboard: Use secure cookies to store JWT Token

This PR intends to store the jwt token in secure cookies instead of local storage

Fixes: https://tracker.ceph.com/issues/44591
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 36703c63381e6723fff57266235f8230e6af1d92)

Merge pull request #38643 from tchaikov/wip-doc-dev

doc/dev/generatedocs.rst: fix highlight syntax

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #38638 from idryomov/wip-krbd-stable-writes-attr

qa: krbd_stable_pages_required.sh: move to stable_writes attribute

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #38635 from ronen-fr/wip-ronenf-crimsclang-tree

crimson/seastore: fixing Clang errors and warnings

Merge pull request #38602 from dillaman/wip-48486

librbd: explicitly disable readahead for writearound cache

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #38645 from cyx1231st/wip-seastar-onode-tree-fix-clang-link

crimson/onode-staged-tree: fix explicit template instantiation for clang

common: Add get_process_name implementation for Windows

This patch adds get_process_name for Windows based on
GetModuleFileName.

Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>

crimson/onode-staged-tree: fix explicit template instantiation for clang

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

doc/dev/generatedocs.rst: fix highlight syntax

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38618 from neha-ojha/wip-14-2-16

doc/releases/nautilus.rst: add release notes for 14.2.16

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #38622 from neha-ojha/wip-15-2-8

doc/releases/octopus.rst: add release notes for 15.2.8

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #38351 from yuvalif/wip-yuval-fix-46128

rgw/notifications: automatically delete topics associated with a bucket

Merge pull request #38246 from yuvalif/wip-yuval-fix-48321

rgw/notifications: fix tag based filtering to work on all ops

Merge pull request #38190 from yuvalif/wip-yuvali-fix-48293

rgw/amqp/kafka: prevent concurrent shutdowns from happening

Merge pull request #37924 from yuvalif/allow_packages_in_lua

rgw/lua: support packages via luarocks

Merge pull request #38284 from rhcs-dashboard/48355-read-pwd-from-file

mgr/dashboard: CLI commands: read passwords from file

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: knortema <knortema@redhat.com>

Merge pull request #38473 from votdev/issue_48474_health_check

mgr/dashboard: Display a warning message in Dashboard when debug mode is enabled

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #38599 from tchaikov/wip-47977

ceph.in: try harder if asok path does not exist

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>

crimson/osd: do not repeat type name when constructing an instance

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: do not use __func__ in lambda

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #38447 into master

* refs/pull/38447/head:
ceph-volume: disable cache for blkid calls

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #38636 from ceph/fix-labeler-master

.github/labeler: fix yaml syntax

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38634 from tchaikov/wip-install-deps

install-deps.sh: do not install libboost-all-dev and nlohmann-json-dev

Reviewed-by: Josh Durgin <jdurgin@redat.com>

Merge pull request #38601 from linuxbox2/more-librgw-zipper9

More librgw zipper9

Merge pull request #23396 from linuxbox2/wip-rgw-xattrs-2

rgw_file:  expose RGW user-defined attributes

Merge pull request #37138 from lxbsz/iscsi_qa

qa: add ceph iscsi test suite support

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>

librbd/api: avoid retrieving more than max mirror image info records

This could otherwise result in an assertion failure in the API if
it failed to retrieve the status on an image and therefore required
a second iteration through the loop.

Fixes: https://tracker.ceph.com/issues/48522
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

qa: add ceph iscsi test suite support

Currently this only supports the gwcli tests on CentOS/RHEL 8 with
2 ceph iscsi gateways.

Fixes: https://tracker.ceph.com/issues/47439
Signed-off-by: Xiubo Li <xiubli@redhat.com>

qa: krbd_stable_pages_required.sh: move to stable_writes attribute

bdi/stable_pages_required attribute was deprecated in 5.10 and now
always returns 0.  The replacement is queue/stable_writes.  (It is
also writeable, so we can simplify these test cases somewhat in the
future.)

Fixes: https://tracker.ceph.com/issues/48232
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

qa/tasks: get the correct clone_dir for each client

The clone_dir will be overrided in the loop.

Fixes: https://tracker.ceph.com/issues/47439
Signed-off-by: Xiubo Li <xiubli@redhat.com>

qa/tasks: allow none client prefixed node to run the cram

Fixes: https://tracker.ceph.com/issues/47439
Signed-off-by: Xiubo Li <xiubli@redhat.com>

qa/tasks: fix not enough values to unpack value error

Fixes: https://tracker.ceph.com/issues/47439
Signed-off-by: Xiubo Li <xiubli@redhat.com>

crimson/seastore: fixing Clang errors and warnings

Errors: capturing structured-binding "special ref"

Warnings: unused captures

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

.github/labeler: fix yaml syntax

Introduced by https://github.com/ceph/ceph/pull/38617

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

crimson/osd: return plain value instead of future

seastar allows us to use plain value instead of a future<> when the
future is available right away.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: use move() to avoid memcpy()

try to move away from the returned map of xattrs.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: do not use a now() future if no shard to push

in that case, seastar::parallel_for_each() returns a
`make_ready_future<>()`, so no need to optimize for this case.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: extract push_func as a separate method

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: do not use do_with() for capturing target pg_shards

it's perfectly fine to check for empty, and pass it to
seastar::parallel_for_each().

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: do not use the parallel_for_each() in prep_push()

the caller of prep_push() also loops in target pg shards, so there is no
need to do the loop in prep_push(). in this change, prep_push() just
takes care of a single pg_shard for a single oid instead of collecting
all push ops for all pg_shards to be recovered.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: create the collected push ops use shared_ptr

do_with() uses a unique_ptr for keeping the captured variables alive. so
it is practically the same thing in concept. but `do_with()` is more
distracting and difficult to reason about, it increases the indent level
also.

so use a lw_shared_ptr() for collecting the push ops map.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: trade do_with() for plain code

no need to capture the intervals or the data in
`ReplicatedRecoveryBackend::_handle_push()`, they are passed to
`submit_push_data()` by value right after being initialized. so
move the content of `do_with()` block out into the caller.

also, restructure the code preparing the parameters for
`submit_push_data()` to match with the structure of with the code in
`ReplicatedRecoveryBackend::_handle_pull_response()` for better
readability.

Signed-off-by: Kefu Chai <kchai@redhat.com>

install-deps.sh: do not install nlohmann-json{3}?-dev

"mk-build-deps --install" should be able to take care of this.

Signed-off-by: Kefu Chai <kchai@redhat.com>

install-deps.sh: do not install libboost-all-dev for old distros

ubuntu disco and ubuntu focal do not ship libboost 1.72 and up, and
we depend on libboost 1.72 or up, so it does not help to install
liboost 1.67 or libboost 1.71 anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/BaseMgrModule: add optional inbuf param to ceph_send_command.

BaseMgrModule.cc: ceph_send_command: add inbuf param for handling input file content.

Fixes: https://tracker.ceph.com/issues/48355
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

mgr/dashboard: CLI commands: read passwords from file

Fixes: https://tracker.ceph.com/issues/48355
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>

Merge pull request #38617 from batrick/cmake-labeler

.github/labeler: add build/ops label

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38629 from changchengx/sudo_fix

install-deps.sh: install debian package with proper right

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #38464 into master

* refs/pull/38464/head:
mds/OpenFileTable: make the data length as long as possible for each op

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #38363 into master

* refs/pull/38363/head:
mds/OpenFileTable: enhance the log info
mds/OpenFileTable: add _read_omap_values() to simplify the code

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #38355 into master

* refs/pull/38355/head:
client: when STATX_NLINK is requested request FsLs caps
client: ensure we take Fs caps when querying dirstat vxattrs

Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge PR #38236 into master

* refs/pull/38236/head:
qa: forward scrubbing background task

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #38222 into master

* refs/pull/38222/head:
client: set CEPH_STAT_RSTAT mask for dir in readdir_r_cb

Reviewed-by: Jeff Layton <jlayton@redhat.com>

install-deps.sh: install debian package with proper right

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>

.github/labeler: add build/ops label

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #38624 from rzarzynski/wip-crimson-nopack-in-blocking_future

crimson/osd: drop arg packs from blocking_future.

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38450 from zdover23/wip-doc-dev-guide-basic-workflow-auto-pr-valid-dec-2020-1

doc/dev: update auto pr validation section

Reviewed-by: Josh Durgin <jdurgin@redat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #38600 from agayev/master

os/bluestore: Fix code rot in ZonedAllocator.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

ceph.in: try harder if asok path does not exist

when handling "ceph daemon <name> ...", we need to figure out the asok
path, if the "<name>" option is not a path but a "name" as it claims to
be. but if the "admin_socket" option includes substitution/meta variable of
"$pid", it will be expanded using its own pid, instead of the process
with the specified "name". but "ceph" cli does not offer a dedicated
option for overriding the pid for ceph-conf which is used "ceph" cli to
retrieve the "admin_socket" option with specified "name".

in this change, "<name>" option is interpreted as "${name}.${pid}" if
the returned admin_socket path does not point to a valid UNIX domain
socket file. and "ceph" cli will try harder by passing "--pid ${pid}"
and "--name ${name}" instead of "--name ${name}.${pid}" to ceph-conf.

Fixes: https://tracker.ceph.com/issues/47977
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38609 from ideepika/fix-yaml-failure

cmake: fix build failure due to yaml-cpp not available

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38608 from tchaikov/wip-crimson-build

rpm,deb: conditionally package crimson-store-nbd in ceph-test

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #38578 from cyx1231st/wip-seastar-onode-tree-fix-stage-type

crimson/onode-staged-tree: fix match_stage_t related compile issue

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38625 from batrick/tox-fix

qa: fix tox failures

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

qa: fix tox failures

Fixes: c6121e48ecb7224e5addf4b5fdeb64907a8d8683
Fixes: https://tracker.ceph.com/issues/48633
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

crimson/osd: drop arg packs from blocking_future.

This feature is not necessary as the `seastar::feature` lost
the support for `T...`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

doc/releases/octopus.rst: add release notes for 15.2.8

Signed-off-by: Neha Ojha <nojha@redhat.com>

doc/releases/nautilus.rst: add release notes for 14.2.16

Signed-off-by: Neha Ojha <nojha@redhat.com>

Merge pull request #38548 from rhcs-dashboard/wip-48570-master

github: add action to manage needs-rebase label

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge branch 'CVE-2020-27781' into master

* CVE-2020-27781:
  tasks/cephfs/test_volume_client: Add tests for authorize/deauthorize
  pybind/ceph_volume_client: Optionally authorize existing auth-ids
  pybind/ceph_volume_client: Preserve existing caps while authorize/deauthorize auth-id
  pybind/ceph_volume_client: Disallow authorize auth_id

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>

rgw_file: correct initialization of RGWWriteRequest

The legacy call to init_from_header() in RGWWriteRequest()
conflicted with initialization via ::init()

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

rgw_file: fix librgw_file_gp unit test and driver

Fixes missing commit after rgw_write(), as well as conditional
cleanup.

Reorder tests, and split out librgw_file_gp --delete to avoid an
issue w/sysobj cache (temporary).

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

rgw_file: fix zipper crash(es) in RGWCopyObj

Instantiate zipper object and bucket handles when called from
rgw_rename().

The current change appears potentially valid, but also suggests
topics for further discussion:

1. redundant object and bucket vars (in req_state and RGWOp)
2. semantic implications std::unique_ptr (e.g., redundant handle
   forks)

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #38580 from anthonyeleven/anthonyeleven/48301-underscores

doc: standardize config option names with interstitial underscores

Reviewed-by: Zac Dover <zac.dover@gmail.com>

crimson/onode-staged-tree: comment out excessive range checks

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

doc/dev: update auto pr validation section

This commit updates the "Automated PR Validation"
section of the "Basic Workflow" page in the
Developer Guide. This is part of a project that
aims to clean all of the sentences currently extant
in the Dev Guide, prior to a slight reorganization
of that guide for the sake of clarity and simplicity.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

os/bluestore: Fix code rot in ZonedAllocator.

Signed-off-by: Abutalib Aghayev <agayev@psu.edu>

mgr/dashboard: Display a warning message in Dashboard when debug mode is enabled

Set a health check warning if debug mode is enabled.

Fixes: https://tracker.ceph.com/issues/48475
Signed-off-by: Volker Theile <vtheile@suse.com>