Merge pull request #46814 from idryomov/wip-rbd-mirror-remote-not-primary-quincy

quincy: rbd-mirror: generally skip replay/resync if remote image is not primary

Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #46742 from mkogan1/backport-quincy-t54363

quincy: rgwlc: fix segfault resharding during lc

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #46625 from cfsnyder/wip-55997-quincy

quincy: rgw: reopen ops log file on sighup

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #46781 from idryomov/wip-rbd-schedule-backports-quincy

quincy: mirror snapshot schedule and trash purge schedule fixes

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>

Merge pull request #46624 from cfsnyder/wip-55999-quincy

quincy: rgw: log access key id in ops logs

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #46598 from idryomov/wip-qa-rwl-on-tmpfs-quincy

quincy: qa/suites/rbd: place cache file on tmpfs for xfstests

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #46594 from idryomov/wip-rbd-unlink-newest-snap-at-capacity-quincy

quincy: librbd: unlink newest mirror snapshot when at capacity, bump capacity

Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>

Merge pull request #46591 from idryomov/wip-rbd-preserve-non-primary-snap-quincy

quincy: rbd-mirror: don't prune non-primary snapshot when restarting delta sync

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>

Merge pull request #46801 from lxbsz/wip-56106

quincy: qa: wait rank 0 to become up:active state before mounting fuse client

Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #46800 from lxbsz/wip-56109

quincy: client: choose auth MDS for getxattr with the Xs caps

Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #46697 from NitzanMordhai/wip-54282-quincy

quincy: pybind/mgr: ceph osd status crash with ZeroDivisionError

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #46681 from lxbsz/wip-56015

Quincy: mds: clear MDCache::rejoin_*_q queues before recovering file inodes

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #46680 from lxbsz/wip-55994

Quincy: client: switch AT_NO_ATTR_SYNC to AT_STATX_DONT_SYNC

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>

Merge pull request #46595 from kotreshhr/wip-55926-quincy

quincy: client/fuse: Fix directory DACs overriding for root

Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #46566 from vshankar/tr-55933

quincy: mds: do not assert early on when issuing client leases

Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #46558 from lxbsz/wip-55934

Quincy:  client: always return ESTALE directly in handle_reply

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #47102 from adk3798/quincy-osd-removal-docs-update

quincy: doc/cephadm: add note about OSDs being recreated to OSD removal section

Reviewed-by: <Anthony D'Atri anthonyeleven@users.noreply.github.com>

doc/cephadm: add note about OSDs being recreated to OSD removal section

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit d4a39cd046b93cb7bb5b7ce0311139d9f6552802)

Merge pull request #47077 from adk3798/wip-56159-quincy

quincy: doc/cephadm: Add post-upgrade section

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #47076 from adk3798/wip-56171-quincy

quincy: doc/cephadm: document the new per-fsid cephadm conf location

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #47074 from adk3798/wip-56437-quincy

quincy: doc/cephadm: enhancing daemon operations documentation

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #47068 from adk3798/wip-56505-quincy

quincy: doc/cephadm/services: the config section of service specs

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

doc/cephadm: Add post-upgrade section
Fixes: https://tracker.ceph.com/issues/54474
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 49b234ae744dd3a2afc130d9c215f4f00c1ee4b8)

doc/cephadm: document the new per-fsid cephadm conf location
Fixes: https://tracker.ceph.com/issues/55357
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 443f93e95d8068a31526730da0febd692b87b7a5)

doc/cephadm: enhancing daemon operations documentation
Fixes: https://tracker.ceph.com/issues/54399
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit df1aaacb7d09322528e42ae90c0d98793e9c254e)

doc/cephadm/services: the config section of service specs
Fixes: https://tracker.ceph.com/issues/53997
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit b67bd50a3bb1233973586c4c2eabfb934db2e818)

Merge pull request #46915 from cbodley/wip-55495

quincy: rgw/dbstore: Fix build errors on centos9

Merge pull request #47048 from zdover23/wip-doc-2022-07-12-backport-47045-to-quincy

quincy: doc/dev: s/github/GitHub/ in essentials.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #47051 from zdover23/wip-doc-2022-07-12-backport-47031-to-quincy

quincy: doc/dev: edit delayed-delete.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/dev: s/github/GitHub/ in essentials.rst

This addresses a typo that Anthony D'Atri pointed out in
PR#47032. It didn't get addressed there, so it's being
addressed here.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit f7581e05b08d6ab55446088b0fb9f29b1dd6441b)

doc/dev: edit delayed-delete.rst

This PR improves the English in the "CephFS Delayed
Deletion" chapter of the Ceph Internals Guide (which
is stored in the doc/dev/ directory).

There was no pressing need to rewrite this. I just saw
that it could be tightened up, and I had the fifteen
minutes I needed to do it.

Co-author: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit c186c5ec6cb2ea1999cb14500aaa64d6aa72dddd)

Merge pull request #47042 from zdover23/wip-doc-2022-07-12-backport-47032-to-quincy

quincy: doc/dev: add Dependabot section to essentials.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

doc/dev: add Dependabot section to essentials.rst

This PR adds a section to the Developer Guide chapter
"Essentials" that explains what Dependabot is. This
section is adapted from an email from Ernesto Puerta
to the CLT that was sent on 08 Jul 2022.

Co-authored-by: Ernesto Puerta <epuertat@redhat.com>>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 2711e8de80edea121503e022cca37683f8abdfa9)

Merge pull request #47007 from rhcs-dashboard/wip-56126-quincy

quincy: mgr/dashboard: display helpfull message when the iframe-embedded Grafana dashboard failed to load

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: nSedrickm <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #46990 from aaSharma14/wip-56481-quincy

quincy: mgr/dashboard: Improve monitoring tabs content

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #46790 from adk3798/wip-55951-quincy

quincy: cephadm: preserve cephadm user during RPM upgrade

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #46339 from zdover23/wip-doc-pr-45209-backport-quincy

quincy: doc/start: alphabetize hardware-recs links

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #46548 from MrFreezeex/wip-55653-quincy

quincy: ceph-mixin: backport of recent cleanups

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

mgr/dashboard: Dashboard should display some helpful (error) message when the iframe-embedded Grafana dashboard failed to load

This commit adds checks for successful grafana panel loads before displaying dashboards and informs the user if the request is blocked by the browser
Fixes: https://tracker.ceph.com/issues/54206
Signed-off-by: Ngwa Sedrick Meh <nsedrick101@gmail.com>
(cherry picked from commit a4b66efb2a2139bd88a6a088af9bd5e079e46105)

Merge pull request #46935 from zdover23/wip-doc-2022-06-30-backport-46906-to-quincy

quincy: doc/dev: s/the the/the/ in basic-workflow.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

mgr/dashboard: Improve column spacing in alerts tab

This PR intends to fix the column spacing in the alert list in the alerts tab

Fixes:https://tracker.ceph.com/issues/56165
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit d60ca04c965446cfde20a0b7bfdd76393815c1bb)

mds: clear the recover and check queues in front of identify_files_to_recover()

If the monitor sends rejoin mdsmap twice just before the first time
hasn't finished yet, it may run identify_files_to_recover() twice.
Since the rejoin_recover_q and rejoin_check_q were vector so there
could be duplicated inodes.

Fixes: https://tracker.ceph.com/issues/53741
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit d82bdd8e4255585512a963c87c8300be8dc26420)

Merge pull request #46946 from aaSharma14/wip-56451-quincy

quincy: doc: update docs for centralized logging

Reviewed-by: anthonyeleven <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #46532 from rhcs-dashboard/wip-55753-quincy

quincy: mgr/dashboard: rbd-mirror batch backport

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Sarthak Gupta <sarthak.dev.0702@gmail.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: melissa-kun-li <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>

doc: update docs for centralized logging

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 4ac2a3e5f764dae9315358d11d7b00e9a08610b1)

Merge pull request #46940 from zdover23/wip-doc-2022-07-03-backport-46938-to-quincy

quincy: doc/dev: add IRC registration instructions

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/dev: add IRC registration instructions

This PR adds to the Developer Guide a link to the OFTC's IRC nick
registration instructions.

(cherry picked from commit 893e68a8f57b22cc025c82586ad0b42da2a6477c)

doc/dev: s/the the/the/ in basic-workflow.rst

This PR does exactly what it says: it changes a "the the"
to a "the".

I'd like to thank Josh Soref for bringing this
to my attention.

(cherry picked from commit 326034807d58fe6569851c043f71a222f59cde5e)

Merge pull request #46792 from adk3798/wip-55992-quincy

quincy: python-common: allow crush device class to be set from osd service spec

Reviewed-by: Cory Snyder <csnyder@iland.com>

Merge pull request #46871 from rhcs-dashboard/wip-56119-quincy

quincy: mgr/dashboard: iterate through copy of items

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

rgw/dbstore: Fix build errors on centos9

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
(cherry picked from commit fc1008a15bc9f7c37330e613f7c81680bc5605fc)

Merge pull request #46819 from rhcs-dashboard/wip-iops-quincy

quincy: mgr/dashboard: iops optimized option enabled

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #46900 from ceph/46773-quincy

install-deps.sh: do not install libpmem from chacra

Merge pull request #46904 from zdover23/wip-doc-2022-06-30-backport-46984-to-quincy

quincy: doc/index.rst: add link to Dev Guide basic workfl.

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/index.rst: add link to Dev Guide basic workfl.

This PR adds a link to the "Basic Workflow" section of the
Developer Guide on the landing page of docs.ceph.com.

This PR is meant to improve the documentation for developers
new to Ceph and to guide them to instructions that will allow
them to become full-fledged contributors to the Ceph project
as quickly as possible.

The "Basic Workflow" page of the Developer Guide contains
information that answers almost all of the questions that I had
about contributing to the Ceph project when I was new to it,
and I am finally acting on my long-held conviction that the
"Basic Workflow" page of the Developer Guide should have a more
prominent position in the documentation suite than it has had.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit c624a2a8ef71035eef34ee866ef7668f83a139e7)

install-deps.sh: do not install libpmem from chacra

this change reverts 17d2bc3707bb0078e2fa1b4eef31b39804e45135, before
we recreate a chacra repo hosting libpmem packages, we are not able
to query the repo from shaman or pull the dependencies from chacra.

in future, we should be able to get the libpmem dependencies from
offical ubuntu package repo and fedora, CentOS Stream and RHEL repos.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit fbfb369722fe9f92ad333f8368095637c36c10ec)

Merge pull request #46807 from aaSharma14/wip-56156-quincy

quincy: mgr/dashboard: Add daemon logs tab to Logs component

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #46718 from rhcs-dashboard/wip-56076-quincy

quincy: mgr/dashboard: bump moment from 2.29.1 to 2.29.3 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

mgr/dashboard: iterate through copy of items

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit f6de56a02c4f1db557211621f1a369e3f8cff615)

mgr/dashboard: rbd image primary ui

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

mgr/dashboard: fix linting issues

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

mgr/dashboard: Error page cleanup

Some error page cleanups

Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: configure rbd mirroring

One-click button in the case of an orch cluster for configuring the
rbd-mirroring when its not properly setup. This button will create an
rbd-mirror service and also an rbd labelled pool(replicated: size-3) (if they are not
existing)

Fixes: https://tracker.ceph.com/issues/55646
Signed-off-by: Nizamudeen A <nia@redhat.com>
 Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/core/error/error.component.html
src/pybind/mgr/dashboard/frontend/src/app/shared/services/module-status-guard.service.ts

This commits had minor conflicts where the addition of dashboardButton
had to be explicitly added and the state of api/orch/status in
module-status-guard had to be updated.

mgr/dashboard: add rbd status endpoint

Show "No RBD pools available" error page when accessing block/rbd if there are no rbd pools.
Add a "button_name" and "button_route" property to `ModuleStatusGuardService` config to customize the button on the error page.
Modify `ModuleStatusGuardService` to execute API calls to `/ui-api/<uiApiPath>/status` which uses the `UIRouter`.

Fixes: https://tracker.ceph.com/issues/42109
Signed-off-by: Melissa Li <melissali@redhat.com>
(cherry picked from commit 6ac9b3cfe171a8902454ea907b3ba37d83eda3dc)

Merge pull request #46528 from rhcs-dashboard/wip-54624-quincy

quincy: mgr/dashboard: BDD approach for the dashboard cephadm e2e

Reviewed-by: Sarthak Gupta <sarthak.dev.0702@gmail.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #46672 from rhcs-dashboard/wip-56037-quincy

quincy: mgr/dashboard: stop polling when page is not visible

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

mgr/dashboard: improve edit site name action in rbd-mirroring

Fixes: https://tracker.ceph.com/issues/55896
Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: rbd force resync from fornt-end

Signed-off-by: Sarthak0702 <sarthak.dev.0702@gmail.com>

mgr/dashboard: fix mirroring e2e and lint errors

Signed-off-by: Avan Thakkar <athakkar@redhat.com>

mgr/dashboard: add byte info, move state, add idle state

Idle substate added from snapshot mode.
Instead of seconds info we display bytes and entries info.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

mgr/dashboard: move replaying images to Syncing tab

Images with 'Replaying' state will be displayed in Syncing tab. syncTmpl
removed as it was unnecessary if sate is provided from the backend.

Replaying images in contrast of Syncing images don't have a progress
percentage, nevertheless, we have an approximation of how much time left
there is until the image is fully synced. Therefore, we can use seconds_until_synced to represent the progress.

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

mgr/dashboard: snapshot mirroring from dashboard

Enable snapshot mirroring from the Pools -> Image

Also show the mirror-snapshot in the image where snapshot is enabled

When parsing images if an image has the snapshot mode enabled, it will
try to  run commands that don't work with that mode. The solution was
not running those for now and appending the mode in the get call.

Fixes: https://tracker.ceph.com/issues/55648
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Signed-off-by: Nizamudeen A <nia@redhat.com>
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 489a385a95d6ffa5dbd4c5f9c53c1f80ea179142)

mgr/dashboard: expose image mirroring commands as endpoints

Expose:
  - enable/disable mirroring in image
  - promote/demote (primary and non-primary)
  - resync
  - snapshot mode:
    - mirror image snapshot (manual snapshot)
    - schedule

Fixes: https://tracker.ceph.com/issues/55645
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
(cherry picked from commit 8bd89415fe340512f457acd58225934e9ed8e4e1)

Merge pull request #46789 from adk3798/wip-55949-quincy

quincy: mgr/cephadm: check if a service exists before trying to restart it

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #46793 from adk3798/wip-56044-quincy

quincy: mgr/cephadm: try to get FQDN for active instance

Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #46728 from guits/wip-56085-quincy

quincy: ceph-volume: do not log sensitive details

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #46730 from guits/wip-56039-quincy

quincy: ceph-volume: make is_valid() optional

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #46794 from adk3798/wip-56069-quincy

quincy: mgr/nfs: validate virtual_ip parameter

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #46809 from rhcs-dashboard/wip-56163-quincy

quincy: mgr/dashboard: dashboard help command showing wrong syntax for login-banner

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #46818 from zdover23/wip-doc-2022-06-23-backport-46769-quincy-dev-guide-command-context

quincy: doc/dev: add context note to dev guide config

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #46070 from guits/wip-55480-quincy

quincy: ceph-volume: only warn when config file isn't found

ceph-volume: make is_valid() optional

There are cases where `ceph-volume` doesn't have to require
a `ceph.conf` file that has the `fsid` parameter.

See: https://github.com/rook/rook/pull/10333#pullrequestreview-994958873

Fixes: https://tracker.ceph.com/issues/55970
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 7ffea899921dc9996f20ef88531bd1daf82d44aa)

ceph-volume: do not print the secret of osd keyring

during osd preparation, ceph-volume logs the secret of the osd keyring to file
```
[2022-06-15 12:31:17,466][ceph_volume.process][INFO  ] Running command: /usr/bin/ceph-authtool /var/lib/ceph/osd/ceph-0/keyring --create-keyring --name osd.0 --add-key AQAM0aliR5JvDRAAQBu0stWl9ZhZrcjijg2BIQ==
[2022-06-15 12:31:17,481][ceph_volume.process][INFO  ] stdout creating /var/lib/ceph/osd/ceph-0/keyring
added entity osd.0 auth(key=AQAM0aliR5JvDRAAQBu0stWl9ZhZrcjijg2BIQ==)
```

This shouldn't be logged nor printed on terminal.

Fixes: https://tracker.ceph.com/issues/56071
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 4b9cc6b303588e0c44443debe4f04c6160adf5a2)

ceph-volume: do not print luks key encryption

During osd activation, ceph-volume logs the luks key to its log file.

```
[2022-06-15 12:50:35,180][ceph_volume.process][INFO  ] Running command: /usr/bin/ceph --cluster ceph --name client.osd-lockbox.51d0770d-403d-4f81-93e6-e99f627f246c --keyring /var/lib/ceph/osd/ceph-0/lockbox.keyring config-key get dm-crypt/osd/51d0770d-403d-4f81-93e6-e99f627f246c/luks
[2022-06-15 12:50:35,522][ceph_volume.process][INFO  ] stdout ut9NjMK6YtMh1BLMJZ/mE2A7zTNyrp9pW1kHV8F2ipfz1BIX9MkEWhdYB2Azm1JPZ1d7ahIjBMUbrC/Iqqr2jQhP3MIsDzUYj1enw+sw7LeVvGPf0qNUdKmEGu5tUmvtQ+5pbk4T/9PF36kT6vCHKfNML/3fL6nnY8FDySrI4LY=
[2022-06-15 12:50:35,522][ceph_volume.process][INFO  ] Running command: /usr/sbin/cryptsetup --key-size 512 --key-file - --allow-discards luksOpen /dev/ceph-83c307d3-710b-4197-8ecd-0484e17395e3/osd-block-51d0770d-403d-4f81-93e6-e99f627f246c a9HhDO-MiYD-DtYm-SKJf-nO1d-5O3u-FmcCrd
```

Fixes: https://tracker.ceph.com/issues/56066
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 0d97a93faae431f1197d72ee3c4347387f6b1c73)

mgr/dashboard: save mgr logs inside a folder on kcli e2e

Save the mgr container logs of cephadm inside a folder and later on
archive it and get it as an artifact on the cephadm dashboard e2e jobs

Fixes: https://tracker.ceph.com/issues/55247
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit d74defbbb3282f056e26619ecd65fc63216f2f59)

Merge pull request #46551 from guits/bkp-quincy-46481

quincy: backport of cephadm: fix osd adoption with custom cluster name

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #46569 from guits/wip-55943-quincy

quincy: cephadm: add 'is_paused' field in orch status output

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #46714 from guits/wip-56041-quincy

quincy: cephadm: change default keepalived/haproxy container images

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #46783 from adk3798/wip-55947-quincy

quincy: mgr/cephadm: capture exception when not able to list upgrade tags

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #46791 from adk3798/wip-55988-quincy

quincy: mgr/cephadm: store device info separately from rest of host cache

Reviewed-by: Redouane Kachach <rkachach@redhat.com>

mgr/dashboard: iops optimized option enabled

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

doc/dev: add context note to dev guide config

This PR adds a note directing first-time cloners of
their Ceph git forks to make sure to cd into the ceph/
directory before trying to run the "git config" commands.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
(cherry picked from commit 3e6bcd7f0be2d0f896146c563a3381c9b7ea0e83)

rbd-mirror: spell out "remote image is not primary" status correctly

There is a difference: non-primary means NON_PRIMARY promotion state,
while "not primary" can refer to any of NON_PRIMARY, ORPHAN or UNKNOWN
promotion states.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 2bd2050909f22980b113870f17a50e2efbe02ac7)

rbd-mirror: fix up "error preparing image for replay" messages

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 8ce97c8cb72a0049009caae69bc2e6c8b36ecbee)

rbd-mirror: fix up PrepareReplayDisconnected test case

It was botched in commit 2bca9ee96c65 ("rbd-mirror: consolidate
prepare local/remote image steps to bootstrap") and went unnoticed
because currently no special handling is needed for disconnected
clients -- is_disconnected() check happens to be the last step
and it doesn't generate an error.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit b6d6a2737ebb8c131d929bca6d39a0b15c67755e)

rbd-mirror: drop m_remote_promotion_state from PrepareReplayRequest

Now unused (and if it was used, the entire StateBuilder is passed in
anyway).

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit adf7f1ee2ef70ca3e728f2c5619668dc38216edf)

rbd-mirror: generally skip replay/resync if remote image is not primary

Replay and resync should generally be skipped if the remote image is
not primary.

If this is not done for replay, snapshot-based mirroring can run into
a livelock if the primary image is demoted while a mirror snapshot is
being synced.  On the demote site, rbd-mirror would pick up the just
demoted image, grab the exclusive lock on it and idle waiting for a new
mirror snapshot to be created.  On the (still) non-primary site,
rbd-mirror would eventually finish syncing that mirror snapshot and
attempt to unlink from it on the demote site.  These attempts would
fail with EROFS due to exclusive lock being held in the "refuse proxied
maintenance operations" mode, blocking forward progress (syncing of the
demotion snapshot so that the non-primary image can be orderly promoted
to primary, etc).

If this is not done for resync, data loss can ensue as the just demoted
image would be immediately trashed, underneath the non-primary site that
is still syncing.

Currently this is done in PrepareReplayRequest only for journal-based
mirroring.  Note that it is conditional: if the local image is linked
to the remote image, proceeding is desirable.

Generalize this check, consolidate it with a related check in
PrepareRemoteImageRequest and move the result to BootstrapRequest to
cover both "local image does not exist" and "local image is unlinked"
cases for both modes.

Fixes: https://tracker.ceph.com/issues/54448
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 79d28e63cb47e9bacbb2fd8a5ddc3a092377731b)

rbd-mirror: strengthen is_local_primary() and is_linked()

Initialize local_promotion_state and remote_promotion_state to UNKNOWN
instead of counterintuitive PRIMARY and NON_PRIMARY -- half the time the
final values are flipped.  Then is_local_primary() and is_linked() can
be strengthened as a non-existent image should stay in UNKNOWN.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit c60f1d5813c7fe248593731bbffb43d12cdd3b62)

mgr/dashboard: dashboard help command showing wrong syntax for login-banner

Signed-off-by: Sarthak0702 <sarthak.dev.0702@gmail.com>
(cherry picked from commit 826741f192e754ed32b1636b06b9939efa5c5226)

Merge pull request #46686 from rhcs-dashboard/wip-55942-quincy

quincy: mgr/dashboard: Feature 54330 osd creation workflow

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>