]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/log
rocksdb.git
9 years agoFix deadlock when calling getMergedHistogram rocksdb-4.13 v4.13
Changli Gao [Mon, 21 Nov 2016 02:14:33 +0000 (18:14 -0800)]
Fix deadlock when calling getMergedHistogram

Summary:
When calling StatisticsImpl::HistogramInfo::getMergedHistogram(), if
there is a dying thread, which is calling
ThreadLocalPtr::StaticMeta::OnThreadExit() to merge its thread values to
HistogramInfo, deadlock will occur. Because the former try to hold
merge_lock then ThreadMeta::mutex_, but the later try to hold
ThreadMeta::mutex_ then merge_lock. In short, the locking order isn't
the same.

This patch addressed this issue by releasing merge_lock before folding
thread values.
Closes https://github.com/facebook/rocksdb/pull/1552

Differential Revision: D4211942

Pulled By: ajkr

fbshipit-source-id: ef89bcb

9 years agoRemove Ticker::SEQUENCE_NUMBER
Yi Wu [Thu, 17 Nov 2016 06:34:18 +0000 (22:34 -0800)]
Remove Ticker::SEQUENCE_NUMBER

Summary:
Remove the ticker count because:
* Having to reset the ticker count in WriteImpl is ineffiecent;
* It doesn't make sense to have it as a ticker count if multiple db
  instance share a statistics object.
Closes https://github.com/facebook/rocksdb/pull/1531

Differential Revision: D4194442

Pulled By: yiwu-arbug

fbshipit-source-id: e2110a9

9 years agoBumb version to 4.13.4
Islam AbdelRahman [Fri, 9 Dec 2016 03:06:47 +0000 (19:06 -0800)]
Bumb version to 4.13.4

9 years agoUse skiplist rep for range tombstone memtable
Andrew Kryczka [Thu, 27 Oct 2016 17:07:28 +0000 (10:07 -0700)]
Use skiplist rep for range tombstone memtable

Summary: somehow missed committing this update in D62217

Test Plan: make check

Reviewers: sdong

Reviewed By: sdong

Subscribers: andrewkr, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D65361

9 years agoKill flashcache code in RocksDB
Igor Canadi [Thu, 1 Dec 2016 18:00:56 +0000 (10:00 -0800)]
Kill flashcache code in RocksDB

Summary:
Now that we have userspace persisted cache, we don't need flashcache anymore.
Closes https://github.com/facebook/rocksdb/pull/1588

Differential Revision: D4245114

Pulled By: igorcanadi

fbshipit-source-id: e2c1c72

9 years agoFix implicit conversion between int64_t to int
Islam AbdelRahman [Tue, 29 Nov 2016 18:40:31 +0000 (10:40 -0800)]
Fix implicit conversion between int64_t to int

Summary:
Make conversion explicit, implicit conversion breaks the build
Closes https://github.com/facebook/rocksdb/pull/1589

Differential Revision: D4245158

Pulled By: IslamAbdelRahman

fbshipit-source-id: aaec00d

9 years agoBumb version to 4.13.3
Islam AbdelRahman [Tue, 29 Nov 2016 02:49:33 +0000 (18:49 -0800)]
Bumb version to 4.13.3

9 years agoAvoid intentional overflow in GetL0ThresholdSpeedupCompaction
Islam AbdelRahman [Tue, 29 Nov 2016 02:25:27 +0000 (18:25 -0800)]
Avoid intentional overflow in GetL0ThresholdSpeedupCompaction

Summary:
https://github.com/facebook/rocksdb/commit/99c052a34f93d119b75eccdcd489ecd581d48ee9 fixes integer overflow in GetL0ThresholdSpeedupCompaction() by checking if int become -ve.
UBSAN will complain about that since this is still an overflow, we can fix the issue by simply using int64_t
Closes https://github.com/facebook/rocksdb/pull/1582

Differential Revision: D4241525

Pulled By: IslamAbdelRahman

fbshipit-source-id: b3ae21f

9 years agodisable UBSAN for functions with intentional -ve shift / overflow
Islam AbdelRahman [Tue, 29 Nov 2016 01:46:35 +0000 (17:46 -0800)]
disable UBSAN for functions with intentional -ve shift / overflow

Summary:
disable UBSAN for functions with intentional left shift on -ve number / overflow

These functions are
rocksdb:: Hash
FixedLengthColBufEncoder::Append
FaultInjectionTest:: Key
Closes https://github.com/facebook/rocksdb/pull/1577

Differential Revision: D4240801

Pulled By: IslamAbdelRahman

fbshipit-source-id: 3e1caf6

9 years agoFix integer overflow in GetL0ThresholdSpeedupCompaction (#1378)
Edouard A [Mon, 24 Oct 2016 01:43:29 +0000 (18:43 -0700)]
Fix integer overflow in GetL0ThresholdSpeedupCompaction (#1378)