log/LogClock: render timestamp in ISO 8601 format

Signed-off-by: Sage Weil <sage@redhat.com>

common/ceph_time: stringify in ISO 8601 format

Signed-off-by: Sage Weil <sage@redhat.com>

unittest_utime: add tests

Signed-off-by: Sage Weil <sage@redhat.com>

common/utime: make parse() handle (our) ISO 8601 output

- optional subsecond values
- optional timezone offset

Signed-off-by: Sage Weil <sage@redhat.com>

include/utime: make default string rendering ISO 8601 conformant

- use T separator
- include TZ offset

Signed-off-by: Sage Weil <sage@redhat.com>

include/utime: remove unused s[n]printf methods

Signed-off-by: Sage Weil <sage@redhat.com>

include/utime: make gmtime() output conformant ISO 8601

Use 'T' separated instead of ' '.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #28271 from yuriw/wip-yuriw-crontab-master

qa/tests: removed filters for client-upgrade-* suites

Merge pull request #28170 from marxin/disable-lto-in-spec-file

rpm: Disable LTO in spec when being used.

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>

mgr/dashboard: Fix NFS clients squash/access_type default values (#28235)

mgr/dashboard: Fix NFS clients squash/access_type default values

Reviewed-by: Ricardo Marques <rimarques@suse.com>

Merge pull request #28211 from tspmelo/wip-service-root

mgr/dashboard: Change the provider of services to root

Merge pull request #28118 from tspmelo/wip-on-push

mgr/dashboard: Reduce the number of renders on the tables

mgr/dashboard: Add multi root support in CRUSH map (#28047)

mgr/dashboard: Add multi root support in CRUSH map

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #28179 from trociny/wip-39980

rbd-mirror: don't overwrite status error returned by replay

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #28240 from trociny/wip-journal-overflow

journal: optimize object overflow detection

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #28275 from tchaikov/wip-cmake-asan

ceph.in: do not preload libasan if it is found

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #28269 from NTmatter/patch-1

install-deps.sh: fix typo for krb5 on FreeBSD

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #27978 from votdev/add_snmp_oids_to_prometheus_alerts

monitoring: SNMP OID per every Prometheus alert rule

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>

Merge pull request #28225 from sebastian-philipp/script-run-mypy-sort-groups

script/run_mypy: Sort groups

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>

rpm: Disable LTO in spec when being used

Fixes: http://tracker.ceph.com/issues/39974
Works around: https://tracker.ceph.com/issues/40060

Signed-off-by: Martin Liška <Martin.Liska@suse.com>

Merge pull request #28002 from smithfarm/wip-39323-ext

pybind/tox: handle possible WITH_PYTHON3 values other than "3"

Reviewed-by: Stephan Müller <smueller@suse.com>

mgr/dashboard: Change the provider of services to root

It looks like that even if we provide a service only in 1 module, there are
still situations where angular will create multiple instances of that service.

By setting root as its providers, this no longer happens.

Fixes: http://tracker.ceph.com/issues/39996
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Use serial RGW Admin OPS API calls (#28223)

mgr/dashboard: Use serial RGW Admin OPS API calls

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #28174 from votdev/issue_39964

mgr/dashboard: Fix RGW user/bucket quota issues

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #28168 from votdev/fix_create_key_title

mgr/dashboard: Display correct dialog title

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: PG scrub configuration (#27072)

mgr/dashboard: PG scrub configuration

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

ceph.in: do not preload libasan if it is not found

before this change, `asan_lib_path` could be `None` when we check it to
see if it ends with `NOTFOUND`. this happens if WITH_SEASTAR=OFF or
WITH_ASAN=OFF, as in that case, find_package(Sanitizers) is not called,
hence `ASAN_LIBRARY` won't be set.

in this change, libasan is only preloaded if

- (WITH_SEASTAR=ON and CMAKE_BUILD_TYPE=Debug and ASAN_LIBRARY is found)
  or
- (WITH_ASAN)

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tests: removed filters for client-upgrade-* suites

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

install-deps.sh: Typo for krb5 on FreeBSD

The FreeBSD dependency install specifies devel/kbr5 instead of devel/krb5

Fixes: https://tracker.ceph.com/issues/40050
Signed-off-by: Thomas Johnson <NTmatter@gmail.com>

Merge PR #28058 into master

* refs/pull/28058/head:
mgr/zabbix: Fix raw_bytes_used key name

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #26967 from qwren/qat-accel-doc

doc: QAT Acceleration for Encryption and Compression

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #28099 from tchaikov/wip-blobhash

blobhash: do not use cast for unaligned access

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #28247 from tchaikov/wip-disable-asan-if-notfound

ceph.in: disable ASAN if libasan is not found

Reviewed-by: Casey Bodley <cbodley@redhat.com>

mgr/dashboard: Display correct dialog title

The dialog to create a new S3 key shows the title 'Show S3 key' instead of 'Create S3 key'.

Fixes: https://tracker.ceph.com/issues/40047
Signed-off-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Consider user permissions

Consider user permissions when showing advanced table actions and hide
all buttons requiring missing permissions from the user.
Also consider user permissions when showing submit buttons.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>

mgr/dashboard: Add PG scrub configuration form

The commit adapts two different parts:

1. It adds all frontend related changes around the PG scrub
   configuration form
2. It also adds an API test case to check the existence of
   all hard-coded config options in the frontend

Fixes: https://tracker.ceph.com/issues/38211
Signed-off-by: Tatjana Dehler <tdehler@suse.com>

mgr/dashboard: Add config option component

This commit adds an initial config option component in order to move
the HTML template and the config option types related code to an own
centralized place to be re-usable by other components

Signed-off-by: Tatjana Dehler <tdehler@suse.com>

mgr/dashboard: Add config filter and delete routes

Add a filter route to the configurations endpoint to get a subset of
config options in one request.
Add a delete route to the configurations endpoint to delete a
specific config option value.

The commit contains the frontend and backend related changes.

It also adds the missing '/' to `ConfigurationService.bulkCreate` and
unit test.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>

mgr/dashboard: Optimize iSCSI target edition (#27272)

mgr/dashboard: Optimize iSCSI target edition

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

blobhash: do not use cast for unaligned access

* remove the uncorrect comment. as std::hash<> does not apply to a
  customized type. see https://en.cppreference.com/w/cpp/utility/hash
* do not use cast for accessing an uint32_t by dereferencing (void *)
  or (char *) pointer. because the alignment requirement of `uint32_t`
  is stricter than that of `void*` or `char *`. we need to do an
  explicit memcpy() for accessing the uint32_t pointed by the pointer.
  see also https://www.kernel.org/doc/Documentation/unaligned-memory-access.txt
* instead of using a loop for mixing the last few bytes. use a switch-
  case. so GCC-9 won't complain with
```
../src/include/blobhash.h:38:10: warning: iteration 4 invokes undefined
behavior [-Waggressive-loop-optimizations]
   38 |       sh += 8;
      |       ~~~^~~~
../src/include/blobhash.h:36:12: note: within this loop
   36 |     while (len) {
      |            ^~~
```
  at seeing `sh += 8;`
* instead of mixing the last bits repeatly by derefencing `p` using
  `uint32_t`, while move it forwards with step size of `1`, mix
  the bits byte-wise.
* include <cstdint>. this header file is supposed to be self-contained.
* use `std::uint32_t` instead of using `uint32_t`. we cannot assume
  somebody is `using namespace std` or `using std::uint32_t` for us.
* mark the operator() `const noexcept`. see
  https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c89-make-a-hash-noexcept
  for the rationale behind this

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #27569 from batrick/gcc-9-wrn

CMakeLists: add std::move warnings in gcc9

Reviewed-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Add clients tab to NFS details (#28193)

mgr/dashboard: Add clients tab to NFS details

Reviewed-by: Ricardo Marques <rimarques@suse.com>

script/run_mypy: Sort groups

Workaround for https://github.com/python/mypy/issues/2144

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/zabbix: Fix raw_bytes_used key name

This patch fixes raw_bytes_used key which was renamed to stored_raw.
Also added key percent_used and fixed zabbix template to be fully
compatible with zabbix 3.0

Fixes: https://tracker.ceph.com/issues/39644
Signed-off-by: Dmitriy Rabotjagov <noonedeadpunk@ya.ru>

mgr/dashboard: Unify remaining action labels (#28162)

mgr/dashboard: Unify remaining action labels

Reviewed-by: Ricardo Marques <rimarques@suse.com>

monitoring: SNMP OID per every Prometheus alert rule

Use the Ceph enterprise OID 50495 (https://www.iana.org/assignments/enterprise-numbers/enterprise-numbers) and create OIDs for every Prometheus alert rule according to the schema at https://github.com/SUSE/prometheus-webhook-snmp/blob/master/README.md.

Example OID:
1.3.6.1.4.1.50495.15.1.2.2.1

All alert rule OIDs are located below the object identifier 15 (15 for p which is the first character of prometheus). Check out the MIB at https://github.com/SUSE/prometheus-webhook-snmp/blob/master/PROMETHEUS-ALERT-CEPH-MIB.txt for more details.

Signed-off-by: Volker Theile <vtheile@suse.com>

Merge pull request #27436 from simon-rock/simon_work

mds: avoid sending too many osd requests at once after mds restarts

Merge pull request #28224 from jan--f/pool-ls-detail-ec-profile

osd_types: add ec profile to plain text osd pool ls detail output

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #28159 from batrick/i39599

common: fix parse_env nullptr deref

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #28057 from wido/zabbix-pg-state

mgr/zabbix: Fix typo in key name for PGs in backfill_wait state

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #28025 from markhpc/wip-bs-aio-preadv

os/bluestore: Unify on preadv for io_uring and future refactor.

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #28010 from ifed01/wip-ifed-dump-large-onode

os/bluestore: dump onode that has too many spanning blobs

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #26341 from sebastian-philipp/dashboard-merge-orchclient

mgr/dashboard: Fix iSCSI + Rook issues

Reviewed-by: Ricardo Marques <rimarques@suse.com>

mds: avoid sending too many osd requests at once after mds restarts
Fixes: http://tracker.ceph.com/issues/40028
Signed-off-by: simon gao <simon29rock@gmail.com>

mgr/dashboard: Fixing RGW user user/bucket quota info

Display '-' if user/bucket quota is disabled instead of displaying the current set values.

Signed-off-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Fix RGW user/bucket quota issues

* RGW user/bucket "max. size" should be hidden when "user/bucket quota" is not enabled
* Only execute validators if necessary

Fixes: https://tracker.ceph.com/issues/39964
Signed-off-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Use serial RGW Admin OPS API calls

This PR takes care that changes done to a RGW user are submitted (via RGW Admin OPS API) in serial and NOT in parallel.

Fixes: https://tracker.ceph.com/issues/40015
Signed-off-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Subscribe to changes when RequiredIf is used (#28231)

mgr/dashboard: Subscribe to changes when RequiredIf is used

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #28078 from sebastian-philipp/kubejacker-fix-mgr-plugins

scripts/kubejacker: Fix mgr_plugins target for centos

Reviewed-by: Tim Serong <tserong@suse.com>

ceph.in: disable ASAN if libasan is not found

Signed-off-by: Kefu Chai <kchai@redhat.com>

journal: optimize object overflow detection

Previously to detect overflow we were sending journal append
requests until -EOVERFLOW is returned by osd. This means that we
had at least one waste (rejected) request per object set (though
there may be more if the number of in-flight appends is not
limited).

We can easily predict when the osd will start to return
-EOVERFLOW and avoid such additional requests.

Signed-off-by: Mykola Golub <mgolub@suse.com>

Merge pull request #28155 from alimaredia/wip-remove-mon-valgrind-check-in-rgw-suite

qa: remove mon valgrind check in rgw verfiy suite

mgr/dashboard: Fix NFS clients squash/access_type default values

Fixes: https://tracker.ceph.com/issues/40012
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Subscribe to changes when RequiredIf is used

FormControls that use 'requiredIf' validators depend on the state of other
controls.
To prevent that some of the state changes are not tracked, we now automatically
subscribe to the prerequsited controls and update the validation of the parent
control.

Fixes: https://tracker.ceph.com/issues/40017
Signed-off-by: Tiago Melo <tmelo@suse.com>

osd_types: add ec profile to plain text osd pool ls detail output

Fixes: http://tracker.ceph.com/issues/40009
Signed-off-by: Jan Fajerski <jfajerski@suse.com>

mgr/dashboard: Unify the labels on all table actions objects

Fixes: http://tracker.ceph.com/issues/39102
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Unify action naming for NFS

Fixes: http://tracker.ceph.com/issues/39102
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Bug Fix Error on Mgr Dashboard NFS (#28075)

mgr/dashboard: Bug Fix Error on Mgr Dashboard NFS

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>

common: fix parse_env nullptr deref

Fixes: https://tracker.ceph.com/issues/39599
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

test: add test for parse_env

Test for https://tracker.ceph.com/issues/39599

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #28169 from bk201/wip-39971

mgr/dashboard: fix some performance data are not displayed

Reviewed-by: Kanika Murarka <kmurarka@redhat.com>

Merge pull request #28181 from smithfarm/wip-39981

do_cmake.sh: use bash

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>

Merge pull request #28093 from dillaman/wip-39703

librbd: use custom allocator for aligned boost::lockfree::queue

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>

mgr/rook: Raise proper exception in `describe_service`

`describe_service` is called often and raising
  assertions will pollute the log file with tracebacks.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: Load iSCSI config from local store and orchestrator

As iSCSI is not supported by Rook, users need a way to manage
  ceph-iscsi without Rook knowledge

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: Reduce number of triggers when search not empty

Fixes: http://tracker.ceph.com/issues/39944
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Set changeDetection to Push on Table Component

This will limit the number of times angular checks for changes to only once
when a new data object is pushed to the table component.

It will also remove the event of rendering the table when we hover a row.

Fixes: http://tracker.ceph.com/issues/39944
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Merge OrchClient with OrchestratorClientMixin

Fixed missing error propagation from
  the orchestrator to the dashboard

Adapted orchestrator integration in NFS

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #28147 from bk201/wip-39933

mgr/dashboard: fix backend error when updating RBD interlocked features

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

mgr/dashboard: Add clients tab to NFS details

Fixes: https://tracker.ceph.com/issues/39963
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Fix tcmu-runner perf counters page (#28154)

mgr/dashboard: Fix tcmu-runner perf counters page

Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #26518 from linuxbox2/wip-rgw-lc-prefix-2

rgw: lifecycle: alternate solution to prefix_map conflict

rgw: lifecycle: fix object iteration for >1 same-prefix rules

Rules of like-prefix must visit every matching object.  A next
logical step is to combine tag checking for rules of like-prefix.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

rgw: lifecycle: fix RGWLifecycleConfiguration::valid()

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

rgw: lifecycle: alternate solution to prefix_map conflict

A rule containing a tag filter but no constraining prefix is
legal, as is a sequence of >1 such rules.

As currently designed, enforcement requires rules to be
installed in prefix_map as well as rule_map, though only the
latter is encoded.

Fixes: http://tracker.ceph.com/issues/37879
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

do_cmake.sh: use bash

Fixes: http://tracker.ceph.com/issues/39981
Signed-off-by: Nathan Cutler <ncutler@suse.com>

rbd-mirror: don't overwrite status error returned by replay

Fixes: https://tracker.ceph.com/issues/39980
Signed-off-by: Mykola Golub <mgolub@suse.com>

Merge pull request #27996 from jan--f/package-prometheus-alerts-suse

ceph.spec.in: package prometheus default alerts for SUSE

Reviewed-by: Nathan Cutler <ncutler@suse.com>

mgr/dashboard: fix some performance data are not displayed

Several Grafana dashboards were updated and their uids are changed.
Update corresponding uids in angular templates. Also fix that when a user
clicks performance details of an OSD, wrong OSD metrics are displayed.

Fixes: http://tracker.ceph.com/issues/39971
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>

Merge pull request #28094 from tchaikov/wip-install-deps-gcc-8

install-deps.sh: use gcc-8 on xenial and trusty

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #28079 from tchaikov/wip-crimson-rados-cleanup

crimson: support pgnls and delete op

Reviewed-off-by: Samuel Just <sjust@redhat.com>

qa: remove mon valgrind check in rgw verfiy suite

memory leaks in the monitor are causing a significant
percentage of jobs run in the rgw verify suite to
fail even though the jobs succeeded before hand.

See: http://tracker.ceph.com/issues/38827 for
root cause

Signed-off-by: Ali Maredia <amaredia@redhat.com>

Merge pull request #27653 from tspmelo/wip-nfs-pseudo

mgr/dashboard: Improve NFS Pseudo pattern message

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>

Merge pull request #28023 from rjfd/wip-fix-ceph-mgr-systemd

systemd: ceph-mgr: set MemoryDenyWriteExecute to false

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>

Merge pull request #28044 from dillaman/wip-librbd-io-perf

librbd: tweaks to increase IOPS and reduce CPU usage

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #28067 from yuriw/wip-yuriw-crontab-master

qa/tests: added new client-upgrade-*-nautilus suites for jewel, luminous, mimic

mgr/dashboard: Fix tcmu-runner perf counters page

Fixes: https://tracker.ceph.com/issues/39954
Signed-off-by: Ricardo Marques <rimarques@suse.com>

Merge pull request #27681 from tspmelo/wip-charts

mgr/dashboard: Unify the look of dashboard charts

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #28113 from hjwsm1989/fix-krb-compile-error

auth/krb: fix Kerberos compile error

Reviewed-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: fix backend error when updating RBD interlocked features

Now object-map and fast-diff features are interlocked. Allow
enabling/disabling these two features together without raising an already
enabled/disabled error.

Fixes: http://tracker.ceph.com/issues/39933
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>