osd: add processed_subop_count for cls_cxx_subop_version()

cls_log_add() relies on cls_cxx_subop_version() to generate unique keys
for log entries with the same timestamp. because cls calls back into
do_osd_ops(), resetting current_osd_subop_num means that cls_log_add()
will keep seeing the same subop version and generating the same keys.
this causes the following failure in ceph_test_cls_log:

[ RUN      ] cls_rgw.test_log_add_same_time
/home/cbodley/ceph/src/test/cls_log/test_cls_log.cc:144: Failure
      Expected: 10
To be equal to: (int)entries.size()
      Which is: 1
[  FAILED  ] cls_rgw.test_log_add_same_time (1180 ms)

Fixes: http://tracker.ceph.com/issues/21964
Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #18602 from adamemerson/wip-optional-failure

rgw: Fix dereference of empty optional

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #18592 from dillaman/wip-21956

cls/journal: fixed possible infinite loop in expire_tags

Reviewed-by: Mykola Golub <to.my.trociny@gmail.com>

Merge pull request #18607 from yaozongyou/fix-typo

doc: fix typo e.g,. => e.g.,

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

doc: fix typo e.g,. => e.g.,

Signed-off-by: Yao Zongyou <yaozongyou@vip.qq.com>

Merge pull request #18519 from liewegas/wip-21712-c

ceph_test_objectstore: do not change model for 0-length zero

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

rgw: Fix dereference of empty optional

Due to the lack of a return, there was a case where an invalid ARN
could cause a dereference of an uninitialized boost::optional.

As a bit of defensive programming, restructure a couple functions to
make that kind of error impossible by ensuring the optional is only in
scope when it is initialized and relying less in early return on
error.

Fixes: http://tracker.ceph.com/issues/21962
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

qa/suites/rbd: run cls tests for all dependencies

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

cls/journal: fixed possible infinite loop in expire_tags

Fixes: http://tracker.ceph.com/issues/21956
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #18571 from linuxbox2/wip-rgwfile-21940

rgw_file:  set s->obj_size from bytes_written

Merge pull request #18449 from dzafman/wip-zafman-misc

mark_unfound_lost fix and some other minor changes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #18402 from cbodley/wip-21831

rgw: fix for pause in beast frontend

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #18328 from PCzhangPC/cplostmeta

librbd: cannot copy all image-metas if we have more than 64 key/value pairs

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #18419 from majianpeng/librbd-bug-fix

librbd misc cleanup.

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #18542 from trociny/wip-metadata-open

librbd: don't read metadata twice on image open

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #18561 from dillaman/wip-librbd-test-notify

test/librbd: added update_features RPC message to test_notify

Reviewed-by: Mykola Golub <mgolub@mirantis.com>

Merge pull request #18583 from idryomov/wip-qa-xfstests-except

qa/tasks/rbd: run all xfstests runs to completion

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #18557 from tchaikov/wip-cmake-cleanup

cmake: check for aligned_alloc() instead of checking tcmalloc version

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #18551 from liewegas/wip-object-stat-decode

osd/osd_types: fix object_stat_sum_t decode

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #18565 from liewegas/wip-prime-fixes

ceph-bluestore-tool: prime-osd-dir: update symlinks instead of bailing

Reviewed-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #18518 from ceph/wip-cv-fix-default-flags

ceph-volume: ensure correct --filestore/--bluestore behavior

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #18502 from optimistyzy/1024_yzy

bluestore/NVMEDevice: convert the legacy config opt related with SPDK

Merge pull request #18576 from tchaikov/wip-cmake-no-rados_a

cmake: do not link against librados.a

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

cmake: remove rados_a target

rados_a is librados.a, which is not neeeded anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: link librbd against librados not rados_a

link librados.so in hope to reduce the size of librdb, also the size of
debug-info.

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: link librados tests against librados.so

* in hope to shrink the test, and the debug-info rpm package
* also add librados to radostest's target_link_libraries(),  otherwise we might
   run into linker order issue, like

Undefined reference in
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/librados/test.cc:61
to `rados_application_enable'

Signed-off-by: Kefu Chai <kchai@redhat.com>

test/librados/cmd.cc: avoid using non-librados facilities

a test for librados should be only depending on librados

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #18543 from neha-ojha/wip-add-cbt-repo

qa: add cbt repo parameter

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #18573 from neha-ojha/wip-add-cbt-workloads

qa/suites/rados/perf: add workloads

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

cmake: check for aligned_alloc()

in case developer is using patched tcmalloc.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #18174 into master

* refs/pull/18174/head:
mds: no assertion on inode being purging in find_ino_peers()

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #18537 into master

* refs/pull/18537/head:
mds: set PRIO_USEFUL on num_sessions counter

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

qa/suites/rados/perf: add workloads

Signed-off-by: Neha Ojha <nojha@redhat.com>

rgw_file:  set s->obj_size from bytes_written

Required to store correct final accounted_size of objects in
RGWWriteWriteRequest::write_finish.

Fixes: http://tracker.ceph.com/issues/21940
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #18524 from liewegas/wip-backfill-rops

osd/PG: fix recovery op leak

Reviewed-by: David Zafman <dzafman@redhat.com>

Merge pull request #18552 from liewegas/wip-mds-cluster-down

qa/workunits/rest/test.py: stop trying to test obsolte cluster_up/down

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #18489 from cbodley/wip-21895

rgw: fix extra_data_len handling in PutObj filters

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

ceph-volume lvm.activate remove links on activate before priming

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-bluestore-tool: prime-osd-dir: update symlinks instead of bailing

If the symlink points to the right location, do nothing.  If it doesn't,
replace it.  If it's not a symlink, bail with EEXIST.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #18451 from zmc/wip-cephmetrics

Add cephmetrics suite

Merge pull request #18198 from cbodley/wip-21735

rgw: fix error handling in ListBucketIndexesCR

qa/tasks/rbd: run all xfstests runs to completion

rbd.xfstests task allows spawning xfstests runs on multiple nodes.
Don't unwind task contexts if one of the runs fails -- let the other
runs finish.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Add cephmetrics suite

Signed-off-by: Zack Cerza <zack@redhat.com>

test/librbd: added update_features RPC message to test_notify

Fixes: http://tracker.ceph.com/issues/21936
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

qa/workunits/rest/test.py: stop trying to test obsolete 'mds *' commands

These were recently removed.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #18511 from smithfarm/wip-rpm-recommend-influxdb

build/ops: rpm: recommend python-influxdb with ceph-mgr

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Tim Serong <tserong@suse.com>

Merge pull request #18182 from nrdmn/dashboard

mgr/dashboard: improve error handling

Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

librbd: don't read metadata twice on image open

After adding get_metadata to RefreshRequest it has become redundant
in OpenRequest.

Signed-off-by: Mykola Golub <to.my.trociny@gmail.com>

Merge pull request #18533 from tchaikov/wip-qa-cephtool

qa: do not "ceph fs get cephfs" w/o a cephfs fs

Reviewed-by: Douglas Fuller <dfuller@redhat.com>

osd/PG: handle remote backfill recovation while waiting for other targets

If we have multiple targets, we may still be waiting on them when we get
a revocation.

Signed-off-by: Sage Weil <sage@redhat.com>

ceph-volume lvm.activate ceph-bluestore-tool needs --cluster too

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #18545 from batrick/pr18393-revert

Revert "ceph_context: re-expand admin_socket metavariables in child process"

Reviewed-by: Mykola Golub <to.my.trociny@gmail.com>

Merge pull request #18496 from liewegas/wip-pgmap

build: remove PGMap.cc from libcommon

Reviewed-by: Kefu Chai <kchai@redhat.com>

osd/PG: make scan recovery op cancellation match up reliably

Previously, there was only one time we would end up in this region of code:
when the backfill was rejected by the peer.  Previously that was apparently
reliably when we had an outstanding SCAN request, because we would
unconditionally cancle the MAX recovery op and clear waiting_on_backfill.

See 624aaf2a4ea9950153a89ff921e2adce683a6f51 for when this code appeared.

Now we have several similar paths, and we don't always have an outstanding
scan call (I don't think!).  Regardless, move most these three cases into
a common helper and make the finish_recovery_op completion conditional
on whether there is an outstanding SCAN.  This fixes a leak of a recovery
op when we defer while a scan is outstanding (this bug was recently
introduced by e708410542b0a52fbb29e14b76f49c94adbc0a59 and then
duplicated by 2463c6463d1ed38a2e15a0960ed1530a47851489).

Note that there is still one other time we register MAX ops: when we are
finishing backfill.  There, we start one per target.  But we will always
get back our reply and process it in the normal way (that old commit
did not change the timing for these).

Signed-off-by: Sage Weil <sage@redhat.com>

osd/PG: make recovering_oids a multiset

For multiple backfill targets, we start MAX multiple times.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #18527 from xiexingguo/wip-hunt-scrub-mismatch

osd/PrimaryLogPG: several oi.extents fixes

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #18531 from majianpeng/msg-async

msg/async misc cleanup

Reviewed-by: Haomai Wang <haomai@xsky.com>

msg/async: record correctly l_msgr_send_bytes if "rc == 0".

If rc == 0, it mean all data of outcoming_bl whether old or new data.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

osd/osd_types: fix object_stat_sum_t decode

Broken by 71bf04775bef90c9291bd825da626bc9de6f9ec1

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #18192 into master

* refs/pull/18192/head:
qa/cephfs: test ec data pool
qa/suites/fs/basic_functional/clusters: more osds

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

ceph-volume lvm.activate consume cluster_name from lvm metadata

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm.prepare persist cluster_name on lvm metadata

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Revert "ceph_context: re-expand admin_socket metavariables in child process"

This commit introduces a regression where the admin socket specified in
ceph.conf overrides command line arguments or environment variables.

This reverts commit 1630f4bbef3a3ff6efb56acbaa9b8786b945b1e6.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #18485 from liewegas/wip-remote-res-preemption

osd: fix recovery reservation bugs, and implement remote reservation preemption

Reviewed-by: David Zafman <dzafman@redhat.com>

ceph-volume util.prepare bluestore db and wal paths are to devices, not osd dir paths

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm.prepare bluestore wal and db links get created with mkfs

Signed-off-by: Alfredo Deza <adeza@redhat.com>

rgw: fix extra_data_len handling in PutObj filters

the RGWPutObj_Compress filter relies on a starting offset of 0 to ensure
that we only compress entire objects

for RGWRados::fetch_remote_obj(), we also fetch object metadata. the
replies come back with a 'Rgwx-Embedded-Metadata-Len' header, which
specifies how many bytes of object metadata are at the front of the
request body. when this is present, the offsets passed from
RGWRadosPutObj down to the RGWPutObjDataProcessor filters are offsets
into the http response body, rather than logical offsets into the object
data itself

this commit adds a transformation to RGWRadosPutObj so that only that
logical offset is visible to the RGWPutObjDataProcessor

Fixes: http://tracker.ceph.com/issues/21895
Signed-off-by: Casey Bodley <cbodley@redhat.com>

qa: add cbt repo parameter

Signed-off-by: Neha Ojha <nojha@redhat.com>

msg/async: updating l_msgr_running_send_time if write_message failed.

Also for the most time write_message return zero. So avoid checking
"r < 0 or r > 0" every time, it should firstly check "r == 0".

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

Merge pull request #18528 from tchaikov/wip-osd-misplaced

osd/PG: fix calc of misplaced objects

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

msg/async: only system can accept more data, continue send.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

Merge pull request #18523 from tchaikov/wip-vstart-quoted

vstart.sh: should quote the parameters to get them quoted

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

msg/async: remove redundant condition.

From the code, if out_q[r].is_empty, it already remove.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

msg/async: batch handle out_seq.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

ceph-volume lvm.prepare use wal and db for mkfs

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge PR #18062 into master

* refs/pull/18062/head:
client: put MetaSession map container
client: simplify release context ref mgmt

Reviewed-by: Zheng Yan <zyan@redhat.com>

mds: set PRIO_USEFUL on num_sessions counter

This is used by dashboard and status modules,
so let's make sure we're sending it to the mgr.

Fixes: http://tracker.ceph.com/issues/21927
Signed-off-by: John Spray <john.spray@redhat.com>

Merge pull request #18381 from cbodley/wip-21832

Revert "radosgw: fix awsv4 header line sort order."

Merge pull request #18369 from baixueyu/refcount_bug

 rgw: source data in 'default.rgw.buckets.data' may not be deleted after inter-bucket copy

Merge pull request #16605 from theanalyst/tools/release-notes-pyfixes

script: ceph-release-notes: minor fixes for split_component

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #18482 from liewegas/wip-luminous-note-fix

doc/release-notes: add jewel->kraken notes

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
Reviewed-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #18481 from xiexingguo/wip-choose-acting

osd/PG: miscellaneous choose acting changes and cleanups

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #18473 from yuyuyu101/wip-objecter-mono

osdc/Objecter: using coarse_mono instead

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #18471 from yuyuyu101/wip-omap-stat

osd/ReplicatedPG: add omap write bytes to delta_stats

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #16332 from badone/wip-warn-about-objects-with-too-many-omap-entries

osd: Warn about objects with too many omap entries

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #18506 from majianpeng/osd-scrub

osd/PrimaryLogPG: add condition "is_chunky_scrub_active" to check object in chunky_scrub

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

qa: do not "ceph fs get cephfs" w/o a cephfs fs

introduced by 183646c

Signed-off-by: Kefu Chai <kchai@redhat.com>

script: ceph-release-notes: minor fixes for split_component

make labels a set as intersection would fail otherwise, also sort the
results of prefixes before creating the title

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

build/ops: rpm: recommend python-influxdb with ceph-mgr

The influxdb module won't run if python-influxdb is not present (but it will be
graceful about not running). That means python-influxdb is a dependency of
that module, not mgr itself. However, we are not (yet) packaging the modules
separately. (When we do, this could become a Requires: of the module.)

RPM itself does not support "Recommends", and ignores this line. Higher-level
tools may or may not support it, so put this line in a SUSE-only conditional
since we know that zypper supports it.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Tim Serong <tserong@suse.com>

Merge pull request #18517 from dillaman/wip-iscsi-docs

doc/rbd: specify additional ESX prerequisites

Reviewed-by: Mykola Golub <to.my.trociny@gmail.com>

OSD/PG: fix calc of misplaced objects

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #18466 from zealoussnow/wip-wrong-parameter

OSD: drop unsed parameter passed to check_osdmap_features

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Liu-Chunmei <chunmei.liu@intel.com>

Merge pull request #18425 from ZVampirEM77/wip-options-cleanup

common/options.cc: cleanup readable literals for default sizes

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #17894 from chenliuzhong/change-aio-max-nr

ceph.spec.in,debian/rules: change aio-max-nr to 1048576

Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

vstart.sh: should quote the parameters to get them quoted

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #18505 from badone/wip-unittest-crypto-getentropy-limit

unittest_crypto: Don't exceed limit for getentropy

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #18181 from tchaikov/wip-vstart-quoted-print

vstart.sh: quote command only when necessary

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge PR #17266 into master

* refs/pull/17266/head:
qa: update test_ceph_argparse to test fs cmds
qa: use fs rm_data_pool
qa: fix mdsmap lookup
qa: remove usage of mds dump
PendingReleaseNotes: add obsoleted mds commands
qa: remove use of obsolete mds commands
ceph_volume_client: remove use of obsolete mds cmd
doc: update on obsolete mds commands
cephfs: obsolete deprecated mds commands

Reviewed-by: Douglas Fuller <dfuller@redhat.com>

Merge pull request #17909 from tchaikov/wip-coverity

test/objectstore/test_bluefs: cleanups

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

qa: update test_ceph_argparse to test fs cmds

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>