]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
6 weeks agoMerge pull request #63622 from zdover23/wip-doc-2025-06-02-mgr-dashboard_plugins...
Zac Dover [Tue, 3 Jun 2025 20:51:36 +0000 (06:51 +1000)]
Merge pull request #63622 from zdover23/wip-doc-2025-06-02-mgr-dashboard_plugins-63367-followup

doc/mgr/dashboard_plugins: edit feature_toggles.inc.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #62893 from zdover23/wip-doc-2025-04-21-radosgw-metrics
Zac Dover [Tue, 3 Jun 2025 20:30:28 +0000 (06:30 +1000)]
Merge pull request #62893 from zdover23/wip-doc-2025-04-21-radosgw-metrics

doc/radosgw: edit sentence in metrics.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63614 from zdover23/wip-doc-2025-05-30-rados-ops-cache-tiering...
Zac Dover [Tue, 3 Jun 2025 20:03:47 +0000 (06:03 +1000)]
Merge pull request #63614 from zdover23/wip-doc-2025-05-30-rados-ops-cache-tiering-63465-followup

doc/rados/operations: edit cache-tiering.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63476 from zdover23/wip-doc-2025-05-26-mgr-telemetry-62782-followup
Zac Dover [Tue, 3 Jun 2025 19:56:15 +0000 (05:56 +1000)]
Merge pull request #63476 from zdover23/wip-doc-2025-05-26-mgr-telemetry-62782-followup

doc/mgr: edit telemetry.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63195 from zdover23/wip-doc-2025-05-09-mgr-cli-api-62782-followup
Zac Dover [Tue, 3 Jun 2025 19:42:02 +0000 (05:42 +1000)]
Merge pull request #63195 from zdover23/wip-doc-2025-05-09-mgr-cli-api-62782-followup

doc/mgr: edit cli_api.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63628 from zdover23/wip-doc-2025-06-02-rados-ops-balancer-63530...
Zac Dover [Tue, 3 Jun 2025 18:52:13 +0000 (04:52 +1000)]
Merge pull request #63628 from zdover23/wip-doc-2025-06-02-rados-ops-balancer-63530-followup

doc/rados: edit balancer.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63623 from zdover23/wip-doc-2025-06-02-mgr-iostat-63418-followup
Zac Dover [Tue, 3 Jun 2025 18:49:08 +0000 (04:49 +1000)]
Merge pull request #63623 from zdover23/wip-doc-2025-06-02-mgr-iostat-63418-followup

doc/mgr: edit iostat.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agodoc/mgr/dashboard_plugins: edit feature_toggles.inc.rst 63622/head
Zac Dover [Sun, 1 Jun 2025 23:04:25 +0000 (09:04 +1000)]
doc/mgr/dashboard_plugins: edit feature_toggles.inc.rst

Follow up on the suggestions made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63367.

- Add "nvmeof" to the list of enabled features.
- Remove an extraneous space.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/radosgw: edit sentence in metrics.rst 62893/head
Zac Dover [Mon, 21 Apr 2025 07:52:02 +0000 (17:52 +1000)]
doc/radosgw: edit sentence in metrics.rst

Change the wording of a sentence in doc/radosgw/metrics.rst so that its
articles read as though they were written by a native speaker of the
English language.

This commit is being raised as part of a diagnostic process aimed at
discovering why the ReadtheDocs check is failing on PR
https://github.com/ceph/ceph/pull/62877.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agoMerge pull request #63556 from guits/fix-node-proxy-hw-status
Adam King [Tue, 3 Jun 2025 14:51:20 +0000 (10:51 -0400)]
Merge pull request #63556 from guits/fix-node-proxy-hw-status

node-proxy: address `ceph orch hardware status` cmd

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Teoman ONAY <tonay@ibm.com>
6 weeks agoMerge pull request #62121 from aclamk/wip-aclamk-bluefs-truncate-alloc-size
Adam Kupczyk [Tue, 3 Jun 2025 12:55:35 +0000 (14:55 +0200)]
Merge pull request #62121 from aclamk/wip-aclamk-bluefs-truncate-alloc-size

os/bluestore: In BlueFS::truncate accept wierd alloc_unit

6 weeks agoMerge pull request #62913 from Jayaprakash-ibm/wip-jaya-esb-fio-test ceph-8.1-rhel-patches
Adam Kupczyk [Tue, 3 Jun 2025 09:29:18 +0000 (11:29 +0200)]
Merge pull request #62913 from Jayaprakash-ibm/wip-jaya-esb-fio-test

qa: Add Teuthology test for BlueStore ESB assertion failure

6 weeks agoMerge pull request #63188 from aclamk/aclamk-fix-70911-envelope-dirty-recover
Adam Kupczyk [Tue, 3 Jun 2025 09:28:21 +0000 (11:28 +0200)]
Merge pull request #63188 from aclamk/aclamk-fix-70911-envelope-dirty-recover

os/bluestore: Fix bluefs_fnode_t::seek

6 weeks agoMerge pull request #63358 from ifed01/wip-ifed-fix-vselector-math
Adam Kupczyk [Tue, 3 Jun 2025 09:25:20 +0000 (11:25 +0200)]
Merge pull request #63358 from ifed01/wip-ifed-fix-vselector-math

os/bluestore:fix bluestore_volume_selection_reserved_factor usage

6 weeks agoMerge pull request #63373 from aclamk/aclamk-bs-fix-split-and-compress
Adam Kupczyk [Tue, 3 Jun 2025 09:24:50 +0000 (11:24 +0200)]
Merge pull request #63373 from aclamk/aclamk-bs-fix-split-and-compress

os/bluestore/compression: Fix Estimator::split_and_compress

6 weeks agoMerge pull request #63629 from zdover23/wip-doc-2025-06-02-mgr-localpool-63419-followup
Zac Dover [Tue, 3 Jun 2025 06:11:45 +0000 (16:11 +1000)]
Merge pull request #63629 from zdover23/wip-doc-2025-06-02-mgr-localpool-63419-followup

doc/mgr: edit localpool.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63630 from zdover23/wip-doc-2025-06-02-mgr-modules-63451-followup
Zac Dover [Tue, 3 Jun 2025 06:09:11 +0000 (16:09 +1000)]
Merge pull request #63630 from zdover23/wip-doc-2025-06-02-mgr-modules-63451-followup

doc/mgr: edit modules.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63631 from zdover23/wip-doc-2025-06-02-mgr-nfs-63452-followup
Zac Dover [Tue, 3 Jun 2025 06:06:33 +0000 (16:06 +1000)]
Merge pull request #63631 from zdover23/wip-doc-2025-06-02-mgr-nfs-63452-followup

doc/mgr: edit nfs.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63632 from zdover23/wip-doc-2025-06-02-dev-cephfs-mirroring-63237...
Zac Dover [Tue, 3 Jun 2025 06:03:43 +0000 (16:03 +1000)]
Merge pull request #63632 from zdover23/wip-doc-2025-06-02-dev-cephfs-mirroring-63237-followup-4-of-x

doc/dev/cephfs-mirroring: edit file 4 of x

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63643 from chardan/jfw-breakpad-add-pre-build
Jesse Williamson [Mon, 2 Jun 2025 21:29:48 +0000 (14:29 -0700)]
Merge pull request #63643 from chardan/jfw-breakpad-add-pre-build

Add PRE_BUILD to breakpad command (fix for CMake > 3.30)

6 weeks agoMerge pull request #63634 from zdover23/wip-doc-2025-06-02-start-documenting-ceph
Zac Dover [Mon, 2 Jun 2025 18:50:55 +0000 (04:50 +1000)]
Merge pull request #63634 from zdover23/wip-doc-2025-06-02-start-documenting-ceph

doc/start: edit documenting-ceph.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
6 weeks agoMerge pull request #63644 from anthonyeleven/advice
Zac Dover [Mon, 2 Jun 2025 18:43:05 +0000 (04:43 +1000)]
Merge pull request #63644 from anthonyeleven/advice

doc/rados/operations: Additional improvements to placement-groups.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/rados/operations: Additional improvements to placement-groups.rst 63644/head
Anthony D'Atri [Mon, 2 Jun 2025 18:35:23 +0000 (14:35 -0400)]
doc/rados/operations: Additional improvements to placement-groups.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
6 weeks agoMerge pull request #63618 from anthonyeleven/advice
Anthony D'Atri [Mon, 2 Jun 2025 18:32:34 +0000 (14:32 -0400)]
Merge pull request #63618 from anthonyeleven/advice

doc/rados/operations: Improve placement-groups.rst

6 weeks agoqa: Add Teuthology test for BlueStore ESB assertion failure 62913/head
Jaya Prakash [Wed, 16 Apr 2025 10:50:30 +0000 (16:20 +0530)]
qa: Add Teuthology test for BlueStore ESB assertion failure

Adds a test to reproduce the !ito->is_valid() assertion in BlueStore
with bluestore_elastic_shared_blobs=true on a 2+1 EC pool using a
FIO randwrite workload (512 concurrent ops, 50G, 12,500 objects).
The test deploys a 6-OSD cluster and runs FIO for 1 hour via workunit,
failing if an OSD crashes.

Signed-off-by: Jaya Prakash <jayaprakash@ibm.com>
6 weeks agoAdd PRE_BUILD (fix for CMake > 3.30) 63643/head
Jesse F. Williamson [Mon, 2 Jun 2025 17:30:45 +0000 (10:30 -0700)]
Add PRE_BUILD (fix for CMake > 3.30)

Signed-off-by: Jesse F. Williamson <jfw@ibm.com>
6 weeks agoMerge pull request #61264 from irq0/wip/breakpad
Jesse Williamson [Mon, 2 Jun 2025 16:17:43 +0000 (09:17 -0700)]
Merge pull request #61264 from irq0/wip/breakpad

Breakpad Crash Handler

6 weeks agoMerge pull request #63633 from zdover23/wip-doc-2025-06-02-mgr-progress-63470-followup
Anthony D'Atri [Mon, 2 Jun 2025 03:17:05 +0000 (23:17 -0400)]
Merge pull request #63633 from zdover23/wip-doc-2025-06-02-mgr-progress-63470-followup

doc/mgr: edit progress.rst

6 weeks agodoc/rados/operations: Improve placement-groups.rst 63618/head
Anthony D'Atri [Fri, 30 May 2025 17:43:49 +0000 (13:43 -0400)]
doc/rados/operations: Improve placement-groups.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
6 weeks agodoc/mgr: edit progress.rst 63633/head
Zac Dover [Mon, 2 Jun 2025 02:27:12 +0000 (12:27 +1000)]
doc/mgr: edit progress.rst

Edit doc/mgr/progress.rst. Make the changes suggested by Anthony D'Atri
in https://github.com/ceph/ceph/pull/63470.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/start: edit documenting-ceph.rst 63634/head
Zac Dover [Mon, 2 Jun 2025 02:32:36 +0000 (12:32 +1000)]
doc/start: edit documenting-ceph.rst

Edit the section "Build the Source" in doc/start/documenting-ceph.rst.
Also correct a misuse of the word "presently", which means "in a little
while", not "now".

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/dev/cephfs-mirroring: edit file 4 of x 63632/head
Zac Dover [Mon, 2 Jun 2025 02:16:47 +0000 (12:16 +1000)]
doc/dev/cephfs-mirroring: edit file 4 of x

Add prompts (and perform necessary corrections to glaring grammatical
errors) to doc/dev/cephfs-mirroring.rst, as requested by Jos Collin in
https://github.com/ceph/ceph/pull/63237/files#r2085886075.

This commit edits the fourth (and final) quarter of the
doc/dev/cephfs-mirroring.rst file.

Further refinements to the English in this file are possible.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/mgr: edit nfs.rst 63631/head
Zac Dover [Sun, 1 Jun 2025 23:45:42 +0000 (09:45 +1000)]
doc/mgr: edit nfs.rst

Edit the "Updating an NFS Cluster" section of doc/mgr/nfs.rst. This
commit includes changes requested by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63452.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/mgr: edit modules.rst 63630/head
Zac Dover [Sun, 1 Jun 2025 23:39:35 +0000 (09:39 +1000)]
doc/mgr: edit modules.rst

s/called/named/ as requested by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63451#discussion_r2104487962.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/mgr: edit localpool.rst 63629/head
Zac Dover [Sun, 1 Jun 2025 23:33:20 +0000 (09:33 +1000)]
doc/mgr: edit localpool.rst

Remove "only" where it was extraneous.

This commit was made in response to a request made by Anthony D'Atri
here: https://github.com/ceph/ceph/pull/63419#discussion_r2102803276.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/rados: edit balancer.rst 63628/head
Zac Dover [Sun, 1 Jun 2025 23:25:42 +0000 (09:25 +1000)]
doc/rados: edit balancer.rst

Edit doc/rados/operations/balancer.rst. Follow up on matters raised in
https://github.com/ceph/ceph/pull/63530. Make the English clearer.

Signed-off-by: Zac Dover <zac.dover@proton.me>
6 weeks agodoc/mgr: edit iostat.rst 63623/head
Zac Dover [Sun, 1 Jun 2025 23:14:45 +0000 (09:14 +1000)]
doc/mgr: edit iostat.rst

Rewrite the first sentence in doc/mgr/iostat.rst. This follows up on a
request made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63418#discussion_r2102806688.

Signed-off-by: Zac Dover <zac.dover@proton.me>
7 weeks agoMerge pull request #63429 from aclamk/aclamk-qa-no-bench-for-write-v2-compression
Laura Flores [Fri, 30 May 2025 19:22:17 +0000 (14:22 -0500)]
Merge pull request #63429 from aclamk/aclamk-qa-no-bench-for-write-v2-compression

qa/rados: Fix problem with recompression failing osd bench testing

7 weeks agoMerge PR #63606 into main
Patrick Donnelly [Fri, 30 May 2025 16:48:39 +0000 (12:48 -0400)]
Merge PR #63606 into main

* refs/pull/63606/head:
win32_deps_bild: bump openssl version

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
7 weeks agoMerge pull request #63529 from chardan/build-cmake-improve-catch2-support
Jesse Williamson [Fri, 30 May 2025 15:48:48 +0000 (08:48 -0700)]
Merge pull request #63529 from chardan/build-cmake-improve-catch2-support

make adding Catch2 tests straightforward

7 weeks agoMerge pull request #63600 from tchaikov/wip-bluestore-types-fix-leaks
Igor Fedotov [Fri, 30 May 2025 14:30:03 +0000 (17:30 +0300)]
Merge pull request #63600 from tchaikov/wip-bluestore-types-fix-leaks

test/objectstore: fix memory leak test_bluestore_types.cc

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
7 weeks agoMerge pull request #63613 from zdover23/wip-doc-2025-05-30-cephadm-host-management...
Anthony D'Atri [Fri, 30 May 2025 13:48:00 +0000 (09:48 -0400)]
Merge pull request #63613 from zdover23/wip-doc-2025-05-30-cephadm-host-management-62600-followup

doc/cephadm: edit host-management.rst

7 weeks agoMerge pull request #63570 from joscollin/wip-update-backport-script
Jos Collin [Fri, 30 May 2025 13:04:57 +0000 (18:34 +0530)]
Merge pull request #63570 from joscollin/wip-update-backport-script

ceph-backport.sh: update known milestones

Reviewed-by: Casey Bodley <cbodley@redhat.com>
7 weeks agoMerge pull request #63603 from tchaikov/wip-bluestore-nullptr
Igor Fedotov [Fri, 30 May 2025 12:56:08 +0000 (15:56 +0300)]
Merge pull request #63603 from tchaikov/wip-bluestore-nullptr

os/bluestore/BlueFS: use nullptr when appropriate

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
7 weeks agodoc/rados/operations: edit cache-tiering.rst 63614/head
Zac Dover [Fri, 30 May 2025 12:38:03 +0000 (22:38 +1000)]
doc/rados/operations: edit cache-tiering.rst

Strengthen the warning against deploying cache tiering in releases after
Reef. This follows up on Anthony D'Atri's request in
https://github.com/ceph/ceph/pull/63465.

Signed-off-by: Zac Dover <zac.dover@proton.me>
7 weeks agodoc/cephadm: edit host-management.rst 63613/head
Zac Dover [Fri, 30 May 2025 12:27:03 +0000 (22:27 +1000)]
doc/cephadm: edit host-management.rst

Make the improvements to doc/cephadm/host-management.rst that Anthony
D'Atri suggested in https://github.com/ceph/ceph/pull/62600.

Signed-off-by: Zac Dover <zac.dover@proton.me>
7 weeks agowin32_deps_bild: bump openssl version 63606/head
Lucian Petrut [Fri, 30 May 2025 09:24:51 +0000 (09:24 +0000)]
win32_deps_bild: bump openssl version

The Windows build is using a very old OpenSSL version (1.1.1c),
we'll bump the version to 3.0.16.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
7 weeks agoceph-backport.sh: update known milestones 63570/head
Jos Collin [Thu, 29 May 2025 07:20:46 +0000 (12:50 +0530)]
ceph-backport.sh: update known milestones

Signed-off-by: Jos Collin <jcollin@redhat.com>
7 weeks agoos/bluestore/BlueFS: use nullptr when appropriate 63603/head
Kefu Chai [Fri, 30 May 2025 07:29:42 +0000 (15:29 +0800)]
os/bluestore/BlueFS: use nullptr when appropriate

instead of using `0` to represent a nullptr, use nullptr for better
readability.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
7 weeks agoMerge pull request #63559 from ronen-fr/wip-rf-extsleep
Ronen Friedman [Fri, 30 May 2025 07:59:04 +0000 (10:59 +0300)]
Merge pull request #63559 from ronen-fr/wip-rf-extsleep

osd/scrub: only periodic_regular scrubs should suffer extended sleeps

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
7 weeks agotest/objectstore: fix memory leak test_bluestore_types.cc 63600/head
Kefu Chai [Fri, 30 May 2025 01:40:41 +0000 (09:40 +0800)]
test/objectstore: fix memory leak test_bluestore_types.cc

Previously, we had memory leak in the test_bluestore_types.cc tests where
`BufferCacheShard` and `OnodeCacheShard` objects were allocated with
raw pointers but never freed, causing leaks detected by AddressSanitizer.

ASan rightly pointed this out:

```
Direct leak of 224 byte(s) in 1 object(s) allocated from:
    #0 0x55a7432a079d in operator new(unsigned long) (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_bluestore_types+0xf2e79d) (BuildId: c3bec647afa97df6bb147bc82eac937531fc6272)
    #1 0x55a743523340 in BlueStore::BufferCacheShard::create(BlueStore*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, ceph::common::PerfCounters*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/Bl
ueStore.cc:1678:9
    #2 0x55a74330b617 in ExtentMap_seek_lextent_Test::TestBody() /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/objectstore/test_bluestore_types.cc:1077:7
    #3 0x55a7434f2b2d in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.
cc:2653:10
    #4 0x55a7434b5775 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:
2689:14
    #5 0x55a74347005d in testing::Test::Run() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2728:5
```
```
Direct leak of 9928 byte(s) in 1 object(s) allocated from:
    #0 0x7ff249d21a2d in operator new(unsigned long) /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_new_delete.cpp:86
    #1 0x6048ed878b76 in BlueStore::OnodeCacheShard::create(ceph::common::CephContext*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, ceph::common::PerfCounters*) /home/kefu/dev/ceph/src/os/bluestore/BlueStore.cc:1219
    #2 0x6048ed66d4f9 in GarbageCollector_BasicTest_Test::TestBody() /home/kefu/dev/ceph/src/test/objectstore/test_bluestore_types.cc:2662
    #3 0x6048ed820555 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/kefu/dev/ceph/src/googletest/googletest/src/gtest.cc:2653
    #4 0x6048ed80c78a in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/kefu/dev/ceph/src/googletest/googletest/src/gtest.cc:2689
    #5 0x6048ed7b8bfa in testing::Test::Run() /home/kefu/dev/ceph/src/googletest/googletest/src/gtest.cc:2728
```

In this change, we replace raw pointer allocation with unique_ptr to
ensure automatic cleanup when the objects go out of scope.
`
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
7 weeks agoMerge pull request #63435 from phlogistonjohn/jjm-fix-dash-fix
Dan Mick [Thu, 29 May 2025 22:10:15 +0000 (15:10 -0700)]
Merge pull request #63435 from phlogistonjohn/jjm-fix-dash-fix

dashboard: fix the workaround for unpacking node sources

7 weeks agoMerge pull request #63410 from Hezko/nvmeof-cli-align-part-3
Hezko [Thu, 29 May 2025 17:46:05 +0000 (20:46 +0300)]
Merge pull request #63410 from Hezko/nvmeof-cli-align-part-3

mgr/dashboard: align response of subsystem add and ns add with old cli

7 weeks agoMerge pull request #63412 from awojno-bloomberg/cephadm-optional-build
Alex [Thu, 29 May 2025 17:04:07 +0000 (13:04 -0400)]
Merge pull request #63412 from awojno-bloomberg/cephadm-optional-build

cephadm: add optional build flag

7 weeks agoImprove Catch2 support by adding helper functions. 63529/head
Jesse F. Williamson [Tue, 27 May 2025 17:44:43 +0000 (10:44 -0700)]
Improve Catch2 support by adding helper functions.

Makes it less tedious to add a new Catch2 test with CMake.

Signed-off-by: Jesse F. Williamson <jfw@ibm.com>
7 weeks agoMerge pull request #60428 from amathuria/wip-amat-add-pg-splitting-crimson
Matan Breizman [Thu, 29 May 2025 15:35:13 +0000 (18:35 +0300)]
Merge pull request #60428 from amathuria/wip-amat-add-pg-splitting-crimson

Crimson PG Splitting

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
7 weeks agoMerge pull request #63381 from mkogan1/wip-d3n-test-stripe_size
Mark Kogan [Thu, 29 May 2025 14:08:28 +0000 (17:08 +0300)]
Merge pull request #63381 from mkogan1/wip-d3n-test-stripe_size

rgw/d3n: fix teuthology run-datacache.sh FAIL when stripe_size!=4MiB

7 weeks agoMerge pull request #63471 from zdover23/wip-doc-2025-05-26-mgr-prometheus-62782-followup
Zac Dover [Thu, 29 May 2025 12:56:12 +0000 (22:56 +1000)]
Merge pull request #63471 from zdover23/wip-doc-2025-05-26-mgr-prometheus-62782-followup

doc/mgr: edit prometheus.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
7 weeks agoMerge pull request #63470 from zdover23/wip-doc-2025-05-26-mgr-progress-62782-followup
Zac Dover [Thu, 29 May 2025 12:54:42 +0000 (22:54 +1000)]
Merge pull request #63470 from zdover23/wip-doc-2025-05-26-mgr-progress-62782-followup

doc/mgr: edit progress.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
7 weeks agoMerge pull request #63565 from cbodley/wip-backport-redmine-key
Casey Bodley [Thu, 29 May 2025 12:41:52 +0000 (08:41 -0400)]
Merge pull request #63565 from cbodley/wip-backport-redmine-key

script: ceph-backport.sh adds redmine key to api requests

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Adam Kraitman <akraitma@redhat.com>
7 weeks agoMerge pull request #63452 from zdover23/wip-doc-2025-05-23-mgr-nfs-62782-followup
Zac Dover [Thu, 29 May 2025 12:38:35 +0000 (22:38 +1000)]
Merge pull request #63452 from zdover23/wip-doc-2025-05-23-mgr-nfs-62782-followup

doc/mgr: edit nfs.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
7 weeks agoMerge pull request #63451 from zdover23/wip-doc-2025-05-23-mgr-modules-62782-followup
Zac Dover [Thu, 29 May 2025 12:33:57 +0000 (22:33 +1000)]
Merge pull request #63451 from zdover23/wip-doc-2025-05-23-mgr-modules-62782-followup

doc/mgr: edit modules.rst.

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
7 weeks agoMerge pull request #63240 from yuvalif/wip-yuval-71255
Yuval Lifshitz [Thu, 29 May 2025 08:24:22 +0000 (11:24 +0300)]
Merge pull request #63240 from yuvalif/wip-yuval-71255

rgw/logging: support object metadata changes in journal mode

7 weeks agoMerge pull request #63525 from ronen-fr/wip-rf-checkrepair
Ronen Friedman [Thu, 29 May 2025 05:50:19 +0000 (08:50 +0300)]
Merge pull request #63525 from ronen-fr/wip-rf-checkrepair

osd/scrub: no auto-repair in 'after_repair' type of scrubs

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
7 weeks agoMerge PR #61547 into main
Venky Shankar [Thu, 29 May 2025 04:21:16 +0000 (09:51 +0530)]
Merge PR #61547 into main

* refs/pull/61547/head:
qa: enable libcephfs debug logs for fio workload with nfs

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
7 weeks agoMerge PR #62549 into main
Venky Shankar [Thu, 29 May 2025 04:20:00 +0000 (09:50 +0530)]
Merge PR #62549 into main

* refs/pull/62549/head:
test/libcephfs: Add a new test with ceph_ll_get() API
libcephfs: Implement ceph_ll_get() API

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
7 weeks agoMerge pull request #63131 from joscollin/wip-B71186-test_cephfs_mirror_stats-failure
Venky Shankar [Thu, 29 May 2025 04:19:00 +0000 (09:49 +0530)]
Merge pull request #63131 from joscollin/wip-B71186-test_cephfs_mirror_stats-failure

qa: fix test_cephfs_mirror_stats failure

Reviewed-by: Venky Shankar <vshankar@redhat.com>
7 weeks agoMerge PR #63178 into main
Venky Shankar [Thu, 29 May 2025 04:17:39 +0000 (09:47 +0530)]
Merge PR #63178 into main

* refs/pull/63178/head:
cephfs, tools/cephfs_mirror: migrate from boost::variant to std::variant

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
7 weeks agoMerge pull request #63220 from trociny/wip-71270
Venky Shankar [Thu, 29 May 2025 04:16:18 +0000 (09:46 +0530)]
Merge pull request #63220 from trociny/wip-71270

mds: log meaningful error message when entering damaged state

Reviewed-by: Venky Shankar <vshankar@redhat.com>
7 weeks agoscript: ceph-backport.sh adds redmine key to api requests 63565/head
Casey Bodley [Wed, 28 May 2025 20:33:44 +0000 (16:33 -0400)]
script: ceph-backport.sh adds redmine key to api requests

the ceph-backport.sh script recently started failing with:

> ceph-backport.sh: DEBUG: Considering Redmine issue: https://tracker.ceph.com/issues/70374 - is it in the Backport tracker?
> ceph-backport.sh: DEBUG:
> ceph-backport.sh: ERROR: Issue https://tracker.ceph.com/issues/70374 is not a Backport

because the command `curl --silent https://tracker.ceph.com/issues/70374.json`
now fails with `HTTP/2 401` (Unauthorized) and returns an empty string

the command succeeds after adding my redmine key as a query param like
some of the other redmine requests

Signed-off-by: Casey Bodley <cbodley@redhat.com>
7 weeks agoMerge pull request #63092 from bill-scales/issue71027
Yuri Weinstein [Wed, 28 May 2025 19:15:15 +0000 (12:15 -0700)]
Merge pull request #63092 from bill-scales/issue71027

crushtool: init with CINIT_FLAG_NO_DAEMON_ACTIONS

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
7 weeks agoos/bluestore/compression: Fix Estimator::split_and_compress 63373/head
Adam Kupczyk [Tue, 20 May 2025 07:27:26 +0000 (07:27 +0000)]
os/bluestore/compression: Fix Estimator::split_and_compress

Fixed calculation on effective blob size.
When fully non-compressible data is passed,
it could cause losing few bytes in the end.
Example:
 -107> 2025-05-17T20:40:50.468+0000 7f267a42f640 15 bluestore(/var/lib/ceph/osd/ceph-4) _do_write_v2_compressed 200000~78002 -> 200000~78002
 -106> 2025-05-17T20:40:50.468+0000 7f267a42f640 20 blobs to put: 200000~f000(4d61) 20f000~f000(b51) 21e000~f000(b51) 22d000~f000(b51) 23c000~f000(b51) 24b000~f000(b51) 25a000~f000(b51) 269000~f000(b51)
In result we split 0x78002 into 8 * 0xf000, losing 0x2 in the process.

Calculations for original:
>>> size=0x78002
>>> blobs=(size+0xffff) / 0x10000
>>> blob_size = size / blobs
>>> print hex(size), blobs, hex(blob_size)
0x78002 8 0xf000 <-this means roundup is 0xf000

Calculations for fixed:
>>> size=0x78002
>>> blobs=(size+0xffff) / 0x10000
>>> blob_size = (size+blobs-1) / blobs
>>> print hex(size), blobs, hex(blob_size)
0x78002 8 0xf001 <-this meand roundup is 0x10000

Fixes: https://tracker.ceph.com/issues/71353
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
7 weeks agomgr/dashboard: align response of subsystem add and ns add with old cli 63410/head
Tomer Haskalovitch [Tue, 20 May 2025 20:27:43 +0000 (23:27 +0300)]
mgr/dashboard: align response of subsystem add and ns add with old cli

Signed-off-by: Tomer Haskalovitch <il033030@Tomers-MBP.lan>
7 weeks agoMerge pull request #63481 from bluikko/doc-minor-fixes-rgw-mgr
Anthony D'Atri [Wed, 28 May 2025 15:39:17 +0000 (11:39 -0400)]
Merge pull request #63481 from bluikko/doc-minor-fixes-rgw-mgr

doc/mgr: Small improvements in rgw.rst

7 weeks agoosd/scrub: only periodic_regular scrubs should extended-sleep 63559/head
Ronen Friedman [Wed, 28 May 2025 14:26:29 +0000 (09:26 -0500)]
osd/scrub: only periodic_regular scrubs should extended-sleep

Fix get_scrub_sleep_time() call parameters, to use the correct
logic (observes_extended_sleep()) for sleep time calculations.

Fixes: https://tracker.ceph.com/issues/70923
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
7 weeks agoMerge pull request #62164 from piyushagarwal1411/cephfsdashboard
Aashish Sharma [Wed, 28 May 2025 14:01:44 +0000 (19:31 +0530)]
Merge pull request #62164 from piyushagarwal1411/cephfsdashboard

mgr/dashboard: Creating CephFS dashboard for Grafana

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
7 weeks agoMerge pull request #63450 from bluikko/doc-capitalize-nfs-ct-radosgw
Anthony D'Atri [Wed, 28 May 2025 13:04:48 +0000 (09:04 -0400)]
Merge pull request #63450 from bluikko/doc-capitalize-nfs-ct-radosgw

doc/radosgw: Fix capitalization, tab use, punctuation in two files

7 weeks agoMerge pull request #62823 from NitzanMordhai/wip-nitzan-suites-verify-validater-valgr...
SrinivasaBharathKanta [Wed, 28 May 2025 12:58:12 +0000 (18:28 +0530)]
Merge pull request #62823 from NitzanMordhai/wip-nitzan-suites-verify-validater-valgrind-doesnt-wait-enough

qa/suites: wait longer before stopping OSDs with valgrind

7 weeks agoMerge PR #63528 into main
Patrick Donnelly [Wed, 28 May 2025 12:27:44 +0000 (08:27 -0400)]
Merge PR #63528 into main

* refs/pull/63528/head:
qa/crontab: update priority for tentacle upgrade command

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
7 weeks agonode-proxy: address `ceph orch hardware status` cmd 63556/head
Guillaume Abrioux [Wed, 28 May 2025 11:33:10 +0000 (13:33 +0200)]
node-proxy: address `ceph orch hardware status` cmd

ce360a4a introduced a regression.

`ceph orch hardware status` fails when no hostname is passed (global
cluster hw status report).

Typical failure:

```
Error EINVAL: Traceback (most recent call last):
  File "/usr/share/ceph/mgr/mgr_module.py", line 1928, in _handle_command
    return self.handle_command(inbuf, cmd)
  File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 186, in handle_command
    return dispatch[cmd['prefix']].call(self, cmd, inbuf)
  File "/usr/share/ceph/mgr/mgr_module.py", line 527, in call
    return self.func(mgr, **kwargs)
  File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 122, in <lambda>
    wrapper_copy = lambda *l_args, **l_kwargs: wrapper(*l_args, **l_kwargs)  # noqa: E731
  File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 111, in wrapper
    return func(*args, **kwargs)
  File "/usr/share/ceph/mgr/orchestrator/module.py", line 553, in _hardware_status
    row = [k, v['sn']]
KeyError: 'sn'
```

Only the last node in the list has the `sn`, `host` and `firmwares`
information because of the wrong identation.

Fixes: https://tracker.ceph.com/issues/71472
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
7 weeks agoMerge pull request #59903 from connorfawcett/wip-connorfa-ec-consistency-2024-09...
Connor Fawcett [Wed, 28 May 2025 09:01:23 +0000 (10:01 +0100)]
Merge pull request #59903 from connorfawcett/wip-connorfa-ec-consistency-2024-09-18-1703

qa/tasks: Add a task which performs an offline check of the consistency of parity shards

7 weeks agomgr/dashboard: Creating CephFS dashboard for Grafana 62164/head
Piyush Agarwal [Sun, 13 Apr 2025 14:26:31 +0000 (19:56 +0530)]
mgr/dashboard: Creating CephFS dashboard for Grafana

Fixes: https://tracker.ceph.com/issues/70901
Signed-off-by: Piyush Agarwal <piyushagarwal14.pa@gmail.com>
7 weeks agodoc/mgr: Small improvements in rgw.rst 63481/head
Ville Ojamo [Mon, 26 May 2025 10:41:24 +0000 (17:41 +0700)]
doc/mgr: Small improvements in rgw.rst

Use double backticks consistently for module name, CLI commands and
parameters etc.

Use title case in section titles and underline them only until end of
title text.

Use "command line" instead of "cmd line" in text.

Capitalize RGW consistently.

Delete one paragraph that included a strange out of place text fragment.

Call it "Manager" consistently instead of "MGR" in text one time.

Improve language in CA cert upgrade.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
7 weeks agoMerge pull request #62496 from aainscow/interval_set_reenable_assert
Adam Kupczyk [Wed, 28 May 2025 06:07:11 +0000 (08:07 +0200)]
Merge pull request #62496 from aainscow/interval_set_reenable_assert

test/osd: Adapt strategy for testing asserts in interval_sets

7 weeks agoMerge pull request #63419 from zdover23/wip-doc-2025-05-22-mgr-localpool-62782-followup
Zac Dover [Wed, 28 May 2025 05:24:32 +0000 (15:24 +1000)]
Merge pull request #63419 from zdover23/wip-doc-2025-05-22-mgr-localpool-62782-followup

doc/mgr: edit localpool.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
7 weeks agoMerge pull request #63275 from zdover23/wip-doc-2025-05-14-dev-cephfs-mirroring-63237...
Zac Dover [Wed, 28 May 2025 05:18:53 +0000 (15:18 +1000)]
Merge pull request #63275 from zdover23/wip-doc-2025-05-14-dev-cephfs-mirroring-63237-followup-3-of-x

doc/dev/cephfs-mirroring: edit file 3 of x

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
7 weeks agoMerge pull request #63530 from anthonyeleven/balancer-advice
Zac Dover [Wed, 28 May 2025 04:45:20 +0000 (14:45 +1000)]
Merge pull request #63530 from anthonyeleven/balancer-advice

doc/rados/operations: Add settings advice to balancer.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
7 weeks agoMerge pull request #62973 from connorfawcett/exerciser-fixes-2404
Connor Fawcett [Tue, 27 May 2025 22:55:15 +0000 (23:55 +0100)]
Merge pull request #62973 from connorfawcett/exerciser-fixes-2404

common/io_exerciser: Fixes for sequencing options

7 weeks agoMerge pull request #63327 from Hezko/nvmeof-cli-text-format
Hezko [Tue, 27 May 2025 19:23:14 +0000 (22:23 +0300)]
Merge pull request #63327 from Hezko/nvmeof-cli-text-format

mgr/dashboard: Nvmeof CLI plain format support

7 weeks agodoc/rados/operations: Add settings advice to balancer.rst 63530/head
Anthony D'Atri [Tue, 27 May 2025 19:00:59 +0000 (15:00 -0400)]
doc/rados/operations: Add settings advice to balancer.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
7 weeks agoqa/crontab: update priority for tentacle upgrade command 63528/head
Laura Flores [Tue, 27 May 2025 17:09:04 +0000 (12:09 -0500)]
qa/crontab: update priority for tentacle upgrade command

The current prio (100) results in this error:
```
teuthology.exceptions.ScheduleFailError: Scheduling failed: Unable to schedule 244 jobs with priority 100.
```

I tested the prio on 150 on my teuthology setup, and this passes with the amount of jobs.

Signed-off-by: Laura Flores <lflores@ibm.com>
7 weeks agoqa/tasks: Add a task which performs an offline check of the consistency of parity... 59903/head
Connor Fawcett [Mon, 9 Dec 2024 17:02:11 +0000 (17:02 +0000)]
qa/tasks: Add a task which performs an offline check of the consistency of parity shards

Add a Python script which can be used to scan a Ceph cluster, find any erasure coded data objects and
check them for consistency. This is achieved by reading the data shards for a given object, running the data shards
through the existing EC tool and verifying the output matches the parity shards stored on the OSDs.

This commit adds a new teuthology task but does not add it to any YAMLs currently, this work will be
expanded on in future commits.

Signed-off-by: Connor Fawcett <connorfa@uk.ibm.com>
Fixes: https://tracker.ceph.com/issues/71412
7 weeks agoMerge pull request #60833 from connorfawcett/wip-vstart-runner-fns2
Kamoltat (Junior) Sirivadhna [Tue, 27 May 2025 15:41:44 +0000 (11:41 -0400)]
Merge pull request #60833 from connorfawcett/wip-vstart-runner-fns2

qa/vstart_runner: Add get_file and write_file equivalents to the LocalRemoteProcess class

Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
7 weeks agoosd/scrub: no auto-repair in 'after_repair' type of scrubs 63525/head
Ronen Friedman [Tue, 27 May 2025 15:13:09 +0000 (10:13 -0500)]
osd/scrub: no auto-repair in 'after_repair' type of scrubs

The deep scrubs that are initiated after a full "peering" repair, are
not supposed to auto-repair any errors - just report them.

This behavior detail was inadvertently changed recently, and is fixed
here.

Fixes: https://tracker.ceph.com/issues/71463
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
7 weeks agoMerge pull request #63267 from ceph/wip-yuriw-17.2.9-release.notes-main
Yuri Weinstein [Tue, 27 May 2025 14:52:55 +0000 (07:52 -0700)]
Merge pull request #63267 from ceph/wip-yuriw-17.2.9-release.notes-main

doc: quincy 17.2.9 release notes

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
7 weeks agoMerge pull request #63433 from stackhpc/cephadm-upgrade-order
Anthony D'Atri [Tue, 27 May 2025 13:48:38 +0000 (09:48 -0400)]
Merge pull request #63433 from stackhpc/cephadm-upgrade-order

doc/cephadm: fix upgrade ordering

7 weeks agocommon/io_exerciser: Fix the --sequence and --listsequence options for 62973/head
Connor Fawcett [Fri, 25 Apr 2025 10:30:58 +0000 (11:30 +0100)]
common/io_exerciser: Fix the --sequence and --listsequence options for
the IO exerciser. Also fix an incorrect read operation in SEQ7.

Signed-off-by: Connor Fawcett <connorfa@uk.ibm.com>
Fixes: https://tracker.ceph.com/issues/71074
7 weeks agomgr/dashboard: add plain output type support to nvme cli 63327/head
Tomer Haskalovitch [Thu, 8 May 2025 08:54:39 +0000 (11:54 +0300)]
mgr/dashboard: add plain output type support to nvme cli

Signed-off-by: Tomer Haskalovitch <il033030@Tomers-MBP.lan>
fixon

7 weeks agoMerge pull request #62955 from yuvalif/wip-yuval-fix-admin-flush
Yuval Lifshitz [Tue, 27 May 2025 08:08:19 +0000 (11:08 +0300)]
Merge pull request #62955 from yuvalif/wip-yuval-fix-admin-flush

rgw/logging: extract tenant from bucket name on admin flush

7 weeks agoMerge pull request #63377 from yuvalif/wip-yuval-71385
Yuval Lifshitz [Tue, 27 May 2025 08:07:50 +0000 (11:07 +0300)]
Merge pull request #63377 from yuvalif/wip-yuval-71385

rgw/logging: add mtime to get-bucket-logging response