os/bluestore: use 64 bit values for zone_state_t

Simpler and future-proof for devices with zones >= 4GB.

Signed-off-by: Sage Weil <sage@newdream.net>

os/bluestore: reimplement zone backrefs

Implement a (zone, offset) -> oid reference.  The offset is the first
offset referenced by this object in this zone; subsequent extents in the
same zone will not generate additional refs.  The ref will be removed only
when *all* refs for that object to that zone are gone.

- minimal metadata per zone (one ref to each object involved
- (zone, offset) keys are ordered for efficient sequential cleaning

Signed-off-by: Sage Weil <sage@newdream.net>

os/bluestore: fix smr allocator init

- initialize from device's pointers
- cross check against freelist manager's pointers (warn!)
- fix init_{add,rm}_free methods to do little/nothing (the other init
  method does most of what we need)

Signed-off-by: Sage Weil <sage@newdream.net>

os/bluestore: do not use null freelist with SMR

Signed-off-by: Sage Weil <sage@newdream.net>

blk/zones: implement HMSMRDevice has KernelDevice child

No need to duplicate so much code when we are just adding a few things.
Also, we want to track KernelDevice changes/improvements.

We could probably integrate these SMR capabilities directly into
KernelDevice too...

Signed-off-by: Sage Weil <sage@newdream.net>

os/bluestore: fix/simplify zoned_cleaner thread start error handling

Signed-off-by: Sage Weil <sage@newdream.net>

os/bluestore: properly reset zoned allocator on startup

Signed-off-by: Sage Weil <sage@newdream.net>

os/bluestore: force prefer_deferred_size=0 for smr

Signed-off-by: Sage Weil <sage@newdream.net>

os/bluestore: drop SMR 64K min_alloc_size restriction

used_blocks is only for fsck.

Signed-off-by: Sage Weil <sage@newdream.net>

os/bluestore/ZonedAllocator: less verbose

Signed-off-by: Sage Weil <sage@newdream.net>

os/bluestore/ZonedAllocator: simplify debug output prefix

Signed-off-by: Sage Weil <sage@newdream.net>

os/bluestore/ZonedAllocator: be consistent with hex debug output

Signed-off-by: Sage Weil <sage@newdream.net>

os/bluestore/ZonedAllocator: whitespace

Signed-off-by: Sage Weil <sage@newdream.net>

blk/zoned: remove dead VDO code

VDO won't work on an SMR device

Signed-off-by: Sage Weil <sage@newdream.net>

blk/zoned: add reset_all_zones()

Signed-off-by: Sage Weil <sage@newdream.net>

blk/zoned: print error during init

Otherwise it is easy to miss things like EPERM during testing.

Signed-off-by: Sage Weil <sage@newdream.net>

os/bluestore: adjust allocator+freelist interfaces for smr params

Instead of shoehorning these fields into alloc_size, adjust the inferfaces
to explicitly pass in zone_size and first_sequential_zone for
Allocator and FreelistManager.

Signed-off-by: Sage Weil <sage@newdream.net>

os/bluestore: select 'zoned' freelistmanager during mkfs, not mount

Signed-off-by: Sage Weil <sage@newdream.net>

Merge PR #43709 into master

* refs/pull/43709/head:
qa/tasks/cephfs/test_nfs: wait for fs to come up before exporting

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43602 from sebastian-philipp/cephadm-rgw-ipv6

mgr/cephadm: Fix RGW ipv6 frontend configuration

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Sage Weil <sage@newdream.net>

Merge pull request #43260 from cfsnyder/wip-43692-repave-osds

mgr/orchestrator: add --zap flag to 'orch osd rm'

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43539 from orozery/ms-nocrc

msg/async: support disabling data crc for protocol v2

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #31877 from rosinL/wip-fix-dpdk-link

cmake: link against DPDK shared libraries to avoid DPDK EAL double initialization

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #43693 from batrick/i53074

pybind/mgr/cephadm: upgrade MDS if no MDS is "up"

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43293 from pcuzner/granular-alerts

mgr/prometheus: expose ceph healthchecks as metrics

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge PR #43583 into master

* refs/pull/43583/head:
changes to logging code requested by Adam
remove allocation file after rollback to real-fm
bug-fix close db when umount failed to store allocation file
Bug-Fix: When restoring allocation from file use a temp allocator and only copy the allocation to the shared-allocator after the file was verified and all extents were cleared

Reviewed-by: Adam Kupczyk <akucpzyk@redhat.com>

Merge PR #43645 into master

* refs/pull/43645/head:
os/bluestore: Disable compaction then no-column-b is storing allocations to bluefs file

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Gabriel Benhanokh <gbenhano@redhat.com>

qa/tasks/cephfs/test_nfs: wait for fs to come up before exporting

Signed-off-by: Sage Weil <sage@newdream.net>

Merge pull request #41325 from rhcs-dashboard/wip-cephadm_box-master

cephadm: add cephadm sandbox (Docker in Docker)

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sebastian-philipp <NOT@FOUND>

Merge pull request #43692 from liewegas/misc-rook-1

mgr/orchestrator: log exception from wrapper

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43330 from sebastian-philipp/CEPHADM_STRAY_DAEMON

doc/cephadm/operations: extend CEPHADM_STRAY_DAEMON

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #43601 from sebastian-philipp/doc-cephadm-osd-similar-disk-layout

doc/cephadm: improve "Deploying OSDs on multiple similar hosts"

Reviewed-by: Joao Eduardo Luis <joao@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #43622 from Daniel-Pivonka/cephadm-doc-osd-replace-host

doc/cephadm: note that replacment osd needs to be on same host as removed osd

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #43681 from cyx1231st/wip-seastore-fix-test-setup-teardown

crimson/os/seastore: initialize tests in seastar reactor

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

cephadm/box: add no-tmpfs flag prepare osd bluestore

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

pybind/mgr/cephadm: upgrade MDS if no MDS is "up"

The upgrade process can get stuck if an MDS crashes. This should be rare
when straddling v16.2.5 where the compatset of the file system inherits
the FSMap "default". The MDS from pre-v16.2.5 do not yet share a
compatset with the mons so the mons will do no promotions, causing
upgrade task to get stuck.

Fixes: https://tracker.ceph.com/issues/53074
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #43689 from rzarzynski/wip-auth-drop-get_supported_con_modes

auth: drop unused get_supported_con_modes() from AuthServer.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

mgr/orchestrator: log exception from wrapper

This lets us see a proper traceback when we are calling across
modules.

Signed-off-by: Sage Weil <sage@newdream.net>

auth: drop unused get_supported_con_modes() from AuthServer.

In 2d530938753313a776258ff9fa8208db637c9d96 its last user has
been removed.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #43684 from ybwang0211/doc-host

doc: The description of "Host" on the page is inconsistent

Signed-off-by: wangyingbin ybwang0211@163.com
Reviewed-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #43581 from cbodley/wip-52800

rgw: fix lock scope in ObjectCache::get()

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #43170 from thotz/removeusercaps-in-modifyuser

rgw: remove dead code for user-caps from RGWOp_User_Modify

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #43153 from ivancich/wip-add-bucket-listing-log

rgw: add logging to bucket listing so calls are better understood

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>

Merge pull request #42704 from wzbxqt327/patch-1

rgw,doc: fix command problem

Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #41323 from pkalever/cookie

rbd-nbd: generate and send device cookie with netlink connect request

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #43584 from rhcs-dashboard/add-multiple-hosts-at-once

mgr/dashboard: Cluster Creation Add multiple hosts at once

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #43605 from rhcs-dashboard/bonding-metrics

monitoring: ethernet bonding filter in Network Load.

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #43603 from rhcs-dashboard/fix-gather-facts-fetch-UI

mgr/dashboard: fetch host facts only if get_facts orch feature available

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #43661 from rhcs-dashboard/review-page-fix

mgr/dashboard: Cluster expansion review page minor bug fixes

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

crimson/os/seastore: initialize tests in seastar reactor

testing::Test from gtest is constructed and destructed outside seastar
application. It is unexpected for most seastore components, and causing
undefined behaviors.

For example, when registering metrics during construction, the logic
needs to be called inside seastar reactor thread because metrics are
maintained in reactor thread-local variables.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: cleanup transaction_manager_test_state

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/randomblock-manager: cleanup unit test

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/cache: get block-size from reader

Cache cannot get the correct block size before SegmentManager is
mounted.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/store-nbd: cleanup headers

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/journal: proper close journal when test finishes

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

doc: The description of "Host" on the page is inconsistent

In the "https://docs.ceph.com/en/latest/radosgw/adminops/#radosgw-admin-ops" page, the description of "Host" is not uniform, so I changed it.

Signed-off-by: wangyingbin <ybwang0211@163.com>

monitoring: ethernet bonding filter in Network Load

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #43630 from kkang-wr/master

cmake: add support for python 3.10

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #43648 from rzarzynski/wip-crimson-proper-addrs-for-hbmsgrs

crimson/osd: fix network address selection for hearbeat's messengers.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

Merge pull request #43671 from javicacheiro/python_data_as_binary

doc/rbd: correct sample code to use byte string for data

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #43674 from rzarzynski/wip-crimson-net-honor_listen_type

crimson/net: FixedCPUServerSocket::accept() respects the listening addr's type.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

mgr/prometheus: remove cmake tests

Temporary removal of the cmake test integration

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>

crimson/net: FixedCPUServerSocket::accept() respects the listening addr's type.

For the sake of compliance with the classical OSD where the type
of the listening address is being reflected in the address type
of an accepted connection:

```
int PosixServerSocketImpl::accept(ConnectedSocket *sock, const SocketOptions &opt, entity_addr_t *out, Worker *w) {
  // ...
  sockaddr_storage ss;
  // ...
  int sd = accept_cloexec(_fd, (sockaddr*)&ss, &slen);
  if (sd < 0) {
    return -ceph_sock_errno();
  }

  // ...

  out->set_type(addr_type);
  out->set_sockaddr((sockaddr*)&ss);
  handler.set_priority(sd, opt.priority, out->get_family());
}
```

In Rook crimson binds explicitly to v2 address:

```
INFO  2021-10-26 17:55:08,116 [shard 0] osd - picked address v2:0.0.0.0:0/0
ERROR 2021-10-26 17:55:08,116 [shard 0] none - Falling back to public interface
INFO  2021-10-26 17:55:08,116 [shard 0] osd - picked address v2:0.0.0.0:0/0
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge PR #43627 into master

* refs/pull/43627/head:
Revert "Merge pull request #42099 from aclamk/wip-bluefs-fine-grain-locking-2"

Reviewed-by: Neha Ojha <nojha@redhat.com>

doc: data must be a byte string

Data must be a byte string in python 3.

Signed-off-by: Javier Cacheiro <javier.cacheiro.lopez@cesga.es>

Merge pull request #43668 from rhcs-dashboard/kube-v1_events-update

mgr/k8sevents: pin the kubernetes version to 11.0.0

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

qa/workunits/rbd: test map/attach with --show-cookie/--cookie options

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>

rbd-nbd: allow user to specify cookie at map

Allow user to specify cookie of choice at the time of map

$ rbd device attach rbd-pool/image --device /dev/nbd0 \
--cookie 6f85d970-10b2-456b-8baf-676aa4d782e4 --options try-netlink

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>

rbd: add --show-cookie/--cookie option for map/attach commands

Example:
$ rbd device map rbd-pool/image --show-cookie --try-netlink --device-type nbd

$ rbd device attach rbd-pool/image --device /dev/nbd0 \
      --cookie 6f85d970-10b2-456b-8baf-676aa4d782e4 --device-type nbd

older Kernel versions can use --force to skip the cookie validation

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>

rbd-nbd: allow attach without --cookie for old kernel versions

For backward compatibility allow attach without --cookie option:

[root@linux-vm1]# rbd-nbd attach rbd-pool/image0 --device /dev/nbd0
/dev/nbd0

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>

rbd-nbd: show per device cookie with list command

[root@linux-vm1]# rbd-nbd list-mapped
id    pool      namespace  image   snap  device     cookie
8133  rbd-pool             image0  -     /dev/nbd0  c704cb91-c6cf-466e-a335-0e935c0d5e47

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>

rbd-nbd: mandate device cookie for attach command

[root@linux-vm1]# rbd-nbd attach rbd-pool/image0 --device /dev/nbd0 \
                          --cookie c704cb91-c6cf-466e-a335-0e935c0d5e47
/dev/nbd0

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>

rbd-nbd: provide a flag to show device cookie with map command

[root@linux-vm1]# rbd-nbd map rbd-pool/image0 --try-netlink --show-cookie
/dev/nbd0 c704cb91-c6cf-466e-a335-0e935c0d5e47

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>

rbd-nbd: generate and send device cookie with netlink connect request

[root@linux-vm1]# rbd-nbd map rbd-pool/image0 --try-netlink
/dev/nbd0

[root@linux-vm1]# cat /sys/block/nbd0/backend
c704cb91-c6cf-466e-a335-0e935c0d5e47

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>

mgr/orchestrator: add --zap flag to 'orch osd rm'

Adds the ability to zap OSD devices after removal, implemented as a flag
on the 'orch osd rm' command.

Fixes: https://tracker.ceph.com/issues/43692
Signed-off-by: Cory Snyder <csnyder@iland.com>

mgr/k8sevents: pin the kubernetes version to 11.0.0

Fixes: https://tracker.ceph.com/issues/53044
Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: gather facts should only be fetched when orch backend is cephadm

Fixes: https://tracker.ceph.com/issues/52981
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Gather facts in UI should only be fetched if there is orch available and
get_facts feature is available for that orch backend.

mgr/dashboard: Cluster expansion review page minor bug fixes

Fix the Total Memory coming up as NaN Undefined
Remove `Add` Button in the Cluster Details table

Fixes: https://tracker.ceph.com/issues/53038
Signed-off-by: Nizamudeen A <nia@redhat.com>

doc/cephadm/operations: extend CEPHADM_STRAY_DAEMON

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

doc/cephadm: osd.rst: s/Note, /.. note:: /

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

doc/cephadm: osd.rst: s/DriveGroup/OSD spec/

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

doc/cephadm: osd.rst: Fix yaml comments

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

doc/cephadm: Add "Deploying OSDs on multiple similar hosts"

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

doc/cephadm: indent yaml specs

properly conform with other service types

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

mgr/cephadm: Fix RGW ipv6 frontend configuration

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43640 from rhcs-dashboard/module-status-guard-error-handling

mgr/dashboard: Proper error handling in module status guard

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #43639 from rhcs-dashboard/angular-11-form-fix

mgr/dashboard: Fix for form inside form closing issue

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #43560 from pcuzner/fix-orch-device-zap

mgr/cephadm: improve validation of orch device zap

Reviewed-by: Sage Weil <sage@newdream.net>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43499 from jecluis/wip-cephadm-insecure

cephadm: allow pulling from insecure registries

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43502 from adk3798/rm-testing2

mgr/cephadm: remove host addr from agent deps

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #43579 from sebastian-philipp/cephadm-monitoring-ipv6

mgr/cephadm: Fix IPv6 in monitoring services

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #43632 from myoungwon/wip-alloc-free-rbm-paddr

seastore: add alloc/free extent for RBM based on paddr_t

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #43641 from athanatos/sjust/wip-52805

crimson/os/seastore: fix LBABtree::lower_bound behavior

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

Merge pull request #43651 from rzarzynski/wip-crimson-net-fix-nonceportcheck

crimson/net: don't enforce peer-perceived-myaddr matches myaddr if haven't learned it yet.

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

mgr/prometheus: update promtool testcase location

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>

Merge pull request #43650 from rzarzynski/wip-crimson-improve-dbgs

crimson, monmap: fix / improve miscellaneous debugs

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #43652 from rzarzynski/wip-crimson-osd-seqmeta

crimson/osd: write object store's meta sequentially.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/.../lba_btree: fix min_capacity condition

Reducing the size of split_merge_multi has an interesting side effect of
causing removes to happen on some leaf nodes immediately after split.
After split, child nodes would have size 72 or 73.  At size 72, the node
would be at_min_size() and a remove would put it below causing the
at_min_size() condition to fail and hande_merge to misbehave.

Replace at_min_capacity() with below_min_capacity().
below_min_capacity() will not be true for any child of a split, and
asserts that the child is below capacity by no more than 1.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/.../lba_btree: fix lower_bound at_boundary()

Clarify that lookup_depth_range may return an iterator at_boundary() and
audity users.

Fix LBABtree::lookup to correctly handle at_boundary() after the call to
lookup_depth_range.

Fixes: https://tracker.ceph.com/issues/52805
Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/lba_manager/lba_btree: factor out iterator::handle_boundary

Factor out helper to adjust iterators at_boundary().

Signed-off-by: Samuel Just <sjust@redhat.com>