]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agolibrbd: don't temporarily shut down crypto when flattening
Ilya Dryomov [Thu, 15 Sep 2022 07:33:01 +0000 (09:33 +0200)]
librbd: don't temporarily shut down crypto when flattening

(Temporarily) shutting down crypto can lead to data corruption in the
face of concurrent I/O, especially when flatten operation is proxied to
the remote lock owner.  This was added to be able to read, optionally
modify and write crypto header without it being subjected to remapping
and encryption itself.  read_header() and write_header() now achieve
that by specifying CRYPTO_HEADER area explicitly.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: move get_file_offset() into CryptoObjectDispatch
Ilya Dryomov [Mon, 26 Sep 2022 10:57:16 +0000 (12:57 +0200)]
librbd: move get_file_offset() into CryptoObjectDispatch

This method doesn't propagate area.  Since its only user is
CryptoObjectDispatch which is now applied only to DATA area,
move get_file_offset() there to avoid misuse in the future.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: apply CryptoObjectDispatch layer only to DATA area
Ilya Dryomov [Fri, 9 Sep 2022 16:34:49 +0000 (18:34 +0200)]
librbd: apply CryptoObjectDispatch layer only to DATA area

Objects in CRYPTO_HEADER area should not be subjected to encryption.
Unit tests needed adjustment because MockCryptoInterface is configured
with DATA_OFFSET = 4 * 1024 * 1024, thus disqualifying object 0.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: propagate area down to file_to_extents()
Ilya Dryomov [Wed, 14 Sep 2022 12:55:56 +0000 (14:55 +0200)]
librbd: propagate area down to file_to_extents()

- readahead and PWL cache are limited to DATA area as explained in
  the previous commit
- DATA area is assumed for the journal as encryption can't be used
  with journaling anyway

To postpone the churn associated with passing area through
ImageDispatchInterface (where only WriteLogImageDispatch and
ImageDispatch care), add a new image dispatch flag.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: pass area to ImageDispatchSpec::create_*()
Ilya Dryomov [Wed, 14 Sep 2022 10:40:58 +0000 (12:40 +0200)]
librbd: pass area to ImageDispatchSpec::create_*()

- DATA area is assumed at the API layer as there is no way to pass
  an area
- DATA area is assumed by ImageWriteback because PWL cache persists
  image extents as provided by the user without any kind of designator
  and therefore can be active only in either area
- luks::FlattenRequest operates on CRYPTO_HEADER area

The passed area is acted upon in ImageDispatchSpec constructor in the
next commit.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: return area from extents_to_file()
Ilya Dryomov [Mon, 12 Sep 2022 19:05:44 +0000 (21:05 +0200)]
librbd: return area from extents_to_file()

Note that, as suggested by extents_to_file() signature, all returned
image extents would pertain to the same area.  This means that an area
boundary must coincide with an object boundary.

luks::FormatRequest is actually more strict: crypto header area size is
set to a multiple of stripe period (i.e. one or more whole objects).

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: introduce ImageArea and split remap_extents() into two methods
Ilya Dryomov [Mon, 12 Sep 2022 18:24:29 +0000 (20:24 +0200)]
librbd: introduce ImageArea and split remap_extents() into two methods

Since remap in either direction can really be done only once, iterating
through image dispatch layers in ImageDispatcher::remap_extents() makes
no sense.  For now, just replace the iteration with CryptoImageDispatch
lookup.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: pass image_extents to create_{discard,write_same}()
Ilya Dryomov [Sun, 11 Sep 2022 10:10:27 +0000 (12:10 +0200)]
librbd: pass image_extents to create_{discard,write_same}()

These are still taking off and len separately which is inconsistent
with the rest of ImageDispatchSpec and also ImageDiscardRequest and
ImageWriteSameRequest.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: CopyupRequest can move image_extents instead of copying
Ilya Dryomov [Sun, 11 Sep 2022 08:10:25 +0000 (10:10 +0200)]
librbd: CopyupRequest can move image_extents instead of copying

image_extents is already taken by rvalue reference.
CopyupRequest::create() callers are prepared for the move.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #49217 from zdover23/wip-doc-2022-12-04-rados-ops-health-check...
zdover23 [Sat, 3 Dec 2022 18:30:27 +0000 (04:30 +1000)]
Merge pull request #49217 from zdover23/wip-doc-2022-12-04-rados-ops-health-check-5-of-5-prompts

doc/rados: add prompts to health-checks (5 of 5)

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #49216 from zdover23/wip-doc-2022-12-04-rados-ops-health-check...
zdover23 [Sat, 3 Dec 2022 18:27:11 +0000 (04:27 +1000)]
Merge pull request #49216 from zdover23/wip-doc-2022-12-04-rados-ops-health-check-4-of-5-prompts

doc/rados: add prompts to health-checks (4 of 5)

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #49215 from zdover23/wip-doc-2022-12-04-rados-ops-health-check...
zdover23 [Sat, 3 Dec 2022 18:22:18 +0000 (04:22 +1000)]
Merge pull request #49215 from zdover23/wip-doc-2022-12-04-rados-ops-health-check-3-of-5-prompts

doc/rados: add prompts to health-checks (3 of 5)

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #49214 from zdover23/wip-doc-2022-12-04-rados-ops-health-chech...
zdover23 [Sat, 3 Dec 2022 18:21:16 +0000 (04:21 +1000)]
Merge pull request #49214 from zdover23/wip-doc-2022-12-04-rados-ops-health-chech-2-of-5-prompts

doc/rados: add prompts to health-checks (2 of 5)

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #49213 from zdover23/wip-doc-2022-12-04-rados-ops-health-chech...
zdover23 [Sat, 3 Dec 2022 18:15:06 +0000 (04:15 +1000)]
Merge pull request #49213 from zdover23/wip-doc-2022-12-04-rados-ops-health-chech-1-of-4-prompts

doc/rados: add prompts to health-checks (1 of 5)

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #49212 from zdover23/wip-doc-2022-12-04-rados-ops-erasure-code...
zdover23 [Sat, 3 Dec 2022 18:09:25 +0000 (04:09 +1000)]
Merge pull request #49212 from zdover23/wip-doc-2022-12-04-rados-ops-erasure-code-shec-prompts

doc/rados: add prompts to erasure-code-shec.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agoMerge pull request #49211 from zdover23/wip-doc-2022-12-04-rados-ops-erasure-code...
zdover23 [Sat, 3 Dec 2022 18:00:52 +0000 (04:00 +1000)]
Merge pull request #49211 from zdover23/wip-doc-2022-12-04-rados-ops-erasure-code-erasure-code-lrc-prompts

doc/rados: add prompts to erasure-code-lrc.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/rados: add prompts to health-checks (5 of 5) 49217/head
Zac Dover [Sat, 3 Dec 2022 17:03:53 +0000 (03:03 +1000)]
doc/rados: add prompts to health-checks (5 of 5)

Add unselectable prompts to doc/rados/operations/health-checks.rst,
fifth 300 lines.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rados: add prompts to health-checks (4 of 5) 49216/head
Zac Dover [Sat, 3 Dec 2022 16:56:31 +0000 (02:56 +1000)]
doc/rados: add prompts to health-checks (4 of 5)

Add unselectable prompts to doc/rados/operations/health-checks.rst,
fourth 300 lines.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rados: add prompts to health-checks (3 of 5) 49215/head
Zac Dover [Sat, 3 Dec 2022 16:49:02 +0000 (02:49 +1000)]
doc/rados: add prompts to health-checks (3 of 5)

Add unselectable prompts to doc/rados/operations/health-checks.rst,
third 300 lines.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rados: add prompts to health-checks (2 of 5) 49214/head
Zac Dover [Sat, 3 Dec 2022 16:33:42 +0000 (02:33 +1000)]
doc/rados: add prompts to health-checks (2 of 5)

Add unselectable prompts to doc/rados/operations/health-checks.rst,
second 300 lines.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rados: add prompts to health-checks (1 of 5) 49213/head
Zac Dover [Sat, 3 Dec 2022 16:13:08 +0000 (02:13 +1000)]
doc/rados: add prompts to health-checks (1 of 5)

Add unselectable prompts to doc/rados/operations/health-checks.rst,
first 300 lines.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rados: add prompts to erasure-code-shec.rst 49212/head
Zac Dover [Sat, 3 Dec 2022 15:57:13 +0000 (01:57 +1000)]
doc/rados: add prompts to erasure-code-shec.rst

Add unselectable prompts to doc/rados/operations/erasure-code-shec.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rados: add prompts to erasure-code-lrc.rst 49211/head
Zac Dover [Sat, 3 Dec 2022 15:28:11 +0000 (01:28 +1000)]
doc/rados: add prompts to erasure-code-lrc.rst

Add unselectable prompts to doc/rados/operations/erasure-code-lrc.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49202 from zdover23/wip-doc-2022-12-01-rados-ops-erasure-code...
zdover23 [Sat, 3 Dec 2022 03:10:05 +0000 (13:10 +1000)]
Merge pull request #49202 from zdover23/wip-doc-2022-12-01-rados-ops-erasure-code-jerasure-prompts

doc/rados: add prompts to erasure-code-jerasure.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49201 from zdover23/wip-doc-2022-12-01-rados-ops-erasure-code...
zdover23 [Sat, 3 Dec 2022 03:07:32 +0000 (13:07 +1000)]
Merge pull request #49201 from zdover23/wip-doc-2022-12-01-rados-ops-erasure-code-isa-prompts

doc/rados: add prompts to erasure-code-isa

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49200 from zdover23/wip-doc-2022-12-01-rados-ops-erasure-code...
zdover23 [Sat, 3 Dec 2022 03:02:27 +0000 (13:02 +1000)]
Merge pull request #49200 from zdover23/wip-doc-2022-12-01-rados-ops-erasure-code-clay-prompts

doc/rados: add prompts to erasure-code-clay.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49162 from Gaoweinan/main-rgw-rgwerror-StatementRepetition-gaoweinan
Daniel Gryniewicz [Fri, 2 Dec 2022 16:47:26 +0000 (11:47 -0500)]
Merge pull request #49162 from Gaoweinan/main-rgw-rgwerror-StatementRepetition-gaoweinan

radosgw:Fix repeated statement

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agodoc/rados: add prompts to erasure-code-jerasure.rst 49202/head
Zac Dover [Fri, 2 Dec 2022 16:27:59 +0000 (02:27 +1000)]
doc/rados: add prompts to erasure-code-jerasure.rst

Add unselectable prompts to
doc/rados/operations/erasure-code-jerasure.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rados: add prompts to erasure-code-isa 49201/head
Zac Dover [Fri, 2 Dec 2022 16:16:43 +0000 (02:16 +1000)]
doc/rados: add prompts to erasure-code-isa

Add unselectable prompts to doc/rados/operations/erasure-code-isa.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rados: add prompts to erasure-code-clay.rst 49200/head
Zac Dover [Fri, 2 Dec 2022 16:11:49 +0000 (02:11 +1000)]
doc/rados: add prompts to erasure-code-clay.rst

Add unselectable prompts to doc/rados/operations/erasure-code-clay.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48549 from pkalever/snap-list
Ilya Dryomov [Fri, 2 Dec 2022 12:18:08 +0000 (13:18 +0100)]
Merge pull request #48549 from pkalever/snap-list

cls/rbd: update last_read in group::snap_list

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #49177 from yuvalif/remove-pubsub-release-notes
Yuval Lifshitz [Fri, 2 Dec 2022 06:00:03 +0000 (08:00 +0200)]
Merge pull request #49177 from yuvalif/remove-pubsub-release-notes

rgw: update release notes on the removal of pubsub

2 years agoMerge pull request #49052 from tchaikov/wip-fmt-v9
Kefu Chai [Fri, 2 Dec 2022 05:03:50 +0000 (13:03 +0800)]
Merge pull request #49052 from tchaikov/wip-fmt-v9

*: include fmt/ostream.h if FMT_VERSION >= 9

Reviewed-by: Tim Serong <tserong@suse.com>
2 years agoMerge pull request #49185 from zdover23/wip-doc-2022-12-01-rados-ops-devices-prompts
zdover23 [Fri, 2 Dec 2022 02:45:41 +0000 (12:45 +1000)]
Merge pull request #49185 from zdover23/wip-doc-2022-12-01-rados-ops-devices-prompts

doc/rados: add prompts to devices.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/rados: add prompts to devices.rst 49185/head
Zac Dover [Fri, 2 Dec 2022 02:28:58 +0000 (12:28 +1000)]
doc/rados: add prompts to devices.rst

Add unselectable prompts to doc/rados/operations/devices.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49182 from zdover23/wip-doc-2022-12-01-rados-ops-crush-map-prompts
zdover23 [Fri, 2 Dec 2022 02:28:06 +0000 (12:28 +1000)]
Merge pull request #49182 from zdover23/wip-doc-2022-12-01-rados-ops-crush-map-prompts

doc/rados: add prompts to crush-map.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/rados: add prompts to crush-map.rst 49182/head
Zac Dover [Fri, 2 Dec 2022 02:15:52 +0000 (12:15 +1000)]
doc/rados: add prompts to crush-map.rst

Add unselectable prompts to doc/rados/operations/crush-map.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48838 from badone/wip-ceph-ansible-suite-nightlies-disable
Brad Hubbard [Fri, 2 Dec 2022 01:51:57 +0000 (11:51 +1000)]
Merge pull request #48838 from badone/wip-ceph-ansible-suite-nightlies-disable

qa/tests: Remove octopus ceph-ansible tests

Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agorgw: update release notes on the removal of pubsub 49177/head
yuval Lifshitz [Thu, 1 Dec 2022 15:43:35 +0000 (17:43 +0200)]
rgw: update release notes on the removal of pubsub

Signed-off-by: yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #48609 from cbodley/wip-rgw-encrypt-compress-release-note
Casey Bodley [Thu, 1 Dec 2022 18:43:18 +0000 (13:43 -0500)]
Merge pull request #48609 from cbodley/wip-rgw-encrypt-compress-release-note

PendingReleaseNotes: add note for rgw compression+encryption

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoPendingReleaseNotes: add note for rgw compression+encryption 48609/head
Casey Bodley [Mon, 24 Oct 2022 16:40:07 +0000 (12:40 -0400)]
PendingReleaseNotes: add note for rgw compression+encryption

adds release notes for the feature added in
https://github.com/ceph/ceph/pull/46188

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #48996 from yuvalif/wip-yuval-remove-pubsub
Casey Bodley [Thu, 1 Dec 2022 14:00:26 +0000 (09:00 -0500)]
Merge pull request #48996 from yuvalif/wip-yuval-remove-pubsub

remove pubsub from the RGW

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoMerge pull request #49167 from zdover23/wip-doc-2022-12-01-cephadm-upgrade-warning...
zdover23 [Thu, 1 Dec 2022 07:43:16 +0000 (17:43 +1000)]
Merge pull request #49167 from zdover23/wip-doc-2022-12-01-cephadm-upgrade-warning-removal

doc/cephadm - remove "danger" admonition

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2 years agodoc/cephadm - remove "danger" admonition 49167/head
Zac Dover [Thu, 1 Dec 2022 07:27:16 +0000 (17:27 +1000)]
doc/cephadm - remove "danger" admonition

Remove the "Danger!" admonition that warned against upgrading to Pacific
from an older version of Ceph. That admonition was meant to protect
against the issue discussed here: https://tracker.ceph.com/issues/53062.
That issue was fixed in this PR:
https://github.com/ceph/ceph/pull/43793.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49161 from zdover23/wip-doc-2022-12-01-cephadm-host-management...
zdover23 [Thu, 1 Dec 2022 05:03:43 +0000 (15:03 +1000)]
Merge pull request #49161 from zdover23/wip-doc-2022-12-01-cephadm-host-management-grammar

doc/cephadm: improve grammar in "listing hosts"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #48930 from joscollin/wip-replace-isinstance-current-screen
Venky Shankar [Thu, 1 Dec 2022 04:33:49 +0000 (10:03 +0530)]
Merge pull request #48930 from joscollin/wip-replace-isinstance-current-screen

cephfs-top: replace isinstance call with current_screen variable

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
2 years agoMerge pull request #49041 from joscollin/wip-reset-filters-nofs
Venky Shankar [Thu, 1 Dec 2022 04:32:41 +0000 (10:02 +0530)]
Merge pull request #49041 from joscollin/wip-reset-filters-nofs

cephfs-top: reset filters when no fs

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
2 years agoMerge pull request #49160 from Gaoweinan/main-doc-docerror-radosgw-gaoweinan
Anthony D'Atri [Thu, 1 Dec 2022 04:13:13 +0000 (23:13 -0500)]
Merge pull request #49160 from Gaoweinan/main-doc-docerror-radosgw-gaoweinan

doc/radosgw:Fix index error

2 years agoradosgw:Fix repeated statement 49162/head
gaoweinan [Thu, 1 Dec 2022 03:21:54 +0000 (11:21 +0800)]
radosgw:Fix repeated statement

Fix repeated statement.
There are two statements "using rgw::IAM::s3ListBucket;" in “ceph/src/test/rgw/test_rgw_iam_policy.cc”, it's repeated.

Fix:https://tracker.ceph.com/issues/58135

Signed-off-by: gaoweinan <gaoweinan@inspur.com>
2 years agodoc/cephadm: improve grammar in "listing hosts" 49161/head
Zac Dover [Thu, 1 Dec 2022 02:52:45 +0000 (12:52 +1000)]
doc/cephadm: improve grammar in "listing hosts"

Improve the grammar in host-management.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/radosgw:Fix index error 49160/head
gaoweinan [Thu, 1 Dec 2022 02:19:45 +0000 (10:19 +0800)]
doc/radosgw:Fix index error

Fix index error.There is a sentence in the note of chapter "Pool Placement and storage classes": "If you have not done any previous Multisite Configuration", so it seems that chapter "Multisite Configuration" precedes chapter "Pool Placement and storage classes", but actually chapter "Multisite Configuration" follows chapter "Pool Placement and storage classes" in the index.

Fix:https://tracker.ceph.com/issues/58134

Signed-off-by: gaoweinan <gaoweinan@inspur.com>
2 years agoMerge pull request #49153 from Gaoweinan/master-doc-docerror-WordRepetition-gaoweinan
Anthony D'Atri [Thu, 1 Dec 2022 01:49:20 +0000 (20:49 -0500)]
Merge pull request #49153 from Gaoweinan/master-doc-docerror-WordRepetition-gaoweinan

doc/radosgw/swift: Fix repeated word

2 years agodoc/radosgw/swift: Fix repeated word 49153/head
gaoweinan [Wed, 30 Nov 2022 07:50:05 +0000 (15:50 +0800)]
doc/radosgw/swift: Fix repeated word

Fix repeated word in swift API

fix:https://tracker.ceph.com/issues/58124

Signed-off-by: gaoweinan <gaoweinan@inspur.com>
2 years agoMerge pull request #49156 from zdover23/wip-doc-2022-12-01-cephadm-install-airgap...
zdover23 [Thu, 1 Dec 2022 00:15:54 +0000 (10:15 +1000)]
Merge pull request #49156 from zdover23/wip-doc-2022-12-01-cephadm-install-airgap-grammar

doc/cephadm: improve airgapping procedure grammar

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/cephadm: improve airgapping procedure grammar 49156/head
Zac Dover [Wed, 30 Nov 2022 23:01:17 +0000 (09:01 +1000)]
doc/cephadm: improve airgapping procedure grammar

Improve the grammar of the airgapping procedure.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agorgw/pubsub: remove unnecessary REST abstraction layer 48996/head
Yuval Lifshitz [Mon, 21 Nov 2022 18:04:53 +0000 (20:04 +0200)]
rgw/pubsub: remove unnecessary REST abstraction layer

this was used for an already deprecated non s3 API for pubsub
also, some texts changes in docs and error messages

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agorgw/pubsub: remove deprecated pubsub event types
Yuval Lifshitz [Mon, 21 Nov 2022 12:52:08 +0000 (14:52 +0200)]
rgw/pubsub: remove deprecated pubsub event types

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agorgw/pubsub: remove pusub subscription functionality
Yuval Lifshitz [Mon, 21 Nov 2022 11:52:26 +0000 (13:52 +0200)]
rgw/pubsub: remove pusub subscription functionality

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agorgw/pubsub: remove pusub sync module functionality
Yuval Lifshitz [Sun, 20 Nov 2022 18:03:03 +0000 (20:03 +0200)]
rgw/pubsub: remove pusub sync module functionality

also update the documentation

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2 years agoMerge pull request #48908 from kalebskeithley/ceph-zipper-utils
Casey Bodley [Wed, 30 Nov 2022 16:55:03 +0000 (11:55 -0500)]
Merge pull request #48908 from kalebskeithley/ceph-zipper-utils

rgw: refactor selected files for better above- vs below-the-line

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoMerge pull request #49147 from zdover23/wip-doc-2022-11-30-cephadm-install-airgap...
zdover23 [Wed, 30 Nov 2022 04:52:34 +0000 (14:52 +1000)]
Merge pull request #49147 from zdover23/wip-doc-2022-11-30-cephadm-install-airgap-formatting

doc/cephadm: format airgap install procedure

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/cephadm: format airgap install procedure 49147/head
Zac Dover [Wed, 30 Nov 2022 04:31:17 +0000 (14:31 +1000)]
doc/cephadm: format airgap install procedure

Format the procedure that explains how to install an airgapped cluster.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49060 from rhcs-dashboard/accept-cors-dashboard
Nizamudeen A [Wed, 30 Nov 2022 04:26:33 +0000 (09:56 +0530)]
Merge pull request #49060 from rhcs-dashboard/accept-cors-dashboard

mgr/dashboard: allow cross origin when the url is set

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #49143 from zdover23/wip-doc-2022-11-30-44346-update
zdover23 [Wed, 30 Nov 2022 04:16:06 +0000 (14:16 +1000)]
Merge pull request #49143 from zdover23/wip-doc-2022-11-30-44346-update

doc/cephadm: add airgapped install procedure

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
2 years agodoc/cephadm: add airgapped install procedure 49143/head
Zac Dover [Wed, 30 Nov 2022 03:56:52 +0000 (13:56 +1000)]
doc/cephadm: add airgapped install procedure

Add a procedure describing an installation with an airgapped registry.

This commit ingests work done in https://github.com/ceph/ceph/pull/44346
that was abandoned for lo these past eleven months. The PR connected
with this commit supersedes that PR.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #47969 from myoungwon/wip-rbm-integration-step1
Yingxin [Wed, 30 Nov 2022 01:23:46 +0000 (09:23 +0800)]
Merge pull request #47969 from myoungwon/wip-rbm-integration-step1

crimson/os/seastore: add RBM OOL path

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #49131 from cbodley/wip-rgw-log-identity-type
Casey Bodley [Tue, 29 Nov 2022 21:28:01 +0000 (16:28 -0500)]
Merge pull request #49131 from cbodley/wip-rgw-log-identity-type

rgw: initialize rgw_log_entry::identity_type

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2 years agorgw: refactor selected files for better above- vs below-the-line 48908/head
Kaleb S. KEITHLEY [Wed, 16 Nov 2022 12:36:47 +0000 (07:36 -0500)]
rgw: refactor selected files for better above- vs below-the-line

Based on https://github.com/ceph/ceph/pull/48272, separate selected methods
into new files for above-the-line vs below-the-line linkage. This is more of
the work to prepare for eventual merging of the loadable module implementation.

"Utility" functions that don't reference the Store are moved, e.g. from
rgw_zone.cc, into the new rgw_zone_utils.cc. Methods in the new *_utils.cc
files are above-the-line.

Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
2 years agorgw: default-initialize delete_multi_obj_op_meta 49131/head
Casey Bodley [Tue, 29 Nov 2022 18:30:04 +0000 (13:30 -0500)]
rgw: default-initialize delete_multi_obj_op_meta

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agorgw: initialize rgw_log_entry::identity_type
Casey Bodley [Tue, 29 Nov 2022 15:11:03 +0000 (10:11 -0500)]
rgw: initialize rgw_log_entry::identity_type

uninitialized identity_type field was causing unit test failures from
check-generated.sh:

**** rgw_log_entry test 2 dump_json check failed ****
   ceph-dencoder type rgw_log_entry select_test 2 dump_json > /tmp/typ-AW7AEODB3
   ceph-dencoder type rgw_log_entry select_test 2 encode decode dump_json > /tmp/typ-0NX4cmLHR
21c21
<     "identity_type": 3599295712
---
>     "identity_type": 2072560864

Fixes: https://tracker.ceph.com/issues/58115
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #49136 from zdover23/wip-doc-2022-11-30-glossary-dashboard-module
zdover23 [Tue, 29 Nov 2022 17:44:43 +0000 (03:44 +1000)]
Merge pull request #49136 from zdover23/wip-doc-2022-11-30-glossary-dashboard-module

doc/glossary: add "Dashboard Module"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/glossary: add "Dashboard Module" 49136/head
Zac Dover [Tue, 29 Nov 2022 17:26:04 +0000 (03:26 +1000)]
doc/glossary: add "Dashboard Module"

Define "Dashboard Module" in doc/glossary.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49133 from zdover23/wip-doc-2022-11-30-glossary-rados-cluster
zdover23 [Tue, 29 Nov 2022 17:06:20 +0000 (03:06 +1000)]
Merge pull request #49133 from zdover23/wip-doc-2022-11-30-glossary-rados-cluster

doc/glossary: add "RADOS Cluster"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/glossary: add "RADOS Cluster" 49133/head
Zac Dover [Tue, 29 Nov 2022 16:52:31 +0000 (02:52 +1000)]
doc/glossary: add "RADOS Cluster"

Define "RADOS Cluster" in the glossary.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48682 from Matan-B/wip-matanb-obc-loader
Matan [Tue, 29 Nov 2022 15:35:15 +0000 (17:35 +0200)]
Merge pull request #48682 from Matan-B/wip-matanb-obc-loader

crimson/osd: Introduce ObjectContextLoader

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
2 years agoMerge pull request #48831 from rzarzynski/wip-crimson-list_snaps-fix-errmsg
Matan [Tue, 29 Nov 2022 15:31:04 +0000 (17:31 +0200)]
Merge pull request #48831 from rzarzynski/wip-crimson-list_snaps-fix-errmsg

crimson/osd: fix error msg in OpsExecuter::do_list_snaps()

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #48527 from rzarzynski/wip-crimson-simpler-cloning
Matan [Tue, 29 Nov 2022 15:29:11 +0000 (17:29 +0200)]
Merge pull request #48527 from rzarzynski/wip-crimson-simpler-cloning

crimson/osd: simplify cloning

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #49119 from zdover23/wip-doc-2022-11-29-rados-ops-change-mon-elect...
zdover23 [Tue, 29 Nov 2022 14:05:20 +0000 (00:05 +1000)]
Merge pull request #49119 from zdover23/wip-doc-2022-11-29-rados-ops-change-mon-elections-prompts

doc/rados: add prompts to change-mon-elections.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49120 from zdover23/wip-doc-2022-11-29-rados-ops-control-prompts
zdover23 [Tue, 29 Nov 2022 13:59:08 +0000 (23:59 +1000)]
Merge pull request #49120 from zdover23/wip-doc-2022-11-29-rados-ops-control-prompts

doc/rados: add prompts to control.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49118 from zdover23/wip-doc-2022-11-29-rados-cache-tiering-prompts
zdover23 [Tue, 29 Nov 2022 13:56:23 +0000 (23:56 +1000)]
Merge pull request #49118 from zdover23/wip-doc-2022-11-29-rados-cache-tiering-prompts

doc/rados: add prompts to cache-tiering.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #49114 from zdover23/wip-doc-2022-11-29-rados-bluestore-migration...
zdover23 [Tue, 29 Nov 2022 13:51:16 +0000 (23:51 +1000)]
Merge pull request #49114 from zdover23/wip-doc-2022-11-29-rados-bluestore-migration-prompts

doc/rados: add prompts to bluestore-migration.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: add prompts to control.rst 49120/head
Zac Dover [Tue, 29 Nov 2022 13:30:02 +0000 (23:30 +1000)]
doc/rados: add prompts to control.rst

Add unselectable prompts to doc/rados/operations/control.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rados: add prompts to change-mon-elections.rst 49119/head
Zac Dover [Tue, 29 Nov 2022 13:10:59 +0000 (23:10 +1000)]
doc/rados: add prompts to change-mon-elections.rst

Add unselectable prompts to
doc/rados/operations/change-mon-elections.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #48525 from rhcs-dashboard/fix-PgImbalance-alert
Nizamudeen A [Tue, 29 Nov 2022 12:59:39 +0000 (18:29 +0530)]
Merge pull request #48525 from rhcs-dashboard/fix-PgImbalance-alert

mgr/dashboard: fix CephPGImbalance alert

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2 years agoMerge pull request #48526 from rhcs-dashboard/fix-cephPoolGrowth-alert
Nizamudeen A [Tue, 29 Nov 2022 12:59:01 +0000 (18:29 +0530)]
Merge pull request #48526 from rhcs-dashboard/fix-cephPoolGrowth-alert

mgr/dashboard: Fix CephPoolGrowthWarning alert

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agodoc/rados: add prompts to cache-tiering.rst 49118/head
Zac Dover [Tue, 29 Nov 2022 12:28:36 +0000 (22:28 +1000)]
doc/rados: add prompts to cache-tiering.rst

Add unselectable prompts to doc/rados/operations/cache-tiering.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agodoc/rados: add prompts to bluestore-migration.rst 49114/head
Zac Dover [Tue, 29 Nov 2022 11:08:10 +0000 (21:08 +1000)]
doc/rados: add prompts to bluestore-migration.rst

Add unselectable prompts to
doc/rados/operations/bluestore-migration.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agocephfs-top: reset filters when no fs 49041/head
Jos Collin [Thu, 24 Nov 2022 11:59:32 +0000 (17:29 +0530)]
cephfs-top: reset filters when no fs

Signed-off-by: Jos Collin <jcollin@redhat.com>
2 years agoMerge pull request #49107 from zdover23/wip-doc-2022-11-29-rados-balancer-prompts
zdover23 [Tue, 29 Nov 2022 07:43:48 +0000 (17:43 +1000)]
Merge pull request #49107 from zdover23/wip-doc-2022-11-29-rados-balancer-prompts

doc/rados: add prompts to balancer.rst

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: add prompts to balancer.rst 49107/head
Zac Dover [Tue, 29 Nov 2022 05:41:11 +0000 (15:41 +1000)]
doc/rados: add prompts to balancer.rst

Add unselectable prompts to doc/rados/operations/balancer.rst.

https://tracker.ceph.com/issues/57108

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2 years agoMerge pull request #49015 from batrick/meta-doc
Venky Shankar [Tue, 29 Nov 2022 04:07:04 +0000 (09:37 +0530)]
Merge pull request #49015 from batrick/meta-doc

doc/cephfs: correct names for fs/meta

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #48490 from aclamk/wip-aclamk-fix-deferred
Yuri Weinstein [Mon, 28 Nov 2022 18:38:12 +0000 (10:38 -0800)]
Merge pull request #48490 from aclamk/wip-aclamk-fix-deferred

[bluestore] Improve deferred write decision

Reviewed-by: Mark Nelson <mnelson@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2 years agomgr/dashboard: allow cross origin when the url is set 49060/head
Nizamudeen A [Fri, 25 Nov 2022 14:53:31 +0000 (20:23 +0530)]
mgr/dashboard: allow cross origin when the url is set

Allow CORS when the cross_origin_url is set in the config opt.

you have to update the cross_origin_url setting with the url of the
requesting entity.

The request needs to have the header `Access-Control-Allow-Origin`
with the origin URL

The url can be set using this command
`ceph config set mgr mgr/dashboard/cross_origin_url
http://localhost:4200`

multiple urls can be set as
`ceph config set mgr mgr/dashboard/cross_origin_url
http://localhost:4200,http://localhost:4201`

If multiple url is provided in the configuration option, then whatever
url is there in the Access-Control-Allow-Origin request header will be
allowed for CORS

Once the URL is set you have to restart the dashboard module to restart
the cherrypy server with the new CORS policies

Fixes: https://tracker.ceph.com/issues/58086
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #49053 from tchaikov/wip-crimson-fmt-v9
Samuel Just [Mon, 28 Nov 2022 16:43:12 +0000 (08:43 -0800)]
Merge pull request #49053 from tchaikov/wip-crimson-fmt-v9

crimson: various fmt related changes and fixes

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #47221 from markhpc/wip-faster-rocksdb
Mark Nelson [Mon, 28 Nov 2022 16:32:16 +0000 (10:32 -0600)]
Merge pull request #47221 from markhpc/wip-faster-rocksdb

[WIP] kv/RocksDBStore: Improved RocksDB Settings and Tombstone behavior

2 years agoMerge pull request #48875 from yuvalif/wip-yuval-fix-58014
Yuval Lifshitz [Mon, 28 Nov 2022 16:01:32 +0000 (18:01 +0200)]
Merge pull request #48875 from yuvalif/wip-yuval-fix-58014

rgw/notifications: sending metadata in COPY and CompleteMultipartUpload

2 years agoMerge pull request #49082 from zdover23/wip-doc-2022-11-28-rbd-isci-monitoring-prompts
Ilya Dryomov [Mon, 28 Nov 2022 09:29:00 +0000 (10:29 +0100)]
Merge pull request #49082 from zdover23/wip-doc-2022-11-28-rbd-isci-monitoring-prompts

doc/rbd: add prompts to iscsi-monitoring.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #48598 from yuvalif/wip-yuval-fix-57899
Yuval Lifshitz [Mon, 28 Nov 2022 06:01:06 +0000 (08:01 +0200)]
Merge pull request #48598 from yuvalif/wip-yuval-fix-57899

rgw/admin/notifications: support admin operations on topics with tenants

2 years agoMerge pull request #49079 from zdover23/wip-doc-2022-11-28-glossary-ceph-system-remove
zdover23 [Mon, 28 Nov 2022 00:16:58 +0000 (10:16 +1000)]
Merge pull request #49079 from zdover23/wip-doc-2022-11-28-glossary-ceph-system-remove

doc/glossary: s/Ceph System/Ceph Cluster/

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rbd: add prompts to iscsi-monitoring.rst 49082/head
Zac Dover [Mon, 28 Nov 2022 00:11:04 +0000 (10:11 +1000)]
doc/rbd: add prompts to iscsi-monitoring.rst

Add unselectable prompts to doc/rbd/iscsi-monitoring.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>