Merge pull request #37282 from neha-ojha/wip-46323

qa/*/thrash_cache_writeback_proxy_none.yaml: remove cache-mode proxy

Reviewed-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #37077 from wjwithagen/wjw-fix-cls_fifo.cc-__lea64

cls: replace __le{32,64} types by their Ceph counterparts

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #37149 from ifed01/wip-ifed-fix-alloc-cmd-multi-reg

os/bluestore: provide a different name for fallback allocator

Reviewed-by: Adam Kupczyk <akucpzyk@redhat.com>

Merge pull request #37150 from pdvian/wip-crush-failure-domain

mon: validate crush-failure-domain

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #37263 from ifed01/wip-ifed-more-structs-to-mempool

os/bluestore: add missing structs to bluestore_cache_other mempool

Reviewed-by: Adam Kupczyk <akucpzyk@redhat.com>

Merge pull request #37153 from tchaikov/wip-46124

blk/kernel: use open file description lock if available

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Niklas Hambüchen <mail@nh2.me>

Merge pull request #37329 from changchengx/add_conn

mon: set MonClient::_add_conn return type to void

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #37321 from changchengx/mon_make

cmake: remove undefined source file lists

Reviewed-by: Kefu Chai <kchai@redhat.com>

cmake: remove undefined source file lists

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>

Merge pull request #37388 from johscheuer/add-missing-python-dependency

debian: Add missing Python dependency for ceph-mgr

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #37380 from changchengx/ceph_port

msgr: remove the macro not referenced anywhere

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #36779 from athanatos/sjust/wip-dirty-writeout

crimson/seastore: add dirty extent writeout

Reviewed-by: Kefu Chai <kchai@redhat.com>

test/crimson/seastore/test_transaction_manager: add random overwrite test

Also improves replay() by recycling all structures except for the
segment_manager.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore: add segment_cleaner

Adds SegmentCleaner component to manage rewriting
dirty segments.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/lba_manager: add rewrite_extent

Adds support for writing out an extent to a new location and updating
lba mappings.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/journal: add more debugging for replay

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/journal: initialize current_journal_segment in find_replay_segments

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/journal: return next write location from open_for_write

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/cache: replay_delta handle obsolete extents properly

If we see a delta at verison v (v != 0) and we haven't seen version v-1,
we know that the extent is obsolete and can be ignored (presuming that
journal trimming is behaving).

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/journal: pass journal_seq with each replay delta

We'll need this to track where extents became dirty during replay.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore: maintain dirty_from value on dirty CachedExtents

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #37400 from cbodley/wip-rgw-DatalogTrimImplCR-logging

rgw: raise debug level of DatalogTrimImplCR message

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #36482 from cbodley/wip-rgw-bucket-sync-checkpoint

rgw: add 'bucket sync checkpoint' command to radosgw-admin

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #37311 from mgariepy/fix-47502

[ceph-volume]: remove unneeded call to get_devices()

Merge PR #36685 into master

* refs/pull/36685/head:
mds: allow quota for root directory

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #37009 into master

* refs/pull/37009/head:
client: remove the unecessary client_lock for objector->read/write()
client: fix the comment for RWRef

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #37266 into master

* refs/pull/37266/head:
qa: ignore logrotate state rename error

Reviewed-by: Rishabh Dave <ridave@redhat.com>

ceph-volume: remove unneeded call to get_devices()

there is no need to probe the device to generate the argparse help
message.

also removing the test on the function as it's not there anymore.

Signed-off-by: Marc Gariepy <gariepy.marc@gmail.com>
Fixes: https://tracker.ceph.com/issues/47502

Merge pull request #37374 from wjwithagen/wjw-fix-crypto-alloca

librbd: Use stdlib.h instead of alloca.h

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>

rgw: raise debug level of DatalogTrimImplCR message

the message was printed at level 0 even on success

Signed-off-by: Casey Bodley <cbodley@redhat.com>

librbd: Use stdlib.h instead of alloca.h

src/librbd/crypto/BlockCrypto.cc:5:10: fatal error: 'alloca.h' file not found
         ^~~~~~~~~~
1 error generated.

Including <stdlib.h> is enough

fixes: https://tracker.ceph.com/issues/47614
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #37385 from idryomov/wip-krbd-read-only-override

rbd: make common options override krbd-specific options

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #37384 from tchaikov/wip-crimson-doc

doc/dev/crimson: add instructions on how to build crimson

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

debian: Add missing Python dependency for ceph-mgr

The file mgr/volumes/fs/operations/pin_util.py imports distutils.util for using
strtobool and thus the python package is required.

Signed-off-by: Johannes M. Scheuermann <joh.scheuer@gmail.com>

rbd: make common options override krbd-specific options

ceph-csi has added support for passing custom map and unmap options via
mapOptions and unmapOptions storage class parameters.  However, it also
uses --read-only for implementing ROX (ReadOnlyMany) PVs.  If the user
supplies "mapOptions: rw", they will get around the intended read-only
restriction (at least on the block device).

ceph-csi could be patched to use "-o ro", but it actually makes sense
for common options to win over device type-specific equivalents.

Fixes: https://tracker.ceph.com/issues/47625
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #37236 from jschmid1/osd_rm_doc_fix

docs: remove docs should say osd_id instead of svc_id

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

doc/dev/crimson: add instructions on how to build crimson

and add a link to Scylla's document on debugging with GDB

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #37275 from bk201/wip-47494

mgr/dashboard: display devices' health information within a tabset

Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #37305 from zdover23/wip-doc-3-dev-guide-basic-workflow-date-update-sep-2020

doc/dev: updated date from 2016

Reviewed-by: Neha Ojha <nojha@redhat.com>

msgr: remove the macro not referenced anywhere

The default port range should be between:
  [ms_bind_port_min, ms_bind_port_max]

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>

doc/dev: added the other four tests

This PR adds a list of tests that are performed
when a PR hits Github.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

crimson/os/seastore/journal: return addr and seq from submit_record

Reworks journal_seq_t to be a monotonically increasing, but non-dense
value from the current segment_seq_t and segment offset.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/journal: add interface for trimming the journal

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore: rework pending extents

Previously, we simply added the old extent to the retired set and
treated the new instance seperately.  Instead, let the new pending
instance reference the old instance via a prior_instance reference.
This has a few advantages:
- During commit, we swap cache hooks from the prior instance to
  avoid traversal
- Extents in the retired set are only those extents that are no
  longer mapped/valid.
- btree range pins can be swapped without a traversal
- position in the dirty list can be maintained

That last will be particularly important as the dirty list will
therefore be ordered from the extent with the oldest initial
delta forward.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore: factor out LogicalCachedExtent::on_delta_write

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/journal: rename journal_replay_lb to journal_tail

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/lba_manager/btree: factor out common LBANode helpers

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore: remove CachedExtent move constructor

I'm not sure why I added this in the first place, there aren't really
any scenarios where invoking it wouldn't be a bug.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/.../btree_lba_node_impl: mutate_mapping adjust addr for extent state

Addresses must always be adjusted depending on whether the extent will
be written as a block or as a delta.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore: improve misc debugging

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/seastore_types: permit paddr_t::operator- to operate on block relative addrs

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/segment_manager: use smaller segments for tests

This way, we'll roll segments more frequently.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/lba_manager/btree/btree_lba_manager: manage pin in init

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/lba_manager: drop from cache directly during replay if dead

Dead extents can't go through the normal retire_extent path as they don't
have valid pins or other elements of a real extent.  Instead, simply drop
them on the floor directly.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/.../lba_btree_node_impl: fix find_hole

find_hole shouldn't check entries prior to min.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore: initialize crc *after* read

Previously, all extents ended up initialized to the same crc value
upon read -- the one for an empty buffer.  This bug wasn't detected
because an extent was always evicted and reread following the first
write and subsequently kept in cache once initially written.

Also, add crc to operator<< for extents.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/transaction_manager: only add pin if not already pending

If it's already pending, cache.duplicate_for_write is a noop and the extent
will already have a pin.  Also, add some debugging.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/cache: let root exist in the dirty list

Most handling remains special, but this way the dirty list we
work on will include root directly.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore: clarify crc initial state

Otherwise, different users may use different values complicating
debugging.  We can re-add this in the future if it becomes
useful.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/transaction: let get_extent signal retired extents

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/common/fixed_kv_node_layout: fix lower_bound

This went undetected because all existing users ensure that
the key does not already exist.

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #37186 from guits/guits-cephadm-filter-dangling-images

cephadm: filter dangling images in get_last_local_ceph_image()

Merge pull request #37133 from jschmid1/ptrace_priv

cephadm: capadd and privileged are mutex with podman >= 2.0

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge PR #37310 into master

* refs/pull/37310/head:
client: refresh rstat for quota check of rename

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #37041 from bk201/wip-47356

mgr/dashboard: fix security scopes of some NFS-Ganesha endpoints

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #37244 from ceph/47543-bucket-list-perf

mgr/dashboard: fix perf. issue when listing large amounts of buckets

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #37242 from dang/wip-dang-47520

Fix missing req_state for librgw

Merge pull request #37330 from idryomov/wip-backport-create-issue-key

doc: SubmittingPatches-backports.rst: backport scripts read key from file

Reviewed-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #37136 from p-se/cd-add-per-rbd-graphs

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

SubmittingPatches-backports.rst: backport scripts read key from file

The --key option was removed in commit 1b5f37bbcd4a
("backport-create-issue: read redmine key from file").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #37192 from rhcs-dashboard/fix-46898-master

mgr/dashboard/api: move/create OSD histogram in separate endpoint

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #37303 from tchaikov/wip-crimson-osd

crimson: do not set_value() twice and fix Message leak

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/mon: move handle_auth_done() to "v1 and v2" section

crimson::mon::Connection::handle_auth_done() is shared by both v1 and v2
authentication implementation, so move it to "v1 and v2" section

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #37326 from tchaikov/wip-47324

test/crimson: better error message when bind fails

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #37323 from tchaikov/wip-47593

crimson/osd: add_recovery(oid) before recover_object(oid)

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

test/crimson: better error message when bind fails

See also: https://tracker.ceph.com/issues/47324

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: more constness

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: add_recovery(oid) before recover_object(oid)

in 7736bddc534e5df2daf704c4bbc92a0927b0db4d, we assumed that the object
to be recovered did not exist in `recovering` before
`recover_object(oid)` was called. but this turns out not true. so, in
this change, `add_object(oid)` is called before `recover_object(oid)`
gets called.

Fixes: https://tracker.ceph.com/issues/47593
Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: use recoverying.at() when appropriate

this helps to avoid the confusion of "where the recovery is added" and
"are we adding a new instance of recovery here".

should call add_recovery() explicitly when we need to add a new recovery
instance.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: add RecoveryBackend:add_recovering()

before this change, get_recovery() can also be used for adding a
recovery instance to `recovering`. this behavior is error-prone and
confusing.

after this change, add_recovery() is used in the place where we
want to add a new instance of recovery instance.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #37290 from tchaikov/wip-run-make-check

run-make-check.sh: fix syntax error

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #37106 from sebastian-philipp/cephadm-overwritable-templates

mgr/cephadm: make j2 teamplates overwritable

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>

Merge pull request #37121 from Songweibin/wip-rbd-metadata

librbd: async version of metadata_set/remove

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #37083 from orozery/librbd-data-cryptor

librbd: add data encryptor/decryptor using openssl

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #37110 from CongMinYin/qa_immutable_object_cache_check

qa: check immutable object cache content

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #37237 from MahatiC/wip-fix-rwl-path

librbd/cache: Fix pwl_path read issue

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #37206 from bk201/wip-47387

mgr/rook: fix listing daemons

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Varsha Rao <varao@redhat.com>

client: refresh rstat for quota check of rename

Fixes: https://tracker.ceph.com/issues/47224
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>

Merge pull request #37043 from s0nea/wip-dashboard-47331

mgr/dashboard: log in non-admin users successfully if the telemetry notification is shown

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

mon: validate crush-failure-domain

While creating erasure-coded profile make sure
that user is specifying valid crush-failure-domain.

Fixes: https://tracker.ceph.com/issues/47452
Signed-off-by: Prashant Dhange <pdhange@redhat.com>

Merge pull request #37293 from changchengx/osd_comment

osd: fix wrong comment about setting auth_client for messenger

Reviewed-by: Kefu Chai <kchai@redhat.com>

crimson/osd: do not add ref when constructing MessageRef

crimson::osd::PG::send_cluster_message() accepts a `Message*`
pointer, and then hand it over to `shard_services.send_to_osd()`,
which expects a `Ref<Message>`. so the raw pointer is used to
construct an `intrusive_ptr<Message>`, which increment the
refcount of that Message instance by one. but that Message
was owned by nobody before that, so we end up with an
`intrusive_ptr<Message>` of 2 refcount, and only a single
owner. hence the memory leak.

in this change, instructs the constructor to not add the refcount.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/mon: do not set_value() again

once the continuation consuming the stored value of the associated
future, we cannot set_value() again. otherwise, ASan complains that we
are accessing the memory on heap after it is freed.

in this change, std::optional<> is used for holding
promise<auth_result_t>, once the promise is fulfilled, `auth_done` is
reset to prevent another call of `set_value()` or `set_exception()`.

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc/dev: updated date from 2016

This updates a date from 2016 to 2020,
so that readers can be confident that the
procedure that they're reading has been recently
tested.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

crimson/mon: only finish auth when auth is completed

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/mon: s/AuthResult/auth_result_t/

auth_result_t is merely an enum, so make it like so.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/mon: extract mon::Client::_finish_auth()

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>

osd: correct comment about setting auth_client for messenger

client_messenger's auth_client has not been set until call
monc->init();

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>

Merge pull request #37152 from rhcs-dashboard/bottom-links-component

mgr/dashboard: Creating a new Login Page Legal Links Component

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

mon: set MonClient::_add_conn return type to void

The new created MonConnection are refered through
MonClient::pending_cons instead of through the return
value.

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>