]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Zac Dover [Thu, 5 Jun 2025 00:02:47 +0000 (10:02 +1000)]
doc/mgr: edit telemetry (1 of x)
Improve the English and the formatting in doc/mgr/telemetry.rst. This
follows up on https://github.com/ceph/ceph/pull/63476.
This commit edits down to the line "Note that telemetry must be on for
these commands to take effect.", inclusive.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Wed, 4 Jun 2025 23:52:40 +0000 (09:52 +1000)]
doc/mgr: edit cli_api
Improve the English in doc/mgr/cli_api.rst. Incorporate the changes
suggested by Anthony D'Atri in https://github.com/ceph/ceph/pull/63195.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Casey Bodley [Wed, 4 Jun 2025 22:20:55 +0000 (18:20 -0400)]
Merge pull request #63596 from cbodley/wip-github-milestone-tentacle
github: add tentacle milestone
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Casey Bodley [Wed, 4 Jun 2025 20:22:07 +0000 (16:22 -0400)]
Merge pull request #63361 from cbodley/wip-github-label-rgw-docs
github: add rgw label for changes in doc/radosgw
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Casey Bodley [Wed, 4 Jun 2025 20:21:01 +0000 (16:21 -0400)]
Merge pull request #63702 from ThomasLamprecht/deb-radosgw-media-types-dependency
debian: radosgw: add media-types packages as alternative for mime-support
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Casey Bodley [Wed, 4 Jun 2025 18:57:08 +0000 (14:57 -0400)]
Merge pull request #63409 from cbodley/wip-70792
run-make: work around package conflicts from llvm.sh
Reviewed-by: Dan Mick <dmick@redhat.com>
Yuval Lifshitz [Wed, 4 Jun 2025 13:34:19 +0000 (16:34 +0300)]
Merge pull request #63264 from yuvalif/wip-yuval-71308
rgw/logging: Make unique portion of log object name ordered
Casey Bodley [Wed, 21 May 2025 17:24:26 +0000 (13:24 -0400)]
run-make: work around package conflicts from llvm.sh
packages installed by llvm.sh sometimes conflict with existing packages
from earlier versions, leading to errors like:
> The following packages have unmet dependencies:
> python3-lldb-13 : Conflicts: python3-lldb-x.y
> python3-lldb-19 : Conflicts: python3-lldb-x.y
remove packages from any earlier versions before running llvm.sh
Fixes: https://tracker.ceph.com/issues/70792
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Yuval Lifshitz [Wed, 4 Jun 2025 13:11:51 +0000 (16:11 +0300)]
Merge pull request #63244 from yuvalif/wip-yuval-71288
rgw/logging: add size in MPU complete in standard mode
Patrick Donnelly [Wed, 4 Jun 2025 12:42:39 +0000 (08:42 -0400)]
Merge PR #62865 into main
* refs/pull/62865/head:
test/libcephfs: copy DT_NEEDED entries from input libraries
test/fs: only add libcephfs as library dependency
test/client: do not depend on libcephfs
Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
Naveen Naidu [Wed, 4 Jun 2025 08:54:19 +0000 (14:24 +0530)]
Merge pull request #63136 from Naveenaidu/wip-naveen-config-diff-scripts
script: add configuration diff tool
Guillaume Abrioux [Wed, 4 Jun 2025 07:07:51 +0000 (09:07 +0200)]
Merge pull request #62648 from guits/refactor_setup_device
ceph-volume: refactor LvmBlueStore.setup_device()
Yingxin Cheng [Wed, 4 Jun 2025 06:10:03 +0000 (14:10 +0800)]
Merge pull request #63389 from cyx1231st/wip-seastore-refine-extent-states
crimson/os/seastore: cleanup CachedExtent::extent_state_t and related logic
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Zac Dover [Wed, 4 Jun 2025 03:33:23 +0000 (13:33 +1000)]
Merge pull request #63686 from zdover23/wip-doc-2025-06-04-start-documenting-ceph
doc/start: edit documenting-ceph.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Naveen Naidu [Thu, 17 Apr 2025 13:50:57 +0000 (19:20 +0530)]
.github/workflow: add diff ceph config action
Signed-off-by: Naveen Naidu <naveen.naidu@ibm.com>
Naveen Naidu [Thu, 17 Apr 2025 13:50:40 +0000 (19:20 +0530)]
script: add config-diff tool
Signed-off-by: Naveen Naidu <naveen.naidu@ibm.com>
Yingxin Cheng [Tue, 3 Jun 2025 06:23:50 +0000 (14:23 +0800)]
crimson/os/seastore/../btree_omap_manager: workaround log failure
See https://tracker.ceph.com/issues/71524
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 22 May 2025 03:52:37 +0000 (11:52 +0800)]
test/crimson/../test_transaction_manager: fix try_get_extent() to handle transaction conflicts
Outside interruptible future, transaction can become invalidated
implicitly.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 22 May 2025 02:43:19 +0000 (10:43 +0800)]
crimson/os/seastore/cache: minor cleanups to prepare_record/complete_commit()
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 21 May 2025 06:21:10 +0000 (14:21 +0800)]
crimson/os/seastore: more accurate usages to is_pending() vs is_stable()
Generally, prefer is_pending() than !is_stable(), and
is_stable() than !is_pending().
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 21 May 2025 03:54:05 +0000 (11:54 +0800)]
crimson/os/seastore: more accurate usages to is_mutable() vs is_data_stable()
Generally, prefer is_mutable() than !is_data_stable(), and
is_data_stable() than !is_mutable().
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 21 May 2025 03:33:26 +0000 (11:33 +0800)]
crimson/os/seastore: distinguish between is_mutation_pending() and has_mutation()
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 21 May 2025 03:20:03 +0000 (11:20 +0800)]
crimson/os/seastore/../fixed_kv_btree: get_stable_for_key() is called when the node is pending
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 19 May 2025 07:01:18 +0000 (15:01 +0800)]
crimson/os/seastore: cleanup CachedExtent::prior_instance
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Fri, 25 Apr 2025 08:32:07 +0000 (16:32 +0800)]
crimson/os/seastore/cached_extent: drop the unused retired_at
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Fri, 25 Apr 2025 07:56:46 +0000 (15:56 +0800)]
crimson/os/seastore/cached_extent: merge is_clean() and is_dirty() as has_delta()
The original names were misleading because they don't correspond to
CLEAN and DIRTY states.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Fri, 25 Apr 2025 06:47:16 +0000 (14:47 +0800)]
crimson/os/seastore/cached_extent: drop CLEAN_PENDING state
It is only used to prevent printing details when the buffer is still
loading, and is a special case of CLEAN.
It doesn't worth a dedicated state that complicates state-related
decisions.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Wed, 4 Jun 2025 01:57:44 +0000 (09:57 +0800)]
Merge pull request #59565 from Nuckal777/mon-increase-dns-buf-size
mon: increase dns buffer size
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Yingxin Cheng [Wed, 4 Jun 2025 01:56:23 +0000 (09:56 +0800)]
Merge pull request #63218 from xxhdx1985126/wip-seastore-fix-retire-absent
crimson/os/seastore/transaction_manager: Cache::retire_absent_extent_addr should be called immediately after TransactionManager::get_extent_if_linked if necessary
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Wed, 4 Jun 2025 01:43:42 +0000 (09:43 +0800)]
Merge pull request #63520 from xxhdx1985126/wip-71448
crimson/os/seastore/omap_manager: only mutate the parent when merge/balance can proceed
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Jesse Williamson [Wed, 4 Jun 2025 00:39:35 +0000 (17:39 -0700)]
Merge pull request #63676 from irq0/wip/fix-breakpad-fedora41
Fix Breakpad Builds on Newer Distros
Zac Dover [Tue, 3 Jun 2025 20:51:36 +0000 (06:51 +1000)]
Merge pull request #63622 from zdover23/wip-doc-2025-06-02-mgr-dashboard_plugins-63367-followup
doc/mgr/dashboard_plugins: edit feature_toggles.inc.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Thomas Lamprecht [Tue, 3 Jun 2025 20:32:05 +0000 (22:32 +0200)]
debian: radosgw: add media-types packages as alternative for mime-support
Back in 2020 the '/etc/mime.types' file was split out into it's own
leaner 'media-types' Debian package [0], the previous 'mime-support'
was kept as transitional package to handle upgrades, but it did its
job and isn't included in Debian Trixie repos anymore.
So accept both, the new 'media-types' package or the legacy
'mime-support' one as valid dependency for radosgw, this ensures one
can install radosgw on newer Debian based releases while keeping it
also working for older ones.
[0]: https://salsa.debian.org/debian/media-types/-/commit/
4d6ff19de5720196b40cf65f1173bd9333dfecf9
Fixes: https://tracker.ceph.com/issues/71545
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Zac Dover [Tue, 3 Jun 2025 20:30:28 +0000 (06:30 +1000)]
Merge pull request #62893 from zdover23/wip-doc-2025-04-21-radosgw-metrics
doc/radosgw: edit sentence in metrics.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 3 Jun 2025 20:03:47 +0000 (06:03 +1000)]
Merge pull request #63614 from zdover23/wip-doc-2025-05-30-rados-ops-cache-tiering-63465-followup
doc/rados/operations: edit cache-tiering.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 3 Jun 2025 19:56:15 +0000 (05:56 +1000)]
Merge pull request #63476 from zdover23/wip-doc-2025-05-26-mgr-telemetry-62782-followup
doc/mgr: edit telemetry.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 3 Jun 2025 19:42:02 +0000 (05:42 +1000)]
Merge pull request #63195 from zdover23/wip-doc-2025-05-09-mgr-cli-api-62782-followup
doc/mgr: edit cli_api.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 3 Jun 2025 19:23:53 +0000 (05:23 +1000)]
doc/start: edit documenting-ceph.rst
Edit the section "Build the Source (First Time)" in
doc/start/documenting-ceph.rst.
- remove references to RHEL7 (it's old)
- improve sentences (they were first-draft-like)
- improve RST formatting
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Tue, 3 Jun 2025 18:52:13 +0000 (04:52 +1000)]
Merge pull request #63628 from zdover23/wip-doc-2025-06-02-rados-ops-balancer-63530-followup
doc/rados: edit balancer.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 3 Jun 2025 18:49:08 +0000 (04:49 +1000)]
Merge pull request #63623 from zdover23/wip-doc-2025-06-02-mgr-iostat-63418-followup
doc/mgr: edit iostat.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Sun, 1 Jun 2025 23:04:25 +0000 (09:04 +1000)]
doc/mgr/dashboard_plugins: edit feature_toggles.inc.rst
Follow up on the suggestions made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63367.
- Add "nvmeof" to the list of enabled features.
- Remove an extraneous space.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Mon, 21 Apr 2025 07:52:02 +0000 (17:52 +1000)]
doc/radosgw: edit sentence in metrics.rst
Change the wording of a sentence in doc/radosgw/metrics.rst so that its
articles read as though they were written by a native speaker of the
English language.
This commit is being raised as part of a diagnostic process aimed at
discovering why the ReadtheDocs check is failing on PR
https://github.com/ceph/ceph/pull/62877.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Marcel Lauhoff [Tue, 3 Jun 2025 15:12:27 +0000 (17:12 +0200)]
cmake: Adjust breakpad builds for newer distros
Compile Breakpad with project compiler settings, add -fPIC and silence incompatible
warnings from GCC14.
Signed-off-by: Marcel Lauhoff <marcel.lauhoff@clyso.com>
Adam King [Tue, 3 Jun 2025 14:51:20 +0000 (10:51 -0400)]
Merge pull request #63556 from guits/fix-node-proxy-hw-status
node-proxy: address `ceph orch hardware status` cmd
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Teoman ONAY <tonay@ibm.com>
Casey Bodley [Thu, 29 May 2025 15:18:26 +0000 (11:18 -0400)]
github: add tentacle milestone
pull requests based on the tentacle branch aren't setting the milestone
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Adam Kupczyk [Tue, 3 Jun 2025 12:55:35 +0000 (14:55 +0200)]
Merge pull request #62121 from aclamk/wip-aclamk-bluefs-truncate-alloc-size
os/bluestore: In BlueFS::truncate accept wierd alloc_unit
Adam Kupczyk [Tue, 3 Jun 2025 09:29:18 +0000 (11:29 +0200)]
Merge pull request #62913 from Jayaprakash-ibm/wip-jaya-esb-fio-test
qa: Add Teuthology test for BlueStore ESB assertion failure
Adam Kupczyk [Tue, 3 Jun 2025 09:28:21 +0000 (11:28 +0200)]
Merge pull request #63188 from aclamk/aclamk-fix-70911-envelope-dirty-recover
os/bluestore: Fix bluefs_fnode_t::seek
Adam Kupczyk [Tue, 3 Jun 2025 09:25:20 +0000 (11:25 +0200)]
Merge pull request #63358 from ifed01/wip-ifed-fix-vselector-math
os/bluestore:fix bluestore_volume_selection_reserved_factor usage
Adam Kupczyk [Tue, 3 Jun 2025 09:24:50 +0000 (11:24 +0200)]
Merge pull request #63373 from aclamk/aclamk-bs-fix-split-and-compress
os/bluestore/compression: Fix Estimator::split_and_compress
Zac Dover [Tue, 3 Jun 2025 06:11:45 +0000 (16:11 +1000)]
Merge pull request #63629 from zdover23/wip-doc-2025-06-02-mgr-localpool-63419-followup
doc/mgr: edit localpool.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 3 Jun 2025 06:09:11 +0000 (16:09 +1000)]
Merge pull request #63630 from zdover23/wip-doc-2025-06-02-mgr-modules-63451-followup
doc/mgr: edit modules.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 3 Jun 2025 06:06:33 +0000 (16:06 +1000)]
Merge pull request #63631 from zdover23/wip-doc-2025-06-02-mgr-nfs-63452-followup
doc/mgr: edit nfs.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 3 Jun 2025 06:03:43 +0000 (16:03 +1000)]
Merge pull request #63632 from zdover23/wip-doc-2025-06-02-dev-cephfs-mirroring-63237-followup-4-of-x
doc/dev/cephfs-mirroring: edit file 4 of x
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Jesse Williamson [Mon, 2 Jun 2025 21:29:48 +0000 (14:29 -0700)]
Merge pull request #63643 from chardan/jfw-breakpad-add-pre-build
Add PRE_BUILD to breakpad command (fix for CMake > 3.30)
Zac Dover [Mon, 2 Jun 2025 18:50:55 +0000 (04:50 +1000)]
Merge pull request #63634 from zdover23/wip-doc-2025-06-02-start-documenting-ceph
doc/start: edit documenting-ceph.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Mon, 2 Jun 2025 18:43:05 +0000 (04:43 +1000)]
Merge pull request #63644 from anthonyeleven/advice
doc/rados/operations: Additional improvements to placement-groups.rst
Reviewed-by: Zac Dover <zac.dover@proton.me>
Anthony D'Atri [Mon, 2 Jun 2025 18:35:23 +0000 (14:35 -0400)]
doc/rados/operations: Additional improvements to placement-groups.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Anthony D'Atri [Mon, 2 Jun 2025 18:32:34 +0000 (14:32 -0400)]
Merge pull request #63618 from anthonyeleven/advice
doc/rados/operations: Improve placement-groups.rst
Jaya Prakash [Wed, 16 Apr 2025 10:50:30 +0000 (16:20 +0530)]
qa: Add Teuthology test for BlueStore ESB assertion failure
Adds a test to reproduce the !ito->is_valid() assertion in BlueStore
with bluestore_elastic_shared_blobs=true on a 2+1 EC pool using a
FIO randwrite workload (512 concurrent ops, 50G, 12,500 objects).
The test deploys a 6-OSD cluster and runs FIO for 1 hour via workunit,
failing if an OSD crashes.
Signed-off-by: Jaya Prakash <jayaprakash@ibm.com>
Jesse F. Williamson [Mon, 2 Jun 2025 17:30:45 +0000 (10:30 -0700)]
Add PRE_BUILD (fix for CMake > 3.30)
Signed-off-by: Jesse F. Williamson <jfw@ibm.com>
Jesse Williamson [Mon, 2 Jun 2025 16:17:43 +0000 (09:17 -0700)]
Merge pull request #61264 from irq0/wip/breakpad
Breakpad Crash Handler
Anthony D'Atri [Mon, 2 Jun 2025 03:17:05 +0000 (23:17 -0400)]
Merge pull request #63633 from zdover23/wip-doc-2025-06-02-mgr-progress-63470-followup
doc/mgr: edit progress.rst
Anthony D'Atri [Fri, 30 May 2025 17:43:49 +0000 (13:43 -0400)]
doc/rados/operations: Improve placement-groups.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Zac Dover [Mon, 2 Jun 2025 02:27:12 +0000 (12:27 +1000)]
doc/mgr: edit progress.rst
Edit doc/mgr/progress.rst. Make the changes suggested by Anthony D'Atri
in https://github.com/ceph/ceph/pull/63470.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Mon, 2 Jun 2025 02:32:36 +0000 (12:32 +1000)]
doc/start: edit documenting-ceph.rst
Edit the section "Build the Source" in doc/start/documenting-ceph.rst.
Also correct a misuse of the word "presently", which means "in a little
while", not "now".
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Mon, 2 Jun 2025 02:16:47 +0000 (12:16 +1000)]
doc/dev/cephfs-mirroring: edit file 4 of x
Add prompts (and perform necessary corrections to glaring grammatical
errors) to doc/dev/cephfs-mirroring.rst, as requested by Jos Collin in
https://github.com/ceph/ceph/pull/63237/files#r2085886075.
This commit edits the fourth (and final) quarter of the
doc/dev/cephfs-mirroring.rst file.
Further refinements to the English in this file are possible.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Sun, 1 Jun 2025 23:45:42 +0000 (09:45 +1000)]
doc/mgr: edit nfs.rst
Edit the "Updating an NFS Cluster" section of doc/mgr/nfs.rst. This
commit includes changes requested by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63452.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Sun, 1 Jun 2025 23:39:35 +0000 (09:39 +1000)]
doc/mgr: edit modules.rst
s/called/named/ as requested by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63451#discussion_r2104487962.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Sun, 1 Jun 2025 23:33:20 +0000 (09:33 +1000)]
doc/mgr: edit localpool.rst
Remove "only" where it was extraneous.
This commit was made in response to a request made by Anthony D'Atri
here: https://github.com/ceph/ceph/pull/63419#discussion_r2102803276.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Sun, 1 Jun 2025 23:25:42 +0000 (09:25 +1000)]
doc/rados: edit balancer.rst
Edit doc/rados/operations/balancer.rst. Follow up on matters raised in
https://github.com/ceph/ceph/pull/63530. Make the English clearer.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Sun, 1 Jun 2025 23:14:45 +0000 (09:14 +1000)]
doc/mgr: edit iostat.rst
Rewrite the first sentence in doc/mgr/iostat.rst. This follows up on a
request made by Anthony D'Atri in
https://github.com/ceph/ceph/pull/63418#discussion_r2102806688.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Laura Flores [Fri, 30 May 2025 19:22:17 +0000 (14:22 -0500)]
Merge pull request #63429 from aclamk/aclamk-qa-no-bench-for-write-v2-compression
qa/rados: Fix problem with recompression failing osd bench testing
Patrick Donnelly [Fri, 30 May 2025 16:48:39 +0000 (12:48 -0400)]
Merge PR #63606 into main
* refs/pull/63606/head:
win32_deps_bild: bump openssl version
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Jesse Williamson [Fri, 30 May 2025 15:48:48 +0000 (08:48 -0700)]
Merge pull request #63529 from chardan/build-cmake-improve-catch2-support
make adding Catch2 tests straightforward
Igor Fedotov [Fri, 30 May 2025 14:30:03 +0000 (17:30 +0300)]
Merge pull request #63600 from tchaikov/wip-bluestore-types-fix-leaks
test/objectstore: fix memory leak test_bluestore_types.cc
Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
Anthony D'Atri [Fri, 30 May 2025 13:48:00 +0000 (09:48 -0400)]
Merge pull request #63613 from zdover23/wip-doc-2025-05-30-cephadm-host-management-62600-followup
doc/cephadm: edit host-management.rst
Jos Collin [Fri, 30 May 2025 13:04:57 +0000 (18:34 +0530)]
Merge pull request #63570 from joscollin/wip-update-backport-script
ceph-backport.sh: update known milestones
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Igor Fedotov [Fri, 30 May 2025 12:56:08 +0000 (15:56 +0300)]
Merge pull request #63603 from tchaikov/wip-bluestore-nullptr
os/bluestore/BlueFS: use nullptr when appropriate
Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
Zac Dover [Fri, 30 May 2025 12:38:03 +0000 (22:38 +1000)]
doc/rados/operations: edit cache-tiering.rst
Strengthen the warning against deploying cache tiering in releases after
Reef. This follows up on Anthony D'Atri's request in
https://github.com/ceph/ceph/pull/63465.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Fri, 30 May 2025 12:27:03 +0000 (22:27 +1000)]
doc/cephadm: edit host-management.rst
Make the improvements to doc/cephadm/host-management.rst that Anthony
D'Atri suggested in https://github.com/ceph/ceph/pull/62600.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Lucian Petrut [Fri, 30 May 2025 09:24:51 +0000 (09:24 +0000)]
win32_deps_bild: bump openssl version
The Windows build is using a very old OpenSSL version (1.1.1c),
we'll bump the version to 3.0.16.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Jos Collin [Thu, 29 May 2025 07:20:46 +0000 (12:50 +0530)]
ceph-backport.sh: update known milestones
Signed-off-by: Jos Collin <jcollin@redhat.com>
Kefu Chai [Fri, 30 May 2025 07:29:42 +0000 (15:29 +0800)]
os/bluestore/BlueFS: use nullptr when appropriate
instead of using `0` to represent a nullptr, use nullptr for better
readability.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Ronen Friedman [Fri, 30 May 2025 07:59:04 +0000 (10:59 +0300)]
Merge pull request #63559 from ronen-fr/wip-rf-extsleep
osd/scrub: only periodic_regular scrubs should suffer extended sleeps
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Xuehan Xu [Mon, 19 May 2025 03:43:13 +0000 (11:43 +0800)]
crimson/os/seastore/transaction: more logs about inconsistent
retired_placeholder
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Sun, 11 May 2025 03:19:24 +0000 (11:19 +0800)]
crimson/os/seastore/transaction_manager:
Cache::retire_absent_extent_addr should be called immediately after
TransactionManager::get_extent_if_linked if necessary
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Sat, 3 May 2025 06:59:40 +0000 (14:59 +0800)]
crimson/os/seastore/linked_tree_node: rename
`BaseChildNode::get_parent_node()` to
`BaseChildNode::peek_parent_node()`
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Wed, 23 Apr 2025 02:56:24 +0000 (10:56 +0800)]
crimson/os/seastore/cache: do seperated add_to_read_set steps for
initial pending and stable writing extents
Fixes: https://tracker.ceph.com/issues/70976
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Xuehan Xu [Wed, 23 Apr 2025 02:51:19 +0000 (10:51 +0800)]
crimson/os/seastore/transaction: add interfaces for seperated Transaction::do_add_to_read_set()
The current implementation of Transaction::do_add_to_read_set() can
be seperated into two steps:
1. attach the extent to the transaction, i.e. insert the extent into the
transaction's read_set
2. attach the transaction to the extent, i.e. insert the transaction
into the extent's read_transactions
For initial pending and stable writing extents, we need to do the second
step before doing "CachedExtent::wait_io()" and to do the first step
after "CachedExtent::wait_io()". This commit add interfaces
corresponding to those two steps.
Fixes: https://tracker.ceph.com/issues/70976
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Fri, 30 May 2025 01:40:41 +0000 (09:40 +0800)]
test/objectstore: fix memory leak test_bluestore_types.cc
Previously, we had memory leak in the test_bluestore_types.cc tests where
`BufferCacheShard` and `OnodeCacheShard` objects were allocated with
raw pointers but never freed, causing leaks detected by AddressSanitizer.
ASan rightly pointed this out:
```
Direct leak of 224 byte(s) in 1 object(s) allocated from:
#0 0x55a7432a079d in operator new(unsigned long) (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_bluestore_types+0xf2e79d) (BuildId:
c3bec647afa97df6bb147bc82eac937531fc6272 )
#1 0x55a743523340 in BlueStore::BufferCacheShard::create(BlueStore*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, ceph::common::PerfCounters*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/Bl
ueStore.cc:1678:9
#2 0x55a74330b617 in ExtentMap_seek_lextent_Test::TestBody() /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/objectstore/test_bluestore_types.cc:1077:7
#3 0x55a7434f2b2d in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.
cc:2653:10
#4 0x55a7434b5775 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:
2689:14
#5 0x55a74347005d in testing::Test::Run() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2728:5
```
```
Direct leak of 9928 byte(s) in 1 object(s) allocated from:
#0 0x7ff249d21a2d in operator new(unsigned long) /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_new_delete.cpp:86
#1 0x6048ed878b76 in BlueStore::OnodeCacheShard::create(ceph::common::CephContext*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, ceph::common::PerfCounters*) /home/kefu/dev/ceph/src/os/bluestore/BlueStore.cc:1219
#2 0x6048ed66d4f9 in GarbageCollector_BasicTest_Test::TestBody() /home/kefu/dev/ceph/src/test/objectstore/test_bluestore_types.cc:2662
#3 0x6048ed820555 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/kefu/dev/ceph/src/googletest/googletest/src/gtest.cc:2653
#4 0x6048ed80c78a in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/kefu/dev/ceph/src/googletest/googletest/src/gtest.cc:2689
#5 0x6048ed7b8bfa in testing::Test::Run() /home/kefu/dev/ceph/src/googletest/googletest/src/gtest.cc:2728
```
In this change, we replace raw pointer allocation with unique_ptr to
ensure automatic cleanup when the objects go out of scope.
`
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Dan Mick [Thu, 29 May 2025 22:10:15 +0000 (15:10 -0700)]
Merge pull request #63435 from phlogistonjohn/jjm-fix-dash-fix
dashboard: fix the workaround for unpacking node sources
Hezko [Thu, 29 May 2025 17:46:05 +0000 (20:46 +0300)]
Merge pull request #63410 from Hezko/nvmeof-cli-align-part-3
mgr/dashboard: align response of subsystem add and ns add with old cli
Alex [Thu, 29 May 2025 17:04:07 +0000 (13:04 -0400)]
Merge pull request #63412 from awojno-bloomberg/cephadm-optional-build
cephadm: add optional build flag
Jesse F. Williamson [Tue, 27 May 2025 17:44:43 +0000 (10:44 -0700)]
Improve Catch2 support by adding helper functions.
Makes it less tedious to add a new Catch2 test with CMake.
Signed-off-by: Jesse F. Williamson <jfw@ibm.com>
Matan Breizman [Thu, 29 May 2025 15:35:13 +0000 (18:35 +0300)]
Merge pull request #60428 from amathuria/wip-amat-add-pg-splitting-crimson
Crimson PG Splitting
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Mark Kogan [Thu, 29 May 2025 14:08:28 +0000 (17:08 +0300)]
Merge pull request #63381 from mkogan1/wip-d3n-test-stripe_size
rgw/d3n: fix teuthology run-datacache.sh FAIL when stripe_size!=4MiB
Zac Dover [Thu, 29 May 2025 12:56:12 +0000 (22:56 +1000)]
Merge pull request #63471 from zdover23/wip-doc-2025-05-26-mgr-prometheus-62782-followup
doc/mgr: edit prometheus.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Thu, 29 May 2025 12:54:42 +0000 (22:54 +1000)]
Merge pull request #63470 from zdover23/wip-doc-2025-05-26-mgr-progress-62782-followup
doc/mgr: edit progress.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Casey Bodley [Thu, 29 May 2025 12:41:52 +0000 (08:41 -0400)]
Merge pull request #63565 from cbodley/wip-backport-redmine-key
script: ceph-backport.sh adds redmine key to api requests
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Adam Kraitman <akraitma@redhat.com>